renderer.js 124 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewContainerElement from '../../src/view/containerelement';
  9. import ViewAttributeElement from '../../src/view/attributeelement';
  10. import ViewText from '../../src/view/text';
  11. import ViewRange from '../../src/view/range';
  12. import ViewPosition from '../../src/view/position';
  13. import UIElement from '../../src/view/uielement';
  14. import DocumentSelection from '../../src/view/documentselection';
  15. import DomConverter from '../../src/view/domconverter';
  16. import Renderer from '../../src/view/renderer';
  17. import DocumentFragment from '../../src/view/documentfragment';
  18. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  19. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  20. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  21. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  22. import createViewRoot from './_utils/createroot';
  23. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  24. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  25. testUtils.createSinonSandbox();
  26. describe( 'Renderer', () => {
  27. let selection, domConverter, renderer;
  28. beforeEach( () => {
  29. selection = new DocumentSelection();
  30. domConverter = new DomConverter();
  31. renderer = new Renderer( domConverter, selection );
  32. renderer.domDocuments.add( document );
  33. } );
  34. describe( 'markToSync', () => {
  35. let viewRoot;
  36. beforeEach( () => {
  37. viewRoot = new ViewElement( 'p' );
  38. const domRoot = document.createElement( 'p' );
  39. domConverter.bindElements( domRoot, viewRoot );
  40. viewRoot._appendChild( new ViewText( 'foo' ) );
  41. renderer.markedTexts.clear();
  42. renderer.markedAttributes.clear();
  43. renderer.markedChildren.clear();
  44. } );
  45. it( 'should mark attributes which need update', () => {
  46. viewRoot._setAttribute( 'class', 'foo' );
  47. renderer.markToSync( 'attributes', viewRoot );
  48. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  49. } );
  50. it( 'should mark children which need update', () => {
  51. viewRoot._appendChild( new ViewText( 'foo' ) );
  52. renderer.markToSync( 'children', viewRoot );
  53. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  54. } );
  55. it( 'should not mark children if element has no corresponding node', () => {
  56. // Overwrite viewRoot with node without coresponding DOM node.
  57. viewRoot = new ViewElement( 'p' );
  58. viewRoot._appendChild( new ViewText( 'foo' ) );
  59. renderer.markToSync( 'children', viewRoot );
  60. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  61. } );
  62. it( 'should mark text which need update', () => {
  63. const viewText = new ViewText( 'foo' );
  64. viewRoot._appendChild( viewText );
  65. viewText._data = 'bar';
  66. renderer.markToSync( 'text', viewText );
  67. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  68. } );
  69. it( 'should not mark text if parent has no corresponding node', () => {
  70. const viewText = new ViewText( 'foo' );
  71. // Overwrite viewRoot with node without coresponding DOM node.
  72. viewRoot = new ViewElement( 'p' );
  73. viewRoot._appendChild( viewText );
  74. viewText._data = 'bar';
  75. renderer.markToSync( 'text', viewText );
  76. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  77. } );
  78. it( 'should throw if the type is unknown', () => {
  79. expect( () => {
  80. renderer.markToSync( 'UNKNOWN', viewRoot );
  81. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  82. } );
  83. } );
  84. describe( 'render', () => {
  85. let viewRoot, domRoot, selectionEditable;
  86. beforeEach( () => {
  87. viewRoot = new ViewElement( 'div' );
  88. domRoot = document.createElement( 'div' );
  89. document.body.appendChild( domRoot );
  90. domConverter.bindElements( domRoot, viewRoot );
  91. renderer.markedTexts.clear();
  92. renderer.markedAttributes.clear();
  93. renderer.markedChildren.clear();
  94. selection._setTo( null );
  95. selectionEditable = viewRoot;
  96. renderer.isFocused = true;
  97. // Fake selection editable - it is needed to render selection properly.
  98. Object.defineProperty( selection, 'editableElement', {
  99. get() {
  100. return selectionEditable;
  101. }
  102. } );
  103. } );
  104. afterEach( () => {
  105. domRoot.remove();
  106. } );
  107. it( 'should update attributes', () => {
  108. viewRoot._setAttribute( 'class', 'foo' );
  109. renderer.markToSync( 'attributes', viewRoot );
  110. renderer.render();
  111. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  112. expect( renderer.markedAttributes.size ).to.equal( 0 );
  113. } );
  114. it( 'should remove attributes', () => {
  115. viewRoot._setAttribute( 'class', 'foo' );
  116. domRoot.setAttribute( 'id', 'bar' );
  117. domRoot.setAttribute( 'class', 'bar' );
  118. renderer.markToSync( 'attributes', viewRoot );
  119. renderer.render();
  120. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  121. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  122. expect( renderer.markedAttributes.size ).to.equal( 0 );
  123. } );
  124. it( 'should add children', () => {
  125. viewRoot._appendChild( new ViewText( 'foo' ) );
  126. renderer.markToSync( 'children', viewRoot );
  127. renderer.render();
  128. expect( domRoot.childNodes.length ).to.equal( 1 );
  129. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  130. expect( renderer.markedChildren.size ).to.equal( 0 );
  131. } );
  132. it( 'should remove children', () => {
  133. viewRoot._appendChild( new ViewText( 'foo' ) );
  134. renderer.markToSync( 'children', viewRoot );
  135. renderer.render();
  136. expect( domRoot.childNodes.length ).to.equal( 1 );
  137. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  138. viewRoot._removeChildren( 0, 1 );
  139. renderer.markToSync( 'children', viewRoot );
  140. renderer.render();
  141. expect( domRoot.childNodes.length ).to.equal( 0 );
  142. expect( renderer.markedChildren.size ).to.equal( 0 );
  143. } );
  144. it( 'should update text', () => {
  145. const viewText = new ViewText( 'foo' );
  146. viewRoot._appendChild( viewText );
  147. renderer.markToSync( 'children', viewRoot );
  148. renderer.render();
  149. expect( domRoot.childNodes.length ).to.equal( 1 );
  150. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  151. viewText._data = 'bar';
  152. renderer.markToSync( 'text', viewText );
  153. renderer.render();
  154. expect( domRoot.childNodes.length ).to.equal( 1 );
  155. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  156. expect( renderer.markedTexts.size ).to.equal( 0 );
  157. } );
  158. it( 'should not update same text', () => {
  159. const viewText = new ViewText( 'foo' );
  160. viewRoot._appendChild( viewText );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.render();
  163. expect( domRoot.childNodes.length ).to.equal( 1 );
  164. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  165. viewText._data = 'foo';
  166. renderer.markToSync( 'text', viewText );
  167. renderAndExpectNoChanges( renderer, domRoot );
  168. expect( domRoot.childNodes.length ).to.equal( 1 );
  169. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  170. expect( renderer.markedTexts.size ).to.equal( 0 );
  171. } );
  172. it( 'should not update text parent child list changed', () => {
  173. const viewImg = new ViewElement( 'img' );
  174. const viewText = new ViewText( 'foo' );
  175. viewRoot._appendChild( [ viewImg, viewText ] );
  176. renderer.markToSync( 'children', viewRoot );
  177. renderer.markToSync( 'text', viewText );
  178. renderer.render();
  179. expect( domRoot.childNodes.length ).to.equal( 2 );
  180. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  181. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  182. } );
  183. it( 'should not change text if it is the same during text rendering', () => {
  184. const viewText = new ViewText( 'foo' );
  185. viewRoot._appendChild( viewText );
  186. renderer.markToSync( 'children', viewRoot );
  187. renderer.render();
  188. // This should not be changed during the render.
  189. const domText = domRoot.childNodes[ 0 ];
  190. renderer.markToSync( 'text', viewText );
  191. renderer.render();
  192. expect( domRoot.childNodes.length ).to.equal( 1 );
  193. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  194. } );
  195. it( 'should not change text if it is the same during children rendering', () => {
  196. const viewText = new ViewText( 'foo' );
  197. viewRoot._appendChild( viewText );
  198. renderer.markToSync( 'children', viewRoot );
  199. renderer.render();
  200. // This should not be changed during the render.
  201. const domText = domRoot.childNodes[ 0 ];
  202. renderer.markToSync( 'children', viewRoot );
  203. renderer.render();
  204. expect( domRoot.childNodes.length ).to.equal( 1 );
  205. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  206. } );
  207. it( 'should not change element if it is the same', () => {
  208. const viewImg = new ViewElement( 'img' );
  209. viewRoot._appendChild( viewImg );
  210. // This should not be changed during the render.
  211. const domImg = document.createElement( 'img' );
  212. domRoot.appendChild( domImg );
  213. domConverter.bindElements( domImg, viewImg );
  214. renderer.markToSync( 'children', viewRoot );
  215. renderer.render();
  216. expect( domRoot.childNodes.length ).to.equal( 1 );
  217. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  218. } );
  219. it( 'should change element if it is different', () => {
  220. const viewImg = new ViewElement( 'img' );
  221. viewRoot._appendChild( viewImg );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. const viewP = new ViewElement( 'p' );
  225. viewRoot._removeChildren( 0, 1 );
  226. viewRoot._appendChild( viewP );
  227. renderer.markToSync( 'children', viewRoot );
  228. renderer.render();
  229. expect( domRoot.childNodes.length ).to.equal( 1 );
  230. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  231. } );
  232. it( 'should update removed item when it is reinserted', () => {
  233. const viewFoo = new ViewText( 'foo' );
  234. const viewP = new ViewElement( 'p', null, viewFoo );
  235. const viewDiv = new ViewElement( 'div', null, viewP );
  236. viewRoot._appendChild( viewDiv );
  237. renderer.markToSync( 'children', viewRoot );
  238. renderer.render();
  239. viewDiv._removeChildren( 0, 1 );
  240. renderer.markToSync( 'children', viewDiv );
  241. renderer.render();
  242. viewP._removeChildren( 0, 1 );
  243. viewDiv._appendChild( viewP );
  244. renderer.markToSync( 'children', viewDiv );
  245. renderer.render();
  246. expect( domRoot.childNodes.length ).to.equal( 1 );
  247. const domDiv = domRoot.childNodes[ 0 ];
  248. expect( domDiv.tagName ).to.equal( 'DIV' );
  249. expect( domDiv.childNodes.length ).to.equal( 1 );
  250. const domP = domDiv.childNodes[ 0 ];
  251. expect( domP.tagName ).to.equal( 'P' );
  252. expect( domP.childNodes.length ).to.equal( 0 );
  253. } );
  254. it( 'should update removed item when it is reinserted #2', () => {
  255. // Prepare view: root -> div "outer" -> div "inner" -> p.
  256. const viewP = new ViewElement( 'p' );
  257. const viewDivInner = new ViewElement( 'div', null, viewP );
  258. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  259. viewRoot._appendChild( viewDivOuter );
  260. // Render view tree to DOM.
  261. renderer.markToSync( 'children', viewRoot );
  262. renderer.render();
  263. // Remove div "outer" from root and render it.
  264. viewDivOuter._remove();
  265. renderer.markToSync( 'children', viewRoot );
  266. renderer.render();
  267. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  268. viewP._remove();
  269. // Add div "outer" back to root.
  270. viewRoot._appendChild( viewDivOuter );
  271. renderer.markToSync( 'children', viewRoot );
  272. // Render changes, view is: root -> div "outer" -> div "inner".
  273. renderer.render();
  274. // Same is expected in DOM.
  275. expect( domRoot.childNodes.length ).to.equal( 1 );
  276. const domDivOuter = domRoot.childNodes[ 0 ];
  277. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  278. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  279. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  280. const domDivInner = domDivOuter.childNodes[ 0 ];
  281. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  282. expect( domDivInner.tagName ).to.equal( 'DIV' );
  283. expect( domDivInner.childNodes.length ).to.equal( 0 );
  284. } );
  285. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  286. const viewFoo = new ViewText( 'foo' );
  287. const viewP = new ViewElement( 'p', null, viewFoo );
  288. const viewDiv = new ViewElement( 'div', null, viewP );
  289. viewRoot._appendChild( viewDiv );
  290. renderer.markToSync( 'children', viewRoot );
  291. renderer.render();
  292. viewRoot._removeChildren( 0, 1 );
  293. renderer.markToSync( 'children', viewRoot );
  294. viewDiv._removeChildren( 0, 1 );
  295. renderer.markToSync( 'children', viewDiv );
  296. viewP._removeChildren( 0, 1 );
  297. renderer.markToSync( 'children', viewP );
  298. renderer.render();
  299. expect( domRoot.childNodes.length ).to.equal( 0 );
  300. } );
  301. it( 'should not care about filler if there is no DOM', () => {
  302. selectionEditable = null;
  303. const { view: viewP, selection: newSelection } = parse(
  304. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  305. const viewRoot = new ViewElement( 'p' );
  306. viewRoot._appendChild( viewP );
  307. selection._setTo( newSelection );
  308. renderer.markToSync( 'children', viewRoot );
  309. renderer.render();
  310. // Expect no error on render.
  311. expect( viewRoot ).to.be.ok;
  312. } );
  313. it( 'should not add filler when inside contenteditable=false parent', () => {
  314. const { view: viewP, selection: newSelection } = parse(
  315. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  316. viewRoot._appendChild( viewP );
  317. selection._setTo( newSelection );
  318. renderer.markToSync( 'children', viewRoot );
  319. renderer.render();
  320. expect( domRoot.childNodes.length ).to.equal( 1 );
  321. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  322. const domP = domRoot.childNodes[ 0 ];
  323. expect( domP.childNodes.length ).to.equal( 3 );
  324. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  325. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  326. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  327. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  328. } );
  329. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  330. const { view: viewP, selection: newSelection } = parse(
  331. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  332. viewRoot._appendChild( viewP );
  333. selection._setTo( newSelection );
  334. renderer.markToSync( 'children', viewRoot );
  335. renderer.render();
  336. expect( domRoot.childNodes.length ).to.equal( 1 );
  337. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  338. const domP = domRoot.childNodes[ 0 ];
  339. expect( domP.childNodes.length ).to.equal( 3 );
  340. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  341. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  342. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  343. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  344. } );
  345. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  346. const domSelection = document.getSelection();
  347. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  348. const { view: viewP, selection: newSelection } = parse(
  349. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  350. viewRoot._appendChild( viewP );
  351. selection._setTo( newSelection );
  352. renderer.markToSync( 'children', viewRoot );
  353. renderer.render();
  354. expect( domRoot.childNodes.length ).to.equal( 1 );
  355. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  356. const domP = domRoot.childNodes[ 0 ];
  357. expect( domP.childNodes.length ).to.equal( 3 );
  358. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  359. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  360. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  361. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  362. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  363. expect( domSelection.rangeCount ).to.equal( 1 );
  364. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  365. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  366. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  367. // Step 2: No mutation on second render
  368. renderer.markToSync( 'children', viewRoot );
  369. renderer.markToSync( 'children', viewP );
  370. renderAndExpectNoChanges( renderer, domRoot );
  371. // Step 3: <p>foo{}<b></b></p>
  372. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  373. renderer.render();
  374. expect( domP.childNodes.length ).to.equal( 3 );
  375. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  376. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  377. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  378. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  379. expect( domSelection.rangeCount ).to.equal( 1 );
  380. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  381. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  382. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  383. // Step 4: No mutation on second render
  384. renderer.markToSync( 'children', viewRoot );
  385. renderer.markToSync( 'children', viewP );
  386. renderAndExpectNoChanges( renderer, domRoot );
  387. } );
  388. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  389. const domSelection = document.getSelection();
  390. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  391. const { view: viewP, selection: newSelection } = parse(
  392. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  393. viewRoot._appendChild( viewP );
  394. selection._setTo( newSelection );
  395. renderer.markToSync( 'children', viewRoot );
  396. renderer.render();
  397. const domP = domRoot.childNodes[ 0 ];
  398. expect( domP.childNodes.length ).to.equal( 2 );
  399. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  400. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  401. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  402. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  403. expect( domSelection.rangeCount ).to.equal( 1 );
  404. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  405. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  406. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  407. // Step 2: No mutation on second render
  408. renderer.markToSync( 'children', viewP );
  409. renderAndExpectNoChanges( renderer, domRoot );
  410. // Step 3: <p><b>{}foo</b></p>
  411. selection._setTo( ViewRange.createFromParentsAndOffsets(
  412. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  413. renderer.render();
  414. expect( domP.childNodes.length ).to.equal( 1 );
  415. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  416. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  417. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  418. expect( domSelection.rangeCount ).to.equal( 1 );
  419. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  420. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  421. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  422. // Step 4: No mutation on second render
  423. renderer.markToSync( 'children', viewP );
  424. renderAndExpectNoChanges( renderer, domRoot );
  425. } );
  426. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  427. const domSelection = document.getSelection();
  428. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  429. const { view: viewP, selection: newSelection } = parse(
  430. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  431. viewRoot._appendChild( viewP );
  432. selection._setTo( newSelection );
  433. renderer.markToSync( 'children', viewRoot );
  434. renderer.render();
  435. const domP = domRoot.childNodes[ 0 ];
  436. expect( domP.childNodes.length ).to.equal( 2 );
  437. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  438. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  439. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  440. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  441. expect( domSelection.rangeCount ).to.equal( 1 );
  442. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  443. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  444. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  445. // Step 2: No mutation on second render
  446. renderer.markToSync( 'children', viewP );
  447. renderAndExpectNoChanges( renderer, domRoot );
  448. // Step 3: <p><b>foo{}</b></p>
  449. selection._setTo( ViewRange.createFromParentsAndOffsets(
  450. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  451. renderer.render();
  452. expect( domP.childNodes.length ).to.equal( 1 );
  453. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  454. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  455. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  456. expect( domSelection.rangeCount ).to.equal( 1 );
  457. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  458. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  459. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  460. // Step 4: No mutation on second render
  461. renderer.markToSync( 'children', viewP );
  462. renderAndExpectNoChanges( renderer, domRoot );
  463. } );
  464. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  465. const domSelection = document.getSelection();
  466. const { view: viewP, selection: newSelection } = parse(
  467. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  468. viewRoot._appendChild( viewP );
  469. selection._setTo( newSelection );
  470. renderer.markToSync( 'children', viewRoot );
  471. renderer.render();
  472. const domP = domRoot.childNodes[ 0 ];
  473. expect( domP.childNodes.length ).to.equal( 3 );
  474. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  475. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  476. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  477. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  478. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  479. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  480. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  481. expect( domSelection.rangeCount ).to.equal( 1 );
  482. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  483. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  484. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  485. } );
  486. it( 'should move filler when selection is moved', () => {
  487. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  488. const { view: viewP, selection: newSelection } = parse(
  489. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  490. viewRoot._appendChild( viewP );
  491. selection._setTo( newSelection );
  492. renderer.markToSync( 'children', viewRoot );
  493. renderer.render();
  494. const domP = domRoot.childNodes[ 0 ];
  495. expect( domP.childNodes.length ).to.equal( 3 );
  496. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  497. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  498. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  499. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  500. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  501. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  502. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  503. const viewI = viewP.getChild( 2 );
  504. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  505. renderer.render();
  506. expect( domP.childNodes.length ).to.equal( 3 );
  507. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  508. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  509. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  510. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  511. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  512. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  513. } );
  514. it( 'should remove filler when text is added and selection removed', () => {
  515. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  516. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  517. const viewB = viewP.getChild( 1 );
  518. viewRoot._appendChild( viewP );
  519. selection._setTo( newSelection );
  520. renderer.markToSync( 'children', viewRoot );
  521. renderer.render();
  522. const domP = domRoot.childNodes[ 0 ];
  523. expect( domP.childNodes.length ).to.equal( 2 );
  524. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  525. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  526. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  527. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  528. // Step 2: Add text node.
  529. const viewText = new ViewText( 'x' );
  530. viewB._appendChild( viewText );
  531. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  532. renderer.markToSync( 'children', viewB );
  533. renderer.render();
  534. // Step 3: Remove selection from the view.
  535. selection._setTo( null );
  536. renderer.render();
  537. expect( domP.childNodes.length ).to.equal( 2 );
  538. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  539. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  540. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  541. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  542. } );
  543. // #659
  544. // The element before the filler is removed so the position of the filler
  545. // cannot be remembered as parent+offset.
  546. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  547. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  548. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  549. viewRoot._appendChild( viewP );
  550. selection._setTo( newSelection );
  551. renderer.markToSync( 'children', viewRoot );
  552. renderer.render();
  553. const domP = domRoot.childNodes[ 0 ];
  554. expect( domP.childNodes.length ).to.equal( 3 );
  555. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  556. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  557. viewP._removeChildren( 1 );
  558. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  559. renderer.markToSync( 'children', viewP );
  560. renderer.render();
  561. // Step 3: Check whether there's no filler in the DOM.
  562. expect( domP.childNodes.length ).to.equal( 1 );
  563. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  564. } );
  565. // #659
  566. it( 'should remove filler from a modified DOM when children moved', () => {
  567. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  568. const { view: viewFragment, selection: newSelection } = parse(
  569. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  570. );
  571. viewRoot._appendChild( viewFragment );
  572. selection._setTo( newSelection );
  573. renderer.markToSync( 'children', viewRoot );
  574. renderer.render();
  575. expect( domRoot.childNodes.length ).to.equal( 2 );
  576. const domP = domRoot.childNodes[ 0 ];
  577. const domP2 = domRoot.childNodes[ 1 ];
  578. expect( domP.childNodes.length ).to.equal( 3 );
  579. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  580. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  581. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  582. const viewP = viewRoot.getChild( 0 );
  583. const viewP2 = viewRoot.getChild( 1 );
  584. const removedChildren = viewP._removeChildren( 0, 2 );
  585. viewP2._appendChild( removedChildren );
  586. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  587. renderer.markToSync( 'children', viewP );
  588. renderer.markToSync( 'children', viewP2 );
  589. renderer.render();
  590. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  591. // in the second one there are two <b> tags.
  592. expect( domP.childNodes.length ).to.equal( 1 );
  593. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  594. expect( domP2.childNodes.length ).to.equal( 2 );
  595. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  596. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  597. } );
  598. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  599. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  600. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  601. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  602. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  603. viewRoot._appendChild( viewP );
  604. selection._setTo( newSelection );
  605. renderer.markToSync( 'children', viewRoot );
  606. renderer.render();
  607. const domP = domRoot.childNodes[ 0 ];
  608. expect( domP.childNodes.length ).to.equal( 2 );
  609. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  610. // Step 2: Move selection to a new attribute element and remove the previous one
  611. viewP._removeChildren( 1 ); // Remove <b>.
  612. const viewI = parse( '<attribute:i></attribute:i>' );
  613. viewP._appendChild( viewI );
  614. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  615. renderer.markToSync( 'children', viewP );
  616. renderer.render();
  617. // Step 3: Check whether new filler was created in the <i> element.
  618. expect( domP.childNodes.length ).to.equal( 2 );
  619. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  620. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  621. } );
  622. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  623. // that has not been yet rendered/bound to DOM.
  624. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  625. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  626. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  627. viewRoot._appendChild( viewP );
  628. selection._setTo( newSelection );
  629. renderer.markToSync( 'children', viewRoot );
  630. renderer.render();
  631. const domP = domRoot.childNodes[ 0 ];
  632. expect( domP.childNodes.length ).to.equal( 3 );
  633. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  634. // Step 2: Move selection to a new attribute element.
  635. const viewAbc = parse( 'abc' );
  636. viewP._appendChild( viewAbc );
  637. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  638. renderer.markToSync( 'children', viewP );
  639. renderer.render();
  640. // Step 3: Check whether old filler was removed.
  641. expect( domP.childNodes.length ).to.equal( 3 );
  642. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  643. } );
  644. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  645. const domSelection = document.getSelection();
  646. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  647. viewRoot._appendChild( viewP );
  648. selection._setTo( newSelection );
  649. renderer.markToSync( 'children', viewRoot );
  650. renderer.render();
  651. const domP = domRoot.childNodes[ 0 ];
  652. expect( domP.childNodes.length ).to.equal( 1 );
  653. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  654. expect( domSelection.rangeCount ).to.equal( 1 );
  655. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  656. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  657. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  658. // Remove filler and add text node to both DOM and View <p>x{}</p>
  659. domP.removeChild( domP.childNodes[ 0 ] );
  660. domP.appendChild( document.createTextNode( 'x' ) );
  661. domSelection.removeAllRanges();
  662. const domRange = document.createRange();
  663. domRange.setStart( domP.childNodes[ 0 ], 1 );
  664. domRange.collapse( true );
  665. domSelection.addRange( domRange );
  666. const viewText = new ViewText( 'x' );
  667. viewP._appendChild( viewText );
  668. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  669. renderer.markToSync( 'children', viewP );
  670. renderAndExpectNoChanges( renderer, domRoot );
  671. } );
  672. it( 'should handle typing in empty block, render if needed', () => {
  673. const domSelection = document.getSelection();
  674. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  675. viewRoot._appendChild( viewP );
  676. selection._setTo( newSelection );
  677. renderer.markToSync( 'children', viewRoot );
  678. renderer.render();
  679. const domP = domRoot.childNodes[ 0 ];
  680. expect( domP.childNodes.length ).to.equal( 1 );
  681. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  682. expect( domSelection.rangeCount ).to.equal( 1 );
  683. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  684. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  685. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  686. // Add text node only in View <p>x{}</p>
  687. const viewText = new ViewText( 'x' );
  688. viewP._appendChild( viewText );
  689. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  690. renderer.markToSync( 'children', viewP );
  691. renderer.render();
  692. expect( domP.childNodes.length ).to.equal( 1 );
  693. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  694. expect( domSelection.rangeCount ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  696. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  697. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  698. } );
  699. it( 'should handle removing last character', () => {
  700. const domSelection = document.getSelection();
  701. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  702. viewRoot._appendChild( viewP );
  703. selection._setTo( newSelection );
  704. renderer.markToSync( 'children', viewRoot );
  705. renderer.render();
  706. const domP = domRoot.childNodes[ 0 ];
  707. expect( domP.childNodes.length ).to.equal( 1 );
  708. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  709. expect( domSelection.rangeCount ).to.equal( 1 );
  710. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  711. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  712. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  713. // Remove text and add filler to both DOM and View <p>{}</p>
  714. domP.removeChild( domP.childNodes[ 0 ] );
  715. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  716. domSelection.removeAllRanges();
  717. const domRange = document.createRange();
  718. domRange.setStart( domP.childNodes[ 0 ], 0 );
  719. domRange.collapse( true );
  720. domSelection.addRange( domRange );
  721. viewP._removeChildren( 0 );
  722. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  723. renderer.markToSync( 'children', viewP );
  724. renderAndExpectNoChanges( renderer, domRoot );
  725. } );
  726. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  727. const domSelection = document.getSelection();
  728. // 1. Render <p><b>FILLER{}</b>foo</p>.
  729. const { view: viewP, selection: newSelection } = parse(
  730. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  731. viewRoot._appendChild( viewP );
  732. selection._setTo( newSelection );
  733. renderer.markToSync( 'children', viewRoot );
  734. renderer.render();
  735. // 2. Check the DOM.
  736. const domP = domRoot.childNodes[ 0 ];
  737. expect( domP.childNodes.length ).to.equal( 2 );
  738. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  739. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  740. const domB = domP.childNodes[ 0 ];
  741. const viewB = viewP.getChild( 0 );
  742. expect( domB.childNodes.length ).to.equal( 1 );
  743. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  744. expect( domSelection.rangeCount ).to.equal( 1 );
  745. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  746. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  747. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  748. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  749. domB.childNodes[ 0 ].data += 'x';
  750. domSelection.removeAllRanges();
  751. const domRange = document.createRange();
  752. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  753. domRange.collapse( true );
  754. domSelection.addRange( domRange );
  755. const viewText = new ViewText( 'x' );
  756. viewB._appendChild( viewText );
  757. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  758. renderer.markToSync( 'children', viewP );
  759. renderAndExpectNoChanges( renderer, domRoot );
  760. } );
  761. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  762. const domSelection = document.getSelection();
  763. // 1. Render <p><b>FILLER{}</b>foo</p>.
  764. const { view: viewP, selection: newSelection } = parse(
  765. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  766. viewRoot._appendChild( viewP );
  767. selection._setTo( newSelection );
  768. renderer.markToSync( 'children', viewRoot );
  769. renderer.render();
  770. // 2. Check the DOM.
  771. const domP = domRoot.childNodes[ 0 ];
  772. expect( domP.childNodes.length ).to.equal( 2 );
  773. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  774. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  775. const domB = domP.childNodes[ 0 ];
  776. const viewB = viewP.getChild( 0 );
  777. expect( domB.childNodes.length ).to.equal( 1 );
  778. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  779. expect( domSelection.rangeCount ).to.equal( 1 );
  780. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  781. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  782. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  783. domSelection.removeAllRanges();
  784. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  785. const viewText = new ViewText( 'x' );
  786. viewB._appendChild( viewText );
  787. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  788. renderer.markToSync( 'children', viewB );
  789. renderer.render();
  790. expect( domB.childNodes.length ).to.equal( 1 );
  791. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  792. expect( domSelection.rangeCount ).to.equal( 1 );
  793. // Depending on the browser selection may end up at the end of the text node or after the text node.
  794. const firstRange = domSelection.getRangeAt( 0 );
  795. const assertSelectionAtEndOfTextNode = () => {
  796. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  797. };
  798. const assertSelectionInsideTextNode = () => {
  799. expect( firstRange.startContainer ).to.equal( domB );
  800. expect( firstRange.startOffset ).to.equal( 1 );
  801. };
  802. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  803. expect( firstRange.collapsed ).to.be.true;
  804. } );
  805. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  806. const domSelection = document.getSelection();
  807. // 1. Render <p><b>FILLER{}</b>foo</p>.
  808. const { view: viewP, selection: newSelection } = parse(
  809. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  810. viewRoot._appendChild( viewP );
  811. selection._setTo( newSelection );
  812. renderer.markToSync( 'children', viewRoot );
  813. renderer.render();
  814. // 2. Check the DOM.
  815. const domP = domRoot.childNodes[ 0 ];
  816. expect( domP.childNodes.length ).to.equal( 2 );
  817. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  818. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  819. const domB = domP.childNodes[ 0 ];
  820. const viewB = viewP.getChild( 0 );
  821. expect( domB.childNodes.length ).to.equal( 1 );
  822. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  823. expect( domSelection.rangeCount ).to.equal( 1 );
  824. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  825. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  826. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  827. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  828. const viewText = new ViewText( 'x' );
  829. viewB._appendChild( viewText );
  830. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  831. renderer.markToSync( 'text', viewText );
  832. renderer.render();
  833. // 4. Check the DOM.
  834. expect( domB.childNodes.length ).to.equal( 1 );
  835. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  836. expect( domSelection.rangeCount ).to.equal( 1 );
  837. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  838. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  839. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  840. } );
  841. it( 'should handle not collapsed range', () => {
  842. const domSelection = document.getSelection();
  843. const { view: viewP, selection: newSelection } = parse(
  844. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  845. viewRoot._appendChild( viewP );
  846. selection._setTo( newSelection );
  847. renderer.markToSync( 'children', viewRoot );
  848. renderer.render();
  849. const domP = domRoot.childNodes[ 0 ];
  850. expect( domP.childNodes.length ).to.equal( 2 );
  851. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  852. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  853. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  854. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  855. expect( domSelection.rangeCount ).to.equal( 1 );
  856. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  857. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  858. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  859. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  860. renderer.markToSync( 'children', viewP );
  861. renderAndExpectNoChanges( renderer, domRoot );
  862. } );
  863. it( 'should not change selection if there is no editable with selection', () => {
  864. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  865. document.body.appendChild( domDiv );
  866. domDiv.focus();
  867. const domSelection = document.getSelection();
  868. domSelection.removeAllRanges();
  869. domSelection.collapse( domDiv, 0 );
  870. selectionEditable = null;
  871. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  872. viewRoot._appendChild( viewP );
  873. selection._setTo( newSelection );
  874. renderer.render();
  875. expect( domSelection.rangeCount ).to.equal( 1 );
  876. // Depending on the browser selection may end up before the text node or at the beginning of it.
  877. const domRange = domSelection.getRangeAt( 0 );
  878. const assertSelectionAtEndOfTextNode = () => {
  879. expect( domRange.startContainer ).to.equal( domDiv );
  880. };
  881. const assertSelectionInsideTextNode = () => {
  882. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  883. };
  884. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  885. expect( domRange.startOffset ).to.equal( 0 );
  886. expect( domRange.collapsed ).to.be.true;
  887. domDiv.remove();
  888. } );
  889. it( 'should not change selection if there is no focus', () => {
  890. const domDiv = createElement( document, 'div', null, 'not editable' );
  891. document.body.appendChild( domDiv );
  892. const domSelection = document.getSelection();
  893. domSelection.removeAllRanges();
  894. const domRange = document.createRange();
  895. domRange.setStart( domDiv, 0 );
  896. domRange.collapse( true );
  897. domSelection.addRange( domRange );
  898. renderer.isFocused = false;
  899. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  900. viewRoot._appendChild( viewP );
  901. selection._setTo( newSelection );
  902. renderer.render();
  903. expect( domSelection.rangeCount ).to.equal( 1 );
  904. // Depending on the browser selection may end up before the text node or at the beginning of it.
  905. const domSelectionRange = domSelection.getRangeAt( 0 );
  906. const assertSelectionAtEndOfTextNode = () => {
  907. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  908. };
  909. const assertSelectionInsideTextNode = () => {
  910. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  911. };
  912. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  913. expect( domSelectionRange.startOffset ).to.equal( 0 );
  914. expect( domSelectionRange.collapsed ).to.be.true;
  915. domDiv.remove();
  916. } );
  917. it( 'should not add inline filler after text node', () => {
  918. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  919. viewRoot._appendChild( viewP );
  920. selection._setTo( newSelection );
  921. renderer.markToSync( 'children', viewRoot );
  922. renderer.render();
  923. const domP = domRoot.childNodes[ 0 ];
  924. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  925. } );
  926. it( 'should throw if there is no filler in expected position', () => {
  927. const { view: viewP, selection: newSelection } = parse(
  928. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  929. viewRoot._appendChild( viewP );
  930. selection._setTo( newSelection );
  931. renderer.markToSync( 'children', viewRoot );
  932. renderer.render();
  933. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  934. const viewB = viewP.getChild( 1 );
  935. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  936. // Remove filler.
  937. domB.childNodes[ 0 ].data = '';
  938. selection._setTo( null );
  939. renderer.markToSync( 'children', viewB );
  940. expect( () => {
  941. renderer.render();
  942. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  943. } );
  944. // #1014.
  945. it( 'should create inline filler in newly created dom nodes', () => {
  946. // 1. Create the view structure which needs inline filler.
  947. const inputView =
  948. '<container:ul>' +
  949. '<container:li>Foobar.</container:li>' +
  950. '<container:li>[]<container:div></container:div></container:li>' +
  951. '</container:ul>';
  952. const { view: view, selection: newSelection } = parse( inputView );
  953. viewRoot._appendChild( view );
  954. selection._setTo( newSelection );
  955. renderer.markToSync( 'children', viewRoot );
  956. renderer.render();
  957. // 2. Check if filler element has been (correctly) created.
  958. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  959. // 3. Move the inline filler parent to a newly created element.
  960. const viewLi = view.getChild( 0 );
  961. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  962. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  963. viewLi._appendChild( viewUl );
  964. // 4. Mark changed items and render the view.
  965. renderer.markToSync( 'children', view );
  966. renderer.markToSync( 'children', viewLi );
  967. renderer.render();
  968. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  969. const domSelection = document.getSelection();
  970. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  971. } );
  972. it( 'should handle focusing element', () => {
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. const editable = selection.editableElement;
  975. renderer.render();
  976. expect( editable ).to.equal( viewRoot );
  977. expect( domFocusSpy.calledOnce ).to.be.true;
  978. } );
  979. it( 'should not focus editable if isFocues is set to false', () => {
  980. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  981. renderer.isFocused = false;
  982. renderer.render();
  983. expect( domFocusSpy.calledOnce ).to.be.false;
  984. } );
  985. it( 'should not focus already focused DOM element', () => {
  986. domRoot.setAttribute( 'contentEditable', true );
  987. domRoot.focus();
  988. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  989. renderer.render();
  990. expect( domFocusSpy.called ).to.be.false;
  991. } );
  992. it( 'should render NBSP as first space in inline element after another space', () => {
  993. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  994. viewRoot._appendChild( viewP );
  995. renderer.markToSync( 'children', viewRoot );
  996. renderer.render();
  997. const domP = domRoot.childNodes[ 0 ];
  998. const domB = domP.childNodes[ 1 ];
  999. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1000. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1001. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1002. // Insert space resulting in '<p>x <b> y</b></p>'.
  1003. const viewB = viewP.getChild( 1 );
  1004. viewB._removeChildren( 0 );
  1005. viewB._appendChild( new ViewText( ' y' ) );
  1006. renderer.markToSync( 'children', viewP );
  1007. renderer.render();
  1008. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1009. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1010. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1011. } );
  1012. it( 'should update sibling after, when node before is removed', () => {
  1013. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1014. viewRoot._appendChild( viewP );
  1015. renderer.markToSync( 'children', viewRoot );
  1016. renderer.render();
  1017. const domP = domRoot.childNodes[ 0 ];
  1018. const domB = domP.childNodes[ 1 ];
  1019. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1020. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1021. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1022. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1023. viewP._removeChildren( 0 );
  1024. renderer.markToSync( 'children', viewP );
  1025. renderer.render();
  1026. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1027. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1028. } );
  1029. it( 'should update sibling before, when node after is removed', () => {
  1030. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1031. viewRoot._appendChild( viewP );
  1032. renderer.markToSync( 'children', viewRoot );
  1033. renderer.render();
  1034. const domP = domRoot.childNodes[ 0 ];
  1035. const domB = domP.childNodes[ 1 ];
  1036. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1037. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1038. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1039. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1040. viewP._removeChildren( 1 );
  1041. renderer.markToSync( 'children', viewP );
  1042. renderer.render();
  1043. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1044. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1045. } );
  1046. // #1093
  1047. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1048. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1049. viewRoot._appendChild( viewP );
  1050. renderer.markToSync( 'children', viewRoot );
  1051. renderer.render();
  1052. const domP = domRoot.childNodes[ 0 ];
  1053. const domB = domP.childNodes[ 1 ];
  1054. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1055. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1056. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1057. // Insert space resulting in '<p>x <b> y</b></p>'.
  1058. viewP._removeChildren( 0 );
  1059. viewP._insertChild( 0, new ViewText( 'x ' ) );
  1060. renderer.markToSync( 'children', viewP );
  1061. renderer.render();
  1062. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1063. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1064. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1065. } );
  1066. // #1093
  1067. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1068. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1069. viewRoot._appendChild( viewP );
  1070. renderer.markToSync( 'children', viewRoot );
  1071. renderer.render();
  1072. const domP = domRoot.childNodes[ 0 ];
  1073. const domB = domP.childNodes[ 0 ];
  1074. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1075. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1076. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1077. // Insert space resulting in '<p><b>x </b> y</p>'.
  1078. const viewB = viewP.getChild( 0 );
  1079. viewB._removeChildren( 0 );
  1080. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1081. renderer.markToSync( 'children', viewP );
  1082. renderer.render();
  1083. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1084. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1085. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1086. } );
  1087. // #1093
  1088. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1089. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1090. viewRoot._appendChild( viewP );
  1091. renderer.markToSync( 'children', viewRoot );
  1092. renderer.render();
  1093. const domP = domRoot.childNodes[ 0 ];
  1094. const domB = domP.childNodes[ 0 ];
  1095. const domI = domP.childNodes[ 1 ];
  1096. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1097. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1098. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1099. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1100. const viewB = viewP.getChild( 0 );
  1101. viewB._removeChildren( 0 );
  1102. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1103. renderer.markToSync( 'children', viewP );
  1104. renderer.render();
  1105. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1106. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1107. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1108. } );
  1109. // #1125
  1110. it( 'should properly rerender many changes done in one batch', () => {
  1111. // This test transforms:
  1112. //
  1113. // <h2>He<strong>ding 1</strong></h2>
  1114. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1115. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1116. //
  1117. // into:
  1118. //
  1119. // <h2>Heading 2</h2>
  1120. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1121. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1122. //
  1123. // during one rerender to check if complex structure changes are rerendered correctly.
  1124. const viewContent = parse( '' +
  1125. '<container:h2>He' +
  1126. '<attribute:i>ading 1</attribute:i>' +
  1127. '</container:h2>' +
  1128. '<container:p>Ph ' +
  1129. '<attribute:strong>Bold</attribute:strong> ' +
  1130. '<attribute:i>It' +
  1131. '<attribute:strong>alic</attribute:strong>' +
  1132. '</attribute:i> ' +
  1133. '<attribute:a href="https://ckeditor.com">' +
  1134. '<attribute:strong>Lin</attribute:strong>' +
  1135. 'k</attribute:a>' +
  1136. '</container:p>' +
  1137. '<container:blockquote>' +
  1138. '<container:ul>' +
  1139. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1140. '</container:ul>' +
  1141. '</container:blockquote>' );
  1142. viewRoot._appendChild( viewContent );
  1143. renderer.markToSync( 'children', viewRoot );
  1144. renderer.render();
  1145. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1146. const viewHeading = viewRoot.getChild( 0 );
  1147. viewHeading._removeChildren( 0, viewHeading.childCount );
  1148. viewHeading._insertChild( 0, new ViewText( 'Heading 2' ) );
  1149. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1150. renderer.markToSync( 'children', viewRoot );
  1151. renderer.markToSync( 'children', viewHeading );
  1152. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1153. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1154. // ->
  1155. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1156. const viewP = viewRoot.getChild( 1 );
  1157. viewP._removeChildren( 0, viewP.childCount );
  1158. viewP._insertChild(
  1159. 0,
  1160. parse(
  1161. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1162. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1163. )
  1164. );
  1165. renderer.markToSync( 'children', viewRoot );
  1166. renderer.markToSync( 'children', viewP );
  1167. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1168. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1169. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1170. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1171. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1172. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1173. const viewBq = viewRoot.getChild( 2 );
  1174. viewBq._removeChildren( 0, viewBq.childCount );
  1175. viewBq._insertChild(
  1176. 0,
  1177. parse(
  1178. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1179. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1180. )
  1181. );
  1182. renderer.markToSync( 'children', viewRoot );
  1183. renderer.markToSync( 'children', viewBq );
  1184. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1185. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1186. renderer.render();
  1187. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1188. '<h2>Heading 2</h2>' +
  1189. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1190. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1191. );
  1192. } );
  1193. // #1125
  1194. it( 'should properly rerender changes when whole content replaced at once', () => {
  1195. // This test replaces:
  1196. //
  1197. // <h1>Header</h1>
  1198. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1199. //
  1200. // with:
  1201. //
  1202. // <h2>Header</h2>
  1203. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1204. //
  1205. // during one rerender to check if complex structure changes are rerendered correctly.
  1206. const viewContent = parse(
  1207. '<container:h1>Header</container:h1>' +
  1208. '<container:blockquote>' +
  1209. '<container:ul>' +
  1210. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1211. '<container:li>Item 2</container:li>' +
  1212. '</container:ul>' +
  1213. '</container:blockquote>'
  1214. );
  1215. viewRoot._appendChild( viewContent );
  1216. renderer.markToSync( 'children', viewRoot );
  1217. renderer.render();
  1218. const newViewContent = parse(
  1219. '<container:h2>Header</container:h2>' +
  1220. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1221. );
  1222. viewRoot._removeChildren( 0, viewRoot.childCount );
  1223. viewRoot._appendChild( newViewContent );
  1224. renderer.markToSync( 'children', viewRoot );
  1225. renderer.render();
  1226. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1227. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1228. );
  1229. } );
  1230. describe( 'fake selection', () => {
  1231. beforeEach( () => {
  1232. const { view: viewP, selection: newSelection } = parse(
  1233. '<container:p>[foo bar]</container:p>'
  1234. );
  1235. viewRoot._appendChild( viewP );
  1236. selection._setTo( newSelection );
  1237. renderer.markToSync( 'children', viewRoot );
  1238. renderer.render();
  1239. } );
  1240. it( 'should render fake selection', () => {
  1241. const label = 'fake selection label';
  1242. selection._setTo( selection.getRanges(), { fake: true, label } );
  1243. renderer.render();
  1244. expect( domRoot.childNodes.length ).to.equal( 2 );
  1245. const container = domRoot.childNodes[ 1 ];
  1246. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1247. expect( container.childNodes.length ).to.equal( 1 );
  1248. const textNode = container.childNodes[ 0 ];
  1249. expect( textNode.textContent ).to.equal( label );
  1250. const domSelection = domRoot.ownerDocument.getSelection();
  1251. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1252. } );
  1253. it( 'should render &nbsp; if no selection label is provided', () => {
  1254. selection._setTo( selection.getRanges(), { fake: true } );
  1255. renderer.render();
  1256. expect( domRoot.childNodes.length ).to.equal( 2 );
  1257. const container = domRoot.childNodes[ 1 ];
  1258. expect( container.childNodes.length ).to.equal( 1 );
  1259. const textNode = container.childNodes[ 0 ];
  1260. expect( textNode.textContent ).to.equal( '\u00A0' );
  1261. const domSelection = domRoot.ownerDocument.getSelection();
  1262. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1263. } );
  1264. it( 'should remove fake selection container when selection is no longer fake', () => {
  1265. selection._setTo( selection.getRanges(), { fake: true } );
  1266. renderer.render();
  1267. selection._setTo( selection.getRanges(), { fake: false } );
  1268. renderer.render();
  1269. expect( domRoot.childNodes.length ).to.equal( 1 );
  1270. const domParagraph = domRoot.childNodes[ 0 ];
  1271. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1272. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1273. const domSelection = domRoot.ownerDocument.getSelection();
  1274. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1275. } );
  1276. it( 'should reuse fake selection container #1', () => {
  1277. const label = 'fake selection label';
  1278. selection._setTo( selection.getRanges(), { fake: true, label } );
  1279. renderer.render();
  1280. expect( domRoot.childNodes.length ).to.equal( 2 );
  1281. const container = domRoot.childNodes[ 1 ];
  1282. selection._setTo( selection.getRanges(), { fake: true, label } );
  1283. renderer.render();
  1284. expect( domRoot.childNodes.length ).to.equal( 2 );
  1285. const newContainer = domRoot.childNodes[ 1 ];
  1286. expect( newContainer ).equals( container );
  1287. expect( newContainer.childNodes.length ).to.equal( 1 );
  1288. const textNode = newContainer.childNodes[ 0 ];
  1289. expect( textNode.textContent ).to.equal( label );
  1290. } );
  1291. it( 'should reuse fake selection container #2', () => {
  1292. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1293. renderer.render();
  1294. expect( domRoot.childNodes.length ).to.equal( 2 );
  1295. const container = domRoot.childNodes[ 1 ];
  1296. selection._setTo( selection.getRanges(), { fake: false } );
  1297. renderer.render();
  1298. expect( domRoot.childNodes.length ).to.equal( 1 );
  1299. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1300. renderer.render();
  1301. expect( domRoot.childNodes.length ).to.equal( 2 );
  1302. const newContainer = domRoot.childNodes[ 1 ];
  1303. expect( newContainer ).equals( container );
  1304. expect( newContainer.childNodes.length ).to.equal( 1 );
  1305. const textNode = newContainer.childNodes[ 0 ];
  1306. expect( textNode.textContent ).to.equal( 'label 2' );
  1307. } );
  1308. it( 'should reuse fake selection container #3', () => {
  1309. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1310. renderer.render();
  1311. expect( domRoot.childNodes.length ).to.equal( 2 );
  1312. const container = domRoot.childNodes[ 1 ];
  1313. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1314. renderer.render();
  1315. expect( domRoot.childNodes.length ).to.equal( 2 );
  1316. const newContainer = domRoot.childNodes[ 1 ];
  1317. expect( newContainer ).equals( container );
  1318. expect( newContainer.childNodes.length ).to.equal( 1 );
  1319. const textNode = newContainer.childNodes[ 0 ];
  1320. expect( textNode.textContent ).to.equal( 'label 2' );
  1321. } );
  1322. it( 'should style fake selection container properly', () => {
  1323. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1324. renderer.render();
  1325. expect( domRoot.childNodes.length ).to.equal( 2 );
  1326. const container = domRoot.childNodes[ 1 ];
  1327. expect( container.style.position ).to.equal( 'fixed' );
  1328. expect( container.style.top ).to.equal( '0px' );
  1329. expect( container.style.left ).to.equal( '-9999px' );
  1330. } );
  1331. it( 'should bind fake selection container to view selection', () => {
  1332. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1333. renderer.render();
  1334. expect( domRoot.childNodes.length ).to.equal( 2 );
  1335. const container = domRoot.childNodes[ 1 ];
  1336. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1337. expect( bindSelection ).to.not.be.undefined;
  1338. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1339. } );
  1340. // Use a forgiving way of checking what the selection contains
  1341. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1342. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1343. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1344. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1345. expect( domSelection.toString() ).to.match( expectedText );
  1346. expect(
  1347. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1348. ).to.be.true;
  1349. }
  1350. } );
  1351. // #887
  1352. describe( 'similar selection', () => {
  1353. // Use spies to check selection updates. Some selection positions are not achievable in some
  1354. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1355. let selectionCollapseSpy, selectionExtendSpy;
  1356. afterEach( () => {
  1357. if ( selectionCollapseSpy ) {
  1358. selectionCollapseSpy.restore();
  1359. selectionCollapseSpy = null;
  1360. }
  1361. if ( selectionExtendSpy ) {
  1362. selectionExtendSpy.restore();
  1363. selectionExtendSpy = null;
  1364. }
  1365. } );
  1366. it( 'should always render collapsed selection even if it is similar', () => {
  1367. const domSelection = document.getSelection();
  1368. const { view: viewP, selection: newSelection } = parse(
  1369. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1370. viewRoot._appendChild( viewP );
  1371. selection._setTo( newSelection );
  1372. renderer.markToSync( 'children', viewRoot );
  1373. renderer.render();
  1374. const domP = domRoot.childNodes[ 0 ];
  1375. const domB = domP.childNodes[ 1 ];
  1376. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1377. expect( domSelection.isCollapsed ).to.true;
  1378. expect( domSelection.rangeCount ).to.equal( 1 );
  1379. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1380. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1381. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1382. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1383. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1384. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1385. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1386. selection._setTo( [
  1387. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1388. ] );
  1389. renderer.markToSync( 'children', viewP );
  1390. renderer.render();
  1391. expect( selectionCollapseSpy.calledOnce ).to.true;
  1392. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1393. expect( selectionExtendSpy.calledOnce ).to.true;
  1394. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1395. } );
  1396. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1397. const domSelection = document.getSelection();
  1398. const { view: viewP, selection: newSelection } = parse(
  1399. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1400. viewRoot._appendChild( viewP );
  1401. selection._setTo( newSelection );
  1402. renderer.markToSync( 'children', viewRoot );
  1403. renderer.render();
  1404. const domP = domRoot.childNodes[ 0 ];
  1405. const domB = domP.childNodes[ 1 ];
  1406. expect( domSelection.isCollapsed ).to.true;
  1407. expect( domSelection.rangeCount ).to.equal( 1 );
  1408. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1409. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1410. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1411. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1412. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1413. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1414. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1415. selection._setTo( [
  1416. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1417. ] );
  1418. renderer.markToSync( 'children', viewP );
  1419. renderer.render();
  1420. expect( selectionCollapseSpy.calledOnce ).to.true;
  1421. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1422. expect( selectionExtendSpy.calledOnce ).to.true;
  1423. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1424. } );
  1425. it( 'should always render non-collapsed selection if it not is similar', () => {
  1426. const domSelection = document.getSelection();
  1427. const { view: viewP, selection: newSelection } = parse(
  1428. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1429. viewRoot._appendChild( viewP );
  1430. selection._setTo( newSelection );
  1431. renderer.markToSync( 'children', viewRoot );
  1432. renderer.render();
  1433. const domP = domRoot.childNodes[ 0 ];
  1434. const domB = domP.childNodes[ 1 ];
  1435. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1436. expect( domSelection.isCollapsed ).to.false;
  1437. expect( domSelection.rangeCount ).to.equal( 1 );
  1438. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1439. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1440. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1441. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1442. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1443. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1444. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1445. selection._setTo( [
  1446. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1447. ] );
  1448. renderer.markToSync( 'children', viewP );
  1449. renderer.render();
  1450. expect( selectionCollapseSpy.calledOnce ).to.true;
  1451. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1452. expect( selectionExtendSpy.calledOnce ).to.true;
  1453. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1454. } );
  1455. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1456. const domSelection = document.getSelection();
  1457. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1458. viewRoot._appendChild( viewP );
  1459. selection._setTo( newSelection );
  1460. renderer.markToSync( 'children', viewRoot );
  1461. renderer.render();
  1462. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1463. // Do not change view selection.
  1464. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1465. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1466. // because DOM selection is in incorrect place.
  1467. const domP = domRoot.childNodes[ 0 ];
  1468. const domSpan = domP.childNodes[ 1 ];
  1469. domSelection.collapse( domSpan, 0 );
  1470. renderer.render();
  1471. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1472. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1473. const assertSelectionAtEndOfTextNode = () => {
  1474. expect( domSelection.anchorNode ).to.equal( domP );
  1475. expect( domSelection.anchorOffset ).to.equal( 1 );
  1476. };
  1477. const assertSelectionInsideTextNode = () => {
  1478. const textNode = domP.childNodes[ 0 ];
  1479. expect( domSelection.anchorNode ).to.equal( textNode );
  1480. expect( domSelection.anchorOffset ).to.equal( 3 );
  1481. };
  1482. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1483. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1484. } );
  1485. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1486. const domSelection = document.getSelection();
  1487. const { view: viewP, selection: newSelection } = parse(
  1488. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1489. viewRoot._appendChild( viewP );
  1490. selection._setTo( newSelection );
  1491. renderer.markToSync( 'children', viewRoot );
  1492. renderer.render();
  1493. const domP = domRoot.childNodes[ 0 ];
  1494. const domB = domP.childNodes[ 1 ];
  1495. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1496. expect( domSelection.isCollapsed ).to.false;
  1497. expect( domSelection.rangeCount ).to.equal( 1 );
  1498. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1499. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1500. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1501. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1502. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1503. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1504. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1505. selection._setTo( [
  1506. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1507. ] );
  1508. renderer.markToSync( 'children', viewP );
  1509. renderer.render();
  1510. expect( selectionCollapseSpy.notCalled ).to.true;
  1511. expect( selectionExtendSpy.notCalled ).to.true;
  1512. } );
  1513. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1514. const domSelection = document.getSelection();
  1515. const { view: viewP, selection: newSelection } = parse(
  1516. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1517. viewRoot._appendChild( viewP );
  1518. selection._setTo( newSelection );
  1519. renderer.markToSync( 'children', viewRoot );
  1520. renderer.render();
  1521. const domP = domRoot.childNodes[ 0 ];
  1522. const domB = domP.childNodes[ 1 ];
  1523. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1524. expect( domSelection.isCollapsed ).to.false;
  1525. expect( domSelection.rangeCount ).to.equal( 1 );
  1526. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1527. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1528. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1529. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1530. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1531. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1532. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1533. selection._setTo( [
  1534. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1535. ] );
  1536. renderer.markToSync( 'children', viewP );
  1537. renderer.render();
  1538. expect( selectionCollapseSpy.notCalled ).to.true;
  1539. expect( selectionExtendSpy.notCalled ).to.true;
  1540. } );
  1541. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1542. const domSelection = document.getSelection();
  1543. const { view: viewP, selection: newSelection } = parse(
  1544. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1545. viewRoot._appendChild( viewP );
  1546. selection._setTo( newSelection );
  1547. renderer.markToSync( 'children', viewRoot );
  1548. renderer.render();
  1549. const domP = domRoot.childNodes[ 0 ];
  1550. const domB = domP.childNodes[ 1 ];
  1551. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1552. expect( domSelection.isCollapsed ).to.false;
  1553. expect( domSelection.rangeCount ).to.equal( 1 );
  1554. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1555. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1556. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1557. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1558. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1559. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1560. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1561. selection._setTo( [
  1562. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1563. ] );
  1564. renderer.markToSync( 'children', viewP );
  1565. renderer.render();
  1566. expect( selectionCollapseSpy.notCalled ).to.true;
  1567. expect( selectionExtendSpy.notCalled ).to.true;
  1568. } );
  1569. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1570. const domSelection = document.getSelection();
  1571. const { view: viewP, selection: newSelection } = parse(
  1572. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1573. viewRoot._appendChild( viewP );
  1574. selection._setTo( newSelection );
  1575. renderer.markToSync( 'children', viewRoot );
  1576. renderer.render();
  1577. const domP = domRoot.childNodes[ 0 ];
  1578. const domB = domP.childNodes[ 1 ];
  1579. expect( domSelection.isCollapsed ).to.false;
  1580. expect( domSelection.rangeCount ).to.equal( 1 );
  1581. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1582. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1583. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1584. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1585. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1586. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1587. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1588. selection._setTo( [
  1589. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1590. ] );
  1591. renderer.markToSync( 'children', viewP );
  1592. renderer.render();
  1593. expect( selectionCollapseSpy.notCalled ).to.true;
  1594. expect( selectionExtendSpy.notCalled ).to.true;
  1595. } );
  1596. } );
  1597. // #1417
  1598. describe( 'optimal rendering', () => {
  1599. it( 'should render inline element replacement (before text)', () => {
  1600. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1601. renderer.markToSync( 'children', viewRoot );
  1602. renderer.render();
  1603. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1604. const viewP = viewRoot.getChild( 0 );
  1605. viewP._removeChildren( 0, 2 );
  1606. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1607. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1608. renderer.markToSync( 'children', viewRoot );
  1609. renderer.markToSync( 'children', viewP );
  1610. renderer.render();
  1611. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1612. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1613. } );
  1614. it( 'should render inline element replacement (after text)', () => {
  1615. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1616. renderer.markToSync( 'children', viewRoot );
  1617. renderer.render();
  1618. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1619. const viewP = viewRoot.getChild( 0 );
  1620. viewP._removeChildren( 0, 2 );
  1621. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1622. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1623. renderer.markToSync( 'children', viewRoot );
  1624. renderer.markToSync( 'children', viewP );
  1625. renderer.render();
  1626. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1627. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1628. } );
  1629. it( 'should render inline element replacement (before text swapped order)', () => {
  1630. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1631. renderer.markToSync( 'children', viewRoot );
  1632. renderer.render();
  1633. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1634. const viewP = viewRoot.getChild( 0 );
  1635. viewP._removeChildren( 0, 2 );
  1636. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1637. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1638. renderer.markToSync( 'children', viewRoot );
  1639. renderer.markToSync( 'children', viewP );
  1640. renderer.render();
  1641. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1642. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1643. } );
  1644. it( 'should render inline element replacement (after text swapped order)', () => {
  1645. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1646. renderer.markToSync( 'children', viewRoot );
  1647. renderer.render();
  1648. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1649. const viewP = viewRoot.getChild( 0 );
  1650. viewP._removeChildren( 0, 2 );
  1651. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1652. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1653. renderer.markToSync( 'children', viewRoot );
  1654. renderer.markToSync( 'children', viewP );
  1655. renderer.render();
  1656. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1657. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1658. } );
  1659. it( 'should render single replacement in p group', () => {
  1660. const content = '' +
  1661. '<container:p>1</container:p>' +
  1662. '<container:p>2</container:p>' +
  1663. '<container:p>3</container:p>';
  1664. viewRoot._appendChild( parse( content ) );
  1665. renderer.markToSync( 'children', viewRoot );
  1666. renderer.render();
  1667. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1668. viewRoot._removeChildren( 1 );
  1669. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1670. const domP = domRoot.childNodes[ 1 ];
  1671. renderer.markToSync( 'children', viewRoot );
  1672. renderer.render();
  1673. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1674. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1675. } );
  1676. it( 'should render replacement and insertion in p group', () => {
  1677. const content = '' +
  1678. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1679. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1680. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1681. const replacement = '' +
  1682. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1683. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1684. viewRoot._appendChild( parse( content ) );
  1685. renderer.markToSync( 'children', viewRoot );
  1686. renderer.render();
  1687. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1688. viewRoot._removeChildren( 1 );
  1689. viewRoot._insertChild( 1, parse( replacement ) );
  1690. const domP2 = domRoot.childNodes[ 1 ];
  1691. const domP3 = domRoot.childNodes[ 2 ];
  1692. renderer.markToSync( 'children', viewRoot );
  1693. renderer.render();
  1694. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1695. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1696. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1697. } );
  1698. it( 'should render replacement and deletion in p group', () => {
  1699. const content = '' +
  1700. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1701. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1702. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1703. viewRoot._appendChild( parse( content ) );
  1704. renderer.markToSync( 'children', viewRoot );
  1705. renderer.render();
  1706. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1707. viewRoot._removeChildren( 0, 2 );
  1708. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1709. const domP0 = domRoot.childNodes[ 0 ];
  1710. const domP2 = domRoot.childNodes[ 2 ];
  1711. renderer.markToSync( 'children', viewRoot );
  1712. renderer.render();
  1713. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1714. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1715. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1716. } );
  1717. it( 'should render multiple continuous replacement in p group', () => {
  1718. const content = '' +
  1719. '<container:p>1</container:p>' +
  1720. '<container:p>2</container:p>' +
  1721. '<container:p>3</container:p>' +
  1722. '<container:p>4</container:p>' +
  1723. '<container:p>5</container:p>';
  1724. viewRoot._appendChild( parse( content ) );
  1725. renderer.markToSync( 'children', viewRoot );
  1726. renderer.render();
  1727. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1728. viewRoot._removeChildren( 0, 3 );
  1729. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1730. const domP1 = domRoot.childNodes[ 0 ];
  1731. const domP2 = domRoot.childNodes[ 1 ];
  1732. const domP4 = domRoot.childNodes[ 3 ];
  1733. const domP5 = domRoot.childNodes[ 4 ];
  1734. renderer.markToSync( 'children', viewRoot );
  1735. renderer.render();
  1736. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1737. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1738. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1739. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1740. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1741. } );
  1742. it( 'should render multiple replacement in p group', () => {
  1743. const content = '' +
  1744. '<container:p>1</container:p>' +
  1745. '<container:p>2</container:p>' +
  1746. '<container:p>3</container:p>' +
  1747. '<container:p>4</container:p>' +
  1748. '<container:p>5</container:p>';
  1749. viewRoot._appendChild( parse( content ) );
  1750. renderer.markToSync( 'children', viewRoot );
  1751. renderer.render();
  1752. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1753. viewRoot._removeChildren( 4 );
  1754. viewRoot._removeChildren( 1, 2 );
  1755. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1756. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1757. const domP1 = domRoot.childNodes[ 0 ];
  1758. const domP2 = domRoot.childNodes[ 1 ];
  1759. const domP4 = domRoot.childNodes[ 3 ];
  1760. const domP5 = domRoot.childNodes[ 4 ];
  1761. renderer.markToSync( 'children', viewRoot );
  1762. renderer.render();
  1763. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1764. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1765. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1766. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1767. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1768. } );
  1769. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1770. const content = '' +
  1771. '<container:h2>He' +
  1772. '<attribute:i>ading 1</attribute:i>' +
  1773. '</container:h2>' +
  1774. '<container:p>Ph ' +
  1775. '<attribute:strong>Bold</attribute:strong>' +
  1776. '<attribute:a href="https://ckeditor.com">' +
  1777. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1778. '</attribute:a>' +
  1779. '</container:p>' +
  1780. '<container:blockquote>' +
  1781. '<container:ul>' +
  1782. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1783. '</container:ul>' +
  1784. '</container:blockquote>';
  1785. viewRoot._appendChild( parse( content ) );
  1786. renderer.markToSync( 'children', viewRoot );
  1787. renderer.render();
  1788. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1789. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1790. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1791. viewRoot._removeChildren( 0, viewRoot.childCount );
  1792. viewRoot._appendChild( parse( content ) );
  1793. const viewH = viewRoot.getChild( 0 );
  1794. const viewP = viewRoot.getChild( 1 );
  1795. const viewQ = viewRoot.getChild( 2 );
  1796. const domH = domRoot.childNodes[ 0 ];
  1797. const domHI = domH.childNodes[ 1 ];
  1798. const domP = domRoot.childNodes[ 1 ];
  1799. const domPT = domP.childNodes[ 0 ];
  1800. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1801. const domQ = domRoot.childNodes[ 2 ];
  1802. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1803. renderer.markToSync( 'children', viewRoot );
  1804. renderer.render();
  1805. // Assert content.
  1806. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1807. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1808. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1809. // Assert if DOM elements did not change.
  1810. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1811. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1812. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1813. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1814. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1815. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1816. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1817. // Assert mappings.
  1818. const mappings = renderer.domConverter._domToViewMapping;
  1819. expect( mappings.get( domH ) ).to.equal( viewH );
  1820. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1821. expect( mappings.get( domP ) ).to.equal( viewP );
  1822. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1823. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1824. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1825. } );
  1826. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1827. const content = '' +
  1828. '<container:h2>He' +
  1829. '<attribute:i>ading 1</attribute:i>' +
  1830. '</container:h2>' +
  1831. '<container:p>Ph ' +
  1832. '<attribute:strong>Bold</attribute:strong>' +
  1833. '<attribute:a href="https://ckeditor.com">' +
  1834. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1835. '</attribute:a>' +
  1836. '</container:p>' +
  1837. '<container:blockquote>' +
  1838. '<container:ul>' +
  1839. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1840. '</container:ul>' +
  1841. '</container:blockquote>';
  1842. const content2 = '' +
  1843. '<container:p>Ph ' +
  1844. '<attribute:strong>Bold</attribute:strong>' +
  1845. '<attribute:a href="https://ckeditor.com">' +
  1846. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1847. '</attribute:a>' +
  1848. '</container:p>' +
  1849. '<container:blockquote>' +
  1850. '<container:ul>' +
  1851. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1852. '</container:ul>' +
  1853. '</container:blockquote>';
  1854. viewRoot._appendChild( parse( content ) );
  1855. renderer.markToSync( 'children', viewRoot );
  1856. renderer.render();
  1857. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1858. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1859. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1860. viewRoot._removeChildren( 0, viewRoot.childCount );
  1861. viewRoot._appendChild( parse( content2 ) );
  1862. const viewP = viewRoot.getChild( 0 );
  1863. const viewQ = viewRoot.getChild( 1 );
  1864. const domP = domRoot.childNodes[ 1 ];
  1865. const domPT = domP.childNodes[ 0 ];
  1866. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1867. const domQ = domRoot.childNodes[ 2 ];
  1868. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1869. renderer.markToSync( 'children', viewRoot );
  1870. renderer.render();
  1871. // Assert content.
  1872. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  1873. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1874. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1875. // Assert if DOM elements did not change.
  1876. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1877. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1878. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1879. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  1880. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1881. // Assert mappings.
  1882. const mappings = renderer.domConverter._domToViewMapping;
  1883. expect( mappings.get( domP ) ).to.equal( viewP );
  1884. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1885. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1886. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1887. } );
  1888. it( 'should not rerender DOM when typing inside empty inline element', () => {
  1889. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  1890. viewRoot._appendChild( view );
  1891. renderer.markToSync( 'children', viewRoot );
  1892. renderer.render();
  1893. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  1894. const viewP = viewRoot.getChild( 0 );
  1895. viewP._removeChildren( 1 );
  1896. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  1897. const domP = domRoot.childNodes[ 0 ];
  1898. const domText = domP.childNodes[ 0 ];
  1899. const domB = domP.childNodes[ 1 ];
  1900. domB.innerHTML = 'a';
  1901. renderer.markToSync( 'children', viewRoot );
  1902. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  1903. renderer.render();
  1904. // Assert content.
  1905. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  1906. // Assert if DOM elements did not change.
  1907. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1908. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  1909. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  1910. // Assert mappings.
  1911. const mappings = renderer.domConverter._domToViewMapping;
  1912. expect( mappings.get( domP ) ).to.equal( viewP );
  1913. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  1914. } );
  1915. it( 'should handle complex view duplication', () => {
  1916. const content = '' +
  1917. '<container:blockquote>' +
  1918. '<container:ul>' +
  1919. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1920. '<container:li>Item 2</container:li>' +
  1921. '<container:li>' +
  1922. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  1923. '</container:li>' +
  1924. '</container:ul>' +
  1925. '</container:blockquote>';
  1926. const expected = '' +
  1927. '<blockquote>' +
  1928. '<ul>' +
  1929. '<li>Quoted <strong>item 1</strong></li>' +
  1930. '<li>Item 2</li>' +
  1931. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  1932. '</ul>' +
  1933. '</blockquote>';
  1934. viewRoot._appendChild( parse( content ) );
  1935. renderer.markToSync( 'children', viewRoot );
  1936. renderer.render();
  1937. expect( domRoot.innerHTML ).to.equal( expected );
  1938. viewRoot._removeChildren( 0, viewRoot.childCount );
  1939. viewRoot._appendChild( parse( content + content ) );
  1940. const domBQ = domRoot.childNodes[ 0 ];
  1941. const domUL = domBQ.childNodes[ 0 ];
  1942. const domLI1 = domUL.childNodes[ 0 ];
  1943. const domLI2 = domUL.childNodes[ 1 ];
  1944. const domLI3 = domUL.childNodes[ 2 ];
  1945. renderer.markToSync( 'children', viewRoot );
  1946. renderer.render();
  1947. // Assert content.
  1948. expect( domRoot.innerHTML ).to.equal( expected + expected );
  1949. // Assert if DOM elements did not change.
  1950. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  1951. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  1952. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  1953. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  1954. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  1955. // Assert mappings.
  1956. const domMappings = renderer.domConverter._domToViewMapping;
  1957. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  1958. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  1959. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  1960. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1961. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  1962. // Assert if new view elements are bind to new DOM elements.
  1963. const viewMappings = renderer.domConverter._domToViewMapping;
  1964. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  1965. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  1966. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  1967. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  1968. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  1969. } );
  1970. it( 'should handle complex view replace', () => {
  1971. const content = '' +
  1972. '<container:h2>He' +
  1973. '<attribute:i>ading 1</attribute:i>' +
  1974. '</container:h2>' +
  1975. '<container:p>Ph ' +
  1976. '<attribute:strong>Bold</attribute:strong>' +
  1977. '<attribute:a href="https://ckeditor.com">' +
  1978. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1979. '</attribute:a>' +
  1980. '</container:p>' +
  1981. '<container:blockquote>' +
  1982. '<container:ul>' +
  1983. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1984. '<container:li>Item 2</container:li>' +
  1985. '<container:li>' +
  1986. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  1987. '</container:li>' +
  1988. '</container:ul>' +
  1989. '</container:blockquote>';
  1990. const replacement = '' +
  1991. '<container:p>' +
  1992. '1' +
  1993. '<attribute:i>A</attribute:i>' +
  1994. '</container:p>' +
  1995. '<container:p>' +
  1996. '<attribute:a href="https://cksource.com">' +
  1997. 'Li' +
  1998. '<attribute:strong>nk</attribute:strong>' +
  1999. '</attribute:a>' +
  2000. '</container:p>' +
  2001. '<container:h1>' +
  2002. 'Heading ' +
  2003. '<attribute:strong>1</attribute:strong>' +
  2004. '</container:h1>' +
  2005. '<container:h2>' +
  2006. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2007. '</container:h2>' +
  2008. '<container:h3>' +
  2009. 'Heading' +
  2010. '<attribute:i> 3</attribute:i>' +
  2011. '</container:h3>' +
  2012. '<container:blockquote>' +
  2013. 'Foo Bar Baz' +
  2014. '</container:blockquote>' +
  2015. '<container:ul>' +
  2016. '<container:li>' +
  2017. 'Item ' +
  2018. '<attribute:strong>1</attribute:strong>' +
  2019. '</container:li>' +
  2020. '<container:li>' +
  2021. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2022. ' 2' +
  2023. '</container:li>' +
  2024. '</container:ul>';
  2025. viewRoot._appendChild( parse( content ) );
  2026. renderer.markToSync( 'children', viewRoot );
  2027. renderer.render();
  2028. expect( domRoot.innerHTML ).to.equal( '' +
  2029. '<h2>He<i>ading 1</i></h2>' +
  2030. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2031. '<blockquote><ul>' +
  2032. '<li>Quoted <strong>item 1</strong></li>' +
  2033. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2034. '</ul></blockquote>' );
  2035. viewRoot._removeChildren( 0, viewRoot.childCount );
  2036. viewRoot._appendChild( parse( replacement ) );
  2037. renderer.markToSync( 'children', viewRoot );
  2038. renderer.render();
  2039. // Here we just check if new DOM structure was properly rendered.
  2040. expect( domRoot.innerHTML ).to.equal( '' +
  2041. '<p>1<i>A</i></p>' +
  2042. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2043. '<h1>Heading <strong>1</strong></h1>' +
  2044. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2045. '<h3>Heading<i> 3</i></h3>' +
  2046. '<blockquote>Foo Bar Baz</blockquote>' +
  2047. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2048. } );
  2049. it( 'should handle br elements while refreshing bindings', () => {
  2050. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2051. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2052. renderer.markToSync( 'children', viewRoot );
  2053. renderer.render();
  2054. expect( domRoot.innerHTML ).to.equal( expected );
  2055. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2056. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2057. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2058. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2059. viewRoot._removeChildren( 1 );
  2060. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2061. renderer.markToSync( 'children', viewRoot );
  2062. renderer.render();
  2063. expect( domRoot.innerHTML ).to.equal( expected );
  2064. } );
  2065. it( 'should handle list to paragraph conversion', () => {
  2066. const view = '' +
  2067. '<container:ol>' +
  2068. '<container:li>Item 1' +
  2069. '<container:ol>' +
  2070. '<container:li>Item 2</container:li>' +
  2071. '</container:ol>' +
  2072. '</container:li>' +
  2073. '</container:ol>' +
  2074. '<container:p>Paragraph</container:p>' +
  2075. '<container:ol>' +
  2076. '<container:li>Item 3' +
  2077. '<container:ol>' +
  2078. '<container:li>Item 4</container:li>' +
  2079. '</container:ol>' +
  2080. '</container:li>' +
  2081. '</container:ol>';
  2082. viewRoot._appendChild( parse( view ) );
  2083. renderer.markToSync( 'children', viewRoot );
  2084. renderer.render();
  2085. expect( domRoot.innerHTML ).to.equal(
  2086. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2087. const viewOL1 = viewRoot.getChild( 0 );
  2088. viewOL1.getChild( 0 )._removeChildren( 1 );
  2089. viewRoot._removeChildren( 2 );
  2090. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2091. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2092. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2093. const domOL1 = domRoot.childNodes[ 0 ];
  2094. const domOL2 = domRoot.childNodes[ 2 ];
  2095. const domP = domRoot.childNodes[ 1 ];
  2096. renderer.markToSync( 'children', viewRoot );
  2097. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2098. renderer.render();
  2099. expect( domRoot.innerHTML ).to.equal(
  2100. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2101. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2102. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2103. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2104. } );
  2105. it( 'should handle attributes change in replaced elements', () => {
  2106. const view = '' +
  2107. '<container:ol>' +
  2108. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2109. '</container:ol>' +
  2110. '<container:p>Paragraph ' +
  2111. '<attribute:a href="123">Link</attribute:a>' +
  2112. '</container:p>' +
  2113. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2114. viewRoot._appendChild( parse( view ) );
  2115. renderer.markToSync( 'children', viewRoot );
  2116. renderer.render();
  2117. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2118. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2119. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2120. const viewOL = viewRoot.getChild( 0 );
  2121. viewOL._removeChildren( 0 );
  2122. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2123. const viewP1 = viewRoot.getChild( 1 );
  2124. viewP1._removeChildren( 1 );
  2125. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2126. viewRoot._removeChildren( 2 );
  2127. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2128. renderer.markToSync( 'children', viewRoot );
  2129. renderer.markToSync( 'children', viewOL );
  2130. renderer.markToSync( 'children', viewP1 );
  2131. renderer.render();
  2132. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2133. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2134. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2135. } );
  2136. it( 'should handle classes change in replaced elements', () => {
  2137. const view = '' +
  2138. '<container:ol>' +
  2139. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2140. '</container:ol>' +
  2141. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2142. viewRoot._appendChild( parse( view ) );
  2143. renderer.markToSync( 'children', viewRoot );
  2144. renderer.render();
  2145. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2146. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2147. const viewOL = viewRoot.getChild( 0 );
  2148. const oldViewLI = viewOL.getChild( 0 );
  2149. viewOL._removeChildren( 0 );
  2150. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2151. const oldViewP = viewRoot.getChild( 1 );
  2152. viewRoot._removeChildren( 1 );
  2153. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2154. renderer.markToSync( 'attributes', oldViewLI );
  2155. renderer.markToSync( 'attributes', oldViewP );
  2156. renderer.markToSync( 'children', viewRoot );
  2157. renderer.markToSync( 'children', viewOL );
  2158. renderer.render();
  2159. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2160. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2161. } );
  2162. it( 'should handle styles change in replaced elements', () => {
  2163. const view = '' +
  2164. '<container:ol>' +
  2165. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2166. '<container:li>Bar ' +
  2167. '<attribute:i>' +
  2168. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2169. ' Bax</attribute:i>' +
  2170. '</container:li>' +
  2171. '</container:ol>';
  2172. viewRoot._appendChild( parse( view ) );
  2173. renderer.markToSync( 'children', viewRoot );
  2174. renderer.render();
  2175. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2176. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2177. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2178. const viewOL = viewRoot.getChild( 0 );
  2179. const viewLI1 = viewOL.getChild( 0 );
  2180. const viewLI2 = viewOL.getChild( 1 );
  2181. viewLI1._removeStyle( 'font-weight' );
  2182. viewLI1._setStyle( { color: '#FFF' } );
  2183. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2184. viewLI2._removeChildren( 0, viewLI2.childCount );
  2185. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2186. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2187. renderer.markToSync( 'attributes', viewLI1 );
  2188. renderer.markToSync( 'attributes', viewLI2 );
  2189. renderer.markToSync( 'children', viewRoot );
  2190. renderer.markToSync( 'children', viewLI2 );
  2191. renderer.render();
  2192. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2193. '<ol><li style="color:#FFF;">Foo</li>' +
  2194. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2195. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2196. } );
  2197. it( 'should handle uiElement rendering', () => {
  2198. function createUIElement( id, text ) {
  2199. const element = new UIElement( 'span' );
  2200. element.render = function( domDocument ) {
  2201. const domElement = this.toDomElement( domDocument );
  2202. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2203. return domElement;
  2204. };
  2205. return element;
  2206. }
  2207. const ui1 = createUIElement( 'id1', 'UI1' );
  2208. const ui2 = createUIElement( 'id2', 'UI2' );
  2209. const viewP = new ViewContainerElement( 'p', null, [ new ViewText( 'Foo ' ), ui1, new ViewText( 'Bar' ) ] );
  2210. viewRoot._appendChild( viewP );
  2211. renderer.markToSync( 'children', viewRoot );
  2212. renderer.render();
  2213. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2214. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2215. viewP._removeChildren( 0, viewP.childCount );
  2216. viewP._insertChild( 0, [ new ViewText( 'Foo' ), ui2, new ViewText( ' Bar' ) ] );
  2217. renderer.markToSync( 'children', viewRoot );
  2218. renderer.markToSync( 'children', viewP );
  2219. renderer.render();
  2220. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2221. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2222. } );
  2223. it( 'should handle linking entire content', () => {
  2224. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2225. renderer.markToSync( 'children', viewRoot );
  2226. renderer.render();
  2227. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2228. const viewP = viewRoot.getChild( 0 );
  2229. // While linking, the existing DOM children are moved to a new `a` element during binding
  2230. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2231. // where view elements were moved to a newly created link view element.
  2232. const viewA = new ViewAttributeElement( 'a', { href: '#href' }, [ new ViewText( 'Foo' ), viewP.getChild( 1 ) ] );
  2233. viewP._removeChildren( 0, viewP.childCount );
  2234. viewP._insertChild( 0, viewA );
  2235. renderer.markToSync( 'children', viewRoot );
  2236. renderer.markToSync( 'children', viewP );
  2237. renderer.render();
  2238. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2239. } );
  2240. } );
  2241. } );
  2242. describe( '#922', () => {
  2243. let view, viewDoc, viewRoot, domRoot, converter;
  2244. beforeEach( () => {
  2245. view = new View();
  2246. viewDoc = view.document;
  2247. domRoot = document.createElement( 'div' );
  2248. document.body.appendChild( domRoot );
  2249. viewRoot = createViewRoot( viewDoc );
  2250. view.attachDomRoot( domRoot );
  2251. converter = view.domConverter;
  2252. } );
  2253. it( 'should properly render unwrapped attributes #1', () => {
  2254. setViewData( view,
  2255. '<container:p>' +
  2256. '[<attribute:italic>' +
  2257. '<attribute:strong>f</attribute:strong>' +
  2258. '</attribute:italic>]' +
  2259. '<attribute:strong>oo</attribute:strong>' +
  2260. '</container:p>'
  2261. );
  2262. // Render it to DOM to create initial DOM <-> view mappings.
  2263. view.render();
  2264. // Unwrap italic attribute element.
  2265. view.change( writer => {
  2266. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2267. } );
  2268. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2269. // Re-render changes in view to DOM.
  2270. view.render();
  2271. // Check if DOM is rendered correctly.
  2272. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2273. expect( checkMappings() ).to.be.true;
  2274. } );
  2275. it( 'should properly render unwrapped attributes #2', () => {
  2276. setViewData( view,
  2277. '<container:p>' +
  2278. '[<attribute:italic>' +
  2279. '<attribute:strong>foo</attribute:strong>' +
  2280. '</attribute:italic>]' +
  2281. '</container:p>' );
  2282. // Render it to DOM to create initial DOM <-> view mappings.
  2283. view.render();
  2284. // Unwrap italic attribute element and change text inside.
  2285. view.change( writer => {
  2286. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2287. } );
  2288. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2289. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2290. // Re-render changes in view to DOM.
  2291. view.render();
  2292. // Check if DOM is rendered correctly.
  2293. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2294. expect( checkMappings() ).to.be.true;
  2295. } );
  2296. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2297. setViewData( view,
  2298. '<container:p>foo</container:p>'
  2299. );
  2300. // Render it to DOM to create initial DOM <-> view mappings.
  2301. view.render();
  2302. // Change text and insert new element into paragraph.
  2303. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2304. textNode._data = 'foobar';
  2305. view.change( writer => {
  2306. writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  2307. } );
  2308. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2309. // Re-render changes in view to DOM.
  2310. view.render();
  2311. // Check if DOM is rendered correctly.
  2312. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2313. expect( checkMappings() ).to.be.true;
  2314. } );
  2315. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2316. setViewData( view,
  2317. '<container:p>foo</container:p>'
  2318. );
  2319. // Render it to DOM to create initial DOM <-> view mappings.
  2320. view.render();
  2321. // Change text and insert new element into paragraph.
  2322. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2323. textNode._data = 'foobar';
  2324. view.change( writer => {
  2325. writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  2326. } );
  2327. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2328. // Re-render changes in view to DOM.
  2329. view.render();
  2330. // Check if DOM is rendered correctly.
  2331. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2332. expect( checkMappings() ).to.be.true;
  2333. } );
  2334. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2335. setViewData( view,
  2336. '<container:p>' +
  2337. '<attribute:b></attribute:b>' +
  2338. '<attribute:i></attribute:i>' +
  2339. '<attribute:span></attribute:span>' +
  2340. '</container:p>'
  2341. );
  2342. // Render it to DOM to create initial DOM <-> view mappings.
  2343. view.render();
  2344. // Remove first element and reinsert it at the end.
  2345. const container = viewRoot.getChild( 0 );
  2346. const firstElement = container.getChild( 0 );
  2347. view.change( writer => {
  2348. writer.remove( ViewRange.createOn( firstElement ) );
  2349. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2350. } );
  2351. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2352. // Re-render changes in view to DOM.
  2353. view.render();
  2354. // Check if DOM is rendered correctly.
  2355. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2356. expect( checkMappings() ).to.be.true;
  2357. } );
  2358. // Checks if every node in DOM tree is mapped to the view.
  2359. function checkMappings() {
  2360. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2361. while ( domWalker.nextNode() ) {
  2362. const node = domWalker.currentNode;
  2363. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2364. return false;
  2365. }
  2366. }
  2367. return true;
  2368. }
  2369. } );
  2370. describe( '_markDescendantTextToSync', () => {
  2371. let viewRoot;
  2372. beforeEach( () => {
  2373. viewRoot = new ViewElement( 'div' );
  2374. renderer.markedTexts.clear();
  2375. renderer.markedAttributes.clear();
  2376. renderer.markedChildren.clear();
  2377. } );
  2378. it( 'should handle null values', () => {
  2379. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2380. renderer._markDescendantTextToSync( null );
  2381. expect( renderer.markedChildren.size ).to.equal( 0 );
  2382. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2383. expect( renderer.markedTexts.size ).to.equal( 0 );
  2384. } );
  2385. it( 'should handle element nodes', () => {
  2386. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2387. viewRoot._appendChild( viewP );
  2388. renderer._markDescendantTextToSync( viewP );
  2389. expect( renderer.markedChildren.size ).to.equal( 0 );
  2390. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2391. expect( renderer.markedTexts.size ).to.equal( 3 );
  2392. } );
  2393. it( 'should handle text nodes', () => {
  2394. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2395. viewRoot._appendChild( viewP );
  2396. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2397. expect( renderer.markedChildren.size ).to.equal( 0 );
  2398. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2399. expect( renderer.markedTexts.size ).to.equal( 1 );
  2400. } );
  2401. it( 'should handle document fragment', () => {
  2402. const fragment = new DocumentFragment();
  2403. renderer._markDescendantTextToSync( fragment );
  2404. expect( renderer.markedChildren.size ).to.equal( 0 );
  2405. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2406. expect( renderer.markedTexts.size ).to.equal( 0 );
  2407. } );
  2408. it( 'should handle empty element nodes', () => {
  2409. const viewP = parse( '<container:p></container:p>' );
  2410. viewRoot._appendChild( viewP );
  2411. renderer._markDescendantTextToSync( viewP );
  2412. expect( renderer.markedChildren.size ).to.equal( 0 );
  2413. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2414. expect( renderer.markedTexts.size ).to.equal( 0 );
  2415. } );
  2416. } );
  2417. describe( '_updateText', () => {
  2418. let viewRoot, domRoot;
  2419. beforeEach( () => {
  2420. viewRoot = new ViewElement( 'div' );
  2421. domRoot = document.createElement( 'div' );
  2422. document.body.appendChild( domRoot );
  2423. domConverter.bindElements( domRoot, viewRoot );
  2424. renderer.markedTexts.clear();
  2425. renderer.markedAttributes.clear();
  2426. renderer.markedChildren.clear();
  2427. renderer.isFocused = true;
  2428. } );
  2429. afterEach( () => {
  2430. domRoot.remove();
  2431. } );
  2432. it( 'should update text - change on end', () => {
  2433. const viewText = new ViewText( 'foo' );
  2434. viewRoot._appendChild( viewText );
  2435. renderer.markToSync( 'children', viewRoot );
  2436. renderer.render();
  2437. expect( domRoot.childNodes.length ).to.equal( 1 );
  2438. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2439. viewText._data = 'fobar';
  2440. renderer._updateText( viewText, {} );
  2441. expect( domRoot.childNodes.length ).to.equal( 1 );
  2442. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2443. } );
  2444. it( 'should update text - change on start', () => {
  2445. const viewText = new ViewText( 'foo' );
  2446. viewRoot._appendChild( viewText );
  2447. renderer.markToSync( 'children', viewRoot );
  2448. renderer.render();
  2449. expect( domRoot.childNodes.length ).to.equal( 1 );
  2450. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2451. viewText._data = 'baro';
  2452. renderer._updateText( viewText, {} );
  2453. expect( domRoot.childNodes.length ).to.equal( 1 );
  2454. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  2455. } );
  2456. it( 'should update text - change in the middle', () => {
  2457. const viewText = new ViewText( 'foobar' );
  2458. viewRoot._appendChild( viewText );
  2459. renderer.markToSync( 'children', viewRoot );
  2460. renderer.render();
  2461. expect( domRoot.childNodes.length ).to.equal( 1 );
  2462. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  2463. viewText._data = 'fobazr';
  2464. renderer._updateText( viewText, {} );
  2465. expect( domRoot.childNodes.length ).to.equal( 1 );
  2466. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  2467. } );
  2468. it( 'should update text - empty expected', () => {
  2469. const viewText = new ViewText( 'foo' );
  2470. viewRoot._appendChild( viewText );
  2471. renderer.markToSync( 'children', viewRoot );
  2472. renderer.render();
  2473. expect( domRoot.childNodes.length ).to.equal( 1 );
  2474. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2475. viewText._data = '';
  2476. renderer._updateText( viewText, {} );
  2477. expect( domRoot.childNodes.length ).to.equal( 1 );
  2478. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2479. } );
  2480. it( 'should update text - empty actual', () => {
  2481. const viewText = new ViewText( '' );
  2482. viewRoot._appendChild( viewText );
  2483. renderer.markToSync( 'children', viewRoot );
  2484. renderer.render();
  2485. expect( domRoot.childNodes.length ).to.equal( 1 );
  2486. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2487. viewText._data = 'fobar';
  2488. renderer._updateText( viewText, {} );
  2489. expect( domRoot.childNodes.length ).to.equal( 1 );
  2490. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2491. } );
  2492. it( 'should handle filler during text modifications', () => {
  2493. const viewText = new ViewText( 'foo' );
  2494. viewRoot._appendChild( viewText );
  2495. renderer.markToSync( 'children', viewRoot );
  2496. renderer.render();
  2497. expect( domRoot.childNodes.length ).to.equal( 1 );
  2498. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2499. // 1. Insert filler.
  2500. renderer._updateText( viewText, {
  2501. inlineFillerPosition: {
  2502. parent: viewText.parent,
  2503. offset: 0
  2504. }
  2505. } );
  2506. expect( domRoot.childNodes.length ).to.equal( 1 );
  2507. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2508. // 2. Edit text - filler should be preserved.
  2509. viewText._data = 'barfoo';
  2510. renderer._updateText( viewText, {
  2511. inlineFillerPosition: {
  2512. parent: viewText.parent,
  2513. offset: 0
  2514. }
  2515. } );
  2516. expect( domRoot.childNodes.length ).to.equal( 1 );
  2517. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  2518. // 3. Remove filler.
  2519. renderer._updateText( viewText, {} );
  2520. expect( domRoot.childNodes.length ).to.equal( 1 );
  2521. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  2522. } );
  2523. it( 'should handle filler during text modifications - empty text', () => {
  2524. const viewText = new ViewText( '' );
  2525. viewRoot._appendChild( viewText );
  2526. renderer.markToSync( 'children', viewRoot );
  2527. renderer.render();
  2528. expect( domRoot.childNodes.length ).to.equal( 1 );
  2529. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2530. // 1. Insert filler.
  2531. renderer._updateText( viewText, {
  2532. inlineFillerPosition: {
  2533. parent: viewText.parent,
  2534. offset: 0
  2535. }
  2536. } );
  2537. expect( domRoot.childNodes.length ).to.equal( 1 );
  2538. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  2539. // 2. Edit text - filler should be preserved.
  2540. viewText._data = 'foo';
  2541. renderer._updateText( viewText, {
  2542. inlineFillerPosition: {
  2543. parent: viewText.parent,
  2544. offset: 0
  2545. }
  2546. } );
  2547. expect( domRoot.childNodes.length ).to.equal( 1 );
  2548. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2549. // 3. Remove filler.
  2550. viewText._data = '';
  2551. renderer._updateText( viewText, {} );
  2552. expect( domRoot.childNodes.length ).to.equal( 1 );
  2553. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2554. } );
  2555. it( 'should handle filler during text modifications inside inline element', () => {
  2556. const viewB = new ViewElement( 'b' );
  2557. const viewText = new ViewText( 'foo' );
  2558. viewB._appendChild( viewText );
  2559. viewRoot._appendChild( viewB );
  2560. renderer.markToSync( 'children', viewRoot );
  2561. renderer.render();
  2562. expect( domRoot.childNodes.length ).to.equal( 1 );
  2563. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2564. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2565. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  2566. // 1. Insert filler.
  2567. renderer._updateText( viewText, {
  2568. inlineFillerPosition: {
  2569. parent: viewText.parent,
  2570. offset: 0
  2571. }
  2572. } );
  2573. expect( domRoot.childNodes.length ).to.equal( 1 );
  2574. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2575. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2576. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2577. // 2. Edit text - filler should be preserved.
  2578. viewText._data = 'bar';
  2579. renderer._updateText( viewText, {
  2580. inlineFillerPosition: {
  2581. parent: viewText.parent,
  2582. offset: 0
  2583. }
  2584. } );
  2585. expect( domRoot.childNodes.length ).to.equal( 1 );
  2586. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2587. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2588. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  2589. // 3. Remove filler.
  2590. viewText._data = 'bar';
  2591. renderer._updateText( viewText, {} );
  2592. expect( domRoot.childNodes.length ).to.equal( 1 );
  2593. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2594. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2595. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  2596. } );
  2597. } );
  2598. } );
  2599. function renderAndExpectNoChanges( renderer, domRoot ) {
  2600. const config = {
  2601. childList: true,
  2602. characterData: true,
  2603. characterDataOldValue: true,
  2604. subtree: true
  2605. };
  2606. const mutationObserver = new window.MutationObserver( () => {
  2607. throw 'There should be not mutations';
  2608. } );
  2609. mutationObserver.observe( domRoot, config );
  2610. renderer.render();
  2611. const records = mutationObserver.takeRecords();
  2612. mutationObserver.disconnect();
  2613. expect( records.length ).to.equal( 0 );
  2614. }