| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438 |
- /**
- * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
- * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
- */
- /* globals document, window, NodeFilter, MutationObserver, HTMLImageElement */
- import View from '../../src/view/view';
- import ViewElement from '../../src/view/element';
- import ViewEditableElement from '../../src/view/editableelement';
- import ViewContainerElement from '../../src/view/containerelement';
- import ViewAttributeElement from '../../src/view/attributeelement';
- import ViewRawElement from '../../src/view/rawelement';
- import ViewUIElement from '../../src/view/uielement';
- import ViewText from '../../src/view/text';
- import ViewRange from '../../src/view/range';
- import ViewPosition from '../../src/view/position';
- import DocumentSelection from '../../src/view/documentselection';
- import DomConverter from '../../src/view/domconverter';
- import Renderer from '../../src/view/renderer';
- import DocumentFragment from '../../src/view/documentfragment';
- import ViewDocument from '../../src/view/document';
- import DowncastWriter from '../../src/view/downcastwriter';
- import { parse, stringify, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
- import { BR_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../../src/view/filler';
- import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
- import createViewRoot from './_utils/createroot';
- import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
- import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
- import env from '@ckeditor/ckeditor5-utils/src/env';
- import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
- import { StylesProcessor } from '../../src/view/stylesmap';
- describe( 'Renderer', () => {
- let selection, domConverter, renderer, viewDocument;
- testUtils.createSinonSandbox();
- beforeEach( () => {
- viewDocument = new ViewDocument( new StylesProcessor() );
- selection = new DocumentSelection();
- domConverter = new DomConverter( viewDocument );
- renderer = new Renderer( domConverter, selection );
- renderer.domDocuments.add( document );
- } );
- describe( 'markToSync', () => {
- let viewRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( viewDocument, 'p' );
- const domRoot = document.createElement( 'p' );
- domConverter.bindElements( domRoot, viewRoot );
- viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- } );
- it( 'should mark attributes which need update', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
- } );
- it( 'should mark children which need update', () => {
- viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
- } );
- it( 'should not mark children if element has no corresponding node', () => {
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( viewDocument, 'p' );
- viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
- } );
- it( 'should mark text which need update', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.true;
- } );
- it( 'should not mark text if parent has no corresponding node', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( viewDocument, 'p' );
- viewRoot._appendChild( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.false;
- } );
- it( 'should throw if the type is unknown', () => {
- expectToThrowCKEditorError( () => {
- renderer.markToSync( 'UNKNOWN', viewRoot );
- }, /^view-renderer-unknown-type/, selection );
- } );
- } );
- describe( 'render', () => {
- let viewRoot, domRoot;
- beforeEach( () => {
- viewRoot = new ViewEditableElement( viewDocument, 'div' );
- viewRoot.getFillerOffset = () => null;
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- domConverter.bindElements( domRoot, viewRoot );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- selection._setTo( null );
- renderer.isFocused = true;
- } );
- afterEach( () => {
- domRoot.remove();
- } );
- it( 'should update attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should remove attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- domRoot.setAttribute( 'id', 'bar' );
- domRoot.setAttribute( 'class', 'bar' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should add children', () => {
- viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should remove children', () => {
- viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should update text', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should not update same text', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'foo';
- renderer.markToSync( 'text', viewText );
- renderAndExpectNoChanges( renderer, domRoot );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should not update text parent child list changed', () => {
- const viewImg = new ViewElement( viewDocument, 'img' );
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( [ viewImg, viewText ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
- expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
- } );
- it( 'should not change text if it is the same during text rendering', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change text if it is the same during children rendering', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change element if it is the same', () => {
- const viewImg = new ViewElement( viewDocument, 'img' );
- viewRoot._appendChild( viewImg );
- // This should not be changed during the render.
- const domImg = document.createElement( 'img' );
- domRoot.appendChild( domImg );
- domConverter.bindElements( domImg, viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
- } );
- it( 'should remove any comment from the DOM element', () => {
- // This comment should be cleared during render.
- const domComment = document.createComment( 'some comment from the user-land' );
- domRoot.appendChild( domComment );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- } );
- // https://github.com/ckeditor/ckeditor5/issues/5734
- it( 'should remove the comment and add a child element', () => {
- const viewImg = new ViewElement( viewDocument, 'img' );
- viewRoot._appendChild( viewImg );
- // This comment should be cleared during render.
- const domComment = document.createComment( 'some comment from the user-land' );
- domRoot.appendChild( domComment );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.be.an.instanceof( HTMLImageElement );
- } );
- it( 'should change element if it is different', () => {
- const viewImg = new ViewElement( viewDocument, 'img' );
- viewRoot._appendChild( viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const viewP = new ViewElement( viewDocument, 'p' );
- viewRoot._removeChildren( 0, 1 );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
- } );
- it( 'should update removed item when it is reinserted', () => {
- const viewFoo = new ViewText( viewDocument, 'foo' );
- const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
- const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
- viewRoot._appendChild( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- viewP._removeChildren( 0, 1 );
- viewDiv._appendChild( viewP );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDiv = domRoot.childNodes[ 0 ];
- expect( domDiv.tagName ).to.equal( 'DIV' );
- expect( domDiv.childNodes.length ).to.equal( 1 );
- const domP = domDiv.childNodes[ 0 ];
- expect( domP.tagName ).to.equal( 'P' );
- expect( domP.childNodes.length ).to.equal( 0 );
- } );
- it( 'should update removed item when it is reinserted #2', () => {
- // Prepare view: root -> div "outer" -> div "inner" -> p.
- const viewP = new ViewElement( viewDocument, 'p' );
- const viewDivInner = new ViewElement( viewDocument, 'div', null, viewP );
- const viewDivOuter = new ViewElement( viewDocument, 'div', null, viewDivInner );
- viewRoot._appendChild( viewDivOuter );
- // Render view tree to DOM.
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove div "outer" from root and render it.
- viewDivOuter._remove();
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
- viewP._remove();
- // Add div "outer" back to root.
- viewRoot._appendChild( viewDivOuter );
- renderer.markToSync( 'children', viewRoot );
- // Render changes, view is: root -> div "outer" -> div "inner".
- renderer.render();
- // Same is expected in DOM.
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDivOuter = domRoot.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
- expect( domDivOuter.tagName ).to.equal( 'DIV' );
- expect( domDivOuter.childNodes.length ).to.equal( 1 );
- const domDivInner = domDivOuter.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
- expect( domDivInner.tagName ).to.equal( 'DIV' );
- expect( domDivInner.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
- const viewFoo = new ViewText( viewDocument, 'foo' );
- const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
- const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
- viewRoot._appendChild( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- viewP._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not care about filler if there is no DOM', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- const viewRoot = new ViewElement( viewDocument, 'p' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Expect no error on render.
- expect( viewRoot ).to.be.ok;
- } );
- it( 'should not add filler when inside contenteditable=false parent', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should not add filler when inside contenteditable=false ancestor', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p>foo{}<b></b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>{}foo</b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>foo{}</b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should move filler when selection is moved', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
- // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
- const viewI = viewP.getChild( 2 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- it( 'should remove filler when text is added and selection removed', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- const viewB = viewP.getChild( 1 );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Add text node.
- const viewText = new ViewText( viewDocument, 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- // Step 3: Remove selection from the view.
- selection._setTo( null );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
- } );
- // #659
- // The element before the filler is removed so the position of the filler
- // cannot be remembered as parent+offset.
- it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
- // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
- viewP._removeChildren( 1 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether there's no filler in the DOM.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
- } );
- // #659
- it( 'should remove filler from a modified DOM when children moved', () => {
- // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
- const { view: viewFragment, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
- );
- viewRoot._appendChild( viewFragment );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const domP = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
- // <p>[]</p><p><b>foo</b><b>bar</b></p>
- const viewP = viewRoot.getChild( 0 );
- const viewP2 = viewRoot.getChild( 1 );
- const removedChildren = viewP._removeChildren( 0, 2 );
- viewP2._appendChild( removedChildren );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.markToSync( 'children', viewP2 );
- renderer.render();
- // Step 3: Check whether in the first paragraph there's a <br> filler and that
- // in the second one there are two <b> tags.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domP2.childNodes.length ).to.equal( 2 );
- expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
- // in one of ckeditor/ckeditor5-typing#59 automated tests.
- it( 'should not break when selection is moved to a new element, when filler exists', () => {
- // Step 1: <p>bar<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element and remove the previous one
- viewP._removeChildren( 1 ); // Remove <b>.
- const viewI = parse( '<attribute:i></attribute:i>' );
- viewP._appendChild( viewI );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether new filler was created in the <i> element.
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
- // that has not been yet rendered/bound to DOM.
- it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
- // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element.
- const viewAbc = parse( 'abc' );
- viewP._appendChild( viewAbc );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether old filler was removed.
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove filler and add text node to both DOM and View <p>x{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( document.createTextNode( 'x' ) );
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( viewDocument, 'x' );
- viewP._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty block, render if needed', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Add text node only in View <p>x{}</p>
- const viewText = new ViewText( viewDocument, 'x' );
- viewP._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle removing last character', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove text and add filler to both DOM and View <p>{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- viewP._removeChildren( 0 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
- domB.childNodes[ 0 ].data += 'x';
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( viewDocument, 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute as a children change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- domSelection.removeAllRanges();
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( viewDocument, 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const firstRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- };
- const assertSelectionInsideTextNode = () => {
- expect( firstRange.startContainer ).to.equal( domB );
- expect( firstRange.startOffset ).to.equal( 1 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( firstRange.collapsed ).to.be.true;
- } );
- it( 'should handle typing in empty attribute as a text change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( viewDocument, 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- // 4. Check the DOM.
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle not collapsed range', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should not change selection if there is no editable with selection', () => {
- const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
- document.body.appendChild( domDiv );
- domDiv.focus();
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- domSelection.collapse( domDiv, 0 );
- const viewDiv = new ViewElement( viewDocument, 'div' );
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewDiv._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domRange.startOffset ).to.equal( 0 );
- expect( domRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not change selection if there is no focus', () => {
- const domDiv = createElement( document, 'div', null, 'not editable' );
- document.body.appendChild( domDiv );
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domDiv, 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- renderer.isFocused = false;
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domSelectionRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelectionRange.startOffset ).to.equal( 0 );
- expect( domSelectionRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not add inline filler after text node', () => {
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should throw if there is no filler in expected position', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- const viewB = viewP.getChild( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Remove filler.
- domB.childNodes[ 0 ].data = '';
- selection._setTo( null );
- renderer.markToSync( 'children', viewB );
- expectToThrowCKEditorError( () => {
- renderer.render();
- }, /^view-renderer-filler-was-lost/, selection );
- } );
- // #1014.
- it( 'should create inline filler in newly created dom nodes', () => {
- // 1. Create the view structure which needs inline filler.
- const inputView =
- '<container:ul>' +
- '<container:li>Foobar.</container:li>' +
- '<container:li>[]<container:div></container:div></container:li>' +
- '</container:ul>';
- const { view: view, selection: newSelection } = parse( inputView );
- viewRoot._appendChild( view );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check if filler element has been (correctly) created.
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- // 3. Move the inline filler parent to a newly created element.
- const viewLi = view.getChild( 0 );
- const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
- const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
- viewLi._appendChild( viewUl );
- // 4. Mark changed items and render the view.
- renderer.markToSync( 'children', view );
- renderer.markToSync( 'children', viewLi );
- renderer.render();
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- const domSelection = document.getSelection();
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
- } );
- it( 'should handle focusing element', () => {
- selection._setTo( viewRoot, 0 );
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.render();
- expect( domFocusSpy.called ).to.be.true;
- } );
- it( 'should not focus editable if isFocues is set to false', () => {
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.isFocused = false;
- renderer.render();
- expect( domFocusSpy.calledOnce ).to.be.false;
- } );
- it( 'should not focus already focused DOM element', () => {
- domRoot.setAttribute( 'contentEditable', true );
- domRoot.focus();
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.render();
- expect( domFocusSpy.called ).to.be.false;
- } );
- it( 'should render NBSP as last space in the previous inline element', () => {
- const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
- expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
- expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
- // Insert space resulting in '<p>x <b> y</b></p>'.
- const viewB = viewP.getChild( 1 );
- viewB._removeChildren( 0 );
- viewB._appendChild( new ViewText( viewDocument, ' y' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x <b> y</b>' );
- } );
- it( 'should update sibling after, when node before is removed', () => {
- const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
- // Remove 'x' resulting in '<p><b> y</b></p>'.
- viewP._removeChildren( 0 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
- expect( domP.innerHTML ).to.equal( '<b> y</b>' );
- } );
- it( 'should update sibling before, when node after is removed', () => {
- const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
- expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
- expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
- // Remove '<b>y</b>' resulting in '<p>x </p>'.
- viewP._removeChildren( 1 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domP.innerHTML ).to.equal( 'x ' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - text-element', () => {
- const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
- // Insert space resulting in '<p>x <b> y</b></p>'.
- viewP._removeChildren( 0 );
- viewP._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x <b> y</b>' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - element-text', () => {
- const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 0 ];
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
- // Insert space resulting in '<p><b>x </b> y</p>'.
- const viewB = viewP.getChild( 0 );
- viewB._removeChildren( 0 );
- viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x </b> y' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - element-element', () => {
- const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 0 ];
- const domI = domP.childNodes[ 1 ];
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
- // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
- const viewB = viewP.getChild( 0 );
- viewB._removeChildren( 0 );
- viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x </b><i> y</i>' );
- } );
- // #1125
- it( 'should properly rerender many changes done in one batch', () => {
- // This test transforms:
- //
- // <h2>He<strong>ding 1</strong></h2>
- // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
- // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
- //
- // into:
- //
- // <h2>Heading 2</h2>
- // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
- // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
- //
- // during one rerender to check if complex structure changes are rerendered correctly.
- const viewContent = parse( '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong> ' +
- '<attribute:i>It' +
- '<attribute:strong>alic</attribute:strong>' +
- '</attribute:i> ' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin</attribute:strong>' +
- 'k</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>' );
- viewRoot._appendChild( viewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
- const viewHeading = viewRoot.getChild( 0 );
- viewHeading._removeChildren( 0, viewHeading.childCount );
- viewHeading._insertChild( 0, new ViewText( viewDocument, 'Heading 2' ) );
- // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewHeading );
- renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
- // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
- // ->
- // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
- const viewP = viewRoot.getChild( 1 );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild(
- 0,
- parse(
- 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
- '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
- )
- );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.markToSync( 'children', viewP.getChild( 1 ) );
- renderer.markToSync( 'children', viewP.getChild( 3 ) );
- renderer.markToSync( 'text', viewP.getChild( 0 ) );
- renderer.markToSync( 'text', viewP.getChild( 2 ) );
- // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
- // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
- const viewBq = viewRoot.getChild( 2 );
- viewBq._removeChildren( 0, viewBq.childCount );
- viewBq._insertChild(
- 0,
- parse(
- '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
- '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
- )
- );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewBq );
- renderer.markToSync( 'children', viewBq.getChild( 0 ) );
- renderer.markToSync( 'children', viewBq.getChild( 1 ) );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
- '<h2>Heading 2</h2>' +
- '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
- '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
- );
- } );
- // #1125
- it( 'should properly rerender changes when whole content replaced at once', () => {
- // This test replaces:
- //
- // <h1>Header</h1>
- // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
- //
- // with:
- //
- // <h2>Header</h2>
- // <p>Not Quoted <strong>item 1</strong> and item 2</p>
- //
- // during one rerender to check if complex structure changes are rerendered correctly.
- const viewContent = parse(
- '<container:h1>Header</container:h1>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '</container:ul>' +
- '</container:blockquote>'
- );
- viewRoot._appendChild( viewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const newViewContent = parse(
- '<container:h2>Header</container:h2>' +
- '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
- );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( newViewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
- '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
- );
- } );
- // #1451
- it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
- const inputView =
- '<container:ul>' +
- '<container:li>Foo</container:li>' +
- '<container:li><attribute:b>Bar</attribute:b></container:li>' +
- '</container:ul>';
- const view = parse( inputView );
- viewRoot._appendChild( view );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
- const viewLi = view.getChild( 0 );
- const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
- viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
- const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
- viewLi._appendChild( viewUl );
- renderer.markToSync( 'children', view );
- renderer.markToSync( 'children', viewLi );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
- } );
- // #1439
- it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
- const domSelection = domRoot.ownerDocument.defaultView.getSelection();
- testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
- const spy = testUtils.sinon.stub( domSelection, 'addRange' );
- // <p>foo<br/>[]</p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<empty:br></empty:br>[]' +
- '</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- } );
- // #1439
- it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
- const domSelection = domRoot.ownerDocument.defaultView.getSelection();
- testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
- const spy = testUtils.sinon.stub( domSelection, 'addRange' );
- // <p>foo[]<b>bar</b></p>
- let { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<attribute:b>bar</attribute:b>' +
- '</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- // <p>foo<b>bar</b></p><p>foo[]<br/></p>
- ( { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<empty:br></empty:br>' +
- '</container:p>' ) );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
- ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.calledOnce( spy );
- } );
- describe( 'fake selection', () => {
- beforeEach( () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[foo bar]</container:p>'
- );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- } );
- it( 'should render fake selection', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( domConverter.mapDomToView( container ) ).to.be.undefined;
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
- } );
- describe( 'subsequent call optimization', () => {
- // https://github.com/ckeditor/ckeditor5-engine/issues/1791
- it( 'doesn\'t render the same selection multiple times', () => {
- const createRangeSpy = sinon.spy( document, 'createRange' );
- const label = 'subsequent fake selection calls';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( createRangeSpy.callCount ).to.equal( 1 );
- } );
- it( 'different subsequent fake selections sets do change native selection', () => {
- const createRangeSpy = sinon.spy( document, 'createRange' );
- selection._setTo( selection.getRanges(), { fake: true, label: 'selection 1' } );
- renderer.render();
- selection._setTo( selection.getRanges(), { fake: true, label: 'selection 2' } );
- renderer.render();
- expect( createRangeSpy.callCount ).to.equal( 2 );
- } );
- it( 'rerenders selection if disturbed externally', () => {
- const interruptingRange = document.createRange();
- interruptingRange.setStartBefore( domRoot.children[ 0 ] );
- interruptingRange.setEndAfter( domRoot.children[ 0 ] );
- const createRangeSpy = sinon.spy( document, 'createRange' );
- const label = 'selection 1';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- document.getSelection().removeAllRanges();
- document.getSelection().addRange( interruptingRange );
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( createRangeSpy.callCount ).to.equal( 2 );
- } );
- it( 'correctly maps fake selection ', () => {
- // See https://github.com/ckeditor/ckeditor5-engine/pull/1792#issuecomment-529814641
- const label = 'subsequent fake selection calls';
- const { view: newParagraph, selection: newSelection } = parse( '<container:p>[baz]</container:p>' );
- viewRoot._appendChild( newParagraph );
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- selection._setTo( newSelection.getRanges(), { fake: true, label } );
- renderer.render();
- const fakeSelectionContainer = domRoot.childNodes[ 1 ];
- const mappedSelection = renderer.domConverter.fakeSelectionToView( fakeSelectionContainer );
- expect( stringify( viewRoot, mappedSelection ) ).to.equal( '<div><p>foo bar</p><p>[baz]</p></div>' );
- } );
- } );
- it( 'should render if no selection label is provided', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( '\u00A0' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
- } );
- it( 'should remove fake selection container when selection is no longer fake', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domParagraph = domRoot.childNodes[ 0 ];
- expect( domParagraph.childNodes.length ).to.equal( 1 );
- expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
- } );
- it( 'should reuse fake selection container #1', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- } );
- it( 'should reuse fake selection container #2', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should reuse fake selection container #3', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should style fake selection container properly', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.style.position ).to.equal( 'fixed' );
- expect( container.style.top ).to.equal( '0px' );
- expect( container.style.left ).to.equal( '-9999px' );
- } );
- it( 'should move fake selection container between editables', () => {
- const viewEditable = new ViewEditableElement( viewDocument, 'div' );
- viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
- const domEditable = document.createElement( 'div' );
- document.body.appendChild( domEditable );
- domConverter.bindElements( domEditable, viewEditable );
- renderer.markToSync( 'children', viewEditable );
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- let container = document.getSelection().anchorNode;
- expect( domRoot.contains( container ) ).to.be.true;
- selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
- renderer.render();
- container = document.getSelection().anchorNode;
- expect( domEditable.contains( container ) ).to.be.true;
- domEditable.remove();
- } );
- it( 'should bind fake selection container to view selection', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- const bindSelection = renderer.domConverter.fakeSelectionToView( container );
- expect( bindSelection ).to.not.be.undefined;
- expect( bindSelection.isEqual( selection ) ).to.be.true;
- } );
- // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
- it( 'should handle situation when label got removed from the fake selection container', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( domConverter.mapDomToView( container ) ).to.be.undefined;
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- // Remove a text node (label) from the fake selection container.
- // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
- textNode.remove();
- renderer.render();
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
- } );
- // Use a forgiving way of checking what the selection contains
- // because Safari normalizes the selection ranges so precise checking is troublesome.
- // Also, Firefox returns a normal space instead of nbsp so we need to use even more alternatives.
- function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
- const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
- expect( domSelection.toString() ).to.match( expectedText );
- expect(
- domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
- ).to.be.true;
- }
- } );
- // #887
- describe( 'similar selection', () => {
- // Use spies to check selection updates. Some selection positions are not achievable in some
- // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
- let selectionCollapseSpy, selectionExtendSpy;
- afterEach( () => {
- if ( selectionCollapseSpy ) {
- selectionCollapseSpy.restore();
- selectionCollapseSpy = null;
- }
- if ( selectionExtendSpy ) {
- selectionExtendSpy.restore();
- selectionExtendSpy = null;
- }
- } );
- it( 'should always render collapsed selection even if it is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- } );
- it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{}<attribute:b></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- } );
- it( 'should always render non-collapsed selection if it not is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
- } );
- it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
- // Do not change view selection.
- // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
- // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
- // because DOM selection is in incorrect place.
- const domP = domRoot.childNodes[ 0 ];
- const domSpan = domP.childNodes[ 1 ];
- domSelection.collapse( domSpan, 0 );
- renderer.render();
- // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelection.anchorNode ).to.equal( domP );
- expect( domSelection.anchorOffset ).to.equal( 1 );
- };
- const assertSelectionInsideTextNode = () => {
- const textNode = domP.childNodes[ 0 ];
- expect( domSelection.anchorNode ).to.equal( textNode );
- expect( domSelection.anchorOffset ).to.equal( 3 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- } );
- // #1417
- describe( 'optimal rendering – reusing existing nodes', () => {
- it( 'should render inline element replacement (before text)', () => {
- viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
- } );
- it( 'should render inline element replacement (after text)', () => {
- viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
- } );
- it( 'should render inline element replacement (before text swapped order)', () => {
- viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
- } );
- it( 'should render inline element replacement (after text swapped order)', () => {
- viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
- } );
- it( 'should render single replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
- const domP = domRoot.childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
- expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
- } );
- it( 'should render replacement and insertion in p group', () => {
- const content = '' +
- '<container:p>1<attribute:i>A</attribute:i></container:p>' +
- '<container:p>2<attribute:i>B</attribute:i></container:p>' +
- '<container:p>3<attribute:i>C</attribute:i></container:p>';
- const replacement = '' +
- '<container:p><attribute:i>D</attribute:i></container:p>' +
- '<container:p>5<attribute:i>E</attribute:i></container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( replacement ) );
- const domP2 = domRoot.childNodes[ 1 ];
- const domP3 = domRoot.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should render replacement and deletion in p group', () => {
- const content = '' +
- '<container:p><attribute:i>A</attribute:i>1</container:p>' +
- '<container:p><attribute:i>B</attribute:i>2</container:p>' +
- '<container:p><attribute:i>C</attribute:i>3</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
- viewRoot._removeChildren( 0, 2 );
- viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
- const domP0 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
- expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- } );
- it( 'should render multiple continuous replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>' +
- '<container:p>4</container:p>' +
- '<container:p>5</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
- viewRoot._removeChildren( 0, 3 );
- viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
- const domP1 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- const domP4 = domRoot.childNodes[ 3 ];
- const domP5 = domRoot.childNodes[ 4 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
- expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
- expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should render multiple replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>' +
- '<container:p>4</container:p>' +
- '<container:p>5</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
- viewRoot._removeChildren( 4 );
- viewRoot._removeChildren( 1, 2 );
- viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
- viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
- const domP1 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- const domP4 = domRoot.childNodes[ 3 ];
- const domP5 = domRoot.childNodes[ 4 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
- expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
- expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should not rerender DOM when view replaced with the same structure', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content ) );
- const viewH = viewRoot.getChild( 0 );
- const viewP = viewRoot.getChild( 1 );
- const viewQ = viewRoot.getChild( 2 );
- const domH = domRoot.childNodes[ 0 ];
- const domHI = domH.childNodes[ 1 ];
- const domP = domRoot.childNodes[ 1 ];
- const domPT = domP.childNodes[ 0 ];
- const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
- const domQ = domRoot.childNodes[ 2 ];
- const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
- expect( domH.childNodes[ 1 ] ).to.equal( domHI );
- expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
- expect( domP.childNodes[ 0 ] ).to.equal( domPT );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
- expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
- expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domH ) ).to.equal( viewH );
- expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
- expect( mappings.get( domQ ) ).to.equal( viewQ );
- expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- } );
- // https://github.com/ckeditor/ckeditor5/issues/5734
- it( 'should not rerender DOM when view replaced with the same structure without a comment', () => {
- const domContent = '' +
- '<h2>He<i>ading 1</i></h2>' +
- '<p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a>' +
- '</p>' +
- '<!-- A comment to be ignored -->' +
- '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>';
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- domRoot.innerHTML = domContent;
- viewRoot._appendChild( parse( content ) );
- const viewH = viewRoot.getChild( 0 );
- const viewP = viewRoot.getChild( 1 );
- const viewQ = viewRoot.getChild( 2 );
- const domH = domRoot.childNodes[ 0 ];
- const domHI = domH.childNodes[ 1 ];
- const domP = domRoot.childNodes[ 1 ];
- const domPT = domP.childNodes[ 0 ];
- const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
- const domC = domRoot.childNodes[ 2 ];
- const domQ = domRoot.childNodes[ 3 ];
- const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert the comment is no longer in the content.
- expect( domRoot.contains( domC ), 'domRoot should not contain the comment' ).to.be.false;
- // Assert content, without the comment.
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- // Assert if other DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
- expect( domH.childNodes[ 1 ] ).to.equal( domHI );
- expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
- expect( domP.childNodes[ 0 ] ).to.equal( domPT );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
- // Note the shifted index of domQ, from 3 to 2.
- expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
- expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domH ) ).to.equal( viewH );
- expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
- expect( mappings.get( domQ ) ).to.equal( viewQ );
- expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- } );
- it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const content2 = '' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content2 ) );
- const viewP = viewRoot.getChild( 0 );
- const viewQ = viewRoot.getChild( 1 );
- const domP = domRoot.childNodes[ 1 ];
- const domPT = domP.childNodes[ 0 ];
- const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
- const domQ = domRoot.childNodes[ 2 ];
- const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
- expect( domP.childNodes[ 0 ] ).to.equal( domPT );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
- expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
- expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
- expect( mappings.get( domQ ) ).to.equal( viewQ );
- expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- } );
- it( 'should not rerender DOM when typing inside empty inline element', () => {
- const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
- viewRoot._appendChild( view );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 1 );
- viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
- const domP = domRoot.childNodes[ 0 ];
- const domText = domP.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- domB.innerHTML = 'a';
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
- expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
- } );
- it( 'should handle complex view duplication', () => {
- const content = '' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
- '</container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const expected = '' +
- '<blockquote>' +
- '<ul>' +
- '<li>Quoted <strong>item 1</strong></li>' +
- '<li>Item 2</li>' +
- '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
- '</ul>' +
- '</blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content + content ) );
- const domBQ = domRoot.childNodes[ 0 ];
- const domUL = domBQ.childNodes[ 0 ];
- const domLI1 = domUL.childNodes[ 0 ];
- const domLI2 = domUL.childNodes[ 1 ];
- const domLI3 = domUL.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( expected + expected );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
- expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
- expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
- expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
- expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
- // Assert mappings.
- const domMappings = renderer.domConverter._domToViewMapping;
- expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
- expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
- expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
- expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
- // Assert if new view elements are bind to new DOM elements.
- const viewMappings = renderer.domConverter._domToViewMapping;
- expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
- } );
- it( 'should handle complex view replace', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
- '</container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const replacement = '' +
- '<container:p>' +
- '1' +
- '<attribute:i>A</attribute:i>' +
- '</container:p>' +
- '<container:p>' +
- '<attribute:a href="https://cksource.com">' +
- 'Li' +
- '<attribute:strong>nk</attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:h1>' +
- 'Heading ' +
- '<attribute:strong>1</attribute:strong>' +
- '</container:h1>' +
- '<container:h2>' +
- '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
- '</container:h2>' +
- '<container:h3>' +
- 'Heading' +
- '<attribute:i> 3</attribute:i>' +
- '</container:h3>' +
- '<container:blockquote>' +
- 'Foo Bar Baz' +
- '</container:blockquote>' +
- '<container:ul>' +
- '<container:li>' +
- 'Item ' +
- '<attribute:strong>1</attribute:strong>' +
- '</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
- ' 2' +
- '</container:li>' +
- '</container:ul>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '' +
- '<h2>He<i>ading 1</i></h2>' +
- '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
- '<blockquote><ul>' +
- '<li>Quoted <strong>item 1</strong></li>' +
- '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
- '</ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( replacement ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Here we just check if new DOM structure was properly rendered.
- expect( domRoot.innerHTML ).to.equal( '' +
- '<p>1<i>A</i></p>' +
- '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
- '<h1>Heading <strong>1</strong></h1>' +
- '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
- '<h3>Heading<i> 3</i></h3>' +
- '<blockquote>Foo Bar Baz</blockquote>' +
- '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
- } );
- it( 'should handle br elements while refreshing bindings', () => {
- const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
- viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
- // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
- // refreshing mappings in a renderer. Simulate such behaviour (#1354).
- domRoot.childNodes[ 1 ].innerHTML = '<br>';
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- } );
- it( 'should handle list to paragraph conversion', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li>Item 1' +
- '<container:ol>' +
- '<container:li>Item 2</container:li>' +
- '</container:ol>' +
- '</container:li>' +
- '</container:ol>' +
- '<container:p>Paragraph</container:p>' +
- '<container:ol>' +
- '<container:li>Item 3' +
- '<container:ol>' +
- '<container:li>Item 4</container:li>' +
- '</container:ol>' +
- '</container:li>' +
- '</container:ol>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal(
- '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
- const viewOL1 = viewRoot.getChild( 0 );
- viewOL1.getChild( 0 )._removeChildren( 1 );
- viewRoot._removeChildren( 2 );
- viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
- viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
- viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
- const domOL1 = domRoot.childNodes[ 0 ];
- const domOL2 = domRoot.childNodes[ 2 ];
- const domP = domRoot.childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal(
- '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
- expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
- expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
- } );
- it( 'should handle attributes change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li data-index="1" align="left">Item 1</container:li>' +
- '</container:ol>' +
- '<container:p>Paragraph ' +
- '<attribute:a href="123">Link</attribute:a>' +
- '</container:p>' +
- '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li data-index="1" align="left">Item 1</li></ol>' +
- '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
- const viewOL = viewRoot.getChild( 0 );
- viewOL._removeChildren( 0 );
- viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
- const viewP1 = viewRoot.getChild( 1 );
- viewP1._removeChildren( 1 );
- viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
- viewRoot._removeChildren( 2 );
- viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL );
- renderer.markToSync( 'children', viewP1 );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
- '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
- } );
- it( 'should handle classes change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
- '</container:ol>' +
- '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
- const viewOL = viewRoot.getChild( 0 );
- const oldViewLI = viewOL.getChild( 0 );
- viewOL._removeChildren( 0 );
- viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
- const oldViewP = viewRoot.getChild( 1 );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
- renderer.markToSync( 'attributes', oldViewLI );
- renderer.markToSync( 'attributes', oldViewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
- } );
- it( 'should handle styles change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
- '<container:li>Bar ' +
- '<attribute:i>' +
- '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
- ' Bax</attribute:i>' +
- '</container:li>' +
- '</container:ol>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
- '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
- const viewOL = viewRoot.getChild( 0 );
- const viewLI1 = viewOL.getChild( 0 );
- const viewLI2 = viewOL.getChild( 1 );
- viewLI1._removeStyle( 'font-weight' );
- viewLI1._setStyle( { color: '#FFF' } );
- viewLI2._setStyle( { 'font-weight': 'bold' } );
- viewLI2._removeChildren( 0, viewLI2.childCount );
- viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
- '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
- renderer.markToSync( 'attributes', viewLI1 );
- renderer.markToSync( 'attributes', viewLI2 );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewLI2 );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li style="color:#FFF;">Foo</li>' +
- '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
- '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
- } );
- it( 'should handle uiElement rendering', () => {
- function createUIElement( id, text ) {
- const element = new ViewUIElement( viewDocument, 'span' );
- element.render = function( domDocument ) {
- const domElement = this.toDomElement( domDocument );
- domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
- return domElement;
- };
- return element;
- }
- const ui1 = createUIElement( 'id1', 'UI1' );
- const ui2 = createUIElement( 'id2', 'UI2' );
- const viewP = new ViewContainerElement( viewDocument, 'p', null, [
- new ViewText( viewDocument, 'Foo ' ),
- ui1,
- new ViewText( viewDocument, 'Bar' )
- ] );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild( 0, [ new ViewText( viewDocument, 'Foo' ), ui2, new ViewText( viewDocument, ' Bar' ) ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
- } );
- it( 'should handle RawElement rendering', () => {
- function createRawElement( id, text ) {
- const element = new ViewRawElement( viewDocument, 'span' );
- element.render = function( domElement ) {
- domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
- };
- return element;
- }
- const raw1 = createRawElement( 'id1', 'RAW1' );
- const raw2 = createRawElement( 'id2', 'RAW2' );
- const viewP = new ViewContainerElement( viewDocument, 'p', null, [
- new ViewText( viewDocument, 'Foo ' ),
- raw1,
- new ViewText( viewDocument, 'Bar' )
- ] );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo <span><span id="id1"><b>RAW1</b></span></span>Bar</p>' ) );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild( 0, [ new ViewText( viewDocument, 'Foo' ), raw2, new ViewText( viewDocument, ' Bar' ) ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo<span><span id="id2"><b>RAW2</b></span></span> Bar</p>' ) );
- } );
- it( 'should manage RawElement attributes', () => {
- const rawElement = new ViewRawElement( viewDocument, 'span', {
- foo: 'foo1',
- baz: 'baz1'
- } );
- rawElement.render = function( domElement ) {
- domElement.innerHTML = '<b>foo</b>';
- };
- const viewP = new ViewContainerElement( viewDocument, 'p', null, [ rawElement ] );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p><span baz="baz1" foo="foo1"><b>foo</b></span></p>' ) );
- rawElement._setAttribute( 'foo', 'foo2' );
- rawElement._setAttribute( 'new', 'new-value' );
- rawElement._removeAttribute( 'baz' );
- renderer.markToSync( 'attributes', rawElement );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p><span foo="foo2" new="new-value"><b>foo</b></span></p>' ) );
- } );
- it( 'should handle linking entire content', () => {
- viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- // While linking, the existing DOM children are moved to a new `a` element during binding
- // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
- // where view elements were moved to a newly created link view element.
- const viewA = new ViewAttributeElement( viewDocument, 'a', { href: '#href' }, [
- new ViewText( viewDocument, 'Foo' ),
- viewP.getChild( 1 )
- ] );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild( 0, viewA );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
- } );
- // https://github.com/ckeditor/ckeditor5/issues/6367.
- it( 'should correctly handle moving a DOM element when rendering children', () => {
- viewRoot._insertChild( 0, parse( 'y<attribute:span>x</attribute:span>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const viewSpan = viewRoot._removeChildren( 1, 1 )[ 0 ];
- viewRoot._insertChild( 0, viewSpan );
- viewRoot._insertChild( 2, parse( '<attribute:strong>z</attribute:strong>' ) );
- renderer.markToSync( 'children', viewRoot );
- // This would throw without a fix.
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<span>x</span>y<strong>z</strong>' );
- } );
- // https://github.com/ckeditor/ckeditor5/issues/6367, but more complex
- it( 'should correctly handle moving a DOM element when rendering children (more complex case)', () => {
- viewRoot._insertChild( 0,
- parse( '1<attribute:span>2</attribute:span><attribute:span>3</attribute:span>4<attribute:span>5</attribute:span>' )
- );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const viewSpan5 = viewRoot._removeChildren( 4, 1 )[ 0 ];
- const viewSpan2 = viewRoot._removeChildren( 1, 1 )[ 0 ];
- viewRoot._insertChild( 0, viewSpan2 );
- viewRoot._insertChild( 1, parse( '<attribute:strong>6</attribute:strong>' ) );
- viewRoot._insertChild( 4, parse( '<attribute:strong>7</attribute:strong>' ) );
- viewRoot._insertChild( 2, viewSpan5 );
- renderer.markToSync( 'children', viewRoot );
- // This would throw without a fix.
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<span>2</span><strong>6</strong><span>5</span>1<span>3</span><strong>7</strong>4' );
- } );
- } );
- describe( 'optimal (minimal) rendering – minimal children changes', () => {
- let observer;
- beforeEach( () => {
- observer = new MutationObserver( () => {} );
- observer.observe( domRoot, {
- childList: true,
- attributes: false,
- subtree: false
- } );
- } );
- afterEach( () => {
- observer.disconnect();
- } );
- it( 'should add only one child (at the beginning)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (at the end)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (in the middle)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch elements at all (rendering texts is enough)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
- } );
- it( 'should remove and add one', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1',
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch the FSC when rendering children', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- // Set fake selection on the second paragraph.
- selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- // Remove the second paragraph.
- viewRoot._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- } );
- it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
- // This test's purpose is mostly reaching 100% CC.
- observer = new MutationObserver( () => {} );
- viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
- const viewDiv = viewRoot.getChild( 0 );
- // Set fake selection on the second paragraph.
- selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- observer.observe( domRoot.childNodes[ 0 ], {
- childList: true,
- attributes: false,
- subtree: false
- } );
- // Remove the second paragraph.
- viewDiv._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- observer.disconnect();
- } );
- describe( 'using fastDiff() - significant number of nodes in the editor', () => {
- it( 'should add only one child (at the beginning)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (at the end)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (in the middle)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch elements at all (rendering texts is enough)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
- } );
- it( 'should remove and add one', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1',
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch the FSC when rendering children', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- // Set fake selection on the second paragraph.
- selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- // Remove the second paragraph.
- viewRoot._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- } );
- } );
- function getMutationStats( mutationList ) {
- return mutationList.map( mutation => {
- return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
- } );
- }
- function cleanObserver( observer ) {
- observer.takeRecords();
- }
- function makeContainers( howMany ) {
- const containers = [];
- for ( let i = 1; i <= howMany; i++ ) {
- containers.push( `<container:p>${ i }</container:p>` );
- }
- return containers.join( '' );
- }
- } );
- // #1560
- describe( 'attributes manipulation on replaced element', () => {
- it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
- const writer = new DowncastWriter( viewDocument );
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- const viewP = viewRoot.getChild( 0 );
- writer.setAttribute( 'data-placeholder', 'Body', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
- // 2. Modify view.
- writer.removeAttribute( 'data-placeholder', viewP );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'attributes', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
- } );
- it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
- const writer = new DowncastWriter( viewDocument );
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
- const viewP = viewRoot.getChild( 1 );
- writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
- // 2. Modify view.
- writer.removeClass( 'cke-test2', viewP );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
- '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
- renderer.markToSync( 'attributes', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
- } );
- it( 'should rerender element if it was removed and have its attributes removed after', () => {
- const writer = new DowncastWriter( viewDocument );
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- const viewP = viewRoot.getChild( 0 );
- writer.setAttribute( 'data-placeholder', 'Body', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
- // 2. Modify view.
- viewRoot._removeChildren( 0, viewRoot.childCount );
- writer.removeAttribute( 'data-placeholder', viewP );
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
- } );
- } );
- // ckeditor/ckeditor5-utils#269
- // The expected times has a significant margin above the usual execution time (which is around 40-50%
- // of the expected time) because it depends on the browser and environment in which tests are run.
- // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
- // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
- describe( 'rendering performance', () => {
- before( function() {
- // Ignore on Edge browser where performance is quite poor.
- if ( env.isEdge ) {
- this.skip();
- }
- } );
- it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- function measureRenderingTime( viewRoot, initialData, newData ) {
- // Set initial data.
- const initialView = parse( initialData );
- viewRoot._appendChild( initialView );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Set new data.
- const newView = parse( newData );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( newView );
- renderer.markToSync( 'children', viewRoot );
- // Measure render time.
- const start = Date.now();
- renderer.render();
- return Date.now() - start;
- }
- function generateViewData1( repeat = 1 ) {
- const viewData = '' +
- '<container:h1>' +
- 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
- '</container:h1>' +
- '<container:p>' +
- 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
- '</container:p>' +
- '<container:ul>' +
- '<container:li>Item 1</container:li>' +
- '</container:ul>' +
- '<container:ul>' +
- '<container:li>Item 2</container:li>' +
- '</container:ul>' +
- '<container:ul>' +
- '<container:li>Item 3</container:li>' +
- '</container:ul>';
- return viewData.repeat( repeat );
- }
- function generateViewData2( repeat = 1 ) {
- const viewData = '' +
- '<container:ol>' +
- '<container:li>' +
- '<attribute:strong>Foo</attribute:strong>' +
- '</container:li>' +
- '</container:ol>' +
- '<container:ol>' +
- '<container:li>Item 1</container:li>' +
- '</container:ol>' +
- '<container:h1>Heading 1</container:h1>' +
- '<container:h2>' +
- '<attribute:strong>Heading</attribute:strong> 2' +
- '</container:h2>' +
- '<container:h3>Heading 4</container:h3>';
- return viewData.repeat( repeat );
- }
- } );
- } );
- describe( '#922', () => {
- let view, viewDoc, viewRoot, domRoot, converter;
- beforeEach( () => {
- view = new View( new StylesProcessor() );
- viewDoc = view.document;
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- viewRoot = createViewRoot( viewDoc );
- view.attachDomRoot( domRoot );
- converter = view.domConverter;
- } );
- afterEach( () => {
- view.destroy();
- domRoot.remove();
- } );
- it( 'should properly render unwrapped attributes #1', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>f</attribute:strong>' +
- '</attribute:italic>]' +
- '<attribute:strong>oo</attribute:strong>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Unwrap italic attribute element.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render unwrapped attributes #2', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>foo</attribute:strong>' +
- '</attribute:italic>]' +
- '</container:p>' );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Unwrap italic attribute element and change text inside.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
- } );
- viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
- expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #1', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #2', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should not unbind elements that are removed and reinserted to DOM', () => {
- setViewData( view,
- '<container:p>' +
- '<attribute:b></attribute:b>' +
- '<attribute:i></attribute:i>' +
- '<attribute:span></attribute:span>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Remove first element and reinsert it at the end.
- const container = viewRoot.getChild( 0 );
- const firstElement = container.getChild( 0 );
- view.change( writer => {
- writer.remove( ViewRange._createOn( firstElement ) );
- writer.insert( new ViewPosition( container, 2 ), firstElement );
- } );
- expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- // Checks if every node in DOM tree is mapped to the view.
- function checkMappings() {
- const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
- while ( domWalker.nextNode() ) {
- const node = domWalker.currentNode;
- if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
- return false;
- }
- }
- return true;
- }
- } );
- describe( '_markDescendantTextToSync', () => {
- let viewRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( viewDocument, 'div' );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- } );
- it( 'should handle null values', () => {
- // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
- renderer._markDescendantTextToSync( null );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should handle element nodes', () => {
- const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 3 );
- } );
- it( 'should handle text nodes', () => {
- const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 1 );
- } );
- it( 'should handle document fragment', () => {
- const fragment = new DocumentFragment();
- renderer._markDescendantTextToSync( fragment );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should handle empty element nodes', () => {
- const viewP = parse( '<container:p></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- } );
- describe( '_updateText', () => {
- let viewRoot, domRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( viewDocument, 'div' );
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- domConverter.bindElements( domRoot, viewRoot );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- renderer.isFocused = true;
- } );
- afterEach( () => {
- domRoot.remove();
- } );
- it( 'should update text - change on end', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'fobar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
- } );
- it( 'should update text - change on start', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'baro';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
- } );
- it( 'should update text - change in the middle', () => {
- const viewText = new ViewText( viewDocument, 'foobar' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
- viewText._data = 'fobazr';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
- } );
- it( 'should update text - empty expected', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = '';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- } );
- it( 'should update text - empty actual', () => {
- const viewText = new ViewText( viewDocument, '' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- viewText._data = 'fobar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
- } );
- it( 'should handle filler during text modifications', () => {
- const viewText = new ViewText( viewDocument, 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'barfoo';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
- // 3. Remove filler.
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
- } );
- it( 'should handle filler during text modifications - empty text', () => {
- const viewText = new ViewText( viewDocument, '' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'foo';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 3. Remove filler.
- viewText._data = '';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- } );
- it( 'should handle filler during text modifications inside inline element', () => {
- const viewB = new ViewElement( viewDocument, 'b' );
- const viewText = new ViewText( viewDocument, 'foo' );
- viewB._appendChild( viewText );
- viewRoot._appendChild( viewB );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'bar';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
- // 3. Remove filler.
- viewText._data = 'bar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- } );
- } );
- } );
- function renderAndExpectNoChanges( renderer, domRoot ) {
- const config = {
- childList: true,
- characterData: true,
- characterDataOldValue: true,
- subtree: true
- };
- const mutationObserver = new window.MutationObserver( () => {
- throw 'There should be not mutations';
- } );
- mutationObserver.observe( domRoot, config );
- renderer.render();
- const records = mutationObserver.takeRecords();
- mutationObserver.disconnect();
- expect( records.length ).to.equal( 0 );
- }
|