renderer.js 144 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123
  1. /**
  2. * @license Copyright (c) 2003-2019, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter, MutationObserver */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewEditableElement from '../../src/view/editableelement';
  9. import ViewContainerElement from '../../src/view/containerelement';
  10. import ViewAttributeElement from '../../src/view/attributeelement';
  11. import ViewText from '../../src/view/text';
  12. import ViewRange from '../../src/view/range';
  13. import ViewPosition from '../../src/view/position';
  14. import UIElement from '../../src/view/uielement';
  15. import DocumentSelection from '../../src/view/documentselection';
  16. import DomConverter from '../../src/view/domconverter';
  17. import Renderer from '../../src/view/renderer';
  18. import DocumentFragment from '../../src/view/documentfragment';
  19. import DowncastWriter from '../../src/view/downcastwriter';
  20. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  21. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  22. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  23. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  24. import createViewRoot from './_utils/createroot';
  25. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  26. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  27. import env from '@ckeditor/ckeditor5-utils/src/env';
  28. describe( 'Renderer', () => {
  29. let selection, domConverter, renderer;
  30. testUtils.createSinonSandbox();
  31. beforeEach( () => {
  32. selection = new DocumentSelection();
  33. domConverter = new DomConverter();
  34. renderer = new Renderer( domConverter, selection );
  35. renderer.domDocuments.add( document );
  36. } );
  37. describe( 'markToSync', () => {
  38. let viewRoot;
  39. beforeEach( () => {
  40. viewRoot = new ViewElement( 'p' );
  41. const domRoot = document.createElement( 'p' );
  42. domConverter.bindElements( domRoot, viewRoot );
  43. viewRoot._appendChild( new ViewText( 'foo' ) );
  44. renderer.markedTexts.clear();
  45. renderer.markedAttributes.clear();
  46. renderer.markedChildren.clear();
  47. } );
  48. it( 'should mark attributes which need update', () => {
  49. viewRoot._setAttribute( 'class', 'foo' );
  50. renderer.markToSync( 'attributes', viewRoot );
  51. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  52. } );
  53. it( 'should mark children which need update', () => {
  54. viewRoot._appendChild( new ViewText( 'foo' ) );
  55. renderer.markToSync( 'children', viewRoot );
  56. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  57. } );
  58. it( 'should not mark children if element has no corresponding node', () => {
  59. // Overwrite viewRoot with node without coresponding DOM node.
  60. viewRoot = new ViewElement( 'p' );
  61. viewRoot._appendChild( new ViewText( 'foo' ) );
  62. renderer.markToSync( 'children', viewRoot );
  63. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  64. } );
  65. it( 'should mark text which need update', () => {
  66. const viewText = new ViewText( 'foo' );
  67. viewRoot._appendChild( viewText );
  68. viewText._data = 'bar';
  69. renderer.markToSync( 'text', viewText );
  70. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  71. } );
  72. it( 'should not mark text if parent has no corresponding node', () => {
  73. const viewText = new ViewText( 'foo' );
  74. // Overwrite viewRoot with node without coresponding DOM node.
  75. viewRoot = new ViewElement( 'p' );
  76. viewRoot._appendChild( viewText );
  77. viewText._data = 'bar';
  78. renderer.markToSync( 'text', viewText );
  79. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  80. } );
  81. it( 'should throw if the type is unknown', () => {
  82. expect( () => {
  83. renderer.markToSync( 'UNKNOWN', viewRoot );
  84. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  85. } );
  86. } );
  87. describe( 'render', () => {
  88. let viewRoot, domRoot;
  89. beforeEach( () => {
  90. viewRoot = new ViewEditableElement( 'div' );
  91. viewRoot.getFillerOffset = () => null;
  92. domRoot = document.createElement( 'div' );
  93. document.body.appendChild( domRoot );
  94. domConverter.bindElements( domRoot, viewRoot );
  95. renderer.markedTexts.clear();
  96. renderer.markedAttributes.clear();
  97. renderer.markedChildren.clear();
  98. selection._setTo( null );
  99. renderer.isFocused = true;
  100. } );
  101. afterEach( () => {
  102. domRoot.remove();
  103. } );
  104. it( 'should update attributes', () => {
  105. viewRoot._setAttribute( 'class', 'foo' );
  106. renderer.markToSync( 'attributes', viewRoot );
  107. renderer.render();
  108. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  109. expect( renderer.markedAttributes.size ).to.equal( 0 );
  110. } );
  111. it( 'should remove attributes', () => {
  112. viewRoot._setAttribute( 'class', 'foo' );
  113. domRoot.setAttribute( 'id', 'bar' );
  114. domRoot.setAttribute( 'class', 'bar' );
  115. renderer.markToSync( 'attributes', viewRoot );
  116. renderer.render();
  117. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  118. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  119. expect( renderer.markedAttributes.size ).to.equal( 0 );
  120. } );
  121. it( 'should add children', () => {
  122. viewRoot._appendChild( new ViewText( 'foo' ) );
  123. renderer.markToSync( 'children', viewRoot );
  124. renderer.render();
  125. expect( domRoot.childNodes.length ).to.equal( 1 );
  126. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  127. expect( renderer.markedChildren.size ).to.equal( 0 );
  128. } );
  129. it( 'should remove children', () => {
  130. viewRoot._appendChild( new ViewText( 'foo' ) );
  131. renderer.markToSync( 'children', viewRoot );
  132. renderer.render();
  133. expect( domRoot.childNodes.length ).to.equal( 1 );
  134. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  135. viewRoot._removeChildren( 0, 1 );
  136. renderer.markToSync( 'children', viewRoot );
  137. renderer.render();
  138. expect( domRoot.childNodes.length ).to.equal( 0 );
  139. expect( renderer.markedChildren.size ).to.equal( 0 );
  140. } );
  141. it( 'should update text', () => {
  142. const viewText = new ViewText( 'foo' );
  143. viewRoot._appendChild( viewText );
  144. renderer.markToSync( 'children', viewRoot );
  145. renderer.render();
  146. expect( domRoot.childNodes.length ).to.equal( 1 );
  147. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  148. viewText._data = 'bar';
  149. renderer.markToSync( 'text', viewText );
  150. renderer.render();
  151. expect( domRoot.childNodes.length ).to.equal( 1 );
  152. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  153. expect( renderer.markedTexts.size ).to.equal( 0 );
  154. } );
  155. it( 'should not update same text', () => {
  156. const viewText = new ViewText( 'foo' );
  157. viewRoot._appendChild( viewText );
  158. renderer.markToSync( 'children', viewRoot );
  159. renderer.render();
  160. expect( domRoot.childNodes.length ).to.equal( 1 );
  161. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  162. viewText._data = 'foo';
  163. renderer.markToSync( 'text', viewText );
  164. renderAndExpectNoChanges( renderer, domRoot );
  165. expect( domRoot.childNodes.length ).to.equal( 1 );
  166. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  167. expect( renderer.markedTexts.size ).to.equal( 0 );
  168. } );
  169. it( 'should not update text parent child list changed', () => {
  170. const viewImg = new ViewElement( 'img' );
  171. const viewText = new ViewText( 'foo' );
  172. viewRoot._appendChild( [ viewImg, viewText ] );
  173. renderer.markToSync( 'children', viewRoot );
  174. renderer.markToSync( 'text', viewText );
  175. renderer.render();
  176. expect( domRoot.childNodes.length ).to.equal( 2 );
  177. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  178. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  179. } );
  180. it( 'should not change text if it is the same during text rendering', () => {
  181. const viewText = new ViewText( 'foo' );
  182. viewRoot._appendChild( viewText );
  183. renderer.markToSync( 'children', viewRoot );
  184. renderer.render();
  185. // This should not be changed during the render.
  186. const domText = domRoot.childNodes[ 0 ];
  187. renderer.markToSync( 'text', viewText );
  188. renderer.render();
  189. expect( domRoot.childNodes.length ).to.equal( 1 );
  190. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  191. } );
  192. it( 'should not change text if it is the same during children rendering', () => {
  193. const viewText = new ViewText( 'foo' );
  194. viewRoot._appendChild( viewText );
  195. renderer.markToSync( 'children', viewRoot );
  196. renderer.render();
  197. // This should not be changed during the render.
  198. const domText = domRoot.childNodes[ 0 ];
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. expect( domRoot.childNodes.length ).to.equal( 1 );
  202. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  203. } );
  204. it( 'should not change element if it is the same', () => {
  205. const viewImg = new ViewElement( 'img' );
  206. viewRoot._appendChild( viewImg );
  207. // This should not be changed during the render.
  208. const domImg = document.createElement( 'img' );
  209. domRoot.appendChild( domImg );
  210. domConverter.bindElements( domImg, viewImg );
  211. renderer.markToSync( 'children', viewRoot );
  212. renderer.render();
  213. expect( domRoot.childNodes.length ).to.equal( 1 );
  214. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  215. } );
  216. it( 'should change element if it is different', () => {
  217. const viewImg = new ViewElement( 'img' );
  218. viewRoot._appendChild( viewImg );
  219. renderer.markToSync( 'children', viewRoot );
  220. renderer.render();
  221. const viewP = new ViewElement( 'p' );
  222. viewRoot._removeChildren( 0, 1 );
  223. viewRoot._appendChild( viewP );
  224. renderer.markToSync( 'children', viewRoot );
  225. renderer.render();
  226. expect( domRoot.childNodes.length ).to.equal( 1 );
  227. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  228. } );
  229. it( 'should update removed item when it is reinserted', () => {
  230. const viewFoo = new ViewText( 'foo' );
  231. const viewP = new ViewElement( 'p', null, viewFoo );
  232. const viewDiv = new ViewElement( 'div', null, viewP );
  233. viewRoot._appendChild( viewDiv );
  234. renderer.markToSync( 'children', viewRoot );
  235. renderer.render();
  236. viewDiv._removeChildren( 0, 1 );
  237. renderer.markToSync( 'children', viewDiv );
  238. renderer.render();
  239. viewP._removeChildren( 0, 1 );
  240. viewDiv._appendChild( viewP );
  241. renderer.markToSync( 'children', viewDiv );
  242. renderer.render();
  243. expect( domRoot.childNodes.length ).to.equal( 1 );
  244. const domDiv = domRoot.childNodes[ 0 ];
  245. expect( domDiv.tagName ).to.equal( 'DIV' );
  246. expect( domDiv.childNodes.length ).to.equal( 1 );
  247. const domP = domDiv.childNodes[ 0 ];
  248. expect( domP.tagName ).to.equal( 'P' );
  249. expect( domP.childNodes.length ).to.equal( 0 );
  250. } );
  251. it( 'should update removed item when it is reinserted #2', () => {
  252. // Prepare view: root -> div "outer" -> div "inner" -> p.
  253. const viewP = new ViewElement( 'p' );
  254. const viewDivInner = new ViewElement( 'div', null, viewP );
  255. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  256. viewRoot._appendChild( viewDivOuter );
  257. // Render view tree to DOM.
  258. renderer.markToSync( 'children', viewRoot );
  259. renderer.render();
  260. // Remove div "outer" from root and render it.
  261. viewDivOuter._remove();
  262. renderer.markToSync( 'children', viewRoot );
  263. renderer.render();
  264. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  265. viewP._remove();
  266. // Add div "outer" back to root.
  267. viewRoot._appendChild( viewDivOuter );
  268. renderer.markToSync( 'children', viewRoot );
  269. // Render changes, view is: root -> div "outer" -> div "inner".
  270. renderer.render();
  271. // Same is expected in DOM.
  272. expect( domRoot.childNodes.length ).to.equal( 1 );
  273. const domDivOuter = domRoot.childNodes[ 0 ];
  274. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  275. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  276. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  277. const domDivInner = domDivOuter.childNodes[ 0 ];
  278. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  279. expect( domDivInner.tagName ).to.equal( 'DIV' );
  280. expect( domDivInner.childNodes.length ).to.equal( 0 );
  281. } );
  282. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  283. const viewFoo = new ViewText( 'foo' );
  284. const viewP = new ViewElement( 'p', null, viewFoo );
  285. const viewDiv = new ViewElement( 'div', null, viewP );
  286. viewRoot._appendChild( viewDiv );
  287. renderer.markToSync( 'children', viewRoot );
  288. renderer.render();
  289. viewRoot._removeChildren( 0, 1 );
  290. renderer.markToSync( 'children', viewRoot );
  291. viewDiv._removeChildren( 0, 1 );
  292. renderer.markToSync( 'children', viewDiv );
  293. viewP._removeChildren( 0, 1 );
  294. renderer.markToSync( 'children', viewP );
  295. renderer.render();
  296. expect( domRoot.childNodes.length ).to.equal( 0 );
  297. } );
  298. it( 'should not care about filler if there is no DOM', () => {
  299. const { view: viewP, selection: newSelection } = parse(
  300. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  301. const viewRoot = new ViewElement( 'p' );
  302. viewRoot._appendChild( viewP );
  303. selection._setTo( newSelection );
  304. renderer.markToSync( 'children', viewRoot );
  305. renderer.render();
  306. // Expect no error on render.
  307. expect( viewRoot ).to.be.ok;
  308. } );
  309. it( 'should not add filler when inside contenteditable=false parent', () => {
  310. const { view: viewP, selection: newSelection } = parse(
  311. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  312. viewRoot._appendChild( viewP );
  313. selection._setTo( newSelection );
  314. renderer.markToSync( 'children', viewRoot );
  315. renderer.render();
  316. expect( domRoot.childNodes.length ).to.equal( 1 );
  317. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  318. const domP = domRoot.childNodes[ 0 ];
  319. expect( domP.childNodes.length ).to.equal( 3 );
  320. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  321. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  322. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  323. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  324. } );
  325. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  326. const { view: viewP, selection: newSelection } = parse(
  327. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  328. viewRoot._appendChild( viewP );
  329. selection._setTo( newSelection );
  330. renderer.markToSync( 'children', viewRoot );
  331. renderer.render();
  332. expect( domRoot.childNodes.length ).to.equal( 1 );
  333. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  334. const domP = domRoot.childNodes[ 0 ];
  335. expect( domP.childNodes.length ).to.equal( 3 );
  336. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  337. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  338. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  339. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  340. } );
  341. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  342. const domSelection = document.getSelection();
  343. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  344. const { view: viewP, selection: newSelection } = parse(
  345. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  346. viewRoot._appendChild( viewP );
  347. selection._setTo( newSelection );
  348. renderer.markToSync( 'children', viewRoot );
  349. renderer.render();
  350. expect( domRoot.childNodes.length ).to.equal( 1 );
  351. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  352. const domP = domRoot.childNodes[ 0 ];
  353. expect( domP.childNodes.length ).to.equal( 3 );
  354. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  355. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  356. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  357. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  358. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  359. expect( domSelection.rangeCount ).to.equal( 1 );
  360. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  361. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  362. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  363. // Step 2: No mutation on second render
  364. renderer.markToSync( 'children', viewRoot );
  365. renderer.markToSync( 'children', viewP );
  366. renderAndExpectNoChanges( renderer, domRoot );
  367. // Step 3: <p>foo{}<b></b></p>
  368. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  369. renderer.render();
  370. expect( domP.childNodes.length ).to.equal( 3 );
  371. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  372. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  373. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  374. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  375. expect( domSelection.rangeCount ).to.equal( 1 );
  376. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  377. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  378. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  379. // Step 4: No mutation on second render
  380. renderer.markToSync( 'children', viewRoot );
  381. renderer.markToSync( 'children', viewP );
  382. renderAndExpectNoChanges( renderer, domRoot );
  383. } );
  384. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  385. const domSelection = document.getSelection();
  386. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  387. const { view: viewP, selection: newSelection } = parse(
  388. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  389. viewRoot._appendChild( viewP );
  390. selection._setTo( newSelection );
  391. renderer.markToSync( 'children', viewRoot );
  392. renderer.render();
  393. const domP = domRoot.childNodes[ 0 ];
  394. expect( domP.childNodes.length ).to.equal( 2 );
  395. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  396. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  397. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  398. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  399. expect( domSelection.rangeCount ).to.equal( 1 );
  400. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  401. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  402. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  403. // Step 2: No mutation on second render
  404. renderer.markToSync( 'children', viewP );
  405. renderAndExpectNoChanges( renderer, domRoot );
  406. // Step 3: <p><b>{}foo</b></p>
  407. selection._setTo( ViewRange._createFromParentsAndOffsets(
  408. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  409. renderer.render();
  410. expect( domP.childNodes.length ).to.equal( 1 );
  411. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  412. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  413. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  414. expect( domSelection.rangeCount ).to.equal( 1 );
  415. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  416. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  417. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  418. // Step 4: No mutation on second render
  419. renderer.markToSync( 'children', viewP );
  420. renderAndExpectNoChanges( renderer, domRoot );
  421. } );
  422. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  423. const domSelection = document.getSelection();
  424. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  425. const { view: viewP, selection: newSelection } = parse(
  426. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  427. viewRoot._appendChild( viewP );
  428. selection._setTo( newSelection );
  429. renderer.markToSync( 'children', viewRoot );
  430. renderer.render();
  431. const domP = domRoot.childNodes[ 0 ];
  432. expect( domP.childNodes.length ).to.equal( 2 );
  433. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  434. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  435. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  436. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  437. expect( domSelection.rangeCount ).to.equal( 1 );
  438. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  439. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  440. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  441. // Step 2: No mutation on second render
  442. renderer.markToSync( 'children', viewP );
  443. renderAndExpectNoChanges( renderer, domRoot );
  444. // Step 3: <p><b>foo{}</b></p>
  445. selection._setTo( ViewRange._createFromParentsAndOffsets(
  446. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  447. renderer.render();
  448. expect( domP.childNodes.length ).to.equal( 1 );
  449. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  450. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  451. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  452. expect( domSelection.rangeCount ).to.equal( 1 );
  453. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  454. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  455. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  456. // Step 4: No mutation on second render
  457. renderer.markToSync( 'children', viewP );
  458. renderAndExpectNoChanges( renderer, domRoot );
  459. } );
  460. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  461. const domSelection = document.getSelection();
  462. const { view: viewP, selection: newSelection } = parse(
  463. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  464. viewRoot._appendChild( viewP );
  465. selection._setTo( newSelection );
  466. renderer.markToSync( 'children', viewRoot );
  467. renderer.render();
  468. const domP = domRoot.childNodes[ 0 ];
  469. expect( domP.childNodes.length ).to.equal( 3 );
  470. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  471. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  472. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  473. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  474. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  475. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  476. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  477. expect( domSelection.rangeCount ).to.equal( 1 );
  478. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  479. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  480. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  481. } );
  482. it( 'should move filler when selection is moved', () => {
  483. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  484. const { view: viewP, selection: newSelection } = parse(
  485. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  486. viewRoot._appendChild( viewP );
  487. selection._setTo( newSelection );
  488. renderer.markToSync( 'children', viewRoot );
  489. renderer.render();
  490. const domP = domRoot.childNodes[ 0 ];
  491. expect( domP.childNodes.length ).to.equal( 3 );
  492. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  493. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  494. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  495. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  496. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  497. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  498. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  499. const viewI = viewP.getChild( 2 );
  500. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  501. renderer.render();
  502. expect( domP.childNodes.length ).to.equal( 3 );
  503. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  504. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  505. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  506. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  507. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  508. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  509. } );
  510. it( 'should remove filler when text is added and selection removed', () => {
  511. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  512. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  513. const viewB = viewP.getChild( 1 );
  514. viewRoot._appendChild( viewP );
  515. selection._setTo( newSelection );
  516. renderer.markToSync( 'children', viewRoot );
  517. renderer.render();
  518. const domP = domRoot.childNodes[ 0 ];
  519. expect( domP.childNodes.length ).to.equal( 2 );
  520. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  521. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  522. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  523. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  524. // Step 2: Add text node.
  525. const viewText = new ViewText( 'x' );
  526. viewB._appendChild( viewText );
  527. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  528. renderer.markToSync( 'children', viewB );
  529. renderer.render();
  530. // Step 3: Remove selection from the view.
  531. selection._setTo( null );
  532. renderer.render();
  533. expect( domP.childNodes.length ).to.equal( 2 );
  534. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  535. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  536. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  537. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  538. } );
  539. // #659
  540. // The element before the filler is removed so the position of the filler
  541. // cannot be remembered as parent+offset.
  542. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  543. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  544. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  545. viewRoot._appendChild( viewP );
  546. selection._setTo( newSelection );
  547. renderer.markToSync( 'children', viewRoot );
  548. renderer.render();
  549. const domP = domRoot.childNodes[ 0 ];
  550. expect( domP.childNodes.length ).to.equal( 3 );
  551. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  552. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  553. viewP._removeChildren( 1 );
  554. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  555. renderer.markToSync( 'children', viewP );
  556. renderer.render();
  557. // Step 3: Check whether there's no filler in the DOM.
  558. expect( domP.childNodes.length ).to.equal( 1 );
  559. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  560. } );
  561. // #659
  562. it( 'should remove filler from a modified DOM when children moved', () => {
  563. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  564. const { view: viewFragment, selection: newSelection } = parse(
  565. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  566. );
  567. viewRoot._appendChild( viewFragment );
  568. selection._setTo( newSelection );
  569. renderer.markToSync( 'children', viewRoot );
  570. renderer.render();
  571. expect( domRoot.childNodes.length ).to.equal( 2 );
  572. const domP = domRoot.childNodes[ 0 ];
  573. const domP2 = domRoot.childNodes[ 1 ];
  574. expect( domP.childNodes.length ).to.equal( 3 );
  575. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  576. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  577. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  578. const viewP = viewRoot.getChild( 0 );
  579. const viewP2 = viewRoot.getChild( 1 );
  580. const removedChildren = viewP._removeChildren( 0, 2 );
  581. viewP2._appendChild( removedChildren );
  582. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  583. renderer.markToSync( 'children', viewP );
  584. renderer.markToSync( 'children', viewP2 );
  585. renderer.render();
  586. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  587. // in the second one there are two <b> tags.
  588. expect( domP.childNodes.length ).to.equal( 1 );
  589. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  590. expect( domP2.childNodes.length ).to.equal( 2 );
  591. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  592. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  593. } );
  594. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  595. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  596. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  597. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  598. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  599. viewRoot._appendChild( viewP );
  600. selection._setTo( newSelection );
  601. renderer.markToSync( 'children', viewRoot );
  602. renderer.render();
  603. const domP = domRoot.childNodes[ 0 ];
  604. expect( domP.childNodes.length ).to.equal( 2 );
  605. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  606. // Step 2: Move selection to a new attribute element and remove the previous one
  607. viewP._removeChildren( 1 ); // Remove <b>.
  608. const viewI = parse( '<attribute:i></attribute:i>' );
  609. viewP._appendChild( viewI );
  610. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  611. renderer.markToSync( 'children', viewP );
  612. renderer.render();
  613. // Step 3: Check whether new filler was created in the <i> element.
  614. expect( domP.childNodes.length ).to.equal( 2 );
  615. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  616. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  617. } );
  618. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  619. // that has not been yet rendered/bound to DOM.
  620. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  621. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  622. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  623. viewRoot._appendChild( viewP );
  624. selection._setTo( newSelection );
  625. renderer.markToSync( 'children', viewRoot );
  626. renderer.render();
  627. const domP = domRoot.childNodes[ 0 ];
  628. expect( domP.childNodes.length ).to.equal( 3 );
  629. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  630. // Step 2: Move selection to a new attribute element.
  631. const viewAbc = parse( 'abc' );
  632. viewP._appendChild( viewAbc );
  633. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  634. renderer.markToSync( 'children', viewP );
  635. renderer.render();
  636. // Step 3: Check whether old filler was removed.
  637. expect( domP.childNodes.length ).to.equal( 3 );
  638. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  639. } );
  640. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  641. const domSelection = document.getSelection();
  642. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  643. viewRoot._appendChild( viewP );
  644. selection._setTo( newSelection );
  645. renderer.markToSync( 'children', viewRoot );
  646. renderer.render();
  647. const domP = domRoot.childNodes[ 0 ];
  648. expect( domP.childNodes.length ).to.equal( 1 );
  649. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  650. expect( domSelection.rangeCount ).to.equal( 1 );
  651. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  652. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  653. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  654. // Remove filler and add text node to both DOM and View <p>x{}</p>
  655. domP.removeChild( domP.childNodes[ 0 ] );
  656. domP.appendChild( document.createTextNode( 'x' ) );
  657. domSelection.removeAllRanges();
  658. const domRange = document.createRange();
  659. domRange.setStart( domP.childNodes[ 0 ], 1 );
  660. domRange.collapse( true );
  661. domSelection.addRange( domRange );
  662. const viewText = new ViewText( 'x' );
  663. viewP._appendChild( viewText );
  664. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  665. renderer.markToSync( 'children', viewP );
  666. renderAndExpectNoChanges( renderer, domRoot );
  667. } );
  668. it( 'should handle typing in empty block, render if needed', () => {
  669. const domSelection = document.getSelection();
  670. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  671. viewRoot._appendChild( viewP );
  672. selection._setTo( newSelection );
  673. renderer.markToSync( 'children', viewRoot );
  674. renderer.render();
  675. const domP = domRoot.childNodes[ 0 ];
  676. expect( domP.childNodes.length ).to.equal( 1 );
  677. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  678. expect( domSelection.rangeCount ).to.equal( 1 );
  679. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  680. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  681. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  682. // Add text node only in View <p>x{}</p>
  683. const viewText = new ViewText( 'x' );
  684. viewP._appendChild( viewText );
  685. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  686. renderer.markToSync( 'children', viewP );
  687. renderer.render();
  688. expect( domP.childNodes.length ).to.equal( 1 );
  689. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  690. expect( domSelection.rangeCount ).to.equal( 1 );
  691. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  692. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  693. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  694. } );
  695. it( 'should handle removing last character', () => {
  696. const domSelection = document.getSelection();
  697. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  698. viewRoot._appendChild( viewP );
  699. selection._setTo( newSelection );
  700. renderer.markToSync( 'children', viewRoot );
  701. renderer.render();
  702. const domP = domRoot.childNodes[ 0 ];
  703. expect( domP.childNodes.length ).to.equal( 1 );
  704. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  705. expect( domSelection.rangeCount ).to.equal( 1 );
  706. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  707. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  708. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  709. // Remove text and add filler to both DOM and View <p>{}</p>
  710. domP.removeChild( domP.childNodes[ 0 ] );
  711. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  712. domSelection.removeAllRanges();
  713. const domRange = document.createRange();
  714. domRange.setStart( domP.childNodes[ 0 ], 0 );
  715. domRange.collapse( true );
  716. domSelection.addRange( domRange );
  717. viewP._removeChildren( 0 );
  718. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  719. renderer.markToSync( 'children', viewP );
  720. renderAndExpectNoChanges( renderer, domRoot );
  721. } );
  722. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  723. const domSelection = document.getSelection();
  724. // 1. Render <p><b>FILLER{}</b>foo</p>.
  725. const { view: viewP, selection: newSelection } = parse(
  726. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  727. viewRoot._appendChild( viewP );
  728. selection._setTo( newSelection );
  729. renderer.markToSync( 'children', viewRoot );
  730. renderer.render();
  731. // 2. Check the DOM.
  732. const domP = domRoot.childNodes[ 0 ];
  733. expect( domP.childNodes.length ).to.equal( 2 );
  734. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  735. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  736. const domB = domP.childNodes[ 0 ];
  737. const viewB = viewP.getChild( 0 );
  738. expect( domB.childNodes.length ).to.equal( 1 );
  739. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  740. expect( domSelection.rangeCount ).to.equal( 1 );
  741. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  742. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  743. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  744. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  745. domB.childNodes[ 0 ].data += 'x';
  746. domSelection.removeAllRanges();
  747. const domRange = document.createRange();
  748. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  749. domRange.collapse( true );
  750. domSelection.addRange( domRange );
  751. const viewText = new ViewText( 'x' );
  752. viewB._appendChild( viewText );
  753. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  754. renderer.markToSync( 'children', viewP );
  755. renderAndExpectNoChanges( renderer, domRoot );
  756. } );
  757. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  758. const domSelection = document.getSelection();
  759. // 1. Render <p><b>FILLER{}</b>foo</p>.
  760. const { view: viewP, selection: newSelection } = parse(
  761. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  762. viewRoot._appendChild( viewP );
  763. selection._setTo( newSelection );
  764. renderer.markToSync( 'children', viewRoot );
  765. renderer.render();
  766. // 2. Check the DOM.
  767. const domP = domRoot.childNodes[ 0 ];
  768. expect( domP.childNodes.length ).to.equal( 2 );
  769. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  770. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  771. const domB = domP.childNodes[ 0 ];
  772. const viewB = viewP.getChild( 0 );
  773. expect( domB.childNodes.length ).to.equal( 1 );
  774. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  775. expect( domSelection.rangeCount ).to.equal( 1 );
  776. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  777. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  778. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  779. domSelection.removeAllRanges();
  780. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  781. const viewText = new ViewText( 'x' );
  782. viewB._appendChild( viewText );
  783. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  784. renderer.markToSync( 'children', viewB );
  785. renderer.render();
  786. expect( domB.childNodes.length ).to.equal( 1 );
  787. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  788. expect( domSelection.rangeCount ).to.equal( 1 );
  789. // Depending on the browser selection may end up at the end of the text node or after the text node.
  790. const firstRange = domSelection.getRangeAt( 0 );
  791. const assertSelectionAtEndOfTextNode = () => {
  792. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  793. };
  794. const assertSelectionInsideTextNode = () => {
  795. expect( firstRange.startContainer ).to.equal( domB );
  796. expect( firstRange.startOffset ).to.equal( 1 );
  797. };
  798. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  799. expect( firstRange.collapsed ).to.be.true;
  800. } );
  801. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  802. const domSelection = document.getSelection();
  803. // 1. Render <p><b>FILLER{}</b>foo</p>.
  804. const { view: viewP, selection: newSelection } = parse(
  805. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  806. viewRoot._appendChild( viewP );
  807. selection._setTo( newSelection );
  808. renderer.markToSync( 'children', viewRoot );
  809. renderer.render();
  810. // 2. Check the DOM.
  811. const domP = domRoot.childNodes[ 0 ];
  812. expect( domP.childNodes.length ).to.equal( 2 );
  813. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  814. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  815. const domB = domP.childNodes[ 0 ];
  816. const viewB = viewP.getChild( 0 );
  817. expect( domB.childNodes.length ).to.equal( 1 );
  818. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  819. expect( domSelection.rangeCount ).to.equal( 1 );
  820. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  821. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  822. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  823. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  824. const viewText = new ViewText( 'x' );
  825. viewB._appendChild( viewText );
  826. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  827. renderer.markToSync( 'text', viewText );
  828. renderer.render();
  829. // 4. Check the DOM.
  830. expect( domB.childNodes.length ).to.equal( 1 );
  831. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  832. expect( domSelection.rangeCount ).to.equal( 1 );
  833. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  834. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  835. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  836. } );
  837. it( 'should handle not collapsed range', () => {
  838. const domSelection = document.getSelection();
  839. const { view: viewP, selection: newSelection } = parse(
  840. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  841. viewRoot._appendChild( viewP );
  842. selection._setTo( newSelection );
  843. renderer.markToSync( 'children', viewRoot );
  844. renderer.render();
  845. const domP = domRoot.childNodes[ 0 ];
  846. expect( domP.childNodes.length ).to.equal( 2 );
  847. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  848. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  849. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  850. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  851. expect( domSelection.rangeCount ).to.equal( 1 );
  852. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  853. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  854. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  855. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  856. renderer.markToSync( 'children', viewP );
  857. renderAndExpectNoChanges( renderer, domRoot );
  858. } );
  859. it( 'should not change selection if there is no editable with selection', () => {
  860. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  861. document.body.appendChild( domDiv );
  862. domDiv.focus();
  863. const domSelection = document.getSelection();
  864. domSelection.removeAllRanges();
  865. domSelection.collapse( domDiv, 0 );
  866. const viewDiv = new ViewElement( 'div' );
  867. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  868. viewDiv._appendChild( viewP );
  869. selection._setTo( newSelection );
  870. renderer.render();
  871. expect( domSelection.rangeCount ).to.equal( 1 );
  872. // Depending on the browser selection may end up before the text node or at the beginning of it.
  873. const domRange = domSelection.getRangeAt( 0 );
  874. const assertSelectionAtEndOfTextNode = () => {
  875. expect( domRange.startContainer ).to.equal( domDiv );
  876. };
  877. const assertSelectionInsideTextNode = () => {
  878. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  879. };
  880. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  881. expect( domRange.startOffset ).to.equal( 0 );
  882. expect( domRange.collapsed ).to.be.true;
  883. domDiv.remove();
  884. } );
  885. it( 'should not change selection if there is no focus', () => {
  886. const domDiv = createElement( document, 'div', null, 'not editable' );
  887. document.body.appendChild( domDiv );
  888. const domSelection = document.getSelection();
  889. domSelection.removeAllRanges();
  890. const domRange = document.createRange();
  891. domRange.setStart( domDiv, 0 );
  892. domRange.collapse( true );
  893. domSelection.addRange( domRange );
  894. renderer.isFocused = false;
  895. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  896. viewRoot._appendChild( viewP );
  897. selection._setTo( newSelection );
  898. renderer.render();
  899. expect( domSelection.rangeCount ).to.equal( 1 );
  900. // Depending on the browser selection may end up before the text node or at the beginning of it.
  901. const domSelectionRange = domSelection.getRangeAt( 0 );
  902. const assertSelectionAtEndOfTextNode = () => {
  903. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  904. };
  905. const assertSelectionInsideTextNode = () => {
  906. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  907. };
  908. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  909. expect( domSelectionRange.startOffset ).to.equal( 0 );
  910. expect( domSelectionRange.collapsed ).to.be.true;
  911. domDiv.remove();
  912. } );
  913. it( 'should not add inline filler after text node', () => {
  914. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  915. viewRoot._appendChild( viewP );
  916. selection._setTo( newSelection );
  917. renderer.markToSync( 'children', viewRoot );
  918. renderer.render();
  919. const domP = domRoot.childNodes[ 0 ];
  920. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  921. } );
  922. it( 'should throw if there is no filler in expected position', () => {
  923. const { view: viewP, selection: newSelection } = parse(
  924. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  925. viewRoot._appendChild( viewP );
  926. selection._setTo( newSelection );
  927. renderer.markToSync( 'children', viewRoot );
  928. renderer.render();
  929. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  930. const viewB = viewP.getChild( 1 );
  931. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  932. // Remove filler.
  933. domB.childNodes[ 0 ].data = '';
  934. selection._setTo( null );
  935. renderer.markToSync( 'children', viewB );
  936. expect( () => {
  937. renderer.render();
  938. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  939. } );
  940. // #1014.
  941. it( 'should create inline filler in newly created dom nodes', () => {
  942. // 1. Create the view structure which needs inline filler.
  943. const inputView =
  944. '<container:ul>' +
  945. '<container:li>Foobar.</container:li>' +
  946. '<container:li>[]<container:div></container:div></container:li>' +
  947. '</container:ul>';
  948. const { view: view, selection: newSelection } = parse( inputView );
  949. viewRoot._appendChild( view );
  950. selection._setTo( newSelection );
  951. renderer.markToSync( 'children', viewRoot );
  952. renderer.render();
  953. // 2. Check if filler element has been (correctly) created.
  954. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  955. // 3. Move the inline filler parent to a newly created element.
  956. const viewLi = view.getChild( 0 );
  957. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  958. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  959. viewLi._appendChild( viewUl );
  960. // 4. Mark changed items and render the view.
  961. renderer.markToSync( 'children', view );
  962. renderer.markToSync( 'children', viewLi );
  963. renderer.render();
  964. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  965. const domSelection = document.getSelection();
  966. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  967. } );
  968. it( 'should handle focusing element', () => {
  969. selection._setTo( viewRoot, 0 );
  970. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  971. renderer.render();
  972. expect( domFocusSpy.called ).to.be.true;
  973. } );
  974. it( 'should not focus editable if isFocues is set to false', () => {
  975. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  976. renderer.isFocused = false;
  977. renderer.render();
  978. expect( domFocusSpy.calledOnce ).to.be.false;
  979. } );
  980. it( 'should not focus already focused DOM element', () => {
  981. domRoot.setAttribute( 'contentEditable', true );
  982. domRoot.focus();
  983. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  984. renderer.render();
  985. expect( domFocusSpy.called ).to.be.false;
  986. } );
  987. it( 'should render NBSP as first space in inline element after another space', () => {
  988. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  989. viewRoot._appendChild( viewP );
  990. renderer.markToSync( 'children', viewRoot );
  991. renderer.render();
  992. const domP = domRoot.childNodes[ 0 ];
  993. const domB = domP.childNodes[ 1 ];
  994. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  995. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  996. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  997. // Insert space resulting in '<p>x <b> y</b></p>'.
  998. const viewB = viewP.getChild( 1 );
  999. viewB._removeChildren( 0 );
  1000. viewB._appendChild( new ViewText( ' y' ) );
  1001. renderer.markToSync( 'children', viewP );
  1002. renderer.render();
  1003. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1004. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1005. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1006. } );
  1007. it( 'should update sibling after, when node before is removed', () => {
  1008. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1009. viewRoot._appendChild( viewP );
  1010. renderer.markToSync( 'children', viewRoot );
  1011. renderer.render();
  1012. const domP = domRoot.childNodes[ 0 ];
  1013. const domB = domP.childNodes[ 1 ];
  1014. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1015. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1016. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1017. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1018. viewP._removeChildren( 0 );
  1019. renderer.markToSync( 'children', viewP );
  1020. renderer.render();
  1021. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1022. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1023. } );
  1024. it( 'should update sibling before, when node after is removed', () => {
  1025. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1026. viewRoot._appendChild( viewP );
  1027. renderer.markToSync( 'children', viewRoot );
  1028. renderer.render();
  1029. const domP = domRoot.childNodes[ 0 ];
  1030. const domB = domP.childNodes[ 1 ];
  1031. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1032. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1033. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1034. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1035. viewP._removeChildren( 1 );
  1036. renderer.markToSync( 'children', viewP );
  1037. renderer.render();
  1038. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1039. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1040. } );
  1041. // #1093
  1042. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1043. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1044. viewRoot._appendChild( viewP );
  1045. renderer.markToSync( 'children', viewRoot );
  1046. renderer.render();
  1047. const domP = domRoot.childNodes[ 0 ];
  1048. const domB = domP.childNodes[ 1 ];
  1049. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1050. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1051. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1052. // Insert space resulting in '<p>x <b> y</b></p>'.
  1053. viewP._removeChildren( 0 );
  1054. viewP._insertChild( 0, new ViewText( 'x ' ) );
  1055. renderer.markToSync( 'children', viewP );
  1056. renderer.render();
  1057. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1058. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1059. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1060. } );
  1061. // #1093
  1062. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1063. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1064. viewRoot._appendChild( viewP );
  1065. renderer.markToSync( 'children', viewRoot );
  1066. renderer.render();
  1067. const domP = domRoot.childNodes[ 0 ];
  1068. const domB = domP.childNodes[ 0 ];
  1069. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1070. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1071. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1072. // Insert space resulting in '<p><b>x </b> y</p>'.
  1073. const viewB = viewP.getChild( 0 );
  1074. viewB._removeChildren( 0 );
  1075. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1076. renderer.markToSync( 'children', viewP );
  1077. renderer.render();
  1078. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1079. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1080. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1081. } );
  1082. // #1093
  1083. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1084. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1085. viewRoot._appendChild( viewP );
  1086. renderer.markToSync( 'children', viewRoot );
  1087. renderer.render();
  1088. const domP = domRoot.childNodes[ 0 ];
  1089. const domB = domP.childNodes[ 0 ];
  1090. const domI = domP.childNodes[ 1 ];
  1091. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1092. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1093. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1094. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1095. const viewB = viewP.getChild( 0 );
  1096. viewB._removeChildren( 0 );
  1097. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1098. renderer.markToSync( 'children', viewP );
  1099. renderer.render();
  1100. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1101. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1102. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1103. } );
  1104. // #1125
  1105. it( 'should properly rerender many changes done in one batch', () => {
  1106. // This test transforms:
  1107. //
  1108. // <h2>He<strong>ding 1</strong></h2>
  1109. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1110. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1111. //
  1112. // into:
  1113. //
  1114. // <h2>Heading 2</h2>
  1115. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1116. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1117. //
  1118. // during one rerender to check if complex structure changes are rerendered correctly.
  1119. const viewContent = parse( '' +
  1120. '<container:h2>He' +
  1121. '<attribute:i>ading 1</attribute:i>' +
  1122. '</container:h2>' +
  1123. '<container:p>Ph ' +
  1124. '<attribute:strong>Bold</attribute:strong> ' +
  1125. '<attribute:i>It' +
  1126. '<attribute:strong>alic</attribute:strong>' +
  1127. '</attribute:i> ' +
  1128. '<attribute:a href="https://ckeditor.com">' +
  1129. '<attribute:strong>Lin</attribute:strong>' +
  1130. 'k</attribute:a>' +
  1131. '</container:p>' +
  1132. '<container:blockquote>' +
  1133. '<container:ul>' +
  1134. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1135. '</container:ul>' +
  1136. '</container:blockquote>' );
  1137. viewRoot._appendChild( viewContent );
  1138. renderer.markToSync( 'children', viewRoot );
  1139. renderer.render();
  1140. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1141. const viewHeading = viewRoot.getChild( 0 );
  1142. viewHeading._removeChildren( 0, viewHeading.childCount );
  1143. viewHeading._insertChild( 0, new ViewText( 'Heading 2' ) );
  1144. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1145. renderer.markToSync( 'children', viewRoot );
  1146. renderer.markToSync( 'children', viewHeading );
  1147. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1148. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1149. // ->
  1150. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1151. const viewP = viewRoot.getChild( 1 );
  1152. viewP._removeChildren( 0, viewP.childCount );
  1153. viewP._insertChild(
  1154. 0,
  1155. parse(
  1156. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1157. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1158. )
  1159. );
  1160. renderer.markToSync( 'children', viewRoot );
  1161. renderer.markToSync( 'children', viewP );
  1162. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1163. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1164. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1165. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1166. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1167. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1168. const viewBq = viewRoot.getChild( 2 );
  1169. viewBq._removeChildren( 0, viewBq.childCount );
  1170. viewBq._insertChild(
  1171. 0,
  1172. parse(
  1173. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1174. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1175. )
  1176. );
  1177. renderer.markToSync( 'children', viewRoot );
  1178. renderer.markToSync( 'children', viewBq );
  1179. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1180. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1181. renderer.render();
  1182. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1183. '<h2>Heading 2</h2>' +
  1184. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1185. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1186. );
  1187. } );
  1188. // #1125
  1189. it( 'should properly rerender changes when whole content replaced at once', () => {
  1190. // This test replaces:
  1191. //
  1192. // <h1>Header</h1>
  1193. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1194. //
  1195. // with:
  1196. //
  1197. // <h2>Header</h2>
  1198. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1199. //
  1200. // during one rerender to check if complex structure changes are rerendered correctly.
  1201. const viewContent = parse(
  1202. '<container:h1>Header</container:h1>' +
  1203. '<container:blockquote>' +
  1204. '<container:ul>' +
  1205. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1206. '<container:li>Item 2</container:li>' +
  1207. '</container:ul>' +
  1208. '</container:blockquote>'
  1209. );
  1210. viewRoot._appendChild( viewContent );
  1211. renderer.markToSync( 'children', viewRoot );
  1212. renderer.render();
  1213. const newViewContent = parse(
  1214. '<container:h2>Header</container:h2>' +
  1215. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1216. );
  1217. viewRoot._removeChildren( 0, viewRoot.childCount );
  1218. viewRoot._appendChild( newViewContent );
  1219. renderer.markToSync( 'children', viewRoot );
  1220. renderer.render();
  1221. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1222. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1223. );
  1224. } );
  1225. // #1451
  1226. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1227. const inputView =
  1228. '<container:ul>' +
  1229. '<container:li>Foo</container:li>' +
  1230. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1231. '</container:ul>';
  1232. const view = parse( inputView );
  1233. viewRoot._appendChild( view );
  1234. renderer.markToSync( 'children', viewRoot );
  1235. renderer.render();
  1236. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1237. const viewLi = view.getChild( 0 );
  1238. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1239. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1240. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  1241. viewLi._appendChild( viewUl );
  1242. renderer.markToSync( 'children', view );
  1243. renderer.markToSync( 'children', viewLi );
  1244. renderer.render();
  1245. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1246. } );
  1247. // #1439
  1248. it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
  1249. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1250. testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
  1251. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1252. // <p>foo<br/>[]</p>
  1253. const { view: viewP, selection: newSelection } = parse(
  1254. '<container:p>' +
  1255. 'foo[]' +
  1256. '<empty:br></empty:br>[]' +
  1257. '</container:p>' );
  1258. viewRoot._appendChild( viewP );
  1259. selection._setTo( newSelection );
  1260. renderer.markToSync( 'children', viewRoot );
  1261. renderer.render();
  1262. sinon.assert.notCalled( spy );
  1263. } );
  1264. // #1439
  1265. it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
  1266. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1267. testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
  1268. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1269. // <p>foo[]<b>bar</b></p>
  1270. let { view: viewP, selection: newSelection } = parse(
  1271. '<container:p>' +
  1272. 'foo[]' +
  1273. '<attribute:b>bar</attribute:b>' +
  1274. '</container:p>' );
  1275. viewRoot._appendChild( viewP );
  1276. selection._setTo( newSelection );
  1277. renderer.markToSync( 'children', viewRoot );
  1278. renderer.render();
  1279. sinon.assert.notCalled( spy );
  1280. // <p>foo<b>bar</b></p><p>foo[]<br/></p>
  1281. ( { view: viewP, selection: newSelection } = parse(
  1282. '<container:p>' +
  1283. 'foo[]' +
  1284. '<empty:br></empty:br>' +
  1285. '</container:p>' ) );
  1286. viewRoot._appendChild( viewP );
  1287. selection._setTo( newSelection );
  1288. renderer.markToSync( 'children', viewRoot );
  1289. renderer.render();
  1290. sinon.assert.notCalled( spy );
  1291. // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
  1292. selection._setTo( [
  1293. new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
  1294. ] );
  1295. renderer.markToSync( 'children', viewRoot );
  1296. renderer.render();
  1297. sinon.assert.calledOnce( spy );
  1298. } );
  1299. describe( 'fake selection', () => {
  1300. beforeEach( () => {
  1301. const { view: viewP, selection: newSelection } = parse(
  1302. '<container:p>[foo bar]</container:p>'
  1303. );
  1304. viewRoot._appendChild( viewP );
  1305. selection._setTo( newSelection );
  1306. renderer.markToSync( 'children', viewRoot );
  1307. renderer.render();
  1308. } );
  1309. it( 'should render fake selection', () => {
  1310. const label = 'fake selection label';
  1311. selection._setTo( selection.getRanges(), { fake: true, label } );
  1312. renderer.render();
  1313. expect( domRoot.childNodes.length ).to.equal( 2 );
  1314. const container = domRoot.childNodes[ 1 ];
  1315. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1316. expect( container.childNodes.length ).to.equal( 1 );
  1317. const textNode = container.childNodes[ 0 ];
  1318. expect( textNode.textContent ).to.equal( label );
  1319. const domSelection = domRoot.ownerDocument.getSelection();
  1320. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1321. } );
  1322. it( 'should render &nbsp; if no selection label is provided', () => {
  1323. selection._setTo( selection.getRanges(), { fake: true } );
  1324. renderer.render();
  1325. expect( domRoot.childNodes.length ).to.equal( 2 );
  1326. const container = domRoot.childNodes[ 1 ];
  1327. expect( container.childNodes.length ).to.equal( 1 );
  1328. const textNode = container.childNodes[ 0 ];
  1329. expect( textNode.textContent ).to.equal( '\u00A0' );
  1330. const domSelection = domRoot.ownerDocument.getSelection();
  1331. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1332. } );
  1333. it( 'should remove fake selection container when selection is no longer fake', () => {
  1334. selection._setTo( selection.getRanges(), { fake: true } );
  1335. renderer.render();
  1336. selection._setTo( selection.getRanges(), { fake: false } );
  1337. renderer.render();
  1338. expect( domRoot.childNodes.length ).to.equal( 1 );
  1339. const domParagraph = domRoot.childNodes[ 0 ];
  1340. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1341. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1342. const domSelection = domRoot.ownerDocument.getSelection();
  1343. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1344. } );
  1345. it( 'should reuse fake selection container #1', () => {
  1346. const label = 'fake selection label';
  1347. selection._setTo( selection.getRanges(), { fake: true, label } );
  1348. renderer.render();
  1349. expect( domRoot.childNodes.length ).to.equal( 2 );
  1350. const container = domRoot.childNodes[ 1 ];
  1351. selection._setTo( selection.getRanges(), { fake: true, label } );
  1352. renderer.render();
  1353. expect( domRoot.childNodes.length ).to.equal( 2 );
  1354. const newContainer = domRoot.childNodes[ 1 ];
  1355. expect( newContainer ).equals( container );
  1356. expect( newContainer.childNodes.length ).to.equal( 1 );
  1357. const textNode = newContainer.childNodes[ 0 ];
  1358. expect( textNode.textContent ).to.equal( label );
  1359. } );
  1360. it( 'should reuse fake selection container #2', () => {
  1361. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1362. renderer.render();
  1363. expect( domRoot.childNodes.length ).to.equal( 2 );
  1364. const container = domRoot.childNodes[ 1 ];
  1365. selection._setTo( selection.getRanges(), { fake: false } );
  1366. renderer.render();
  1367. expect( domRoot.childNodes.length ).to.equal( 1 );
  1368. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1369. renderer.render();
  1370. expect( domRoot.childNodes.length ).to.equal( 2 );
  1371. const newContainer = domRoot.childNodes[ 1 ];
  1372. expect( newContainer ).equals( container );
  1373. expect( newContainer.childNodes.length ).to.equal( 1 );
  1374. const textNode = newContainer.childNodes[ 0 ];
  1375. expect( textNode.textContent ).to.equal( 'label 2' );
  1376. } );
  1377. it( 'should reuse fake selection container #3', () => {
  1378. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1379. renderer.render();
  1380. expect( domRoot.childNodes.length ).to.equal( 2 );
  1381. const container = domRoot.childNodes[ 1 ];
  1382. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1383. renderer.render();
  1384. expect( domRoot.childNodes.length ).to.equal( 2 );
  1385. const newContainer = domRoot.childNodes[ 1 ];
  1386. expect( newContainer ).equals( container );
  1387. expect( newContainer.childNodes.length ).to.equal( 1 );
  1388. const textNode = newContainer.childNodes[ 0 ];
  1389. expect( textNode.textContent ).to.equal( 'label 2' );
  1390. } );
  1391. it( 'should style fake selection container properly', () => {
  1392. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1393. renderer.render();
  1394. expect( domRoot.childNodes.length ).to.equal( 2 );
  1395. const container = domRoot.childNodes[ 1 ];
  1396. expect( container.style.position ).to.equal( 'fixed' );
  1397. expect( container.style.top ).to.equal( '0px' );
  1398. expect( container.style.left ).to.equal( '-9999px' );
  1399. } );
  1400. it( 'should move fake selection container between editables', () => {
  1401. const viewEditable = new ViewEditableElement( 'div' );
  1402. viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
  1403. const domEditable = document.createElement( 'div' );
  1404. document.body.appendChild( domEditable );
  1405. domConverter.bindElements( domEditable, viewEditable );
  1406. renderer.markToSync( 'children', viewEditable );
  1407. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1408. renderer.render();
  1409. let container = document.getSelection().anchorNode;
  1410. expect( domRoot.contains( container ) ).to.be.true;
  1411. selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
  1412. renderer.render();
  1413. container = document.getSelection().anchorNode;
  1414. expect( domEditable.contains( container ) ).to.be.true;
  1415. } );
  1416. it( 'should bind fake selection container to view selection', () => {
  1417. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1418. renderer.render();
  1419. expect( domRoot.childNodes.length ).to.equal( 2 );
  1420. const container = domRoot.childNodes[ 1 ];
  1421. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1422. expect( bindSelection ).to.not.be.undefined;
  1423. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1424. } );
  1425. // Use a forgiving way of checking what the selection contains
  1426. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1427. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1428. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1429. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1430. expect( domSelection.toString() ).to.match( expectedText );
  1431. expect(
  1432. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1433. ).to.be.true;
  1434. }
  1435. } );
  1436. // #887
  1437. describe( 'similar selection', () => {
  1438. // Use spies to check selection updates. Some selection positions are not achievable in some
  1439. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1440. let selectionCollapseSpy, selectionExtendSpy;
  1441. afterEach( () => {
  1442. if ( selectionCollapseSpy ) {
  1443. selectionCollapseSpy.restore();
  1444. selectionCollapseSpy = null;
  1445. }
  1446. if ( selectionExtendSpy ) {
  1447. selectionExtendSpy.restore();
  1448. selectionExtendSpy = null;
  1449. }
  1450. } );
  1451. it( 'should always render collapsed selection even if it is similar', () => {
  1452. const domSelection = document.getSelection();
  1453. const { view: viewP, selection: newSelection } = parse(
  1454. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1455. viewRoot._appendChild( viewP );
  1456. selection._setTo( newSelection );
  1457. renderer.markToSync( 'children', viewRoot );
  1458. renderer.render();
  1459. const domP = domRoot.childNodes[ 0 ];
  1460. const domB = domP.childNodes[ 1 ];
  1461. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1462. expect( domSelection.isCollapsed ).to.true;
  1463. expect( domSelection.rangeCount ).to.equal( 1 );
  1464. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1465. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1466. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1467. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1468. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1469. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1470. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1471. selection._setTo( [
  1472. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1473. ] );
  1474. renderer.markToSync( 'children', viewP );
  1475. renderer.render();
  1476. expect( selectionCollapseSpy.calledOnce ).to.true;
  1477. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1478. expect( selectionExtendSpy.calledOnce ).to.true;
  1479. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1480. } );
  1481. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1482. const domSelection = document.getSelection();
  1483. const { view: viewP, selection: newSelection } = parse(
  1484. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1485. viewRoot._appendChild( viewP );
  1486. selection._setTo( newSelection );
  1487. renderer.markToSync( 'children', viewRoot );
  1488. renderer.render();
  1489. const domP = domRoot.childNodes[ 0 ];
  1490. const domB = domP.childNodes[ 1 ];
  1491. expect( domSelection.isCollapsed ).to.true;
  1492. expect( domSelection.rangeCount ).to.equal( 1 );
  1493. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1494. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1495. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1496. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1497. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1498. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1499. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1500. selection._setTo( [
  1501. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1502. ] );
  1503. renderer.markToSync( 'children', viewP );
  1504. renderer.render();
  1505. expect( selectionCollapseSpy.calledOnce ).to.true;
  1506. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1507. expect( selectionExtendSpy.calledOnce ).to.true;
  1508. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1509. } );
  1510. it( 'should always render non-collapsed selection if it not is similar', () => {
  1511. const domSelection = document.getSelection();
  1512. const { view: viewP, selection: newSelection } = parse(
  1513. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1514. viewRoot._appendChild( viewP );
  1515. selection._setTo( newSelection );
  1516. renderer.markToSync( 'children', viewRoot );
  1517. renderer.render();
  1518. const domP = domRoot.childNodes[ 0 ];
  1519. const domB = domP.childNodes[ 1 ];
  1520. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1521. expect( domSelection.isCollapsed ).to.false;
  1522. expect( domSelection.rangeCount ).to.equal( 1 );
  1523. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1524. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1525. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1526. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1527. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1528. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1529. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1530. selection._setTo( [
  1531. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1532. ] );
  1533. renderer.markToSync( 'children', viewP );
  1534. renderer.render();
  1535. expect( selectionCollapseSpy.calledOnce ).to.true;
  1536. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1537. expect( selectionExtendSpy.calledOnce ).to.true;
  1538. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1539. } );
  1540. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1541. const domSelection = document.getSelection();
  1542. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1543. viewRoot._appendChild( viewP );
  1544. selection._setTo( newSelection );
  1545. renderer.markToSync( 'children', viewRoot );
  1546. renderer.render();
  1547. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1548. // Do not change view selection.
  1549. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1550. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1551. // because DOM selection is in incorrect place.
  1552. const domP = domRoot.childNodes[ 0 ];
  1553. const domSpan = domP.childNodes[ 1 ];
  1554. domSelection.collapse( domSpan, 0 );
  1555. renderer.render();
  1556. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1557. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1558. const assertSelectionAtEndOfTextNode = () => {
  1559. expect( domSelection.anchorNode ).to.equal( domP );
  1560. expect( domSelection.anchorOffset ).to.equal( 1 );
  1561. };
  1562. const assertSelectionInsideTextNode = () => {
  1563. const textNode = domP.childNodes[ 0 ];
  1564. expect( domSelection.anchorNode ).to.equal( textNode );
  1565. expect( domSelection.anchorOffset ).to.equal( 3 );
  1566. };
  1567. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1568. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1569. } );
  1570. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1571. const domSelection = document.getSelection();
  1572. const { view: viewP, selection: newSelection } = parse(
  1573. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1574. viewRoot._appendChild( viewP );
  1575. selection._setTo( newSelection );
  1576. renderer.markToSync( 'children', viewRoot );
  1577. renderer.render();
  1578. const domP = domRoot.childNodes[ 0 ];
  1579. const domB = domP.childNodes[ 1 ];
  1580. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1581. expect( domSelection.isCollapsed ).to.false;
  1582. expect( domSelection.rangeCount ).to.equal( 1 );
  1583. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1584. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1585. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1586. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1587. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1588. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1589. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1590. selection._setTo( [
  1591. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1592. ] );
  1593. renderer.markToSync( 'children', viewP );
  1594. renderer.render();
  1595. expect( selectionCollapseSpy.notCalled ).to.true;
  1596. expect( selectionExtendSpy.notCalled ).to.true;
  1597. } );
  1598. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1599. const domSelection = document.getSelection();
  1600. const { view: viewP, selection: newSelection } = parse(
  1601. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1602. viewRoot._appendChild( viewP );
  1603. selection._setTo( newSelection );
  1604. renderer.markToSync( 'children', viewRoot );
  1605. renderer.render();
  1606. const domP = domRoot.childNodes[ 0 ];
  1607. const domB = domP.childNodes[ 1 ];
  1608. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1609. expect( domSelection.isCollapsed ).to.false;
  1610. expect( domSelection.rangeCount ).to.equal( 1 );
  1611. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1612. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1613. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1614. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1615. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1616. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1617. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1618. selection._setTo( [
  1619. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1620. ] );
  1621. renderer.markToSync( 'children', viewP );
  1622. renderer.render();
  1623. expect( selectionCollapseSpy.notCalled ).to.true;
  1624. expect( selectionExtendSpy.notCalled ).to.true;
  1625. } );
  1626. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1627. const domSelection = document.getSelection();
  1628. const { view: viewP, selection: newSelection } = parse(
  1629. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1630. viewRoot._appendChild( viewP );
  1631. selection._setTo( newSelection );
  1632. renderer.markToSync( 'children', viewRoot );
  1633. renderer.render();
  1634. const domP = domRoot.childNodes[ 0 ];
  1635. const domB = domP.childNodes[ 1 ];
  1636. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1637. expect( domSelection.isCollapsed ).to.false;
  1638. expect( domSelection.rangeCount ).to.equal( 1 );
  1639. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1640. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1641. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1642. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1643. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1644. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1645. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1646. selection._setTo( [
  1647. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1648. ] );
  1649. renderer.markToSync( 'children', viewP );
  1650. renderer.render();
  1651. expect( selectionCollapseSpy.notCalled ).to.true;
  1652. expect( selectionExtendSpy.notCalled ).to.true;
  1653. } );
  1654. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1655. const domSelection = document.getSelection();
  1656. const { view: viewP, selection: newSelection } = parse(
  1657. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1658. viewRoot._appendChild( viewP );
  1659. selection._setTo( newSelection );
  1660. renderer.markToSync( 'children', viewRoot );
  1661. renderer.render();
  1662. const domP = domRoot.childNodes[ 0 ];
  1663. const domB = domP.childNodes[ 1 ];
  1664. expect( domSelection.isCollapsed ).to.false;
  1665. expect( domSelection.rangeCount ).to.equal( 1 );
  1666. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1667. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1668. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1669. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1670. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1671. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1672. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1673. selection._setTo( [
  1674. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1675. ] );
  1676. renderer.markToSync( 'children', viewP );
  1677. renderer.render();
  1678. expect( selectionCollapseSpy.notCalled ).to.true;
  1679. expect( selectionExtendSpy.notCalled ).to.true;
  1680. } );
  1681. } );
  1682. // #1417
  1683. describe( 'optimal rendering – reusing existing nodes', () => {
  1684. it( 'should render inline element replacement (before text)', () => {
  1685. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1686. renderer.markToSync( 'children', viewRoot );
  1687. renderer.render();
  1688. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1689. const viewP = viewRoot.getChild( 0 );
  1690. viewP._removeChildren( 0, 2 );
  1691. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1692. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1693. renderer.markToSync( 'children', viewRoot );
  1694. renderer.markToSync( 'children', viewP );
  1695. renderer.render();
  1696. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1697. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1698. } );
  1699. it( 'should render inline element replacement (after text)', () => {
  1700. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1701. renderer.markToSync( 'children', viewRoot );
  1702. renderer.render();
  1703. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1704. const viewP = viewRoot.getChild( 0 );
  1705. viewP._removeChildren( 0, 2 );
  1706. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1707. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1708. renderer.markToSync( 'children', viewRoot );
  1709. renderer.markToSync( 'children', viewP );
  1710. renderer.render();
  1711. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1712. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1713. } );
  1714. it( 'should render inline element replacement (before text swapped order)', () => {
  1715. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1716. renderer.markToSync( 'children', viewRoot );
  1717. renderer.render();
  1718. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1719. const viewP = viewRoot.getChild( 0 );
  1720. viewP._removeChildren( 0, 2 );
  1721. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1722. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1723. renderer.markToSync( 'children', viewRoot );
  1724. renderer.markToSync( 'children', viewP );
  1725. renderer.render();
  1726. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1727. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1728. } );
  1729. it( 'should render inline element replacement (after text swapped order)', () => {
  1730. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1731. renderer.markToSync( 'children', viewRoot );
  1732. renderer.render();
  1733. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1734. const viewP = viewRoot.getChild( 0 );
  1735. viewP._removeChildren( 0, 2 );
  1736. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1737. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1738. renderer.markToSync( 'children', viewRoot );
  1739. renderer.markToSync( 'children', viewP );
  1740. renderer.render();
  1741. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1742. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1743. } );
  1744. it( 'should render single replacement in p group', () => {
  1745. const content = '' +
  1746. '<container:p>1</container:p>' +
  1747. '<container:p>2</container:p>' +
  1748. '<container:p>3</container:p>';
  1749. viewRoot._appendChild( parse( content ) );
  1750. renderer.markToSync( 'children', viewRoot );
  1751. renderer.render();
  1752. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1753. viewRoot._removeChildren( 1 );
  1754. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1755. const domP = domRoot.childNodes[ 1 ];
  1756. renderer.markToSync( 'children', viewRoot );
  1757. renderer.render();
  1758. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1759. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1760. } );
  1761. it( 'should render replacement and insertion in p group', () => {
  1762. const content = '' +
  1763. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1764. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1765. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1766. const replacement = '' +
  1767. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1768. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1769. viewRoot._appendChild( parse( content ) );
  1770. renderer.markToSync( 'children', viewRoot );
  1771. renderer.render();
  1772. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1773. viewRoot._removeChildren( 1 );
  1774. viewRoot._insertChild( 1, parse( replacement ) );
  1775. const domP2 = domRoot.childNodes[ 1 ];
  1776. const domP3 = domRoot.childNodes[ 2 ];
  1777. renderer.markToSync( 'children', viewRoot );
  1778. renderer.render();
  1779. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1780. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1781. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1782. } );
  1783. it( 'should render replacement and deletion in p group', () => {
  1784. const content = '' +
  1785. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1786. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1787. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1788. viewRoot._appendChild( parse( content ) );
  1789. renderer.markToSync( 'children', viewRoot );
  1790. renderer.render();
  1791. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1792. viewRoot._removeChildren( 0, 2 );
  1793. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1794. const domP0 = domRoot.childNodes[ 0 ];
  1795. const domP2 = domRoot.childNodes[ 2 ];
  1796. renderer.markToSync( 'children', viewRoot );
  1797. renderer.render();
  1798. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1799. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1800. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1801. } );
  1802. it( 'should render multiple continuous replacement in p group', () => {
  1803. const content = '' +
  1804. '<container:p>1</container:p>' +
  1805. '<container:p>2</container:p>' +
  1806. '<container:p>3</container:p>' +
  1807. '<container:p>4</container:p>' +
  1808. '<container:p>5</container:p>';
  1809. viewRoot._appendChild( parse( content ) );
  1810. renderer.markToSync( 'children', viewRoot );
  1811. renderer.render();
  1812. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1813. viewRoot._removeChildren( 0, 3 );
  1814. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1815. const domP1 = domRoot.childNodes[ 0 ];
  1816. const domP2 = domRoot.childNodes[ 1 ];
  1817. const domP4 = domRoot.childNodes[ 3 ];
  1818. const domP5 = domRoot.childNodes[ 4 ];
  1819. renderer.markToSync( 'children', viewRoot );
  1820. renderer.render();
  1821. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1822. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1823. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1824. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1825. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1826. } );
  1827. it( 'should render multiple replacement in p group', () => {
  1828. const content = '' +
  1829. '<container:p>1</container:p>' +
  1830. '<container:p>2</container:p>' +
  1831. '<container:p>3</container:p>' +
  1832. '<container:p>4</container:p>' +
  1833. '<container:p>5</container:p>';
  1834. viewRoot._appendChild( parse( content ) );
  1835. renderer.markToSync( 'children', viewRoot );
  1836. renderer.render();
  1837. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1838. viewRoot._removeChildren( 4 );
  1839. viewRoot._removeChildren( 1, 2 );
  1840. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1841. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1842. const domP1 = domRoot.childNodes[ 0 ];
  1843. const domP2 = domRoot.childNodes[ 1 ];
  1844. const domP4 = domRoot.childNodes[ 3 ];
  1845. const domP5 = domRoot.childNodes[ 4 ];
  1846. renderer.markToSync( 'children', viewRoot );
  1847. renderer.render();
  1848. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1849. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1850. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1851. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1852. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1853. } );
  1854. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1855. const content = '' +
  1856. '<container:h2>He' +
  1857. '<attribute:i>ading 1</attribute:i>' +
  1858. '</container:h2>' +
  1859. '<container:p>Ph ' +
  1860. '<attribute:strong>Bold</attribute:strong>' +
  1861. '<attribute:a href="https://ckeditor.com">' +
  1862. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1863. '</attribute:a>' +
  1864. '</container:p>' +
  1865. '<container:blockquote>' +
  1866. '<container:ul>' +
  1867. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1868. '</container:ul>' +
  1869. '</container:blockquote>';
  1870. viewRoot._appendChild( parse( content ) );
  1871. renderer.markToSync( 'children', viewRoot );
  1872. renderer.render();
  1873. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1874. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1875. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1876. viewRoot._removeChildren( 0, viewRoot.childCount );
  1877. viewRoot._appendChild( parse( content ) );
  1878. const viewH = viewRoot.getChild( 0 );
  1879. const viewP = viewRoot.getChild( 1 );
  1880. const viewQ = viewRoot.getChild( 2 );
  1881. const domH = domRoot.childNodes[ 0 ];
  1882. const domHI = domH.childNodes[ 1 ];
  1883. const domP = domRoot.childNodes[ 1 ];
  1884. const domPT = domP.childNodes[ 0 ];
  1885. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1886. const domQ = domRoot.childNodes[ 2 ];
  1887. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1888. renderer.markToSync( 'children', viewRoot );
  1889. renderer.render();
  1890. // Assert content.
  1891. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1892. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1893. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1894. // Assert if DOM elements did not change.
  1895. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1896. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1897. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1898. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1899. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1900. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1901. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1902. // Assert mappings.
  1903. const mappings = renderer.domConverter._domToViewMapping;
  1904. expect( mappings.get( domH ) ).to.equal( viewH );
  1905. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1906. expect( mappings.get( domP ) ).to.equal( viewP );
  1907. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1908. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1909. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1910. } );
  1911. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1912. const content = '' +
  1913. '<container:h2>He' +
  1914. '<attribute:i>ading 1</attribute:i>' +
  1915. '</container:h2>' +
  1916. '<container:p>Ph ' +
  1917. '<attribute:strong>Bold</attribute:strong>' +
  1918. '<attribute:a href="https://ckeditor.com">' +
  1919. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1920. '</attribute:a>' +
  1921. '</container:p>' +
  1922. '<container:blockquote>' +
  1923. '<container:ul>' +
  1924. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1925. '</container:ul>' +
  1926. '</container:blockquote>';
  1927. const content2 = '' +
  1928. '<container:p>Ph ' +
  1929. '<attribute:strong>Bold</attribute:strong>' +
  1930. '<attribute:a href="https://ckeditor.com">' +
  1931. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1932. '</attribute:a>' +
  1933. '</container:p>' +
  1934. '<container:blockquote>' +
  1935. '<container:ul>' +
  1936. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1937. '</container:ul>' +
  1938. '</container:blockquote>';
  1939. viewRoot._appendChild( parse( content ) );
  1940. renderer.markToSync( 'children', viewRoot );
  1941. renderer.render();
  1942. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1943. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1944. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1945. viewRoot._removeChildren( 0, viewRoot.childCount );
  1946. viewRoot._appendChild( parse( content2 ) );
  1947. const viewP = viewRoot.getChild( 0 );
  1948. const viewQ = viewRoot.getChild( 1 );
  1949. const domP = domRoot.childNodes[ 1 ];
  1950. const domPT = domP.childNodes[ 0 ];
  1951. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1952. const domQ = domRoot.childNodes[ 2 ];
  1953. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1954. renderer.markToSync( 'children', viewRoot );
  1955. renderer.render();
  1956. // Assert content.
  1957. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  1958. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1959. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1960. // Assert if DOM elements did not change.
  1961. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1962. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1963. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1964. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  1965. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1966. // Assert mappings.
  1967. const mappings = renderer.domConverter._domToViewMapping;
  1968. expect( mappings.get( domP ) ).to.equal( viewP );
  1969. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1970. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1971. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1972. } );
  1973. it( 'should not rerender DOM when typing inside empty inline element', () => {
  1974. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  1975. viewRoot._appendChild( view );
  1976. renderer.markToSync( 'children', viewRoot );
  1977. renderer.render();
  1978. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  1979. const viewP = viewRoot.getChild( 0 );
  1980. viewP._removeChildren( 1 );
  1981. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  1982. const domP = domRoot.childNodes[ 0 ];
  1983. const domText = domP.childNodes[ 0 ];
  1984. const domB = domP.childNodes[ 1 ];
  1985. domB.innerHTML = 'a';
  1986. renderer.markToSync( 'children', viewRoot );
  1987. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  1988. renderer.render();
  1989. // Assert content.
  1990. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  1991. // Assert if DOM elements did not change.
  1992. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1993. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  1994. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  1995. // Assert mappings.
  1996. const mappings = renderer.domConverter._domToViewMapping;
  1997. expect( mappings.get( domP ) ).to.equal( viewP );
  1998. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  1999. } );
  2000. it( 'should handle complex view duplication', () => {
  2001. const content = '' +
  2002. '<container:blockquote>' +
  2003. '<container:ul>' +
  2004. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2005. '<container:li>Item 2</container:li>' +
  2006. '<container:li>' +
  2007. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2008. '</container:li>' +
  2009. '</container:ul>' +
  2010. '</container:blockquote>';
  2011. const expected = '' +
  2012. '<blockquote>' +
  2013. '<ul>' +
  2014. '<li>Quoted <strong>item 1</strong></li>' +
  2015. '<li>Item 2</li>' +
  2016. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2017. '</ul>' +
  2018. '</blockquote>';
  2019. viewRoot._appendChild( parse( content ) );
  2020. renderer.markToSync( 'children', viewRoot );
  2021. renderer.render();
  2022. expect( domRoot.innerHTML ).to.equal( expected );
  2023. viewRoot._removeChildren( 0, viewRoot.childCount );
  2024. viewRoot._appendChild( parse( content + content ) );
  2025. const domBQ = domRoot.childNodes[ 0 ];
  2026. const domUL = domBQ.childNodes[ 0 ];
  2027. const domLI1 = domUL.childNodes[ 0 ];
  2028. const domLI2 = domUL.childNodes[ 1 ];
  2029. const domLI3 = domUL.childNodes[ 2 ];
  2030. renderer.markToSync( 'children', viewRoot );
  2031. renderer.render();
  2032. // Assert content.
  2033. expect( domRoot.innerHTML ).to.equal( expected + expected );
  2034. // Assert if DOM elements did not change.
  2035. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  2036. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  2037. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  2038. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  2039. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  2040. // Assert mappings.
  2041. const domMappings = renderer.domConverter._domToViewMapping;
  2042. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  2043. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  2044. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  2045. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2046. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  2047. // Assert if new view elements are bind to new DOM elements.
  2048. const viewMappings = renderer.domConverter._domToViewMapping;
  2049. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  2050. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  2051. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  2052. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  2053. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  2054. } );
  2055. it( 'should handle complex view replace', () => {
  2056. const content = '' +
  2057. '<container:h2>He' +
  2058. '<attribute:i>ading 1</attribute:i>' +
  2059. '</container:h2>' +
  2060. '<container:p>Ph ' +
  2061. '<attribute:strong>Bold</attribute:strong>' +
  2062. '<attribute:a href="https://ckeditor.com">' +
  2063. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2064. '</attribute:a>' +
  2065. '</container:p>' +
  2066. '<container:blockquote>' +
  2067. '<container:ul>' +
  2068. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2069. '<container:li>Item 2</container:li>' +
  2070. '<container:li>' +
  2071. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2072. '</container:li>' +
  2073. '</container:ul>' +
  2074. '</container:blockquote>';
  2075. const replacement = '' +
  2076. '<container:p>' +
  2077. '1' +
  2078. '<attribute:i>A</attribute:i>' +
  2079. '</container:p>' +
  2080. '<container:p>' +
  2081. '<attribute:a href="https://cksource.com">' +
  2082. 'Li' +
  2083. '<attribute:strong>nk</attribute:strong>' +
  2084. '</attribute:a>' +
  2085. '</container:p>' +
  2086. '<container:h1>' +
  2087. 'Heading ' +
  2088. '<attribute:strong>1</attribute:strong>' +
  2089. '</container:h1>' +
  2090. '<container:h2>' +
  2091. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2092. '</container:h2>' +
  2093. '<container:h3>' +
  2094. 'Heading' +
  2095. '<attribute:i> 3</attribute:i>' +
  2096. '</container:h3>' +
  2097. '<container:blockquote>' +
  2098. 'Foo Bar Baz' +
  2099. '</container:blockquote>' +
  2100. '<container:ul>' +
  2101. '<container:li>' +
  2102. 'Item ' +
  2103. '<attribute:strong>1</attribute:strong>' +
  2104. '</container:li>' +
  2105. '<container:li>' +
  2106. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2107. ' 2' +
  2108. '</container:li>' +
  2109. '</container:ul>';
  2110. viewRoot._appendChild( parse( content ) );
  2111. renderer.markToSync( 'children', viewRoot );
  2112. renderer.render();
  2113. expect( domRoot.innerHTML ).to.equal( '' +
  2114. '<h2>He<i>ading 1</i></h2>' +
  2115. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2116. '<blockquote><ul>' +
  2117. '<li>Quoted <strong>item 1</strong></li>' +
  2118. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2119. '</ul></blockquote>' );
  2120. viewRoot._removeChildren( 0, viewRoot.childCount );
  2121. viewRoot._appendChild( parse( replacement ) );
  2122. renderer.markToSync( 'children', viewRoot );
  2123. renderer.render();
  2124. // Here we just check if new DOM structure was properly rendered.
  2125. expect( domRoot.innerHTML ).to.equal( '' +
  2126. '<p>1<i>A</i></p>' +
  2127. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2128. '<h1>Heading <strong>1</strong></h1>' +
  2129. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2130. '<h3>Heading<i> 3</i></h3>' +
  2131. '<blockquote>Foo Bar Baz</blockquote>' +
  2132. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2133. } );
  2134. it( 'should handle br elements while refreshing bindings', () => {
  2135. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2136. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2137. renderer.markToSync( 'children', viewRoot );
  2138. renderer.render();
  2139. expect( domRoot.innerHTML ).to.equal( expected );
  2140. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2141. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2142. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2143. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2144. viewRoot._removeChildren( 1 );
  2145. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2146. renderer.markToSync( 'children', viewRoot );
  2147. renderer.render();
  2148. expect( domRoot.innerHTML ).to.equal( expected );
  2149. } );
  2150. it( 'should handle list to paragraph conversion', () => {
  2151. const view = '' +
  2152. '<container:ol>' +
  2153. '<container:li>Item 1' +
  2154. '<container:ol>' +
  2155. '<container:li>Item 2</container:li>' +
  2156. '</container:ol>' +
  2157. '</container:li>' +
  2158. '</container:ol>' +
  2159. '<container:p>Paragraph</container:p>' +
  2160. '<container:ol>' +
  2161. '<container:li>Item 3' +
  2162. '<container:ol>' +
  2163. '<container:li>Item 4</container:li>' +
  2164. '</container:ol>' +
  2165. '</container:li>' +
  2166. '</container:ol>';
  2167. viewRoot._appendChild( parse( view ) );
  2168. renderer.markToSync( 'children', viewRoot );
  2169. renderer.render();
  2170. expect( domRoot.innerHTML ).to.equal(
  2171. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2172. const viewOL1 = viewRoot.getChild( 0 );
  2173. viewOL1.getChild( 0 )._removeChildren( 1 );
  2174. viewRoot._removeChildren( 2 );
  2175. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2176. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2177. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2178. const domOL1 = domRoot.childNodes[ 0 ];
  2179. const domOL2 = domRoot.childNodes[ 2 ];
  2180. const domP = domRoot.childNodes[ 1 ];
  2181. renderer.markToSync( 'children', viewRoot );
  2182. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2183. renderer.render();
  2184. expect( domRoot.innerHTML ).to.equal(
  2185. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2186. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2187. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2188. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2189. } );
  2190. it( 'should handle attributes change in replaced elements', () => {
  2191. const view = '' +
  2192. '<container:ol>' +
  2193. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2194. '</container:ol>' +
  2195. '<container:p>Paragraph ' +
  2196. '<attribute:a href="123">Link</attribute:a>' +
  2197. '</container:p>' +
  2198. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2199. viewRoot._appendChild( parse( view ) );
  2200. renderer.markToSync( 'children', viewRoot );
  2201. renderer.render();
  2202. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2203. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2204. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2205. const viewOL = viewRoot.getChild( 0 );
  2206. viewOL._removeChildren( 0 );
  2207. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2208. const viewP1 = viewRoot.getChild( 1 );
  2209. viewP1._removeChildren( 1 );
  2210. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2211. viewRoot._removeChildren( 2 );
  2212. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2213. renderer.markToSync( 'children', viewRoot );
  2214. renderer.markToSync( 'children', viewOL );
  2215. renderer.markToSync( 'children', viewP1 );
  2216. renderer.render();
  2217. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2218. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2219. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2220. } );
  2221. it( 'should handle classes change in replaced elements', () => {
  2222. const view = '' +
  2223. '<container:ol>' +
  2224. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2225. '</container:ol>' +
  2226. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2227. viewRoot._appendChild( parse( view ) );
  2228. renderer.markToSync( 'children', viewRoot );
  2229. renderer.render();
  2230. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2231. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2232. const viewOL = viewRoot.getChild( 0 );
  2233. const oldViewLI = viewOL.getChild( 0 );
  2234. viewOL._removeChildren( 0 );
  2235. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2236. const oldViewP = viewRoot.getChild( 1 );
  2237. viewRoot._removeChildren( 1 );
  2238. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2239. renderer.markToSync( 'attributes', oldViewLI );
  2240. renderer.markToSync( 'attributes', oldViewP );
  2241. renderer.markToSync( 'children', viewRoot );
  2242. renderer.markToSync( 'children', viewOL );
  2243. renderer.render();
  2244. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2245. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2246. } );
  2247. it( 'should handle styles change in replaced elements', () => {
  2248. const view = '' +
  2249. '<container:ol>' +
  2250. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2251. '<container:li>Bar ' +
  2252. '<attribute:i>' +
  2253. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2254. ' Bax</attribute:i>' +
  2255. '</container:li>' +
  2256. '</container:ol>';
  2257. viewRoot._appendChild( parse( view ) );
  2258. renderer.markToSync( 'children', viewRoot );
  2259. renderer.render();
  2260. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2261. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2262. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2263. const viewOL = viewRoot.getChild( 0 );
  2264. const viewLI1 = viewOL.getChild( 0 );
  2265. const viewLI2 = viewOL.getChild( 1 );
  2266. viewLI1._removeStyle( 'font-weight' );
  2267. viewLI1._setStyle( { color: '#FFF' } );
  2268. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2269. viewLI2._removeChildren( 0, viewLI2.childCount );
  2270. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2271. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2272. renderer.markToSync( 'attributes', viewLI1 );
  2273. renderer.markToSync( 'attributes', viewLI2 );
  2274. renderer.markToSync( 'children', viewRoot );
  2275. renderer.markToSync( 'children', viewLI2 );
  2276. renderer.render();
  2277. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2278. '<ol><li style="color:#FFF;">Foo</li>' +
  2279. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2280. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2281. } );
  2282. it( 'should handle uiElement rendering', () => {
  2283. function createUIElement( id, text ) {
  2284. const element = new UIElement( 'span' );
  2285. element.render = function( domDocument ) {
  2286. const domElement = this.toDomElement( domDocument );
  2287. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2288. return domElement;
  2289. };
  2290. return element;
  2291. }
  2292. const ui1 = createUIElement( 'id1', 'UI1' );
  2293. const ui2 = createUIElement( 'id2', 'UI2' );
  2294. const viewP = new ViewContainerElement( 'p', null, [ new ViewText( 'Foo ' ), ui1, new ViewText( 'Bar' ) ] );
  2295. viewRoot._appendChild( viewP );
  2296. renderer.markToSync( 'children', viewRoot );
  2297. renderer.render();
  2298. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2299. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2300. viewP._removeChildren( 0, viewP.childCount );
  2301. viewP._insertChild( 0, [ new ViewText( 'Foo' ), ui2, new ViewText( ' Bar' ) ] );
  2302. renderer.markToSync( 'children', viewRoot );
  2303. renderer.markToSync( 'children', viewP );
  2304. renderer.render();
  2305. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2306. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2307. } );
  2308. it( 'should handle linking entire content', () => {
  2309. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2310. renderer.markToSync( 'children', viewRoot );
  2311. renderer.render();
  2312. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2313. const viewP = viewRoot.getChild( 0 );
  2314. // While linking, the existing DOM children are moved to a new `a` element during binding
  2315. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2316. // where view elements were moved to a newly created link view element.
  2317. const viewA = new ViewAttributeElement( 'a', { href: '#href' }, [ new ViewText( 'Foo' ), viewP.getChild( 1 ) ] );
  2318. viewP._removeChildren( 0, viewP.childCount );
  2319. viewP._insertChild( 0, viewA );
  2320. renderer.markToSync( 'children', viewRoot );
  2321. renderer.markToSync( 'children', viewP );
  2322. renderer.render();
  2323. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2324. } );
  2325. } );
  2326. describe( 'optimal (minimal) rendering – minimal children changes', () => {
  2327. let observer;
  2328. beforeEach( () => {
  2329. observer = new MutationObserver( () => {} );
  2330. observer.observe( domRoot, {
  2331. childList: true,
  2332. attributes: false,
  2333. subtree: false
  2334. } );
  2335. } );
  2336. afterEach( () => {
  2337. observer.disconnect();
  2338. } );
  2339. it( 'should add only one child (at the beginning)', () => {
  2340. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2341. renderer.markToSync( 'children', viewRoot );
  2342. renderer.render();
  2343. cleanObserver( observer );
  2344. viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
  2345. renderer.markToSync( 'children', viewRoot );
  2346. renderer.render();
  2347. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2348. 'added: 1, removed: 0'
  2349. ] );
  2350. } );
  2351. it( 'should add only one child (at the end)', () => {
  2352. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2353. renderer.markToSync( 'children', viewRoot );
  2354. renderer.render();
  2355. cleanObserver( observer );
  2356. viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
  2357. renderer.markToSync( 'children', viewRoot );
  2358. renderer.render();
  2359. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2360. 'added: 1, removed: 0'
  2361. ] );
  2362. } );
  2363. it( 'should add only one child (in the middle)', () => {
  2364. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2365. renderer.markToSync( 'children', viewRoot );
  2366. renderer.render();
  2367. cleanObserver( observer );
  2368. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2369. renderer.markToSync( 'children', viewRoot );
  2370. renderer.render();
  2371. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2372. 'added: 1, removed: 0'
  2373. ] );
  2374. } );
  2375. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2376. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2377. renderer.markToSync( 'children', viewRoot );
  2378. renderer.render();
  2379. cleanObserver( observer );
  2380. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2381. viewRoot._removeChildren( 0, 1 );
  2382. renderer.markToSync( 'children', viewRoot );
  2383. renderer.render();
  2384. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2385. } );
  2386. it( 'should add and remove one', () => {
  2387. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2388. renderer.markToSync( 'children', viewRoot );
  2389. renderer.render();
  2390. cleanObserver( observer );
  2391. viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
  2392. viewRoot._removeChildren( 0, 1 );
  2393. renderer.markToSync( 'children', viewRoot );
  2394. renderer.render();
  2395. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2396. 'added: 1, removed: 0',
  2397. 'added: 0, removed: 1'
  2398. ] );
  2399. } );
  2400. it( 'should not touch the FSC when rendering children', () => {
  2401. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2402. // Set fake selection on the second paragraph.
  2403. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2404. renderer.markToSync( 'children', viewRoot );
  2405. renderer.render();
  2406. cleanObserver( observer );
  2407. // Remove the second paragraph.
  2408. viewRoot._removeChildren( 1, 1 );
  2409. // And set the fake selection on the first one.
  2410. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2411. renderer.markToSync( 'children', viewRoot );
  2412. renderer.render();
  2413. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2414. 'added: 0, removed: 1'
  2415. ] );
  2416. } );
  2417. it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
  2418. // This test's purpose is mostly reaching 100% CC.
  2419. observer = new MutationObserver( () => {} );
  2420. viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
  2421. const viewDiv = viewRoot.getChild( 0 );
  2422. // Set fake selection on the second paragraph.
  2423. selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
  2424. renderer.markToSync( 'children', viewDiv );
  2425. renderer.markToSync( 'children', viewRoot );
  2426. renderer.render();
  2427. observer.observe( domRoot.childNodes[ 0 ], {
  2428. childList: true,
  2429. attributes: false,
  2430. subtree: false
  2431. } );
  2432. // Remove the second paragraph.
  2433. viewDiv._removeChildren( 1, 1 );
  2434. // And set the fake selection on the first one.
  2435. selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
  2436. renderer.markToSync( 'children', viewDiv );
  2437. renderer.markToSync( 'children', viewRoot );
  2438. renderer.render();
  2439. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2440. 'added: 0, removed: 1'
  2441. ] );
  2442. observer.disconnect();
  2443. } );
  2444. describe( 'using fastDiff() - significant number of nodes in the editor', () => {
  2445. it( 'should add only one child (at the beginning)', () => {
  2446. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2447. renderer.markToSync( 'children', viewRoot );
  2448. renderer.render();
  2449. cleanObserver( observer );
  2450. viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
  2451. renderer.markToSync( 'children', viewRoot );
  2452. renderer.render();
  2453. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2454. 'added: 1, removed: 0'
  2455. ] );
  2456. } );
  2457. it( 'should add only one child (at the end)', () => {
  2458. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2459. renderer.markToSync( 'children', viewRoot );
  2460. renderer.render();
  2461. cleanObserver( observer );
  2462. viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
  2463. renderer.markToSync( 'children', viewRoot );
  2464. renderer.render();
  2465. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2466. 'added: 1, removed: 0'
  2467. ] );
  2468. } );
  2469. it( 'should add only one child (in the middle)', () => {
  2470. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2471. renderer.markToSync( 'children', viewRoot );
  2472. renderer.render();
  2473. cleanObserver( observer );
  2474. viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
  2475. renderer.markToSync( 'children', viewRoot );
  2476. renderer.render();
  2477. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2478. 'added: 1, removed: 0'
  2479. ] );
  2480. } );
  2481. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2482. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2483. renderer.markToSync( 'children', viewRoot );
  2484. renderer.render();
  2485. cleanObserver( observer );
  2486. viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
  2487. viewRoot._removeChildren( 0, 1 );
  2488. renderer.markToSync( 'children', viewRoot );
  2489. renderer.render();
  2490. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2491. } );
  2492. it( 'should add and remove one', () => {
  2493. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2494. renderer.markToSync( 'children', viewRoot );
  2495. renderer.render();
  2496. cleanObserver( observer );
  2497. viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
  2498. viewRoot._removeChildren( 0, 1 );
  2499. renderer.markToSync( 'children', viewRoot );
  2500. renderer.render();
  2501. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2502. 'added: 1, removed: 0',
  2503. 'added: 0, removed: 1'
  2504. ] );
  2505. } );
  2506. it( 'should not touch the FSC when rendering children', () => {
  2507. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2508. // Set fake selection on the second paragraph.
  2509. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2510. renderer.markToSync( 'children', viewRoot );
  2511. renderer.render();
  2512. cleanObserver( observer );
  2513. // Remove the second paragraph.
  2514. viewRoot._removeChildren( 1, 1 );
  2515. // And set the fake selection on the first one.
  2516. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2517. renderer.markToSync( 'children', viewRoot );
  2518. renderer.render();
  2519. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2520. 'added: 0, removed: 1'
  2521. ] );
  2522. } );
  2523. } );
  2524. function getMutationStats( mutationList ) {
  2525. return mutationList.map( mutation => {
  2526. return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
  2527. } );
  2528. }
  2529. function cleanObserver( observer ) {
  2530. observer.takeRecords();
  2531. }
  2532. function makeContainers( howMany ) {
  2533. const containers = [];
  2534. for ( let i = 1; i <= howMany; i++ ) {
  2535. containers.push( `<container:p>${ i }</container:p>` );
  2536. }
  2537. return containers.join( '' );
  2538. }
  2539. } );
  2540. // #1560
  2541. describe( 'attributes manipulation on replaced element', () => {
  2542. it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
  2543. const writer = new DowncastWriter();
  2544. // 1. Setup initial view/DOM.
  2545. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2546. const viewP = viewRoot.getChild( 0 );
  2547. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2548. renderer.markToSync( 'children', viewRoot );
  2549. renderer.render();
  2550. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2551. // 2. Modify view.
  2552. writer.removeAttribute( 'data-placeholder', viewP );
  2553. viewRoot._removeChildren( 0, viewRoot.childCount );
  2554. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2555. renderer.markToSync( 'attributes', viewP );
  2556. renderer.markToSync( 'children', viewRoot );
  2557. renderer.render();
  2558. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2559. } );
  2560. it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
  2561. const writer = new DowncastWriter();
  2562. // 1. Setup initial view/DOM.
  2563. viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
  2564. const viewP = viewRoot.getChild( 1 );
  2565. writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
  2566. renderer.markToSync( 'children', viewRoot );
  2567. renderer.render();
  2568. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
  2569. // 2. Modify view.
  2570. writer.removeClass( 'cke-test2', viewP );
  2571. viewRoot._removeChildren( 0, viewRoot.childCount );
  2572. viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
  2573. '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
  2574. renderer.markToSync( 'attributes', viewP );
  2575. renderer.markToSync( 'children', viewRoot );
  2576. renderer.render();
  2577. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
  2578. } );
  2579. it( 'should rerender element if it was removed and have its attributes removed after', () => {
  2580. const writer = new DowncastWriter();
  2581. // 1. Setup initial view/DOM.
  2582. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2583. const viewP = viewRoot.getChild( 0 );
  2584. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2585. renderer.markToSync( 'children', viewRoot );
  2586. renderer.render();
  2587. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2588. // 2. Modify view.
  2589. viewRoot._removeChildren( 0, viewRoot.childCount );
  2590. writer.removeAttribute( 'data-placeholder', viewP );
  2591. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2592. renderer.markToSync( 'children', viewRoot );
  2593. renderer.render();
  2594. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2595. } );
  2596. } );
  2597. // ckeditor/ckeditor5-utils#269
  2598. // The expected times has a significant margin above the usual execution time (which is around 40-50%
  2599. // of the expected time) because it depends on the browser and environment in which tests are run.
  2600. // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
  2601. // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
  2602. describe( 'rendering performance', () => {
  2603. before( function() {
  2604. // Ignore on Edge browser where performance is quite poor.
  2605. if ( env.isEdge ) {
  2606. this.skip();
  2607. }
  2608. } );
  2609. it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
  2610. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
  2611. expect( renderingTime ).to.be.within( 0, 350 );
  2612. } );
  2613. it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
  2614. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
  2615. expect( renderingTime ).to.be.within( 0, 350 );
  2616. } );
  2617. it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
  2618. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
  2619. expect( renderingTime ).to.be.within( 0, 350 );
  2620. } );
  2621. it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
  2622. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
  2623. expect( renderingTime ).to.be.within( 0, 350 );
  2624. } );
  2625. it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
  2626. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
  2627. expect( renderingTime ).to.be.within( 0, 350 );
  2628. } );
  2629. it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
  2630. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
  2631. expect( renderingTime ).to.be.within( 0, 350 );
  2632. } );
  2633. function measureRenderingTime( viewRoot, initialData, newData ) {
  2634. // Set initial data.
  2635. const initialView = parse( initialData );
  2636. viewRoot._appendChild( initialView );
  2637. renderer.markToSync( 'children', viewRoot );
  2638. renderer.render();
  2639. // Set new data.
  2640. const newView = parse( newData );
  2641. viewRoot._removeChildren( 0, viewRoot.childCount );
  2642. viewRoot._appendChild( newView );
  2643. renderer.markToSync( 'children', viewRoot );
  2644. // Measure render time.
  2645. const start = Date.now();
  2646. renderer.render();
  2647. return Date.now() - start;
  2648. }
  2649. function generateViewData1( repeat = 1 ) {
  2650. const viewData = '' +
  2651. '<container:h1>' +
  2652. 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
  2653. '</container:h1>' +
  2654. '<container:p>' +
  2655. 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
  2656. '</container:p>' +
  2657. '<container:ul>' +
  2658. '<container:li>Item 1</container:li>' +
  2659. '</container:ul>' +
  2660. '<container:ul>' +
  2661. '<container:li>Item 2</container:li>' +
  2662. '</container:ul>' +
  2663. '<container:ul>' +
  2664. '<container:li>Item 3</container:li>' +
  2665. '</container:ul>';
  2666. return viewData.repeat( repeat );
  2667. }
  2668. function generateViewData2( repeat = 1 ) {
  2669. const viewData = '' +
  2670. '<container:ol>' +
  2671. '<container:li>' +
  2672. '<attribute:strong>Foo</attribute:strong>' +
  2673. '</container:li>' +
  2674. '</container:ol>' +
  2675. '<container:ol>' +
  2676. '<container:li>Item 1</container:li>' +
  2677. '</container:ol>' +
  2678. '<container:h1>Heading 1</container:h1>' +
  2679. '<container:h2>' +
  2680. '<attribute:strong>Heading</attribute:strong> 2' +
  2681. '</container:h2>' +
  2682. '<container:h3>Heading 4</container:h3>';
  2683. return viewData.repeat( repeat );
  2684. }
  2685. } );
  2686. } );
  2687. describe( '#922', () => {
  2688. let view, viewDoc, viewRoot, domRoot, converter;
  2689. beforeEach( () => {
  2690. view = new View();
  2691. viewDoc = view.document;
  2692. domRoot = document.createElement( 'div' );
  2693. document.body.appendChild( domRoot );
  2694. viewRoot = createViewRoot( viewDoc );
  2695. view.attachDomRoot( domRoot );
  2696. converter = view.domConverter;
  2697. } );
  2698. it( 'should properly render unwrapped attributes #1', () => {
  2699. setViewData( view,
  2700. '<container:p>' +
  2701. '[<attribute:italic>' +
  2702. '<attribute:strong>f</attribute:strong>' +
  2703. '</attribute:italic>]' +
  2704. '<attribute:strong>oo</attribute:strong>' +
  2705. '</container:p>'
  2706. );
  2707. // Render it to DOM to create initial DOM <-> view mappings.
  2708. view.forceRender();
  2709. // Unwrap italic attribute element.
  2710. view.change( writer => {
  2711. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2712. } );
  2713. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2714. // Re-render changes in view to DOM.
  2715. view.forceRender();
  2716. // Check if DOM is rendered correctly.
  2717. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2718. expect( checkMappings() ).to.be.true;
  2719. } );
  2720. it( 'should properly render unwrapped attributes #2', () => {
  2721. setViewData( view,
  2722. '<container:p>' +
  2723. '[<attribute:italic>' +
  2724. '<attribute:strong>foo</attribute:strong>' +
  2725. '</attribute:italic>]' +
  2726. '</container:p>' );
  2727. // Render it to DOM to create initial DOM <-> view mappings.
  2728. view.forceRender();
  2729. // Unwrap italic attribute element and change text inside.
  2730. view.change( writer => {
  2731. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2732. } );
  2733. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2734. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2735. // Re-render changes in view to DOM.
  2736. view.forceRender();
  2737. // Check if DOM is rendered correctly.
  2738. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2739. expect( checkMappings() ).to.be.true;
  2740. } );
  2741. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2742. setViewData( view,
  2743. '<container:p>foo</container:p>'
  2744. );
  2745. // Render it to DOM to create initial DOM <-> view mappings.
  2746. view.forceRender();
  2747. // Change text and insert new element into paragraph.
  2748. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2749. textNode._data = 'foobar';
  2750. view.change( writer => {
  2751. writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  2752. } );
  2753. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2754. // Re-render changes in view to DOM.
  2755. view.forceRender();
  2756. // Check if DOM is rendered correctly.
  2757. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2758. expect( checkMappings() ).to.be.true;
  2759. } );
  2760. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2761. setViewData( view,
  2762. '<container:p>foo</container:p>'
  2763. );
  2764. // Render it to DOM to create initial DOM <-> view mappings.
  2765. view.forceRender();
  2766. // Change text and insert new element into paragraph.
  2767. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2768. textNode._data = 'foobar';
  2769. view.change( writer => {
  2770. writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  2771. } );
  2772. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2773. // Re-render changes in view to DOM.
  2774. view.forceRender();
  2775. // Check if DOM is rendered correctly.
  2776. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2777. expect( checkMappings() ).to.be.true;
  2778. } );
  2779. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2780. setViewData( view,
  2781. '<container:p>' +
  2782. '<attribute:b></attribute:b>' +
  2783. '<attribute:i></attribute:i>' +
  2784. '<attribute:span></attribute:span>' +
  2785. '</container:p>'
  2786. );
  2787. // Render it to DOM to create initial DOM <-> view mappings.
  2788. view.forceRender();
  2789. // Remove first element and reinsert it at the end.
  2790. const container = viewRoot.getChild( 0 );
  2791. const firstElement = container.getChild( 0 );
  2792. view.change( writer => {
  2793. writer.remove( ViewRange._createOn( firstElement ) );
  2794. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2795. } );
  2796. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2797. // Re-render changes in view to DOM.
  2798. view.forceRender();
  2799. // Check if DOM is rendered correctly.
  2800. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2801. expect( checkMappings() ).to.be.true;
  2802. } );
  2803. // Checks if every node in DOM tree is mapped to the view.
  2804. function checkMappings() {
  2805. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2806. while ( domWalker.nextNode() ) {
  2807. const node = domWalker.currentNode;
  2808. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2809. return false;
  2810. }
  2811. }
  2812. return true;
  2813. }
  2814. } );
  2815. describe( '_markDescendantTextToSync', () => {
  2816. let viewRoot;
  2817. beforeEach( () => {
  2818. viewRoot = new ViewElement( 'div' );
  2819. renderer.markedTexts.clear();
  2820. renderer.markedAttributes.clear();
  2821. renderer.markedChildren.clear();
  2822. } );
  2823. it( 'should handle null values', () => {
  2824. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2825. renderer._markDescendantTextToSync( null );
  2826. expect( renderer.markedChildren.size ).to.equal( 0 );
  2827. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2828. expect( renderer.markedTexts.size ).to.equal( 0 );
  2829. } );
  2830. it( 'should handle element nodes', () => {
  2831. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2832. viewRoot._appendChild( viewP );
  2833. renderer._markDescendantTextToSync( viewP );
  2834. expect( renderer.markedChildren.size ).to.equal( 0 );
  2835. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2836. expect( renderer.markedTexts.size ).to.equal( 3 );
  2837. } );
  2838. it( 'should handle text nodes', () => {
  2839. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2840. viewRoot._appendChild( viewP );
  2841. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2842. expect( renderer.markedChildren.size ).to.equal( 0 );
  2843. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2844. expect( renderer.markedTexts.size ).to.equal( 1 );
  2845. } );
  2846. it( 'should handle document fragment', () => {
  2847. const fragment = new DocumentFragment();
  2848. renderer._markDescendantTextToSync( fragment );
  2849. expect( renderer.markedChildren.size ).to.equal( 0 );
  2850. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2851. expect( renderer.markedTexts.size ).to.equal( 0 );
  2852. } );
  2853. it( 'should handle empty element nodes', () => {
  2854. const viewP = parse( '<container:p></container:p>' );
  2855. viewRoot._appendChild( viewP );
  2856. renderer._markDescendantTextToSync( viewP );
  2857. expect( renderer.markedChildren.size ).to.equal( 0 );
  2858. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2859. expect( renderer.markedTexts.size ).to.equal( 0 );
  2860. } );
  2861. } );
  2862. describe( '_updateText', () => {
  2863. let viewRoot, domRoot;
  2864. beforeEach( () => {
  2865. viewRoot = new ViewElement( 'div' );
  2866. domRoot = document.createElement( 'div' );
  2867. document.body.appendChild( domRoot );
  2868. domConverter.bindElements( domRoot, viewRoot );
  2869. renderer.markedTexts.clear();
  2870. renderer.markedAttributes.clear();
  2871. renderer.markedChildren.clear();
  2872. renderer.isFocused = true;
  2873. } );
  2874. afterEach( () => {
  2875. domRoot.remove();
  2876. } );
  2877. it( 'should update text - change on end', () => {
  2878. const viewText = new ViewText( 'foo' );
  2879. viewRoot._appendChild( viewText );
  2880. renderer.markToSync( 'children', viewRoot );
  2881. renderer.render();
  2882. expect( domRoot.childNodes.length ).to.equal( 1 );
  2883. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2884. viewText._data = 'fobar';
  2885. renderer._updateText( viewText, {} );
  2886. expect( domRoot.childNodes.length ).to.equal( 1 );
  2887. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2888. } );
  2889. it( 'should update text - change on start', () => {
  2890. const viewText = new ViewText( 'foo' );
  2891. viewRoot._appendChild( viewText );
  2892. renderer.markToSync( 'children', viewRoot );
  2893. renderer.render();
  2894. expect( domRoot.childNodes.length ).to.equal( 1 );
  2895. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2896. viewText._data = 'baro';
  2897. renderer._updateText( viewText, {} );
  2898. expect( domRoot.childNodes.length ).to.equal( 1 );
  2899. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  2900. } );
  2901. it( 'should update text - change in the middle', () => {
  2902. const viewText = new ViewText( 'foobar' );
  2903. viewRoot._appendChild( viewText );
  2904. renderer.markToSync( 'children', viewRoot );
  2905. renderer.render();
  2906. expect( domRoot.childNodes.length ).to.equal( 1 );
  2907. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  2908. viewText._data = 'fobazr';
  2909. renderer._updateText( viewText, {} );
  2910. expect( domRoot.childNodes.length ).to.equal( 1 );
  2911. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  2912. } );
  2913. it( 'should update text - empty expected', () => {
  2914. const viewText = new ViewText( 'foo' );
  2915. viewRoot._appendChild( viewText );
  2916. renderer.markToSync( 'children', viewRoot );
  2917. renderer.render();
  2918. expect( domRoot.childNodes.length ).to.equal( 1 );
  2919. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2920. viewText._data = '';
  2921. renderer._updateText( viewText, {} );
  2922. expect( domRoot.childNodes.length ).to.equal( 1 );
  2923. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2924. } );
  2925. it( 'should update text - empty actual', () => {
  2926. const viewText = new ViewText( '' );
  2927. viewRoot._appendChild( viewText );
  2928. renderer.markToSync( 'children', viewRoot );
  2929. renderer.render();
  2930. expect( domRoot.childNodes.length ).to.equal( 1 );
  2931. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2932. viewText._data = 'fobar';
  2933. renderer._updateText( viewText, {} );
  2934. expect( domRoot.childNodes.length ).to.equal( 1 );
  2935. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2936. } );
  2937. it( 'should handle filler during text modifications', () => {
  2938. const viewText = new ViewText( 'foo' );
  2939. viewRoot._appendChild( viewText );
  2940. renderer.markToSync( 'children', viewRoot );
  2941. renderer.render();
  2942. expect( domRoot.childNodes.length ).to.equal( 1 );
  2943. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2944. // 1. Insert filler.
  2945. renderer._updateText( viewText, {
  2946. inlineFillerPosition: {
  2947. parent: viewText.parent,
  2948. offset: 0
  2949. }
  2950. } );
  2951. expect( domRoot.childNodes.length ).to.equal( 1 );
  2952. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2953. // 2. Edit text - filler should be preserved.
  2954. viewText._data = 'barfoo';
  2955. renderer._updateText( viewText, {
  2956. inlineFillerPosition: {
  2957. parent: viewText.parent,
  2958. offset: 0
  2959. }
  2960. } );
  2961. expect( domRoot.childNodes.length ).to.equal( 1 );
  2962. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  2963. // 3. Remove filler.
  2964. renderer._updateText( viewText, {} );
  2965. expect( domRoot.childNodes.length ).to.equal( 1 );
  2966. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  2967. } );
  2968. it( 'should handle filler during text modifications - empty text', () => {
  2969. const viewText = new ViewText( '' );
  2970. viewRoot._appendChild( viewText );
  2971. renderer.markToSync( 'children', viewRoot );
  2972. renderer.render();
  2973. expect( domRoot.childNodes.length ).to.equal( 1 );
  2974. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2975. // 1. Insert filler.
  2976. renderer._updateText( viewText, {
  2977. inlineFillerPosition: {
  2978. parent: viewText.parent,
  2979. offset: 0
  2980. }
  2981. } );
  2982. expect( domRoot.childNodes.length ).to.equal( 1 );
  2983. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  2984. // 2. Edit text - filler should be preserved.
  2985. viewText._data = 'foo';
  2986. renderer._updateText( viewText, {
  2987. inlineFillerPosition: {
  2988. parent: viewText.parent,
  2989. offset: 0
  2990. }
  2991. } );
  2992. expect( domRoot.childNodes.length ).to.equal( 1 );
  2993. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2994. // 3. Remove filler.
  2995. viewText._data = '';
  2996. renderer._updateText( viewText, {} );
  2997. expect( domRoot.childNodes.length ).to.equal( 1 );
  2998. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2999. } );
  3000. it( 'should handle filler during text modifications inside inline element', () => {
  3001. const viewB = new ViewElement( 'b' );
  3002. const viewText = new ViewText( 'foo' );
  3003. viewB._appendChild( viewText );
  3004. viewRoot._appendChild( viewB );
  3005. renderer.markToSync( 'children', viewRoot );
  3006. renderer.render();
  3007. expect( domRoot.childNodes.length ).to.equal( 1 );
  3008. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3009. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3010. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  3011. // 1. Insert filler.
  3012. renderer._updateText( viewText, {
  3013. inlineFillerPosition: {
  3014. parent: viewText.parent,
  3015. offset: 0
  3016. }
  3017. } );
  3018. expect( domRoot.childNodes.length ).to.equal( 1 );
  3019. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3020. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3021. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3022. // 2. Edit text - filler should be preserved.
  3023. viewText._data = 'bar';
  3024. renderer._updateText( viewText, {
  3025. inlineFillerPosition: {
  3026. parent: viewText.parent,
  3027. offset: 0
  3028. }
  3029. } );
  3030. expect( domRoot.childNodes.length ).to.equal( 1 );
  3031. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3032. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3033. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  3034. // 3. Remove filler.
  3035. viewText._data = 'bar';
  3036. renderer._updateText( viewText, {} );
  3037. expect( domRoot.childNodes.length ).to.equal( 1 );
  3038. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3039. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3040. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  3041. } );
  3042. } );
  3043. } );
  3044. function renderAndExpectNoChanges( renderer, domRoot ) {
  3045. const config = {
  3046. childList: true,
  3047. characterData: true,
  3048. characterDataOldValue: true,
  3049. subtree: true
  3050. };
  3051. const mutationObserver = new window.MutationObserver( () => {
  3052. throw 'There should be not mutations';
  3053. } );
  3054. mutationObserver.observe( domRoot, config );
  3055. renderer.render();
  3056. const records = mutationObserver.takeRecords();
  3057. mutationObserver.disconnect();
  3058. expect( records.length ).to.equal( 0 );
  3059. }