renderer.js 149 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230
  1. /**
  2. * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  4. */
  5. /* globals document, window, NodeFilter, MutationObserver */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewEditableElement from '../../src/view/editableelement';
  9. import ViewContainerElement from '../../src/view/containerelement';
  10. import ViewAttributeElement from '../../src/view/attributeelement';
  11. import ViewText from '../../src/view/text';
  12. import ViewRange from '../../src/view/range';
  13. import ViewPosition from '../../src/view/position';
  14. import ViewDocument from '../../src/view/document';
  15. import UIElement from '../../src/view/uielement';
  16. import DocumentSelection from '../../src/view/documentselection';
  17. import DomConverter from '../../src/view/domconverter';
  18. import Renderer from '../../src/view/renderer';
  19. import DocumentFragment from '../../src/view/documentfragment';
  20. import DowncastWriter from '../../src/view/downcastwriter';
  21. import { parse, stringify, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  22. import { BR_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../../src/view/filler';
  23. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  24. import createViewRoot from './_utils/createroot';
  25. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  26. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  27. import env from '@ckeditor/ckeditor5-utils/src/env';
  28. import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
  29. describe( 'Renderer', () => {
  30. let selection, domConverter, renderer, viewDocument;
  31. testUtils.createSinonSandbox();
  32. beforeEach( () => {
  33. selection = new DocumentSelection();
  34. domConverter = new DomConverter();
  35. viewDocument = new ViewDocument();
  36. renderer = new Renderer( domConverter, selection );
  37. renderer.domDocuments.add( document );
  38. } );
  39. describe( 'markToSync', () => {
  40. let viewRoot;
  41. beforeEach( () => {
  42. viewRoot = new ViewElement( viewDocument, 'p' );
  43. const domRoot = document.createElement( 'p' );
  44. domConverter.bindElements( domRoot, viewRoot );
  45. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  46. renderer.markedTexts.clear();
  47. renderer.markedAttributes.clear();
  48. renderer.markedChildren.clear();
  49. } );
  50. it( 'should mark attributes which need update', () => {
  51. viewRoot._setAttribute( 'class', 'foo' );
  52. renderer.markToSync( 'attributes', viewRoot );
  53. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  54. } );
  55. it( 'should mark children which need update', () => {
  56. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  57. renderer.markToSync( 'children', viewRoot );
  58. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  59. } );
  60. it( 'should not mark children if element has no corresponding node', () => {
  61. // Overwrite viewRoot with node without coresponding DOM node.
  62. viewRoot = new ViewElement( viewDocument, 'p' );
  63. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  64. renderer.markToSync( 'children', viewRoot );
  65. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  66. } );
  67. it( 'should mark text which need update', () => {
  68. const viewText = new ViewText( viewDocument, 'foo' );
  69. viewRoot._appendChild( viewText );
  70. viewText._data = 'bar';
  71. renderer.markToSync( 'text', viewText );
  72. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  73. } );
  74. it( 'should not mark text if parent has no corresponding node', () => {
  75. const viewText = new ViewText( viewDocument, 'foo' );
  76. // Overwrite viewRoot with node without coresponding DOM node.
  77. viewRoot = new ViewElement( viewDocument, 'p' );
  78. viewRoot._appendChild( viewText );
  79. viewText._data = 'bar';
  80. renderer.markToSync( 'text', viewText );
  81. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  82. } );
  83. it( 'should throw if the type is unknown', () => {
  84. expectToThrowCKEditorError( () => {
  85. renderer.markToSync( 'UNKNOWN', viewRoot );
  86. }, /^view-renderer-unknown-type/, selection );
  87. } );
  88. } );
  89. describe( 'render', () => {
  90. let viewRoot, domRoot;
  91. beforeEach( () => {
  92. viewRoot = new ViewEditableElement( viewDocument, 'div' );
  93. viewRoot.getFillerOffset = () => null;
  94. domRoot = document.createElement( 'div' );
  95. document.body.appendChild( domRoot );
  96. domConverter.bindElements( domRoot, viewRoot );
  97. renderer.markedTexts.clear();
  98. renderer.markedAttributes.clear();
  99. renderer.markedChildren.clear();
  100. selection._setTo( null );
  101. renderer.isFocused = true;
  102. } );
  103. afterEach( () => {
  104. domRoot.remove();
  105. } );
  106. it( 'should update attributes', () => {
  107. viewRoot._setAttribute( 'class', 'foo' );
  108. renderer.markToSync( 'attributes', viewRoot );
  109. renderer.render();
  110. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  111. expect( renderer.markedAttributes.size ).to.equal( 0 );
  112. } );
  113. it( 'should remove attributes', () => {
  114. viewRoot._setAttribute( 'class', 'foo' );
  115. domRoot.setAttribute( 'id', 'bar' );
  116. domRoot.setAttribute( 'class', 'bar' );
  117. renderer.markToSync( 'attributes', viewRoot );
  118. renderer.render();
  119. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  120. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  121. expect( renderer.markedAttributes.size ).to.equal( 0 );
  122. } );
  123. it( 'should add children', () => {
  124. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. expect( renderer.markedChildren.size ).to.equal( 0 );
  130. } );
  131. it( 'should remove children', () => {
  132. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  133. renderer.markToSync( 'children', viewRoot );
  134. renderer.render();
  135. expect( domRoot.childNodes.length ).to.equal( 1 );
  136. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  137. viewRoot._removeChildren( 0, 1 );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 0 );
  141. expect( renderer.markedChildren.size ).to.equal( 0 );
  142. } );
  143. it( 'should update text', () => {
  144. const viewText = new ViewText( viewDocument, 'foo' );
  145. viewRoot._appendChild( viewText );
  146. renderer.markToSync( 'children', viewRoot );
  147. renderer.render();
  148. expect( domRoot.childNodes.length ).to.equal( 1 );
  149. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  150. viewText._data = 'bar';
  151. renderer.markToSync( 'text', viewText );
  152. renderer.render();
  153. expect( domRoot.childNodes.length ).to.equal( 1 );
  154. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  155. expect( renderer.markedTexts.size ).to.equal( 0 );
  156. } );
  157. it( 'should not update same text', () => {
  158. const viewText = new ViewText( viewDocument, 'foo' );
  159. viewRoot._appendChild( viewText );
  160. renderer.markToSync( 'children', viewRoot );
  161. renderer.render();
  162. expect( domRoot.childNodes.length ).to.equal( 1 );
  163. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  164. viewText._data = 'foo';
  165. renderer.markToSync( 'text', viewText );
  166. renderAndExpectNoChanges( renderer, domRoot );
  167. expect( domRoot.childNodes.length ).to.equal( 1 );
  168. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  169. expect( renderer.markedTexts.size ).to.equal( 0 );
  170. } );
  171. it( 'should not update text parent child list changed', () => {
  172. const viewImg = new ViewElement( viewDocument, 'img' );
  173. const viewText = new ViewText( viewDocument, 'foo' );
  174. viewRoot._appendChild( [ viewImg, viewText ] );
  175. renderer.markToSync( 'children', viewRoot );
  176. renderer.markToSync( 'text', viewText );
  177. renderer.render();
  178. expect( domRoot.childNodes.length ).to.equal( 2 );
  179. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  180. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  181. } );
  182. it( 'should not change text if it is the same during text rendering', () => {
  183. const viewText = new ViewText( viewDocument, 'foo' );
  184. viewRoot._appendChild( viewText );
  185. renderer.markToSync( 'children', viewRoot );
  186. renderer.render();
  187. // This should not be changed during the render.
  188. const domText = domRoot.childNodes[ 0 ];
  189. renderer.markToSync( 'text', viewText );
  190. renderer.render();
  191. expect( domRoot.childNodes.length ).to.equal( 1 );
  192. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  193. } );
  194. it( 'should not change text if it is the same during children rendering', () => {
  195. const viewText = new ViewText( viewDocument, 'foo' );
  196. viewRoot._appendChild( viewText );
  197. renderer.markToSync( 'children', viewRoot );
  198. renderer.render();
  199. // This should not be changed during the render.
  200. const domText = domRoot.childNodes[ 0 ];
  201. renderer.markToSync( 'children', viewRoot );
  202. renderer.render();
  203. expect( domRoot.childNodes.length ).to.equal( 1 );
  204. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  205. } );
  206. it( 'should not change element if it is the same', () => {
  207. const viewImg = new ViewElement( viewDocument, 'img' );
  208. viewRoot._appendChild( viewImg );
  209. // This should not be changed during the render.
  210. const domImg = document.createElement( 'img' );
  211. domRoot.appendChild( domImg );
  212. domConverter.bindElements( domImg, viewImg );
  213. renderer.markToSync( 'children', viewRoot );
  214. renderer.render();
  215. expect( domRoot.childNodes.length ).to.equal( 1 );
  216. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  217. } );
  218. it( 'should change element if it is different', () => {
  219. const viewImg = new ViewElement( viewDocument, 'img' );
  220. viewRoot._appendChild( viewImg );
  221. renderer.markToSync( 'children', viewRoot );
  222. renderer.render();
  223. const viewP = new ViewElement( viewDocument, 'p' );
  224. viewRoot._removeChildren( 0, 1 );
  225. viewRoot._appendChild( viewP );
  226. renderer.markToSync( 'children', viewRoot );
  227. renderer.render();
  228. expect( domRoot.childNodes.length ).to.equal( 1 );
  229. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  230. } );
  231. it( 'should update removed item when it is reinserted', () => {
  232. const viewFoo = new ViewText( viewDocument, 'foo' );
  233. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  234. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  235. viewRoot._appendChild( viewDiv );
  236. renderer.markToSync( 'children', viewRoot );
  237. renderer.render();
  238. viewDiv._removeChildren( 0, 1 );
  239. renderer.markToSync( 'children', viewDiv );
  240. renderer.render();
  241. viewP._removeChildren( 0, 1 );
  242. viewDiv._appendChild( viewP );
  243. renderer.markToSync( 'children', viewDiv );
  244. renderer.render();
  245. expect( domRoot.childNodes.length ).to.equal( 1 );
  246. const domDiv = domRoot.childNodes[ 0 ];
  247. expect( domDiv.tagName ).to.equal( 'DIV' );
  248. expect( domDiv.childNodes.length ).to.equal( 1 );
  249. const domP = domDiv.childNodes[ 0 ];
  250. expect( domP.tagName ).to.equal( 'P' );
  251. expect( domP.childNodes.length ).to.equal( 0 );
  252. } );
  253. it( 'should update removed item when it is reinserted #2', () => {
  254. // Prepare view: root -> div "outer" -> div "inner" -> p.
  255. const viewP = new ViewElement( viewDocument, 'p' );
  256. const viewDivInner = new ViewElement( viewDocument, 'div', null, viewP );
  257. const viewDivOuter = new ViewElement( viewDocument, 'div', null, viewDivInner );
  258. viewRoot._appendChild( viewDivOuter );
  259. // Render view tree to DOM.
  260. renderer.markToSync( 'children', viewRoot );
  261. renderer.render();
  262. // Remove div "outer" from root and render it.
  263. viewDivOuter._remove();
  264. renderer.markToSync( 'children', viewRoot );
  265. renderer.render();
  266. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  267. viewP._remove();
  268. // Add div "outer" back to root.
  269. viewRoot._appendChild( viewDivOuter );
  270. renderer.markToSync( 'children', viewRoot );
  271. // Render changes, view is: root -> div "outer" -> div "inner".
  272. renderer.render();
  273. // Same is expected in DOM.
  274. expect( domRoot.childNodes.length ).to.equal( 1 );
  275. const domDivOuter = domRoot.childNodes[ 0 ];
  276. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  277. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  278. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  279. const domDivInner = domDivOuter.childNodes[ 0 ];
  280. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  281. expect( domDivInner.tagName ).to.equal( 'DIV' );
  282. expect( domDivInner.childNodes.length ).to.equal( 0 );
  283. } );
  284. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  285. const viewFoo = new ViewText( viewDocument, 'foo' );
  286. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  287. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  288. viewRoot._appendChild( viewDiv );
  289. renderer.markToSync( 'children', viewRoot );
  290. renderer.render();
  291. viewRoot._removeChildren( 0, 1 );
  292. renderer.markToSync( 'children', viewRoot );
  293. viewDiv._removeChildren( 0, 1 );
  294. renderer.markToSync( 'children', viewDiv );
  295. viewP._removeChildren( 0, 1 );
  296. renderer.markToSync( 'children', viewP );
  297. renderer.render();
  298. expect( domRoot.childNodes.length ).to.equal( 0 );
  299. } );
  300. it( 'should not care about filler if there is no DOM', () => {
  301. const { view: viewP, selection: newSelection } = parse(
  302. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  303. const viewRoot = new ViewElement( viewDocument, 'p' );
  304. viewRoot._appendChild( viewP );
  305. selection._setTo( newSelection );
  306. renderer.markToSync( 'children', viewRoot );
  307. renderer.render();
  308. // Expect no error on render.
  309. expect( viewRoot ).to.be.ok;
  310. } );
  311. it( 'should not add filler when inside contenteditable=false parent', () => {
  312. const { view: viewP, selection: newSelection } = parse(
  313. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  314. viewRoot._appendChild( viewP );
  315. selection._setTo( newSelection );
  316. renderer.markToSync( 'children', viewRoot );
  317. renderer.render();
  318. expect( domRoot.childNodes.length ).to.equal( 1 );
  319. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  320. const domP = domRoot.childNodes[ 0 ];
  321. expect( domP.childNodes.length ).to.equal( 3 );
  322. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  323. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  324. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  325. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  326. } );
  327. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  328. const { view: viewP, selection: newSelection } = parse(
  329. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  330. viewRoot._appendChild( viewP );
  331. selection._setTo( newSelection );
  332. renderer.markToSync( 'children', viewRoot );
  333. renderer.render();
  334. expect( domRoot.childNodes.length ).to.equal( 1 );
  335. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  336. const domP = domRoot.childNodes[ 0 ];
  337. expect( domP.childNodes.length ).to.equal( 3 );
  338. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  339. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  340. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  341. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  342. } );
  343. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  344. const domSelection = document.getSelection();
  345. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  346. const { view: viewP, selection: newSelection } = parse(
  347. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  348. viewRoot._appendChild( viewP );
  349. selection._setTo( newSelection );
  350. renderer.markToSync( 'children', viewRoot );
  351. renderer.render();
  352. expect( domRoot.childNodes.length ).to.equal( 1 );
  353. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  354. const domP = domRoot.childNodes[ 0 ];
  355. expect( domP.childNodes.length ).to.equal( 3 );
  356. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  357. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  358. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  359. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  360. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  361. expect( domSelection.rangeCount ).to.equal( 1 );
  362. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  363. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  364. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  365. // Step 2: No mutation on second render
  366. renderer.markToSync( 'children', viewRoot );
  367. renderer.markToSync( 'children', viewP );
  368. renderAndExpectNoChanges( renderer, domRoot );
  369. // Step 3: <p>foo{}<b></b></p>
  370. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  371. renderer.render();
  372. expect( domP.childNodes.length ).to.equal( 3 );
  373. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  374. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  375. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  376. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  377. expect( domSelection.rangeCount ).to.equal( 1 );
  378. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  379. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  380. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  381. // Step 4: No mutation on second render
  382. renderer.markToSync( 'children', viewRoot );
  383. renderer.markToSync( 'children', viewP );
  384. renderAndExpectNoChanges( renderer, domRoot );
  385. } );
  386. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  387. const domSelection = document.getSelection();
  388. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  389. const { view: viewP, selection: newSelection } = parse(
  390. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  391. viewRoot._appendChild( viewP );
  392. selection._setTo( newSelection );
  393. renderer.markToSync( 'children', viewRoot );
  394. renderer.render();
  395. const domP = domRoot.childNodes[ 0 ];
  396. expect( domP.childNodes.length ).to.equal( 2 );
  397. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  398. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  399. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  400. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  401. expect( domSelection.rangeCount ).to.equal( 1 );
  402. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  403. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  404. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  405. // Step 2: No mutation on second render
  406. renderer.markToSync( 'children', viewP );
  407. renderAndExpectNoChanges( renderer, domRoot );
  408. // Step 3: <p><b>{}foo</b></p>
  409. selection._setTo( ViewRange._createFromParentsAndOffsets(
  410. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  411. renderer.render();
  412. expect( domP.childNodes.length ).to.equal( 1 );
  413. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  414. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  415. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  416. expect( domSelection.rangeCount ).to.equal( 1 );
  417. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  418. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  419. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  420. // Step 4: No mutation on second render
  421. renderer.markToSync( 'children', viewP );
  422. renderAndExpectNoChanges( renderer, domRoot );
  423. } );
  424. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  425. const domSelection = document.getSelection();
  426. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  427. const { view: viewP, selection: newSelection } = parse(
  428. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  429. viewRoot._appendChild( viewP );
  430. selection._setTo( newSelection );
  431. renderer.markToSync( 'children', viewRoot );
  432. renderer.render();
  433. const domP = domRoot.childNodes[ 0 ];
  434. expect( domP.childNodes.length ).to.equal( 2 );
  435. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  436. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  437. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  438. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  439. expect( domSelection.rangeCount ).to.equal( 1 );
  440. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  441. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  442. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  443. // Step 2: No mutation on second render
  444. renderer.markToSync( 'children', viewP );
  445. renderAndExpectNoChanges( renderer, domRoot );
  446. // Step 3: <p><b>foo{}</b></p>
  447. selection._setTo( ViewRange._createFromParentsAndOffsets(
  448. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  449. renderer.render();
  450. expect( domP.childNodes.length ).to.equal( 1 );
  451. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  452. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  453. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  454. expect( domSelection.rangeCount ).to.equal( 1 );
  455. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  456. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  457. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  458. // Step 4: No mutation on second render
  459. renderer.markToSync( 'children', viewP );
  460. renderAndExpectNoChanges( renderer, domRoot );
  461. } );
  462. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  463. const domSelection = document.getSelection();
  464. const { view: viewP, selection: newSelection } = parse(
  465. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  466. viewRoot._appendChild( viewP );
  467. selection._setTo( newSelection );
  468. renderer.markToSync( 'children', viewRoot );
  469. renderer.render();
  470. const domP = domRoot.childNodes[ 0 ];
  471. expect( domP.childNodes.length ).to.equal( 3 );
  472. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  473. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  474. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  475. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  476. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  477. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  478. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  479. expect( domSelection.rangeCount ).to.equal( 1 );
  480. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  481. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  482. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  483. } );
  484. it( 'should move filler when selection is moved', () => {
  485. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  486. const { view: viewP, selection: newSelection } = parse(
  487. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  488. viewRoot._appendChild( viewP );
  489. selection._setTo( newSelection );
  490. renderer.markToSync( 'children', viewRoot );
  491. renderer.render();
  492. const domP = domRoot.childNodes[ 0 ];
  493. expect( domP.childNodes.length ).to.equal( 3 );
  494. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  495. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  496. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  497. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  498. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  499. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  500. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  501. const viewI = viewP.getChild( 2 );
  502. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  503. renderer.render();
  504. expect( domP.childNodes.length ).to.equal( 3 );
  505. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  506. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  507. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  508. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  509. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  510. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  511. } );
  512. it( 'should remove filler when text is added and selection removed', () => {
  513. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  514. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  515. const viewB = viewP.getChild( 1 );
  516. viewRoot._appendChild( viewP );
  517. selection._setTo( newSelection );
  518. renderer.markToSync( 'children', viewRoot );
  519. renderer.render();
  520. const domP = domRoot.childNodes[ 0 ];
  521. expect( domP.childNodes.length ).to.equal( 2 );
  522. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  523. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  524. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  525. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  526. // Step 2: Add text node.
  527. const viewText = new ViewText( viewDocument, 'x' );
  528. viewB._appendChild( viewText );
  529. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  530. renderer.markToSync( 'children', viewB );
  531. renderer.render();
  532. // Step 3: Remove selection from the view.
  533. selection._setTo( null );
  534. renderer.render();
  535. expect( domP.childNodes.length ).to.equal( 2 );
  536. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  537. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  538. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  539. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  540. } );
  541. // #659
  542. // The element before the filler is removed so the position of the filler
  543. // cannot be remembered as parent+offset.
  544. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  545. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  546. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  547. viewRoot._appendChild( viewP );
  548. selection._setTo( newSelection );
  549. renderer.markToSync( 'children', viewRoot );
  550. renderer.render();
  551. const domP = domRoot.childNodes[ 0 ];
  552. expect( domP.childNodes.length ).to.equal( 3 );
  553. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  554. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  555. viewP._removeChildren( 1 );
  556. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  557. renderer.markToSync( 'children', viewP );
  558. renderer.render();
  559. // Step 3: Check whether there's no filler in the DOM.
  560. expect( domP.childNodes.length ).to.equal( 1 );
  561. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  562. } );
  563. // #659
  564. it( 'should remove filler from a modified DOM when children moved', () => {
  565. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  566. const { view: viewFragment, selection: newSelection } = parse(
  567. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  568. );
  569. viewRoot._appendChild( viewFragment );
  570. selection._setTo( newSelection );
  571. renderer.markToSync( 'children', viewRoot );
  572. renderer.render();
  573. expect( domRoot.childNodes.length ).to.equal( 2 );
  574. const domP = domRoot.childNodes[ 0 ];
  575. const domP2 = domRoot.childNodes[ 1 ];
  576. expect( domP.childNodes.length ).to.equal( 3 );
  577. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  578. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  579. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  580. const viewP = viewRoot.getChild( 0 );
  581. const viewP2 = viewRoot.getChild( 1 );
  582. const removedChildren = viewP._removeChildren( 0, 2 );
  583. viewP2._appendChild( removedChildren );
  584. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  585. renderer.markToSync( 'children', viewP );
  586. renderer.markToSync( 'children', viewP2 );
  587. renderer.render();
  588. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  589. // in the second one there are two <b> tags.
  590. expect( domP.childNodes.length ).to.equal( 1 );
  591. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  592. expect( domP2.childNodes.length ).to.equal( 2 );
  593. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  594. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  595. } );
  596. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  597. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  598. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  599. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  600. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  601. viewRoot._appendChild( viewP );
  602. selection._setTo( newSelection );
  603. renderer.markToSync( 'children', viewRoot );
  604. renderer.render();
  605. const domP = domRoot.childNodes[ 0 ];
  606. expect( domP.childNodes.length ).to.equal( 2 );
  607. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  608. // Step 2: Move selection to a new attribute element and remove the previous one
  609. viewP._removeChildren( 1 ); // Remove <b>.
  610. const viewI = parse( '<attribute:i></attribute:i>' );
  611. viewP._appendChild( viewI );
  612. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  613. renderer.markToSync( 'children', viewP );
  614. renderer.render();
  615. // Step 3: Check whether new filler was created in the <i> element.
  616. expect( domP.childNodes.length ).to.equal( 2 );
  617. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  618. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  619. } );
  620. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  621. // that has not been yet rendered/bound to DOM.
  622. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  623. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  624. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  625. viewRoot._appendChild( viewP );
  626. selection._setTo( newSelection );
  627. renderer.markToSync( 'children', viewRoot );
  628. renderer.render();
  629. const domP = domRoot.childNodes[ 0 ];
  630. expect( domP.childNodes.length ).to.equal( 3 );
  631. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  632. // Step 2: Move selection to a new attribute element.
  633. const viewAbc = parse( 'abc' );
  634. viewP._appendChild( viewAbc );
  635. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  636. renderer.markToSync( 'children', viewP );
  637. renderer.render();
  638. // Step 3: Check whether old filler was removed.
  639. expect( domP.childNodes.length ).to.equal( 3 );
  640. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  641. } );
  642. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  643. const domSelection = document.getSelection();
  644. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  645. viewRoot._appendChild( viewP );
  646. selection._setTo( newSelection );
  647. renderer.markToSync( 'children', viewRoot );
  648. renderer.render();
  649. const domP = domRoot.childNodes[ 0 ];
  650. expect( domP.childNodes.length ).to.equal( 1 );
  651. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  652. expect( domSelection.rangeCount ).to.equal( 1 );
  653. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  654. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  655. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  656. // Remove filler and add text node to both DOM and View <p>x{}</p>
  657. domP.removeChild( domP.childNodes[ 0 ] );
  658. domP.appendChild( document.createTextNode( 'x' ) );
  659. domSelection.removeAllRanges();
  660. const domRange = document.createRange();
  661. domRange.setStart( domP.childNodes[ 0 ], 1 );
  662. domRange.collapse( true );
  663. domSelection.addRange( domRange );
  664. const viewText = new ViewText( viewDocument, 'x' );
  665. viewP._appendChild( viewText );
  666. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  667. renderer.markToSync( 'children', viewP );
  668. renderAndExpectNoChanges( renderer, domRoot );
  669. } );
  670. it( 'should handle typing in empty block, render if needed', () => {
  671. const domSelection = document.getSelection();
  672. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  673. viewRoot._appendChild( viewP );
  674. selection._setTo( newSelection );
  675. renderer.markToSync( 'children', viewRoot );
  676. renderer.render();
  677. const domP = domRoot.childNodes[ 0 ];
  678. expect( domP.childNodes.length ).to.equal( 1 );
  679. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  680. expect( domSelection.rangeCount ).to.equal( 1 );
  681. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  682. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  683. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  684. // Add text node only in View <p>x{}</p>
  685. const viewText = new ViewText( viewDocument, 'x' );
  686. viewP._appendChild( viewText );
  687. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  688. renderer.markToSync( 'children', viewP );
  689. renderer.render();
  690. expect( domP.childNodes.length ).to.equal( 1 );
  691. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  692. expect( domSelection.rangeCount ).to.equal( 1 );
  693. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  694. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  696. } );
  697. it( 'should handle removing last character', () => {
  698. const domSelection = document.getSelection();
  699. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  700. viewRoot._appendChild( viewP );
  701. selection._setTo( newSelection );
  702. renderer.markToSync( 'children', viewRoot );
  703. renderer.render();
  704. const domP = domRoot.childNodes[ 0 ];
  705. expect( domP.childNodes.length ).to.equal( 1 );
  706. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  707. expect( domSelection.rangeCount ).to.equal( 1 );
  708. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  709. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  710. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  711. // Remove text and add filler to both DOM and View <p>{}</p>
  712. domP.removeChild( domP.childNodes[ 0 ] );
  713. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  714. domSelection.removeAllRanges();
  715. const domRange = document.createRange();
  716. domRange.setStart( domP.childNodes[ 0 ], 0 );
  717. domRange.collapse( true );
  718. domSelection.addRange( domRange );
  719. viewP._removeChildren( 0 );
  720. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  721. renderer.markToSync( 'children', viewP );
  722. renderAndExpectNoChanges( renderer, domRoot );
  723. } );
  724. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  725. const domSelection = document.getSelection();
  726. // 1. Render <p><b>FILLER{}</b>foo</p>.
  727. const { view: viewP, selection: newSelection } = parse(
  728. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  729. viewRoot._appendChild( viewP );
  730. selection._setTo( newSelection );
  731. renderer.markToSync( 'children', viewRoot );
  732. renderer.render();
  733. // 2. Check the DOM.
  734. const domP = domRoot.childNodes[ 0 ];
  735. expect( domP.childNodes.length ).to.equal( 2 );
  736. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  737. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  738. const domB = domP.childNodes[ 0 ];
  739. const viewB = viewP.getChild( 0 );
  740. expect( domB.childNodes.length ).to.equal( 1 );
  741. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  742. expect( domSelection.rangeCount ).to.equal( 1 );
  743. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  744. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  745. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  746. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  747. domB.childNodes[ 0 ].data += 'x';
  748. domSelection.removeAllRanges();
  749. const domRange = document.createRange();
  750. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  751. domRange.collapse( true );
  752. domSelection.addRange( domRange );
  753. const viewText = new ViewText( viewDocument, 'x' );
  754. viewB._appendChild( viewText );
  755. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  756. renderer.markToSync( 'children', viewP );
  757. renderAndExpectNoChanges( renderer, domRoot );
  758. } );
  759. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  760. const domSelection = document.getSelection();
  761. // 1. Render <p><b>FILLER{}</b>foo</p>.
  762. const { view: viewP, selection: newSelection } = parse(
  763. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  764. viewRoot._appendChild( viewP );
  765. selection._setTo( newSelection );
  766. renderer.markToSync( 'children', viewRoot );
  767. renderer.render();
  768. // 2. Check the DOM.
  769. const domP = domRoot.childNodes[ 0 ];
  770. expect( domP.childNodes.length ).to.equal( 2 );
  771. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  772. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  773. const domB = domP.childNodes[ 0 ];
  774. const viewB = viewP.getChild( 0 );
  775. expect( domB.childNodes.length ).to.equal( 1 );
  776. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  777. expect( domSelection.rangeCount ).to.equal( 1 );
  778. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  779. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  780. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  781. domSelection.removeAllRanges();
  782. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  783. const viewText = new ViewText( viewDocument, 'x' );
  784. viewB._appendChild( viewText );
  785. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  786. renderer.markToSync( 'children', viewB );
  787. renderer.render();
  788. expect( domB.childNodes.length ).to.equal( 1 );
  789. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  790. expect( domSelection.rangeCount ).to.equal( 1 );
  791. // Depending on the browser selection may end up at the end of the text node or after the text node.
  792. const firstRange = domSelection.getRangeAt( 0 );
  793. const assertSelectionAtEndOfTextNode = () => {
  794. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  795. };
  796. const assertSelectionInsideTextNode = () => {
  797. expect( firstRange.startContainer ).to.equal( domB );
  798. expect( firstRange.startOffset ).to.equal( 1 );
  799. };
  800. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  801. expect( firstRange.collapsed ).to.be.true;
  802. } );
  803. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  804. const domSelection = document.getSelection();
  805. // 1. Render <p><b>FILLER{}</b>foo</p>.
  806. const { view: viewP, selection: newSelection } = parse(
  807. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  808. viewRoot._appendChild( viewP );
  809. selection._setTo( newSelection );
  810. renderer.markToSync( 'children', viewRoot );
  811. renderer.render();
  812. // 2. Check the DOM.
  813. const domP = domRoot.childNodes[ 0 ];
  814. expect( domP.childNodes.length ).to.equal( 2 );
  815. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  816. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  817. const domB = domP.childNodes[ 0 ];
  818. const viewB = viewP.getChild( 0 );
  819. expect( domB.childNodes.length ).to.equal( 1 );
  820. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  821. expect( domSelection.rangeCount ).to.equal( 1 );
  822. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  823. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  824. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  825. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  826. const viewText = new ViewText( viewDocument, 'x' );
  827. viewB._appendChild( viewText );
  828. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  829. renderer.markToSync( 'text', viewText );
  830. renderer.render();
  831. // 4. Check the DOM.
  832. expect( domB.childNodes.length ).to.equal( 1 );
  833. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  834. expect( domSelection.rangeCount ).to.equal( 1 );
  835. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  836. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  837. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  838. } );
  839. it( 'should handle not collapsed range', () => {
  840. const domSelection = document.getSelection();
  841. const { view: viewP, selection: newSelection } = parse(
  842. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  843. viewRoot._appendChild( viewP );
  844. selection._setTo( newSelection );
  845. renderer.markToSync( 'children', viewRoot );
  846. renderer.render();
  847. const domP = domRoot.childNodes[ 0 ];
  848. expect( domP.childNodes.length ).to.equal( 2 );
  849. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  850. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  851. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  852. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  853. expect( domSelection.rangeCount ).to.equal( 1 );
  854. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  855. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  856. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  857. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  858. renderer.markToSync( 'children', viewP );
  859. renderAndExpectNoChanges( renderer, domRoot );
  860. } );
  861. it( 'should not change selection if there is no editable with selection', () => {
  862. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  863. document.body.appendChild( domDiv );
  864. domDiv.focus();
  865. const domSelection = document.getSelection();
  866. domSelection.removeAllRanges();
  867. domSelection.collapse( domDiv, 0 );
  868. const viewDiv = new ViewElement( viewDocument, 'div' );
  869. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  870. viewDiv._appendChild( viewP );
  871. selection._setTo( newSelection );
  872. renderer.render();
  873. expect( domSelection.rangeCount ).to.equal( 1 );
  874. // Depending on the browser selection may end up before the text node or at the beginning of it.
  875. const domRange = domSelection.getRangeAt( 0 );
  876. const assertSelectionAtEndOfTextNode = () => {
  877. expect( domRange.startContainer ).to.equal( domDiv );
  878. };
  879. const assertSelectionInsideTextNode = () => {
  880. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  881. };
  882. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  883. expect( domRange.startOffset ).to.equal( 0 );
  884. expect( domRange.collapsed ).to.be.true;
  885. domDiv.remove();
  886. } );
  887. it( 'should not change selection if there is no focus', () => {
  888. const domDiv = createElement( document, 'div', null, 'not editable' );
  889. document.body.appendChild( domDiv );
  890. const domSelection = document.getSelection();
  891. domSelection.removeAllRanges();
  892. const domRange = document.createRange();
  893. domRange.setStart( domDiv, 0 );
  894. domRange.collapse( true );
  895. domSelection.addRange( domRange );
  896. renderer.isFocused = false;
  897. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  898. viewRoot._appendChild( viewP );
  899. selection._setTo( newSelection );
  900. renderer.render();
  901. expect( domSelection.rangeCount ).to.equal( 1 );
  902. // Depending on the browser selection may end up before the text node or at the beginning of it.
  903. const domSelectionRange = domSelection.getRangeAt( 0 );
  904. const assertSelectionAtEndOfTextNode = () => {
  905. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  906. };
  907. const assertSelectionInsideTextNode = () => {
  908. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  909. };
  910. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  911. expect( domSelectionRange.startOffset ).to.equal( 0 );
  912. expect( domSelectionRange.collapsed ).to.be.true;
  913. domDiv.remove();
  914. } );
  915. it( 'should not add inline filler after text node', () => {
  916. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  917. viewRoot._appendChild( viewP );
  918. selection._setTo( newSelection );
  919. renderer.markToSync( 'children', viewRoot );
  920. renderer.render();
  921. const domP = domRoot.childNodes[ 0 ];
  922. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  923. } );
  924. it( 'should throw if there is no filler in expected position', () => {
  925. const { view: viewP, selection: newSelection } = parse(
  926. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  927. viewRoot._appendChild( viewP );
  928. selection._setTo( newSelection );
  929. renderer.markToSync( 'children', viewRoot );
  930. renderer.render();
  931. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  932. const viewB = viewP.getChild( 1 );
  933. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  934. // Remove filler.
  935. domB.childNodes[ 0 ].data = '';
  936. selection._setTo( null );
  937. renderer.markToSync( 'children', viewB );
  938. expectToThrowCKEditorError( () => {
  939. renderer.render();
  940. }, /^view-renderer-filler-was-lost/, selection );
  941. } );
  942. // #1014.
  943. it( 'should create inline filler in newly created dom nodes', () => {
  944. // 1. Create the view structure which needs inline filler.
  945. const inputView =
  946. '<container:ul>' +
  947. '<container:li>Foobar.</container:li>' +
  948. '<container:li>[]<container:div></container:div></container:li>' +
  949. '</container:ul>';
  950. const { view: view, selection: newSelection } = parse( inputView );
  951. viewRoot._appendChild( view );
  952. selection._setTo( newSelection );
  953. renderer.markToSync( 'children', viewRoot );
  954. renderer.render();
  955. // 2. Check if filler element has been (correctly) created.
  956. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  957. // 3. Move the inline filler parent to a newly created element.
  958. const viewLi = view.getChild( 0 );
  959. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  960. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  961. viewLi._appendChild( viewUl );
  962. // 4. Mark changed items and render the view.
  963. renderer.markToSync( 'children', view );
  964. renderer.markToSync( 'children', viewLi );
  965. renderer.render();
  966. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  967. const domSelection = document.getSelection();
  968. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  969. } );
  970. it( 'should handle focusing element', () => {
  971. selection._setTo( viewRoot, 0 );
  972. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  973. renderer.render();
  974. expect( domFocusSpy.called ).to.be.true;
  975. } );
  976. it( 'should not focus editable if isFocues is set to false', () => {
  977. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  978. renderer.isFocused = false;
  979. renderer.render();
  980. expect( domFocusSpy.calledOnce ).to.be.false;
  981. } );
  982. it( 'should not focus already focused DOM element', () => {
  983. domRoot.setAttribute( 'contentEditable', true );
  984. domRoot.focus();
  985. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  986. renderer.render();
  987. expect( domFocusSpy.called ).to.be.false;
  988. } );
  989. it( 'should render NBSP as last space in the previous inline element', () => {
  990. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  991. viewRoot._appendChild( viewP );
  992. renderer.markToSync( 'children', viewRoot );
  993. renderer.render();
  994. const domP = domRoot.childNodes[ 0 ];
  995. const domB = domP.childNodes[ 1 ];
  996. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  997. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  998. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  999. // Insert space resulting in '<p>x <b> y</b></p>'.
  1000. const viewB = viewP.getChild( 1 );
  1001. viewB._removeChildren( 0 );
  1002. viewB._appendChild( new ViewText( viewDocument, ' y' ) );
  1003. renderer.markToSync( 'children', viewP );
  1004. renderer.render();
  1005. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1006. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1007. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1008. } );
  1009. it( 'should update sibling after, when node before is removed', () => {
  1010. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1011. viewRoot._appendChild( viewP );
  1012. renderer.markToSync( 'children', viewRoot );
  1013. renderer.render();
  1014. const domP = domRoot.childNodes[ 0 ];
  1015. const domB = domP.childNodes[ 1 ];
  1016. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1017. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1018. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1019. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1020. viewP._removeChildren( 0 );
  1021. renderer.markToSync( 'children', viewP );
  1022. renderer.render();
  1023. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1024. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1025. } );
  1026. it( 'should update sibling before, when node after is removed', () => {
  1027. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1028. viewRoot._appendChild( viewP );
  1029. renderer.markToSync( 'children', viewRoot );
  1030. renderer.render();
  1031. const domP = domRoot.childNodes[ 0 ];
  1032. const domB = domP.childNodes[ 1 ];
  1033. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1034. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1035. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1036. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1037. viewP._removeChildren( 1 );
  1038. renderer.markToSync( 'children', viewP );
  1039. renderer.render();
  1040. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1041. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1042. } );
  1043. // #1093
  1044. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1045. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1046. viewRoot._appendChild( viewP );
  1047. renderer.markToSync( 'children', viewRoot );
  1048. renderer.render();
  1049. const domP = domRoot.childNodes[ 0 ];
  1050. const domB = domP.childNodes[ 1 ];
  1051. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1052. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1053. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1054. // Insert space resulting in '<p>x <b> y</b></p>'.
  1055. viewP._removeChildren( 0 );
  1056. viewP._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1057. renderer.markToSync( 'children', viewP );
  1058. renderer.render();
  1059. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1060. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1061. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1062. } );
  1063. // #1093
  1064. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1065. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1066. viewRoot._appendChild( viewP );
  1067. renderer.markToSync( 'children', viewRoot );
  1068. renderer.render();
  1069. const domP = domRoot.childNodes[ 0 ];
  1070. const domB = domP.childNodes[ 0 ];
  1071. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1072. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1073. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1074. // Insert space resulting in '<p><b>x </b> y</p>'.
  1075. const viewB = viewP.getChild( 0 );
  1076. viewB._removeChildren( 0 );
  1077. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1078. renderer.markToSync( 'children', viewP );
  1079. renderer.render();
  1080. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1081. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1082. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b> y' );
  1083. } );
  1084. // #1093
  1085. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1086. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1087. viewRoot._appendChild( viewP );
  1088. renderer.markToSync( 'children', viewRoot );
  1089. renderer.render();
  1090. const domP = domRoot.childNodes[ 0 ];
  1091. const domB = domP.childNodes[ 0 ];
  1092. const domI = domP.childNodes[ 1 ];
  1093. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1094. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1095. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1096. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1097. const viewB = viewP.getChild( 0 );
  1098. viewB._removeChildren( 0 );
  1099. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1100. renderer.markToSync( 'children', viewP );
  1101. renderer.render();
  1102. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1103. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1104. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b><i> y</i>' );
  1105. } );
  1106. // #1125
  1107. it( 'should properly rerender many changes done in one batch', () => {
  1108. // This test transforms:
  1109. //
  1110. // <h2>He<strong>ding 1</strong></h2>
  1111. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1112. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1113. //
  1114. // into:
  1115. //
  1116. // <h2>Heading 2</h2>
  1117. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1118. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1119. //
  1120. // during one rerender to check if complex structure changes are rerendered correctly.
  1121. const viewContent = parse( '' +
  1122. '<container:h2>He' +
  1123. '<attribute:i>ading 1</attribute:i>' +
  1124. '</container:h2>' +
  1125. '<container:p>Ph ' +
  1126. '<attribute:strong>Bold</attribute:strong> ' +
  1127. '<attribute:i>It' +
  1128. '<attribute:strong>alic</attribute:strong>' +
  1129. '</attribute:i> ' +
  1130. '<attribute:a href="https://ckeditor.com">' +
  1131. '<attribute:strong>Lin</attribute:strong>' +
  1132. 'k</attribute:a>' +
  1133. '</container:p>' +
  1134. '<container:blockquote>' +
  1135. '<container:ul>' +
  1136. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1137. '</container:ul>' +
  1138. '</container:blockquote>' );
  1139. viewRoot._appendChild( viewContent );
  1140. renderer.markToSync( 'children', viewRoot );
  1141. renderer.render();
  1142. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1143. const viewHeading = viewRoot.getChild( 0 );
  1144. viewHeading._removeChildren( 0, viewHeading.childCount );
  1145. viewHeading._insertChild( 0, new ViewText( viewDocument, 'Heading 2' ) );
  1146. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1147. renderer.markToSync( 'children', viewRoot );
  1148. renderer.markToSync( 'children', viewHeading );
  1149. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1150. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1151. // ->
  1152. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1153. const viewP = viewRoot.getChild( 1 );
  1154. viewP._removeChildren( 0, viewP.childCount );
  1155. viewP._insertChild(
  1156. 0,
  1157. parse(
  1158. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1159. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1160. )
  1161. );
  1162. renderer.markToSync( 'children', viewRoot );
  1163. renderer.markToSync( 'children', viewP );
  1164. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1165. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1166. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1167. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1168. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1169. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1170. const viewBq = viewRoot.getChild( 2 );
  1171. viewBq._removeChildren( 0, viewBq.childCount );
  1172. viewBq._insertChild(
  1173. 0,
  1174. parse(
  1175. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1176. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1177. )
  1178. );
  1179. renderer.markToSync( 'children', viewRoot );
  1180. renderer.markToSync( 'children', viewBq );
  1181. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1182. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1183. renderer.render();
  1184. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1185. '<h2>Heading 2</h2>' +
  1186. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1187. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1188. );
  1189. } );
  1190. // #1125
  1191. it( 'should properly rerender changes when whole content replaced at once', () => {
  1192. // This test replaces:
  1193. //
  1194. // <h1>Header</h1>
  1195. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1196. //
  1197. // with:
  1198. //
  1199. // <h2>Header</h2>
  1200. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1201. //
  1202. // during one rerender to check if complex structure changes are rerendered correctly.
  1203. const viewContent = parse(
  1204. '<container:h1>Header</container:h1>' +
  1205. '<container:blockquote>' +
  1206. '<container:ul>' +
  1207. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1208. '<container:li>Item 2</container:li>' +
  1209. '</container:ul>' +
  1210. '</container:blockquote>'
  1211. );
  1212. viewRoot._appendChild( viewContent );
  1213. renderer.markToSync( 'children', viewRoot );
  1214. renderer.render();
  1215. const newViewContent = parse(
  1216. '<container:h2>Header</container:h2>' +
  1217. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1218. );
  1219. viewRoot._removeChildren( 0, viewRoot.childCount );
  1220. viewRoot._appendChild( newViewContent );
  1221. renderer.markToSync( 'children', viewRoot );
  1222. renderer.render();
  1223. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1224. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1225. );
  1226. } );
  1227. // #1451
  1228. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1229. const inputView =
  1230. '<container:ul>' +
  1231. '<container:li>Foo</container:li>' +
  1232. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1233. '</container:ul>';
  1234. const view = parse( inputView );
  1235. viewRoot._appendChild( view );
  1236. renderer.markToSync( 'children', viewRoot );
  1237. renderer.render();
  1238. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1239. const viewLi = view.getChild( 0 );
  1240. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1241. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1242. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  1243. viewLi._appendChild( viewUl );
  1244. renderer.markToSync( 'children', view );
  1245. renderer.markToSync( 'children', viewLi );
  1246. renderer.render();
  1247. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1248. } );
  1249. // #1439
  1250. it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
  1251. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1252. testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
  1253. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1254. // <p>foo<br/>[]</p>
  1255. const { view: viewP, selection: newSelection } = parse(
  1256. '<container:p>' +
  1257. 'foo[]' +
  1258. '<empty:br></empty:br>[]' +
  1259. '</container:p>' );
  1260. viewRoot._appendChild( viewP );
  1261. selection._setTo( newSelection );
  1262. renderer.markToSync( 'children', viewRoot );
  1263. renderer.render();
  1264. sinon.assert.notCalled( spy );
  1265. } );
  1266. // #1439
  1267. it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
  1268. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1269. testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
  1270. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1271. // <p>foo[]<b>bar</b></p>
  1272. let { view: viewP, selection: newSelection } = parse(
  1273. '<container:p>' +
  1274. 'foo[]' +
  1275. '<attribute:b>bar</attribute:b>' +
  1276. '</container:p>' );
  1277. viewRoot._appendChild( viewP );
  1278. selection._setTo( newSelection );
  1279. renderer.markToSync( 'children', viewRoot );
  1280. renderer.render();
  1281. sinon.assert.notCalled( spy );
  1282. // <p>foo<b>bar</b></p><p>foo[]<br/></p>
  1283. ( { view: viewP, selection: newSelection } = parse(
  1284. '<container:p>' +
  1285. 'foo[]' +
  1286. '<empty:br></empty:br>' +
  1287. '</container:p>' ) );
  1288. viewRoot._appendChild( viewP );
  1289. selection._setTo( newSelection );
  1290. renderer.markToSync( 'children', viewRoot );
  1291. renderer.render();
  1292. sinon.assert.notCalled( spy );
  1293. // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
  1294. selection._setTo( [
  1295. new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
  1296. ] );
  1297. renderer.markToSync( 'children', viewRoot );
  1298. renderer.render();
  1299. sinon.assert.calledOnce( spy );
  1300. } );
  1301. describe( 'fake selection', () => {
  1302. beforeEach( () => {
  1303. const { view: viewP, selection: newSelection } = parse(
  1304. '<container:p>[foo bar]</container:p>'
  1305. );
  1306. viewRoot._appendChild( viewP );
  1307. selection._setTo( newSelection );
  1308. renderer.markToSync( 'children', viewRoot );
  1309. renderer.render();
  1310. } );
  1311. it( 'should render fake selection', () => {
  1312. const label = 'fake selection label';
  1313. selection._setTo( selection.getRanges(), { fake: true, label } );
  1314. renderer.render();
  1315. expect( domRoot.childNodes.length ).to.equal( 2 );
  1316. const container = domRoot.childNodes[ 1 ];
  1317. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1318. expect( container.childNodes.length ).to.equal( 1 );
  1319. const textNode = container.childNodes[ 0 ];
  1320. expect( textNode.textContent ).to.equal( label );
  1321. const domSelection = domRoot.ownerDocument.getSelection();
  1322. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1323. } );
  1324. describe( 'subsequent call optimization', () => {
  1325. // https://github.com/ckeditor/ckeditor5-engine/issues/1791
  1326. it( 'doesn\'t render the same selection multiple times', () => {
  1327. const createRangeSpy = sinon.spy( document, 'createRange' );
  1328. const label = 'subsequent fake selection calls';
  1329. selection._setTo( selection.getRanges(), { fake: true, label } );
  1330. renderer.render();
  1331. selection._setTo( selection.getRanges(), { fake: true, label } );
  1332. renderer.render();
  1333. expect( createRangeSpy.callCount ).to.be.equal( 1 );
  1334. } );
  1335. it( 'different subsequent fake selections sets do change native selection', () => {
  1336. const createRangeSpy = sinon.spy( document, 'createRange' );
  1337. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 1' } );
  1338. renderer.render();
  1339. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 2' } );
  1340. renderer.render();
  1341. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1342. } );
  1343. it( 'rerenders selection if disturbed externally', () => {
  1344. const interruptingRange = document.createRange();
  1345. interruptingRange.setStartBefore( domRoot.children[ 0 ] );
  1346. interruptingRange.setEndAfter( domRoot.children[ 0 ] );
  1347. const createRangeSpy = sinon.spy( document, 'createRange' );
  1348. const label = 'selection 1';
  1349. selection._setTo( selection.getRanges(), { fake: true, label } );
  1350. renderer.render();
  1351. document.getSelection().removeAllRanges();
  1352. document.getSelection().addRange( interruptingRange );
  1353. selection._setTo( selection.getRanges(), { fake: true, label } );
  1354. renderer.render();
  1355. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1356. } );
  1357. it( 'correctly maps fake selection ', () => {
  1358. // See https://github.com/ckeditor/ckeditor5-engine/pull/1792#issuecomment-529814641
  1359. const label = 'subsequent fake selection calls';
  1360. const { view: newParagraph, selection: newSelection } = parse( '<container:p>[baz]</container:p>' );
  1361. viewRoot._appendChild( newParagraph );
  1362. selection._setTo( selection.getRanges(), { fake: true, label } );
  1363. renderer.render();
  1364. selection._setTo( newSelection.getRanges(), { fake: true, label } );
  1365. renderer.render();
  1366. const fakeSelectionContainer = domRoot.childNodes[ 1 ];
  1367. const mappedSelection = renderer.domConverter.fakeSelectionToView( fakeSelectionContainer );
  1368. expect( stringify( viewRoot, mappedSelection ) ).to.be.equal( '<div><p>foo bar</p><p>[baz]</p></div>' );
  1369. } );
  1370. } );
  1371. it( 'should render &nbsp; if no selection label is provided', () => {
  1372. selection._setTo( selection.getRanges(), { fake: true } );
  1373. renderer.render();
  1374. expect( domRoot.childNodes.length ).to.equal( 2 );
  1375. const container = domRoot.childNodes[ 1 ];
  1376. expect( container.childNodes.length ).to.equal( 1 );
  1377. const textNode = container.childNodes[ 0 ];
  1378. expect( textNode.textContent ).to.equal( '\u00A0' );
  1379. const domSelection = domRoot.ownerDocument.getSelection();
  1380. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1381. } );
  1382. it( 'should remove fake selection container when selection is no longer fake', () => {
  1383. selection._setTo( selection.getRanges(), { fake: true } );
  1384. renderer.render();
  1385. selection._setTo( selection.getRanges(), { fake: false } );
  1386. renderer.render();
  1387. expect( domRoot.childNodes.length ).to.equal( 1 );
  1388. const domParagraph = domRoot.childNodes[ 0 ];
  1389. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1390. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1391. const domSelection = domRoot.ownerDocument.getSelection();
  1392. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1393. } );
  1394. it( 'should reuse fake selection container #1', () => {
  1395. const label = 'fake selection label';
  1396. selection._setTo( selection.getRanges(), { fake: true, label } );
  1397. renderer.render();
  1398. expect( domRoot.childNodes.length ).to.equal( 2 );
  1399. const container = domRoot.childNodes[ 1 ];
  1400. selection._setTo( selection.getRanges(), { fake: true, label } );
  1401. renderer.render();
  1402. expect( domRoot.childNodes.length ).to.equal( 2 );
  1403. const newContainer = domRoot.childNodes[ 1 ];
  1404. expect( newContainer ).equals( container );
  1405. expect( newContainer.childNodes.length ).to.equal( 1 );
  1406. const textNode = newContainer.childNodes[ 0 ];
  1407. expect( textNode.textContent ).to.equal( label );
  1408. } );
  1409. it( 'should reuse fake selection container #2', () => {
  1410. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1411. renderer.render();
  1412. expect( domRoot.childNodes.length ).to.equal( 2 );
  1413. const container = domRoot.childNodes[ 1 ];
  1414. selection._setTo( selection.getRanges(), { fake: false } );
  1415. renderer.render();
  1416. expect( domRoot.childNodes.length ).to.equal( 1 );
  1417. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1418. renderer.render();
  1419. expect( domRoot.childNodes.length ).to.equal( 2 );
  1420. const newContainer = domRoot.childNodes[ 1 ];
  1421. expect( newContainer ).equals( container );
  1422. expect( newContainer.childNodes.length ).to.equal( 1 );
  1423. const textNode = newContainer.childNodes[ 0 ];
  1424. expect( textNode.textContent ).to.equal( 'label 2' );
  1425. } );
  1426. it( 'should reuse fake selection container #3', () => {
  1427. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1428. renderer.render();
  1429. expect( domRoot.childNodes.length ).to.equal( 2 );
  1430. const container = domRoot.childNodes[ 1 ];
  1431. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1432. renderer.render();
  1433. expect( domRoot.childNodes.length ).to.equal( 2 );
  1434. const newContainer = domRoot.childNodes[ 1 ];
  1435. expect( newContainer ).equals( container );
  1436. expect( newContainer.childNodes.length ).to.equal( 1 );
  1437. const textNode = newContainer.childNodes[ 0 ];
  1438. expect( textNode.textContent ).to.equal( 'label 2' );
  1439. } );
  1440. it( 'should style fake selection container properly', () => {
  1441. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1442. renderer.render();
  1443. expect( domRoot.childNodes.length ).to.equal( 2 );
  1444. const container = domRoot.childNodes[ 1 ];
  1445. expect( container.style.position ).to.equal( 'fixed' );
  1446. expect( container.style.top ).to.equal( '0px' );
  1447. expect( container.style.left ).to.equal( '-9999px' );
  1448. } );
  1449. it( 'should move fake selection container between editables', () => {
  1450. const viewEditable = new ViewEditableElement( viewDocument, 'div' );
  1451. viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
  1452. const domEditable = document.createElement( 'div' );
  1453. document.body.appendChild( domEditable );
  1454. domConverter.bindElements( domEditable, viewEditable );
  1455. renderer.markToSync( 'children', viewEditable );
  1456. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1457. renderer.render();
  1458. let container = document.getSelection().anchorNode;
  1459. expect( domRoot.contains( container ) ).to.be.true;
  1460. selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
  1461. renderer.render();
  1462. container = document.getSelection().anchorNode;
  1463. expect( domEditable.contains( container ) ).to.be.true;
  1464. domEditable.remove();
  1465. } );
  1466. it( 'should bind fake selection container to view selection', () => {
  1467. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1468. renderer.render();
  1469. expect( domRoot.childNodes.length ).to.equal( 2 );
  1470. const container = domRoot.childNodes[ 1 ];
  1471. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1472. expect( bindSelection ).to.not.be.undefined;
  1473. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1474. } );
  1475. // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
  1476. it( 'should handle situation when label got removed from the fake selection container', () => {
  1477. const label = 'fake selection label';
  1478. selection._setTo( selection.getRanges(), { fake: true, label } );
  1479. renderer.render();
  1480. expect( domRoot.childNodes.length ).to.equal( 2 );
  1481. const container = domRoot.childNodes[ 1 ];
  1482. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1483. expect( container.childNodes.length ).to.equal( 1 );
  1484. const textNode = container.childNodes[ 0 ];
  1485. expect( textNode.textContent ).to.equal( label );
  1486. // Remove a text node (label) from the fake selection container.
  1487. // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
  1488. textNode.remove();
  1489. renderer.render();
  1490. const domSelection = domRoot.ownerDocument.getSelection();
  1491. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1492. } );
  1493. // Use a forgiving way of checking what the selection contains
  1494. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1495. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1496. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1497. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1498. expect( domSelection.toString() ).to.match( expectedText );
  1499. expect(
  1500. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1501. ).to.be.true;
  1502. }
  1503. } );
  1504. // #887
  1505. describe( 'similar selection', () => {
  1506. // Use spies to check selection updates. Some selection positions are not achievable in some
  1507. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1508. let selectionCollapseSpy, selectionExtendSpy;
  1509. afterEach( () => {
  1510. if ( selectionCollapseSpy ) {
  1511. selectionCollapseSpy.restore();
  1512. selectionCollapseSpy = null;
  1513. }
  1514. if ( selectionExtendSpy ) {
  1515. selectionExtendSpy.restore();
  1516. selectionExtendSpy = null;
  1517. }
  1518. } );
  1519. it( 'should always render collapsed selection even if it is similar', () => {
  1520. const domSelection = document.getSelection();
  1521. const { view: viewP, selection: newSelection } = parse(
  1522. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1523. viewRoot._appendChild( viewP );
  1524. selection._setTo( newSelection );
  1525. renderer.markToSync( 'children', viewRoot );
  1526. renderer.render();
  1527. const domP = domRoot.childNodes[ 0 ];
  1528. const domB = domP.childNodes[ 1 ];
  1529. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1530. expect( domSelection.isCollapsed ).to.true;
  1531. expect( domSelection.rangeCount ).to.equal( 1 );
  1532. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1533. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1534. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1535. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1536. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1537. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1538. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1539. selection._setTo( [
  1540. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1541. ] );
  1542. renderer.markToSync( 'children', viewP );
  1543. renderer.render();
  1544. expect( selectionCollapseSpy.calledOnce ).to.true;
  1545. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1546. expect( selectionExtendSpy.calledOnce ).to.true;
  1547. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1548. } );
  1549. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1550. const domSelection = document.getSelection();
  1551. const { view: viewP, selection: newSelection } = parse(
  1552. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1553. viewRoot._appendChild( viewP );
  1554. selection._setTo( newSelection );
  1555. renderer.markToSync( 'children', viewRoot );
  1556. renderer.render();
  1557. const domP = domRoot.childNodes[ 0 ];
  1558. const domB = domP.childNodes[ 1 ];
  1559. expect( domSelection.isCollapsed ).to.true;
  1560. expect( domSelection.rangeCount ).to.equal( 1 );
  1561. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1562. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1563. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1564. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1565. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1566. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1567. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1568. selection._setTo( [
  1569. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1570. ] );
  1571. renderer.markToSync( 'children', viewP );
  1572. renderer.render();
  1573. expect( selectionCollapseSpy.calledOnce ).to.true;
  1574. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1575. expect( selectionExtendSpy.calledOnce ).to.true;
  1576. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1577. } );
  1578. it( 'should always render non-collapsed selection if it not is similar', () => {
  1579. const domSelection = document.getSelection();
  1580. const { view: viewP, selection: newSelection } = parse(
  1581. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1582. viewRoot._appendChild( viewP );
  1583. selection._setTo( newSelection );
  1584. renderer.markToSync( 'children', viewRoot );
  1585. renderer.render();
  1586. const domP = domRoot.childNodes[ 0 ];
  1587. const domB = domP.childNodes[ 1 ];
  1588. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1589. expect( domSelection.isCollapsed ).to.false;
  1590. expect( domSelection.rangeCount ).to.equal( 1 );
  1591. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1592. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1593. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1594. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1595. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1596. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1597. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1598. selection._setTo( [
  1599. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1600. ] );
  1601. renderer.markToSync( 'children', viewP );
  1602. renderer.render();
  1603. expect( selectionCollapseSpy.calledOnce ).to.true;
  1604. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1605. expect( selectionExtendSpy.calledOnce ).to.true;
  1606. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1607. } );
  1608. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1609. const domSelection = document.getSelection();
  1610. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1611. viewRoot._appendChild( viewP );
  1612. selection._setTo( newSelection );
  1613. renderer.markToSync( 'children', viewRoot );
  1614. renderer.render();
  1615. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1616. // Do not change view selection.
  1617. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1618. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1619. // because DOM selection is in incorrect place.
  1620. const domP = domRoot.childNodes[ 0 ];
  1621. const domSpan = domP.childNodes[ 1 ];
  1622. domSelection.collapse( domSpan, 0 );
  1623. renderer.render();
  1624. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1625. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1626. const assertSelectionAtEndOfTextNode = () => {
  1627. expect( domSelection.anchorNode ).to.equal( domP );
  1628. expect( domSelection.anchorOffset ).to.equal( 1 );
  1629. };
  1630. const assertSelectionInsideTextNode = () => {
  1631. const textNode = domP.childNodes[ 0 ];
  1632. expect( domSelection.anchorNode ).to.equal( textNode );
  1633. expect( domSelection.anchorOffset ).to.equal( 3 );
  1634. };
  1635. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1636. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1637. } );
  1638. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1639. const domSelection = document.getSelection();
  1640. const { view: viewP, selection: newSelection } = parse(
  1641. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1642. viewRoot._appendChild( viewP );
  1643. selection._setTo( newSelection );
  1644. renderer.markToSync( 'children', viewRoot );
  1645. renderer.render();
  1646. const domP = domRoot.childNodes[ 0 ];
  1647. const domB = domP.childNodes[ 1 ];
  1648. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1649. expect( domSelection.isCollapsed ).to.false;
  1650. expect( domSelection.rangeCount ).to.equal( 1 );
  1651. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1652. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1653. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1654. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1655. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1656. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1657. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1658. selection._setTo( [
  1659. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1660. ] );
  1661. renderer.markToSync( 'children', viewP );
  1662. renderer.render();
  1663. expect( selectionCollapseSpy.notCalled ).to.true;
  1664. expect( selectionExtendSpy.notCalled ).to.true;
  1665. } );
  1666. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1667. const domSelection = document.getSelection();
  1668. const { view: viewP, selection: newSelection } = parse(
  1669. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1670. viewRoot._appendChild( viewP );
  1671. selection._setTo( newSelection );
  1672. renderer.markToSync( 'children', viewRoot );
  1673. renderer.render();
  1674. const domP = domRoot.childNodes[ 0 ];
  1675. const domB = domP.childNodes[ 1 ];
  1676. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1677. expect( domSelection.isCollapsed ).to.false;
  1678. expect( domSelection.rangeCount ).to.equal( 1 );
  1679. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1680. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1681. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1682. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1683. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1684. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1685. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1686. selection._setTo( [
  1687. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1688. ] );
  1689. renderer.markToSync( 'children', viewP );
  1690. renderer.render();
  1691. expect( selectionCollapseSpy.notCalled ).to.true;
  1692. expect( selectionExtendSpy.notCalled ).to.true;
  1693. } );
  1694. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1695. const domSelection = document.getSelection();
  1696. const { view: viewP, selection: newSelection } = parse(
  1697. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1698. viewRoot._appendChild( viewP );
  1699. selection._setTo( newSelection );
  1700. renderer.markToSync( 'children', viewRoot );
  1701. renderer.render();
  1702. const domP = domRoot.childNodes[ 0 ];
  1703. const domB = domP.childNodes[ 1 ];
  1704. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1705. expect( domSelection.isCollapsed ).to.false;
  1706. expect( domSelection.rangeCount ).to.equal( 1 );
  1707. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1708. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1709. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1710. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1711. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1712. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1713. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1714. selection._setTo( [
  1715. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1716. ] );
  1717. renderer.markToSync( 'children', viewP );
  1718. renderer.render();
  1719. expect( selectionCollapseSpy.notCalled ).to.true;
  1720. expect( selectionExtendSpy.notCalled ).to.true;
  1721. } );
  1722. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1723. const domSelection = document.getSelection();
  1724. const { view: viewP, selection: newSelection } = parse(
  1725. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1726. viewRoot._appendChild( viewP );
  1727. selection._setTo( newSelection );
  1728. renderer.markToSync( 'children', viewRoot );
  1729. renderer.render();
  1730. const domP = domRoot.childNodes[ 0 ];
  1731. const domB = domP.childNodes[ 1 ];
  1732. expect( domSelection.isCollapsed ).to.false;
  1733. expect( domSelection.rangeCount ).to.equal( 1 );
  1734. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1735. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1736. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1737. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1738. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1739. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1740. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1741. selection._setTo( [
  1742. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1743. ] );
  1744. renderer.markToSync( 'children', viewP );
  1745. renderer.render();
  1746. expect( selectionCollapseSpy.notCalled ).to.true;
  1747. expect( selectionExtendSpy.notCalled ).to.true;
  1748. } );
  1749. } );
  1750. // #1417
  1751. describe( 'optimal rendering – reusing existing nodes', () => {
  1752. it( 'should render inline element replacement (before text)', () => {
  1753. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1754. renderer.markToSync( 'children', viewRoot );
  1755. renderer.render();
  1756. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1757. const viewP = viewRoot.getChild( 0 );
  1758. viewP._removeChildren( 0, 2 );
  1759. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1760. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1761. renderer.markToSync( 'children', viewRoot );
  1762. renderer.markToSync( 'children', viewP );
  1763. renderer.render();
  1764. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1765. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1766. } );
  1767. it( 'should render inline element replacement (after text)', () => {
  1768. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1769. renderer.markToSync( 'children', viewRoot );
  1770. renderer.render();
  1771. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1772. const viewP = viewRoot.getChild( 0 );
  1773. viewP._removeChildren( 0, 2 );
  1774. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1775. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1776. renderer.markToSync( 'children', viewRoot );
  1777. renderer.markToSync( 'children', viewP );
  1778. renderer.render();
  1779. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1780. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1781. } );
  1782. it( 'should render inline element replacement (before text swapped order)', () => {
  1783. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1784. renderer.markToSync( 'children', viewRoot );
  1785. renderer.render();
  1786. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1787. const viewP = viewRoot.getChild( 0 );
  1788. viewP._removeChildren( 0, 2 );
  1789. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1790. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1791. renderer.markToSync( 'children', viewRoot );
  1792. renderer.markToSync( 'children', viewP );
  1793. renderer.render();
  1794. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1795. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1796. } );
  1797. it( 'should render inline element replacement (after text swapped order)', () => {
  1798. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1799. renderer.markToSync( 'children', viewRoot );
  1800. renderer.render();
  1801. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1802. const viewP = viewRoot.getChild( 0 );
  1803. viewP._removeChildren( 0, 2 );
  1804. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1805. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1806. renderer.markToSync( 'children', viewRoot );
  1807. renderer.markToSync( 'children', viewP );
  1808. renderer.render();
  1809. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1810. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1811. } );
  1812. it( 'should render single replacement in p group', () => {
  1813. const content = '' +
  1814. '<container:p>1</container:p>' +
  1815. '<container:p>2</container:p>' +
  1816. '<container:p>3</container:p>';
  1817. viewRoot._appendChild( parse( content ) );
  1818. renderer.markToSync( 'children', viewRoot );
  1819. renderer.render();
  1820. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1821. viewRoot._removeChildren( 1 );
  1822. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1823. const domP = domRoot.childNodes[ 1 ];
  1824. renderer.markToSync( 'children', viewRoot );
  1825. renderer.render();
  1826. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1827. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1828. } );
  1829. it( 'should render replacement and insertion in p group', () => {
  1830. const content = '' +
  1831. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1832. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1833. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1834. const replacement = '' +
  1835. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1836. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1837. viewRoot._appendChild( parse( content ) );
  1838. renderer.markToSync( 'children', viewRoot );
  1839. renderer.render();
  1840. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1841. viewRoot._removeChildren( 1 );
  1842. viewRoot._insertChild( 1, parse( replacement ) );
  1843. const domP2 = domRoot.childNodes[ 1 ];
  1844. const domP3 = domRoot.childNodes[ 2 ];
  1845. renderer.markToSync( 'children', viewRoot );
  1846. renderer.render();
  1847. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1848. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1849. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1850. } );
  1851. it( 'should render replacement and deletion in p group', () => {
  1852. const content = '' +
  1853. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1854. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1855. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1856. viewRoot._appendChild( parse( content ) );
  1857. renderer.markToSync( 'children', viewRoot );
  1858. renderer.render();
  1859. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1860. viewRoot._removeChildren( 0, 2 );
  1861. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1862. const domP0 = domRoot.childNodes[ 0 ];
  1863. const domP2 = domRoot.childNodes[ 2 ];
  1864. renderer.markToSync( 'children', viewRoot );
  1865. renderer.render();
  1866. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1867. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1868. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1869. } );
  1870. it( 'should render multiple continuous replacement in p group', () => {
  1871. const content = '' +
  1872. '<container:p>1</container:p>' +
  1873. '<container:p>2</container:p>' +
  1874. '<container:p>3</container:p>' +
  1875. '<container:p>4</container:p>' +
  1876. '<container:p>5</container:p>';
  1877. viewRoot._appendChild( parse( content ) );
  1878. renderer.markToSync( 'children', viewRoot );
  1879. renderer.render();
  1880. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1881. viewRoot._removeChildren( 0, 3 );
  1882. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1883. const domP1 = domRoot.childNodes[ 0 ];
  1884. const domP2 = domRoot.childNodes[ 1 ];
  1885. const domP4 = domRoot.childNodes[ 3 ];
  1886. const domP5 = domRoot.childNodes[ 4 ];
  1887. renderer.markToSync( 'children', viewRoot );
  1888. renderer.render();
  1889. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1890. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1891. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1892. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1893. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1894. } );
  1895. it( 'should render multiple replacement in p group', () => {
  1896. const content = '' +
  1897. '<container:p>1</container:p>' +
  1898. '<container:p>2</container:p>' +
  1899. '<container:p>3</container:p>' +
  1900. '<container:p>4</container:p>' +
  1901. '<container:p>5</container:p>';
  1902. viewRoot._appendChild( parse( content ) );
  1903. renderer.markToSync( 'children', viewRoot );
  1904. renderer.render();
  1905. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1906. viewRoot._removeChildren( 4 );
  1907. viewRoot._removeChildren( 1, 2 );
  1908. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1909. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1910. const domP1 = domRoot.childNodes[ 0 ];
  1911. const domP2 = domRoot.childNodes[ 1 ];
  1912. const domP4 = domRoot.childNodes[ 3 ];
  1913. const domP5 = domRoot.childNodes[ 4 ];
  1914. renderer.markToSync( 'children', viewRoot );
  1915. renderer.render();
  1916. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1917. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1918. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1919. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1920. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1921. } );
  1922. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1923. const content = '' +
  1924. '<container:h2>He' +
  1925. '<attribute:i>ading 1</attribute:i>' +
  1926. '</container:h2>' +
  1927. '<container:p>Ph ' +
  1928. '<attribute:strong>Bold</attribute:strong>' +
  1929. '<attribute:a href="https://ckeditor.com">' +
  1930. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1931. '</attribute:a>' +
  1932. '</container:p>' +
  1933. '<container:blockquote>' +
  1934. '<container:ul>' +
  1935. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1936. '</container:ul>' +
  1937. '</container:blockquote>';
  1938. viewRoot._appendChild( parse( content ) );
  1939. renderer.markToSync( 'children', viewRoot );
  1940. renderer.render();
  1941. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1942. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1943. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1944. viewRoot._removeChildren( 0, viewRoot.childCount );
  1945. viewRoot._appendChild( parse( content ) );
  1946. const viewH = viewRoot.getChild( 0 );
  1947. const viewP = viewRoot.getChild( 1 );
  1948. const viewQ = viewRoot.getChild( 2 );
  1949. const domH = domRoot.childNodes[ 0 ];
  1950. const domHI = domH.childNodes[ 1 ];
  1951. const domP = domRoot.childNodes[ 1 ];
  1952. const domPT = domP.childNodes[ 0 ];
  1953. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1954. const domQ = domRoot.childNodes[ 2 ];
  1955. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1956. renderer.markToSync( 'children', viewRoot );
  1957. renderer.render();
  1958. // Assert content.
  1959. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1960. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1961. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1962. // Assert if DOM elements did not change.
  1963. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1964. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1965. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1966. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1967. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1968. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1969. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1970. // Assert mappings.
  1971. const mappings = renderer.domConverter._domToViewMapping;
  1972. expect( mappings.get( domH ) ).to.equal( viewH );
  1973. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1974. expect( mappings.get( domP ) ).to.equal( viewP );
  1975. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1976. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1977. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1978. } );
  1979. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1980. const content = '' +
  1981. '<container:h2>He' +
  1982. '<attribute:i>ading 1</attribute:i>' +
  1983. '</container:h2>' +
  1984. '<container:p>Ph ' +
  1985. '<attribute:strong>Bold</attribute:strong>' +
  1986. '<attribute:a href="https://ckeditor.com">' +
  1987. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1988. '</attribute:a>' +
  1989. '</container:p>' +
  1990. '<container:blockquote>' +
  1991. '<container:ul>' +
  1992. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1993. '</container:ul>' +
  1994. '</container:blockquote>';
  1995. const content2 = '' +
  1996. '<container:p>Ph ' +
  1997. '<attribute:strong>Bold</attribute:strong>' +
  1998. '<attribute:a href="https://ckeditor.com">' +
  1999. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2000. '</attribute:a>' +
  2001. '</container:p>' +
  2002. '<container:blockquote>' +
  2003. '<container:ul>' +
  2004. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2005. '</container:ul>' +
  2006. '</container:blockquote>';
  2007. viewRoot._appendChild( parse( content ) );
  2008. renderer.markToSync( 'children', viewRoot );
  2009. renderer.render();
  2010. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  2011. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2012. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2013. viewRoot._removeChildren( 0, viewRoot.childCount );
  2014. viewRoot._appendChild( parse( content2 ) );
  2015. const viewP = viewRoot.getChild( 0 );
  2016. const viewQ = viewRoot.getChild( 1 );
  2017. const domP = domRoot.childNodes[ 1 ];
  2018. const domPT = domP.childNodes[ 0 ];
  2019. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  2020. const domQ = domRoot.childNodes[ 2 ];
  2021. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  2022. renderer.markToSync( 'children', viewRoot );
  2023. renderer.render();
  2024. // Assert content.
  2025. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  2026. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2027. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2028. // Assert if DOM elements did not change.
  2029. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2030. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  2031. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  2032. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  2033. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  2034. // Assert mappings.
  2035. const mappings = renderer.domConverter._domToViewMapping;
  2036. expect( mappings.get( domP ) ).to.equal( viewP );
  2037. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  2038. expect( mappings.get( domQ ) ).to.equal( viewQ );
  2039. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2040. } );
  2041. it( 'should not rerender DOM when typing inside empty inline element', () => {
  2042. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  2043. viewRoot._appendChild( view );
  2044. renderer.markToSync( 'children', viewRoot );
  2045. renderer.render();
  2046. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  2047. const viewP = viewRoot.getChild( 0 );
  2048. viewP._removeChildren( 1 );
  2049. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  2050. const domP = domRoot.childNodes[ 0 ];
  2051. const domText = domP.childNodes[ 0 ];
  2052. const domB = domP.childNodes[ 1 ];
  2053. domB.innerHTML = 'a';
  2054. renderer.markToSync( 'children', viewRoot );
  2055. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  2056. renderer.render();
  2057. // Assert content.
  2058. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  2059. // Assert if DOM elements did not change.
  2060. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2061. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  2062. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  2063. // Assert mappings.
  2064. const mappings = renderer.domConverter._domToViewMapping;
  2065. expect( mappings.get( domP ) ).to.equal( viewP );
  2066. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  2067. } );
  2068. it( 'should handle complex view duplication', () => {
  2069. const content = '' +
  2070. '<container:blockquote>' +
  2071. '<container:ul>' +
  2072. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2073. '<container:li>Item 2</container:li>' +
  2074. '<container:li>' +
  2075. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2076. '</container:li>' +
  2077. '</container:ul>' +
  2078. '</container:blockquote>';
  2079. const expected = '' +
  2080. '<blockquote>' +
  2081. '<ul>' +
  2082. '<li>Quoted <strong>item 1</strong></li>' +
  2083. '<li>Item 2</li>' +
  2084. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2085. '</ul>' +
  2086. '</blockquote>';
  2087. viewRoot._appendChild( parse( content ) );
  2088. renderer.markToSync( 'children', viewRoot );
  2089. renderer.render();
  2090. expect( domRoot.innerHTML ).to.equal( expected );
  2091. viewRoot._removeChildren( 0, viewRoot.childCount );
  2092. viewRoot._appendChild( parse( content + content ) );
  2093. const domBQ = domRoot.childNodes[ 0 ];
  2094. const domUL = domBQ.childNodes[ 0 ];
  2095. const domLI1 = domUL.childNodes[ 0 ];
  2096. const domLI2 = domUL.childNodes[ 1 ];
  2097. const domLI3 = domUL.childNodes[ 2 ];
  2098. renderer.markToSync( 'children', viewRoot );
  2099. renderer.render();
  2100. // Assert content.
  2101. expect( domRoot.innerHTML ).to.equal( expected + expected );
  2102. // Assert if DOM elements did not change.
  2103. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  2104. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  2105. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  2106. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  2107. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  2108. // Assert mappings.
  2109. const domMappings = renderer.domConverter._domToViewMapping;
  2110. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  2111. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  2112. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  2113. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2114. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  2115. // Assert if new view elements are bind to new DOM elements.
  2116. const viewMappings = renderer.domConverter._domToViewMapping;
  2117. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  2118. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  2119. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  2120. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  2121. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  2122. } );
  2123. it( 'should handle complex view replace', () => {
  2124. const content = '' +
  2125. '<container:h2>He' +
  2126. '<attribute:i>ading 1</attribute:i>' +
  2127. '</container:h2>' +
  2128. '<container:p>Ph ' +
  2129. '<attribute:strong>Bold</attribute:strong>' +
  2130. '<attribute:a href="https://ckeditor.com">' +
  2131. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2132. '</attribute:a>' +
  2133. '</container:p>' +
  2134. '<container:blockquote>' +
  2135. '<container:ul>' +
  2136. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2137. '<container:li>Item 2</container:li>' +
  2138. '<container:li>' +
  2139. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2140. '</container:li>' +
  2141. '</container:ul>' +
  2142. '</container:blockquote>';
  2143. const replacement = '' +
  2144. '<container:p>' +
  2145. '1' +
  2146. '<attribute:i>A</attribute:i>' +
  2147. '</container:p>' +
  2148. '<container:p>' +
  2149. '<attribute:a href="https://cksource.com">' +
  2150. 'Li' +
  2151. '<attribute:strong>nk</attribute:strong>' +
  2152. '</attribute:a>' +
  2153. '</container:p>' +
  2154. '<container:h1>' +
  2155. 'Heading ' +
  2156. '<attribute:strong>1</attribute:strong>' +
  2157. '</container:h1>' +
  2158. '<container:h2>' +
  2159. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2160. '</container:h2>' +
  2161. '<container:h3>' +
  2162. 'Heading' +
  2163. '<attribute:i> 3</attribute:i>' +
  2164. '</container:h3>' +
  2165. '<container:blockquote>' +
  2166. 'Foo Bar Baz' +
  2167. '</container:blockquote>' +
  2168. '<container:ul>' +
  2169. '<container:li>' +
  2170. 'Item ' +
  2171. '<attribute:strong>1</attribute:strong>' +
  2172. '</container:li>' +
  2173. '<container:li>' +
  2174. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2175. ' 2' +
  2176. '</container:li>' +
  2177. '</container:ul>';
  2178. viewRoot._appendChild( parse( content ) );
  2179. renderer.markToSync( 'children', viewRoot );
  2180. renderer.render();
  2181. expect( domRoot.innerHTML ).to.equal( '' +
  2182. '<h2>He<i>ading 1</i></h2>' +
  2183. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2184. '<blockquote><ul>' +
  2185. '<li>Quoted <strong>item 1</strong></li>' +
  2186. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2187. '</ul></blockquote>' );
  2188. viewRoot._removeChildren( 0, viewRoot.childCount );
  2189. viewRoot._appendChild( parse( replacement ) );
  2190. renderer.markToSync( 'children', viewRoot );
  2191. renderer.render();
  2192. // Here we just check if new DOM structure was properly rendered.
  2193. expect( domRoot.innerHTML ).to.equal( '' +
  2194. '<p>1<i>A</i></p>' +
  2195. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2196. '<h1>Heading <strong>1</strong></h1>' +
  2197. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2198. '<h3>Heading<i> 3</i></h3>' +
  2199. '<blockquote>Foo Bar Baz</blockquote>' +
  2200. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2201. } );
  2202. it( 'should handle br elements while refreshing bindings', () => {
  2203. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2204. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2205. renderer.markToSync( 'children', viewRoot );
  2206. renderer.render();
  2207. expect( domRoot.innerHTML ).to.equal( expected );
  2208. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2209. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2210. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2211. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2212. viewRoot._removeChildren( 1 );
  2213. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2214. renderer.markToSync( 'children', viewRoot );
  2215. renderer.render();
  2216. expect( domRoot.innerHTML ).to.equal( expected );
  2217. } );
  2218. it( 'should handle list to paragraph conversion', () => {
  2219. const view = '' +
  2220. '<container:ol>' +
  2221. '<container:li>Item 1' +
  2222. '<container:ol>' +
  2223. '<container:li>Item 2</container:li>' +
  2224. '</container:ol>' +
  2225. '</container:li>' +
  2226. '</container:ol>' +
  2227. '<container:p>Paragraph</container:p>' +
  2228. '<container:ol>' +
  2229. '<container:li>Item 3' +
  2230. '<container:ol>' +
  2231. '<container:li>Item 4</container:li>' +
  2232. '</container:ol>' +
  2233. '</container:li>' +
  2234. '</container:ol>';
  2235. viewRoot._appendChild( parse( view ) );
  2236. renderer.markToSync( 'children', viewRoot );
  2237. renderer.render();
  2238. expect( domRoot.innerHTML ).to.equal(
  2239. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2240. const viewOL1 = viewRoot.getChild( 0 );
  2241. viewOL1.getChild( 0 )._removeChildren( 1 );
  2242. viewRoot._removeChildren( 2 );
  2243. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2244. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2245. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2246. const domOL1 = domRoot.childNodes[ 0 ];
  2247. const domOL2 = domRoot.childNodes[ 2 ];
  2248. const domP = domRoot.childNodes[ 1 ];
  2249. renderer.markToSync( 'children', viewRoot );
  2250. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2251. renderer.render();
  2252. expect( domRoot.innerHTML ).to.equal(
  2253. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2254. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2255. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2256. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2257. } );
  2258. it( 'should handle attributes change in replaced elements', () => {
  2259. const view = '' +
  2260. '<container:ol>' +
  2261. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2262. '</container:ol>' +
  2263. '<container:p>Paragraph ' +
  2264. '<attribute:a href="123">Link</attribute:a>' +
  2265. '</container:p>' +
  2266. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2267. viewRoot._appendChild( parse( view ) );
  2268. renderer.markToSync( 'children', viewRoot );
  2269. renderer.render();
  2270. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2271. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2272. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2273. const viewOL = viewRoot.getChild( 0 );
  2274. viewOL._removeChildren( 0 );
  2275. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2276. const viewP1 = viewRoot.getChild( 1 );
  2277. viewP1._removeChildren( 1 );
  2278. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2279. viewRoot._removeChildren( 2 );
  2280. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2281. renderer.markToSync( 'children', viewRoot );
  2282. renderer.markToSync( 'children', viewOL );
  2283. renderer.markToSync( 'children', viewP1 );
  2284. renderer.render();
  2285. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2286. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2287. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2288. } );
  2289. it( 'should handle classes change in replaced elements', () => {
  2290. const view = '' +
  2291. '<container:ol>' +
  2292. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2293. '</container:ol>' +
  2294. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2295. viewRoot._appendChild( parse( view ) );
  2296. renderer.markToSync( 'children', viewRoot );
  2297. renderer.render();
  2298. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2299. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2300. const viewOL = viewRoot.getChild( 0 );
  2301. const oldViewLI = viewOL.getChild( 0 );
  2302. viewOL._removeChildren( 0 );
  2303. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2304. const oldViewP = viewRoot.getChild( 1 );
  2305. viewRoot._removeChildren( 1 );
  2306. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2307. renderer.markToSync( 'attributes', oldViewLI );
  2308. renderer.markToSync( 'attributes', oldViewP );
  2309. renderer.markToSync( 'children', viewRoot );
  2310. renderer.markToSync( 'children', viewOL );
  2311. renderer.render();
  2312. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2313. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2314. } );
  2315. it( 'should handle styles change in replaced elements', () => {
  2316. const view = '' +
  2317. '<container:ol>' +
  2318. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2319. '<container:li>Bar ' +
  2320. '<attribute:i>' +
  2321. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2322. ' Bax</attribute:i>' +
  2323. '</container:li>' +
  2324. '</container:ol>';
  2325. viewRoot._appendChild( parse( view ) );
  2326. renderer.markToSync( 'children', viewRoot );
  2327. renderer.render();
  2328. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2329. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2330. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2331. const viewOL = viewRoot.getChild( 0 );
  2332. const viewLI1 = viewOL.getChild( 0 );
  2333. const viewLI2 = viewOL.getChild( 1 );
  2334. viewLI1._removeStyle( 'font-weight' );
  2335. viewLI1._setStyle( { color: '#FFF' } );
  2336. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2337. viewLI2._removeChildren( 0, viewLI2.childCount );
  2338. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2339. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2340. renderer.markToSync( 'attributes', viewLI1 );
  2341. renderer.markToSync( 'attributes', viewLI2 );
  2342. renderer.markToSync( 'children', viewRoot );
  2343. renderer.markToSync( 'children', viewLI2 );
  2344. renderer.render();
  2345. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2346. '<ol><li style="color:#FFF;">Foo</li>' +
  2347. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2348. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2349. } );
  2350. it( 'should handle uiElement rendering', () => {
  2351. function createUIElement( id, text ) {
  2352. const element = new UIElement( viewDocument, 'span' );
  2353. element.render = function( domDocument ) {
  2354. const domElement = this.toDomElement( domDocument );
  2355. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2356. return domElement;
  2357. };
  2358. return element;
  2359. }
  2360. const ui1 = createUIElement( 'id1', 'UI1' );
  2361. const ui2 = createUIElement( 'id2', 'UI2' );
  2362. const viewP = new ViewContainerElement( viewDocument, 'p', null, [
  2363. new ViewText( viewDocument, 'Foo ' ),
  2364. ui1,
  2365. new ViewText( viewDocument, 'Bar' )
  2366. ] );
  2367. viewRoot._appendChild( viewP );
  2368. renderer.markToSync( 'children', viewRoot );
  2369. renderer.render();
  2370. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2371. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2372. viewP._removeChildren( 0, viewP.childCount );
  2373. viewP._insertChild( 0, [ new ViewText( viewDocument, 'Foo' ), ui2, new ViewText( viewDocument, ' Bar' ) ] );
  2374. renderer.markToSync( 'children', viewRoot );
  2375. renderer.markToSync( 'children', viewP );
  2376. renderer.render();
  2377. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2378. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2379. } );
  2380. it( 'should handle linking entire content', () => {
  2381. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2382. renderer.markToSync( 'children', viewRoot );
  2383. renderer.render();
  2384. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2385. const viewP = viewRoot.getChild( 0 );
  2386. // While linking, the existing DOM children are moved to a new `a` element during binding
  2387. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2388. // where view elements were moved to a newly created link view element.
  2389. const viewA = new ViewAttributeElement( viewDocument, 'a', { href: '#href' }, [
  2390. new ViewText( viewDocument, 'Foo' ),
  2391. viewP.getChild( 1 )
  2392. ] );
  2393. viewP._removeChildren( 0, viewP.childCount );
  2394. viewP._insertChild( 0, viewA );
  2395. renderer.markToSync( 'children', viewRoot );
  2396. renderer.markToSync( 'children', viewP );
  2397. renderer.render();
  2398. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2399. } );
  2400. } );
  2401. describe( 'optimal (minimal) rendering – minimal children changes', () => {
  2402. let observer;
  2403. beforeEach( () => {
  2404. observer = new MutationObserver( () => {} );
  2405. observer.observe( domRoot, {
  2406. childList: true,
  2407. attributes: false,
  2408. subtree: false
  2409. } );
  2410. } );
  2411. afterEach( () => {
  2412. observer.disconnect();
  2413. } );
  2414. it( 'should add only one child (at the beginning)', () => {
  2415. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2416. renderer.markToSync( 'children', viewRoot );
  2417. renderer.render();
  2418. cleanObserver( observer );
  2419. viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
  2420. renderer.markToSync( 'children', viewRoot );
  2421. renderer.render();
  2422. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2423. 'added: 1, removed: 0'
  2424. ] );
  2425. } );
  2426. it( 'should add only one child (at the end)', () => {
  2427. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2428. renderer.markToSync( 'children', viewRoot );
  2429. renderer.render();
  2430. cleanObserver( observer );
  2431. viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
  2432. renderer.markToSync( 'children', viewRoot );
  2433. renderer.render();
  2434. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2435. 'added: 1, removed: 0'
  2436. ] );
  2437. } );
  2438. it( 'should add only one child (in the middle)', () => {
  2439. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2440. renderer.markToSync( 'children', viewRoot );
  2441. renderer.render();
  2442. cleanObserver( observer );
  2443. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2444. renderer.markToSync( 'children', viewRoot );
  2445. renderer.render();
  2446. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2447. 'added: 1, removed: 0'
  2448. ] );
  2449. } );
  2450. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2451. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2452. renderer.markToSync( 'children', viewRoot );
  2453. renderer.render();
  2454. cleanObserver( observer );
  2455. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2456. viewRoot._removeChildren( 0, 1 );
  2457. renderer.markToSync( 'children', viewRoot );
  2458. renderer.render();
  2459. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2460. } );
  2461. it( 'should add and remove one', () => {
  2462. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2463. renderer.markToSync( 'children', viewRoot );
  2464. renderer.render();
  2465. cleanObserver( observer );
  2466. viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
  2467. viewRoot._removeChildren( 0, 1 );
  2468. renderer.markToSync( 'children', viewRoot );
  2469. renderer.render();
  2470. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2471. 'added: 1, removed: 0',
  2472. 'added: 0, removed: 1'
  2473. ] );
  2474. } );
  2475. it( 'should not touch the FSC when rendering children', () => {
  2476. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2477. // Set fake selection on the second paragraph.
  2478. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2479. renderer.markToSync( 'children', viewRoot );
  2480. renderer.render();
  2481. cleanObserver( observer );
  2482. // Remove the second paragraph.
  2483. viewRoot._removeChildren( 1, 1 );
  2484. // And set the fake selection on the first one.
  2485. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2486. renderer.markToSync( 'children', viewRoot );
  2487. renderer.render();
  2488. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2489. 'added: 0, removed: 1'
  2490. ] );
  2491. } );
  2492. it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
  2493. // This test's purpose is mostly reaching 100% CC.
  2494. observer = new MutationObserver( () => {} );
  2495. viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
  2496. const viewDiv = viewRoot.getChild( 0 );
  2497. // Set fake selection on the second paragraph.
  2498. selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
  2499. renderer.markToSync( 'children', viewDiv );
  2500. renderer.markToSync( 'children', viewRoot );
  2501. renderer.render();
  2502. observer.observe( domRoot.childNodes[ 0 ], {
  2503. childList: true,
  2504. attributes: false,
  2505. subtree: false
  2506. } );
  2507. // Remove the second paragraph.
  2508. viewDiv._removeChildren( 1, 1 );
  2509. // And set the fake selection on the first one.
  2510. selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
  2511. renderer.markToSync( 'children', viewDiv );
  2512. renderer.markToSync( 'children', viewRoot );
  2513. renderer.render();
  2514. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2515. 'added: 0, removed: 1'
  2516. ] );
  2517. observer.disconnect();
  2518. } );
  2519. describe( 'using fastDiff() - significant number of nodes in the editor', () => {
  2520. it( 'should add only one child (at the beginning)', () => {
  2521. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2522. renderer.markToSync( 'children', viewRoot );
  2523. renderer.render();
  2524. cleanObserver( observer );
  2525. viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
  2526. renderer.markToSync( 'children', viewRoot );
  2527. renderer.render();
  2528. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2529. 'added: 1, removed: 0'
  2530. ] );
  2531. } );
  2532. it( 'should add only one child (at the end)', () => {
  2533. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2534. renderer.markToSync( 'children', viewRoot );
  2535. renderer.render();
  2536. cleanObserver( observer );
  2537. viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
  2538. renderer.markToSync( 'children', viewRoot );
  2539. renderer.render();
  2540. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2541. 'added: 1, removed: 0'
  2542. ] );
  2543. } );
  2544. it( 'should add only one child (in the middle)', () => {
  2545. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2546. renderer.markToSync( 'children', viewRoot );
  2547. renderer.render();
  2548. cleanObserver( observer );
  2549. viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
  2550. renderer.markToSync( 'children', viewRoot );
  2551. renderer.render();
  2552. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2553. 'added: 1, removed: 0'
  2554. ] );
  2555. } );
  2556. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2557. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2558. renderer.markToSync( 'children', viewRoot );
  2559. renderer.render();
  2560. cleanObserver( observer );
  2561. viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
  2562. viewRoot._removeChildren( 0, 1 );
  2563. renderer.markToSync( 'children', viewRoot );
  2564. renderer.render();
  2565. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2566. } );
  2567. it( 'should add and remove one', () => {
  2568. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2569. renderer.markToSync( 'children', viewRoot );
  2570. renderer.render();
  2571. cleanObserver( observer );
  2572. viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
  2573. viewRoot._removeChildren( 0, 1 );
  2574. renderer.markToSync( 'children', viewRoot );
  2575. renderer.render();
  2576. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2577. 'added: 1, removed: 0',
  2578. 'added: 0, removed: 1'
  2579. ] );
  2580. } );
  2581. it( 'should not touch the FSC when rendering children', () => {
  2582. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2583. // Set fake selection on the second paragraph.
  2584. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2585. renderer.markToSync( 'children', viewRoot );
  2586. renderer.render();
  2587. cleanObserver( observer );
  2588. // Remove the second paragraph.
  2589. viewRoot._removeChildren( 1, 1 );
  2590. // And set the fake selection on the first one.
  2591. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2592. renderer.markToSync( 'children', viewRoot );
  2593. renderer.render();
  2594. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2595. 'added: 0, removed: 1'
  2596. ] );
  2597. } );
  2598. } );
  2599. function getMutationStats( mutationList ) {
  2600. return mutationList.map( mutation => {
  2601. return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
  2602. } );
  2603. }
  2604. function cleanObserver( observer ) {
  2605. observer.takeRecords();
  2606. }
  2607. function makeContainers( howMany ) {
  2608. const containers = [];
  2609. for ( let i = 1; i <= howMany; i++ ) {
  2610. containers.push( `<container:p>${ i }</container:p>` );
  2611. }
  2612. return containers.join( '' );
  2613. }
  2614. } );
  2615. // #1560
  2616. describe( 'attributes manipulation on replaced element', () => {
  2617. it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
  2618. const writer = new DowncastWriter();
  2619. // 1. Setup initial view/DOM.
  2620. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2621. const viewP = viewRoot.getChild( 0 );
  2622. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2623. renderer.markToSync( 'children', viewRoot );
  2624. renderer.render();
  2625. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2626. // 2. Modify view.
  2627. writer.removeAttribute( 'data-placeholder', viewP );
  2628. viewRoot._removeChildren( 0, viewRoot.childCount );
  2629. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2630. renderer.markToSync( 'attributes', viewP );
  2631. renderer.markToSync( 'children', viewRoot );
  2632. renderer.render();
  2633. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2634. } );
  2635. it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
  2636. const writer = new DowncastWriter();
  2637. // 1. Setup initial view/DOM.
  2638. viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
  2639. const viewP = viewRoot.getChild( 1 );
  2640. writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
  2641. renderer.markToSync( 'children', viewRoot );
  2642. renderer.render();
  2643. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
  2644. // 2. Modify view.
  2645. writer.removeClass( 'cke-test2', viewP );
  2646. viewRoot._removeChildren( 0, viewRoot.childCount );
  2647. viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
  2648. '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
  2649. renderer.markToSync( 'attributes', viewP );
  2650. renderer.markToSync( 'children', viewRoot );
  2651. renderer.render();
  2652. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
  2653. } );
  2654. it( 'should rerender element if it was removed and have its attributes removed after', () => {
  2655. const writer = new DowncastWriter();
  2656. // 1. Setup initial view/DOM.
  2657. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2658. const viewP = viewRoot.getChild( 0 );
  2659. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2660. renderer.markToSync( 'children', viewRoot );
  2661. renderer.render();
  2662. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2663. // 2. Modify view.
  2664. viewRoot._removeChildren( 0, viewRoot.childCount );
  2665. writer.removeAttribute( 'data-placeholder', viewP );
  2666. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2667. renderer.markToSync( 'children', viewRoot );
  2668. renderer.render();
  2669. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2670. } );
  2671. } );
  2672. // ckeditor/ckeditor5-utils#269
  2673. // The expected times has a significant margin above the usual execution time (which is around 40-50%
  2674. // of the expected time) because it depends on the browser and environment in which tests are run.
  2675. // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
  2676. // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
  2677. describe( 'rendering performance', () => {
  2678. before( function() {
  2679. // Ignore on Edge browser where performance is quite poor.
  2680. if ( env.isEdge ) {
  2681. this.skip();
  2682. }
  2683. } );
  2684. it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
  2685. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
  2686. expect( renderingTime ).to.be.within( 0, 350 );
  2687. } );
  2688. it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
  2689. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
  2690. expect( renderingTime ).to.be.within( 0, 350 );
  2691. } );
  2692. it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
  2693. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
  2694. expect( renderingTime ).to.be.within( 0, 350 );
  2695. } );
  2696. it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
  2697. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
  2698. expect( renderingTime ).to.be.within( 0, 350 );
  2699. } );
  2700. it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
  2701. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
  2702. expect( renderingTime ).to.be.within( 0, 350 );
  2703. } );
  2704. it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
  2705. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
  2706. expect( renderingTime ).to.be.within( 0, 350 );
  2707. } );
  2708. function measureRenderingTime( viewRoot, initialData, newData ) {
  2709. // Set initial data.
  2710. const initialView = parse( initialData );
  2711. viewRoot._appendChild( initialView );
  2712. renderer.markToSync( 'children', viewRoot );
  2713. renderer.render();
  2714. // Set new data.
  2715. const newView = parse( newData );
  2716. viewRoot._removeChildren( 0, viewRoot.childCount );
  2717. viewRoot._appendChild( newView );
  2718. renderer.markToSync( 'children', viewRoot );
  2719. // Measure render time.
  2720. const start = Date.now();
  2721. renderer.render();
  2722. return Date.now() - start;
  2723. }
  2724. function generateViewData1( repeat = 1 ) {
  2725. const viewData = '' +
  2726. '<container:h1>' +
  2727. 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
  2728. '</container:h1>' +
  2729. '<container:p>' +
  2730. 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
  2731. '</container:p>' +
  2732. '<container:ul>' +
  2733. '<container:li>Item 1</container:li>' +
  2734. '</container:ul>' +
  2735. '<container:ul>' +
  2736. '<container:li>Item 2</container:li>' +
  2737. '</container:ul>' +
  2738. '<container:ul>' +
  2739. '<container:li>Item 3</container:li>' +
  2740. '</container:ul>';
  2741. return viewData.repeat( repeat );
  2742. }
  2743. function generateViewData2( repeat = 1 ) {
  2744. const viewData = '' +
  2745. '<container:ol>' +
  2746. '<container:li>' +
  2747. '<attribute:strong>Foo</attribute:strong>' +
  2748. '</container:li>' +
  2749. '</container:ol>' +
  2750. '<container:ol>' +
  2751. '<container:li>Item 1</container:li>' +
  2752. '</container:ol>' +
  2753. '<container:h1>Heading 1</container:h1>' +
  2754. '<container:h2>' +
  2755. '<attribute:strong>Heading</attribute:strong> 2' +
  2756. '</container:h2>' +
  2757. '<container:h3>Heading 4</container:h3>';
  2758. return viewData.repeat( repeat );
  2759. }
  2760. } );
  2761. } );
  2762. describe( '#922', () => {
  2763. let view, viewDoc, viewRoot, domRoot, converter;
  2764. beforeEach( () => {
  2765. view = new View();
  2766. viewDoc = view.document;
  2767. domRoot = document.createElement( 'div' );
  2768. document.body.appendChild( domRoot );
  2769. viewRoot = createViewRoot( viewDoc );
  2770. view.attachDomRoot( domRoot );
  2771. converter = view.domConverter;
  2772. } );
  2773. afterEach( () => {
  2774. view.destroy();
  2775. domRoot.remove();
  2776. } );
  2777. it( 'should properly render unwrapped attributes #1', () => {
  2778. setViewData( view,
  2779. '<container:p>' +
  2780. '[<attribute:italic>' +
  2781. '<attribute:strong>f</attribute:strong>' +
  2782. '</attribute:italic>]' +
  2783. '<attribute:strong>oo</attribute:strong>' +
  2784. '</container:p>'
  2785. );
  2786. // Render it to DOM to create initial DOM <-> view mappings.
  2787. view.forceRender();
  2788. // Unwrap italic attribute element.
  2789. view.change( writer => {
  2790. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2791. } );
  2792. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2793. // Re-render changes in view to DOM.
  2794. view.forceRender();
  2795. // Check if DOM is rendered correctly.
  2796. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2797. expect( checkMappings() ).to.be.true;
  2798. } );
  2799. it( 'should properly render unwrapped attributes #2', () => {
  2800. setViewData( view,
  2801. '<container:p>' +
  2802. '[<attribute:italic>' +
  2803. '<attribute:strong>foo</attribute:strong>' +
  2804. '</attribute:italic>]' +
  2805. '</container:p>' );
  2806. // Render it to DOM to create initial DOM <-> view mappings.
  2807. view.forceRender();
  2808. // Unwrap italic attribute element and change text inside.
  2809. view.change( writer => {
  2810. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2811. } );
  2812. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2813. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2814. // Re-render changes in view to DOM.
  2815. view.forceRender();
  2816. // Check if DOM is rendered correctly.
  2817. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2818. expect( checkMappings() ).to.be.true;
  2819. } );
  2820. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2821. setViewData( view,
  2822. '<container:p>foo</container:p>'
  2823. );
  2824. // Render it to DOM to create initial DOM <-> view mappings.
  2825. view.forceRender();
  2826. // Change text and insert new element into paragraph.
  2827. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2828. textNode._data = 'foobar';
  2829. view.change( writer => {
  2830. writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2831. } );
  2832. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2833. // Re-render changes in view to DOM.
  2834. view.forceRender();
  2835. // Check if DOM is rendered correctly.
  2836. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2837. expect( checkMappings() ).to.be.true;
  2838. } );
  2839. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2840. setViewData( view,
  2841. '<container:p>foo</container:p>'
  2842. );
  2843. // Render it to DOM to create initial DOM <-> view mappings.
  2844. view.forceRender();
  2845. // Change text and insert new element into paragraph.
  2846. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2847. textNode._data = 'foobar';
  2848. view.change( writer => {
  2849. writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2850. } );
  2851. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2852. // Re-render changes in view to DOM.
  2853. view.forceRender();
  2854. // Check if DOM is rendered correctly.
  2855. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2856. expect( checkMappings() ).to.be.true;
  2857. } );
  2858. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2859. setViewData( view,
  2860. '<container:p>' +
  2861. '<attribute:b></attribute:b>' +
  2862. '<attribute:i></attribute:i>' +
  2863. '<attribute:span></attribute:span>' +
  2864. '</container:p>'
  2865. );
  2866. // Render it to DOM to create initial DOM <-> view mappings.
  2867. view.forceRender();
  2868. // Remove first element and reinsert it at the end.
  2869. const container = viewRoot.getChild( 0 );
  2870. const firstElement = container.getChild( 0 );
  2871. view.change( writer => {
  2872. writer.remove( ViewRange._createOn( firstElement ) );
  2873. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2874. } );
  2875. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2876. // Re-render changes in view to DOM.
  2877. view.forceRender();
  2878. // Check if DOM is rendered correctly.
  2879. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2880. expect( checkMappings() ).to.be.true;
  2881. } );
  2882. // Checks if every node in DOM tree is mapped to the view.
  2883. function checkMappings() {
  2884. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2885. while ( domWalker.nextNode() ) {
  2886. const node = domWalker.currentNode;
  2887. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2888. return false;
  2889. }
  2890. }
  2891. return true;
  2892. }
  2893. } );
  2894. describe( '_markDescendantTextToSync', () => {
  2895. let viewRoot;
  2896. beforeEach( () => {
  2897. viewRoot = new ViewElement( viewDocument, 'div' );
  2898. renderer.markedTexts.clear();
  2899. renderer.markedAttributes.clear();
  2900. renderer.markedChildren.clear();
  2901. } );
  2902. it( 'should handle null values', () => {
  2903. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2904. renderer._markDescendantTextToSync( null );
  2905. expect( renderer.markedChildren.size ).to.equal( 0 );
  2906. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2907. expect( renderer.markedTexts.size ).to.equal( 0 );
  2908. } );
  2909. it( 'should handle element nodes', () => {
  2910. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2911. viewRoot._appendChild( viewP );
  2912. renderer._markDescendantTextToSync( viewP );
  2913. expect( renderer.markedChildren.size ).to.equal( 0 );
  2914. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2915. expect( renderer.markedTexts.size ).to.equal( 3 );
  2916. } );
  2917. it( 'should handle text nodes', () => {
  2918. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2919. viewRoot._appendChild( viewP );
  2920. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2921. expect( renderer.markedChildren.size ).to.equal( 0 );
  2922. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2923. expect( renderer.markedTexts.size ).to.equal( 1 );
  2924. } );
  2925. it( 'should handle document fragment', () => {
  2926. const fragment = new DocumentFragment();
  2927. renderer._markDescendantTextToSync( fragment );
  2928. expect( renderer.markedChildren.size ).to.equal( 0 );
  2929. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2930. expect( renderer.markedTexts.size ).to.equal( 0 );
  2931. } );
  2932. it( 'should handle empty element nodes', () => {
  2933. const viewP = parse( '<container:p></container:p>' );
  2934. viewRoot._appendChild( viewP );
  2935. renderer._markDescendantTextToSync( viewP );
  2936. expect( renderer.markedChildren.size ).to.equal( 0 );
  2937. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2938. expect( renderer.markedTexts.size ).to.equal( 0 );
  2939. } );
  2940. } );
  2941. describe( '_updateText', () => {
  2942. let viewRoot, domRoot;
  2943. beforeEach( () => {
  2944. viewRoot = new ViewElement( viewDocument, 'div' );
  2945. domRoot = document.createElement( 'div' );
  2946. document.body.appendChild( domRoot );
  2947. domConverter.bindElements( domRoot, viewRoot );
  2948. renderer.markedTexts.clear();
  2949. renderer.markedAttributes.clear();
  2950. renderer.markedChildren.clear();
  2951. renderer.isFocused = true;
  2952. } );
  2953. afterEach( () => {
  2954. domRoot.remove();
  2955. } );
  2956. it( 'should update text - change on end', () => {
  2957. const viewText = new ViewText( viewDocument, 'foo' );
  2958. viewRoot._appendChild( viewText );
  2959. renderer.markToSync( 'children', viewRoot );
  2960. renderer.render();
  2961. expect( domRoot.childNodes.length ).to.equal( 1 );
  2962. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2963. viewText._data = 'fobar';
  2964. renderer._updateText( viewText, {} );
  2965. expect( domRoot.childNodes.length ).to.equal( 1 );
  2966. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2967. } );
  2968. it( 'should update text - change on start', () => {
  2969. const viewText = new ViewText( viewDocument, 'foo' );
  2970. viewRoot._appendChild( viewText );
  2971. renderer.markToSync( 'children', viewRoot );
  2972. renderer.render();
  2973. expect( domRoot.childNodes.length ).to.equal( 1 );
  2974. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2975. viewText._data = 'baro';
  2976. renderer._updateText( viewText, {} );
  2977. expect( domRoot.childNodes.length ).to.equal( 1 );
  2978. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  2979. } );
  2980. it( 'should update text - change in the middle', () => {
  2981. const viewText = new ViewText( viewDocument, 'foobar' );
  2982. viewRoot._appendChild( viewText );
  2983. renderer.markToSync( 'children', viewRoot );
  2984. renderer.render();
  2985. expect( domRoot.childNodes.length ).to.equal( 1 );
  2986. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  2987. viewText._data = 'fobazr';
  2988. renderer._updateText( viewText, {} );
  2989. expect( domRoot.childNodes.length ).to.equal( 1 );
  2990. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  2991. } );
  2992. it( 'should update text - empty expected', () => {
  2993. const viewText = new ViewText( viewDocument, 'foo' );
  2994. viewRoot._appendChild( viewText );
  2995. renderer.markToSync( 'children', viewRoot );
  2996. renderer.render();
  2997. expect( domRoot.childNodes.length ).to.equal( 1 );
  2998. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2999. viewText._data = '';
  3000. renderer._updateText( viewText, {} );
  3001. expect( domRoot.childNodes.length ).to.equal( 1 );
  3002. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3003. } );
  3004. it( 'should update text - empty actual', () => {
  3005. const viewText = new ViewText( viewDocument, '' );
  3006. viewRoot._appendChild( viewText );
  3007. renderer.markToSync( 'children', viewRoot );
  3008. renderer.render();
  3009. expect( domRoot.childNodes.length ).to.equal( 1 );
  3010. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3011. viewText._data = 'fobar';
  3012. renderer._updateText( viewText, {} );
  3013. expect( domRoot.childNodes.length ).to.equal( 1 );
  3014. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  3015. } );
  3016. it( 'should handle filler during text modifications', () => {
  3017. const viewText = new ViewText( viewDocument, 'foo' );
  3018. viewRoot._appendChild( viewText );
  3019. renderer.markToSync( 'children', viewRoot );
  3020. renderer.render();
  3021. expect( domRoot.childNodes.length ).to.equal( 1 );
  3022. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3023. // 1. Insert filler.
  3024. renderer._updateText( viewText, {
  3025. inlineFillerPosition: {
  3026. parent: viewText.parent,
  3027. offset: 0
  3028. }
  3029. } );
  3030. expect( domRoot.childNodes.length ).to.equal( 1 );
  3031. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3032. // 2. Edit text - filler should be preserved.
  3033. viewText._data = 'barfoo';
  3034. renderer._updateText( viewText, {
  3035. inlineFillerPosition: {
  3036. parent: viewText.parent,
  3037. offset: 0
  3038. }
  3039. } );
  3040. expect( domRoot.childNodes.length ).to.equal( 1 );
  3041. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  3042. // 3. Remove filler.
  3043. renderer._updateText( viewText, {} );
  3044. expect( domRoot.childNodes.length ).to.equal( 1 );
  3045. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  3046. } );
  3047. it( 'should handle filler during text modifications - empty text', () => {
  3048. const viewText = new ViewText( viewDocument, '' );
  3049. viewRoot._appendChild( viewText );
  3050. renderer.markToSync( 'children', viewRoot );
  3051. renderer.render();
  3052. expect( domRoot.childNodes.length ).to.equal( 1 );
  3053. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3054. // 1. Insert filler.
  3055. renderer._updateText( viewText, {
  3056. inlineFillerPosition: {
  3057. parent: viewText.parent,
  3058. offset: 0
  3059. }
  3060. } );
  3061. expect( domRoot.childNodes.length ).to.equal( 1 );
  3062. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  3063. // 2. Edit text - filler should be preserved.
  3064. viewText._data = 'foo';
  3065. renderer._updateText( viewText, {
  3066. inlineFillerPosition: {
  3067. parent: viewText.parent,
  3068. offset: 0
  3069. }
  3070. } );
  3071. expect( domRoot.childNodes.length ).to.equal( 1 );
  3072. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3073. // 3. Remove filler.
  3074. viewText._data = '';
  3075. renderer._updateText( viewText, {} );
  3076. expect( domRoot.childNodes.length ).to.equal( 1 );
  3077. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3078. } );
  3079. it( 'should handle filler during text modifications inside inline element', () => {
  3080. const viewB = new ViewElement( viewDocument, 'b' );
  3081. const viewText = new ViewText( viewDocument, 'foo' );
  3082. viewB._appendChild( viewText );
  3083. viewRoot._appendChild( viewB );
  3084. renderer.markToSync( 'children', viewRoot );
  3085. renderer.render();
  3086. expect( domRoot.childNodes.length ).to.equal( 1 );
  3087. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3088. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3089. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  3090. // 1. Insert filler.
  3091. renderer._updateText( viewText, {
  3092. inlineFillerPosition: {
  3093. parent: viewText.parent,
  3094. offset: 0
  3095. }
  3096. } );
  3097. expect( domRoot.childNodes.length ).to.equal( 1 );
  3098. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3099. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3100. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3101. // 2. Edit text - filler should be preserved.
  3102. viewText._data = 'bar';
  3103. renderer._updateText( viewText, {
  3104. inlineFillerPosition: {
  3105. parent: viewText.parent,
  3106. offset: 0
  3107. }
  3108. } );
  3109. expect( domRoot.childNodes.length ).to.equal( 1 );
  3110. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3111. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3112. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  3113. // 3. Remove filler.
  3114. viewText._data = 'bar';
  3115. renderer._updateText( viewText, {} );
  3116. expect( domRoot.childNodes.length ).to.equal( 1 );
  3117. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3118. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3119. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  3120. } );
  3121. } );
  3122. } );
  3123. function renderAndExpectNoChanges( renderer, domRoot ) {
  3124. const config = {
  3125. childList: true,
  3126. characterData: true,
  3127. characterDataOldValue: true,
  3128. subtree: true
  3129. };
  3130. const mutationObserver = new window.MutationObserver( () => {
  3131. throw 'There should be not mutations';
  3132. } );
  3133. mutationObserver.observe( domRoot, config );
  3134. renderer.render();
  3135. const records = mutationObserver.takeRecords();
  3136. mutationObserver.disconnect();
  3137. expect( records.length ).to.equal( 0 );
  3138. }