8
0

renderer.js 62 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740
  1. /**
  2. * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window */
  6. import ViewElement from '../../src/view/element';
  7. import ViewText from '../../src/view/text';
  8. import ViewRange from '../../src/view/range';
  9. import ViewPosition from '../../src/view/position';
  10. import Selection from '../../src/view/selection';
  11. import DomConverter from '../../src/view/domconverter';
  12. import Renderer from '../../src/view/renderer';
  13. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  14. import { parse } from '../../src/dev-utils/view';
  15. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  16. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  17. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  18. import log from '@ckeditor/ckeditor5-utils/src/log';
  19. testUtils.createSinonSandbox();
  20. describe( 'Renderer', () => {
  21. let selection, domConverter, renderer;
  22. beforeEach( () => {
  23. selection = new Selection();
  24. domConverter = new DomConverter();
  25. renderer = new Renderer( domConverter, selection );
  26. renderer.domDocuments.add( document );
  27. } );
  28. describe( 'markToSync', () => {
  29. let viewRoot;
  30. beforeEach( () => {
  31. viewRoot = new ViewElement( 'p' );
  32. const domRoot = document.createElement( 'p' );
  33. domConverter.bindElements( domRoot, viewRoot );
  34. viewRoot.appendChildren( new ViewText( 'foo' ) );
  35. renderer.markedTexts.clear();
  36. renderer.markedAttributes.clear();
  37. renderer.markedChildren.clear();
  38. } );
  39. it( 'should mark attributes which need update', () => {
  40. viewRoot.setAttribute( 'class', 'foo' );
  41. renderer.markToSync( 'attributes', viewRoot );
  42. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  43. } );
  44. it( 'should mark children which need update', () => {
  45. viewRoot.appendChildren( new ViewText( 'foo' ) );
  46. renderer.markToSync( 'children', viewRoot );
  47. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  48. } );
  49. it( 'should not mark children if element has no corresponding node', () => {
  50. // Overwrite viewRoot with node without coresponding DOM node.
  51. viewRoot = new ViewElement( 'p' );
  52. viewRoot.appendChildren( new ViewText( 'foo' ) );
  53. renderer.markToSync( 'children', viewRoot );
  54. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  55. } );
  56. it( 'should mark text which need update', () => {
  57. const viewText = new ViewText( 'foo' );
  58. viewRoot.appendChildren( viewText );
  59. viewText.data = 'bar';
  60. renderer.markToSync( 'text', viewText );
  61. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  62. } );
  63. it( 'should not mark text if parent has no corresponding node', () => {
  64. const viewText = new ViewText( 'foo' );
  65. // Overwrite viewRoot with node without coresponding DOM node.
  66. viewRoot = new ViewElement( 'p' );
  67. viewRoot.appendChildren( viewText );
  68. viewText.data = 'bar';
  69. renderer.markToSync( 'text', viewText );
  70. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  71. } );
  72. it( 'should throw if the type is unknown', () => {
  73. expect( () => {
  74. renderer.markToSync( 'UNKNOWN', viewRoot );
  75. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  76. } );
  77. } );
  78. describe( 'render', () => {
  79. let viewRoot, domRoot, selectionEditable;
  80. beforeEach( () => {
  81. viewRoot = new ViewElement( 'div' );
  82. domRoot = document.createElement( 'div' );
  83. document.body.appendChild( domRoot );
  84. domConverter.bindElements( domRoot, viewRoot );
  85. renderer.markedTexts.clear();
  86. renderer.markedAttributes.clear();
  87. renderer.markedChildren.clear();
  88. selection.removeAllRanges();
  89. selection.setFake( false );
  90. selectionEditable = viewRoot;
  91. renderer.isFocused = true;
  92. // Fake selection editable - it is needed to render selection properly.
  93. Object.defineProperty( selection, 'editableElement', {
  94. get() {
  95. return selectionEditable;
  96. }
  97. } );
  98. } );
  99. it( 'should update attributes', () => {
  100. viewRoot.setAttribute( 'class', 'foo' );
  101. renderer.markToSync( 'attributes', viewRoot );
  102. renderer.render();
  103. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  104. expect( renderer.markedAttributes.size ).to.equal( 0 );
  105. } );
  106. it( 'should remove attributes', () => {
  107. viewRoot.setAttribute( 'class', 'foo' );
  108. domRoot.setAttribute( 'id', 'bar' );
  109. domRoot.setAttribute( 'class', 'bar' );
  110. renderer.markToSync( 'attributes', viewRoot );
  111. renderer.render();
  112. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  113. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  114. expect( renderer.markedAttributes.size ).to.equal( 0 );
  115. } );
  116. it( 'should add children', () => {
  117. viewRoot.appendChildren( new ViewText( 'foo' ) );
  118. renderer.markToSync( 'children', viewRoot );
  119. renderer.render();
  120. expect( domRoot.childNodes.length ).to.equal( 1 );
  121. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  122. expect( renderer.markedChildren.size ).to.equal( 0 );
  123. } );
  124. it( 'should remove children', () => {
  125. viewRoot.appendChildren( new ViewText( 'foo' ) );
  126. renderer.markToSync( 'children', viewRoot );
  127. renderer.render();
  128. expect( domRoot.childNodes.length ).to.equal( 1 );
  129. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  130. viewRoot.removeChildren( 0, 1 );
  131. renderer.markToSync( 'children', viewRoot );
  132. renderer.render();
  133. expect( domRoot.childNodes.length ).to.equal( 0 );
  134. expect( renderer.markedChildren.size ).to.equal( 0 );
  135. } );
  136. it( 'should update text', () => {
  137. const viewText = new ViewText( 'foo' );
  138. viewRoot.appendChildren( viewText );
  139. renderer.markToSync( 'children', viewRoot );
  140. renderer.render();
  141. expect( domRoot.childNodes.length ).to.equal( 1 );
  142. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  143. viewText.data = 'bar';
  144. renderer.markToSync( 'text', viewText );
  145. renderer.render();
  146. expect( domRoot.childNodes.length ).to.equal( 1 );
  147. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  148. expect( renderer.markedTexts.size ).to.equal( 0 );
  149. } );
  150. it( 'should not update text parent child list changed', () => {
  151. const viewImg = new ViewElement( 'img' );
  152. const viewText = new ViewText( 'foo' );
  153. viewRoot.appendChildren( [ viewImg, viewText ] );
  154. renderer.markToSync( 'children', viewRoot );
  155. renderer.markToSync( 'text', viewText );
  156. renderer.render();
  157. expect( domRoot.childNodes.length ).to.equal( 2 );
  158. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  159. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  160. } );
  161. it( 'should not change text if it is the same during text rendering', () => {
  162. const viewText = new ViewText( 'foo' );
  163. viewRoot.appendChildren( viewText );
  164. renderer.markToSync( 'children', viewRoot );
  165. renderer.render();
  166. // This should not be changed during the render.
  167. const domText = domRoot.childNodes[ 0 ];
  168. renderer.markToSync( 'text', viewText );
  169. renderer.render();
  170. expect( domRoot.childNodes.length ).to.equal( 1 );
  171. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  172. } );
  173. it( 'should not change text if it is the same during children rendering', () => {
  174. const viewText = new ViewText( 'foo' );
  175. viewRoot.appendChildren( viewText );
  176. renderer.markToSync( 'children', viewRoot );
  177. renderer.render();
  178. // This should not be changed during the render.
  179. const domText = domRoot.childNodes[ 0 ];
  180. renderer.markToSync( 'children', viewRoot );
  181. renderer.render();
  182. expect( domRoot.childNodes.length ).to.equal( 1 );
  183. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  184. } );
  185. it( 'should not change element if it is the same', () => {
  186. const viewImg = new ViewElement( 'img' );
  187. viewRoot.appendChildren( viewImg );
  188. // This should not be changed during the render.
  189. const domImg = document.createElement( 'img' );
  190. domRoot.appendChild( domImg );
  191. domConverter.bindElements( domImg, viewImg );
  192. renderer.markToSync( 'children', viewRoot );
  193. renderer.render();
  194. expect( domRoot.childNodes.length ).to.equal( 1 );
  195. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  196. } );
  197. it( 'should change element if it is different', () => {
  198. const viewImg = new ViewElement( 'img' );
  199. viewRoot.appendChildren( viewImg );
  200. renderer.markToSync( 'children', viewRoot );
  201. renderer.render();
  202. const viewP = new ViewElement( 'p' );
  203. viewRoot.removeChildren( 0, 1 );
  204. viewRoot.appendChildren( viewP );
  205. renderer.markToSync( 'children', viewRoot );
  206. renderer.render();
  207. expect( domRoot.childNodes.length ).to.equal( 1 );
  208. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  209. } );
  210. it( 'should update removed item when it is reinserted', () => {
  211. const viewFoo = new ViewText( 'foo' );
  212. const viewP = new ViewElement( 'p', null, viewFoo );
  213. const viewDiv = new ViewElement( 'div', null, viewP );
  214. viewRoot.appendChildren( viewDiv );
  215. renderer.markToSync( 'children', viewRoot );
  216. renderer.render();
  217. viewDiv.removeChildren( 0, 1 );
  218. renderer.markToSync( 'children', viewDiv );
  219. renderer.render();
  220. viewP.removeChildren( 0, 1 );
  221. viewDiv.appendChildren( viewP );
  222. renderer.markToSync( 'children', viewDiv );
  223. renderer.render();
  224. expect( domRoot.childNodes.length ).to.equal( 1 );
  225. const domDiv = domRoot.childNodes[ 0 ];
  226. expect( domDiv.tagName ).to.equal( 'DIV' );
  227. expect( domDiv.childNodes.length ).to.equal( 1 );
  228. const domP = domDiv.childNodes[ 0 ];
  229. expect( domP.tagName ).to.equal( 'P' );
  230. expect( domP.childNodes.length ).to.equal( 0 );
  231. } );
  232. it( 'should update removed item when it is reinserted #2', () => {
  233. // Prepare view: root -> div "outer" -> div "inner" -> p.
  234. const viewP = new ViewElement( 'p' );
  235. const viewDivInner = new ViewElement( 'div', null, viewP );
  236. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  237. viewRoot.appendChildren( viewDivOuter );
  238. // Render view tree to DOM.
  239. renderer.markToSync( 'children', viewRoot );
  240. renderer.render();
  241. // Remove div "outer" from root and render it.
  242. viewDivOuter.remove();
  243. renderer.markToSync( 'children', viewRoot );
  244. renderer.render();
  245. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  246. viewP.remove();
  247. // Add div "outer" back to root.
  248. viewRoot.appendChildren( viewDivOuter );
  249. renderer.markToSync( 'children', viewRoot );
  250. // Render changes, view is: root -> div "outer" -> div "inner".
  251. renderer.render();
  252. // Same is expected in DOM.
  253. expect( domRoot.childNodes.length ).to.equal( 1 );
  254. const domDivOuter = domRoot.childNodes[ 0 ];
  255. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  256. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  257. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  258. const domDivInner = domDivOuter.childNodes[ 0 ];
  259. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  260. expect( domDivInner.tagName ).to.equal( 'DIV' );
  261. expect( domDivInner.childNodes.length ).to.equal( 0 );
  262. } );
  263. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  264. const viewFoo = new ViewText( 'foo' );
  265. const viewP = new ViewElement( 'p', null, viewFoo );
  266. const viewDiv = new ViewElement( 'div', null, viewP );
  267. viewRoot.appendChildren( viewDiv );
  268. renderer.markToSync( 'children', viewRoot );
  269. renderer.render();
  270. viewRoot.removeChildren( 0, 1 );
  271. renderer.markToSync( 'children', viewRoot );
  272. viewDiv.removeChildren( 0, 1 );
  273. renderer.markToSync( 'children', viewDiv );
  274. viewP.removeChildren( 0, 1 );
  275. renderer.markToSync( 'children', viewP );
  276. renderer.render();
  277. expect( domRoot.childNodes.length ).to.equal( 0 );
  278. } );
  279. it( 'should not care about filler if there is no DOM', () => {
  280. selectionEditable = null;
  281. const { view: viewP, selection: newSelection } = parse(
  282. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  283. const viewRoot = new ViewElement( 'p' );
  284. viewRoot.appendChildren( viewP );
  285. selection.setTo( newSelection );
  286. renderer.markToSync( 'children', viewRoot );
  287. renderer.render();
  288. // Expect no error on render.
  289. expect( viewRoot ).to.be.ok;
  290. } );
  291. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  292. const domSelection = document.getSelection();
  293. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  294. const { view: viewP, selection: newSelection } = parse(
  295. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  296. viewRoot.appendChildren( viewP );
  297. selection.setTo( newSelection );
  298. renderer.markToSync( 'children', viewRoot );
  299. renderer.render();
  300. expect( domRoot.childNodes.length ).to.equal( 1 );
  301. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  302. const domP = domRoot.childNodes[ 0 ];
  303. expect( domP.childNodes.length ).to.equal( 3 );
  304. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  305. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  306. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  307. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  308. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  309. expect( domSelection.rangeCount ).to.equal( 1 );
  310. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  311. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  312. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  313. // Step 2: No mutation on second render
  314. renderer.markToSync( 'children', viewRoot );
  315. renderer.markToSync( 'children', viewP );
  316. renderAndExpectNoChanges( renderer, domRoot );
  317. // Step 3: <p>foo{}<b></b></p>
  318. selection.removeAllRanges();
  319. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  320. renderer.render();
  321. expect( domP.childNodes.length ).to.equal( 3 );
  322. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  323. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  324. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  325. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  326. expect( domSelection.rangeCount ).to.equal( 1 );
  327. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  328. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  329. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  330. // Step 4: No mutation on second render
  331. renderer.markToSync( 'children', viewRoot );
  332. renderer.markToSync( 'children', viewP );
  333. renderAndExpectNoChanges( renderer, domRoot );
  334. } );
  335. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  336. const domSelection = document.getSelection();
  337. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  338. const { view: viewP, selection: newSelection } = parse(
  339. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  340. viewRoot.appendChildren( viewP );
  341. selection.setTo( newSelection );
  342. renderer.markToSync( 'children', viewRoot );
  343. renderer.render();
  344. const domP = domRoot.childNodes[ 0 ];
  345. expect( domP.childNodes.length ).to.equal( 2 );
  346. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  347. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  348. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  349. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  350. expect( domSelection.rangeCount ).to.equal( 1 );
  351. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  352. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  353. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  354. // Step 2: No mutation on second render
  355. renderer.markToSync( 'children', viewP );
  356. renderAndExpectNoChanges( renderer, domRoot );
  357. // Step 3: <p><b>{}foo</b></p>
  358. selection.removeAllRanges();
  359. selection.addRange( ViewRange.createFromParentsAndOffsets(
  360. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  361. renderer.render();
  362. expect( domP.childNodes.length ).to.equal( 1 );
  363. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  364. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  365. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  366. expect( domSelection.rangeCount ).to.equal( 1 );
  367. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  368. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  369. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  370. // Step 4: No mutation on second render
  371. renderer.markToSync( 'children', viewP );
  372. renderAndExpectNoChanges( renderer, domRoot );
  373. } );
  374. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  375. const domSelection = document.getSelection();
  376. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  377. const { view: viewP, selection: newSelection } = parse(
  378. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  379. viewRoot.appendChildren( viewP );
  380. selection.setTo( newSelection );
  381. renderer.markToSync( 'children', viewRoot );
  382. renderer.render();
  383. const domP = domRoot.childNodes[ 0 ];
  384. expect( domP.childNodes.length ).to.equal( 2 );
  385. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  386. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  387. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  389. expect( domSelection.rangeCount ).to.equal( 1 );
  390. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  391. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  392. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  393. // Step 2: No mutation on second render
  394. renderer.markToSync( 'children', viewP );
  395. renderAndExpectNoChanges( renderer, domRoot );
  396. // Step 3: <p><b>foo{}</b></p>
  397. selection.removeAllRanges();
  398. selection.addRange( ViewRange.createFromParentsAndOffsets(
  399. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  400. renderer.render();
  401. expect( domP.childNodes.length ).to.equal( 1 );
  402. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  403. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  404. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  405. expect( domSelection.rangeCount ).to.equal( 1 );
  406. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  407. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  408. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  409. // Step 4: No mutation on second render
  410. renderer.markToSync( 'children', viewP );
  411. renderAndExpectNoChanges( renderer, domRoot );
  412. } );
  413. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  414. const domSelection = document.getSelection();
  415. const { view: viewP, selection: newSelection } = parse(
  416. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  417. viewRoot.appendChildren( viewP );
  418. selection.setTo( newSelection );
  419. renderer.markToSync( 'children', viewRoot );
  420. renderer.render();
  421. const domP = domRoot.childNodes[ 0 ];
  422. expect( domP.childNodes.length ).to.equal( 3 );
  423. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  424. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  425. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  426. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  427. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  428. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  429. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  430. expect( domSelection.rangeCount ).to.equal( 1 );
  431. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  432. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  433. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  434. } );
  435. it( 'should move filler when selection is moved', () => {
  436. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  437. const { view: viewP, selection: newSelection } = parse(
  438. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  439. viewRoot.appendChildren( viewP );
  440. selection.setTo( newSelection );
  441. renderer.markToSync( 'children', viewRoot );
  442. renderer.render();
  443. const domP = domRoot.childNodes[ 0 ];
  444. expect( domP.childNodes.length ).to.equal( 3 );
  445. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  446. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  447. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  448. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  449. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  450. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  451. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  452. selection.removeAllRanges();
  453. const viewI = viewP.getChild( 2 );
  454. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  455. renderer.render();
  456. expect( domP.childNodes.length ).to.equal( 3 );
  457. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  458. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  459. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  460. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  461. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  462. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  463. } );
  464. it( 'should remove filler when text is added and selection removed', () => {
  465. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  466. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  467. const viewB = viewP.getChild( 1 );
  468. viewRoot.appendChildren( viewP );
  469. selection.setTo( newSelection );
  470. renderer.markToSync( 'children', viewRoot );
  471. renderer.render();
  472. const domP = domRoot.childNodes[ 0 ];
  473. expect( domP.childNodes.length ).to.equal( 2 );
  474. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  475. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  476. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  477. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  478. // Step 2: Add text node.
  479. const viewText = new ViewText( 'x' );
  480. viewB.appendChildren( viewText );
  481. selection.removeAllRanges();
  482. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  483. renderer.markToSync( 'children', viewB );
  484. renderer.render();
  485. // Step 3: Remove selection from the view.
  486. selection.removeAllRanges();
  487. renderer.render();
  488. expect( domP.childNodes.length ).to.equal( 2 );
  489. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  490. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  491. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  492. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  493. } );
  494. // #659
  495. // The element before the filler is removed so the position of the filler
  496. // cannot be remembered as parent+offset.
  497. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  498. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  499. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  500. viewRoot.appendChildren( viewP );
  501. selection.setTo( newSelection );
  502. renderer.markToSync( 'children', viewRoot );
  503. renderer.render();
  504. const domP = domRoot.childNodes[ 0 ];
  505. expect( domP.childNodes.length ).to.equal( 3 );
  506. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  507. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  508. viewP.removeChildren( 1 );
  509. selection.removeAllRanges();
  510. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  511. renderer.markToSync( 'children', viewP );
  512. renderer.render();
  513. // Step 3: Check whether there's no filler in the DOM.
  514. expect( domP.childNodes.length ).to.equal( 1 );
  515. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  516. } );
  517. // #659
  518. it( 'should remove filler from a modified DOM when children moved', () => {
  519. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  520. const { view: viewFragment, selection: newSelection } = parse(
  521. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  522. );
  523. viewRoot.appendChildren( viewFragment );
  524. selection.setTo( newSelection );
  525. renderer.markToSync( 'children', viewRoot );
  526. renderer.render();
  527. expect( domRoot.childNodes.length ).to.equal( 2 );
  528. const domP = domRoot.childNodes[ 0 ];
  529. const domP2 = domRoot.childNodes[ 1 ];
  530. expect( domP.childNodes.length ).to.equal( 3 );
  531. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  532. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  533. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  534. const viewP = viewRoot.getChild( 0 );
  535. const viewP2 = viewRoot.getChild( 1 );
  536. const removedChildren = viewP.removeChildren( 0, 2 );
  537. viewP2.appendChildren( removedChildren );
  538. selection.removeAllRanges();
  539. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  540. renderer.markToSync( 'children', viewP );
  541. renderer.markToSync( 'children', viewP2 );
  542. renderer.render();
  543. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  544. // in the second one there are two <b> tags.
  545. expect( domP.childNodes.length ).to.equal( 1 );
  546. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  547. expect( domP2.childNodes.length ).to.equal( 2 );
  548. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  549. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  550. } );
  551. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  552. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  553. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  554. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  555. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  556. viewRoot.appendChildren( viewP );
  557. selection.setTo( newSelection );
  558. renderer.markToSync( 'children', viewRoot );
  559. renderer.render();
  560. const domP = domRoot.childNodes[ 0 ];
  561. expect( domP.childNodes.length ).to.equal( 2 );
  562. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  563. // Step 2: Move selection to a new attribute element and remove the previous one
  564. viewP.removeChildren( 1 ); // Remove <b>.
  565. const viewI = parse( '<attribute:i></attribute:i>' );
  566. viewP.appendChildren( viewI );
  567. selection.removeAllRanges();
  568. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  569. renderer.markToSync( 'children', viewP );
  570. renderer.render();
  571. // Step 3: Check whether new filler was created in the <i> element.
  572. expect( domP.childNodes.length ).to.equal( 2 );
  573. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  574. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  575. } );
  576. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  577. // that has not been yet rendered/bound to DOM.
  578. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  579. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  580. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  581. viewRoot.appendChildren( viewP );
  582. selection.setTo( newSelection );
  583. renderer.markToSync( 'children', viewRoot );
  584. renderer.render();
  585. const domP = domRoot.childNodes[ 0 ];
  586. expect( domP.childNodes.length ).to.equal( 3 );
  587. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  588. // Step 2: Move selection to a new attribute element.
  589. const viewAbc = parse( 'abc' );
  590. viewP.appendChildren( viewAbc );
  591. selection.removeAllRanges();
  592. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  593. renderer.markToSync( 'children', viewP );
  594. renderer.render();
  595. // Step 3: Check whether old filler was removed.
  596. expect( domP.childNodes.length ).to.equal( 3 );
  597. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  598. } );
  599. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  600. const domSelection = document.getSelection();
  601. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  602. viewRoot.appendChildren( viewP );
  603. selection.setTo( newSelection );
  604. renderer.markToSync( 'children', viewRoot );
  605. renderer.render();
  606. const domP = domRoot.childNodes[ 0 ];
  607. expect( domP.childNodes.length ).to.equal( 1 );
  608. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  609. expect( domSelection.rangeCount ).to.equal( 1 );
  610. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  611. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  612. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  613. // Remove filler and add text node to both DOM and View <p>x{}</p>
  614. domP.removeChild( domP.childNodes[ 0 ] );
  615. domP.appendChild( document.createTextNode( 'x' ) );
  616. domSelection.removeAllRanges();
  617. const domRange = document.createRange();
  618. domRange.setStart( domP.childNodes[ 0 ], 1 );
  619. domRange.collapse( true );
  620. domSelection.addRange( domRange );
  621. const viewText = new ViewText( 'x' );
  622. viewP.appendChildren( viewText );
  623. selection.removeAllRanges();
  624. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  625. renderer.markToSync( 'children', viewP );
  626. renderAndExpectNoChanges( renderer, domRoot );
  627. } );
  628. it( 'should handle typing in empty block, render if needed', () => {
  629. const domSelection = document.getSelection();
  630. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  631. viewRoot.appendChildren( viewP );
  632. selection.setTo( newSelection );
  633. renderer.markToSync( 'children', viewRoot );
  634. renderer.render();
  635. const domP = domRoot.childNodes[ 0 ];
  636. expect( domP.childNodes.length ).to.equal( 1 );
  637. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  638. expect( domSelection.rangeCount ).to.equal( 1 );
  639. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  640. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  641. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  642. // Add text node only in View <p>x{}</p>
  643. const viewText = new ViewText( 'x' );
  644. viewP.appendChildren( viewText );
  645. selection.removeAllRanges();
  646. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  647. renderer.markToSync( 'children', viewP );
  648. renderer.render();
  649. expect( domP.childNodes.length ).to.equal( 1 );
  650. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  651. expect( domSelection.rangeCount ).to.equal( 1 );
  652. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  653. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  654. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  655. } );
  656. it( 'should handle removing last character', () => {
  657. const domSelection = document.getSelection();
  658. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  659. viewRoot.appendChildren( viewP );
  660. selection.setTo( newSelection );
  661. renderer.markToSync( 'children', viewRoot );
  662. renderer.render();
  663. const domP = domRoot.childNodes[ 0 ];
  664. expect( domP.childNodes.length ).to.equal( 1 );
  665. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  666. expect( domSelection.rangeCount ).to.equal( 1 );
  667. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  668. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  669. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  670. // Remove text and add filler to both DOM and View <p>{}</p>
  671. domP.removeChild( domP.childNodes[ 0 ] );
  672. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  673. domSelection.removeAllRanges();
  674. const domRange = document.createRange();
  675. domRange.setStart( domP.childNodes[ 0 ], 0 );
  676. domRange.collapse( true );
  677. domSelection.addRange( domRange );
  678. viewP.removeChildren( 0 );
  679. selection.removeAllRanges();
  680. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  681. renderer.markToSync( 'children', viewP );
  682. renderAndExpectNoChanges( renderer, domRoot );
  683. } );
  684. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  685. const domSelection = document.getSelection();
  686. // 1. Render <p><b>FILLER{}</b>foo</p>.
  687. const { view: viewP, selection: newSelection } = parse(
  688. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  689. viewRoot.appendChildren( viewP );
  690. selection.setTo( newSelection );
  691. renderer.markToSync( 'children', viewRoot );
  692. renderer.render();
  693. // 2. Check the DOM.
  694. const domP = domRoot.childNodes[ 0 ];
  695. expect( domP.childNodes.length ).to.equal( 2 );
  696. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  697. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  698. const domB = domP.childNodes[ 0 ];
  699. const viewB = viewP.getChild( 0 );
  700. expect( domB.childNodes.length ).to.equal( 1 );
  701. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  702. expect( domSelection.rangeCount ).to.equal( 1 );
  703. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  704. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  705. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  706. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  707. domB.childNodes[ 0 ].data += 'x';
  708. domSelection.removeAllRanges();
  709. const domRange = document.createRange();
  710. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  711. domRange.collapse( true );
  712. domSelection.addRange( domRange );
  713. const viewText = new ViewText( 'x' );
  714. viewB.appendChildren( viewText );
  715. selection.removeAllRanges();
  716. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  717. renderer.markToSync( 'children', viewP );
  718. renderAndExpectNoChanges( renderer, domRoot );
  719. } );
  720. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  721. const domSelection = document.getSelection();
  722. // 1. Render <p><b>FILLER{}</b>foo</p>.
  723. const { view: viewP, selection: newSelection } = parse(
  724. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  725. viewRoot.appendChildren( viewP );
  726. selection.setTo( newSelection );
  727. renderer.markToSync( 'children', viewRoot );
  728. renderer.render();
  729. // 2. Check the DOM.
  730. const domP = domRoot.childNodes[ 0 ];
  731. expect( domP.childNodes.length ).to.equal( 2 );
  732. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  733. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  734. const domB = domP.childNodes[ 0 ];
  735. const viewB = viewP.getChild( 0 );
  736. expect( domB.childNodes.length ).to.equal( 1 );
  737. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  738. expect( domSelection.rangeCount ).to.equal( 1 );
  739. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  740. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  741. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  742. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  743. const viewText = new ViewText( 'x' );
  744. viewB.appendChildren( viewText );
  745. selection.removeAllRanges();
  746. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  747. renderer.markToSync( 'children', viewB );
  748. renderer.render();
  749. expect( domB.childNodes.length ).to.equal( 1 );
  750. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  751. expect( domSelection.rangeCount ).to.equal( 1 );
  752. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  753. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  754. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  755. } );
  756. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  757. const domSelection = document.getSelection();
  758. // 1. Render <p><b>FILLER{}</b>foo</p>.
  759. const { view: viewP, selection: newSelection } = parse(
  760. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  761. viewRoot.appendChildren( viewP );
  762. selection.setTo( newSelection );
  763. renderer.markToSync( 'children', viewRoot );
  764. renderer.render();
  765. // 2. Check the DOM.
  766. const domP = domRoot.childNodes[ 0 ];
  767. expect( domP.childNodes.length ).to.equal( 2 );
  768. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  769. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  770. const domB = domP.childNodes[ 0 ];
  771. const viewB = viewP.getChild( 0 );
  772. expect( domB.childNodes.length ).to.equal( 1 );
  773. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  774. expect( domSelection.rangeCount ).to.equal( 1 );
  775. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  776. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  777. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  778. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  779. const viewText = new ViewText( 'x' );
  780. viewB.appendChildren( viewText );
  781. selection.removeAllRanges();
  782. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  783. renderer.markToSync( 'text', viewText );
  784. renderer.render();
  785. // 4. Check the DOM.
  786. expect( domB.childNodes.length ).to.equal( 1 );
  787. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  788. expect( domSelection.rangeCount ).to.equal( 1 );
  789. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  790. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  791. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  792. } );
  793. it( 'should handle not collapsed range', () => {
  794. const domSelection = document.getSelection();
  795. const { view: viewP, selection: newSelection } = parse(
  796. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  797. viewRoot.appendChildren( viewP );
  798. selection.setTo( newSelection );
  799. renderer.markToSync( 'children', viewRoot );
  800. renderer.render();
  801. const domP = domRoot.childNodes[ 0 ];
  802. expect( domP.childNodes.length ).to.equal( 2 );
  803. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  804. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  805. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  806. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  807. expect( domSelection.rangeCount ).to.equal( 1 );
  808. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  809. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  810. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  811. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  812. renderer.markToSync( 'children', viewP );
  813. renderAndExpectNoChanges( renderer, domRoot );
  814. } );
  815. it( 'should not change selection if there is no editable with selection', () => {
  816. const domDiv = createElement( document, 'div', null, 'not editable' );
  817. document.body.appendChild( domDiv );
  818. const domSelection = document.getSelection();
  819. domSelection.removeAllRanges();
  820. const domRange = document.createRange();
  821. domRange.setStart( domDiv, 0 );
  822. domRange.collapse( true );
  823. domSelection.addRange( domRange );
  824. selectionEditable = null;
  825. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  826. viewRoot.appendChildren( viewP );
  827. selection.setTo( newSelection );
  828. renderer.render();
  829. expect( domSelection.rangeCount ).to.equal( 1 );
  830. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  831. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  832. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  833. } );
  834. it( 'should not change selection if there is no focus', () => {
  835. const domDiv = createElement( document, 'div', null, 'not editable' );
  836. document.body.appendChild( domDiv );
  837. const domSelection = document.getSelection();
  838. domSelection.removeAllRanges();
  839. const domRange = document.createRange();
  840. domRange.setStart( domDiv, 0 );
  841. domRange.collapse( true );
  842. domSelection.addRange( domRange );
  843. renderer.isFocused = false;
  844. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  845. viewRoot.appendChildren( viewP );
  846. selection.setTo( newSelection );
  847. renderer.render();
  848. expect( domSelection.rangeCount ).to.equal( 1 );
  849. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  850. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  851. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  852. } );
  853. it( 'should not add inline filler after text node', () => {
  854. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  855. viewRoot.appendChildren( viewP );
  856. selection.setTo( newSelection );
  857. renderer.markToSync( 'children', viewRoot );
  858. renderer.render();
  859. const domP = domRoot.childNodes[ 0 ];
  860. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  861. } );
  862. it( 'should throw if there is no filler in expected position', () => {
  863. const { view: viewP, selection: newSelection } = parse(
  864. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  865. viewRoot.appendChildren( viewP );
  866. selection.setTo( newSelection );
  867. renderer.markToSync( 'children', viewRoot );
  868. renderer.render();
  869. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  870. const viewB = viewP.getChild( 1 );
  871. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  872. // Remove filler.
  873. domB.childNodes[ 0 ].data = '';
  874. selection.removeAllRanges();
  875. renderer.markToSync( 'children', viewB );
  876. expect( () => {
  877. renderer.render();
  878. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  879. } );
  880. it( 'should handle focusing element', () => {
  881. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  882. const editable = selection.editableElement;
  883. renderer.render();
  884. expect( editable ).to.equal( viewRoot );
  885. expect( domFocusSpy.calledOnce ).to.be.true;
  886. } );
  887. it( 'should not focus editable if isFocues is set to false', () => {
  888. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  889. renderer.isFocused = false;
  890. renderer.render();
  891. expect( domFocusSpy.calledOnce ).to.be.false;
  892. } );
  893. it( 'should not focus already focused DOM element', () => {
  894. domRoot.setAttribute( 'contentEditable', true );
  895. domRoot.focus();
  896. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  897. renderer.render();
  898. expect( domFocusSpy.called ).to.be.false;
  899. } );
  900. describe( 'fake selection', () => {
  901. beforeEach( () => {
  902. const { view: viewP, selection: newSelection } = parse(
  903. '<container:p>[foo bar]</container:p>'
  904. );
  905. viewRoot.appendChildren( viewP );
  906. selection.setTo( newSelection );
  907. renderer.markToSync( 'children', viewRoot );
  908. renderer.render();
  909. } );
  910. it( 'should render fake selection', () => {
  911. const label = 'fake selection label';
  912. selection.setFake( true, { label } );
  913. renderer.render();
  914. expect( domRoot.childNodes.length ).to.equal( 2 );
  915. const container = domRoot.childNodes[ 1 ];
  916. expect( domConverter.getCorrespondingViewElement( container ) ).to.be.undefined;
  917. expect( container.childNodes.length ).to.equal( 1 );
  918. const textNode = container.childNodes[ 0 ];
  919. expect( textNode.textContent ).to.equal( label );
  920. const domSelection = domRoot.ownerDocument.getSelection();
  921. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  922. } );
  923. it( 'should render &nbsp; if no selection label is provided', () => {
  924. selection.setFake( true );
  925. renderer.render();
  926. expect( domRoot.childNodes.length ).to.equal( 2 );
  927. const container = domRoot.childNodes[ 1 ];
  928. expect( container.childNodes.length ).to.equal( 1 );
  929. const textNode = container.childNodes[ 0 ];
  930. expect( textNode.textContent ).to.equal( '\u00A0' );
  931. const domSelection = domRoot.ownerDocument.getSelection();
  932. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  933. } );
  934. it( 'should remove fake selection container when selection is no longer fake', () => {
  935. selection.setFake( true );
  936. renderer.render();
  937. selection.setFake( false );
  938. renderer.render();
  939. expect( domRoot.childNodes.length ).to.equal( 1 );
  940. const domParagraph = domRoot.childNodes[ 0 ];
  941. expect( domParagraph.childNodes.length ).to.equal( 1 );
  942. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  943. const domSelection = domRoot.ownerDocument.getSelection();
  944. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  945. } );
  946. it( 'should reuse fake selection container #1', () => {
  947. const label = 'fake selection label';
  948. selection.setFake( true, { label } );
  949. renderer.render();
  950. expect( domRoot.childNodes.length ).to.equal( 2 );
  951. const container = domRoot.childNodes[ 1 ];
  952. selection.setFake( true, { label } );
  953. renderer.render();
  954. expect( domRoot.childNodes.length ).to.equal( 2 );
  955. const newContainer = domRoot.childNodes[ 1 ];
  956. expect( newContainer ).equals( container );
  957. expect( newContainer.childNodes.length ).to.equal( 1 );
  958. const textNode = newContainer.childNodes[ 0 ];
  959. expect( textNode.textContent ).to.equal( label );
  960. } );
  961. it( 'should reuse fake selection container #2', () => {
  962. selection.setFake( true, { label: 'label 1' } );
  963. renderer.render();
  964. expect( domRoot.childNodes.length ).to.equal( 2 );
  965. const container = domRoot.childNodes[ 1 ];
  966. selection.setFake( false );
  967. renderer.render();
  968. expect( domRoot.childNodes.length ).to.equal( 1 );
  969. selection.setFake( true, { label: 'label 2' } );
  970. renderer.render();
  971. expect( domRoot.childNodes.length ).to.equal( 2 );
  972. const newContainer = domRoot.childNodes[ 1 ];
  973. expect( newContainer ).equals( container );
  974. expect( newContainer.childNodes.length ).to.equal( 1 );
  975. const textNode = newContainer.childNodes[ 0 ];
  976. expect( textNode.textContent ).to.equal( 'label 2' );
  977. } );
  978. it( 'should reuse fake selection container #3', () => {
  979. selection.setFake( true, { label: 'label 1' } );
  980. renderer.render();
  981. expect( domRoot.childNodes.length ).to.equal( 2 );
  982. const container = domRoot.childNodes[ 1 ];
  983. selection.setFake( true, { label: 'label 2' } );
  984. renderer.render();
  985. expect( domRoot.childNodes.length ).to.equal( 2 );
  986. const newContainer = domRoot.childNodes[ 1 ];
  987. expect( newContainer ).equals( container );
  988. expect( newContainer.childNodes.length ).to.equal( 1 );
  989. const textNode = newContainer.childNodes[ 0 ];
  990. expect( textNode.textContent ).to.equal( 'label 2' );
  991. } );
  992. it( 'should style fake selection container properly', () => {
  993. selection.setFake( true, { label: 'fake selection' } );
  994. renderer.render();
  995. expect( domRoot.childNodes.length ).to.equal( 2 );
  996. const container = domRoot.childNodes[ 1 ];
  997. expect( container.style.position ).to.equal( 'fixed' );
  998. expect( container.style.top ).to.equal( '0px' );
  999. expect( container.style.left ).to.equal( '-9999px' );
  1000. } );
  1001. it( 'should bind fake selection container to view selection', () => {
  1002. selection.setFake( true, { label: 'fake selection' } );
  1003. renderer.render();
  1004. expect( domRoot.childNodes.length ).to.equal( 2 );
  1005. const container = domRoot.childNodes[ 1 ];
  1006. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1007. expect( bindSelection ).to.be.defined;
  1008. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1009. } );
  1010. // Use a forgiving way of checking what the selection contains
  1011. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1012. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1013. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1014. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1015. expect( domSelection.toString() ).to.match( expectedText );
  1016. expect(
  1017. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1018. ).to.be.true;
  1019. }
  1020. } );
  1021. // #887
  1022. describe( 'similar selection', () => {
  1023. // Use spies to check selection updates. Some selection positions are not achievable in some
  1024. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1025. let selectionCollapseSpy, selectionExtendSpy, logWarnStub;
  1026. before( () => {
  1027. logWarnStub = sinon.stub( log, 'warn' );
  1028. } );
  1029. afterEach( () => {
  1030. if ( selectionCollapseSpy ) {
  1031. selectionCollapseSpy.restore();
  1032. selectionCollapseSpy = null;
  1033. }
  1034. if ( selectionExtendSpy ) {
  1035. selectionExtendSpy.restore();
  1036. selectionExtendSpy = null;
  1037. }
  1038. logWarnStub.reset();
  1039. } );
  1040. after( () => {
  1041. logWarnStub.restore();
  1042. } );
  1043. it( 'should always render collapsed selection even if it is similar', () => {
  1044. const domSelection = document.getSelection();
  1045. const { view: viewP, selection: newSelection } = parse(
  1046. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1047. viewRoot.appendChildren( viewP );
  1048. selection.setTo( newSelection );
  1049. renderer.markToSync( 'children', viewRoot );
  1050. renderer.render();
  1051. const domP = domRoot.childNodes[ 0 ];
  1052. const domB = domP.childNodes[ 1 ];
  1053. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1054. expect( domSelection.isCollapsed ).to.true;
  1055. expect( domSelection.rangeCount ).to.equal( 1 );
  1056. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1057. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1058. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1059. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1060. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1061. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1062. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1063. selection.setRanges( [
  1064. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1065. ] );
  1066. renderer.markToSync( 'children', viewP );
  1067. renderer.render();
  1068. expect( selectionCollapseSpy.calledOnce ).to.true;
  1069. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1070. expect( selectionExtendSpy.calledOnce ).to.true;
  1071. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1072. expect( logWarnStub.notCalled ).to.true;
  1073. } );
  1074. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1075. const domSelection = document.getSelection();
  1076. const { view: viewP, selection: newSelection } = parse(
  1077. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1078. viewRoot.appendChildren( viewP );
  1079. selection.setTo( newSelection );
  1080. renderer.markToSync( 'children', viewRoot );
  1081. renderer.render();
  1082. const domP = domRoot.childNodes[ 0 ];
  1083. const domB = domP.childNodes[ 1 ];
  1084. expect( domSelection.isCollapsed ).to.true;
  1085. expect( domSelection.rangeCount ).to.equal( 1 );
  1086. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1087. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1088. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1089. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1090. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1091. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1092. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1093. selection.setRanges( [
  1094. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1095. ] );
  1096. renderer.markToSync( 'children', viewP );
  1097. renderer.render();
  1098. expect( selectionCollapseSpy.calledOnce ).to.true;
  1099. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1100. expect( selectionExtendSpy.calledOnce ).to.true;
  1101. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1102. expect( logWarnStub.notCalled ).to.true;
  1103. } );
  1104. it( 'should always render non-collapsed selection if it not is similar', () => {
  1105. const domSelection = document.getSelection();
  1106. const { view: viewP, selection: newSelection } = parse(
  1107. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1108. viewRoot.appendChildren( viewP );
  1109. selection.setTo( newSelection );
  1110. renderer.markToSync( 'children', viewRoot );
  1111. renderer.render();
  1112. const domP = domRoot.childNodes[ 0 ];
  1113. const domB = domP.childNodes[ 1 ];
  1114. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1115. expect( domSelection.isCollapsed ).to.false;
  1116. expect( domSelection.rangeCount ).to.equal( 1 );
  1117. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1118. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1119. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1120. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1121. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1122. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1123. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1124. selection.setRanges( [
  1125. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1126. ] );
  1127. renderer.markToSync( 'children', viewP );
  1128. renderer.render();
  1129. expect( selectionCollapseSpy.calledOnce ).to.true;
  1130. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1131. expect( selectionExtendSpy.calledOnce ).to.true;
  1132. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1133. expect( logWarnStub.notCalled ).to.true;
  1134. } );
  1135. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1136. const domSelection = document.getSelection();
  1137. const { view: viewP, selection: newSelection } = parse(
  1138. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1139. viewRoot.appendChildren( viewP );
  1140. selection.setTo( newSelection );
  1141. renderer.markToSync( 'children', viewRoot );
  1142. renderer.render();
  1143. const domP = domRoot.childNodes[ 0 ];
  1144. const domB = domP.childNodes[ 1 ];
  1145. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1146. expect( domSelection.isCollapsed ).to.false;
  1147. expect( domSelection.rangeCount ).to.equal( 1 );
  1148. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1149. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1150. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1151. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1152. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1153. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1154. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1155. selection.setRanges( [
  1156. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1157. ] );
  1158. renderer.markToSync( 'children', viewP );
  1159. renderer.render();
  1160. expect( selectionCollapseSpy.notCalled ).to.true;
  1161. expect( selectionExtendSpy.notCalled ).to.true;
  1162. expect( logWarnStub.called ).to.true;
  1163. } );
  1164. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1165. const domSelection = document.getSelection();
  1166. const { view: viewP, selection: newSelection } = parse(
  1167. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1168. viewRoot.appendChildren( viewP );
  1169. selection.setTo( newSelection );
  1170. renderer.markToSync( 'children', viewRoot );
  1171. renderer.render();
  1172. const domP = domRoot.childNodes[ 0 ];
  1173. const domB = domP.childNodes[ 1 ];
  1174. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1175. expect( domSelection.isCollapsed ).to.false;
  1176. expect( domSelection.rangeCount ).to.equal( 1 );
  1177. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1178. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1179. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1180. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1181. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1182. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1183. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1184. selection.setRanges( [
  1185. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1186. ] );
  1187. renderer.markToSync( 'children', viewP );
  1188. renderer.render();
  1189. expect( selectionCollapseSpy.notCalled ).to.true;
  1190. expect( selectionExtendSpy.notCalled ).to.true;
  1191. expect( logWarnStub.called ).to.true;
  1192. } );
  1193. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1194. const domSelection = document.getSelection();
  1195. const { view: viewP, selection: newSelection } = parse(
  1196. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1197. viewRoot.appendChildren( viewP );
  1198. selection.setTo( newSelection );
  1199. renderer.markToSync( 'children', viewRoot );
  1200. renderer.render();
  1201. const domP = domRoot.childNodes[ 0 ];
  1202. const domB = domP.childNodes[ 1 ];
  1203. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1204. expect( domSelection.isCollapsed ).to.false;
  1205. expect( domSelection.rangeCount ).to.equal( 1 );
  1206. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1207. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1208. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1209. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1210. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1211. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1212. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1213. selection.setRanges( [
  1214. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1215. ] );
  1216. renderer.markToSync( 'children', viewP );
  1217. renderer.render();
  1218. expect( selectionCollapseSpy.notCalled ).to.true;
  1219. expect( selectionExtendSpy.notCalled ).to.true;
  1220. expect( logWarnStub.called ).to.true;
  1221. } );
  1222. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1223. const domSelection = document.getSelection();
  1224. const { view: viewP, selection: newSelection } = parse(
  1225. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1226. viewRoot.appendChildren( viewP );
  1227. selection.setTo( newSelection );
  1228. renderer.markToSync( 'children', viewRoot );
  1229. renderer.render();
  1230. const domP = domRoot.childNodes[ 0 ];
  1231. const domB = domP.childNodes[ 1 ];
  1232. expect( domSelection.isCollapsed ).to.false;
  1233. expect( domSelection.rangeCount ).to.equal( 1 );
  1234. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1235. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1236. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1237. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1238. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1239. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1240. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1241. selection.setRanges( [
  1242. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1243. ] );
  1244. renderer.markToSync( 'children', viewP );
  1245. renderer.render();
  1246. expect( selectionCollapseSpy.notCalled ).to.true;
  1247. expect( selectionExtendSpy.notCalled ).to.true;
  1248. expect( logWarnStub.called ).to.true;
  1249. } );
  1250. } );
  1251. } );
  1252. } );
  1253. function renderAndExpectNoChanges( renderer, domRoot ) {
  1254. const config = {
  1255. childList: true,
  1256. characterData: true,
  1257. characterDataOldValue: true,
  1258. subtree: true
  1259. };
  1260. const mutationObserver = new window.MutationObserver( () => {
  1261. throw 'There should be not mutations';
  1262. } );
  1263. mutationObserver.observe( domRoot, config );
  1264. renderer.render();
  1265. const records = mutationObserver.takeRecords();
  1266. mutationObserver.disconnect();
  1267. expect( records.length ).to.equal( 0 );
  1268. }