renderer.js 80 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewContainerElement from '../../src/view/containerelement';
  9. import ViewAttributeElement from '../../src/view/attributeelement';
  10. import ViewText from '../../src/view/text';
  11. import ViewRange from '../../src/view/range';
  12. import ViewPosition from '../../src/view/position';
  13. import DocumentSelection from '../../src/view/documentselection';
  14. import DomConverter from '../../src/view/domconverter';
  15. import Renderer from '../../src/view/renderer';
  16. import DocumentFragment from '../../src/view/documentfragment';
  17. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  18. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  19. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  20. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  21. import createViewRoot from './_utils/createroot';
  22. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  23. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  24. testUtils.createSinonSandbox();
  25. describe( 'Renderer', () => {
  26. let selection, domConverter, renderer;
  27. beforeEach( () => {
  28. selection = new DocumentSelection();
  29. domConverter = new DomConverter();
  30. renderer = new Renderer( domConverter, selection );
  31. renderer.domDocuments.add( document );
  32. } );
  33. describe( 'markToSync', () => {
  34. let viewRoot;
  35. beforeEach( () => {
  36. viewRoot = new ViewElement( 'p' );
  37. const domRoot = document.createElement( 'p' );
  38. domConverter.bindElements( domRoot, viewRoot );
  39. viewRoot._appendChildren( new ViewText( 'foo' ) );
  40. renderer.markedTexts.clear();
  41. renderer.markedAttributes.clear();
  42. renderer.markedChildren.clear();
  43. } );
  44. it( 'should mark attributes which need update', () => {
  45. viewRoot._setAttribute( 'class', 'foo' );
  46. renderer.markToSync( 'attributes', viewRoot );
  47. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  48. } );
  49. it( 'should mark children which need update', () => {
  50. viewRoot._appendChildren( new ViewText( 'foo' ) );
  51. renderer.markToSync( 'children', viewRoot );
  52. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  53. } );
  54. it( 'should not mark children if element has no corresponding node', () => {
  55. // Overwrite viewRoot with node without coresponding DOM node.
  56. viewRoot = new ViewElement( 'p' );
  57. viewRoot._appendChildren( new ViewText( 'foo' ) );
  58. renderer.markToSync( 'children', viewRoot );
  59. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  60. } );
  61. it( 'should mark text which need update', () => {
  62. const viewText = new ViewText( 'foo' );
  63. viewRoot._appendChildren( viewText );
  64. viewText._data = 'bar';
  65. renderer.markToSync( 'text', viewText );
  66. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  67. } );
  68. it( 'should not mark text if parent has no corresponding node', () => {
  69. const viewText = new ViewText( 'foo' );
  70. // Overwrite viewRoot with node without coresponding DOM node.
  71. viewRoot = new ViewElement( 'p' );
  72. viewRoot._appendChildren( viewText );
  73. viewText._data = 'bar';
  74. renderer.markToSync( 'text', viewText );
  75. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  76. } );
  77. it( 'should throw if the type is unknown', () => {
  78. expect( () => {
  79. renderer.markToSync( 'UNKNOWN', viewRoot );
  80. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  81. } );
  82. } );
  83. describe( 'render', () => {
  84. let viewRoot, domRoot, selectionEditable;
  85. beforeEach( () => {
  86. viewRoot = new ViewElement( 'div' );
  87. domRoot = document.createElement( 'div' );
  88. document.body.appendChild( domRoot );
  89. domConverter.bindElements( domRoot, viewRoot );
  90. renderer.markedTexts.clear();
  91. renderer.markedAttributes.clear();
  92. renderer.markedChildren.clear();
  93. selection._setTo( null );
  94. selectionEditable = viewRoot;
  95. renderer.isFocused = true;
  96. // Fake selection editable - it is needed to render selection properly.
  97. Object.defineProperty( selection, 'editableElement', {
  98. get() {
  99. return selectionEditable;
  100. }
  101. } );
  102. } );
  103. afterEach( () => {
  104. domRoot.remove();
  105. } );
  106. it( 'should update attributes', () => {
  107. viewRoot._setAttribute( 'class', 'foo' );
  108. renderer.markToSync( 'attributes', viewRoot );
  109. renderer.render();
  110. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  111. expect( renderer.markedAttributes.size ).to.equal( 0 );
  112. } );
  113. it( 'should remove attributes', () => {
  114. viewRoot._setAttribute( 'class', 'foo' );
  115. domRoot.setAttribute( 'id', 'bar' );
  116. domRoot.setAttribute( 'class', 'bar' );
  117. renderer.markToSync( 'attributes', viewRoot );
  118. renderer.render();
  119. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  120. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  121. expect( renderer.markedAttributes.size ).to.equal( 0 );
  122. } );
  123. it( 'should add children', () => {
  124. viewRoot._appendChildren( new ViewText( 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. expect( renderer.markedChildren.size ).to.equal( 0 );
  130. } );
  131. it( 'should remove children', () => {
  132. viewRoot._appendChildren( new ViewText( 'foo' ) );
  133. renderer.markToSync( 'children', viewRoot );
  134. renderer.render();
  135. expect( domRoot.childNodes.length ).to.equal( 1 );
  136. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  137. viewRoot._removeChildren( 0, 1 );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 0 );
  141. expect( renderer.markedChildren.size ).to.equal( 0 );
  142. } );
  143. it( 'should update text', () => {
  144. const viewText = new ViewText( 'foo' );
  145. viewRoot._appendChildren( viewText );
  146. renderer.markToSync( 'children', viewRoot );
  147. renderer.render();
  148. expect( domRoot.childNodes.length ).to.equal( 1 );
  149. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  150. viewText._data = 'bar';
  151. renderer.markToSync( 'text', viewText );
  152. renderer.render();
  153. expect( domRoot.childNodes.length ).to.equal( 1 );
  154. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  155. expect( renderer.markedTexts.size ).to.equal( 0 );
  156. } );
  157. it( 'should not update text parent child list changed', () => {
  158. const viewImg = new ViewElement( 'img' );
  159. const viewText = new ViewText( 'foo' );
  160. viewRoot._appendChildren( [ viewImg, viewText ] );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.markToSync( 'text', viewText );
  163. renderer.render();
  164. expect( domRoot.childNodes.length ).to.equal( 2 );
  165. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  166. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  167. } );
  168. it( 'should not change text if it is the same during text rendering', () => {
  169. const viewText = new ViewText( 'foo' );
  170. viewRoot._appendChildren( viewText );
  171. renderer.markToSync( 'children', viewRoot );
  172. renderer.render();
  173. // This should not be changed during the render.
  174. const domText = domRoot.childNodes[ 0 ];
  175. renderer.markToSync( 'text', viewText );
  176. renderer.render();
  177. expect( domRoot.childNodes.length ).to.equal( 1 );
  178. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  179. } );
  180. it( 'should not change text if it is the same during children rendering', () => {
  181. const viewText = new ViewText( 'foo' );
  182. viewRoot._appendChildren( viewText );
  183. renderer.markToSync( 'children', viewRoot );
  184. renderer.render();
  185. // This should not be changed during the render.
  186. const domText = domRoot.childNodes[ 0 ];
  187. renderer.markToSync( 'children', viewRoot );
  188. renderer.render();
  189. expect( domRoot.childNodes.length ).to.equal( 1 );
  190. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  191. } );
  192. it( 'should not change element if it is the same', () => {
  193. const viewImg = new ViewElement( 'img' );
  194. viewRoot._appendChildren( viewImg );
  195. // This should not be changed during the render.
  196. const domImg = document.createElement( 'img' );
  197. domRoot.appendChild( domImg );
  198. domConverter.bindElements( domImg, viewImg );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. expect( domRoot.childNodes.length ).to.equal( 1 );
  202. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  203. } );
  204. it( 'should change element if it is different', () => {
  205. const viewImg = new ViewElement( 'img' );
  206. viewRoot._appendChildren( viewImg );
  207. renderer.markToSync( 'children', viewRoot );
  208. renderer.render();
  209. const viewP = new ViewElement( 'p' );
  210. viewRoot._removeChildren( 0, 1 );
  211. viewRoot._appendChildren( viewP );
  212. renderer.markToSync( 'children', viewRoot );
  213. renderer.render();
  214. expect( domRoot.childNodes.length ).to.equal( 1 );
  215. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  216. } );
  217. it( 'should update removed item when it is reinserted', () => {
  218. const viewFoo = new ViewText( 'foo' );
  219. const viewP = new ViewElement( 'p', null, viewFoo );
  220. const viewDiv = new ViewElement( 'div', null, viewP );
  221. viewRoot._appendChildren( viewDiv );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. viewDiv._removeChildren( 0, 1 );
  225. renderer.markToSync( 'children', viewDiv );
  226. renderer.render();
  227. viewP._removeChildren( 0, 1 );
  228. viewDiv._appendChildren( viewP );
  229. renderer.markToSync( 'children', viewDiv );
  230. renderer.render();
  231. expect( domRoot.childNodes.length ).to.equal( 1 );
  232. const domDiv = domRoot.childNodes[ 0 ];
  233. expect( domDiv.tagName ).to.equal( 'DIV' );
  234. expect( domDiv.childNodes.length ).to.equal( 1 );
  235. const domP = domDiv.childNodes[ 0 ];
  236. expect( domP.tagName ).to.equal( 'P' );
  237. expect( domP.childNodes.length ).to.equal( 0 );
  238. } );
  239. it( 'should update removed item when it is reinserted #2', () => {
  240. // Prepare view: root -> div "outer" -> div "inner" -> p.
  241. const viewP = new ViewElement( 'p' );
  242. const viewDivInner = new ViewElement( 'div', null, viewP );
  243. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  244. viewRoot._appendChildren( viewDivOuter );
  245. // Render view tree to DOM.
  246. renderer.markToSync( 'children', viewRoot );
  247. renderer.render();
  248. // Remove div "outer" from root and render it.
  249. viewDivOuter._remove();
  250. renderer.markToSync( 'children', viewRoot );
  251. renderer.render();
  252. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  253. viewP._remove();
  254. // Add div "outer" back to root.
  255. viewRoot._appendChildren( viewDivOuter );
  256. renderer.markToSync( 'children', viewRoot );
  257. // Render changes, view is: root -> div "outer" -> div "inner".
  258. renderer.render();
  259. // Same is expected in DOM.
  260. expect( domRoot.childNodes.length ).to.equal( 1 );
  261. const domDivOuter = domRoot.childNodes[ 0 ];
  262. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  263. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  264. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  265. const domDivInner = domDivOuter.childNodes[ 0 ];
  266. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  267. expect( domDivInner.tagName ).to.equal( 'DIV' );
  268. expect( domDivInner.childNodes.length ).to.equal( 0 );
  269. } );
  270. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  271. const viewFoo = new ViewText( 'foo' );
  272. const viewP = new ViewElement( 'p', null, viewFoo );
  273. const viewDiv = new ViewElement( 'div', null, viewP );
  274. viewRoot._appendChildren( viewDiv );
  275. renderer.markToSync( 'children', viewRoot );
  276. renderer.render();
  277. viewRoot._removeChildren( 0, 1 );
  278. renderer.markToSync( 'children', viewRoot );
  279. viewDiv._removeChildren( 0, 1 );
  280. renderer.markToSync( 'children', viewDiv );
  281. viewP._removeChildren( 0, 1 );
  282. renderer.markToSync( 'children', viewP );
  283. renderer.render();
  284. expect( domRoot.childNodes.length ).to.equal( 0 );
  285. } );
  286. it( 'should not care about filler if there is no DOM', () => {
  287. selectionEditable = null;
  288. const { view: viewP, selection: newSelection } = parse(
  289. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  290. const viewRoot = new ViewElement( 'p' );
  291. viewRoot._appendChildren( viewP );
  292. selection._setTo( newSelection );
  293. renderer.markToSync( 'children', viewRoot );
  294. renderer.render();
  295. // Expect no error on render.
  296. expect( viewRoot ).to.be.ok;
  297. } );
  298. it( 'should not add filler when inside contenteditable=false parent', () => {
  299. const { view: viewP, selection: newSelection } = parse(
  300. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  301. viewRoot._appendChildren( viewP );
  302. selection._setTo( newSelection );
  303. renderer.markToSync( 'children', viewRoot );
  304. renderer.render();
  305. expect( domRoot.childNodes.length ).to.equal( 1 );
  306. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  307. const domP = domRoot.childNodes[ 0 ];
  308. expect( domP.childNodes.length ).to.equal( 3 );
  309. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  310. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  311. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  312. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  313. } );
  314. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  315. const { view: viewP, selection: newSelection } = parse(
  316. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  317. viewRoot._appendChildren( viewP );
  318. selection._setTo( newSelection );
  319. renderer.markToSync( 'children', viewRoot );
  320. renderer.render();
  321. expect( domRoot.childNodes.length ).to.equal( 1 );
  322. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  323. const domP = domRoot.childNodes[ 0 ];
  324. expect( domP.childNodes.length ).to.equal( 3 );
  325. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  326. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  327. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  328. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  329. } );
  330. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  331. const domSelection = document.getSelection();
  332. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  333. const { view: viewP, selection: newSelection } = parse(
  334. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  335. viewRoot._appendChildren( viewP );
  336. selection._setTo( newSelection );
  337. renderer.markToSync( 'children', viewRoot );
  338. renderer.render();
  339. expect( domRoot.childNodes.length ).to.equal( 1 );
  340. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  341. const domP = domRoot.childNodes[ 0 ];
  342. expect( domP.childNodes.length ).to.equal( 3 );
  343. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  344. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  345. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  346. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  347. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  348. expect( domSelection.rangeCount ).to.equal( 1 );
  349. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  350. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  351. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  352. // Step 2: No mutation on second render
  353. renderer.markToSync( 'children', viewRoot );
  354. renderer.markToSync( 'children', viewP );
  355. renderAndExpectNoChanges( renderer, domRoot );
  356. // Step 3: <p>foo{}<b></b></p>
  357. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  358. renderer.render();
  359. expect( domP.childNodes.length ).to.equal( 3 );
  360. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  361. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  362. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  363. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  364. expect( domSelection.rangeCount ).to.equal( 1 );
  365. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  366. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  367. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  368. // Step 4: No mutation on second render
  369. renderer.markToSync( 'children', viewRoot );
  370. renderer.markToSync( 'children', viewP );
  371. renderAndExpectNoChanges( renderer, domRoot );
  372. } );
  373. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  374. const domSelection = document.getSelection();
  375. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  376. const { view: viewP, selection: newSelection } = parse(
  377. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  378. viewRoot._appendChildren( viewP );
  379. selection._setTo( newSelection );
  380. renderer.markToSync( 'children', viewRoot );
  381. renderer.render();
  382. const domP = domRoot.childNodes[ 0 ];
  383. expect( domP.childNodes.length ).to.equal( 2 );
  384. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  385. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  386. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  387. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domSelection.rangeCount ).to.equal( 1 );
  389. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  390. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  391. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  392. // Step 2: No mutation on second render
  393. renderer.markToSync( 'children', viewP );
  394. renderAndExpectNoChanges( renderer, domRoot );
  395. // Step 3: <p><b>{}foo</b></p>
  396. selection._setTo( ViewRange.createFromParentsAndOffsets(
  397. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  398. renderer.render();
  399. expect( domP.childNodes.length ).to.equal( 1 );
  400. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  401. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  402. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  403. expect( domSelection.rangeCount ).to.equal( 1 );
  404. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  405. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  406. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  407. // Step 4: No mutation on second render
  408. renderer.markToSync( 'children', viewP );
  409. renderAndExpectNoChanges( renderer, domRoot );
  410. } );
  411. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  412. const domSelection = document.getSelection();
  413. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  414. const { view: viewP, selection: newSelection } = parse(
  415. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  416. viewRoot._appendChildren( viewP );
  417. selection._setTo( newSelection );
  418. renderer.markToSync( 'children', viewRoot );
  419. renderer.render();
  420. const domP = domRoot.childNodes[ 0 ];
  421. expect( domP.childNodes.length ).to.equal( 2 );
  422. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  423. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  424. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  425. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  426. expect( domSelection.rangeCount ).to.equal( 1 );
  427. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  428. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  429. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  430. // Step 2: No mutation on second render
  431. renderer.markToSync( 'children', viewP );
  432. renderAndExpectNoChanges( renderer, domRoot );
  433. // Step 3: <p><b>foo{}</b></p>
  434. selection._setTo( ViewRange.createFromParentsAndOffsets(
  435. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  436. renderer.render();
  437. expect( domP.childNodes.length ).to.equal( 1 );
  438. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  439. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  440. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  441. expect( domSelection.rangeCount ).to.equal( 1 );
  442. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  443. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  444. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  445. // Step 4: No mutation on second render
  446. renderer.markToSync( 'children', viewP );
  447. renderAndExpectNoChanges( renderer, domRoot );
  448. } );
  449. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  450. const domSelection = document.getSelection();
  451. const { view: viewP, selection: newSelection } = parse(
  452. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  453. viewRoot._appendChildren( viewP );
  454. selection._setTo( newSelection );
  455. renderer.markToSync( 'children', viewRoot );
  456. renderer.render();
  457. const domP = domRoot.childNodes[ 0 ];
  458. expect( domP.childNodes.length ).to.equal( 3 );
  459. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  460. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  461. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  462. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  463. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  464. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  465. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  466. expect( domSelection.rangeCount ).to.equal( 1 );
  467. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  468. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  469. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  470. } );
  471. it( 'should move filler when selection is moved', () => {
  472. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  473. const { view: viewP, selection: newSelection } = parse(
  474. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  475. viewRoot._appendChildren( viewP );
  476. selection._setTo( newSelection );
  477. renderer.markToSync( 'children', viewRoot );
  478. renderer.render();
  479. const domP = domRoot.childNodes[ 0 ];
  480. expect( domP.childNodes.length ).to.equal( 3 );
  481. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  482. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  483. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  484. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  485. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  486. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  487. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  488. const viewI = viewP.getChild( 2 );
  489. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  490. renderer.render();
  491. expect( domP.childNodes.length ).to.equal( 3 );
  492. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  493. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  494. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  495. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  496. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  497. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  498. } );
  499. it( 'should remove filler when text is added and selection removed', () => {
  500. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  501. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  502. const viewB = viewP.getChild( 1 );
  503. viewRoot._appendChildren( viewP );
  504. selection._setTo( newSelection );
  505. renderer.markToSync( 'children', viewRoot );
  506. renderer.render();
  507. const domP = domRoot.childNodes[ 0 ];
  508. expect( domP.childNodes.length ).to.equal( 2 );
  509. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  510. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  511. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  512. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  513. // Step 2: Add text node.
  514. const viewText = new ViewText( 'x' );
  515. viewB._appendChildren( viewText );
  516. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  517. renderer.markToSync( 'children', viewB );
  518. renderer.render();
  519. // Step 3: Remove selection from the view.
  520. selection._setTo( null );
  521. renderer.render();
  522. expect( domP.childNodes.length ).to.equal( 2 );
  523. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  524. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  525. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  526. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  527. } );
  528. // #659
  529. // The element before the filler is removed so the position of the filler
  530. // cannot be remembered as parent+offset.
  531. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  532. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  533. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  534. viewRoot._appendChildren( viewP );
  535. selection._setTo( newSelection );
  536. renderer.markToSync( 'children', viewRoot );
  537. renderer.render();
  538. const domP = domRoot.childNodes[ 0 ];
  539. expect( domP.childNodes.length ).to.equal( 3 );
  540. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  541. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  542. viewP._removeChildren( 1 );
  543. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  544. renderer.markToSync( 'children', viewP );
  545. renderer.render();
  546. // Step 3: Check whether there's no filler in the DOM.
  547. expect( domP.childNodes.length ).to.equal( 1 );
  548. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  549. } );
  550. // #659
  551. it( 'should remove filler from a modified DOM when children moved', () => {
  552. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  553. const { view: viewFragment, selection: newSelection } = parse(
  554. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  555. );
  556. viewRoot._appendChildren( viewFragment );
  557. selection._setTo( newSelection );
  558. renderer.markToSync( 'children', viewRoot );
  559. renderer.render();
  560. expect( domRoot.childNodes.length ).to.equal( 2 );
  561. const domP = domRoot.childNodes[ 0 ];
  562. const domP2 = domRoot.childNodes[ 1 ];
  563. expect( domP.childNodes.length ).to.equal( 3 );
  564. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  565. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  566. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  567. const viewP = viewRoot.getChild( 0 );
  568. const viewP2 = viewRoot.getChild( 1 );
  569. const removedChildren = viewP._removeChildren( 0, 2 );
  570. viewP2._appendChildren( removedChildren );
  571. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  572. renderer.markToSync( 'children', viewP );
  573. renderer.markToSync( 'children', viewP2 );
  574. renderer.render();
  575. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  576. // in the second one there are two <b> tags.
  577. expect( domP.childNodes.length ).to.equal( 1 );
  578. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  579. expect( domP2.childNodes.length ).to.equal( 2 );
  580. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  581. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  582. } );
  583. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  584. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  585. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  586. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  587. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  588. viewRoot._appendChildren( viewP );
  589. selection._setTo( newSelection );
  590. renderer.markToSync( 'children', viewRoot );
  591. renderer.render();
  592. const domP = domRoot.childNodes[ 0 ];
  593. expect( domP.childNodes.length ).to.equal( 2 );
  594. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  595. // Step 2: Move selection to a new attribute element and remove the previous one
  596. viewP._removeChildren( 1 ); // Remove <b>.
  597. const viewI = parse( '<attribute:i></attribute:i>' );
  598. viewP._appendChildren( viewI );
  599. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  600. renderer.markToSync( 'children', viewP );
  601. renderer.render();
  602. // Step 3: Check whether new filler was created in the <i> element.
  603. expect( domP.childNodes.length ).to.equal( 2 );
  604. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  605. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  606. } );
  607. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  608. // that has not been yet rendered/bound to DOM.
  609. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  610. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  611. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  612. viewRoot._appendChildren( viewP );
  613. selection._setTo( newSelection );
  614. renderer.markToSync( 'children', viewRoot );
  615. renderer.render();
  616. const domP = domRoot.childNodes[ 0 ];
  617. expect( domP.childNodes.length ).to.equal( 3 );
  618. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  619. // Step 2: Move selection to a new attribute element.
  620. const viewAbc = parse( 'abc' );
  621. viewP._appendChildren( viewAbc );
  622. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  623. renderer.markToSync( 'children', viewP );
  624. renderer.render();
  625. // Step 3: Check whether old filler was removed.
  626. expect( domP.childNodes.length ).to.equal( 3 );
  627. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  628. } );
  629. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  630. const domSelection = document.getSelection();
  631. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  632. viewRoot._appendChildren( viewP );
  633. selection._setTo( newSelection );
  634. renderer.markToSync( 'children', viewRoot );
  635. renderer.render();
  636. const domP = domRoot.childNodes[ 0 ];
  637. expect( domP.childNodes.length ).to.equal( 1 );
  638. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  639. expect( domSelection.rangeCount ).to.equal( 1 );
  640. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  641. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  642. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  643. // Remove filler and add text node to both DOM and View <p>x{}</p>
  644. domP.removeChild( domP.childNodes[ 0 ] );
  645. domP.appendChild( document.createTextNode( 'x' ) );
  646. domSelection.removeAllRanges();
  647. const domRange = document.createRange();
  648. domRange.setStart( domP.childNodes[ 0 ], 1 );
  649. domRange.collapse( true );
  650. domSelection.addRange( domRange );
  651. const viewText = new ViewText( 'x' );
  652. viewP._appendChildren( viewText );
  653. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  654. renderer.markToSync( 'children', viewP );
  655. renderAndExpectNoChanges( renderer, domRoot );
  656. } );
  657. it( 'should handle typing in empty block, render if needed', () => {
  658. const domSelection = document.getSelection();
  659. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  660. viewRoot._appendChildren( viewP );
  661. selection._setTo( newSelection );
  662. renderer.markToSync( 'children', viewRoot );
  663. renderer.render();
  664. const domP = domRoot.childNodes[ 0 ];
  665. expect( domP.childNodes.length ).to.equal( 1 );
  666. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  667. expect( domSelection.rangeCount ).to.equal( 1 );
  668. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  669. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  670. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  671. // Add text node only in View <p>x{}</p>
  672. const viewText = new ViewText( 'x' );
  673. viewP._appendChildren( viewText );
  674. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  675. renderer.markToSync( 'children', viewP );
  676. renderer.render();
  677. expect( domP.childNodes.length ).to.equal( 1 );
  678. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  679. expect( domSelection.rangeCount ).to.equal( 1 );
  680. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  681. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  682. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  683. } );
  684. it( 'should handle removing last character', () => {
  685. const domSelection = document.getSelection();
  686. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  687. viewRoot._appendChildren( viewP );
  688. selection._setTo( newSelection );
  689. renderer.markToSync( 'children', viewRoot );
  690. renderer.render();
  691. const domP = domRoot.childNodes[ 0 ];
  692. expect( domP.childNodes.length ).to.equal( 1 );
  693. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  694. expect( domSelection.rangeCount ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  696. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  697. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  698. // Remove text and add filler to both DOM and View <p>{}</p>
  699. domP.removeChild( domP.childNodes[ 0 ] );
  700. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  701. domSelection.removeAllRanges();
  702. const domRange = document.createRange();
  703. domRange.setStart( domP.childNodes[ 0 ], 0 );
  704. domRange.collapse( true );
  705. domSelection.addRange( domRange );
  706. viewP._removeChildren( 0 );
  707. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  708. renderer.markToSync( 'children', viewP );
  709. renderAndExpectNoChanges( renderer, domRoot );
  710. } );
  711. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  712. const domSelection = document.getSelection();
  713. // 1. Render <p><b>FILLER{}</b>foo</p>.
  714. const { view: viewP, selection: newSelection } = parse(
  715. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  716. viewRoot._appendChildren( viewP );
  717. selection._setTo( newSelection );
  718. renderer.markToSync( 'children', viewRoot );
  719. renderer.render();
  720. // 2. Check the DOM.
  721. const domP = domRoot.childNodes[ 0 ];
  722. expect( domP.childNodes.length ).to.equal( 2 );
  723. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  724. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  725. const domB = domP.childNodes[ 0 ];
  726. const viewB = viewP.getChild( 0 );
  727. expect( domB.childNodes.length ).to.equal( 1 );
  728. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  729. expect( domSelection.rangeCount ).to.equal( 1 );
  730. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  731. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  732. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  733. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  734. domB.childNodes[ 0 ].data += 'x';
  735. domSelection.removeAllRanges();
  736. const domRange = document.createRange();
  737. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  738. domRange.collapse( true );
  739. domSelection.addRange( domRange );
  740. const viewText = new ViewText( 'x' );
  741. viewB._appendChildren( viewText );
  742. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  743. renderer.markToSync( 'children', viewP );
  744. renderAndExpectNoChanges( renderer, domRoot );
  745. } );
  746. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  747. const domSelection = document.getSelection();
  748. // 1. Render <p><b>FILLER{}</b>foo</p>.
  749. const { view: viewP, selection: newSelection } = parse(
  750. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  751. viewRoot._appendChildren( viewP );
  752. selection._setTo( newSelection );
  753. renderer.markToSync( 'children', viewRoot );
  754. renderer.render();
  755. // 2. Check the DOM.
  756. const domP = domRoot.childNodes[ 0 ];
  757. expect( domP.childNodes.length ).to.equal( 2 );
  758. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  759. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  760. const domB = domP.childNodes[ 0 ];
  761. const viewB = viewP.getChild( 0 );
  762. expect( domB.childNodes.length ).to.equal( 1 );
  763. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  764. expect( domSelection.rangeCount ).to.equal( 1 );
  765. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  766. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  767. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  768. domSelection.removeAllRanges();
  769. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  770. const viewText = new ViewText( 'x' );
  771. viewB._appendChildren( viewText );
  772. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  773. renderer.markToSync( 'children', viewB );
  774. renderer.render();
  775. expect( domB.childNodes.length ).to.equal( 1 );
  776. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  777. expect( domSelection.rangeCount ).to.equal( 1 );
  778. // Depending on the browser selection may end up at the end of the text node or after the text node.
  779. const firstRange = domSelection.getRangeAt( 0 );
  780. const assertSelectionAtEndOfTextNode = () => {
  781. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  782. };
  783. const assertSelectionInsideTextNode = () => {
  784. expect( firstRange.startContainer ).to.equal( domB );
  785. expect( firstRange.startOffset ).to.equal( 1 );
  786. };
  787. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  788. expect( firstRange.collapsed ).to.be.true;
  789. } );
  790. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  791. const domSelection = document.getSelection();
  792. // 1. Render <p><b>FILLER{}</b>foo</p>.
  793. const { view: viewP, selection: newSelection } = parse(
  794. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  795. viewRoot._appendChildren( viewP );
  796. selection._setTo( newSelection );
  797. renderer.markToSync( 'children', viewRoot );
  798. renderer.render();
  799. // 2. Check the DOM.
  800. const domP = domRoot.childNodes[ 0 ];
  801. expect( domP.childNodes.length ).to.equal( 2 );
  802. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  803. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  804. const domB = domP.childNodes[ 0 ];
  805. const viewB = viewP.getChild( 0 );
  806. expect( domB.childNodes.length ).to.equal( 1 );
  807. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  808. expect( domSelection.rangeCount ).to.equal( 1 );
  809. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  810. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  811. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  812. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  813. const viewText = new ViewText( 'x' );
  814. viewB._appendChildren( viewText );
  815. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  816. renderer.markToSync( 'text', viewText );
  817. renderer.render();
  818. // 4. Check the DOM.
  819. expect( domB.childNodes.length ).to.equal( 1 );
  820. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  821. expect( domSelection.rangeCount ).to.equal( 1 );
  822. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  823. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  824. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  825. } );
  826. it( 'should handle not collapsed range', () => {
  827. const domSelection = document.getSelection();
  828. const { view: viewP, selection: newSelection } = parse(
  829. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  830. viewRoot._appendChildren( viewP );
  831. selection._setTo( newSelection );
  832. renderer.markToSync( 'children', viewRoot );
  833. renderer.render();
  834. const domP = domRoot.childNodes[ 0 ];
  835. expect( domP.childNodes.length ).to.equal( 2 );
  836. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  837. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  838. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  839. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  840. expect( domSelection.rangeCount ).to.equal( 1 );
  841. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  842. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  843. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  844. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  845. renderer.markToSync( 'children', viewP );
  846. renderAndExpectNoChanges( renderer, domRoot );
  847. } );
  848. it( 'should not change selection if there is no editable with selection', () => {
  849. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  850. document.body.appendChild( domDiv );
  851. domDiv.focus();
  852. const domSelection = document.getSelection();
  853. domSelection.removeAllRanges();
  854. domSelection.collapse( domDiv, 0 );
  855. selectionEditable = null;
  856. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  857. viewRoot._appendChildren( viewP );
  858. selection._setTo( newSelection );
  859. renderer.render();
  860. expect( domSelection.rangeCount ).to.equal( 1 );
  861. // Depending on the browser selection may end up before the text node or at the beginning of it.
  862. const domRange = domSelection.getRangeAt( 0 );
  863. const assertSelectionAtEndOfTextNode = () => {
  864. expect( domRange.startContainer ).to.equal( domDiv );
  865. };
  866. const assertSelectionInsideTextNode = () => {
  867. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  868. };
  869. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  870. expect( domRange.startOffset ).to.equal( 0 );
  871. expect( domRange.collapsed ).to.be.true;
  872. domDiv.remove();
  873. } );
  874. it( 'should not change selection if there is no focus', () => {
  875. const domDiv = createElement( document, 'div', null, 'not editable' );
  876. document.body.appendChild( domDiv );
  877. const domSelection = document.getSelection();
  878. domSelection.removeAllRanges();
  879. const domRange = document.createRange();
  880. domRange.setStart( domDiv, 0 );
  881. domRange.collapse( true );
  882. domSelection.addRange( domRange );
  883. renderer.isFocused = false;
  884. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  885. viewRoot._appendChildren( viewP );
  886. selection._setTo( newSelection );
  887. renderer.render();
  888. expect( domSelection.rangeCount ).to.equal( 1 );
  889. // Depending on the browser selection may end up before the text node or at the beginning of it.
  890. const domSelectionRange = domSelection.getRangeAt( 0 );
  891. const assertSelectionAtEndOfTextNode = () => {
  892. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  893. };
  894. const assertSelectionInsideTextNode = () => {
  895. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  896. };
  897. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  898. expect( domSelectionRange.startOffset ).to.equal( 0 );
  899. expect( domSelectionRange.collapsed ).to.be.true;
  900. domDiv.remove();
  901. } );
  902. it( 'should not add inline filler after text node', () => {
  903. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  904. viewRoot._appendChildren( viewP );
  905. selection._setTo( newSelection );
  906. renderer.markToSync( 'children', viewRoot );
  907. renderer.render();
  908. const domP = domRoot.childNodes[ 0 ];
  909. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  910. } );
  911. it( 'should throw if there is no filler in expected position', () => {
  912. const { view: viewP, selection: newSelection } = parse(
  913. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  914. viewRoot._appendChildren( viewP );
  915. selection._setTo( newSelection );
  916. renderer.markToSync( 'children', viewRoot );
  917. renderer.render();
  918. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  919. const viewB = viewP.getChild( 1 );
  920. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  921. // Remove filler.
  922. domB.childNodes[ 0 ].data = '';
  923. selection._setTo( null );
  924. renderer.markToSync( 'children', viewB );
  925. expect( () => {
  926. renderer.render();
  927. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  928. } );
  929. // #1014.
  930. it( 'should create inline filler in newly created dom nodes', () => {
  931. // 1. Create the view structure which needs inline filler.
  932. const inputView =
  933. '<container:ul>' +
  934. '<container:li>Foobar.</container:li>' +
  935. '<container:li>[]<container:div></container:div></container:li>' +
  936. '</container:ul>';
  937. const { view: view, selection: newSelection } = parse( inputView );
  938. viewRoot._appendChildren( view );
  939. selection._setTo( newSelection );
  940. renderer.markToSync( 'children', viewRoot );
  941. renderer.render();
  942. // 2. Check if filler element has been (correctly) created.
  943. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  944. // 3. Move the inline filler parent to a newly created element.
  945. const viewLi = view.getChild( 0 );
  946. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  947. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  948. viewLi._appendChildren( viewUl );
  949. // 4. Mark changed items and render the view.
  950. renderer.markToSync( 'children', view );
  951. renderer.markToSync( 'children', viewLi );
  952. renderer.render();
  953. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  954. const domSelection = document.getSelection();
  955. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  956. } );
  957. it( 'should handle focusing element', () => {
  958. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  959. const editable = selection.editableElement;
  960. renderer.render();
  961. expect( editable ).to.equal( viewRoot );
  962. expect( domFocusSpy.calledOnce ).to.be.true;
  963. } );
  964. it( 'should not focus editable if isFocues is set to false', () => {
  965. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  966. renderer.isFocused = false;
  967. renderer.render();
  968. expect( domFocusSpy.calledOnce ).to.be.false;
  969. } );
  970. it( 'should not focus already focused DOM element', () => {
  971. domRoot.setAttribute( 'contentEditable', true );
  972. domRoot.focus();
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. renderer.render();
  975. expect( domFocusSpy.called ).to.be.false;
  976. } );
  977. it( 'should render NBSP as first space in inline element after another space', () => {
  978. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  979. viewRoot._appendChildren( viewP );
  980. renderer.markToSync( 'children', viewRoot );
  981. renderer.render();
  982. const domP = domRoot.childNodes[ 0 ];
  983. const domB = domP.childNodes[ 1 ];
  984. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  985. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  986. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  987. // Insert space resulting in '<p>x <b> y</b></p>'.
  988. const viewB = viewP.getChild( 1 );
  989. viewB._removeChildren( 0 );
  990. viewB._appendChildren( new ViewText( ' y' ) );
  991. renderer.markToSync( 'children', viewP );
  992. renderer.render();
  993. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  994. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  995. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  996. } );
  997. it( 'should update sibling after, when node before is removed', () => {
  998. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  999. viewRoot._appendChildren( viewP );
  1000. renderer.markToSync( 'children', viewRoot );
  1001. renderer.render();
  1002. const domP = domRoot.childNodes[ 0 ];
  1003. const domB = domP.childNodes[ 1 ];
  1004. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1005. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1006. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1007. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1008. viewP._removeChildren( 0 );
  1009. renderer.markToSync( 'children', viewP );
  1010. renderer.render();
  1011. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1012. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1013. } );
  1014. it( 'should update sibling before, when node after is removed', () => {
  1015. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1016. viewRoot._appendChildren( viewP );
  1017. renderer.markToSync( 'children', viewRoot );
  1018. renderer.render();
  1019. const domP = domRoot.childNodes[ 0 ];
  1020. const domB = domP.childNodes[ 1 ];
  1021. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1022. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1023. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1024. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1025. viewP._removeChildren( 1 );
  1026. renderer.markToSync( 'children', viewP );
  1027. renderer.render();
  1028. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1029. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1030. } );
  1031. // #1093
  1032. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1033. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1034. viewRoot._appendChildren( viewP );
  1035. renderer.markToSync( 'children', viewRoot );
  1036. renderer.render();
  1037. const domP = domRoot.childNodes[ 0 ];
  1038. const domB = domP.childNodes[ 1 ];
  1039. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1040. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1041. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1042. // Insert space resulting in '<p>x <b> y</b></p>'.
  1043. viewP._removeChildren( 0 );
  1044. viewP._insertChildren( 0, new ViewText( 'x ' ) );
  1045. renderer.markToSync( 'children', viewP );
  1046. renderer.render();
  1047. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1048. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1049. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1050. } );
  1051. // #1093
  1052. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1053. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1054. viewRoot._appendChildren( viewP );
  1055. renderer.markToSync( 'children', viewRoot );
  1056. renderer.render();
  1057. const domP = domRoot.childNodes[ 0 ];
  1058. const domB = domP.childNodes[ 0 ];
  1059. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1060. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1061. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1062. // Insert space resulting in '<p><b>x </b> y</p>'.
  1063. const viewB = viewP.getChild( 0 );
  1064. viewB._removeChildren( 0 );
  1065. viewB._insertChildren( 0, new ViewText( 'x ' ) );
  1066. renderer.markToSync( 'children', viewP );
  1067. renderer.render();
  1068. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1069. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1070. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1071. } );
  1072. // #1093
  1073. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1074. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1075. viewRoot._appendChildren( viewP );
  1076. renderer.markToSync( 'children', viewRoot );
  1077. renderer.render();
  1078. const domP = domRoot.childNodes[ 0 ];
  1079. const domB = domP.childNodes[ 0 ];
  1080. const domI = domP.childNodes[ 1 ];
  1081. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1082. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1083. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1084. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1085. const viewB = viewP.getChild( 0 );
  1086. viewB._removeChildren( 0 );
  1087. viewB._insertChildren( 0, new ViewText( 'x ' ) );
  1088. renderer.markToSync( 'children', viewP );
  1089. renderer.render();
  1090. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1091. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1092. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1093. } );
  1094. describe( 'fake selection', () => {
  1095. beforeEach( () => {
  1096. const { view: viewP, selection: newSelection } = parse(
  1097. '<container:p>[foo bar]</container:p>'
  1098. );
  1099. viewRoot._appendChildren( viewP );
  1100. selection._setTo( newSelection );
  1101. renderer.markToSync( 'children', viewRoot );
  1102. renderer.render();
  1103. } );
  1104. it( 'should render fake selection', () => {
  1105. const label = 'fake selection label';
  1106. selection._setTo( selection.getRanges(), { fake: true, label } );
  1107. renderer.render();
  1108. expect( domRoot.childNodes.length ).to.equal( 2 );
  1109. const container = domRoot.childNodes[ 1 ];
  1110. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1111. expect( container.childNodes.length ).to.equal( 1 );
  1112. const textNode = container.childNodes[ 0 ];
  1113. expect( textNode.textContent ).to.equal( label );
  1114. const domSelection = domRoot.ownerDocument.getSelection();
  1115. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1116. } );
  1117. it( 'should render &nbsp; if no selection label is provided', () => {
  1118. selection._setTo( selection.getRanges(), { fake: true } );
  1119. renderer.render();
  1120. expect( domRoot.childNodes.length ).to.equal( 2 );
  1121. const container = domRoot.childNodes[ 1 ];
  1122. expect( container.childNodes.length ).to.equal( 1 );
  1123. const textNode = container.childNodes[ 0 ];
  1124. expect( textNode.textContent ).to.equal( '\u00A0' );
  1125. const domSelection = domRoot.ownerDocument.getSelection();
  1126. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1127. } );
  1128. it( 'should remove fake selection container when selection is no longer fake', () => {
  1129. selection._setTo( selection.getRanges(), { fake: true } );
  1130. renderer.render();
  1131. selection._setTo( selection.getRanges(), { fake: false } );
  1132. renderer.render();
  1133. expect( domRoot.childNodes.length ).to.equal( 1 );
  1134. const domParagraph = domRoot.childNodes[ 0 ];
  1135. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1136. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1137. const domSelection = domRoot.ownerDocument.getSelection();
  1138. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1139. } );
  1140. it( 'should reuse fake selection container #1', () => {
  1141. const label = 'fake selection label';
  1142. selection._setTo( selection.getRanges(), { fake: true, label } );
  1143. renderer.render();
  1144. expect( domRoot.childNodes.length ).to.equal( 2 );
  1145. const container = domRoot.childNodes[ 1 ];
  1146. selection._setTo( selection.getRanges(), { fake: true, label } );
  1147. renderer.render();
  1148. expect( domRoot.childNodes.length ).to.equal( 2 );
  1149. const newContainer = domRoot.childNodes[ 1 ];
  1150. expect( newContainer ).equals( container );
  1151. expect( newContainer.childNodes.length ).to.equal( 1 );
  1152. const textNode = newContainer.childNodes[ 0 ];
  1153. expect( textNode.textContent ).to.equal( label );
  1154. } );
  1155. it( 'should reuse fake selection container #2', () => {
  1156. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1157. renderer.render();
  1158. expect( domRoot.childNodes.length ).to.equal( 2 );
  1159. const container = domRoot.childNodes[ 1 ];
  1160. selection._setTo( selection.getRanges(), { fake: false } );
  1161. renderer.render();
  1162. expect( domRoot.childNodes.length ).to.equal( 1 );
  1163. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1164. renderer.render();
  1165. expect( domRoot.childNodes.length ).to.equal( 2 );
  1166. const newContainer = domRoot.childNodes[ 1 ];
  1167. expect( newContainer ).equals( container );
  1168. expect( newContainer.childNodes.length ).to.equal( 1 );
  1169. const textNode = newContainer.childNodes[ 0 ];
  1170. expect( textNode.textContent ).to.equal( 'label 2' );
  1171. } );
  1172. it( 'should reuse fake selection container #3', () => {
  1173. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1174. renderer.render();
  1175. expect( domRoot.childNodes.length ).to.equal( 2 );
  1176. const container = domRoot.childNodes[ 1 ];
  1177. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1178. renderer.render();
  1179. expect( domRoot.childNodes.length ).to.equal( 2 );
  1180. const newContainer = domRoot.childNodes[ 1 ];
  1181. expect( newContainer ).equals( container );
  1182. expect( newContainer.childNodes.length ).to.equal( 1 );
  1183. const textNode = newContainer.childNodes[ 0 ];
  1184. expect( textNode.textContent ).to.equal( 'label 2' );
  1185. } );
  1186. it( 'should style fake selection container properly', () => {
  1187. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1188. renderer.render();
  1189. expect( domRoot.childNodes.length ).to.equal( 2 );
  1190. const container = domRoot.childNodes[ 1 ];
  1191. expect( container.style.position ).to.equal( 'fixed' );
  1192. expect( container.style.top ).to.equal( '0px' );
  1193. expect( container.style.left ).to.equal( '-9999px' );
  1194. } );
  1195. it( 'should bind fake selection container to view selection', () => {
  1196. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1197. renderer.render();
  1198. expect( domRoot.childNodes.length ).to.equal( 2 );
  1199. const container = domRoot.childNodes[ 1 ];
  1200. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1201. expect( bindSelection ).to.not.be.undefined;
  1202. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1203. } );
  1204. // Use a forgiving way of checking what the selection contains
  1205. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1206. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1207. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1208. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1209. expect( domSelection.toString() ).to.match( expectedText );
  1210. expect(
  1211. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1212. ).to.be.true;
  1213. }
  1214. } );
  1215. // #887
  1216. describe( 'similar selection', () => {
  1217. // Use spies to check selection updates. Some selection positions are not achievable in some
  1218. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1219. let selectionCollapseSpy, selectionExtendSpy;
  1220. afterEach( () => {
  1221. if ( selectionCollapseSpy ) {
  1222. selectionCollapseSpy.restore();
  1223. selectionCollapseSpy = null;
  1224. }
  1225. if ( selectionExtendSpy ) {
  1226. selectionExtendSpy.restore();
  1227. selectionExtendSpy = null;
  1228. }
  1229. } );
  1230. it( 'should always render collapsed selection even if it is similar', () => {
  1231. const domSelection = document.getSelection();
  1232. const { view: viewP, selection: newSelection } = parse(
  1233. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1234. viewRoot._appendChildren( viewP );
  1235. selection._setTo( newSelection );
  1236. renderer.markToSync( 'children', viewRoot );
  1237. renderer.render();
  1238. const domP = domRoot.childNodes[ 0 ];
  1239. const domB = domP.childNodes[ 1 ];
  1240. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1241. expect( domSelection.isCollapsed ).to.true;
  1242. expect( domSelection.rangeCount ).to.equal( 1 );
  1243. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1244. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1245. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1246. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1247. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1248. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1249. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1250. selection._setTo( [
  1251. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1252. ] );
  1253. renderer.markToSync( 'children', viewP );
  1254. renderer.render();
  1255. expect( selectionCollapseSpy.calledOnce ).to.true;
  1256. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1257. expect( selectionExtendSpy.calledOnce ).to.true;
  1258. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1259. } );
  1260. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1261. const domSelection = document.getSelection();
  1262. const { view: viewP, selection: newSelection } = parse(
  1263. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1264. viewRoot._appendChildren( viewP );
  1265. selection._setTo( newSelection );
  1266. renderer.markToSync( 'children', viewRoot );
  1267. renderer.render();
  1268. const domP = domRoot.childNodes[ 0 ];
  1269. const domB = domP.childNodes[ 1 ];
  1270. expect( domSelection.isCollapsed ).to.true;
  1271. expect( domSelection.rangeCount ).to.equal( 1 );
  1272. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1273. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1274. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1275. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1276. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1277. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1278. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1279. selection._setTo( [
  1280. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1281. ] );
  1282. renderer.markToSync( 'children', viewP );
  1283. renderer.render();
  1284. expect( selectionCollapseSpy.calledOnce ).to.true;
  1285. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1286. expect( selectionExtendSpy.calledOnce ).to.true;
  1287. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1288. } );
  1289. it( 'should always render non-collapsed selection if it not is similar', () => {
  1290. const domSelection = document.getSelection();
  1291. const { view: viewP, selection: newSelection } = parse(
  1292. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1293. viewRoot._appendChildren( viewP );
  1294. selection._setTo( newSelection );
  1295. renderer.markToSync( 'children', viewRoot );
  1296. renderer.render();
  1297. const domP = domRoot.childNodes[ 0 ];
  1298. const domB = domP.childNodes[ 1 ];
  1299. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1300. expect( domSelection.isCollapsed ).to.false;
  1301. expect( domSelection.rangeCount ).to.equal( 1 );
  1302. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1303. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1304. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1305. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1306. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1307. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1308. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1309. selection._setTo( [
  1310. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1311. ] );
  1312. renderer.markToSync( 'children', viewP );
  1313. renderer.render();
  1314. expect( selectionCollapseSpy.calledOnce ).to.true;
  1315. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1316. expect( selectionExtendSpy.calledOnce ).to.true;
  1317. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1318. } );
  1319. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1320. const domSelection = document.getSelection();
  1321. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1322. viewRoot._appendChildren( viewP );
  1323. selection._setTo( newSelection );
  1324. renderer.markToSync( 'children', viewRoot );
  1325. renderer.render();
  1326. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1327. // Do not change view selection.
  1328. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1329. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1330. // because DOM selection is in incorrect place.
  1331. const domP = domRoot.childNodes[ 0 ];
  1332. const domSpan = domP.childNodes[ 1 ];
  1333. domSelection.collapse( domSpan, 0 );
  1334. renderer.render();
  1335. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1336. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1337. const assertSelectionAtEndOfTextNode = () => {
  1338. expect( domSelection.anchorNode ).to.equal( domP );
  1339. expect( domSelection.anchorOffset ).to.equal( 1 );
  1340. };
  1341. const assertSelectionInsideTextNode = () => {
  1342. const textNode = domP.childNodes[ 0 ];
  1343. expect( domSelection.anchorNode ).to.equal( textNode );
  1344. expect( domSelection.anchorOffset ).to.equal( 3 );
  1345. };
  1346. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1347. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1348. } );
  1349. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1350. const domSelection = document.getSelection();
  1351. const { view: viewP, selection: newSelection } = parse(
  1352. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1353. viewRoot._appendChildren( viewP );
  1354. selection._setTo( newSelection );
  1355. renderer.markToSync( 'children', viewRoot );
  1356. renderer.render();
  1357. const domP = domRoot.childNodes[ 0 ];
  1358. const domB = domP.childNodes[ 1 ];
  1359. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1360. expect( domSelection.isCollapsed ).to.false;
  1361. expect( domSelection.rangeCount ).to.equal( 1 );
  1362. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1363. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1364. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1365. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1366. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1367. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1368. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1369. selection._setTo( [
  1370. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1371. ] );
  1372. renderer.markToSync( 'children', viewP );
  1373. renderer.render();
  1374. expect( selectionCollapseSpy.notCalled ).to.true;
  1375. expect( selectionExtendSpy.notCalled ).to.true;
  1376. } );
  1377. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1378. const domSelection = document.getSelection();
  1379. const { view: viewP, selection: newSelection } = parse(
  1380. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1381. viewRoot._appendChildren( viewP );
  1382. selection._setTo( newSelection );
  1383. renderer.markToSync( 'children', viewRoot );
  1384. renderer.render();
  1385. const domP = domRoot.childNodes[ 0 ];
  1386. const domB = domP.childNodes[ 1 ];
  1387. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1388. expect( domSelection.isCollapsed ).to.false;
  1389. expect( domSelection.rangeCount ).to.equal( 1 );
  1390. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1391. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1392. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1393. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1394. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1395. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1396. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1397. selection._setTo( [
  1398. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1399. ] );
  1400. renderer.markToSync( 'children', viewP );
  1401. renderer.render();
  1402. expect( selectionCollapseSpy.notCalled ).to.true;
  1403. expect( selectionExtendSpy.notCalled ).to.true;
  1404. } );
  1405. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1406. const domSelection = document.getSelection();
  1407. const { view: viewP, selection: newSelection } = parse(
  1408. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1409. viewRoot._appendChildren( viewP );
  1410. selection._setTo( newSelection );
  1411. renderer.markToSync( 'children', viewRoot );
  1412. renderer.render();
  1413. const domP = domRoot.childNodes[ 0 ];
  1414. const domB = domP.childNodes[ 1 ];
  1415. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1416. expect( domSelection.isCollapsed ).to.false;
  1417. expect( domSelection.rangeCount ).to.equal( 1 );
  1418. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1419. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1420. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1421. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1422. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1423. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1424. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1425. selection._setTo( [
  1426. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1427. ] );
  1428. renderer.markToSync( 'children', viewP );
  1429. renderer.render();
  1430. expect( selectionCollapseSpy.notCalled ).to.true;
  1431. expect( selectionExtendSpy.notCalled ).to.true;
  1432. } );
  1433. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1434. const domSelection = document.getSelection();
  1435. const { view: viewP, selection: newSelection } = parse(
  1436. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1437. viewRoot._appendChildren( viewP );
  1438. selection._setTo( newSelection );
  1439. renderer.markToSync( 'children', viewRoot );
  1440. renderer.render();
  1441. const domP = domRoot.childNodes[ 0 ];
  1442. const domB = domP.childNodes[ 1 ];
  1443. expect( domSelection.isCollapsed ).to.false;
  1444. expect( domSelection.rangeCount ).to.equal( 1 );
  1445. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1446. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1447. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1448. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1449. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1450. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1451. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1452. selection._setTo( [
  1453. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1454. ] );
  1455. renderer.markToSync( 'children', viewP );
  1456. renderer.render();
  1457. expect( selectionCollapseSpy.notCalled ).to.true;
  1458. expect( selectionExtendSpy.notCalled ).to.true;
  1459. } );
  1460. } );
  1461. } );
  1462. describe( '#922', () => {
  1463. let view, viewDoc, viewRoot, domRoot, converter;
  1464. beforeEach( () => {
  1465. view = new View();
  1466. viewDoc = view.document;
  1467. domRoot = document.createElement( 'div' );
  1468. document.body.appendChild( domRoot );
  1469. viewRoot = createViewRoot( viewDoc );
  1470. view.attachDomRoot( domRoot );
  1471. converter = view.domConverter;
  1472. } );
  1473. it( 'should properly render unwrapped attributes #1', () => {
  1474. setViewData( view,
  1475. '<container:p>' +
  1476. '[<attribute:italic>' +
  1477. '<attribute:strong>f</attribute:strong>' +
  1478. '</attribute:italic>]' +
  1479. '<attribute:strong>oo</attribute:strong>' +
  1480. '</container:p>'
  1481. );
  1482. // Render it to DOM to create initial DOM <-> view mappings.
  1483. view.render();
  1484. // Unwrap italic attribute element.
  1485. view.change( writer => {
  1486. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1487. } );
  1488. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  1489. // Re-render changes in view to DOM.
  1490. view.render();
  1491. // Check if DOM is rendered correctly.
  1492. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  1493. expect( checkMappings() ).to.be.true;
  1494. } );
  1495. it( 'should properly render unwrapped attributes #2', () => {
  1496. setViewData( view,
  1497. '<container:p>' +
  1498. '[<attribute:italic>' +
  1499. '<attribute:strong>foo</attribute:strong>' +
  1500. '</attribute:italic>]' +
  1501. '</container:p>' );
  1502. // Render it to DOM to create initial DOM <-> view mappings.
  1503. view.render();
  1504. // Unwrap italic attribute element and change text inside.
  1505. view.change( writer => {
  1506. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1507. } );
  1508. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  1509. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  1510. // Re-render changes in view to DOM.
  1511. view.render();
  1512. // Check if DOM is rendered correctly.
  1513. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  1514. expect( checkMappings() ).to.be.true;
  1515. } );
  1516. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  1517. setViewData( view,
  1518. '<container:p>foo</container:p>'
  1519. );
  1520. // Render it to DOM to create initial DOM <-> view mappings.
  1521. view.render();
  1522. // Change text and insert new element into paragraph.
  1523. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1524. textNode._data = 'foobar';
  1525. view.change( writer => {
  1526. writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  1527. } );
  1528. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  1529. // Re-render changes in view to DOM.
  1530. view.render();
  1531. // Check if DOM is rendered correctly.
  1532. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  1533. expect( checkMappings() ).to.be.true;
  1534. } );
  1535. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  1536. setViewData( view,
  1537. '<container:p>foo</container:p>'
  1538. );
  1539. // Render it to DOM to create initial DOM <-> view mappings.
  1540. view.render();
  1541. // Change text and insert new element into paragraph.
  1542. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1543. textNode._data = 'foobar';
  1544. view.change( writer => {
  1545. writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  1546. } );
  1547. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  1548. // Re-render changes in view to DOM.
  1549. view.render();
  1550. // Check if DOM is rendered correctly.
  1551. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  1552. expect( checkMappings() ).to.be.true;
  1553. } );
  1554. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  1555. setViewData( view,
  1556. '<container:p>' +
  1557. '<attribute:b></attribute:b>' +
  1558. '<attribute:i></attribute:i>' +
  1559. '<attribute:span></attribute:span>' +
  1560. '</container:p>'
  1561. );
  1562. // Render it to DOM to create initial DOM <-> view mappings.
  1563. view.render();
  1564. // Remove first element and reinsert it at the end.
  1565. const container = viewRoot.getChild( 0 );
  1566. const firstElement = container.getChild( 0 );
  1567. view.change( writer => {
  1568. writer.remove( ViewRange.createOn( firstElement ) );
  1569. writer.insert( new ViewPosition( container, 2 ), firstElement );
  1570. } );
  1571. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1572. // Re-render changes in view to DOM.
  1573. view.render();
  1574. // Check if DOM is rendered correctly.
  1575. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1576. expect( checkMappings() ).to.be.true;
  1577. } );
  1578. // Checks if every node in DOM tree is mapped to the view.
  1579. function checkMappings() {
  1580. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  1581. while ( domWalker.nextNode() ) {
  1582. const node = domWalker.currentNode;
  1583. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  1584. return false;
  1585. }
  1586. }
  1587. return true;
  1588. }
  1589. } );
  1590. describe( '_markDescendantTextToSync', () => {
  1591. let viewRoot;
  1592. beforeEach( () => {
  1593. viewRoot = new ViewElement( 'div' );
  1594. renderer.markedTexts.clear();
  1595. renderer.markedAttributes.clear();
  1596. renderer.markedChildren.clear();
  1597. } );
  1598. it( 'should handle null values', () => {
  1599. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  1600. renderer._markDescendantTextToSync( null );
  1601. expect( renderer.markedChildren.size ).to.equal( 0 );
  1602. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1603. expect( renderer.markedTexts.size ).to.equal( 0 );
  1604. } );
  1605. it( 'should handle element nodes', () => {
  1606. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  1607. viewRoot._appendChildren( viewP );
  1608. renderer._markDescendantTextToSync( viewP );
  1609. expect( renderer.markedChildren.size ).to.equal( 0 );
  1610. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1611. expect( renderer.markedTexts.size ).to.equal( 3 );
  1612. } );
  1613. it( 'should handle text nodes', () => {
  1614. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  1615. viewRoot._appendChildren( viewP );
  1616. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  1617. expect( renderer.markedChildren.size ).to.equal( 0 );
  1618. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1619. expect( renderer.markedTexts.size ).to.equal( 1 );
  1620. } );
  1621. it( 'should handle document fragment', () => {
  1622. const fragment = new DocumentFragment();
  1623. renderer._markDescendantTextToSync( fragment );
  1624. expect( renderer.markedChildren.size ).to.equal( 0 );
  1625. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1626. expect( renderer.markedTexts.size ).to.equal( 0 );
  1627. } );
  1628. it( 'should handle empty element nodes', () => {
  1629. const viewP = parse( '<container:p></container:p>' );
  1630. viewRoot._appendChildren( viewP );
  1631. renderer._markDescendantTextToSync( viewP );
  1632. expect( renderer.markedChildren.size ).to.equal( 0 );
  1633. expect( renderer.markedAttributes.size ).to.equal( 0 );
  1634. expect( renderer.markedTexts.size ).to.equal( 0 );
  1635. } );
  1636. } );
  1637. } );
  1638. function renderAndExpectNoChanges( renderer, domRoot ) {
  1639. const config = {
  1640. childList: true,
  1641. characterData: true,
  1642. characterDataOldValue: true,
  1643. subtree: true
  1644. };
  1645. const mutationObserver = new window.MutationObserver( () => {
  1646. throw 'There should be not mutations';
  1647. } );
  1648. mutationObserver.observe( domRoot, config );
  1649. renderer.render();
  1650. const records = mutationObserver.takeRecords();
  1651. mutationObserver.disconnect();
  1652. expect( records.length ).to.equal( 0 );
  1653. }