8
0

undoengine-integration.js 29 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919
  1. /**
  2. * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* global document */
  6. import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
  7. import Range from '@ckeditor/ckeditor5-engine/src/model/range';
  8. import Position from '@ckeditor/ckeditor5-engine/src/model/position';
  9. import UndoEngine from '../src/undoengine';
  10. import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
  11. import HeadingEngine from '@ckeditor/ckeditor5-heading/src/headingengine';
  12. import Typing from '@ckeditor/ckeditor5-typing/src/typing';
  13. import Enter from '@ckeditor/ckeditor5-enter/src/enter';
  14. import Clipboard from '@ckeditor/ckeditor5-clipboard/src/clipboard';
  15. import BoldEngine from '@ckeditor/ckeditor5-basic-styles/src/boldengine';
  16. import buildModelConverter from '@ckeditor/ckeditor5-engine/src/conversion/buildmodelconverter';
  17. import buildViewConverter from '@ckeditor/ckeditor5-engine/src/conversion/buildviewconverter';
  18. import { setData, getData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
  19. describe( 'UndoEngine integration', () => {
  20. let editor, doc, root, div;
  21. beforeEach( () => {
  22. div = document.createElement( 'div' );
  23. document.body.appendChild( div );
  24. return ClassicEditor.create( div, { plugins: [ Paragraph, HeadingEngine, Typing, Enter, Clipboard, BoldEngine, UndoEngine ] } )
  25. .then( newEditor => {
  26. editor = newEditor;
  27. doc = editor.document;
  28. // Add "div feature".
  29. doc.schema.registerItem( 'div', '$block' );
  30. buildModelConverter().for( editor.data.modelToView, editor.editing.modelToView ).fromElement( 'div' ).toElement( 'div' );
  31. buildViewConverter().for( editor.data.viewToModel ).fromElement( 'div' ).toElement( 'div' );
  32. root = doc.getRoot();
  33. } );
  34. } );
  35. function setSelection( pathA, pathB ) {
  36. doc.selection.setRanges( [ new Range( new Position( root, pathA ), new Position( root, pathB ) ) ] );
  37. }
  38. function input( input ) {
  39. setData( doc, input );
  40. }
  41. function output( output ) {
  42. expect( getData( doc ) ).to.equal( output );
  43. }
  44. function undoDisabled() {
  45. expect( editor.commands.get( 'undo' ).isEnabled ).to.be.false;
  46. }
  47. function redoDisabled() {
  48. expect( editor.commands.get( 'redo' ).isEnabled ).to.be.false;
  49. }
  50. describe( 'adding and removing content', () => {
  51. it( 'add and undo', () => {
  52. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  53. doc.enqueueChanges( () => {
  54. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  55. } );
  56. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  57. editor.execute( 'undo' );
  58. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  59. undoDisabled();
  60. } );
  61. it( 'multiple adding and undo', () => {
  62. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  63. doc.enqueueChanges( () => {
  64. doc.batch()
  65. .insert( doc.selection.getFirstPosition(), 'zzz' )
  66. .insert( new Position( root, [ 1, 0 ] ), 'xxx' );
  67. } );
  68. output( '<paragraph>fozzz[]o</paragraph><paragraph>xxxbar</paragraph>' );
  69. doc.enqueueChanges( () => {
  70. setSelection( [ 1, 0 ], [ 1, 0 ] );
  71. doc.batch().insert( doc.selection.getFirstPosition(), 'yyy' );
  72. } );
  73. output( '<paragraph>fozzzo</paragraph><paragraph>yyy[]xxxbar</paragraph>' );
  74. editor.execute( 'undo' );
  75. output( '<paragraph>fozzzo</paragraph><paragraph>[]xxxbar</paragraph>' );
  76. editor.execute( 'undo' );
  77. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  78. undoDisabled();
  79. } );
  80. it( 'multiple adding mixed with undo', () => {
  81. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  82. doc.enqueueChanges( () => {
  83. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  84. } );
  85. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  86. doc.enqueueChanges( () => {
  87. setSelection( [ 1, 0 ], [ 1, 0 ] );
  88. doc.batch().insert( doc.selection.getFirstPosition(), 'yyy' );
  89. } );
  90. output( '<paragraph>fozzzo</paragraph><paragraph>yyy[]bar</paragraph>' );
  91. editor.execute( 'undo' );
  92. output( '<paragraph>fozzzo</paragraph><paragraph>[]bar</paragraph>' );
  93. doc.enqueueChanges( () => {
  94. setSelection( [ 0, 0 ], [ 0, 0 ] );
  95. doc.batch().insert( doc.selection.getFirstPosition(), 'xxx' );
  96. } );
  97. output( '<paragraph>xxx[]fozzzo</paragraph><paragraph>bar</paragraph>' );
  98. editor.execute( 'undo' );
  99. output( '<paragraph>[]fozzzo</paragraph><paragraph>bar</paragraph>' );
  100. editor.execute( 'undo' );
  101. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  102. undoDisabled();
  103. } );
  104. it( 'multiple remove and undo', () => {
  105. input( '<paragraph>[]foo</paragraph><paragraph>bar</paragraph>' );
  106. doc.enqueueChanges( () => {
  107. doc.batch().remove( Range.createFromPositionAndShift( doc.selection.getFirstPosition(), 2 ) );
  108. } );
  109. output( '<paragraph>[]o</paragraph><paragraph>bar</paragraph>' );
  110. doc.enqueueChanges( () => {
  111. setSelection( [ 1, 1 ], [ 1, 1 ] );
  112. doc.batch().remove( Range.createFromPositionAndShift( doc.selection.getFirstPosition(), 2 ) );
  113. } );
  114. output( '<paragraph>o</paragraph><paragraph>b[]</paragraph>' );
  115. editor.execute( 'undo' );
  116. // Here is an edge case that selection could be before or after `ar`.
  117. output( '<paragraph>o</paragraph><paragraph>bar[]</paragraph>' );
  118. editor.execute( 'undo' );
  119. // As above.
  120. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  121. undoDisabled();
  122. } );
  123. it( 'add and remove different parts and undo', () => {
  124. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  125. doc.enqueueChanges( () => {
  126. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  127. } );
  128. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  129. doc.enqueueChanges( () => {
  130. setSelection( [ 1, 2 ], [ 1, 2 ] );
  131. doc.batch().remove( Range.createFromPositionAndShift( new Position( root, [ 1, 1 ] ), 1 ) );
  132. } );
  133. output( '<paragraph>fozzzo</paragraph><paragraph>b[]r</paragraph>' );
  134. editor.execute( 'undo' );
  135. output( '<paragraph>fozzzo</paragraph><paragraph>ba[]r</paragraph>' );
  136. editor.execute( 'undo' );
  137. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  138. undoDisabled();
  139. } );
  140. it( 'add and remove same part and undo', () => {
  141. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  142. doc.enqueueChanges( () => {
  143. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  144. } );
  145. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  146. doc.enqueueChanges( () => {
  147. doc.batch().remove( Range.createFromPositionAndShift( new Position( root, [ 0, 2 ] ), 3 ) );
  148. } );
  149. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  150. editor.execute( 'undo' );
  151. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  152. editor.execute( 'undo' );
  153. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  154. undoDisabled();
  155. } );
  156. } );
  157. describe( 'moving', () => {
  158. it( 'move same content twice then undo', () => {
  159. input( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  160. doc.enqueueChanges( () => {
  161. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 1, 0 ] ) );
  162. } );
  163. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  164. doc.enqueueChanges( () => {
  165. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0, 2 ] ) );
  166. } );
  167. output( '<paragraph>fz[o]</paragraph><paragraph>bar</paragraph>' );
  168. editor.execute( 'undo' );
  169. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  170. editor.execute( 'undo' );
  171. output( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  172. undoDisabled();
  173. } );
  174. it( 'move content and new parent then undo', () => {
  175. input( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  176. doc.enqueueChanges( () => {
  177. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 1, 0 ] ) );
  178. } );
  179. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  180. doc.enqueueChanges( () => {
  181. setSelection( [ 1 ], [ 2 ] );
  182. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0 ] ) );
  183. } );
  184. output( '[<paragraph>obar</paragraph>]<paragraph>fz</paragraph>' );
  185. editor.execute( 'undo' );
  186. output( '<paragraph>fz</paragraph>[<paragraph>obar</paragraph>]' );
  187. editor.execute( 'undo' );
  188. output( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  189. undoDisabled();
  190. } );
  191. } );
  192. describe( 'attributes with other', () => {
  193. it( 'attributes then insert inside then undo', () => {
  194. input( '<paragraph>fo[ob]ar</paragraph>' );
  195. doc.enqueueChanges( () => {
  196. doc.batch().setAttribute( doc.selection.getFirstRange(), 'bold', true );
  197. } );
  198. output( '<paragraph>fo[<$text bold="true">ob</$text>]ar</paragraph>' );
  199. doc.enqueueChanges( () => {
  200. setSelection( [ 0, 3 ], [ 0, 3 ] );
  201. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  202. } );
  203. output( '<paragraph>fo<$text bold="true">o</$text>zzz<$text bold="true">[]b</$text>ar</paragraph>' );
  204. expect( doc.selection.getAttribute( 'bold' ) ).to.true;
  205. editor.execute( 'undo' );
  206. output( '<paragraph>fo<$text bold="true">o[]b</$text>ar</paragraph>' );
  207. expect( doc.selection.getAttribute( 'bold' ) ).to.true;
  208. editor.execute( 'undo' );
  209. output( '<paragraph>fo[ob]ar</paragraph>' );
  210. undoDisabled();
  211. } );
  212. } );
  213. describe( 'wrapping, unwrapping, merging, splitting', () => {
  214. it( 'wrap and undo', () => {
  215. doc.schema.allow( { name: '$text', inside: '$root' } );
  216. input( 'fo[zb]ar' );
  217. doc.enqueueChanges( () => {
  218. doc.batch().wrap( doc.selection.getFirstRange(), 'paragraph' );
  219. } );
  220. output( 'fo<paragraph>[zb]</paragraph>ar' );
  221. editor.execute( 'undo' );
  222. output( 'fo[zb]ar' );
  223. undoDisabled();
  224. } );
  225. it( 'wrap, move and undo', () => {
  226. doc.schema.allow( { name: '$text', inside: '$root' } );
  227. input( 'fo[zb]ar' );
  228. doc.enqueueChanges( () => {
  229. doc.batch().wrap( doc.selection.getFirstRange(), 'paragraph' );
  230. } );
  231. // Would be better if selection was inside P.
  232. output( 'fo<paragraph>[zb]</paragraph>ar' );
  233. doc.enqueueChanges( () => {
  234. setSelection( [ 2, 0 ], [ 2, 1 ] );
  235. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0 ] ) );
  236. } );
  237. output( '[z]fo<paragraph>b</paragraph>ar' );
  238. editor.execute( 'undo' );
  239. output( 'fo<paragraph>[z]b</paragraph>ar' );
  240. editor.execute( 'undo' );
  241. output( 'fo[zb]ar' );
  242. undoDisabled();
  243. } );
  244. it( 'unwrap and undo', () => {
  245. input( '<paragraph>foo[]bar</paragraph>' );
  246. doc.enqueueChanges( () => {
  247. doc.batch().unwrap( doc.selection.getFirstPosition().parent );
  248. } );
  249. output( 'foo[]bar' );
  250. editor.execute( 'undo' );
  251. output( '<paragraph>foo[]bar</paragraph>' );
  252. undoDisabled();
  253. } );
  254. it( 'merge and undo', () => {
  255. input( '<paragraph>foo</paragraph><paragraph>[]bar</paragraph>' );
  256. doc.enqueueChanges( () => {
  257. doc.batch().merge( new Position( root, [ 1 ] ) );
  258. // Because selection is stuck with <paragraph> it ends up in graveyard. We have to manually move it to correct node.
  259. setSelection( [ 0, 3 ], [ 0, 3 ] );
  260. } );
  261. output( '<paragraph>foo[]bar</paragraph>' );
  262. editor.execute( 'undo' );
  263. output( '<paragraph>foo</paragraph><paragraph>bar[]</paragraph>' );
  264. undoDisabled();
  265. } );
  266. it( 'split and undo', () => {
  267. input( '<paragraph>foo[]bar</paragraph>' );
  268. doc.enqueueChanges( () => {
  269. doc.batch().split( doc.selection.getFirstPosition() );
  270. // Because selection is stuck with <paragraph> it ends up in wrong node. We have to manually move it to correct node.
  271. setSelection( [ 1, 0 ], [ 1, 0 ] );
  272. } );
  273. output( '<paragraph>foo</paragraph><paragraph>[]bar</paragraph>' );
  274. editor.execute( 'undo' );
  275. output( '<paragraph>foobar[]</paragraph>' );
  276. undoDisabled();
  277. } );
  278. } );
  279. // Restoring selection in those examples may be completely off.
  280. describe( 'multiple enters, deletes and typing', () => {
  281. function split( path ) {
  282. setSelection( path.slice(), path.slice() );
  283. editor.execute( 'enter' );
  284. }
  285. function merge( path ) {
  286. const selPath = path.slice();
  287. selPath.push( 0 );
  288. setSelection( selPath, selPath.slice() );
  289. editor.execute( 'delete' );
  290. }
  291. function type( path, text ) {
  292. setSelection( path.slice(), path.slice() );
  293. editor.execute( 'input', { text } );
  294. }
  295. function remove( path ) {
  296. setSelection( path.slice(), path.slice() );
  297. editor.execute( 'delete' );
  298. }
  299. it( 'split, split, split', () => {
  300. input( '<paragraph>12345678</paragraph>' );
  301. split( [ 0, 3 ] );
  302. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  303. split( [ 1, 4 ] );
  304. output( '<paragraph>123</paragraph><paragraph>4567</paragraph><paragraph>[]8</paragraph>' );
  305. split( [ 1, 2 ] );
  306. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67</paragraph><paragraph>8</paragraph>' );
  307. editor.execute( 'undo' );
  308. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  309. editor.execute( 'undo' );
  310. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  311. editor.execute( 'undo' );
  312. output( '<paragraph>12345678[]</paragraph>' );
  313. undoDisabled();
  314. editor.execute( 'redo' );
  315. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  316. editor.execute( 'redo' );
  317. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  318. editor.execute( 'redo' );
  319. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  320. redoDisabled();
  321. } );
  322. it( 'merge, merge, merge', () => {
  323. input( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  324. merge( [ 1 ] );
  325. output( '<paragraph>123[]45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  326. merge( [ 2 ] );
  327. output( '<paragraph>12345</paragraph><paragraph>67[]8</paragraph>' );
  328. merge( [ 1 ] );
  329. output( '<paragraph>12345[]678</paragraph>' );
  330. editor.execute( 'undo' );
  331. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  332. editor.execute( 'undo' );
  333. output( '<paragraph>12345</paragraph><paragraph>67</paragraph><paragraph>8[]</paragraph>' );
  334. editor.execute( 'undo' );
  335. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  336. undoDisabled();
  337. editor.execute( 'redo' );
  338. output( '<paragraph>12345[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  339. editor.execute( 'redo' );
  340. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  341. editor.execute( 'redo' );
  342. output( '<paragraph>12345678[]</paragraph>' );
  343. redoDisabled();
  344. } );
  345. it( 'split, merge, split, merge (same position)', () => {
  346. input( '<paragraph>12345678</paragraph>' );
  347. split( [ 0, 3 ] );
  348. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  349. merge( [ 1 ] );
  350. output( '<paragraph>123[]45678</paragraph>' );
  351. split( [ 0, 3 ] );
  352. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  353. merge( [ 1 ] );
  354. output( '<paragraph>123[]45678</paragraph>' );
  355. editor.execute( 'undo' );
  356. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  357. editor.execute( 'undo' );
  358. output( '<paragraph>12345678[]</paragraph>' );
  359. editor.execute( 'undo' );
  360. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  361. editor.execute( 'undo' );
  362. output( '<paragraph>12345678[]</paragraph>' );
  363. undoDisabled();
  364. editor.execute( 'redo' );
  365. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  366. editor.execute( 'redo' );
  367. output( '<paragraph>12345678[]</paragraph>' );
  368. editor.execute( 'redo' );
  369. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  370. editor.execute( 'redo' );
  371. output( '<paragraph>12345678[]</paragraph>' );
  372. redoDisabled();
  373. } );
  374. it( 'split, split, split, merge, merge, merge', () => {
  375. input( '<paragraph>12345678</paragraph>' );
  376. split( [ 0, 3 ] );
  377. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  378. split( [ 1, 4 ] );
  379. output( '<paragraph>123</paragraph><paragraph>4567</paragraph><paragraph>[]8</paragraph>' );
  380. split( [ 1, 2 ] );
  381. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67</paragraph><paragraph>8</paragraph>' );
  382. merge( [ 1 ] );
  383. output( '<paragraph>123[]45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  384. merge( [ 2 ] );
  385. output( '<paragraph>12345</paragraph><paragraph>67[]8</paragraph>' );
  386. merge( [ 1 ] );
  387. output( '<paragraph>12345[]678</paragraph>' );
  388. editor.execute( 'undo' );
  389. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  390. editor.execute( 'undo' );
  391. output( '<paragraph>12345</paragraph><paragraph>67</paragraph><paragraph>8[]</paragraph>' );
  392. editor.execute( 'undo' );
  393. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  394. editor.execute( 'undo' );
  395. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  396. editor.execute( 'undo' );
  397. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  398. editor.execute( 'undo' );
  399. output( '<paragraph>12345678[]</paragraph>' );
  400. undoDisabled();
  401. editor.execute( 'redo' );
  402. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  403. editor.execute( 'redo' );
  404. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  405. editor.execute( 'redo' );
  406. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  407. editor.execute( 'redo' );
  408. output( '<paragraph>12345[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  409. editor.execute( 'redo' );
  410. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  411. editor.execute( 'redo' );
  412. output( '<paragraph>12345678[]</paragraph>' );
  413. redoDisabled();
  414. } );
  415. it( 'split, split, merge, split, merge (different order)', () => {
  416. input( '<paragraph>12345678</paragraph>' );
  417. split( [ 0, 3 ] );
  418. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  419. split( [ 1, 2 ] );
  420. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]678</paragraph>' );
  421. merge( [ 1 ] );
  422. output( '<paragraph>123[]45</paragraph><paragraph>678</paragraph>' );
  423. split( [ 1, 1 ] );
  424. output( '<paragraph>12345</paragraph><paragraph>6</paragraph><paragraph>[]78</paragraph>' );
  425. merge( [ 1 ] );
  426. output( '<paragraph>12345[]6</paragraph><paragraph>78</paragraph>' );
  427. editor.execute( 'undo' );
  428. output( '<paragraph>12345</paragraph><paragraph>6[]</paragraph><paragraph>78</paragraph>' );
  429. editor.execute( 'undo' );
  430. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  431. editor.execute( 'undo' );
  432. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>678</paragraph>' );
  433. editor.execute( 'undo' );
  434. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  435. editor.execute( 'undo' );
  436. output( '<paragraph>12345678[]</paragraph>' );
  437. undoDisabled();
  438. editor.execute( 'redo' );
  439. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  440. editor.execute( 'redo' );
  441. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>678</paragraph>' );
  442. editor.execute( 'redo' );
  443. output( '<paragraph>12345[]</paragraph><paragraph>678</paragraph>' );
  444. editor.execute( 'redo' );
  445. output( '<paragraph>12345</paragraph><paragraph>6[]</paragraph><paragraph>78</paragraph>' );
  446. editor.execute( 'redo' );
  447. output( '<paragraph>123456[]</paragraph><paragraph>78</paragraph>' );
  448. redoDisabled();
  449. } );
  450. it( 'split, remove, split, merge, merge', () => {
  451. input( '<paragraph>12345678</paragraph>' );
  452. split( [ 0, 3 ] );
  453. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  454. remove( [ 1, 4 ] );
  455. remove( [ 1, 3 ] );
  456. output( '<paragraph>123</paragraph><paragraph>45[]8</paragraph>' );
  457. split( [ 1, 1 ] );
  458. output( '<paragraph>123</paragraph><paragraph>4</paragraph><paragraph>[]58</paragraph>' );
  459. merge( [ 1 ] );
  460. output( '<paragraph>123[]4</paragraph><paragraph>58</paragraph>' );
  461. merge( [ 1 ] );
  462. output( '<paragraph>1234[]58</paragraph>' );
  463. editor.execute( 'undo' );
  464. output( '<paragraph>1234</paragraph><paragraph>58[]</paragraph>' );
  465. editor.execute( 'undo' );
  466. output( '<paragraph>123</paragraph><paragraph>4[]</paragraph><paragraph>58</paragraph>' );
  467. editor.execute( 'undo' );
  468. output( '<paragraph>123</paragraph><paragraph>458[]</paragraph>' );
  469. editor.execute( 'undo' );
  470. output( '<paragraph>123</paragraph><paragraph>4567[]8</paragraph>' );
  471. editor.execute( 'undo' );
  472. output( '<paragraph>12345678[]</paragraph>' );
  473. undoDisabled();
  474. editor.execute( 'redo' );
  475. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  476. editor.execute( 'redo' );
  477. output( '<paragraph>123</paragraph><paragraph>458[]</paragraph>' );
  478. editor.execute( 'redo' );
  479. output( '<paragraph>123</paragraph><paragraph>4[]</paragraph><paragraph>58</paragraph>' );
  480. editor.execute( 'redo' );
  481. output( '<paragraph>1234[]</paragraph><paragraph>58</paragraph>' );
  482. editor.execute( 'redo' );
  483. output( '<paragraph>123458[]</paragraph>' );
  484. redoDisabled();
  485. } );
  486. it( 'split, typing, split, merge, merge', () => {
  487. input( '<paragraph>12345678</paragraph>' );
  488. split( [ 0, 3 ] );
  489. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  490. type( [ 1, 4 ], 'x' );
  491. type( [ 1, 5 ], 'y' );
  492. output( '<paragraph>123</paragraph><paragraph>4567xy[]8</paragraph>' );
  493. split( [ 1, 2 ] );
  494. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67xy8</paragraph>' );
  495. merge( [ 1 ] );
  496. output( '<paragraph>123[]45</paragraph><paragraph>67xy8</paragraph>' );
  497. merge( [ 1 ] );
  498. output( '<paragraph>12345[]67xy8</paragraph>' );
  499. editor.execute( 'undo' );
  500. output( '<paragraph>12345</paragraph><paragraph>67xy8[]</paragraph>' );
  501. editor.execute( 'undo' );
  502. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67xy8</paragraph>' );
  503. editor.execute( 'undo' );
  504. output( '<paragraph>123</paragraph><paragraph>4567xy8[]</paragraph>' );
  505. editor.execute( 'undo' );
  506. output( '<paragraph>123</paragraph><paragraph>4567[]8</paragraph>' );
  507. editor.execute( 'undo' );
  508. output( '<paragraph>12345678[]</paragraph>' );
  509. undoDisabled();
  510. editor.execute( 'redo' );
  511. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  512. editor.execute( 'redo' );
  513. output( '<paragraph>123</paragraph><paragraph>4567xy8[]</paragraph>' );
  514. editor.execute( 'redo' );
  515. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67xy8</paragraph>' );
  516. editor.execute( 'redo' );
  517. output( '<paragraph>12345[]</paragraph><paragraph>67xy8</paragraph>' );
  518. editor.execute( 'redo' );
  519. output( '<paragraph>1234567xy8[]</paragraph>' );
  520. redoDisabled();
  521. } );
  522. } );
  523. describe( 'other reported cases', () => {
  524. // ckeditor5-engine#t/1051
  525. it( 'rename leaks to other elements on undo #1', () => {
  526. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  527. doc.batch().rename( root.getChild( 0 ), 'paragraph' );
  528. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  529. doc.batch().split( Position.createAt( root.getChild( 0 ), 1 ) );
  530. output( '<paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph>' );
  531. doc.batch().merge( Position.createAt( root, 2 ) );
  532. output( '<paragraph>[]F</paragraph><paragraph>ooBar</paragraph>' );
  533. editor.execute( 'undo' );
  534. output( '<paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph>' );
  535. editor.execute( 'undo' );
  536. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  537. editor.execute( 'undo' );
  538. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  539. } );
  540. // Similar issue that bases on the same error as above, however here we first merge (above we first split).
  541. it( 'rename leaks to other elements on undo #2', () => {
  542. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  543. doc.batch().rename( root.getChild( 0 ), 'heading2' );
  544. output( '<heading2>[]Foo</heading2><paragraph>Bar</paragraph>' );
  545. doc.batch().merge( Position.createAt( root, 1 ) );
  546. output( '<heading2>[]FooBar</heading2>' );
  547. editor.execute( 'undo' );
  548. output( '<heading2>[]Foo</heading2><paragraph>Bar</paragraph>' );
  549. editor.execute( 'undo' );
  550. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  551. } );
  552. // Reverse issue, this time first operation is merge and then rename.
  553. it( 'merge, rename, undo, undo is correct', () => {
  554. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  555. doc.batch().merge( Position.createAt( root, 1 ) );
  556. output( '<heading1>[]FooBar</heading1>' );
  557. doc.batch().rename( root.getChild( 0 ), 'heading2' );
  558. output( '<heading2>[]FooBar</heading2>' );
  559. editor.execute( 'undo' );
  560. output( '<heading1>[]FooBar</heading1>' );
  561. editor.execute( 'undo' );
  562. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  563. } );
  564. // ckeditor5-engine#t/1053
  565. it( 'wrap, split, undo, undo is correct', () => {
  566. input( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  567. doc.batch().wrap( Range.createIn( root ), 'div' );
  568. output( '<div><paragraph>[]Foo</paragraph><paragraph>Bar</paragraph></div>' );
  569. doc.batch().split( new Position( root, [ 0, 0, 1 ] ) );
  570. output( '<div><paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph></div>' );
  571. editor.execute( 'undo' );
  572. output( '<div><paragraph>[]Foo</paragraph><paragraph>Bar</paragraph></div>' );
  573. editor.execute( 'undo' );
  574. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  575. } );
  576. // ckeditor5-engine#t/1055
  577. it( 'selection attribute setting: split, bold, merge, undo, undo, undo', () => {
  578. input( '<paragraph>Foo[]</paragraph><paragraph>Bar</paragraph>' );
  579. editor.execute( 'enter' );
  580. output( '<paragraph>Foo</paragraph><paragraph>[]</paragraph><paragraph>Bar</paragraph>' );
  581. editor.execute( 'bold' );
  582. output(
  583. '<paragraph>Foo</paragraph>' +
  584. '<paragraph selection:bold="true"><$text bold="true">[]</$text></paragraph>' +
  585. '<paragraph>Bar</paragraph>'
  586. );
  587. editor.execute( 'forwardDelete' );
  588. output( '<paragraph>Foo</paragraph><paragraph>[]Bar</paragraph>' );
  589. editor.execute( 'undo' );
  590. output(
  591. '<paragraph>Foo</paragraph>' +
  592. '<paragraph selection:bold="true"><$text bold="true">[]</$text></paragraph>' +
  593. '<paragraph>Bar</paragraph>'
  594. );
  595. editor.execute( 'undo' );
  596. output( '<paragraph>Foo</paragraph><paragraph>[]</paragraph><paragraph>Bar</paragraph>' );
  597. editor.execute( 'undo' );
  598. output( '<paragraph>Foo[]</paragraph><paragraph>Bar</paragraph>' );
  599. } );
  600. } );
  601. describe( 'pasting', () => {
  602. function pasteHtml( editor, html ) {
  603. editor.editing.view.fire( 'paste', {
  604. dataTransfer: createDataTransfer( { 'text/html': html } ),
  605. preventDefault() {}
  606. } );
  607. }
  608. function createDataTransfer( data ) {
  609. return {
  610. getData( type ) {
  611. return data[ type ];
  612. }
  613. };
  614. }
  615. // ckeditor5-engine#t/1065
  616. it( 'undo paste into non empty element should not throw and be correct', () => {
  617. doc.enqueueChanges( () => {
  618. input( '<paragraph>Foo[]</paragraph>' );
  619. } );
  620. doc.enqueueChanges( () => {
  621. pasteHtml( editor, '<p>a</p><p>b</p>' );
  622. } );
  623. output( '<paragraph>Fooa</paragraph><paragraph>b[]</paragraph>' );
  624. doc.enqueueChanges( () => {
  625. pasteHtml( editor, '<p>c</p><p>d</p>' );
  626. } );
  627. output( '<paragraph>Fooa</paragraph><paragraph>bc</paragraph><paragraph>d[]</paragraph>' );
  628. editor.execute( 'undo' );
  629. output( '<paragraph>Fooa</paragraph><paragraph>b[]</paragraph>' );
  630. editor.execute( 'undo' );
  631. output( '<paragraph>Foo[]</paragraph>' );
  632. } );
  633. } );
  634. describe( 'other edge cases', () => {
  635. it( 'deleteContent between two nodes', () => {
  636. input( '<paragraph>fo[o</paragraph><paragraph>b]ar</paragraph>' );
  637. doc.enqueueChanges( () => {
  638. editor.data.deleteContent( doc.selection, doc.batch() );
  639. } );
  640. output( '<paragraph>fo[]ar</paragraph>' );
  641. editor.execute( 'undo' );
  642. output( '<paragraph>fo[o</paragraph><paragraph>b]ar</paragraph>' );
  643. } );
  644. // Related to ckeditor5-engine#891 and ckeditor5-list#51.
  645. it( 'change attribute of removed node then undo and redo', () => {
  646. input( '<paragraph></paragraph>' );
  647. const gy = doc.graveyard;
  648. const p = doc.getRoot().getChild( 0 );
  649. doc.enqueueChanges( () => {
  650. doc.batch().remove( p );
  651. doc.batch().setAttribute( p, 'bold', true );
  652. } );
  653. editor.execute( 'undo' );
  654. editor.execute( 'redo' );
  655. expect( p.root ).to.equal( gy );
  656. expect( p.getAttribute( 'bold' ) ).to.be.true;
  657. } );
  658. } );
  659. } );