renderer.js 150 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265
  1. /**
  2. * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  4. */
  5. /* globals document, window, NodeFilter, MutationObserver */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewEditableElement from '../../src/view/editableelement';
  9. import ViewContainerElement from '../../src/view/containerelement';
  10. import ViewAttributeElement from '../../src/view/attributeelement';
  11. import ViewText from '../../src/view/text';
  12. import ViewRange from '../../src/view/range';
  13. import ViewPosition from '../../src/view/position';
  14. import UIElement from '../../src/view/uielement';
  15. import DocumentSelection from '../../src/view/documentselection';
  16. import DomConverter from '../../src/view/domconverter';
  17. import Renderer from '../../src/view/renderer';
  18. import DocumentFragment from '../../src/view/documentfragment';
  19. import ViewDocument from '../../src/view/document';
  20. import DowncastWriter from '../../src/view/downcastwriter';
  21. import { parse, stringify, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  22. import { BR_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../../src/view/filler';
  23. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  24. import createViewRoot from './_utils/createroot';
  25. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  26. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  27. import env from '@ckeditor/ckeditor5-utils/src/env';
  28. import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
  29. import { StylesProcessor } from '../../src/view/stylesmap';
  30. describe( 'Renderer', () => {
  31. let selection, domConverter, renderer, viewDocument;
  32. testUtils.createSinonSandbox();
  33. beforeEach( () => {
  34. viewDocument = new ViewDocument( new StylesProcessor() );
  35. selection = new DocumentSelection();
  36. domConverter = new DomConverter( viewDocument );
  37. renderer = new Renderer( domConverter, selection );
  38. renderer.domDocuments.add( document );
  39. } );
  40. describe( 'markToSync', () => {
  41. let viewRoot;
  42. beforeEach( () => {
  43. viewRoot = new ViewElement( viewDocument, 'p' );
  44. const domRoot = document.createElement( 'p' );
  45. domConverter.bindElements( domRoot, viewRoot );
  46. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  47. renderer.markedTexts.clear();
  48. renderer.markedAttributes.clear();
  49. renderer.markedChildren.clear();
  50. } );
  51. it( 'should mark attributes which need update', () => {
  52. viewRoot._setAttribute( 'class', 'foo' );
  53. renderer.markToSync( 'attributes', viewRoot );
  54. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  55. } );
  56. it( 'should mark children which need update', () => {
  57. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  58. renderer.markToSync( 'children', viewRoot );
  59. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  60. } );
  61. it( 'should not mark children if element has no corresponding node', () => {
  62. // Overwrite viewRoot with node without coresponding DOM node.
  63. viewRoot = new ViewElement( viewDocument, 'p' );
  64. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  65. renderer.markToSync( 'children', viewRoot );
  66. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  67. } );
  68. it( 'should mark text which need update', () => {
  69. const viewText = new ViewText( viewDocument, 'foo' );
  70. viewRoot._appendChild( viewText );
  71. viewText._data = 'bar';
  72. renderer.markToSync( 'text', viewText );
  73. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  74. } );
  75. it( 'should not mark text if parent has no corresponding node', () => {
  76. const viewText = new ViewText( viewDocument, 'foo' );
  77. // Overwrite viewRoot with node without coresponding DOM node.
  78. viewRoot = new ViewElement( viewDocument, 'p' );
  79. viewRoot._appendChild( viewText );
  80. viewText._data = 'bar';
  81. renderer.markToSync( 'text', viewText );
  82. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  83. } );
  84. it( 'should throw if the type is unknown', () => {
  85. expectToThrowCKEditorError( () => {
  86. renderer.markToSync( 'UNKNOWN', viewRoot );
  87. }, /^view-renderer-unknown-type/, selection );
  88. } );
  89. } );
  90. describe( 'render', () => {
  91. let viewRoot, domRoot;
  92. beforeEach( () => {
  93. viewRoot = new ViewEditableElement( viewDocument, 'div' );
  94. viewRoot.getFillerOffset = () => null;
  95. domRoot = document.createElement( 'div' );
  96. document.body.appendChild( domRoot );
  97. domConverter.bindElements( domRoot, viewRoot );
  98. renderer.markedTexts.clear();
  99. renderer.markedAttributes.clear();
  100. renderer.markedChildren.clear();
  101. selection._setTo( null );
  102. renderer.isFocused = true;
  103. } );
  104. afterEach( () => {
  105. domRoot.remove();
  106. } );
  107. it( 'should update attributes', () => {
  108. viewRoot._setAttribute( 'class', 'foo' );
  109. renderer.markToSync( 'attributes', viewRoot );
  110. renderer.render();
  111. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  112. expect( renderer.markedAttributes.size ).to.equal( 0 );
  113. } );
  114. it( 'should remove attributes', () => {
  115. viewRoot._setAttribute( 'class', 'foo' );
  116. domRoot.setAttribute( 'id', 'bar' );
  117. domRoot.setAttribute( 'class', 'bar' );
  118. renderer.markToSync( 'attributes', viewRoot );
  119. renderer.render();
  120. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  121. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  122. expect( renderer.markedAttributes.size ).to.equal( 0 );
  123. } );
  124. it( 'should add children', () => {
  125. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  126. renderer.markToSync( 'children', viewRoot );
  127. renderer.render();
  128. expect( domRoot.childNodes.length ).to.equal( 1 );
  129. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  130. expect( renderer.markedChildren.size ).to.equal( 0 );
  131. } );
  132. it( 'should remove children', () => {
  133. viewRoot._appendChild( new ViewText( viewDocument, 'foo' ) );
  134. renderer.markToSync( 'children', viewRoot );
  135. renderer.render();
  136. expect( domRoot.childNodes.length ).to.equal( 1 );
  137. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  138. viewRoot._removeChildren( 0, 1 );
  139. renderer.markToSync( 'children', viewRoot );
  140. renderer.render();
  141. expect( domRoot.childNodes.length ).to.equal( 0 );
  142. expect( renderer.markedChildren.size ).to.equal( 0 );
  143. } );
  144. it( 'should update text', () => {
  145. const viewText = new ViewText( viewDocument, 'foo' );
  146. viewRoot._appendChild( viewText );
  147. renderer.markToSync( 'children', viewRoot );
  148. renderer.render();
  149. expect( domRoot.childNodes.length ).to.equal( 1 );
  150. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  151. viewText._data = 'bar';
  152. renderer.markToSync( 'text', viewText );
  153. renderer.render();
  154. expect( domRoot.childNodes.length ).to.equal( 1 );
  155. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  156. expect( renderer.markedTexts.size ).to.equal( 0 );
  157. } );
  158. it( 'should not update same text', () => {
  159. const viewText = new ViewText( viewDocument, 'foo' );
  160. viewRoot._appendChild( viewText );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.render();
  163. expect( domRoot.childNodes.length ).to.equal( 1 );
  164. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  165. viewText._data = 'foo';
  166. renderer.markToSync( 'text', viewText );
  167. renderAndExpectNoChanges( renderer, domRoot );
  168. expect( domRoot.childNodes.length ).to.equal( 1 );
  169. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  170. expect( renderer.markedTexts.size ).to.equal( 0 );
  171. } );
  172. it( 'should not update text parent child list changed', () => {
  173. const viewImg = new ViewElement( viewDocument, 'img' );
  174. const viewText = new ViewText( viewDocument, 'foo' );
  175. viewRoot._appendChild( [ viewImg, viewText ] );
  176. renderer.markToSync( 'children', viewRoot );
  177. renderer.markToSync( 'text', viewText );
  178. renderer.render();
  179. expect( domRoot.childNodes.length ).to.equal( 2 );
  180. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  181. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  182. } );
  183. it( 'should not change text if it is the same during text rendering', () => {
  184. const viewText = new ViewText( viewDocument, 'foo' );
  185. viewRoot._appendChild( viewText );
  186. renderer.markToSync( 'children', viewRoot );
  187. renderer.render();
  188. // This should not be changed during the render.
  189. const domText = domRoot.childNodes[ 0 ];
  190. renderer.markToSync( 'text', viewText );
  191. renderer.render();
  192. expect( domRoot.childNodes.length ).to.equal( 1 );
  193. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  194. } );
  195. it( 'should not change text if it is the same during children rendering', () => {
  196. const viewText = new ViewText( viewDocument, 'foo' );
  197. viewRoot._appendChild( viewText );
  198. renderer.markToSync( 'children', viewRoot );
  199. renderer.render();
  200. // This should not be changed during the render.
  201. const domText = domRoot.childNodes[ 0 ];
  202. renderer.markToSync( 'children', viewRoot );
  203. renderer.render();
  204. expect( domRoot.childNodes.length ).to.equal( 1 );
  205. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  206. } );
  207. it( 'should not change element if it is the same', () => {
  208. const viewImg = new ViewElement( viewDocument, 'img' );
  209. viewRoot._appendChild( viewImg );
  210. // This should not be changed during the render.
  211. const domImg = document.createElement( 'img' );
  212. domRoot.appendChild( domImg );
  213. domConverter.bindElements( domImg, viewImg );
  214. renderer.markToSync( 'children', viewRoot );
  215. renderer.render();
  216. expect( domRoot.childNodes.length ).to.equal( 1 );
  217. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  218. } );
  219. it( 'should change element if it is different', () => {
  220. const viewImg = new ViewElement( viewDocument, 'img' );
  221. viewRoot._appendChild( viewImg );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. const viewP = new ViewElement( viewDocument, 'p' );
  225. viewRoot._removeChildren( 0, 1 );
  226. viewRoot._appendChild( viewP );
  227. renderer.markToSync( 'children', viewRoot );
  228. renderer.render();
  229. expect( domRoot.childNodes.length ).to.equal( 1 );
  230. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  231. } );
  232. it( 'should update removed item when it is reinserted', () => {
  233. const viewFoo = new ViewText( viewDocument, 'foo' );
  234. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  235. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  236. viewRoot._appendChild( viewDiv );
  237. renderer.markToSync( 'children', viewRoot );
  238. renderer.render();
  239. viewDiv._removeChildren( 0, 1 );
  240. renderer.markToSync( 'children', viewDiv );
  241. renderer.render();
  242. viewP._removeChildren( 0, 1 );
  243. viewDiv._appendChild( viewP );
  244. renderer.markToSync( 'children', viewDiv );
  245. renderer.render();
  246. expect( domRoot.childNodes.length ).to.equal( 1 );
  247. const domDiv = domRoot.childNodes[ 0 ];
  248. expect( domDiv.tagName ).to.equal( 'DIV' );
  249. expect( domDiv.childNodes.length ).to.equal( 1 );
  250. const domP = domDiv.childNodes[ 0 ];
  251. expect( domP.tagName ).to.equal( 'P' );
  252. expect( domP.childNodes.length ).to.equal( 0 );
  253. } );
  254. it( 'should update removed item when it is reinserted #2', () => {
  255. // Prepare view: root -> div "outer" -> div "inner" -> p.
  256. const viewP = new ViewElement( viewDocument, 'p' );
  257. const viewDivInner = new ViewElement( viewDocument, 'div', null, viewP );
  258. const viewDivOuter = new ViewElement( viewDocument, 'div', null, viewDivInner );
  259. viewRoot._appendChild( viewDivOuter );
  260. // Render view tree to DOM.
  261. renderer.markToSync( 'children', viewRoot );
  262. renderer.render();
  263. // Remove div "outer" from root and render it.
  264. viewDivOuter._remove();
  265. renderer.markToSync( 'children', viewRoot );
  266. renderer.render();
  267. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  268. viewP._remove();
  269. // Add div "outer" back to root.
  270. viewRoot._appendChild( viewDivOuter );
  271. renderer.markToSync( 'children', viewRoot );
  272. // Render changes, view is: root -> div "outer" -> div "inner".
  273. renderer.render();
  274. // Same is expected in DOM.
  275. expect( domRoot.childNodes.length ).to.equal( 1 );
  276. const domDivOuter = domRoot.childNodes[ 0 ];
  277. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  278. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  279. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  280. const domDivInner = domDivOuter.childNodes[ 0 ];
  281. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  282. expect( domDivInner.tagName ).to.equal( 'DIV' );
  283. expect( domDivInner.childNodes.length ).to.equal( 0 );
  284. } );
  285. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  286. const viewFoo = new ViewText( viewDocument, 'foo' );
  287. const viewP = new ViewElement( viewDocument, 'p', null, viewFoo );
  288. const viewDiv = new ViewElement( viewDocument, 'div', null, viewP );
  289. viewRoot._appendChild( viewDiv );
  290. renderer.markToSync( 'children', viewRoot );
  291. renderer.render();
  292. viewRoot._removeChildren( 0, 1 );
  293. renderer.markToSync( 'children', viewRoot );
  294. viewDiv._removeChildren( 0, 1 );
  295. renderer.markToSync( 'children', viewDiv );
  296. viewP._removeChildren( 0, 1 );
  297. renderer.markToSync( 'children', viewP );
  298. renderer.render();
  299. expect( domRoot.childNodes.length ).to.equal( 0 );
  300. } );
  301. it( 'should not care about filler if there is no DOM', () => {
  302. const { view: viewP, selection: newSelection } = parse(
  303. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  304. const viewRoot = new ViewElement( viewDocument, 'p' );
  305. viewRoot._appendChild( viewP );
  306. selection._setTo( newSelection );
  307. renderer.markToSync( 'children', viewRoot );
  308. renderer.render();
  309. // Expect no error on render.
  310. expect( viewRoot ).to.be.ok;
  311. } );
  312. it( 'should not add filler when inside contenteditable=false parent', () => {
  313. const { view: viewP, selection: newSelection } = parse(
  314. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  315. viewRoot._appendChild( viewP );
  316. selection._setTo( newSelection );
  317. renderer.markToSync( 'children', viewRoot );
  318. renderer.render();
  319. expect( domRoot.childNodes.length ).to.equal( 1 );
  320. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  321. const domP = domRoot.childNodes[ 0 ];
  322. expect( domP.childNodes.length ).to.equal( 3 );
  323. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  324. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  325. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  326. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  327. } );
  328. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  329. const { view: viewP, selection: newSelection } = parse(
  330. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  331. viewRoot._appendChild( viewP );
  332. selection._setTo( newSelection );
  333. renderer.markToSync( 'children', viewRoot );
  334. renderer.render();
  335. expect( domRoot.childNodes.length ).to.equal( 1 );
  336. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  337. const domP = domRoot.childNodes[ 0 ];
  338. expect( domP.childNodes.length ).to.equal( 3 );
  339. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  340. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  341. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  342. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  343. } );
  344. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  345. const domSelection = document.getSelection();
  346. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  347. const { view: viewP, selection: newSelection } = parse(
  348. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  349. viewRoot._appendChild( viewP );
  350. selection._setTo( newSelection );
  351. renderer.markToSync( 'children', viewRoot );
  352. renderer.render();
  353. expect( domRoot.childNodes.length ).to.equal( 1 );
  354. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  355. const domP = domRoot.childNodes[ 0 ];
  356. expect( domP.childNodes.length ).to.equal( 3 );
  357. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  358. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  359. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  360. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  361. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  362. expect( domSelection.rangeCount ).to.equal( 1 );
  363. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  364. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  365. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  366. // Step 2: No mutation on second render
  367. renderer.markToSync( 'children', viewRoot );
  368. renderer.markToSync( 'children', viewP );
  369. renderAndExpectNoChanges( renderer, domRoot );
  370. // Step 3: <p>foo{}<b></b></p>
  371. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  372. renderer.render();
  373. expect( domP.childNodes.length ).to.equal( 3 );
  374. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  375. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  376. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  377. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  378. expect( domSelection.rangeCount ).to.equal( 1 );
  379. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  380. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  381. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  382. // Step 4: No mutation on second render
  383. renderer.markToSync( 'children', viewRoot );
  384. renderer.markToSync( 'children', viewP );
  385. renderAndExpectNoChanges( renderer, domRoot );
  386. } );
  387. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  388. const domSelection = document.getSelection();
  389. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  390. const { view: viewP, selection: newSelection } = parse(
  391. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  392. viewRoot._appendChild( viewP );
  393. selection._setTo( newSelection );
  394. renderer.markToSync( 'children', viewRoot );
  395. renderer.render();
  396. const domP = domRoot.childNodes[ 0 ];
  397. expect( domP.childNodes.length ).to.equal( 2 );
  398. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  399. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  400. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  401. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  402. expect( domSelection.rangeCount ).to.equal( 1 );
  403. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  404. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  405. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  406. // Step 2: No mutation on second render
  407. renderer.markToSync( 'children', viewP );
  408. renderAndExpectNoChanges( renderer, domRoot );
  409. // Step 3: <p><b>{}foo</b></p>
  410. selection._setTo( ViewRange._createFromParentsAndOffsets(
  411. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  412. renderer.render();
  413. expect( domP.childNodes.length ).to.equal( 1 );
  414. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  415. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  416. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  417. expect( domSelection.rangeCount ).to.equal( 1 );
  418. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  419. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  420. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  421. // Step 4: No mutation on second render
  422. renderer.markToSync( 'children', viewP );
  423. renderAndExpectNoChanges( renderer, domRoot );
  424. } );
  425. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  426. const domSelection = document.getSelection();
  427. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  428. const { view: viewP, selection: newSelection } = parse(
  429. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  430. viewRoot._appendChild( viewP );
  431. selection._setTo( newSelection );
  432. renderer.markToSync( 'children', viewRoot );
  433. renderer.render();
  434. const domP = domRoot.childNodes[ 0 ];
  435. expect( domP.childNodes.length ).to.equal( 2 );
  436. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  437. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  438. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  439. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  440. expect( domSelection.rangeCount ).to.equal( 1 );
  441. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  442. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  443. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  444. // Step 2: No mutation on second render
  445. renderer.markToSync( 'children', viewP );
  446. renderAndExpectNoChanges( renderer, domRoot );
  447. // Step 3: <p><b>foo{}</b></p>
  448. selection._setTo( ViewRange._createFromParentsAndOffsets(
  449. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  450. renderer.render();
  451. expect( domP.childNodes.length ).to.equal( 1 );
  452. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  453. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  454. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  455. expect( domSelection.rangeCount ).to.equal( 1 );
  456. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  457. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  458. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  459. // Step 4: No mutation on second render
  460. renderer.markToSync( 'children', viewP );
  461. renderAndExpectNoChanges( renderer, domRoot );
  462. } );
  463. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  464. const domSelection = document.getSelection();
  465. const { view: viewP, selection: newSelection } = parse(
  466. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  467. viewRoot._appendChild( viewP );
  468. selection._setTo( newSelection );
  469. renderer.markToSync( 'children', viewRoot );
  470. renderer.render();
  471. const domP = domRoot.childNodes[ 0 ];
  472. expect( domP.childNodes.length ).to.equal( 3 );
  473. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  474. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  475. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  476. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  477. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  478. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  479. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  480. expect( domSelection.rangeCount ).to.equal( 1 );
  481. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  482. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  483. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  484. } );
  485. it( 'should move filler when selection is moved', () => {
  486. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  487. const { view: viewP, selection: newSelection } = parse(
  488. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  489. viewRoot._appendChild( viewP );
  490. selection._setTo( newSelection );
  491. renderer.markToSync( 'children', viewRoot );
  492. renderer.render();
  493. const domP = domRoot.childNodes[ 0 ];
  494. expect( domP.childNodes.length ).to.equal( 3 );
  495. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  496. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  497. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  498. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  499. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  500. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  501. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  502. const viewI = viewP.getChild( 2 );
  503. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  504. renderer.render();
  505. expect( domP.childNodes.length ).to.equal( 3 );
  506. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  507. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  508. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  509. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  510. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  511. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  512. } );
  513. it( 'should remove filler when text is added and selection removed', () => {
  514. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  515. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  516. const viewB = viewP.getChild( 1 );
  517. viewRoot._appendChild( viewP );
  518. selection._setTo( newSelection );
  519. renderer.markToSync( 'children', viewRoot );
  520. renderer.render();
  521. const domP = domRoot.childNodes[ 0 ];
  522. expect( domP.childNodes.length ).to.equal( 2 );
  523. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  524. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  525. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  526. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  527. // Step 2: Add text node.
  528. const viewText = new ViewText( viewDocument, 'x' );
  529. viewB._appendChild( viewText );
  530. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  531. renderer.markToSync( 'children', viewB );
  532. renderer.render();
  533. // Step 3: Remove selection from the view.
  534. selection._setTo( null );
  535. renderer.render();
  536. expect( domP.childNodes.length ).to.equal( 2 );
  537. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  538. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  539. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  540. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  541. } );
  542. // #659
  543. // The element before the filler is removed so the position of the filler
  544. // cannot be remembered as parent+offset.
  545. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  546. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  547. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  548. viewRoot._appendChild( viewP );
  549. selection._setTo( newSelection );
  550. renderer.markToSync( 'children', viewRoot );
  551. renderer.render();
  552. const domP = domRoot.childNodes[ 0 ];
  553. expect( domP.childNodes.length ).to.equal( 3 );
  554. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  555. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  556. viewP._removeChildren( 1 );
  557. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  558. renderer.markToSync( 'children', viewP );
  559. renderer.render();
  560. // Step 3: Check whether there's no filler in the DOM.
  561. expect( domP.childNodes.length ).to.equal( 1 );
  562. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  563. } );
  564. // #659
  565. it( 'should remove filler from a modified DOM when children moved', () => {
  566. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  567. const { view: viewFragment, selection: newSelection } = parse(
  568. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  569. );
  570. viewRoot._appendChild( viewFragment );
  571. selection._setTo( newSelection );
  572. renderer.markToSync( 'children', viewRoot );
  573. renderer.render();
  574. expect( domRoot.childNodes.length ).to.equal( 2 );
  575. const domP = domRoot.childNodes[ 0 ];
  576. const domP2 = domRoot.childNodes[ 1 ];
  577. expect( domP.childNodes.length ).to.equal( 3 );
  578. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  579. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  580. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  581. const viewP = viewRoot.getChild( 0 );
  582. const viewP2 = viewRoot.getChild( 1 );
  583. const removedChildren = viewP._removeChildren( 0, 2 );
  584. viewP2._appendChild( removedChildren );
  585. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  586. renderer.markToSync( 'children', viewP );
  587. renderer.markToSync( 'children', viewP2 );
  588. renderer.render();
  589. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  590. // in the second one there are two <b> tags.
  591. expect( domP.childNodes.length ).to.equal( 1 );
  592. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  593. expect( domP2.childNodes.length ).to.equal( 2 );
  594. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  595. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  596. } );
  597. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  598. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  599. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  600. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  601. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  602. viewRoot._appendChild( viewP );
  603. selection._setTo( newSelection );
  604. renderer.markToSync( 'children', viewRoot );
  605. renderer.render();
  606. const domP = domRoot.childNodes[ 0 ];
  607. expect( domP.childNodes.length ).to.equal( 2 );
  608. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  609. // Step 2: Move selection to a new attribute element and remove the previous one
  610. viewP._removeChildren( 1 ); // Remove <b>.
  611. const viewI = parse( '<attribute:i></attribute:i>' );
  612. viewP._appendChild( viewI );
  613. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  614. renderer.markToSync( 'children', viewP );
  615. renderer.render();
  616. // Step 3: Check whether new filler was created in the <i> element.
  617. expect( domP.childNodes.length ).to.equal( 2 );
  618. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  619. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  620. } );
  621. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  622. // that has not been yet rendered/bound to DOM.
  623. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  624. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  625. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  626. viewRoot._appendChild( viewP );
  627. selection._setTo( newSelection );
  628. renderer.markToSync( 'children', viewRoot );
  629. renderer.render();
  630. const domP = domRoot.childNodes[ 0 ];
  631. expect( domP.childNodes.length ).to.equal( 3 );
  632. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  633. // Step 2: Move selection to a new attribute element.
  634. const viewAbc = parse( 'abc' );
  635. viewP._appendChild( viewAbc );
  636. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  637. renderer.markToSync( 'children', viewP );
  638. renderer.render();
  639. // Step 3: Check whether old filler was removed.
  640. expect( domP.childNodes.length ).to.equal( 3 );
  641. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  642. } );
  643. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  644. const domSelection = document.getSelection();
  645. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  646. viewRoot._appendChild( viewP );
  647. selection._setTo( newSelection );
  648. renderer.markToSync( 'children', viewRoot );
  649. renderer.render();
  650. const domP = domRoot.childNodes[ 0 ];
  651. expect( domP.childNodes.length ).to.equal( 1 );
  652. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  653. expect( domSelection.rangeCount ).to.equal( 1 );
  654. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  655. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  656. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  657. // Remove filler and add text node to both DOM and View <p>x{}</p>
  658. domP.removeChild( domP.childNodes[ 0 ] );
  659. domP.appendChild( document.createTextNode( 'x' ) );
  660. domSelection.removeAllRanges();
  661. const domRange = document.createRange();
  662. domRange.setStart( domP.childNodes[ 0 ], 1 );
  663. domRange.collapse( true );
  664. domSelection.addRange( domRange );
  665. const viewText = new ViewText( viewDocument, 'x' );
  666. viewP._appendChild( viewText );
  667. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  668. renderer.markToSync( 'children', viewP );
  669. renderAndExpectNoChanges( renderer, domRoot );
  670. } );
  671. it( 'should handle typing in empty block, render if needed', () => {
  672. const domSelection = document.getSelection();
  673. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  674. viewRoot._appendChild( viewP );
  675. selection._setTo( newSelection );
  676. renderer.markToSync( 'children', viewRoot );
  677. renderer.render();
  678. const domP = domRoot.childNodes[ 0 ];
  679. expect( domP.childNodes.length ).to.equal( 1 );
  680. expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
  681. expect( domSelection.rangeCount ).to.equal( 1 );
  682. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  683. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  684. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  685. // Add text node only in View <p>x{}</p>
  686. const viewText = new ViewText( viewDocument, 'x' );
  687. viewP._appendChild( viewText );
  688. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  689. renderer.markToSync( 'children', viewP );
  690. renderer.render();
  691. expect( domP.childNodes.length ).to.equal( 1 );
  692. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  693. expect( domSelection.rangeCount ).to.equal( 1 );
  694. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  695. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  696. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  697. } );
  698. it( 'should handle removing last character', () => {
  699. const domSelection = document.getSelection();
  700. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  701. viewRoot._appendChild( viewP );
  702. selection._setTo( newSelection );
  703. renderer.markToSync( 'children', viewRoot );
  704. renderer.render();
  705. const domP = domRoot.childNodes[ 0 ];
  706. expect( domP.childNodes.length ).to.equal( 1 );
  707. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  708. expect( domSelection.rangeCount ).to.equal( 1 );
  709. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  710. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  711. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  712. // Remove text and add filler to both DOM and View <p>{}</p>
  713. domP.removeChild( domP.childNodes[ 0 ] );
  714. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  715. domSelection.removeAllRanges();
  716. const domRange = document.createRange();
  717. domRange.setStart( domP.childNodes[ 0 ], 0 );
  718. domRange.collapse( true );
  719. domSelection.addRange( domRange );
  720. viewP._removeChildren( 0 );
  721. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  722. renderer.markToSync( 'children', viewP );
  723. renderAndExpectNoChanges( renderer, domRoot );
  724. } );
  725. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  726. const domSelection = document.getSelection();
  727. // 1. Render <p><b>FILLER{}</b>foo</p>.
  728. const { view: viewP, selection: newSelection } = parse(
  729. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  730. viewRoot._appendChild( viewP );
  731. selection._setTo( newSelection );
  732. renderer.markToSync( 'children', viewRoot );
  733. renderer.render();
  734. // 2. Check the DOM.
  735. const domP = domRoot.childNodes[ 0 ];
  736. expect( domP.childNodes.length ).to.equal( 2 );
  737. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  738. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  739. const domB = domP.childNodes[ 0 ];
  740. const viewB = viewP.getChild( 0 );
  741. expect( domB.childNodes.length ).to.equal( 1 );
  742. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  743. expect( domSelection.rangeCount ).to.equal( 1 );
  744. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  745. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  746. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  747. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  748. domB.childNodes[ 0 ].data += 'x';
  749. domSelection.removeAllRanges();
  750. const domRange = document.createRange();
  751. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  752. domRange.collapse( true );
  753. domSelection.addRange( domRange );
  754. const viewText = new ViewText( viewDocument, 'x' );
  755. viewB._appendChild( viewText );
  756. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  757. renderer.markToSync( 'children', viewP );
  758. renderAndExpectNoChanges( renderer, domRoot );
  759. } );
  760. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  761. const domSelection = document.getSelection();
  762. // 1. Render <p><b>FILLER{}</b>foo</p>.
  763. const { view: viewP, selection: newSelection } = parse(
  764. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  765. viewRoot._appendChild( viewP );
  766. selection._setTo( newSelection );
  767. renderer.markToSync( 'children', viewRoot );
  768. renderer.render();
  769. // 2. Check the DOM.
  770. const domP = domRoot.childNodes[ 0 ];
  771. expect( domP.childNodes.length ).to.equal( 2 );
  772. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  773. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  774. const domB = domP.childNodes[ 0 ];
  775. const viewB = viewP.getChild( 0 );
  776. expect( domB.childNodes.length ).to.equal( 1 );
  777. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  778. expect( domSelection.rangeCount ).to.equal( 1 );
  779. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  780. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  781. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  782. domSelection.removeAllRanges();
  783. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  784. const viewText = new ViewText( viewDocument, 'x' );
  785. viewB._appendChild( viewText );
  786. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  787. renderer.markToSync( 'children', viewB );
  788. renderer.render();
  789. expect( domB.childNodes.length ).to.equal( 1 );
  790. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  791. expect( domSelection.rangeCount ).to.equal( 1 );
  792. // Depending on the browser selection may end up at the end of the text node or after the text node.
  793. const firstRange = domSelection.getRangeAt( 0 );
  794. const assertSelectionAtEndOfTextNode = () => {
  795. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  796. };
  797. const assertSelectionInsideTextNode = () => {
  798. expect( firstRange.startContainer ).to.equal( domB );
  799. expect( firstRange.startOffset ).to.equal( 1 );
  800. };
  801. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  802. expect( firstRange.collapsed ).to.be.true;
  803. } );
  804. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  805. const domSelection = document.getSelection();
  806. // 1. Render <p><b>FILLER{}</b>foo</p>.
  807. const { view: viewP, selection: newSelection } = parse(
  808. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  809. viewRoot._appendChild( viewP );
  810. selection._setTo( newSelection );
  811. renderer.markToSync( 'children', viewRoot );
  812. renderer.render();
  813. // 2. Check the DOM.
  814. const domP = domRoot.childNodes[ 0 ];
  815. expect( domP.childNodes.length ).to.equal( 2 );
  816. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  817. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  818. const domB = domP.childNodes[ 0 ];
  819. const viewB = viewP.getChild( 0 );
  820. expect( domB.childNodes.length ).to.equal( 1 );
  821. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  822. expect( domSelection.rangeCount ).to.equal( 1 );
  823. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  824. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  825. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  826. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  827. const viewText = new ViewText( viewDocument, 'x' );
  828. viewB._appendChild( viewText );
  829. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  830. renderer.markToSync( 'text', viewText );
  831. renderer.render();
  832. // 4. Check the DOM.
  833. expect( domB.childNodes.length ).to.equal( 1 );
  834. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  835. expect( domSelection.rangeCount ).to.equal( 1 );
  836. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  837. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  838. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  839. } );
  840. it( 'should handle not collapsed range', () => {
  841. const domSelection = document.getSelection();
  842. const { view: viewP, selection: newSelection } = parse(
  843. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  844. viewRoot._appendChild( viewP );
  845. selection._setTo( newSelection );
  846. renderer.markToSync( 'children', viewRoot );
  847. renderer.render();
  848. const domP = domRoot.childNodes[ 0 ];
  849. expect( domP.childNodes.length ).to.equal( 2 );
  850. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  851. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  852. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  853. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  854. expect( domSelection.rangeCount ).to.equal( 1 );
  855. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  856. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  857. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  858. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  859. renderer.markToSync( 'children', viewP );
  860. renderAndExpectNoChanges( renderer, domRoot );
  861. } );
  862. it( 'should not change selection if there is no editable with selection', () => {
  863. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  864. document.body.appendChild( domDiv );
  865. domDiv.focus();
  866. const domSelection = document.getSelection();
  867. domSelection.removeAllRanges();
  868. domSelection.collapse( domDiv, 0 );
  869. const viewDiv = new ViewElement( viewDocument, 'div' );
  870. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  871. viewDiv._appendChild( viewP );
  872. selection._setTo( newSelection );
  873. renderer.render();
  874. expect( domSelection.rangeCount ).to.equal( 1 );
  875. // Depending on the browser selection may end up before the text node or at the beginning of it.
  876. const domRange = domSelection.getRangeAt( 0 );
  877. const assertSelectionAtEndOfTextNode = () => {
  878. expect( domRange.startContainer ).to.equal( domDiv );
  879. };
  880. const assertSelectionInsideTextNode = () => {
  881. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  882. };
  883. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  884. expect( domRange.startOffset ).to.equal( 0 );
  885. expect( domRange.collapsed ).to.be.true;
  886. domDiv.remove();
  887. } );
  888. it( 'should not change selection if there is no focus', () => {
  889. const domDiv = createElement( document, 'div', null, 'not editable' );
  890. document.body.appendChild( domDiv );
  891. const domSelection = document.getSelection();
  892. domSelection.removeAllRanges();
  893. const domRange = document.createRange();
  894. domRange.setStart( domDiv, 0 );
  895. domRange.collapse( true );
  896. domSelection.addRange( domRange );
  897. renderer.isFocused = false;
  898. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  899. viewRoot._appendChild( viewP );
  900. selection._setTo( newSelection );
  901. renderer.render();
  902. expect( domSelection.rangeCount ).to.equal( 1 );
  903. // Depending on the browser selection may end up before the text node or at the beginning of it.
  904. const domSelectionRange = domSelection.getRangeAt( 0 );
  905. const assertSelectionAtEndOfTextNode = () => {
  906. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  907. };
  908. const assertSelectionInsideTextNode = () => {
  909. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  910. };
  911. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  912. expect( domSelectionRange.startOffset ).to.equal( 0 );
  913. expect( domSelectionRange.collapsed ).to.be.true;
  914. domDiv.remove();
  915. } );
  916. it( 'should not add inline filler after text node', () => {
  917. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  918. viewRoot._appendChild( viewP );
  919. selection._setTo( newSelection );
  920. renderer.markToSync( 'children', viewRoot );
  921. renderer.render();
  922. const domP = domRoot.childNodes[ 0 ];
  923. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  924. } );
  925. it( 'should throw if there is no filler in expected position', () => {
  926. const { view: viewP, selection: newSelection } = parse(
  927. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  928. viewRoot._appendChild( viewP );
  929. selection._setTo( newSelection );
  930. renderer.markToSync( 'children', viewRoot );
  931. renderer.render();
  932. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  933. const viewB = viewP.getChild( 1 );
  934. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  935. // Remove filler.
  936. domB.childNodes[ 0 ].data = '';
  937. selection._setTo( null );
  938. renderer.markToSync( 'children', viewB );
  939. expectToThrowCKEditorError( () => {
  940. renderer.render();
  941. }, /^view-renderer-filler-was-lost/, selection );
  942. } );
  943. // #1014.
  944. it( 'should create inline filler in newly created dom nodes', () => {
  945. // 1. Create the view structure which needs inline filler.
  946. const inputView =
  947. '<container:ul>' +
  948. '<container:li>Foobar.</container:li>' +
  949. '<container:li>[]<container:div></container:div></container:li>' +
  950. '</container:ul>';
  951. const { view: view, selection: newSelection } = parse( inputView );
  952. viewRoot._appendChild( view );
  953. selection._setTo( newSelection );
  954. renderer.markToSync( 'children', viewRoot );
  955. renderer.render();
  956. // 2. Check if filler element has been (correctly) created.
  957. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  958. // 3. Move the inline filler parent to a newly created element.
  959. const viewLi = view.getChild( 0 );
  960. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  961. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  962. viewLi._appendChild( viewUl );
  963. // 4. Mark changed items and render the view.
  964. renderer.markToSync( 'children', view );
  965. renderer.markToSync( 'children', viewLi );
  966. renderer.render();
  967. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  968. const domSelection = document.getSelection();
  969. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  970. } );
  971. it( 'should handle focusing element', () => {
  972. selection._setTo( viewRoot, 0 );
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. renderer.render();
  975. expect( domFocusSpy.called ).to.be.true;
  976. } );
  977. it( 'should not focus editable if isFocues is set to false', () => {
  978. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  979. renderer.isFocused = false;
  980. renderer.render();
  981. expect( domFocusSpy.calledOnce ).to.be.false;
  982. } );
  983. it( 'should not focus already focused DOM element', () => {
  984. domRoot.setAttribute( 'contentEditable', true );
  985. domRoot.focus();
  986. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  987. renderer.render();
  988. expect( domFocusSpy.called ).to.be.false;
  989. } );
  990. it( 'should render NBSP as last space in the previous inline element', () => {
  991. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  992. viewRoot._appendChild( viewP );
  993. renderer.markToSync( 'children', viewRoot );
  994. renderer.render();
  995. const domP = domRoot.childNodes[ 0 ];
  996. const domB = domP.childNodes[ 1 ];
  997. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  998. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  999. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1000. // Insert space resulting in '<p>x <b> y</b></p>'.
  1001. const viewB = viewP.getChild( 1 );
  1002. viewB._removeChildren( 0 );
  1003. viewB._appendChild( new ViewText( viewDocument, ' y' ) );
  1004. renderer.markToSync( 'children', viewP );
  1005. renderer.render();
  1006. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1007. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1008. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1009. } );
  1010. it( 'should update sibling after, when node before is removed', () => {
  1011. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1012. viewRoot._appendChild( viewP );
  1013. renderer.markToSync( 'children', viewRoot );
  1014. renderer.render();
  1015. const domP = domRoot.childNodes[ 0 ];
  1016. const domB = domP.childNodes[ 1 ];
  1017. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1018. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1019. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1020. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1021. viewP._removeChildren( 0 );
  1022. renderer.markToSync( 'children', viewP );
  1023. renderer.render();
  1024. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1025. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1026. } );
  1027. it( 'should update sibling before, when node after is removed', () => {
  1028. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1029. viewRoot._appendChild( viewP );
  1030. renderer.markToSync( 'children', viewRoot );
  1031. renderer.render();
  1032. const domP = domRoot.childNodes[ 0 ];
  1033. const domB = domP.childNodes[ 1 ];
  1034. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1035. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1036. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1037. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1038. viewP._removeChildren( 1 );
  1039. renderer.markToSync( 'children', viewP );
  1040. renderer.render();
  1041. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1042. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1043. } );
  1044. // #1093
  1045. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1046. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1047. viewRoot._appendChild( viewP );
  1048. renderer.markToSync( 'children', viewRoot );
  1049. renderer.render();
  1050. const domP = domRoot.childNodes[ 0 ];
  1051. const domB = domP.childNodes[ 1 ];
  1052. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1053. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1054. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1055. // Insert space resulting in '<p>x <b> y</b></p>'.
  1056. viewP._removeChildren( 0 );
  1057. viewP._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1058. renderer.markToSync( 'children', viewP );
  1059. renderer.render();
  1060. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1061. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1062. expect( domP.innerHTML ).to.equal( 'x&nbsp;<b> y</b>' );
  1063. } );
  1064. // #1093
  1065. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1066. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1067. viewRoot._appendChild( viewP );
  1068. renderer.markToSync( 'children', viewRoot );
  1069. renderer.render();
  1070. const domP = domRoot.childNodes[ 0 ];
  1071. const domB = domP.childNodes[ 0 ];
  1072. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1073. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1074. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1075. // Insert space resulting in '<p><b>x </b> y</p>'.
  1076. const viewB = viewP.getChild( 0 );
  1077. viewB._removeChildren( 0 );
  1078. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1079. renderer.markToSync( 'children', viewP );
  1080. renderer.render();
  1081. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1082. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1083. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b> y' );
  1084. } );
  1085. // #1093
  1086. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1087. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1088. viewRoot._appendChild( viewP );
  1089. renderer.markToSync( 'children', viewRoot );
  1090. renderer.render();
  1091. const domP = domRoot.childNodes[ 0 ];
  1092. const domB = domP.childNodes[ 0 ];
  1093. const domI = domP.childNodes[ 1 ];
  1094. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1095. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1096. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1097. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1098. const viewB = viewP.getChild( 0 );
  1099. viewB._removeChildren( 0 );
  1100. viewB._insertChild( 0, new ViewText( viewDocument, 'x ' ) );
  1101. renderer.markToSync( 'children', viewP );
  1102. renderer.render();
  1103. expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1104. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1105. expect( domP.innerHTML ).to.equal( '<b>x&nbsp;</b><i> y</i>' );
  1106. } );
  1107. // #1125
  1108. it( 'should properly rerender many changes done in one batch', () => {
  1109. // This test transforms:
  1110. //
  1111. // <h2>He<strong>ding 1</strong></h2>
  1112. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1113. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1114. //
  1115. // into:
  1116. //
  1117. // <h2>Heading 2</h2>
  1118. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1119. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1120. //
  1121. // during one rerender to check if complex structure changes are rerendered correctly.
  1122. const viewContent = parse( '' +
  1123. '<container:h2>He' +
  1124. '<attribute:i>ading 1</attribute:i>' +
  1125. '</container:h2>' +
  1126. '<container:p>Ph ' +
  1127. '<attribute:strong>Bold</attribute:strong> ' +
  1128. '<attribute:i>It' +
  1129. '<attribute:strong>alic</attribute:strong>' +
  1130. '</attribute:i> ' +
  1131. '<attribute:a href="https://ckeditor.com">' +
  1132. '<attribute:strong>Lin</attribute:strong>' +
  1133. 'k</attribute:a>' +
  1134. '</container:p>' +
  1135. '<container:blockquote>' +
  1136. '<container:ul>' +
  1137. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1138. '</container:ul>' +
  1139. '</container:blockquote>' );
  1140. viewRoot._appendChild( viewContent );
  1141. renderer.markToSync( 'children', viewRoot );
  1142. renderer.render();
  1143. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1144. const viewHeading = viewRoot.getChild( 0 );
  1145. viewHeading._removeChildren( 0, viewHeading.childCount );
  1146. viewHeading._insertChild( 0, new ViewText( viewDocument, 'Heading 2' ) );
  1147. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1148. renderer.markToSync( 'children', viewRoot );
  1149. renderer.markToSync( 'children', viewHeading );
  1150. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1151. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1152. // ->
  1153. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1154. const viewP = viewRoot.getChild( 1 );
  1155. viewP._removeChildren( 0, viewP.childCount );
  1156. viewP._insertChild(
  1157. 0,
  1158. parse(
  1159. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1160. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1161. )
  1162. );
  1163. renderer.markToSync( 'children', viewRoot );
  1164. renderer.markToSync( 'children', viewP );
  1165. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1166. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1167. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1168. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1169. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1170. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1171. const viewBq = viewRoot.getChild( 2 );
  1172. viewBq._removeChildren( 0, viewBq.childCount );
  1173. viewBq._insertChild(
  1174. 0,
  1175. parse(
  1176. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1177. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1178. )
  1179. );
  1180. renderer.markToSync( 'children', viewRoot );
  1181. renderer.markToSync( 'children', viewBq );
  1182. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1183. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1184. renderer.render();
  1185. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1186. '<h2>Heading 2</h2>' +
  1187. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1188. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1189. );
  1190. } );
  1191. // #1125
  1192. it( 'should properly rerender changes when whole content replaced at once', () => {
  1193. // This test replaces:
  1194. //
  1195. // <h1>Header</h1>
  1196. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1197. //
  1198. // with:
  1199. //
  1200. // <h2>Header</h2>
  1201. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1202. //
  1203. // during one rerender to check if complex structure changes are rerendered correctly.
  1204. const viewContent = parse(
  1205. '<container:h1>Header</container:h1>' +
  1206. '<container:blockquote>' +
  1207. '<container:ul>' +
  1208. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1209. '<container:li>Item 2</container:li>' +
  1210. '</container:ul>' +
  1211. '</container:blockquote>'
  1212. );
  1213. viewRoot._appendChild( viewContent );
  1214. renderer.markToSync( 'children', viewRoot );
  1215. renderer.render();
  1216. const newViewContent = parse(
  1217. '<container:h2>Header</container:h2>' +
  1218. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1219. );
  1220. viewRoot._removeChildren( 0, viewRoot.childCount );
  1221. viewRoot._appendChild( newViewContent );
  1222. renderer.markToSync( 'children', viewRoot );
  1223. renderer.render();
  1224. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1225. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1226. );
  1227. } );
  1228. // #1451
  1229. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1230. const inputView =
  1231. '<container:ul>' +
  1232. '<container:li>Foo</container:li>' +
  1233. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1234. '</container:ul>';
  1235. const view = parse( inputView );
  1236. viewRoot._appendChild( view );
  1237. renderer.markToSync( 'children', viewRoot );
  1238. renderer.render();
  1239. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1240. const viewLi = view.getChild( 0 );
  1241. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1242. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1243. const viewUl = new ViewContainerElement( viewDocument, 'ul', null, viewLiIndented );
  1244. viewLi._appendChild( viewUl );
  1245. renderer.markToSync( 'children', view );
  1246. renderer.markToSync( 'children', viewLi );
  1247. renderer.render();
  1248. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1249. } );
  1250. // #1439
  1251. it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
  1252. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1253. testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
  1254. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1255. // <p>foo<br/>[]</p>
  1256. const { view: viewP, selection: newSelection } = parse(
  1257. '<container:p>' +
  1258. 'foo[]' +
  1259. '<empty:br></empty:br>[]' +
  1260. '</container:p>' );
  1261. viewRoot._appendChild( viewP );
  1262. selection._setTo( newSelection );
  1263. renderer.markToSync( 'children', viewRoot );
  1264. renderer.render();
  1265. sinon.assert.notCalled( spy );
  1266. } );
  1267. // #1439
  1268. it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
  1269. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1270. testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
  1271. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1272. // <p>foo[]<b>bar</b></p>
  1273. let { view: viewP, selection: newSelection } = parse(
  1274. '<container:p>' +
  1275. 'foo[]' +
  1276. '<attribute:b>bar</attribute:b>' +
  1277. '</container:p>' );
  1278. viewRoot._appendChild( viewP );
  1279. selection._setTo( newSelection );
  1280. renderer.markToSync( 'children', viewRoot );
  1281. renderer.render();
  1282. sinon.assert.notCalled( spy );
  1283. // <p>foo<b>bar</b></p><p>foo[]<br/></p>
  1284. ( { view: viewP, selection: newSelection } = parse(
  1285. '<container:p>' +
  1286. 'foo[]' +
  1287. '<empty:br></empty:br>' +
  1288. '</container:p>' ) );
  1289. viewRoot._appendChild( viewP );
  1290. selection._setTo( newSelection );
  1291. renderer.markToSync( 'children', viewRoot );
  1292. renderer.render();
  1293. sinon.assert.notCalled( spy );
  1294. // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
  1295. selection._setTo( [
  1296. new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
  1297. ] );
  1298. renderer.markToSync( 'children', viewRoot );
  1299. renderer.render();
  1300. sinon.assert.calledOnce( spy );
  1301. } );
  1302. describe( 'fake selection', () => {
  1303. beforeEach( () => {
  1304. const { view: viewP, selection: newSelection } = parse(
  1305. '<container:p>[foo bar]</container:p>'
  1306. );
  1307. viewRoot._appendChild( viewP );
  1308. selection._setTo( newSelection );
  1309. renderer.markToSync( 'children', viewRoot );
  1310. renderer.render();
  1311. } );
  1312. it( 'should render fake selection', () => {
  1313. const label = 'fake selection label';
  1314. selection._setTo( selection.getRanges(), { fake: true, label } );
  1315. renderer.render();
  1316. expect( domRoot.childNodes.length ).to.equal( 2 );
  1317. const container = domRoot.childNodes[ 1 ];
  1318. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1319. expect( container.childNodes.length ).to.equal( 1 );
  1320. const textNode = container.childNodes[ 0 ];
  1321. expect( textNode.textContent ).to.equal( label );
  1322. const domSelection = domRoot.ownerDocument.getSelection();
  1323. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1324. } );
  1325. describe( 'subsequent call optimization', () => {
  1326. // https://github.com/ckeditor/ckeditor5-engine/issues/1791
  1327. it( 'doesn\'t render the same selection multiple times', () => {
  1328. const createRangeSpy = sinon.spy( document, 'createRange' );
  1329. const label = 'subsequent fake selection calls';
  1330. selection._setTo( selection.getRanges(), { fake: true, label } );
  1331. renderer.render();
  1332. selection._setTo( selection.getRanges(), { fake: true, label } );
  1333. renderer.render();
  1334. expect( createRangeSpy.callCount ).to.be.equal( 1 );
  1335. } );
  1336. it( 'different subsequent fake selections sets do change native selection', () => {
  1337. const createRangeSpy = sinon.spy( document, 'createRange' );
  1338. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 1' } );
  1339. renderer.render();
  1340. selection._setTo( selection.getRanges(), { fake: true, label: 'selection 2' } );
  1341. renderer.render();
  1342. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1343. } );
  1344. it( 'rerenders selection if disturbed externally', () => {
  1345. const interruptingRange = document.createRange();
  1346. interruptingRange.setStartBefore( domRoot.children[ 0 ] );
  1347. interruptingRange.setEndAfter( domRoot.children[ 0 ] );
  1348. const createRangeSpy = sinon.spy( document, 'createRange' );
  1349. const label = 'selection 1';
  1350. selection._setTo( selection.getRanges(), { fake: true, label } );
  1351. renderer.render();
  1352. document.getSelection().removeAllRanges();
  1353. document.getSelection().addRange( interruptingRange );
  1354. selection._setTo( selection.getRanges(), { fake: true, label } );
  1355. renderer.render();
  1356. expect( createRangeSpy.callCount ).to.be.equal( 2 );
  1357. } );
  1358. it( 'correctly maps fake selection ', () => {
  1359. // See https://github.com/ckeditor/ckeditor5-engine/pull/1792#issuecomment-529814641
  1360. const label = 'subsequent fake selection calls';
  1361. const { view: newParagraph, selection: newSelection } = parse( '<container:p>[baz]</container:p>' );
  1362. viewRoot._appendChild( newParagraph );
  1363. selection._setTo( selection.getRanges(), { fake: true, label } );
  1364. renderer.render();
  1365. selection._setTo( newSelection.getRanges(), { fake: true, label } );
  1366. renderer.render();
  1367. const fakeSelectionContainer = domRoot.childNodes[ 1 ];
  1368. const mappedSelection = renderer.domConverter.fakeSelectionToView( fakeSelectionContainer );
  1369. expect( stringify( viewRoot, mappedSelection ) ).to.be.equal( '<div><p>foo bar</p><p>[baz]</p></div>' );
  1370. } );
  1371. } );
  1372. it( 'should render &nbsp; if no selection label is provided', () => {
  1373. selection._setTo( selection.getRanges(), { fake: true } );
  1374. renderer.render();
  1375. expect( domRoot.childNodes.length ).to.equal( 2 );
  1376. const container = domRoot.childNodes[ 1 ];
  1377. expect( container.childNodes.length ).to.equal( 1 );
  1378. const textNode = container.childNodes[ 0 ];
  1379. expect( textNode.textContent ).to.equal( '\u00A0' );
  1380. const domSelection = domRoot.ownerDocument.getSelection();
  1381. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1382. } );
  1383. it( 'should remove fake selection container when selection is no longer fake', () => {
  1384. selection._setTo( selection.getRanges(), { fake: true } );
  1385. renderer.render();
  1386. selection._setTo( selection.getRanges(), { fake: false } );
  1387. renderer.render();
  1388. expect( domRoot.childNodes.length ).to.equal( 1 );
  1389. const domParagraph = domRoot.childNodes[ 0 ];
  1390. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1391. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1392. const domSelection = domRoot.ownerDocument.getSelection();
  1393. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1394. } );
  1395. it( 'should reuse fake selection container #1', () => {
  1396. const label = 'fake selection label';
  1397. selection._setTo( selection.getRanges(), { fake: true, label } );
  1398. renderer.render();
  1399. expect( domRoot.childNodes.length ).to.equal( 2 );
  1400. const container = domRoot.childNodes[ 1 ];
  1401. selection._setTo( selection.getRanges(), { fake: true, label } );
  1402. renderer.render();
  1403. expect( domRoot.childNodes.length ).to.equal( 2 );
  1404. const newContainer = domRoot.childNodes[ 1 ];
  1405. expect( newContainer ).equals( container );
  1406. expect( newContainer.childNodes.length ).to.equal( 1 );
  1407. const textNode = newContainer.childNodes[ 0 ];
  1408. expect( textNode.textContent ).to.equal( label );
  1409. } );
  1410. it( 'should reuse fake selection container #2', () => {
  1411. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1412. renderer.render();
  1413. expect( domRoot.childNodes.length ).to.equal( 2 );
  1414. const container = domRoot.childNodes[ 1 ];
  1415. selection._setTo( selection.getRanges(), { fake: false } );
  1416. renderer.render();
  1417. expect( domRoot.childNodes.length ).to.equal( 1 );
  1418. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1419. renderer.render();
  1420. expect( domRoot.childNodes.length ).to.equal( 2 );
  1421. const newContainer = domRoot.childNodes[ 1 ];
  1422. expect( newContainer ).equals( container );
  1423. expect( newContainer.childNodes.length ).to.equal( 1 );
  1424. const textNode = newContainer.childNodes[ 0 ];
  1425. expect( textNode.textContent ).to.equal( 'label 2' );
  1426. } );
  1427. it( 'should reuse fake selection container #3', () => {
  1428. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1429. renderer.render();
  1430. expect( domRoot.childNodes.length ).to.equal( 2 );
  1431. const container = domRoot.childNodes[ 1 ];
  1432. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1433. renderer.render();
  1434. expect( domRoot.childNodes.length ).to.equal( 2 );
  1435. const newContainer = domRoot.childNodes[ 1 ];
  1436. expect( newContainer ).equals( container );
  1437. expect( newContainer.childNodes.length ).to.equal( 1 );
  1438. const textNode = newContainer.childNodes[ 0 ];
  1439. expect( textNode.textContent ).to.equal( 'label 2' );
  1440. } );
  1441. it( 'should style fake selection container properly', () => {
  1442. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1443. renderer.render();
  1444. expect( domRoot.childNodes.length ).to.equal( 2 );
  1445. const container = domRoot.childNodes[ 1 ];
  1446. expect( container.style.position ).to.equal( 'fixed' );
  1447. expect( container.style.top ).to.equal( '0px' );
  1448. expect( container.style.left ).to.equal( '-9999px' );
  1449. } );
  1450. it( 'should move fake selection container between editables', () => {
  1451. const viewEditable = new ViewEditableElement( viewDocument, 'div' );
  1452. viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
  1453. const domEditable = document.createElement( 'div' );
  1454. document.body.appendChild( domEditable );
  1455. domConverter.bindElements( domEditable, viewEditable );
  1456. renderer.markToSync( 'children', viewEditable );
  1457. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1458. renderer.render();
  1459. let container = document.getSelection().anchorNode;
  1460. expect( domRoot.contains( container ) ).to.be.true;
  1461. selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
  1462. renderer.render();
  1463. container = document.getSelection().anchorNode;
  1464. expect( domEditable.contains( container ) ).to.be.true;
  1465. domEditable.remove();
  1466. } );
  1467. it( 'should bind fake selection container to view selection', () => {
  1468. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1469. renderer.render();
  1470. expect( domRoot.childNodes.length ).to.equal( 2 );
  1471. const container = domRoot.childNodes[ 1 ];
  1472. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1473. expect( bindSelection ).to.not.be.undefined;
  1474. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1475. } );
  1476. // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
  1477. it( 'should handle situation when label got removed from the fake selection container', () => {
  1478. const label = 'fake selection label';
  1479. selection._setTo( selection.getRanges(), { fake: true, label } );
  1480. renderer.render();
  1481. expect( domRoot.childNodes.length ).to.equal( 2 );
  1482. const container = domRoot.childNodes[ 1 ];
  1483. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1484. expect( container.childNodes.length ).to.equal( 1 );
  1485. const textNode = container.childNodes[ 0 ];
  1486. expect( textNode.textContent ).to.equal( label );
  1487. // Remove a text node (label) from the fake selection container.
  1488. // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
  1489. textNode.remove();
  1490. renderer.render();
  1491. const domSelection = domRoot.ownerDocument.getSelection();
  1492. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1493. } );
  1494. // Use a forgiving way of checking what the selection contains
  1495. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1496. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1497. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1498. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1499. expect( domSelection.toString() ).to.match( expectedText );
  1500. expect(
  1501. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1502. ).to.be.true;
  1503. }
  1504. } );
  1505. // #887
  1506. describe( 'similar selection', () => {
  1507. // Use spies to check selection updates. Some selection positions are not achievable in some
  1508. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1509. let selectionCollapseSpy, selectionExtendSpy;
  1510. afterEach( () => {
  1511. if ( selectionCollapseSpy ) {
  1512. selectionCollapseSpy.restore();
  1513. selectionCollapseSpy = null;
  1514. }
  1515. if ( selectionExtendSpy ) {
  1516. selectionExtendSpy.restore();
  1517. selectionExtendSpy = null;
  1518. }
  1519. } );
  1520. it( 'should always render collapsed selection even if it is similar', () => {
  1521. const domSelection = document.getSelection();
  1522. const { view: viewP, selection: newSelection } = parse(
  1523. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1524. viewRoot._appendChild( viewP );
  1525. selection._setTo( newSelection );
  1526. renderer.markToSync( 'children', viewRoot );
  1527. renderer.render();
  1528. const domP = domRoot.childNodes[ 0 ];
  1529. const domB = domP.childNodes[ 1 ];
  1530. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1531. expect( domSelection.isCollapsed ).to.true;
  1532. expect( domSelection.rangeCount ).to.equal( 1 );
  1533. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1534. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1535. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1536. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1537. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1538. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1539. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1540. selection._setTo( [
  1541. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1542. ] );
  1543. renderer.markToSync( 'children', viewP );
  1544. renderer.render();
  1545. expect( selectionCollapseSpy.calledOnce ).to.true;
  1546. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1547. expect( selectionExtendSpy.calledOnce ).to.true;
  1548. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1549. } );
  1550. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1551. const domSelection = document.getSelection();
  1552. const { view: viewP, selection: newSelection } = parse(
  1553. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1554. viewRoot._appendChild( viewP );
  1555. selection._setTo( newSelection );
  1556. renderer.markToSync( 'children', viewRoot );
  1557. renderer.render();
  1558. const domP = domRoot.childNodes[ 0 ];
  1559. const domB = domP.childNodes[ 1 ];
  1560. expect( domSelection.isCollapsed ).to.true;
  1561. expect( domSelection.rangeCount ).to.equal( 1 );
  1562. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1563. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1564. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1565. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1566. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1567. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1568. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1569. selection._setTo( [
  1570. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1571. ] );
  1572. renderer.markToSync( 'children', viewP );
  1573. renderer.render();
  1574. expect( selectionCollapseSpy.calledOnce ).to.true;
  1575. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1576. expect( selectionExtendSpy.calledOnce ).to.true;
  1577. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1578. } );
  1579. it( 'should always render non-collapsed selection if it not is similar', () => {
  1580. const domSelection = document.getSelection();
  1581. const { view: viewP, selection: newSelection } = parse(
  1582. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1583. viewRoot._appendChild( viewP );
  1584. selection._setTo( newSelection );
  1585. renderer.markToSync( 'children', viewRoot );
  1586. renderer.render();
  1587. const domP = domRoot.childNodes[ 0 ];
  1588. const domB = domP.childNodes[ 1 ];
  1589. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1590. expect( domSelection.isCollapsed ).to.false;
  1591. expect( domSelection.rangeCount ).to.equal( 1 );
  1592. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1593. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1594. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1595. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1596. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1597. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1598. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1599. selection._setTo( [
  1600. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1601. ] );
  1602. renderer.markToSync( 'children', viewP );
  1603. renderer.render();
  1604. expect( selectionCollapseSpy.calledOnce ).to.true;
  1605. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1606. expect( selectionExtendSpy.calledOnce ).to.true;
  1607. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1608. } );
  1609. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1610. const domSelection = document.getSelection();
  1611. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1612. viewRoot._appendChild( viewP );
  1613. selection._setTo( newSelection );
  1614. renderer.markToSync( 'children', viewRoot );
  1615. renderer.render();
  1616. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1617. // Do not change view selection.
  1618. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1619. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1620. // because DOM selection is in incorrect place.
  1621. const domP = domRoot.childNodes[ 0 ];
  1622. const domSpan = domP.childNodes[ 1 ];
  1623. domSelection.collapse( domSpan, 0 );
  1624. renderer.render();
  1625. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1626. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1627. const assertSelectionAtEndOfTextNode = () => {
  1628. expect( domSelection.anchorNode ).to.equal( domP );
  1629. expect( domSelection.anchorOffset ).to.equal( 1 );
  1630. };
  1631. const assertSelectionInsideTextNode = () => {
  1632. const textNode = domP.childNodes[ 0 ];
  1633. expect( domSelection.anchorNode ).to.equal( textNode );
  1634. expect( domSelection.anchorOffset ).to.equal( 3 );
  1635. };
  1636. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1637. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1638. } );
  1639. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1640. const domSelection = document.getSelection();
  1641. const { view: viewP, selection: newSelection } = parse(
  1642. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1643. viewRoot._appendChild( viewP );
  1644. selection._setTo( newSelection );
  1645. renderer.markToSync( 'children', viewRoot );
  1646. renderer.render();
  1647. const domP = domRoot.childNodes[ 0 ];
  1648. const domB = domP.childNodes[ 1 ];
  1649. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1650. expect( domSelection.isCollapsed ).to.false;
  1651. expect( domSelection.rangeCount ).to.equal( 1 );
  1652. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1653. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1654. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1655. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1656. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1657. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1658. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1659. selection._setTo( [
  1660. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1661. ] );
  1662. renderer.markToSync( 'children', viewP );
  1663. renderer.render();
  1664. expect( selectionCollapseSpy.notCalled ).to.true;
  1665. expect( selectionExtendSpy.notCalled ).to.true;
  1666. } );
  1667. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1668. const domSelection = document.getSelection();
  1669. const { view: viewP, selection: newSelection } = parse(
  1670. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1671. viewRoot._appendChild( viewP );
  1672. selection._setTo( newSelection );
  1673. renderer.markToSync( 'children', viewRoot );
  1674. renderer.render();
  1675. const domP = domRoot.childNodes[ 0 ];
  1676. const domB = domP.childNodes[ 1 ];
  1677. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1678. expect( domSelection.isCollapsed ).to.false;
  1679. expect( domSelection.rangeCount ).to.equal( 1 );
  1680. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1681. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1682. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1683. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1684. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1685. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1686. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1687. selection._setTo( [
  1688. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1689. ] );
  1690. renderer.markToSync( 'children', viewP );
  1691. renderer.render();
  1692. expect( selectionCollapseSpy.notCalled ).to.true;
  1693. expect( selectionExtendSpy.notCalled ).to.true;
  1694. } );
  1695. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1696. const domSelection = document.getSelection();
  1697. const { view: viewP, selection: newSelection } = parse(
  1698. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1699. viewRoot._appendChild( viewP );
  1700. selection._setTo( newSelection );
  1701. renderer.markToSync( 'children', viewRoot );
  1702. renderer.render();
  1703. const domP = domRoot.childNodes[ 0 ];
  1704. const domB = domP.childNodes[ 1 ];
  1705. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1706. expect( domSelection.isCollapsed ).to.false;
  1707. expect( domSelection.rangeCount ).to.equal( 1 );
  1708. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1709. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1710. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1711. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1712. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1713. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1714. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1715. selection._setTo( [
  1716. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1717. ] );
  1718. renderer.markToSync( 'children', viewP );
  1719. renderer.render();
  1720. expect( selectionCollapseSpy.notCalled ).to.true;
  1721. expect( selectionExtendSpy.notCalled ).to.true;
  1722. } );
  1723. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1724. const domSelection = document.getSelection();
  1725. const { view: viewP, selection: newSelection } = parse(
  1726. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1727. viewRoot._appendChild( viewP );
  1728. selection._setTo( newSelection );
  1729. renderer.markToSync( 'children', viewRoot );
  1730. renderer.render();
  1731. const domP = domRoot.childNodes[ 0 ];
  1732. const domB = domP.childNodes[ 1 ];
  1733. expect( domSelection.isCollapsed ).to.false;
  1734. expect( domSelection.rangeCount ).to.equal( 1 );
  1735. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1736. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1737. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1738. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1739. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1740. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1741. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1742. selection._setTo( [
  1743. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1744. ] );
  1745. renderer.markToSync( 'children', viewP );
  1746. renderer.render();
  1747. expect( selectionCollapseSpy.notCalled ).to.true;
  1748. expect( selectionExtendSpy.notCalled ).to.true;
  1749. } );
  1750. } );
  1751. // #1417
  1752. describe( 'optimal rendering – reusing existing nodes', () => {
  1753. it( 'should render inline element replacement (before text)', () => {
  1754. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1755. renderer.markToSync( 'children', viewRoot );
  1756. renderer.render();
  1757. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1758. const viewP = viewRoot.getChild( 0 );
  1759. viewP._removeChildren( 0, 2 );
  1760. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1761. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1762. renderer.markToSync( 'children', viewRoot );
  1763. renderer.markToSync( 'children', viewP );
  1764. renderer.render();
  1765. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1766. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1767. } );
  1768. it( 'should render inline element replacement (after text)', () => {
  1769. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1770. renderer.markToSync( 'children', viewRoot );
  1771. renderer.render();
  1772. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1773. const viewP = viewRoot.getChild( 0 );
  1774. viewP._removeChildren( 0, 2 );
  1775. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1776. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1777. renderer.markToSync( 'children', viewRoot );
  1778. renderer.markToSync( 'children', viewP );
  1779. renderer.render();
  1780. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1781. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1782. } );
  1783. it( 'should render inline element replacement (before text swapped order)', () => {
  1784. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1785. renderer.markToSync( 'children', viewRoot );
  1786. renderer.render();
  1787. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1788. const viewP = viewRoot.getChild( 0 );
  1789. viewP._removeChildren( 0, 2 );
  1790. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1791. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1792. renderer.markToSync( 'children', viewRoot );
  1793. renderer.markToSync( 'children', viewP );
  1794. renderer.render();
  1795. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1796. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1797. } );
  1798. it( 'should render inline element replacement (after text swapped order)', () => {
  1799. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1800. renderer.markToSync( 'children', viewRoot );
  1801. renderer.render();
  1802. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1803. const viewP = viewRoot.getChild( 0 );
  1804. viewP._removeChildren( 0, 2 );
  1805. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1806. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1807. renderer.markToSync( 'children', viewRoot );
  1808. renderer.markToSync( 'children', viewP );
  1809. renderer.render();
  1810. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1811. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1812. } );
  1813. it( 'should render single replacement in p group', () => {
  1814. const content = '' +
  1815. '<container:p>1</container:p>' +
  1816. '<container:p>2</container:p>' +
  1817. '<container:p>3</container:p>';
  1818. viewRoot._appendChild( parse( content ) );
  1819. renderer.markToSync( 'children', viewRoot );
  1820. renderer.render();
  1821. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1822. viewRoot._removeChildren( 1 );
  1823. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1824. const domP = domRoot.childNodes[ 1 ];
  1825. renderer.markToSync( 'children', viewRoot );
  1826. renderer.render();
  1827. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1828. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1829. } );
  1830. it( 'should render replacement and insertion in p group', () => {
  1831. const content = '' +
  1832. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1833. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1834. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1835. const replacement = '' +
  1836. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1837. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1838. viewRoot._appendChild( parse( content ) );
  1839. renderer.markToSync( 'children', viewRoot );
  1840. renderer.render();
  1841. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1842. viewRoot._removeChildren( 1 );
  1843. viewRoot._insertChild( 1, parse( replacement ) );
  1844. const domP2 = domRoot.childNodes[ 1 ];
  1845. const domP3 = domRoot.childNodes[ 2 ];
  1846. renderer.markToSync( 'children', viewRoot );
  1847. renderer.render();
  1848. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1849. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1850. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1851. } );
  1852. it( 'should render replacement and deletion in p group', () => {
  1853. const content = '' +
  1854. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1855. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1856. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1857. viewRoot._appendChild( parse( content ) );
  1858. renderer.markToSync( 'children', viewRoot );
  1859. renderer.render();
  1860. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1861. viewRoot._removeChildren( 0, 2 );
  1862. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1863. const domP0 = domRoot.childNodes[ 0 ];
  1864. const domP2 = domRoot.childNodes[ 2 ];
  1865. renderer.markToSync( 'children', viewRoot );
  1866. renderer.render();
  1867. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1868. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1869. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1870. } );
  1871. it( 'should render multiple continuous replacement in p group', () => {
  1872. const content = '' +
  1873. '<container:p>1</container:p>' +
  1874. '<container:p>2</container:p>' +
  1875. '<container:p>3</container:p>' +
  1876. '<container:p>4</container:p>' +
  1877. '<container:p>5</container:p>';
  1878. viewRoot._appendChild( parse( content ) );
  1879. renderer.markToSync( 'children', viewRoot );
  1880. renderer.render();
  1881. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1882. viewRoot._removeChildren( 0, 3 );
  1883. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1884. const domP1 = domRoot.childNodes[ 0 ];
  1885. const domP2 = domRoot.childNodes[ 1 ];
  1886. const domP4 = domRoot.childNodes[ 3 ];
  1887. const domP5 = domRoot.childNodes[ 4 ];
  1888. renderer.markToSync( 'children', viewRoot );
  1889. renderer.render();
  1890. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1891. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1892. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1893. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1894. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1895. } );
  1896. it( 'should render multiple replacement in p group', () => {
  1897. const content = '' +
  1898. '<container:p>1</container:p>' +
  1899. '<container:p>2</container:p>' +
  1900. '<container:p>3</container:p>' +
  1901. '<container:p>4</container:p>' +
  1902. '<container:p>5</container:p>';
  1903. viewRoot._appendChild( parse( content ) );
  1904. renderer.markToSync( 'children', viewRoot );
  1905. renderer.render();
  1906. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1907. viewRoot._removeChildren( 4 );
  1908. viewRoot._removeChildren( 1, 2 );
  1909. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1910. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1911. const domP1 = domRoot.childNodes[ 0 ];
  1912. const domP2 = domRoot.childNodes[ 1 ];
  1913. const domP4 = domRoot.childNodes[ 3 ];
  1914. const domP5 = domRoot.childNodes[ 4 ];
  1915. renderer.markToSync( 'children', viewRoot );
  1916. renderer.render();
  1917. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1918. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1919. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1920. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1921. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1922. } );
  1923. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1924. const content = '' +
  1925. '<container:h2>He' +
  1926. '<attribute:i>ading 1</attribute:i>' +
  1927. '</container:h2>' +
  1928. '<container:p>Ph ' +
  1929. '<attribute:strong>Bold</attribute:strong>' +
  1930. '<attribute:a href="https://ckeditor.com">' +
  1931. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1932. '</attribute:a>' +
  1933. '</container:p>' +
  1934. '<container:blockquote>' +
  1935. '<container:ul>' +
  1936. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1937. '</container:ul>' +
  1938. '</container:blockquote>';
  1939. viewRoot._appendChild( parse( content ) );
  1940. renderer.markToSync( 'children', viewRoot );
  1941. renderer.render();
  1942. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1943. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1944. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1945. viewRoot._removeChildren( 0, viewRoot.childCount );
  1946. viewRoot._appendChild( parse( content ) );
  1947. const viewH = viewRoot.getChild( 0 );
  1948. const viewP = viewRoot.getChild( 1 );
  1949. const viewQ = viewRoot.getChild( 2 );
  1950. const domH = domRoot.childNodes[ 0 ];
  1951. const domHI = domH.childNodes[ 1 ];
  1952. const domP = domRoot.childNodes[ 1 ];
  1953. const domPT = domP.childNodes[ 0 ];
  1954. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1955. const domQ = domRoot.childNodes[ 2 ];
  1956. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1957. renderer.markToSync( 'children', viewRoot );
  1958. renderer.render();
  1959. // Assert content.
  1960. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1961. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1962. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1963. // Assert if DOM elements did not change.
  1964. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1965. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1966. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1967. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1968. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1969. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1970. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1971. // Assert mappings.
  1972. const mappings = renderer.domConverter._domToViewMapping;
  1973. expect( mappings.get( domH ) ).to.equal( viewH );
  1974. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1975. expect( mappings.get( domP ) ).to.equal( viewP );
  1976. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1977. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1978. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1979. } );
  1980. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1981. const content = '' +
  1982. '<container:h2>He' +
  1983. '<attribute:i>ading 1</attribute:i>' +
  1984. '</container:h2>' +
  1985. '<container:p>Ph ' +
  1986. '<attribute:strong>Bold</attribute:strong>' +
  1987. '<attribute:a href="https://ckeditor.com">' +
  1988. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1989. '</attribute:a>' +
  1990. '</container:p>' +
  1991. '<container:blockquote>' +
  1992. '<container:ul>' +
  1993. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1994. '</container:ul>' +
  1995. '</container:blockquote>';
  1996. const content2 = '' +
  1997. '<container:p>Ph ' +
  1998. '<attribute:strong>Bold</attribute:strong>' +
  1999. '<attribute:a href="https://ckeditor.com">' +
  2000. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2001. '</attribute:a>' +
  2002. '</container:p>' +
  2003. '<container:blockquote>' +
  2004. '<container:ul>' +
  2005. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2006. '</container:ul>' +
  2007. '</container:blockquote>';
  2008. viewRoot._appendChild( parse( content ) );
  2009. renderer.markToSync( 'children', viewRoot );
  2010. renderer.render();
  2011. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  2012. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2013. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2014. viewRoot._removeChildren( 0, viewRoot.childCount );
  2015. viewRoot._appendChild( parse( content2 ) );
  2016. const viewP = viewRoot.getChild( 0 );
  2017. const viewQ = viewRoot.getChild( 1 );
  2018. const domP = domRoot.childNodes[ 1 ];
  2019. const domPT = domP.childNodes[ 0 ];
  2020. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  2021. const domQ = domRoot.childNodes[ 2 ];
  2022. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  2023. renderer.markToSync( 'children', viewRoot );
  2024. renderer.render();
  2025. // Assert content.
  2026. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  2027. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  2028. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  2029. // Assert if DOM elements did not change.
  2030. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2031. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  2032. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  2033. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  2034. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  2035. // Assert mappings.
  2036. const mappings = renderer.domConverter._domToViewMapping;
  2037. expect( mappings.get( domP ) ).to.equal( viewP );
  2038. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  2039. expect( mappings.get( domQ ) ).to.equal( viewQ );
  2040. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2041. } );
  2042. it( 'should not rerender DOM when typing inside empty inline element', () => {
  2043. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  2044. viewRoot._appendChild( view );
  2045. renderer.markToSync( 'children', viewRoot );
  2046. renderer.render();
  2047. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  2048. const viewP = viewRoot.getChild( 0 );
  2049. viewP._removeChildren( 1 );
  2050. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  2051. const domP = domRoot.childNodes[ 0 ];
  2052. const domText = domP.childNodes[ 0 ];
  2053. const domB = domP.childNodes[ 1 ];
  2054. domB.innerHTML = 'a';
  2055. renderer.markToSync( 'children', viewRoot );
  2056. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  2057. renderer.render();
  2058. // Assert content.
  2059. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  2060. // Assert if DOM elements did not change.
  2061. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2062. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  2063. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  2064. // Assert mappings.
  2065. const mappings = renderer.domConverter._domToViewMapping;
  2066. expect( mappings.get( domP ) ).to.equal( viewP );
  2067. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  2068. } );
  2069. it( 'should handle complex view duplication', () => {
  2070. const content = '' +
  2071. '<container:blockquote>' +
  2072. '<container:ul>' +
  2073. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2074. '<container:li>Item 2</container:li>' +
  2075. '<container:li>' +
  2076. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2077. '</container:li>' +
  2078. '</container:ul>' +
  2079. '</container:blockquote>';
  2080. const expected = '' +
  2081. '<blockquote>' +
  2082. '<ul>' +
  2083. '<li>Quoted <strong>item 1</strong></li>' +
  2084. '<li>Item 2</li>' +
  2085. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2086. '</ul>' +
  2087. '</blockquote>';
  2088. viewRoot._appendChild( parse( content ) );
  2089. renderer.markToSync( 'children', viewRoot );
  2090. renderer.render();
  2091. expect( domRoot.innerHTML ).to.equal( expected );
  2092. viewRoot._removeChildren( 0, viewRoot.childCount );
  2093. viewRoot._appendChild( parse( content + content ) );
  2094. const domBQ = domRoot.childNodes[ 0 ];
  2095. const domUL = domBQ.childNodes[ 0 ];
  2096. const domLI1 = domUL.childNodes[ 0 ];
  2097. const domLI2 = domUL.childNodes[ 1 ];
  2098. const domLI3 = domUL.childNodes[ 2 ];
  2099. renderer.markToSync( 'children', viewRoot );
  2100. renderer.render();
  2101. // Assert content.
  2102. expect( domRoot.innerHTML ).to.equal( expected + expected );
  2103. // Assert if DOM elements did not change.
  2104. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  2105. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  2106. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  2107. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  2108. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  2109. // Assert mappings.
  2110. const domMappings = renderer.domConverter._domToViewMapping;
  2111. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  2112. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  2113. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  2114. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2115. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  2116. // Assert if new view elements are bind to new DOM elements.
  2117. const viewMappings = renderer.domConverter._domToViewMapping;
  2118. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  2119. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  2120. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  2121. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  2122. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  2123. } );
  2124. it( 'should handle complex view replace', () => {
  2125. const content = '' +
  2126. '<container:h2>He' +
  2127. '<attribute:i>ading 1</attribute:i>' +
  2128. '</container:h2>' +
  2129. '<container:p>Ph ' +
  2130. '<attribute:strong>Bold</attribute:strong>' +
  2131. '<attribute:a href="https://ckeditor.com">' +
  2132. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2133. '</attribute:a>' +
  2134. '</container:p>' +
  2135. '<container:blockquote>' +
  2136. '<container:ul>' +
  2137. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2138. '<container:li>Item 2</container:li>' +
  2139. '<container:li>' +
  2140. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2141. '</container:li>' +
  2142. '</container:ul>' +
  2143. '</container:blockquote>';
  2144. const replacement = '' +
  2145. '<container:p>' +
  2146. '1' +
  2147. '<attribute:i>A</attribute:i>' +
  2148. '</container:p>' +
  2149. '<container:p>' +
  2150. '<attribute:a href="https://cksource.com">' +
  2151. 'Li' +
  2152. '<attribute:strong>nk</attribute:strong>' +
  2153. '</attribute:a>' +
  2154. '</container:p>' +
  2155. '<container:h1>' +
  2156. 'Heading ' +
  2157. '<attribute:strong>1</attribute:strong>' +
  2158. '</container:h1>' +
  2159. '<container:h2>' +
  2160. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2161. '</container:h2>' +
  2162. '<container:h3>' +
  2163. 'Heading' +
  2164. '<attribute:i> 3</attribute:i>' +
  2165. '</container:h3>' +
  2166. '<container:blockquote>' +
  2167. 'Foo Bar Baz' +
  2168. '</container:blockquote>' +
  2169. '<container:ul>' +
  2170. '<container:li>' +
  2171. 'Item ' +
  2172. '<attribute:strong>1</attribute:strong>' +
  2173. '</container:li>' +
  2174. '<container:li>' +
  2175. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2176. ' 2' +
  2177. '</container:li>' +
  2178. '</container:ul>';
  2179. viewRoot._appendChild( parse( content ) );
  2180. renderer.markToSync( 'children', viewRoot );
  2181. renderer.render();
  2182. expect( domRoot.innerHTML ).to.equal( '' +
  2183. '<h2>He<i>ading 1</i></h2>' +
  2184. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2185. '<blockquote><ul>' +
  2186. '<li>Quoted <strong>item 1</strong></li>' +
  2187. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2188. '</ul></blockquote>' );
  2189. viewRoot._removeChildren( 0, viewRoot.childCount );
  2190. viewRoot._appendChild( parse( replacement ) );
  2191. renderer.markToSync( 'children', viewRoot );
  2192. renderer.render();
  2193. // Here we just check if new DOM structure was properly rendered.
  2194. expect( domRoot.innerHTML ).to.equal( '' +
  2195. '<p>1<i>A</i></p>' +
  2196. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2197. '<h1>Heading <strong>1</strong></h1>' +
  2198. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2199. '<h3>Heading<i> 3</i></h3>' +
  2200. '<blockquote>Foo Bar Baz</blockquote>' +
  2201. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2202. } );
  2203. it( 'should handle br elements while refreshing bindings', () => {
  2204. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2205. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2206. renderer.markToSync( 'children', viewRoot );
  2207. renderer.render();
  2208. expect( domRoot.innerHTML ).to.equal( expected );
  2209. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2210. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2211. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2212. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2213. viewRoot._removeChildren( 1 );
  2214. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2215. renderer.markToSync( 'children', viewRoot );
  2216. renderer.render();
  2217. expect( domRoot.innerHTML ).to.equal( expected );
  2218. } );
  2219. it( 'should handle list to paragraph conversion', () => {
  2220. const view = '' +
  2221. '<container:ol>' +
  2222. '<container:li>Item 1' +
  2223. '<container:ol>' +
  2224. '<container:li>Item 2</container:li>' +
  2225. '</container:ol>' +
  2226. '</container:li>' +
  2227. '</container:ol>' +
  2228. '<container:p>Paragraph</container:p>' +
  2229. '<container:ol>' +
  2230. '<container:li>Item 3' +
  2231. '<container:ol>' +
  2232. '<container:li>Item 4</container:li>' +
  2233. '</container:ol>' +
  2234. '</container:li>' +
  2235. '</container:ol>';
  2236. viewRoot._appendChild( parse( view ) );
  2237. renderer.markToSync( 'children', viewRoot );
  2238. renderer.render();
  2239. expect( domRoot.innerHTML ).to.equal(
  2240. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2241. const viewOL1 = viewRoot.getChild( 0 );
  2242. viewOL1.getChild( 0 )._removeChildren( 1 );
  2243. viewRoot._removeChildren( 2 );
  2244. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2245. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2246. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2247. const domOL1 = domRoot.childNodes[ 0 ];
  2248. const domOL2 = domRoot.childNodes[ 2 ];
  2249. const domP = domRoot.childNodes[ 1 ];
  2250. renderer.markToSync( 'children', viewRoot );
  2251. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2252. renderer.render();
  2253. expect( domRoot.innerHTML ).to.equal(
  2254. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2255. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2256. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2257. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2258. } );
  2259. it( 'should handle attributes change in replaced elements', () => {
  2260. const view = '' +
  2261. '<container:ol>' +
  2262. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2263. '</container:ol>' +
  2264. '<container:p>Paragraph ' +
  2265. '<attribute:a href="123">Link</attribute:a>' +
  2266. '</container:p>' +
  2267. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2268. viewRoot._appendChild( parse( view ) );
  2269. renderer.markToSync( 'children', viewRoot );
  2270. renderer.render();
  2271. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2272. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2273. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2274. const viewOL = viewRoot.getChild( 0 );
  2275. viewOL._removeChildren( 0 );
  2276. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2277. const viewP1 = viewRoot.getChild( 1 );
  2278. viewP1._removeChildren( 1 );
  2279. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2280. viewRoot._removeChildren( 2 );
  2281. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2282. renderer.markToSync( 'children', viewRoot );
  2283. renderer.markToSync( 'children', viewOL );
  2284. renderer.markToSync( 'children', viewP1 );
  2285. renderer.render();
  2286. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2287. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2288. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2289. } );
  2290. it( 'should handle classes change in replaced elements', () => {
  2291. const view = '' +
  2292. '<container:ol>' +
  2293. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2294. '</container:ol>' +
  2295. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2296. viewRoot._appendChild( parse( view ) );
  2297. renderer.markToSync( 'children', viewRoot );
  2298. renderer.render();
  2299. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2300. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2301. const viewOL = viewRoot.getChild( 0 );
  2302. const oldViewLI = viewOL.getChild( 0 );
  2303. viewOL._removeChildren( 0 );
  2304. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2305. const oldViewP = viewRoot.getChild( 1 );
  2306. viewRoot._removeChildren( 1 );
  2307. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2308. renderer.markToSync( 'attributes', oldViewLI );
  2309. renderer.markToSync( 'attributes', oldViewP );
  2310. renderer.markToSync( 'children', viewRoot );
  2311. renderer.markToSync( 'children', viewOL );
  2312. renderer.render();
  2313. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2314. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2315. } );
  2316. it( 'should handle styles change in replaced elements', () => {
  2317. const view = '' +
  2318. '<container:ol>' +
  2319. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2320. '<container:li>Bar ' +
  2321. '<attribute:i>' +
  2322. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2323. ' Bax</attribute:i>' +
  2324. '</container:li>' +
  2325. '</container:ol>';
  2326. viewRoot._appendChild( parse( view ) );
  2327. renderer.markToSync( 'children', viewRoot );
  2328. renderer.render();
  2329. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2330. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2331. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2332. const viewOL = viewRoot.getChild( 0 );
  2333. const viewLI1 = viewOL.getChild( 0 );
  2334. const viewLI2 = viewOL.getChild( 1 );
  2335. viewLI1._removeStyle( 'font-weight' );
  2336. viewLI1._setStyle( { color: '#FFF' } );
  2337. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2338. viewLI2._removeChildren( 0, viewLI2.childCount );
  2339. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2340. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2341. renderer.markToSync( 'attributes', viewLI1 );
  2342. renderer.markToSync( 'attributes', viewLI2 );
  2343. renderer.markToSync( 'children', viewRoot );
  2344. renderer.markToSync( 'children', viewLI2 );
  2345. renderer.render();
  2346. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2347. '<ol><li style="color:#FFF;">Foo</li>' +
  2348. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2349. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2350. } );
  2351. it( 'should handle uiElement rendering', () => {
  2352. function createUIElement( id, text ) {
  2353. const element = new UIElement( viewDocument, 'span' );
  2354. element.render = function( domDocument ) {
  2355. const domElement = this.toDomElement( domDocument );
  2356. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2357. return domElement;
  2358. };
  2359. return element;
  2360. }
  2361. const ui1 = createUIElement( 'id1', 'UI1' );
  2362. const ui2 = createUIElement( 'id2', 'UI2' );
  2363. const viewP = new ViewContainerElement( viewDocument, 'p', null, [
  2364. new ViewText( viewDocument, 'Foo ' ),
  2365. ui1,
  2366. new ViewText( viewDocument, 'Bar' )
  2367. ] );
  2368. viewRoot._appendChild( viewP );
  2369. renderer.markToSync( 'children', viewRoot );
  2370. renderer.render();
  2371. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2372. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2373. viewP._removeChildren( 0, viewP.childCount );
  2374. viewP._insertChild( 0, [ new ViewText( viewDocument, 'Foo' ), ui2, new ViewText( viewDocument, ' Bar' ) ] );
  2375. renderer.markToSync( 'children', viewRoot );
  2376. renderer.markToSync( 'children', viewP );
  2377. renderer.render();
  2378. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2379. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2380. } );
  2381. it( 'should handle linking entire content', () => {
  2382. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2383. renderer.markToSync( 'children', viewRoot );
  2384. renderer.render();
  2385. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2386. const viewP = viewRoot.getChild( 0 );
  2387. // While linking, the existing DOM children are moved to a new `a` element during binding
  2388. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2389. // where view elements were moved to a newly created link view element.
  2390. const viewA = new ViewAttributeElement( viewDocument, 'a', { href: '#href' }, [
  2391. new ViewText( viewDocument, 'Foo' ),
  2392. viewP.getChild( 1 )
  2393. ] );
  2394. viewP._removeChildren( 0, viewP.childCount );
  2395. viewP._insertChild( 0, viewA );
  2396. renderer.markToSync( 'children', viewRoot );
  2397. renderer.markToSync( 'children', viewP );
  2398. renderer.render();
  2399. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2400. } );
  2401. // https://github.com/ckeditor/ckeditor5/issues/6367.
  2402. it( 'should correctly handle moving a DOM element when rendering children', () => {
  2403. viewRoot._insertChild( 0, parse( 'y<attribute:span>x</attribute:span>' ) );
  2404. renderer.markToSync( 'children', viewRoot );
  2405. renderer.render();
  2406. const viewSpan = viewRoot._removeChildren( 1, 1 )[ 0 ];
  2407. viewRoot._insertChild( 0, viewSpan );
  2408. viewRoot._insertChild( 2, parse( '<attribute:strong>z</attribute:strong>' ) );
  2409. renderer.markToSync( 'children', viewRoot );
  2410. // This would throw without a fix.
  2411. renderer.render();
  2412. expect( domRoot.innerHTML ).to.equal( '<span>x</span>y<strong>z</strong>' );
  2413. } );
  2414. // https://github.com/ckeditor/ckeditor5/issues/6367, but more complex
  2415. it( 'should correctly handle moving a DOM element when rendering children (more complex case)', () => {
  2416. viewRoot._insertChild( 0,
  2417. parse( '1<attribute:span>2</attribute:span><attribute:span>3</attribute:span>4<attribute:span>5</attribute:span>' )
  2418. );
  2419. renderer.markToSync( 'children', viewRoot );
  2420. renderer.render();
  2421. const viewSpan5 = viewRoot._removeChildren( 4, 1 )[ 0 ];
  2422. const viewSpan2 = viewRoot._removeChildren( 1, 1 )[ 0 ];
  2423. viewRoot._insertChild( 0, viewSpan2 );
  2424. viewRoot._insertChild( 1, parse( '<attribute:strong>6</attribute:strong>' ) );
  2425. viewRoot._insertChild( 4, parse( '<attribute:strong>7</attribute:strong>' ) );
  2426. viewRoot._insertChild( 2, viewSpan5 );
  2427. renderer.markToSync( 'children', viewRoot );
  2428. // This would throw without a fix.
  2429. renderer.render();
  2430. expect( domRoot.innerHTML ).to.equal( '<span>2</span><strong>6</strong><span>5</span>1<span>3</span><strong>7</strong>4' );
  2431. } );
  2432. } );
  2433. describe( 'optimal (minimal) rendering – minimal children changes', () => {
  2434. let observer;
  2435. beforeEach( () => {
  2436. observer = new MutationObserver( () => {} );
  2437. observer.observe( domRoot, {
  2438. childList: true,
  2439. attributes: false,
  2440. subtree: false
  2441. } );
  2442. } );
  2443. afterEach( () => {
  2444. observer.disconnect();
  2445. } );
  2446. it( 'should add only one child (at the beginning)', () => {
  2447. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2448. renderer.markToSync( 'children', viewRoot );
  2449. renderer.render();
  2450. cleanObserver( observer );
  2451. viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
  2452. renderer.markToSync( 'children', viewRoot );
  2453. renderer.render();
  2454. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2455. 'added: 1, removed: 0'
  2456. ] );
  2457. } );
  2458. it( 'should add only one child (at the end)', () => {
  2459. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2460. renderer.markToSync( 'children', viewRoot );
  2461. renderer.render();
  2462. cleanObserver( observer );
  2463. viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
  2464. renderer.markToSync( 'children', viewRoot );
  2465. renderer.render();
  2466. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2467. 'added: 1, removed: 0'
  2468. ] );
  2469. } );
  2470. it( 'should add only one child (in the middle)', () => {
  2471. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2472. renderer.markToSync( 'children', viewRoot );
  2473. renderer.render();
  2474. cleanObserver( observer );
  2475. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2476. renderer.markToSync( 'children', viewRoot );
  2477. renderer.render();
  2478. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2479. 'added: 1, removed: 0'
  2480. ] );
  2481. } );
  2482. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2483. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2484. renderer.markToSync( 'children', viewRoot );
  2485. renderer.render();
  2486. cleanObserver( observer );
  2487. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2488. viewRoot._removeChildren( 0, 1 );
  2489. renderer.markToSync( 'children', viewRoot );
  2490. renderer.render();
  2491. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2492. } );
  2493. it( 'should remove and add one', () => {
  2494. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2495. renderer.markToSync( 'children', viewRoot );
  2496. renderer.render();
  2497. cleanObserver( observer );
  2498. viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
  2499. viewRoot._removeChildren( 0, 1 );
  2500. renderer.markToSync( 'children', viewRoot );
  2501. renderer.render();
  2502. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2503. 'added: 0, removed: 1',
  2504. 'added: 1, removed: 0'
  2505. ] );
  2506. } );
  2507. it( 'should not touch the FSC when rendering children', () => {
  2508. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2509. // Set fake selection on the second paragraph.
  2510. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2511. renderer.markToSync( 'children', viewRoot );
  2512. renderer.render();
  2513. cleanObserver( observer );
  2514. // Remove the second paragraph.
  2515. viewRoot._removeChildren( 1, 1 );
  2516. // And set the fake selection on the first one.
  2517. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2518. renderer.markToSync( 'children', viewRoot );
  2519. renderer.render();
  2520. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2521. 'added: 0, removed: 1'
  2522. ] );
  2523. } );
  2524. it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
  2525. // This test's purpose is mostly reaching 100% CC.
  2526. observer = new MutationObserver( () => {} );
  2527. viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
  2528. const viewDiv = viewRoot.getChild( 0 );
  2529. // Set fake selection on the second paragraph.
  2530. selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
  2531. renderer.markToSync( 'children', viewDiv );
  2532. renderer.markToSync( 'children', viewRoot );
  2533. renderer.render();
  2534. observer.observe( domRoot.childNodes[ 0 ], {
  2535. childList: true,
  2536. attributes: false,
  2537. subtree: false
  2538. } );
  2539. // Remove the second paragraph.
  2540. viewDiv._removeChildren( 1, 1 );
  2541. // And set the fake selection on the first one.
  2542. selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
  2543. renderer.markToSync( 'children', viewDiv );
  2544. renderer.markToSync( 'children', viewRoot );
  2545. renderer.render();
  2546. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2547. 'added: 0, removed: 1'
  2548. ] );
  2549. observer.disconnect();
  2550. } );
  2551. describe( 'using fastDiff() - significant number of nodes in the editor', () => {
  2552. it( 'should add only one child (at the beginning)', () => {
  2553. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2554. renderer.markToSync( 'children', viewRoot );
  2555. renderer.render();
  2556. cleanObserver( observer );
  2557. viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
  2558. renderer.markToSync( 'children', viewRoot );
  2559. renderer.render();
  2560. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2561. 'added: 1, removed: 0'
  2562. ] );
  2563. } );
  2564. it( 'should add only one child (at the end)', () => {
  2565. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2566. renderer.markToSync( 'children', viewRoot );
  2567. renderer.render();
  2568. cleanObserver( observer );
  2569. viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
  2570. renderer.markToSync( 'children', viewRoot );
  2571. renderer.render();
  2572. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2573. 'added: 1, removed: 0'
  2574. ] );
  2575. } );
  2576. it( 'should add only one child (in the middle)', () => {
  2577. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2578. renderer.markToSync( 'children', viewRoot );
  2579. renderer.render();
  2580. cleanObserver( observer );
  2581. viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
  2582. renderer.markToSync( 'children', viewRoot );
  2583. renderer.render();
  2584. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2585. 'added: 1, removed: 0'
  2586. ] );
  2587. } );
  2588. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2589. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2590. renderer.markToSync( 'children', viewRoot );
  2591. renderer.render();
  2592. cleanObserver( observer );
  2593. viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
  2594. viewRoot._removeChildren( 0, 1 );
  2595. renderer.markToSync( 'children', viewRoot );
  2596. renderer.render();
  2597. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2598. } );
  2599. it( 'should remove and add one', () => {
  2600. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2601. renderer.markToSync( 'children', viewRoot );
  2602. renderer.render();
  2603. cleanObserver( observer );
  2604. viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
  2605. viewRoot._removeChildren( 0, 1 );
  2606. renderer.markToSync( 'children', viewRoot );
  2607. renderer.render();
  2608. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2609. 'added: 0, removed: 1',
  2610. 'added: 1, removed: 0'
  2611. ] );
  2612. } );
  2613. it( 'should not touch the FSC when rendering children', () => {
  2614. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2615. // Set fake selection on the second paragraph.
  2616. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2617. renderer.markToSync( 'children', viewRoot );
  2618. renderer.render();
  2619. cleanObserver( observer );
  2620. // Remove the second paragraph.
  2621. viewRoot._removeChildren( 1, 1 );
  2622. // And set the fake selection on the first one.
  2623. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2624. renderer.markToSync( 'children', viewRoot );
  2625. renderer.render();
  2626. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2627. 'added: 0, removed: 1'
  2628. ] );
  2629. } );
  2630. } );
  2631. function getMutationStats( mutationList ) {
  2632. return mutationList.map( mutation => {
  2633. return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
  2634. } );
  2635. }
  2636. function cleanObserver( observer ) {
  2637. observer.takeRecords();
  2638. }
  2639. function makeContainers( howMany ) {
  2640. const containers = [];
  2641. for ( let i = 1; i <= howMany; i++ ) {
  2642. containers.push( `<container:p>${ i }</container:p>` );
  2643. }
  2644. return containers.join( '' );
  2645. }
  2646. } );
  2647. // #1560
  2648. describe( 'attributes manipulation on replaced element', () => {
  2649. it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
  2650. const writer = new DowncastWriter( viewDocument );
  2651. // 1. Setup initial view/DOM.
  2652. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2653. const viewP = viewRoot.getChild( 0 );
  2654. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2655. renderer.markToSync( 'children', viewRoot );
  2656. renderer.render();
  2657. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2658. // 2. Modify view.
  2659. writer.removeAttribute( 'data-placeholder', viewP );
  2660. viewRoot._removeChildren( 0, viewRoot.childCount );
  2661. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2662. renderer.markToSync( 'attributes', viewP );
  2663. renderer.markToSync( 'children', viewRoot );
  2664. renderer.render();
  2665. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2666. } );
  2667. it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
  2668. const writer = new DowncastWriter( viewDocument );
  2669. // 1. Setup initial view/DOM.
  2670. viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
  2671. const viewP = viewRoot.getChild( 1 );
  2672. writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
  2673. renderer.markToSync( 'children', viewRoot );
  2674. renderer.render();
  2675. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
  2676. // 2. Modify view.
  2677. writer.removeClass( 'cke-test2', viewP );
  2678. viewRoot._removeChildren( 0, viewRoot.childCount );
  2679. viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
  2680. '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
  2681. renderer.markToSync( 'attributes', viewP );
  2682. renderer.markToSync( 'children', viewRoot );
  2683. renderer.render();
  2684. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
  2685. } );
  2686. it( 'should rerender element if it was removed and have its attributes removed after', () => {
  2687. const writer = new DowncastWriter( viewDocument );
  2688. // 1. Setup initial view/DOM.
  2689. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2690. const viewP = viewRoot.getChild( 0 );
  2691. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2692. renderer.markToSync( 'children', viewRoot );
  2693. renderer.render();
  2694. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2695. // 2. Modify view.
  2696. viewRoot._removeChildren( 0, viewRoot.childCount );
  2697. writer.removeAttribute( 'data-placeholder', viewP );
  2698. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2699. renderer.markToSync( 'children', viewRoot );
  2700. renderer.render();
  2701. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2702. } );
  2703. } );
  2704. // ckeditor/ckeditor5-utils#269
  2705. // The expected times has a significant margin above the usual execution time (which is around 40-50%
  2706. // of the expected time) because it depends on the browser and environment in which tests are run.
  2707. // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
  2708. // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
  2709. describe( 'rendering performance', () => {
  2710. it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
  2711. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
  2712. expect( renderingTime ).to.be.within( 0, 350 );
  2713. } );
  2714. it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
  2715. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
  2716. expect( renderingTime ).to.be.within( 0, 350 );
  2717. } );
  2718. it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
  2719. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
  2720. expect( renderingTime ).to.be.within( 0, 350 );
  2721. } );
  2722. it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
  2723. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
  2724. expect( renderingTime ).to.be.within( 0, 350 );
  2725. } );
  2726. it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
  2727. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
  2728. expect( renderingTime ).to.be.within( 0, 350 );
  2729. } );
  2730. it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
  2731. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
  2732. expect( renderingTime ).to.be.within( 0, 350 );
  2733. } );
  2734. function measureRenderingTime( viewRoot, initialData, newData ) {
  2735. // Set initial data.
  2736. const initialView = parse( initialData );
  2737. viewRoot._appendChild( initialView );
  2738. renderer.markToSync( 'children', viewRoot );
  2739. renderer.render();
  2740. // Set new data.
  2741. const newView = parse( newData );
  2742. viewRoot._removeChildren( 0, viewRoot.childCount );
  2743. viewRoot._appendChild( newView );
  2744. renderer.markToSync( 'children', viewRoot );
  2745. // Measure render time.
  2746. const start = Date.now();
  2747. renderer.render();
  2748. return Date.now() - start;
  2749. }
  2750. function generateViewData1( repeat = 1 ) {
  2751. const viewData = '' +
  2752. '<container:h1>' +
  2753. 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
  2754. '</container:h1>' +
  2755. '<container:p>' +
  2756. 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
  2757. '</container:p>' +
  2758. '<container:ul>' +
  2759. '<container:li>Item 1</container:li>' +
  2760. '</container:ul>' +
  2761. '<container:ul>' +
  2762. '<container:li>Item 2</container:li>' +
  2763. '</container:ul>' +
  2764. '<container:ul>' +
  2765. '<container:li>Item 3</container:li>' +
  2766. '</container:ul>';
  2767. return viewData.repeat( repeat );
  2768. }
  2769. function generateViewData2( repeat = 1 ) {
  2770. const viewData = '' +
  2771. '<container:ol>' +
  2772. '<container:li>' +
  2773. '<attribute:strong>Foo</attribute:strong>' +
  2774. '</container:li>' +
  2775. '</container:ol>' +
  2776. '<container:ol>' +
  2777. '<container:li>Item 1</container:li>' +
  2778. '</container:ol>' +
  2779. '<container:h1>Heading 1</container:h1>' +
  2780. '<container:h2>' +
  2781. '<attribute:strong>Heading</attribute:strong> 2' +
  2782. '</container:h2>' +
  2783. '<container:h3>Heading 4</container:h3>';
  2784. return viewData.repeat( repeat );
  2785. }
  2786. } );
  2787. } );
  2788. describe( '#922', () => {
  2789. let view, viewDoc, viewRoot, domRoot, converter;
  2790. beforeEach( () => {
  2791. view = new View( new StylesProcessor() );
  2792. viewDoc = view.document;
  2793. domRoot = document.createElement( 'div' );
  2794. document.body.appendChild( domRoot );
  2795. viewRoot = createViewRoot( viewDoc );
  2796. view.attachDomRoot( domRoot );
  2797. converter = view.domConverter;
  2798. } );
  2799. afterEach( () => {
  2800. view.destroy();
  2801. domRoot.remove();
  2802. } );
  2803. it( 'should properly render unwrapped attributes #1', () => {
  2804. setViewData( view,
  2805. '<container:p>' +
  2806. '[<attribute:italic>' +
  2807. '<attribute:strong>f</attribute:strong>' +
  2808. '</attribute:italic>]' +
  2809. '<attribute:strong>oo</attribute:strong>' +
  2810. '</container:p>'
  2811. );
  2812. // Render it to DOM to create initial DOM <-> view mappings.
  2813. view.forceRender();
  2814. // Unwrap italic attribute element.
  2815. view.change( writer => {
  2816. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2817. } );
  2818. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2819. // Re-render changes in view to DOM.
  2820. view.forceRender();
  2821. // Check if DOM is rendered correctly.
  2822. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2823. expect( checkMappings() ).to.be.true;
  2824. } );
  2825. it( 'should properly render unwrapped attributes #2', () => {
  2826. setViewData( view,
  2827. '<container:p>' +
  2828. '[<attribute:italic>' +
  2829. '<attribute:strong>foo</attribute:strong>' +
  2830. '</attribute:italic>]' +
  2831. '</container:p>' );
  2832. // Render it to DOM to create initial DOM <-> view mappings.
  2833. view.forceRender();
  2834. // Unwrap italic attribute element and change text inside.
  2835. view.change( writer => {
  2836. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( viewDocument, 'italic' ) );
  2837. } );
  2838. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2839. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2840. // Re-render changes in view to DOM.
  2841. view.forceRender();
  2842. // Check if DOM is rendered correctly.
  2843. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2844. expect( checkMappings() ).to.be.true;
  2845. } );
  2846. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2847. setViewData( view,
  2848. '<container:p>foo</container:p>'
  2849. );
  2850. // Render it to DOM to create initial DOM <-> view mappings.
  2851. view.forceRender();
  2852. // Change text and insert new element into paragraph.
  2853. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2854. textNode._data = 'foobar';
  2855. view.change( writer => {
  2856. writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2857. } );
  2858. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2859. // Re-render changes in view to DOM.
  2860. view.forceRender();
  2861. // Check if DOM is rendered correctly.
  2862. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2863. expect( checkMappings() ).to.be.true;
  2864. } );
  2865. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2866. setViewData( view,
  2867. '<container:p>foo</container:p>'
  2868. );
  2869. // Render it to DOM to create initial DOM <-> view mappings.
  2870. view.forceRender();
  2871. // Change text and insert new element into paragraph.
  2872. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2873. textNode._data = 'foobar';
  2874. view.change( writer => {
  2875. writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( viewDocument, 'img' ) );
  2876. } );
  2877. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2878. // Re-render changes in view to DOM.
  2879. view.forceRender();
  2880. // Check if DOM is rendered correctly.
  2881. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2882. expect( checkMappings() ).to.be.true;
  2883. } );
  2884. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2885. setViewData( view,
  2886. '<container:p>' +
  2887. '<attribute:b></attribute:b>' +
  2888. '<attribute:i></attribute:i>' +
  2889. '<attribute:span></attribute:span>' +
  2890. '</container:p>'
  2891. );
  2892. // Render it to DOM to create initial DOM <-> view mappings.
  2893. view.forceRender();
  2894. // Remove first element and reinsert it at the end.
  2895. const container = viewRoot.getChild( 0 );
  2896. const firstElement = container.getChild( 0 );
  2897. view.change( writer => {
  2898. writer.remove( ViewRange._createOn( firstElement ) );
  2899. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2900. } );
  2901. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2902. // Re-render changes in view to DOM.
  2903. view.forceRender();
  2904. // Check if DOM is rendered correctly.
  2905. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2906. expect( checkMappings() ).to.be.true;
  2907. } );
  2908. // Checks if every node in DOM tree is mapped to the view.
  2909. function checkMappings() {
  2910. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2911. while ( domWalker.nextNode() ) {
  2912. const node = domWalker.currentNode;
  2913. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2914. return false;
  2915. }
  2916. }
  2917. return true;
  2918. }
  2919. } );
  2920. describe( '_markDescendantTextToSync', () => {
  2921. let viewRoot;
  2922. beforeEach( () => {
  2923. viewRoot = new ViewElement( viewDocument, 'div' );
  2924. renderer.markedTexts.clear();
  2925. renderer.markedAttributes.clear();
  2926. renderer.markedChildren.clear();
  2927. } );
  2928. it( 'should handle null values', () => {
  2929. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2930. renderer._markDescendantTextToSync( null );
  2931. expect( renderer.markedChildren.size ).to.equal( 0 );
  2932. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2933. expect( renderer.markedTexts.size ).to.equal( 0 );
  2934. } );
  2935. it( 'should handle element nodes', () => {
  2936. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2937. viewRoot._appendChild( viewP );
  2938. renderer._markDescendantTextToSync( viewP );
  2939. expect( renderer.markedChildren.size ).to.equal( 0 );
  2940. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2941. expect( renderer.markedTexts.size ).to.equal( 3 );
  2942. } );
  2943. it( 'should handle text nodes', () => {
  2944. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2945. viewRoot._appendChild( viewP );
  2946. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2947. expect( renderer.markedChildren.size ).to.equal( 0 );
  2948. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2949. expect( renderer.markedTexts.size ).to.equal( 1 );
  2950. } );
  2951. it( 'should handle document fragment', () => {
  2952. const fragment = new DocumentFragment();
  2953. renderer._markDescendantTextToSync( fragment );
  2954. expect( renderer.markedChildren.size ).to.equal( 0 );
  2955. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2956. expect( renderer.markedTexts.size ).to.equal( 0 );
  2957. } );
  2958. it( 'should handle empty element nodes', () => {
  2959. const viewP = parse( '<container:p></container:p>' );
  2960. viewRoot._appendChild( viewP );
  2961. renderer._markDescendantTextToSync( viewP );
  2962. expect( renderer.markedChildren.size ).to.equal( 0 );
  2963. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2964. expect( renderer.markedTexts.size ).to.equal( 0 );
  2965. } );
  2966. } );
  2967. describe( '_updateText', () => {
  2968. let viewRoot, domRoot;
  2969. beforeEach( () => {
  2970. viewRoot = new ViewElement( viewDocument, 'div' );
  2971. domRoot = document.createElement( 'div' );
  2972. document.body.appendChild( domRoot );
  2973. domConverter.bindElements( domRoot, viewRoot );
  2974. renderer.markedTexts.clear();
  2975. renderer.markedAttributes.clear();
  2976. renderer.markedChildren.clear();
  2977. renderer.isFocused = true;
  2978. } );
  2979. afterEach( () => {
  2980. domRoot.remove();
  2981. } );
  2982. it( 'should update text - change on end', () => {
  2983. const viewText = new ViewText( viewDocument, 'foo' );
  2984. viewRoot._appendChild( viewText );
  2985. renderer.markToSync( 'children', viewRoot );
  2986. renderer.render();
  2987. expect( domRoot.childNodes.length ).to.equal( 1 );
  2988. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2989. viewText._data = 'fobar';
  2990. renderer._updateText( viewText, {} );
  2991. expect( domRoot.childNodes.length ).to.equal( 1 );
  2992. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2993. } );
  2994. it( 'should update text - change on start', () => {
  2995. const viewText = new ViewText( viewDocument, 'foo' );
  2996. viewRoot._appendChild( viewText );
  2997. renderer.markToSync( 'children', viewRoot );
  2998. renderer.render();
  2999. expect( domRoot.childNodes.length ).to.equal( 1 );
  3000. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3001. viewText._data = 'baro';
  3002. renderer._updateText( viewText, {} );
  3003. expect( domRoot.childNodes.length ).to.equal( 1 );
  3004. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  3005. } );
  3006. it( 'should update text - change in the middle', () => {
  3007. const viewText = new ViewText( viewDocument, 'foobar' );
  3008. viewRoot._appendChild( viewText );
  3009. renderer.markToSync( 'children', viewRoot );
  3010. renderer.render();
  3011. expect( domRoot.childNodes.length ).to.equal( 1 );
  3012. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  3013. viewText._data = 'fobazr';
  3014. renderer._updateText( viewText, {} );
  3015. expect( domRoot.childNodes.length ).to.equal( 1 );
  3016. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  3017. } );
  3018. it( 'should update text - empty expected', () => {
  3019. const viewText = new ViewText( viewDocument, 'foo' );
  3020. viewRoot._appendChild( viewText );
  3021. renderer.markToSync( 'children', viewRoot );
  3022. renderer.render();
  3023. expect( domRoot.childNodes.length ).to.equal( 1 );
  3024. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3025. viewText._data = '';
  3026. renderer._updateText( viewText, {} );
  3027. expect( domRoot.childNodes.length ).to.equal( 1 );
  3028. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3029. } );
  3030. it( 'should update text - empty actual', () => {
  3031. const viewText = new ViewText( viewDocument, '' );
  3032. viewRoot._appendChild( viewText );
  3033. renderer.markToSync( 'children', viewRoot );
  3034. renderer.render();
  3035. expect( domRoot.childNodes.length ).to.equal( 1 );
  3036. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3037. viewText._data = 'fobar';
  3038. renderer._updateText( viewText, {} );
  3039. expect( domRoot.childNodes.length ).to.equal( 1 );
  3040. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  3041. } );
  3042. it( 'should handle filler during text modifications', () => {
  3043. const viewText = new ViewText( viewDocument, 'foo' );
  3044. viewRoot._appendChild( viewText );
  3045. renderer.markToSync( 'children', viewRoot );
  3046. renderer.render();
  3047. expect( domRoot.childNodes.length ).to.equal( 1 );
  3048. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  3049. // 1. Insert filler.
  3050. renderer._updateText( viewText, {
  3051. inlineFillerPosition: {
  3052. parent: viewText.parent,
  3053. offset: 0
  3054. }
  3055. } );
  3056. expect( domRoot.childNodes.length ).to.equal( 1 );
  3057. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3058. // 2. Edit text - filler should be preserved.
  3059. viewText._data = 'barfoo';
  3060. renderer._updateText( viewText, {
  3061. inlineFillerPosition: {
  3062. parent: viewText.parent,
  3063. offset: 0
  3064. }
  3065. } );
  3066. expect( domRoot.childNodes.length ).to.equal( 1 );
  3067. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  3068. // 3. Remove filler.
  3069. renderer._updateText( viewText, {} );
  3070. expect( domRoot.childNodes.length ).to.equal( 1 );
  3071. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  3072. } );
  3073. it( 'should handle filler during text modifications - empty text', () => {
  3074. const viewText = new ViewText( viewDocument, '' );
  3075. viewRoot._appendChild( viewText );
  3076. renderer.markToSync( 'children', viewRoot );
  3077. renderer.render();
  3078. expect( domRoot.childNodes.length ).to.equal( 1 );
  3079. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3080. // 1. Insert filler.
  3081. renderer._updateText( viewText, {
  3082. inlineFillerPosition: {
  3083. parent: viewText.parent,
  3084. offset: 0
  3085. }
  3086. } );
  3087. expect( domRoot.childNodes.length ).to.equal( 1 );
  3088. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  3089. // 2. Edit text - filler should be preserved.
  3090. viewText._data = 'foo';
  3091. renderer._updateText( viewText, {
  3092. inlineFillerPosition: {
  3093. parent: viewText.parent,
  3094. offset: 0
  3095. }
  3096. } );
  3097. expect( domRoot.childNodes.length ).to.equal( 1 );
  3098. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3099. // 3. Remove filler.
  3100. viewText._data = '';
  3101. renderer._updateText( viewText, {} );
  3102. expect( domRoot.childNodes.length ).to.equal( 1 );
  3103. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3104. } );
  3105. it( 'should handle filler during text modifications inside inline element', () => {
  3106. const viewB = new ViewElement( viewDocument, 'b' );
  3107. const viewText = new ViewText( viewDocument, 'foo' );
  3108. viewB._appendChild( viewText );
  3109. viewRoot._appendChild( viewB );
  3110. renderer.markToSync( 'children', viewRoot );
  3111. renderer.render();
  3112. expect( domRoot.childNodes.length ).to.equal( 1 );
  3113. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3114. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3115. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  3116. // 1. Insert filler.
  3117. renderer._updateText( viewText, {
  3118. inlineFillerPosition: {
  3119. parent: viewText.parent,
  3120. offset: 0
  3121. }
  3122. } );
  3123. expect( domRoot.childNodes.length ).to.equal( 1 );
  3124. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3125. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3126. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3127. // 2. Edit text - filler should be preserved.
  3128. viewText._data = 'bar';
  3129. renderer._updateText( viewText, {
  3130. inlineFillerPosition: {
  3131. parent: viewText.parent,
  3132. offset: 0
  3133. }
  3134. } );
  3135. expect( domRoot.childNodes.length ).to.equal( 1 );
  3136. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3137. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3138. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  3139. // 3. Remove filler.
  3140. viewText._data = 'bar';
  3141. renderer._updateText( viewText, {} );
  3142. expect( domRoot.childNodes.length ).to.equal( 1 );
  3143. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3144. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3145. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  3146. } );
  3147. } );
  3148. } );
  3149. function renderAndExpectNoChanges( renderer, domRoot ) {
  3150. const config = {
  3151. childList: true,
  3152. characterData: true,
  3153. characterDataOldValue: true,
  3154. subtree: true
  3155. };
  3156. const mutationObserver = new window.MutationObserver( () => {
  3157. throw 'There should be not mutations';
  3158. } );
  3159. mutationObserver.observe( domRoot, config );
  3160. renderer.render();
  3161. const records = mutationObserver.takeRecords();
  3162. mutationObserver.disconnect();
  3163. expect( records.length ).to.equal( 0 );
  3164. }