renderer.js 126 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewContainerElement from '../../src/view/containerelement';
  9. import ViewAttributeElement from '../../src/view/attributeelement';
  10. import ViewText from '../../src/view/text';
  11. import ViewRange from '../../src/view/range';
  12. import ViewPosition from '../../src/view/position';
  13. import UIElement from '../../src/view/uielement';
  14. import DocumentSelection from '../../src/view/documentselection';
  15. import DomConverter from '../../src/view/domconverter';
  16. import Renderer from '../../src/view/renderer';
  17. import DocumentFragment from '../../src/view/documentfragment';
  18. import DowncastWriter from '../../src/view/downcastwriter';
  19. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  20. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  21. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  22. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  23. import createViewRoot from './_utils/createroot';
  24. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  25. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  26. describe( 'Renderer', () => {
  27. let selection, domConverter, renderer;
  28. testUtils.createSinonSandbox();
  29. beforeEach( () => {
  30. selection = new DocumentSelection();
  31. domConverter = new DomConverter();
  32. renderer = new Renderer( domConverter, selection );
  33. renderer.domDocuments.add( document );
  34. } );
  35. describe( 'markToSync', () => {
  36. let viewRoot;
  37. beforeEach( () => {
  38. viewRoot = new ViewElement( 'p' );
  39. const domRoot = document.createElement( 'p' );
  40. domConverter.bindElements( domRoot, viewRoot );
  41. viewRoot._appendChild( new ViewText( 'foo' ) );
  42. renderer.markedTexts.clear();
  43. renderer.markedAttributes.clear();
  44. renderer.markedChildren.clear();
  45. } );
  46. it( 'should mark attributes which need update', () => {
  47. viewRoot._setAttribute( 'class', 'foo' );
  48. renderer.markToSync( 'attributes', viewRoot );
  49. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  50. } );
  51. it( 'should mark children which need update', () => {
  52. viewRoot._appendChild( new ViewText( 'foo' ) );
  53. renderer.markToSync( 'children', viewRoot );
  54. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  55. } );
  56. it( 'should not mark children if element has no corresponding node', () => {
  57. // Overwrite viewRoot with node without coresponding DOM node.
  58. viewRoot = new ViewElement( 'p' );
  59. viewRoot._appendChild( new ViewText( 'foo' ) );
  60. renderer.markToSync( 'children', viewRoot );
  61. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  62. } );
  63. it( 'should mark text which need update', () => {
  64. const viewText = new ViewText( 'foo' );
  65. viewRoot._appendChild( viewText );
  66. viewText._data = 'bar';
  67. renderer.markToSync( 'text', viewText );
  68. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  69. } );
  70. it( 'should not mark text if parent has no corresponding node', () => {
  71. const viewText = new ViewText( 'foo' );
  72. // Overwrite viewRoot with node without coresponding DOM node.
  73. viewRoot = new ViewElement( 'p' );
  74. viewRoot._appendChild( viewText );
  75. viewText._data = 'bar';
  76. renderer.markToSync( 'text', viewText );
  77. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  78. } );
  79. it( 'should throw if the type is unknown', () => {
  80. expect( () => {
  81. renderer.markToSync( 'UNKNOWN', viewRoot );
  82. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  83. } );
  84. } );
  85. describe( 'render', () => {
  86. let viewRoot, domRoot, selectionEditable;
  87. beforeEach( () => {
  88. viewRoot = new ViewElement( 'div' );
  89. domRoot = document.createElement( 'div' );
  90. document.body.appendChild( domRoot );
  91. domConverter.bindElements( domRoot, viewRoot );
  92. renderer.markedTexts.clear();
  93. renderer.markedAttributes.clear();
  94. renderer.markedChildren.clear();
  95. selection._setTo( null );
  96. selectionEditable = viewRoot;
  97. renderer.isFocused = true;
  98. // Fake selection editable - it is needed to render selection properly.
  99. Object.defineProperty( selection, 'editableElement', {
  100. get() {
  101. return selectionEditable;
  102. }
  103. } );
  104. } );
  105. afterEach( () => {
  106. domRoot.remove();
  107. } );
  108. it( 'should update attributes', () => {
  109. viewRoot._setAttribute( 'class', 'foo' );
  110. renderer.markToSync( 'attributes', viewRoot );
  111. renderer.render();
  112. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  113. expect( renderer.markedAttributes.size ).to.equal( 0 );
  114. } );
  115. it( 'should remove attributes', () => {
  116. viewRoot._setAttribute( 'class', 'foo' );
  117. domRoot.setAttribute( 'id', 'bar' );
  118. domRoot.setAttribute( 'class', 'bar' );
  119. renderer.markToSync( 'attributes', viewRoot );
  120. renderer.render();
  121. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  122. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  123. expect( renderer.markedAttributes.size ).to.equal( 0 );
  124. } );
  125. it( 'should add children', () => {
  126. viewRoot._appendChild( new ViewText( 'foo' ) );
  127. renderer.markToSync( 'children', viewRoot );
  128. renderer.render();
  129. expect( domRoot.childNodes.length ).to.equal( 1 );
  130. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  131. expect( renderer.markedChildren.size ).to.equal( 0 );
  132. } );
  133. it( 'should remove children', () => {
  134. viewRoot._appendChild( new ViewText( 'foo' ) );
  135. renderer.markToSync( 'children', viewRoot );
  136. renderer.render();
  137. expect( domRoot.childNodes.length ).to.equal( 1 );
  138. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  139. viewRoot._removeChildren( 0, 1 );
  140. renderer.markToSync( 'children', viewRoot );
  141. renderer.render();
  142. expect( domRoot.childNodes.length ).to.equal( 0 );
  143. expect( renderer.markedChildren.size ).to.equal( 0 );
  144. } );
  145. it( 'should update text', () => {
  146. const viewText = new ViewText( 'foo' );
  147. viewRoot._appendChild( viewText );
  148. renderer.markToSync( 'children', viewRoot );
  149. renderer.render();
  150. expect( domRoot.childNodes.length ).to.equal( 1 );
  151. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  152. viewText._data = 'bar';
  153. renderer.markToSync( 'text', viewText );
  154. renderer.render();
  155. expect( domRoot.childNodes.length ).to.equal( 1 );
  156. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  157. expect( renderer.markedTexts.size ).to.equal( 0 );
  158. } );
  159. it( 'should not update same text', () => {
  160. const viewText = new ViewText( 'foo' );
  161. viewRoot._appendChild( viewText );
  162. renderer.markToSync( 'children', viewRoot );
  163. renderer.render();
  164. expect( domRoot.childNodes.length ).to.equal( 1 );
  165. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  166. viewText._data = 'foo';
  167. renderer.markToSync( 'text', viewText );
  168. renderAndExpectNoChanges( renderer, domRoot );
  169. expect( domRoot.childNodes.length ).to.equal( 1 );
  170. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  171. expect( renderer.markedTexts.size ).to.equal( 0 );
  172. } );
  173. it( 'should not update text parent child list changed', () => {
  174. const viewImg = new ViewElement( 'img' );
  175. const viewText = new ViewText( 'foo' );
  176. viewRoot._appendChild( [ viewImg, viewText ] );
  177. renderer.markToSync( 'children', viewRoot );
  178. renderer.markToSync( 'text', viewText );
  179. renderer.render();
  180. expect( domRoot.childNodes.length ).to.equal( 2 );
  181. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  182. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  183. } );
  184. it( 'should not change text if it is the same during text rendering', () => {
  185. const viewText = new ViewText( 'foo' );
  186. viewRoot._appendChild( viewText );
  187. renderer.markToSync( 'children', viewRoot );
  188. renderer.render();
  189. // This should not be changed during the render.
  190. const domText = domRoot.childNodes[ 0 ];
  191. renderer.markToSync( 'text', viewText );
  192. renderer.render();
  193. expect( domRoot.childNodes.length ).to.equal( 1 );
  194. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  195. } );
  196. it( 'should not change text if it is the same during children rendering', () => {
  197. const viewText = new ViewText( 'foo' );
  198. viewRoot._appendChild( viewText );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. // This should not be changed during the render.
  202. const domText = domRoot.childNodes[ 0 ];
  203. renderer.markToSync( 'children', viewRoot );
  204. renderer.render();
  205. expect( domRoot.childNodes.length ).to.equal( 1 );
  206. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  207. } );
  208. it( 'should not change element if it is the same', () => {
  209. const viewImg = new ViewElement( 'img' );
  210. viewRoot._appendChild( viewImg );
  211. // This should not be changed during the render.
  212. const domImg = document.createElement( 'img' );
  213. domRoot.appendChild( domImg );
  214. domConverter.bindElements( domImg, viewImg );
  215. renderer.markToSync( 'children', viewRoot );
  216. renderer.render();
  217. expect( domRoot.childNodes.length ).to.equal( 1 );
  218. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  219. } );
  220. it( 'should change element if it is different', () => {
  221. const viewImg = new ViewElement( 'img' );
  222. viewRoot._appendChild( viewImg );
  223. renderer.markToSync( 'children', viewRoot );
  224. renderer.render();
  225. const viewP = new ViewElement( 'p' );
  226. viewRoot._removeChildren( 0, 1 );
  227. viewRoot._appendChild( viewP );
  228. renderer.markToSync( 'children', viewRoot );
  229. renderer.render();
  230. expect( domRoot.childNodes.length ).to.equal( 1 );
  231. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  232. } );
  233. it( 'should update removed item when it is reinserted', () => {
  234. const viewFoo = new ViewText( 'foo' );
  235. const viewP = new ViewElement( 'p', null, viewFoo );
  236. const viewDiv = new ViewElement( 'div', null, viewP );
  237. viewRoot._appendChild( viewDiv );
  238. renderer.markToSync( 'children', viewRoot );
  239. renderer.render();
  240. viewDiv._removeChildren( 0, 1 );
  241. renderer.markToSync( 'children', viewDiv );
  242. renderer.render();
  243. viewP._removeChildren( 0, 1 );
  244. viewDiv._appendChild( viewP );
  245. renderer.markToSync( 'children', viewDiv );
  246. renderer.render();
  247. expect( domRoot.childNodes.length ).to.equal( 1 );
  248. const domDiv = domRoot.childNodes[ 0 ];
  249. expect( domDiv.tagName ).to.equal( 'DIV' );
  250. expect( domDiv.childNodes.length ).to.equal( 1 );
  251. const domP = domDiv.childNodes[ 0 ];
  252. expect( domP.tagName ).to.equal( 'P' );
  253. expect( domP.childNodes.length ).to.equal( 0 );
  254. } );
  255. it( 'should update removed item when it is reinserted #2', () => {
  256. // Prepare view: root -> div "outer" -> div "inner" -> p.
  257. const viewP = new ViewElement( 'p' );
  258. const viewDivInner = new ViewElement( 'div', null, viewP );
  259. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  260. viewRoot._appendChild( viewDivOuter );
  261. // Render view tree to DOM.
  262. renderer.markToSync( 'children', viewRoot );
  263. renderer.render();
  264. // Remove div "outer" from root and render it.
  265. viewDivOuter._remove();
  266. renderer.markToSync( 'children', viewRoot );
  267. renderer.render();
  268. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  269. viewP._remove();
  270. // Add div "outer" back to root.
  271. viewRoot._appendChild( viewDivOuter );
  272. renderer.markToSync( 'children', viewRoot );
  273. // Render changes, view is: root -> div "outer" -> div "inner".
  274. renderer.render();
  275. // Same is expected in DOM.
  276. expect( domRoot.childNodes.length ).to.equal( 1 );
  277. const domDivOuter = domRoot.childNodes[ 0 ];
  278. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  279. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  280. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  281. const domDivInner = domDivOuter.childNodes[ 0 ];
  282. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  283. expect( domDivInner.tagName ).to.equal( 'DIV' );
  284. expect( domDivInner.childNodes.length ).to.equal( 0 );
  285. } );
  286. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  287. const viewFoo = new ViewText( 'foo' );
  288. const viewP = new ViewElement( 'p', null, viewFoo );
  289. const viewDiv = new ViewElement( 'div', null, viewP );
  290. viewRoot._appendChild( viewDiv );
  291. renderer.markToSync( 'children', viewRoot );
  292. renderer.render();
  293. viewRoot._removeChildren( 0, 1 );
  294. renderer.markToSync( 'children', viewRoot );
  295. viewDiv._removeChildren( 0, 1 );
  296. renderer.markToSync( 'children', viewDiv );
  297. viewP._removeChildren( 0, 1 );
  298. renderer.markToSync( 'children', viewP );
  299. renderer.render();
  300. expect( domRoot.childNodes.length ).to.equal( 0 );
  301. } );
  302. it( 'should not care about filler if there is no DOM', () => {
  303. selectionEditable = null;
  304. const { view: viewP, selection: newSelection } = parse(
  305. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  306. const viewRoot = new ViewElement( 'p' );
  307. viewRoot._appendChild( viewP );
  308. selection._setTo( newSelection );
  309. renderer.markToSync( 'children', viewRoot );
  310. renderer.render();
  311. // Expect no error on render.
  312. expect( viewRoot ).to.be.ok;
  313. } );
  314. it( 'should not add filler when inside contenteditable=false parent', () => {
  315. const { view: viewP, selection: newSelection } = parse(
  316. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  317. viewRoot._appendChild( viewP );
  318. selection._setTo( newSelection );
  319. renderer.markToSync( 'children', viewRoot );
  320. renderer.render();
  321. expect( domRoot.childNodes.length ).to.equal( 1 );
  322. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  323. const domP = domRoot.childNodes[ 0 ];
  324. expect( domP.childNodes.length ).to.equal( 3 );
  325. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  326. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  327. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  328. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  329. } );
  330. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  331. const { view: viewP, selection: newSelection } = parse(
  332. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  333. viewRoot._appendChild( viewP );
  334. selection._setTo( newSelection );
  335. renderer.markToSync( 'children', viewRoot );
  336. renderer.render();
  337. expect( domRoot.childNodes.length ).to.equal( 1 );
  338. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  339. const domP = domRoot.childNodes[ 0 ];
  340. expect( domP.childNodes.length ).to.equal( 3 );
  341. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  342. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  343. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  344. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  345. } );
  346. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  347. const domSelection = document.getSelection();
  348. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  349. const { view: viewP, selection: newSelection } = parse(
  350. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  351. viewRoot._appendChild( viewP );
  352. selection._setTo( newSelection );
  353. renderer.markToSync( 'children', viewRoot );
  354. renderer.render();
  355. expect( domRoot.childNodes.length ).to.equal( 1 );
  356. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  357. const domP = domRoot.childNodes[ 0 ];
  358. expect( domP.childNodes.length ).to.equal( 3 );
  359. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  360. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  361. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  362. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  363. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  364. expect( domSelection.rangeCount ).to.equal( 1 );
  365. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  366. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  367. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  368. // Step 2: No mutation on second render
  369. renderer.markToSync( 'children', viewRoot );
  370. renderer.markToSync( 'children', viewP );
  371. renderAndExpectNoChanges( renderer, domRoot );
  372. // Step 3: <p>foo{}<b></b></p>
  373. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  374. renderer.render();
  375. expect( domP.childNodes.length ).to.equal( 3 );
  376. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  377. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  378. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  379. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  380. expect( domSelection.rangeCount ).to.equal( 1 );
  381. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  382. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  383. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  384. // Step 4: No mutation on second render
  385. renderer.markToSync( 'children', viewRoot );
  386. renderer.markToSync( 'children', viewP );
  387. renderAndExpectNoChanges( renderer, domRoot );
  388. } );
  389. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  390. const domSelection = document.getSelection();
  391. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  392. const { view: viewP, selection: newSelection } = parse(
  393. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  394. viewRoot._appendChild( viewP );
  395. selection._setTo( newSelection );
  396. renderer.markToSync( 'children', viewRoot );
  397. renderer.render();
  398. const domP = domRoot.childNodes[ 0 ];
  399. expect( domP.childNodes.length ).to.equal( 2 );
  400. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  401. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  402. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  403. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  404. expect( domSelection.rangeCount ).to.equal( 1 );
  405. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  406. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  407. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  408. // Step 2: No mutation on second render
  409. renderer.markToSync( 'children', viewP );
  410. renderAndExpectNoChanges( renderer, domRoot );
  411. // Step 3: <p><b>{}foo</b></p>
  412. selection._setTo( ViewRange.createFromParentsAndOffsets(
  413. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  414. renderer.render();
  415. expect( domP.childNodes.length ).to.equal( 1 );
  416. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  417. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  418. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  419. expect( domSelection.rangeCount ).to.equal( 1 );
  420. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  421. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  422. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  423. // Step 4: No mutation on second render
  424. renderer.markToSync( 'children', viewP );
  425. renderAndExpectNoChanges( renderer, domRoot );
  426. } );
  427. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  428. const domSelection = document.getSelection();
  429. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  430. const { view: viewP, selection: newSelection } = parse(
  431. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  432. viewRoot._appendChild( viewP );
  433. selection._setTo( newSelection );
  434. renderer.markToSync( 'children', viewRoot );
  435. renderer.render();
  436. const domP = domRoot.childNodes[ 0 ];
  437. expect( domP.childNodes.length ).to.equal( 2 );
  438. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  439. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  440. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  441. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  442. expect( domSelection.rangeCount ).to.equal( 1 );
  443. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  444. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  445. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  446. // Step 2: No mutation on second render
  447. renderer.markToSync( 'children', viewP );
  448. renderAndExpectNoChanges( renderer, domRoot );
  449. // Step 3: <p><b>foo{}</b></p>
  450. selection._setTo( ViewRange.createFromParentsAndOffsets(
  451. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  452. renderer.render();
  453. expect( domP.childNodes.length ).to.equal( 1 );
  454. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  455. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  456. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  457. expect( domSelection.rangeCount ).to.equal( 1 );
  458. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  459. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  460. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  461. // Step 4: No mutation on second render
  462. renderer.markToSync( 'children', viewP );
  463. renderAndExpectNoChanges( renderer, domRoot );
  464. } );
  465. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  466. const domSelection = document.getSelection();
  467. const { view: viewP, selection: newSelection } = parse(
  468. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  469. viewRoot._appendChild( viewP );
  470. selection._setTo( newSelection );
  471. renderer.markToSync( 'children', viewRoot );
  472. renderer.render();
  473. const domP = domRoot.childNodes[ 0 ];
  474. expect( domP.childNodes.length ).to.equal( 3 );
  475. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  476. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  477. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  478. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  479. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  480. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  481. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  482. expect( domSelection.rangeCount ).to.equal( 1 );
  483. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  484. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  485. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  486. } );
  487. it( 'should move filler when selection is moved', () => {
  488. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  489. const { view: viewP, selection: newSelection } = parse(
  490. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  491. viewRoot._appendChild( viewP );
  492. selection._setTo( newSelection );
  493. renderer.markToSync( 'children', viewRoot );
  494. renderer.render();
  495. const domP = domRoot.childNodes[ 0 ];
  496. expect( domP.childNodes.length ).to.equal( 3 );
  497. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  498. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  499. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  500. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  501. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  502. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  503. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  504. const viewI = viewP.getChild( 2 );
  505. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  506. renderer.render();
  507. expect( domP.childNodes.length ).to.equal( 3 );
  508. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  509. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  510. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  511. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  512. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  513. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  514. } );
  515. it( 'should remove filler when text is added and selection removed', () => {
  516. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  517. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  518. const viewB = viewP.getChild( 1 );
  519. viewRoot._appendChild( viewP );
  520. selection._setTo( newSelection );
  521. renderer.markToSync( 'children', viewRoot );
  522. renderer.render();
  523. const domP = domRoot.childNodes[ 0 ];
  524. expect( domP.childNodes.length ).to.equal( 2 );
  525. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  526. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  527. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  528. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  529. // Step 2: Add text node.
  530. const viewText = new ViewText( 'x' );
  531. viewB._appendChild( viewText );
  532. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  533. renderer.markToSync( 'children', viewB );
  534. renderer.render();
  535. // Step 3: Remove selection from the view.
  536. selection._setTo( null );
  537. renderer.render();
  538. expect( domP.childNodes.length ).to.equal( 2 );
  539. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  540. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  541. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  542. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  543. } );
  544. // #659
  545. // The element before the filler is removed so the position of the filler
  546. // cannot be remembered as parent+offset.
  547. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  548. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  549. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  550. viewRoot._appendChild( viewP );
  551. selection._setTo( newSelection );
  552. renderer.markToSync( 'children', viewRoot );
  553. renderer.render();
  554. const domP = domRoot.childNodes[ 0 ];
  555. expect( domP.childNodes.length ).to.equal( 3 );
  556. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  557. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  558. viewP._removeChildren( 1 );
  559. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  560. renderer.markToSync( 'children', viewP );
  561. renderer.render();
  562. // Step 3: Check whether there's no filler in the DOM.
  563. expect( domP.childNodes.length ).to.equal( 1 );
  564. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  565. } );
  566. // #659
  567. it( 'should remove filler from a modified DOM when children moved', () => {
  568. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  569. const { view: viewFragment, selection: newSelection } = parse(
  570. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  571. );
  572. viewRoot._appendChild( viewFragment );
  573. selection._setTo( newSelection );
  574. renderer.markToSync( 'children', viewRoot );
  575. renderer.render();
  576. expect( domRoot.childNodes.length ).to.equal( 2 );
  577. const domP = domRoot.childNodes[ 0 ];
  578. const domP2 = domRoot.childNodes[ 1 ];
  579. expect( domP.childNodes.length ).to.equal( 3 );
  580. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  581. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  582. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  583. const viewP = viewRoot.getChild( 0 );
  584. const viewP2 = viewRoot.getChild( 1 );
  585. const removedChildren = viewP._removeChildren( 0, 2 );
  586. viewP2._appendChild( removedChildren );
  587. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  588. renderer.markToSync( 'children', viewP );
  589. renderer.markToSync( 'children', viewP2 );
  590. renderer.render();
  591. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  592. // in the second one there are two <b> tags.
  593. expect( domP.childNodes.length ).to.equal( 1 );
  594. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  595. expect( domP2.childNodes.length ).to.equal( 2 );
  596. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  597. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  598. } );
  599. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  600. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  601. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  602. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  603. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  604. viewRoot._appendChild( viewP );
  605. selection._setTo( newSelection );
  606. renderer.markToSync( 'children', viewRoot );
  607. renderer.render();
  608. const domP = domRoot.childNodes[ 0 ];
  609. expect( domP.childNodes.length ).to.equal( 2 );
  610. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  611. // Step 2: Move selection to a new attribute element and remove the previous one
  612. viewP._removeChildren( 1 ); // Remove <b>.
  613. const viewI = parse( '<attribute:i></attribute:i>' );
  614. viewP._appendChild( viewI );
  615. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  616. renderer.markToSync( 'children', viewP );
  617. renderer.render();
  618. // Step 3: Check whether new filler was created in the <i> element.
  619. expect( domP.childNodes.length ).to.equal( 2 );
  620. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  621. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  622. } );
  623. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  624. // that has not been yet rendered/bound to DOM.
  625. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  626. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  627. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  628. viewRoot._appendChild( viewP );
  629. selection._setTo( newSelection );
  630. renderer.markToSync( 'children', viewRoot );
  631. renderer.render();
  632. const domP = domRoot.childNodes[ 0 ];
  633. expect( domP.childNodes.length ).to.equal( 3 );
  634. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  635. // Step 2: Move selection to a new attribute element.
  636. const viewAbc = parse( 'abc' );
  637. viewP._appendChild( viewAbc );
  638. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  639. renderer.markToSync( 'children', viewP );
  640. renderer.render();
  641. // Step 3: Check whether old filler was removed.
  642. expect( domP.childNodes.length ).to.equal( 3 );
  643. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  644. } );
  645. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  646. const domSelection = document.getSelection();
  647. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  648. viewRoot._appendChild( viewP );
  649. selection._setTo( newSelection );
  650. renderer.markToSync( 'children', viewRoot );
  651. renderer.render();
  652. const domP = domRoot.childNodes[ 0 ];
  653. expect( domP.childNodes.length ).to.equal( 1 );
  654. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  655. expect( domSelection.rangeCount ).to.equal( 1 );
  656. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  657. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  658. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  659. // Remove filler and add text node to both DOM and View <p>x{}</p>
  660. domP.removeChild( domP.childNodes[ 0 ] );
  661. domP.appendChild( document.createTextNode( 'x' ) );
  662. domSelection.removeAllRanges();
  663. const domRange = document.createRange();
  664. domRange.setStart( domP.childNodes[ 0 ], 1 );
  665. domRange.collapse( true );
  666. domSelection.addRange( domRange );
  667. const viewText = new ViewText( 'x' );
  668. viewP._appendChild( viewText );
  669. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  670. renderer.markToSync( 'children', viewP );
  671. renderAndExpectNoChanges( renderer, domRoot );
  672. } );
  673. it( 'should handle typing in empty block, render if needed', () => {
  674. const domSelection = document.getSelection();
  675. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  676. viewRoot._appendChild( viewP );
  677. selection._setTo( newSelection );
  678. renderer.markToSync( 'children', viewRoot );
  679. renderer.render();
  680. const domP = domRoot.childNodes[ 0 ];
  681. expect( domP.childNodes.length ).to.equal( 1 );
  682. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  683. expect( domSelection.rangeCount ).to.equal( 1 );
  684. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  685. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  686. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  687. // Add text node only in View <p>x{}</p>
  688. const viewText = new ViewText( 'x' );
  689. viewP._appendChild( viewText );
  690. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  691. renderer.markToSync( 'children', viewP );
  692. renderer.render();
  693. expect( domP.childNodes.length ).to.equal( 1 );
  694. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  695. expect( domSelection.rangeCount ).to.equal( 1 );
  696. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  697. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  698. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  699. } );
  700. it( 'should handle removing last character', () => {
  701. const domSelection = document.getSelection();
  702. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  703. viewRoot._appendChild( viewP );
  704. selection._setTo( newSelection );
  705. renderer.markToSync( 'children', viewRoot );
  706. renderer.render();
  707. const domP = domRoot.childNodes[ 0 ];
  708. expect( domP.childNodes.length ).to.equal( 1 );
  709. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  710. expect( domSelection.rangeCount ).to.equal( 1 );
  711. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  712. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  713. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  714. // Remove text and add filler to both DOM and View <p>{}</p>
  715. domP.removeChild( domP.childNodes[ 0 ] );
  716. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  717. domSelection.removeAllRanges();
  718. const domRange = document.createRange();
  719. domRange.setStart( domP.childNodes[ 0 ], 0 );
  720. domRange.collapse( true );
  721. domSelection.addRange( domRange );
  722. viewP._removeChildren( 0 );
  723. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  724. renderer.markToSync( 'children', viewP );
  725. renderAndExpectNoChanges( renderer, domRoot );
  726. } );
  727. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  728. const domSelection = document.getSelection();
  729. // 1. Render <p><b>FILLER{}</b>foo</p>.
  730. const { view: viewP, selection: newSelection } = parse(
  731. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  732. viewRoot._appendChild( viewP );
  733. selection._setTo( newSelection );
  734. renderer.markToSync( 'children', viewRoot );
  735. renderer.render();
  736. // 2. Check the DOM.
  737. const domP = domRoot.childNodes[ 0 ];
  738. expect( domP.childNodes.length ).to.equal( 2 );
  739. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  740. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  741. const domB = domP.childNodes[ 0 ];
  742. const viewB = viewP.getChild( 0 );
  743. expect( domB.childNodes.length ).to.equal( 1 );
  744. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  745. expect( domSelection.rangeCount ).to.equal( 1 );
  746. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  747. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  748. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  749. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  750. domB.childNodes[ 0 ].data += 'x';
  751. domSelection.removeAllRanges();
  752. const domRange = document.createRange();
  753. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  754. domRange.collapse( true );
  755. domSelection.addRange( domRange );
  756. const viewText = new ViewText( 'x' );
  757. viewB._appendChild( viewText );
  758. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  759. renderer.markToSync( 'children', viewP );
  760. renderAndExpectNoChanges( renderer, domRoot );
  761. } );
  762. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  763. const domSelection = document.getSelection();
  764. // 1. Render <p><b>FILLER{}</b>foo</p>.
  765. const { view: viewP, selection: newSelection } = parse(
  766. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  767. viewRoot._appendChild( viewP );
  768. selection._setTo( newSelection );
  769. renderer.markToSync( 'children', viewRoot );
  770. renderer.render();
  771. // 2. Check the DOM.
  772. const domP = domRoot.childNodes[ 0 ];
  773. expect( domP.childNodes.length ).to.equal( 2 );
  774. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  775. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  776. const domB = domP.childNodes[ 0 ];
  777. const viewB = viewP.getChild( 0 );
  778. expect( domB.childNodes.length ).to.equal( 1 );
  779. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  780. expect( domSelection.rangeCount ).to.equal( 1 );
  781. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  782. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  783. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  784. domSelection.removeAllRanges();
  785. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  786. const viewText = new ViewText( 'x' );
  787. viewB._appendChild( viewText );
  788. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  789. renderer.markToSync( 'children', viewB );
  790. renderer.render();
  791. expect( domB.childNodes.length ).to.equal( 1 );
  792. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  793. expect( domSelection.rangeCount ).to.equal( 1 );
  794. // Depending on the browser selection may end up at the end of the text node or after the text node.
  795. const firstRange = domSelection.getRangeAt( 0 );
  796. const assertSelectionAtEndOfTextNode = () => {
  797. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  798. };
  799. const assertSelectionInsideTextNode = () => {
  800. expect( firstRange.startContainer ).to.equal( domB );
  801. expect( firstRange.startOffset ).to.equal( 1 );
  802. };
  803. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  804. expect( firstRange.collapsed ).to.be.true;
  805. } );
  806. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  807. const domSelection = document.getSelection();
  808. // 1. Render <p><b>FILLER{}</b>foo</p>.
  809. const { view: viewP, selection: newSelection } = parse(
  810. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  811. viewRoot._appendChild( viewP );
  812. selection._setTo( newSelection );
  813. renderer.markToSync( 'children', viewRoot );
  814. renderer.render();
  815. // 2. Check the DOM.
  816. const domP = domRoot.childNodes[ 0 ];
  817. expect( domP.childNodes.length ).to.equal( 2 );
  818. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  819. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  820. const domB = domP.childNodes[ 0 ];
  821. const viewB = viewP.getChild( 0 );
  822. expect( domB.childNodes.length ).to.equal( 1 );
  823. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  824. expect( domSelection.rangeCount ).to.equal( 1 );
  825. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  826. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  827. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  828. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  829. const viewText = new ViewText( 'x' );
  830. viewB._appendChild( viewText );
  831. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  832. renderer.markToSync( 'text', viewText );
  833. renderer.render();
  834. // 4. Check the DOM.
  835. expect( domB.childNodes.length ).to.equal( 1 );
  836. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  837. expect( domSelection.rangeCount ).to.equal( 1 );
  838. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  839. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  840. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  841. } );
  842. it( 'should handle not collapsed range', () => {
  843. const domSelection = document.getSelection();
  844. const { view: viewP, selection: newSelection } = parse(
  845. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  846. viewRoot._appendChild( viewP );
  847. selection._setTo( newSelection );
  848. renderer.markToSync( 'children', viewRoot );
  849. renderer.render();
  850. const domP = domRoot.childNodes[ 0 ];
  851. expect( domP.childNodes.length ).to.equal( 2 );
  852. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  853. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  854. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  855. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  856. expect( domSelection.rangeCount ).to.equal( 1 );
  857. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  858. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  859. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  860. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  861. renderer.markToSync( 'children', viewP );
  862. renderAndExpectNoChanges( renderer, domRoot );
  863. } );
  864. it( 'should not change selection if there is no editable with selection', () => {
  865. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  866. document.body.appendChild( domDiv );
  867. domDiv.focus();
  868. const domSelection = document.getSelection();
  869. domSelection.removeAllRanges();
  870. domSelection.collapse( domDiv, 0 );
  871. selectionEditable = null;
  872. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  873. viewRoot._appendChild( viewP );
  874. selection._setTo( newSelection );
  875. renderer.render();
  876. expect( domSelection.rangeCount ).to.equal( 1 );
  877. // Depending on the browser selection may end up before the text node or at the beginning of it.
  878. const domRange = domSelection.getRangeAt( 0 );
  879. const assertSelectionAtEndOfTextNode = () => {
  880. expect( domRange.startContainer ).to.equal( domDiv );
  881. };
  882. const assertSelectionInsideTextNode = () => {
  883. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  884. };
  885. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  886. expect( domRange.startOffset ).to.equal( 0 );
  887. expect( domRange.collapsed ).to.be.true;
  888. domDiv.remove();
  889. } );
  890. it( 'should not change selection if there is no focus', () => {
  891. const domDiv = createElement( document, 'div', null, 'not editable' );
  892. document.body.appendChild( domDiv );
  893. const domSelection = document.getSelection();
  894. domSelection.removeAllRanges();
  895. const domRange = document.createRange();
  896. domRange.setStart( domDiv, 0 );
  897. domRange.collapse( true );
  898. domSelection.addRange( domRange );
  899. renderer.isFocused = false;
  900. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  901. viewRoot._appendChild( viewP );
  902. selection._setTo( newSelection );
  903. renderer.render();
  904. expect( domSelection.rangeCount ).to.equal( 1 );
  905. // Depending on the browser selection may end up before the text node or at the beginning of it.
  906. const domSelectionRange = domSelection.getRangeAt( 0 );
  907. const assertSelectionAtEndOfTextNode = () => {
  908. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  909. };
  910. const assertSelectionInsideTextNode = () => {
  911. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  912. };
  913. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  914. expect( domSelectionRange.startOffset ).to.equal( 0 );
  915. expect( domSelectionRange.collapsed ).to.be.true;
  916. domDiv.remove();
  917. } );
  918. it( 'should not add inline filler after text node', () => {
  919. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  920. viewRoot._appendChild( viewP );
  921. selection._setTo( newSelection );
  922. renderer.markToSync( 'children', viewRoot );
  923. renderer.render();
  924. const domP = domRoot.childNodes[ 0 ];
  925. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  926. } );
  927. it( 'should throw if there is no filler in expected position', () => {
  928. const { view: viewP, selection: newSelection } = parse(
  929. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  930. viewRoot._appendChild( viewP );
  931. selection._setTo( newSelection );
  932. renderer.markToSync( 'children', viewRoot );
  933. renderer.render();
  934. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  935. const viewB = viewP.getChild( 1 );
  936. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  937. // Remove filler.
  938. domB.childNodes[ 0 ].data = '';
  939. selection._setTo( null );
  940. renderer.markToSync( 'children', viewB );
  941. expect( () => {
  942. renderer.render();
  943. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  944. } );
  945. // #1014.
  946. it( 'should create inline filler in newly created dom nodes', () => {
  947. // 1. Create the view structure which needs inline filler.
  948. const inputView =
  949. '<container:ul>' +
  950. '<container:li>Foobar.</container:li>' +
  951. '<container:li>[]<container:div></container:div></container:li>' +
  952. '</container:ul>';
  953. const { view: view, selection: newSelection } = parse( inputView );
  954. viewRoot._appendChild( view );
  955. selection._setTo( newSelection );
  956. renderer.markToSync( 'children', viewRoot );
  957. renderer.render();
  958. // 2. Check if filler element has been (correctly) created.
  959. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  960. // 3. Move the inline filler parent to a newly created element.
  961. const viewLi = view.getChild( 0 );
  962. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  963. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  964. viewLi._appendChild( viewUl );
  965. // 4. Mark changed items and render the view.
  966. renderer.markToSync( 'children', view );
  967. renderer.markToSync( 'children', viewLi );
  968. renderer.render();
  969. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  970. const domSelection = document.getSelection();
  971. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  972. } );
  973. it( 'should handle focusing element', () => {
  974. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  975. const editable = selection.editableElement;
  976. renderer.render();
  977. expect( editable ).to.equal( viewRoot );
  978. expect( domFocusSpy.calledOnce ).to.be.true;
  979. } );
  980. it( 'should not focus editable if isFocues is set to false', () => {
  981. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  982. renderer.isFocused = false;
  983. renderer.render();
  984. expect( domFocusSpy.calledOnce ).to.be.false;
  985. } );
  986. it( 'should not focus already focused DOM element', () => {
  987. domRoot.setAttribute( 'contentEditable', true );
  988. domRoot.focus();
  989. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  990. renderer.render();
  991. expect( domFocusSpy.called ).to.be.false;
  992. } );
  993. it( 'should render NBSP as first space in inline element after another space', () => {
  994. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  995. viewRoot._appendChild( viewP );
  996. renderer.markToSync( 'children', viewRoot );
  997. renderer.render();
  998. const domP = domRoot.childNodes[ 0 ];
  999. const domB = domP.childNodes[ 1 ];
  1000. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1001. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1002. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1003. // Insert space resulting in '<p>x <b> y</b></p>'.
  1004. const viewB = viewP.getChild( 1 );
  1005. viewB._removeChildren( 0 );
  1006. viewB._appendChild( new ViewText( ' y' ) );
  1007. renderer.markToSync( 'children', viewP );
  1008. renderer.render();
  1009. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1010. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1011. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1012. } );
  1013. it( 'should update sibling after, when node before is removed', () => {
  1014. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1015. viewRoot._appendChild( viewP );
  1016. renderer.markToSync( 'children', viewRoot );
  1017. renderer.render();
  1018. const domP = domRoot.childNodes[ 0 ];
  1019. const domB = domP.childNodes[ 1 ];
  1020. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1021. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1022. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1023. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1024. viewP._removeChildren( 0 );
  1025. renderer.markToSync( 'children', viewP );
  1026. renderer.render();
  1027. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1028. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1029. } );
  1030. it( 'should update sibling before, when node after is removed', () => {
  1031. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1032. viewRoot._appendChild( viewP );
  1033. renderer.markToSync( 'children', viewRoot );
  1034. renderer.render();
  1035. const domP = domRoot.childNodes[ 0 ];
  1036. const domB = domP.childNodes[ 1 ];
  1037. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1038. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1039. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1040. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1041. viewP._removeChildren( 1 );
  1042. renderer.markToSync( 'children', viewP );
  1043. renderer.render();
  1044. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1045. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1046. } );
  1047. // #1093
  1048. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1049. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1050. viewRoot._appendChild( viewP );
  1051. renderer.markToSync( 'children', viewRoot );
  1052. renderer.render();
  1053. const domP = domRoot.childNodes[ 0 ];
  1054. const domB = domP.childNodes[ 1 ];
  1055. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1056. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1057. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1058. // Insert space resulting in '<p>x <b> y</b></p>'.
  1059. viewP._removeChildren( 0 );
  1060. viewP._insertChild( 0, new ViewText( 'x ' ) );
  1061. renderer.markToSync( 'children', viewP );
  1062. renderer.render();
  1063. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1064. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1065. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1066. } );
  1067. // #1093
  1068. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1069. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1070. viewRoot._appendChild( viewP );
  1071. renderer.markToSync( 'children', viewRoot );
  1072. renderer.render();
  1073. const domP = domRoot.childNodes[ 0 ];
  1074. const domB = domP.childNodes[ 0 ];
  1075. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1076. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1077. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1078. // Insert space resulting in '<p><b>x </b> y</p>'.
  1079. const viewB = viewP.getChild( 0 );
  1080. viewB._removeChildren( 0 );
  1081. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1082. renderer.markToSync( 'children', viewP );
  1083. renderer.render();
  1084. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1085. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1086. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1087. } );
  1088. // #1093
  1089. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1090. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1091. viewRoot._appendChild( viewP );
  1092. renderer.markToSync( 'children', viewRoot );
  1093. renderer.render();
  1094. const domP = domRoot.childNodes[ 0 ];
  1095. const domB = domP.childNodes[ 0 ];
  1096. const domI = domP.childNodes[ 1 ];
  1097. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1098. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1099. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1100. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1101. const viewB = viewP.getChild( 0 );
  1102. viewB._removeChildren( 0 );
  1103. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1104. renderer.markToSync( 'children', viewP );
  1105. renderer.render();
  1106. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1107. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1108. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1109. } );
  1110. // #1125
  1111. it( 'should properly rerender many changes done in one batch', () => {
  1112. // This test transforms:
  1113. //
  1114. // <h2>He<strong>ding 1</strong></h2>
  1115. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1116. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1117. //
  1118. // into:
  1119. //
  1120. // <h2>Heading 2</h2>
  1121. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1122. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1123. //
  1124. // during one rerender to check if complex structure changes are rerendered correctly.
  1125. const viewContent = parse( '' +
  1126. '<container:h2>He' +
  1127. '<attribute:i>ading 1</attribute:i>' +
  1128. '</container:h2>' +
  1129. '<container:p>Ph ' +
  1130. '<attribute:strong>Bold</attribute:strong> ' +
  1131. '<attribute:i>It' +
  1132. '<attribute:strong>alic</attribute:strong>' +
  1133. '</attribute:i> ' +
  1134. '<attribute:a href="https://ckeditor.com">' +
  1135. '<attribute:strong>Lin</attribute:strong>' +
  1136. 'k</attribute:a>' +
  1137. '</container:p>' +
  1138. '<container:blockquote>' +
  1139. '<container:ul>' +
  1140. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1141. '</container:ul>' +
  1142. '</container:blockquote>' );
  1143. viewRoot._appendChild( viewContent );
  1144. renderer.markToSync( 'children', viewRoot );
  1145. renderer.render();
  1146. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1147. const viewHeading = viewRoot.getChild( 0 );
  1148. viewHeading._removeChildren( 0, viewHeading.childCount );
  1149. viewHeading._insertChild( 0, new ViewText( 'Heading 2' ) );
  1150. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1151. renderer.markToSync( 'children', viewRoot );
  1152. renderer.markToSync( 'children', viewHeading );
  1153. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1154. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1155. // ->
  1156. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1157. const viewP = viewRoot.getChild( 1 );
  1158. viewP._removeChildren( 0, viewP.childCount );
  1159. viewP._insertChild(
  1160. 0,
  1161. parse(
  1162. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1163. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1164. )
  1165. );
  1166. renderer.markToSync( 'children', viewRoot );
  1167. renderer.markToSync( 'children', viewP );
  1168. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1169. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1170. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1171. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1172. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1173. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1174. const viewBq = viewRoot.getChild( 2 );
  1175. viewBq._removeChildren( 0, viewBq.childCount );
  1176. viewBq._insertChild(
  1177. 0,
  1178. parse(
  1179. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1180. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1181. )
  1182. );
  1183. renderer.markToSync( 'children', viewRoot );
  1184. renderer.markToSync( 'children', viewBq );
  1185. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1186. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1187. renderer.render();
  1188. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1189. '<h2>Heading 2</h2>' +
  1190. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1191. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1192. );
  1193. } );
  1194. // #1125
  1195. it( 'should properly rerender changes when whole content replaced at once', () => {
  1196. // This test replaces:
  1197. //
  1198. // <h1>Header</h1>
  1199. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1200. //
  1201. // with:
  1202. //
  1203. // <h2>Header</h2>
  1204. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1205. //
  1206. // during one rerender to check if complex structure changes are rerendered correctly.
  1207. const viewContent = parse(
  1208. '<container:h1>Header</container:h1>' +
  1209. '<container:blockquote>' +
  1210. '<container:ul>' +
  1211. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1212. '<container:li>Item 2</container:li>' +
  1213. '</container:ul>' +
  1214. '</container:blockquote>'
  1215. );
  1216. viewRoot._appendChild( viewContent );
  1217. renderer.markToSync( 'children', viewRoot );
  1218. renderer.render();
  1219. const newViewContent = parse(
  1220. '<container:h2>Header</container:h2>' +
  1221. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1222. );
  1223. viewRoot._removeChildren( 0, viewRoot.childCount );
  1224. viewRoot._appendChild( newViewContent );
  1225. renderer.markToSync( 'children', viewRoot );
  1226. renderer.render();
  1227. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1228. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1229. );
  1230. } );
  1231. // #1451
  1232. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1233. const inputView =
  1234. '<container:ul>' +
  1235. '<container:li>Foo</container:li>' +
  1236. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1237. '</container:ul>';
  1238. const view = parse( inputView );
  1239. viewRoot._appendChild( view );
  1240. renderer.markToSync( 'children', viewRoot );
  1241. renderer.render();
  1242. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1243. const viewLi = view.getChild( 0 );
  1244. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1245. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1246. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  1247. viewLi._appendChild( viewUl );
  1248. renderer.markToSync( 'children', view );
  1249. renderer.markToSync( 'children', viewLi );
  1250. renderer.render();
  1251. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1252. } );
  1253. describe( 'fake selection', () => {
  1254. beforeEach( () => {
  1255. const { view: viewP, selection: newSelection } = parse(
  1256. '<container:p>[foo bar]</container:p>'
  1257. );
  1258. viewRoot._appendChild( viewP );
  1259. selection._setTo( newSelection );
  1260. renderer.markToSync( 'children', viewRoot );
  1261. renderer.render();
  1262. } );
  1263. it( 'should render fake selection', () => {
  1264. const label = 'fake selection label';
  1265. selection._setTo( selection.getRanges(), { fake: true, label } );
  1266. renderer.render();
  1267. expect( domRoot.childNodes.length ).to.equal( 2 );
  1268. const container = domRoot.childNodes[ 1 ];
  1269. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1270. expect( container.childNodes.length ).to.equal( 1 );
  1271. const textNode = container.childNodes[ 0 ];
  1272. expect( textNode.textContent ).to.equal( label );
  1273. const domSelection = domRoot.ownerDocument.getSelection();
  1274. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1275. } );
  1276. it( 'should render &nbsp; if no selection label is provided', () => {
  1277. selection._setTo( selection.getRanges(), { fake: true } );
  1278. renderer.render();
  1279. expect( domRoot.childNodes.length ).to.equal( 2 );
  1280. const container = domRoot.childNodes[ 1 ];
  1281. expect( container.childNodes.length ).to.equal( 1 );
  1282. const textNode = container.childNodes[ 0 ];
  1283. expect( textNode.textContent ).to.equal( '\u00A0' );
  1284. const domSelection = domRoot.ownerDocument.getSelection();
  1285. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1286. } );
  1287. it( 'should remove fake selection container when selection is no longer fake', () => {
  1288. selection._setTo( selection.getRanges(), { fake: true } );
  1289. renderer.render();
  1290. selection._setTo( selection.getRanges(), { fake: false } );
  1291. renderer.render();
  1292. expect( domRoot.childNodes.length ).to.equal( 1 );
  1293. const domParagraph = domRoot.childNodes[ 0 ];
  1294. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1295. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1296. const domSelection = domRoot.ownerDocument.getSelection();
  1297. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1298. } );
  1299. it( 'should reuse fake selection container #1', () => {
  1300. const label = 'fake selection label';
  1301. selection._setTo( selection.getRanges(), { fake: true, label } );
  1302. renderer.render();
  1303. expect( domRoot.childNodes.length ).to.equal( 2 );
  1304. const container = domRoot.childNodes[ 1 ];
  1305. selection._setTo( selection.getRanges(), { fake: true, label } );
  1306. renderer.render();
  1307. expect( domRoot.childNodes.length ).to.equal( 2 );
  1308. const newContainer = domRoot.childNodes[ 1 ];
  1309. expect( newContainer ).equals( container );
  1310. expect( newContainer.childNodes.length ).to.equal( 1 );
  1311. const textNode = newContainer.childNodes[ 0 ];
  1312. expect( textNode.textContent ).to.equal( label );
  1313. } );
  1314. it( 'should reuse fake selection container #2', () => {
  1315. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1316. renderer.render();
  1317. expect( domRoot.childNodes.length ).to.equal( 2 );
  1318. const container = domRoot.childNodes[ 1 ];
  1319. selection._setTo( selection.getRanges(), { fake: false } );
  1320. renderer.render();
  1321. expect( domRoot.childNodes.length ).to.equal( 1 );
  1322. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1323. renderer.render();
  1324. expect( domRoot.childNodes.length ).to.equal( 2 );
  1325. const newContainer = domRoot.childNodes[ 1 ];
  1326. expect( newContainer ).equals( container );
  1327. expect( newContainer.childNodes.length ).to.equal( 1 );
  1328. const textNode = newContainer.childNodes[ 0 ];
  1329. expect( textNode.textContent ).to.equal( 'label 2' );
  1330. } );
  1331. it( 'should reuse fake selection container #3', () => {
  1332. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1333. renderer.render();
  1334. expect( domRoot.childNodes.length ).to.equal( 2 );
  1335. const container = domRoot.childNodes[ 1 ];
  1336. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1337. renderer.render();
  1338. expect( domRoot.childNodes.length ).to.equal( 2 );
  1339. const newContainer = domRoot.childNodes[ 1 ];
  1340. expect( newContainer ).equals( container );
  1341. expect( newContainer.childNodes.length ).to.equal( 1 );
  1342. const textNode = newContainer.childNodes[ 0 ];
  1343. expect( textNode.textContent ).to.equal( 'label 2' );
  1344. } );
  1345. it( 'should style fake selection container properly', () => {
  1346. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1347. renderer.render();
  1348. expect( domRoot.childNodes.length ).to.equal( 2 );
  1349. const container = domRoot.childNodes[ 1 ];
  1350. expect( container.style.position ).to.equal( 'fixed' );
  1351. expect( container.style.top ).to.equal( '0px' );
  1352. expect( container.style.left ).to.equal( '-9999px' );
  1353. } );
  1354. it( 'should bind fake selection container to view selection', () => {
  1355. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1356. renderer.render();
  1357. expect( domRoot.childNodes.length ).to.equal( 2 );
  1358. const container = domRoot.childNodes[ 1 ];
  1359. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1360. expect( bindSelection ).to.not.be.undefined;
  1361. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1362. } );
  1363. // Use a forgiving way of checking what the selection contains
  1364. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1365. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1366. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1367. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1368. expect( domSelection.toString() ).to.match( expectedText );
  1369. expect(
  1370. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1371. ).to.be.true;
  1372. }
  1373. } );
  1374. // #887
  1375. describe( 'similar selection', () => {
  1376. // Use spies to check selection updates. Some selection positions are not achievable in some
  1377. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1378. let selectionCollapseSpy, selectionExtendSpy;
  1379. afterEach( () => {
  1380. if ( selectionCollapseSpy ) {
  1381. selectionCollapseSpy.restore();
  1382. selectionCollapseSpy = null;
  1383. }
  1384. if ( selectionExtendSpy ) {
  1385. selectionExtendSpy.restore();
  1386. selectionExtendSpy = null;
  1387. }
  1388. } );
  1389. it( 'should always render collapsed selection even if it is similar', () => {
  1390. const domSelection = document.getSelection();
  1391. const { view: viewP, selection: newSelection } = parse(
  1392. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1393. viewRoot._appendChild( viewP );
  1394. selection._setTo( newSelection );
  1395. renderer.markToSync( 'children', viewRoot );
  1396. renderer.render();
  1397. const domP = domRoot.childNodes[ 0 ];
  1398. const domB = domP.childNodes[ 1 ];
  1399. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1400. expect( domSelection.isCollapsed ).to.true;
  1401. expect( domSelection.rangeCount ).to.equal( 1 );
  1402. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1403. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1404. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1405. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1406. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1407. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1408. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1409. selection._setTo( [
  1410. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1411. ] );
  1412. renderer.markToSync( 'children', viewP );
  1413. renderer.render();
  1414. expect( selectionCollapseSpy.calledOnce ).to.true;
  1415. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1416. expect( selectionExtendSpy.calledOnce ).to.true;
  1417. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1418. } );
  1419. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1420. const domSelection = document.getSelection();
  1421. const { view: viewP, selection: newSelection } = parse(
  1422. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1423. viewRoot._appendChild( viewP );
  1424. selection._setTo( newSelection );
  1425. renderer.markToSync( 'children', viewRoot );
  1426. renderer.render();
  1427. const domP = domRoot.childNodes[ 0 ];
  1428. const domB = domP.childNodes[ 1 ];
  1429. expect( domSelection.isCollapsed ).to.true;
  1430. expect( domSelection.rangeCount ).to.equal( 1 );
  1431. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1432. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1433. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1434. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1435. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1436. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1437. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1438. selection._setTo( [
  1439. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1440. ] );
  1441. renderer.markToSync( 'children', viewP );
  1442. renderer.render();
  1443. expect( selectionCollapseSpy.calledOnce ).to.true;
  1444. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1445. expect( selectionExtendSpy.calledOnce ).to.true;
  1446. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1447. } );
  1448. it( 'should always render non-collapsed selection if it not is similar', () => {
  1449. const domSelection = document.getSelection();
  1450. const { view: viewP, selection: newSelection } = parse(
  1451. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1452. viewRoot._appendChild( viewP );
  1453. selection._setTo( newSelection );
  1454. renderer.markToSync( 'children', viewRoot );
  1455. renderer.render();
  1456. const domP = domRoot.childNodes[ 0 ];
  1457. const domB = domP.childNodes[ 1 ];
  1458. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1459. expect( domSelection.isCollapsed ).to.false;
  1460. expect( domSelection.rangeCount ).to.equal( 1 );
  1461. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1462. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1463. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1464. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1465. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1466. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1467. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1468. selection._setTo( [
  1469. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1470. ] );
  1471. renderer.markToSync( 'children', viewP );
  1472. renderer.render();
  1473. expect( selectionCollapseSpy.calledOnce ).to.true;
  1474. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1475. expect( selectionExtendSpy.calledOnce ).to.true;
  1476. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1477. } );
  1478. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1479. const domSelection = document.getSelection();
  1480. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1481. viewRoot._appendChild( viewP );
  1482. selection._setTo( newSelection );
  1483. renderer.markToSync( 'children', viewRoot );
  1484. renderer.render();
  1485. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1486. // Do not change view selection.
  1487. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1488. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1489. // because DOM selection is in incorrect place.
  1490. const domP = domRoot.childNodes[ 0 ];
  1491. const domSpan = domP.childNodes[ 1 ];
  1492. domSelection.collapse( domSpan, 0 );
  1493. renderer.render();
  1494. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1495. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1496. const assertSelectionAtEndOfTextNode = () => {
  1497. expect( domSelection.anchorNode ).to.equal( domP );
  1498. expect( domSelection.anchorOffset ).to.equal( 1 );
  1499. };
  1500. const assertSelectionInsideTextNode = () => {
  1501. const textNode = domP.childNodes[ 0 ];
  1502. expect( domSelection.anchorNode ).to.equal( textNode );
  1503. expect( domSelection.anchorOffset ).to.equal( 3 );
  1504. };
  1505. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1506. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1507. } );
  1508. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1509. const domSelection = document.getSelection();
  1510. const { view: viewP, selection: newSelection } = parse(
  1511. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1512. viewRoot._appendChild( viewP );
  1513. selection._setTo( newSelection );
  1514. renderer.markToSync( 'children', viewRoot );
  1515. renderer.render();
  1516. const domP = domRoot.childNodes[ 0 ];
  1517. const domB = domP.childNodes[ 1 ];
  1518. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1519. expect( domSelection.isCollapsed ).to.false;
  1520. expect( domSelection.rangeCount ).to.equal( 1 );
  1521. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1522. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1523. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1524. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1525. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1526. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1527. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1528. selection._setTo( [
  1529. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1530. ] );
  1531. renderer.markToSync( 'children', viewP );
  1532. renderer.render();
  1533. expect( selectionCollapseSpy.notCalled ).to.true;
  1534. expect( selectionExtendSpy.notCalled ).to.true;
  1535. } );
  1536. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1537. const domSelection = document.getSelection();
  1538. const { view: viewP, selection: newSelection } = parse(
  1539. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1540. viewRoot._appendChild( viewP );
  1541. selection._setTo( newSelection );
  1542. renderer.markToSync( 'children', viewRoot );
  1543. renderer.render();
  1544. const domP = domRoot.childNodes[ 0 ];
  1545. const domB = domP.childNodes[ 1 ];
  1546. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1547. expect( domSelection.isCollapsed ).to.false;
  1548. expect( domSelection.rangeCount ).to.equal( 1 );
  1549. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1550. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1551. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1552. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1553. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1554. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1555. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1556. selection._setTo( [
  1557. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1558. ] );
  1559. renderer.markToSync( 'children', viewP );
  1560. renderer.render();
  1561. expect( selectionCollapseSpy.notCalled ).to.true;
  1562. expect( selectionExtendSpy.notCalled ).to.true;
  1563. } );
  1564. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1565. const domSelection = document.getSelection();
  1566. const { view: viewP, selection: newSelection } = parse(
  1567. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1568. viewRoot._appendChild( viewP );
  1569. selection._setTo( newSelection );
  1570. renderer.markToSync( 'children', viewRoot );
  1571. renderer.render();
  1572. const domP = domRoot.childNodes[ 0 ];
  1573. const domB = domP.childNodes[ 1 ];
  1574. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1575. expect( domSelection.isCollapsed ).to.false;
  1576. expect( domSelection.rangeCount ).to.equal( 1 );
  1577. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1578. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1579. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1580. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1581. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1582. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1583. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1584. selection._setTo( [
  1585. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1586. ] );
  1587. renderer.markToSync( 'children', viewP );
  1588. renderer.render();
  1589. expect( selectionCollapseSpy.notCalled ).to.true;
  1590. expect( selectionExtendSpy.notCalled ).to.true;
  1591. } );
  1592. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1593. const domSelection = document.getSelection();
  1594. const { view: viewP, selection: newSelection } = parse(
  1595. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1596. viewRoot._appendChild( viewP );
  1597. selection._setTo( newSelection );
  1598. renderer.markToSync( 'children', viewRoot );
  1599. renderer.render();
  1600. const domP = domRoot.childNodes[ 0 ];
  1601. const domB = domP.childNodes[ 1 ];
  1602. expect( domSelection.isCollapsed ).to.false;
  1603. expect( domSelection.rangeCount ).to.equal( 1 );
  1604. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1605. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1606. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1607. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1608. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1609. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1610. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1611. selection._setTo( [
  1612. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1613. ] );
  1614. renderer.markToSync( 'children', viewP );
  1615. renderer.render();
  1616. expect( selectionCollapseSpy.notCalled ).to.true;
  1617. expect( selectionExtendSpy.notCalled ).to.true;
  1618. } );
  1619. } );
  1620. // #1417
  1621. describe( 'optimal rendering', () => {
  1622. it( 'should render inline element replacement (before text)', () => {
  1623. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1624. renderer.markToSync( 'children', viewRoot );
  1625. renderer.render();
  1626. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1627. const viewP = viewRoot.getChild( 0 );
  1628. viewP._removeChildren( 0, 2 );
  1629. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1630. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1631. renderer.markToSync( 'children', viewRoot );
  1632. renderer.markToSync( 'children', viewP );
  1633. renderer.render();
  1634. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1635. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1636. } );
  1637. it( 'should render inline element replacement (after text)', () => {
  1638. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1639. renderer.markToSync( 'children', viewRoot );
  1640. renderer.render();
  1641. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1642. const viewP = viewRoot.getChild( 0 );
  1643. viewP._removeChildren( 0, 2 );
  1644. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1645. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1646. renderer.markToSync( 'children', viewRoot );
  1647. renderer.markToSync( 'children', viewP );
  1648. renderer.render();
  1649. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1650. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1651. } );
  1652. it( 'should render inline element replacement (before text swapped order)', () => {
  1653. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1654. renderer.markToSync( 'children', viewRoot );
  1655. renderer.render();
  1656. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1657. const viewP = viewRoot.getChild( 0 );
  1658. viewP._removeChildren( 0, 2 );
  1659. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1660. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1661. renderer.markToSync( 'children', viewRoot );
  1662. renderer.markToSync( 'children', viewP );
  1663. renderer.render();
  1664. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1665. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1666. } );
  1667. it( 'should render inline element replacement (after text swapped order)', () => {
  1668. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1669. renderer.markToSync( 'children', viewRoot );
  1670. renderer.render();
  1671. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1672. const viewP = viewRoot.getChild( 0 );
  1673. viewP._removeChildren( 0, 2 );
  1674. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1675. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1676. renderer.markToSync( 'children', viewRoot );
  1677. renderer.markToSync( 'children', viewP );
  1678. renderer.render();
  1679. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1680. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1681. } );
  1682. it( 'should render single replacement in p group', () => {
  1683. const content = '' +
  1684. '<container:p>1</container:p>' +
  1685. '<container:p>2</container:p>' +
  1686. '<container:p>3</container:p>';
  1687. viewRoot._appendChild( parse( content ) );
  1688. renderer.markToSync( 'children', viewRoot );
  1689. renderer.render();
  1690. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1691. viewRoot._removeChildren( 1 );
  1692. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1693. const domP = domRoot.childNodes[ 1 ];
  1694. renderer.markToSync( 'children', viewRoot );
  1695. renderer.render();
  1696. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1697. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1698. } );
  1699. it( 'should render replacement and insertion in p group', () => {
  1700. const content = '' +
  1701. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1702. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1703. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1704. const replacement = '' +
  1705. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1706. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1707. viewRoot._appendChild( parse( content ) );
  1708. renderer.markToSync( 'children', viewRoot );
  1709. renderer.render();
  1710. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1711. viewRoot._removeChildren( 1 );
  1712. viewRoot._insertChild( 1, parse( replacement ) );
  1713. const domP2 = domRoot.childNodes[ 1 ];
  1714. const domP3 = domRoot.childNodes[ 2 ];
  1715. renderer.markToSync( 'children', viewRoot );
  1716. renderer.render();
  1717. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1718. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1719. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1720. } );
  1721. it( 'should render replacement and deletion in p group', () => {
  1722. const content = '' +
  1723. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1724. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1725. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1726. viewRoot._appendChild( parse( content ) );
  1727. renderer.markToSync( 'children', viewRoot );
  1728. renderer.render();
  1729. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1730. viewRoot._removeChildren( 0, 2 );
  1731. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1732. const domP0 = domRoot.childNodes[ 0 ];
  1733. const domP2 = domRoot.childNodes[ 2 ];
  1734. renderer.markToSync( 'children', viewRoot );
  1735. renderer.render();
  1736. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1737. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1738. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1739. } );
  1740. it( 'should render multiple continuous replacement in p group', () => {
  1741. const content = '' +
  1742. '<container:p>1</container:p>' +
  1743. '<container:p>2</container:p>' +
  1744. '<container:p>3</container:p>' +
  1745. '<container:p>4</container:p>' +
  1746. '<container:p>5</container:p>';
  1747. viewRoot._appendChild( parse( content ) );
  1748. renderer.markToSync( 'children', viewRoot );
  1749. renderer.render();
  1750. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1751. viewRoot._removeChildren( 0, 3 );
  1752. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1753. const domP1 = domRoot.childNodes[ 0 ];
  1754. const domP2 = domRoot.childNodes[ 1 ];
  1755. const domP4 = domRoot.childNodes[ 3 ];
  1756. const domP5 = domRoot.childNodes[ 4 ];
  1757. renderer.markToSync( 'children', viewRoot );
  1758. renderer.render();
  1759. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1760. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1761. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1762. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1763. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1764. } );
  1765. it( 'should render multiple replacement in p group', () => {
  1766. const content = '' +
  1767. '<container:p>1</container:p>' +
  1768. '<container:p>2</container:p>' +
  1769. '<container:p>3</container:p>' +
  1770. '<container:p>4</container:p>' +
  1771. '<container:p>5</container:p>';
  1772. viewRoot._appendChild( parse( content ) );
  1773. renderer.markToSync( 'children', viewRoot );
  1774. renderer.render();
  1775. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1776. viewRoot._removeChildren( 4 );
  1777. viewRoot._removeChildren( 1, 2 );
  1778. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1779. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1780. const domP1 = domRoot.childNodes[ 0 ];
  1781. const domP2 = domRoot.childNodes[ 1 ];
  1782. const domP4 = domRoot.childNodes[ 3 ];
  1783. const domP5 = domRoot.childNodes[ 4 ];
  1784. renderer.markToSync( 'children', viewRoot );
  1785. renderer.render();
  1786. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1787. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1788. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1789. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1790. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1791. } );
  1792. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1793. const content = '' +
  1794. '<container:h2>He' +
  1795. '<attribute:i>ading 1</attribute:i>' +
  1796. '</container:h2>' +
  1797. '<container:p>Ph ' +
  1798. '<attribute:strong>Bold</attribute:strong>' +
  1799. '<attribute:a href="https://ckeditor.com">' +
  1800. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1801. '</attribute:a>' +
  1802. '</container:p>' +
  1803. '<container:blockquote>' +
  1804. '<container:ul>' +
  1805. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1806. '</container:ul>' +
  1807. '</container:blockquote>';
  1808. viewRoot._appendChild( parse( content ) );
  1809. renderer.markToSync( 'children', viewRoot );
  1810. renderer.render();
  1811. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1812. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1813. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1814. viewRoot._removeChildren( 0, viewRoot.childCount );
  1815. viewRoot._appendChild( parse( content ) );
  1816. const viewH = viewRoot.getChild( 0 );
  1817. const viewP = viewRoot.getChild( 1 );
  1818. const viewQ = viewRoot.getChild( 2 );
  1819. const domH = domRoot.childNodes[ 0 ];
  1820. const domHI = domH.childNodes[ 1 ];
  1821. const domP = domRoot.childNodes[ 1 ];
  1822. const domPT = domP.childNodes[ 0 ];
  1823. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1824. const domQ = domRoot.childNodes[ 2 ];
  1825. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1826. renderer.markToSync( 'children', viewRoot );
  1827. renderer.render();
  1828. // Assert content.
  1829. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1830. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1831. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1832. // Assert if DOM elements did not change.
  1833. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1834. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1835. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1836. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1837. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1838. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1839. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1840. // Assert mappings.
  1841. const mappings = renderer.domConverter._domToViewMapping;
  1842. expect( mappings.get( domH ) ).to.equal( viewH );
  1843. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1844. expect( mappings.get( domP ) ).to.equal( viewP );
  1845. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1846. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1847. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1848. } );
  1849. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1850. const content = '' +
  1851. '<container:h2>He' +
  1852. '<attribute:i>ading 1</attribute:i>' +
  1853. '</container:h2>' +
  1854. '<container:p>Ph ' +
  1855. '<attribute:strong>Bold</attribute:strong>' +
  1856. '<attribute:a href="https://ckeditor.com">' +
  1857. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1858. '</attribute:a>' +
  1859. '</container:p>' +
  1860. '<container:blockquote>' +
  1861. '<container:ul>' +
  1862. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1863. '</container:ul>' +
  1864. '</container:blockquote>';
  1865. const content2 = '' +
  1866. '<container:p>Ph ' +
  1867. '<attribute:strong>Bold</attribute:strong>' +
  1868. '<attribute:a href="https://ckeditor.com">' +
  1869. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1870. '</attribute:a>' +
  1871. '</container:p>' +
  1872. '<container:blockquote>' +
  1873. '<container:ul>' +
  1874. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1875. '</container:ul>' +
  1876. '</container:blockquote>';
  1877. viewRoot._appendChild( parse( content ) );
  1878. renderer.markToSync( 'children', viewRoot );
  1879. renderer.render();
  1880. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1881. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1882. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1883. viewRoot._removeChildren( 0, viewRoot.childCount );
  1884. viewRoot._appendChild( parse( content2 ) );
  1885. const viewP = viewRoot.getChild( 0 );
  1886. const viewQ = viewRoot.getChild( 1 );
  1887. const domP = domRoot.childNodes[ 1 ];
  1888. const domPT = domP.childNodes[ 0 ];
  1889. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1890. const domQ = domRoot.childNodes[ 2 ];
  1891. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1892. renderer.markToSync( 'children', viewRoot );
  1893. renderer.render();
  1894. // Assert content.
  1895. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  1896. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1897. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1898. // Assert if DOM elements did not change.
  1899. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1900. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1901. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1902. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  1903. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1904. // Assert mappings.
  1905. const mappings = renderer.domConverter._domToViewMapping;
  1906. expect( mappings.get( domP ) ).to.equal( viewP );
  1907. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1908. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1909. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1910. } );
  1911. it( 'should not rerender DOM when typing inside empty inline element', () => {
  1912. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  1913. viewRoot._appendChild( view );
  1914. renderer.markToSync( 'children', viewRoot );
  1915. renderer.render();
  1916. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  1917. const viewP = viewRoot.getChild( 0 );
  1918. viewP._removeChildren( 1 );
  1919. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  1920. const domP = domRoot.childNodes[ 0 ];
  1921. const domText = domP.childNodes[ 0 ];
  1922. const domB = domP.childNodes[ 1 ];
  1923. domB.innerHTML = 'a';
  1924. renderer.markToSync( 'children', viewRoot );
  1925. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  1926. renderer.render();
  1927. // Assert content.
  1928. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  1929. // Assert if DOM elements did not change.
  1930. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1931. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  1932. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  1933. // Assert mappings.
  1934. const mappings = renderer.domConverter._domToViewMapping;
  1935. expect( mappings.get( domP ) ).to.equal( viewP );
  1936. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  1937. } );
  1938. it( 'should handle complex view duplication', () => {
  1939. const content = '' +
  1940. '<container:blockquote>' +
  1941. '<container:ul>' +
  1942. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1943. '<container:li>Item 2</container:li>' +
  1944. '<container:li>' +
  1945. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  1946. '</container:li>' +
  1947. '</container:ul>' +
  1948. '</container:blockquote>';
  1949. const expected = '' +
  1950. '<blockquote>' +
  1951. '<ul>' +
  1952. '<li>Quoted <strong>item 1</strong></li>' +
  1953. '<li>Item 2</li>' +
  1954. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  1955. '</ul>' +
  1956. '</blockquote>';
  1957. viewRoot._appendChild( parse( content ) );
  1958. renderer.markToSync( 'children', viewRoot );
  1959. renderer.render();
  1960. expect( domRoot.innerHTML ).to.equal( expected );
  1961. viewRoot._removeChildren( 0, viewRoot.childCount );
  1962. viewRoot._appendChild( parse( content + content ) );
  1963. const domBQ = domRoot.childNodes[ 0 ];
  1964. const domUL = domBQ.childNodes[ 0 ];
  1965. const domLI1 = domUL.childNodes[ 0 ];
  1966. const domLI2 = domUL.childNodes[ 1 ];
  1967. const domLI3 = domUL.childNodes[ 2 ];
  1968. renderer.markToSync( 'children', viewRoot );
  1969. renderer.render();
  1970. // Assert content.
  1971. expect( domRoot.innerHTML ).to.equal( expected + expected );
  1972. // Assert if DOM elements did not change.
  1973. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  1974. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  1975. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  1976. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  1977. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  1978. // Assert mappings.
  1979. const domMappings = renderer.domConverter._domToViewMapping;
  1980. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  1981. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  1982. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  1983. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1984. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  1985. // Assert if new view elements are bind to new DOM elements.
  1986. const viewMappings = renderer.domConverter._domToViewMapping;
  1987. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  1988. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  1989. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  1990. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  1991. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  1992. } );
  1993. it( 'should handle complex view replace', () => {
  1994. const content = '' +
  1995. '<container:h2>He' +
  1996. '<attribute:i>ading 1</attribute:i>' +
  1997. '</container:h2>' +
  1998. '<container:p>Ph ' +
  1999. '<attribute:strong>Bold</attribute:strong>' +
  2000. '<attribute:a href="https://ckeditor.com">' +
  2001. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2002. '</attribute:a>' +
  2003. '</container:p>' +
  2004. '<container:blockquote>' +
  2005. '<container:ul>' +
  2006. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2007. '<container:li>Item 2</container:li>' +
  2008. '<container:li>' +
  2009. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2010. '</container:li>' +
  2011. '</container:ul>' +
  2012. '</container:blockquote>';
  2013. const replacement = '' +
  2014. '<container:p>' +
  2015. '1' +
  2016. '<attribute:i>A</attribute:i>' +
  2017. '</container:p>' +
  2018. '<container:p>' +
  2019. '<attribute:a href="https://cksource.com">' +
  2020. 'Li' +
  2021. '<attribute:strong>nk</attribute:strong>' +
  2022. '</attribute:a>' +
  2023. '</container:p>' +
  2024. '<container:h1>' +
  2025. 'Heading ' +
  2026. '<attribute:strong>1</attribute:strong>' +
  2027. '</container:h1>' +
  2028. '<container:h2>' +
  2029. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2030. '</container:h2>' +
  2031. '<container:h3>' +
  2032. 'Heading' +
  2033. '<attribute:i> 3</attribute:i>' +
  2034. '</container:h3>' +
  2035. '<container:blockquote>' +
  2036. 'Foo Bar Baz' +
  2037. '</container:blockquote>' +
  2038. '<container:ul>' +
  2039. '<container:li>' +
  2040. 'Item ' +
  2041. '<attribute:strong>1</attribute:strong>' +
  2042. '</container:li>' +
  2043. '<container:li>' +
  2044. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2045. ' 2' +
  2046. '</container:li>' +
  2047. '</container:ul>';
  2048. viewRoot._appendChild( parse( content ) );
  2049. renderer.markToSync( 'children', viewRoot );
  2050. renderer.render();
  2051. expect( domRoot.innerHTML ).to.equal( '' +
  2052. '<h2>He<i>ading 1</i></h2>' +
  2053. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2054. '<blockquote><ul>' +
  2055. '<li>Quoted <strong>item 1</strong></li>' +
  2056. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2057. '</ul></blockquote>' );
  2058. viewRoot._removeChildren( 0, viewRoot.childCount );
  2059. viewRoot._appendChild( parse( replacement ) );
  2060. renderer.markToSync( 'children', viewRoot );
  2061. renderer.render();
  2062. // Here we just check if new DOM structure was properly rendered.
  2063. expect( domRoot.innerHTML ).to.equal( '' +
  2064. '<p>1<i>A</i></p>' +
  2065. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2066. '<h1>Heading <strong>1</strong></h1>' +
  2067. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2068. '<h3>Heading<i> 3</i></h3>' +
  2069. '<blockquote>Foo Bar Baz</blockquote>' +
  2070. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2071. } );
  2072. it( 'should handle br elements while refreshing bindings', () => {
  2073. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2074. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2075. renderer.markToSync( 'children', viewRoot );
  2076. renderer.render();
  2077. expect( domRoot.innerHTML ).to.equal( expected );
  2078. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2079. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2080. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2081. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2082. viewRoot._removeChildren( 1 );
  2083. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2084. renderer.markToSync( 'children', viewRoot );
  2085. renderer.render();
  2086. expect( domRoot.innerHTML ).to.equal( expected );
  2087. } );
  2088. it( 'should handle list to paragraph conversion', () => {
  2089. const view = '' +
  2090. '<container:ol>' +
  2091. '<container:li>Item 1' +
  2092. '<container:ol>' +
  2093. '<container:li>Item 2</container:li>' +
  2094. '</container:ol>' +
  2095. '</container:li>' +
  2096. '</container:ol>' +
  2097. '<container:p>Paragraph</container:p>' +
  2098. '<container:ol>' +
  2099. '<container:li>Item 3' +
  2100. '<container:ol>' +
  2101. '<container:li>Item 4</container:li>' +
  2102. '</container:ol>' +
  2103. '</container:li>' +
  2104. '</container:ol>';
  2105. viewRoot._appendChild( parse( view ) );
  2106. renderer.markToSync( 'children', viewRoot );
  2107. renderer.render();
  2108. expect( domRoot.innerHTML ).to.equal(
  2109. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2110. const viewOL1 = viewRoot.getChild( 0 );
  2111. viewOL1.getChild( 0 )._removeChildren( 1 );
  2112. viewRoot._removeChildren( 2 );
  2113. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2114. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2115. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2116. const domOL1 = domRoot.childNodes[ 0 ];
  2117. const domOL2 = domRoot.childNodes[ 2 ];
  2118. const domP = domRoot.childNodes[ 1 ];
  2119. renderer.markToSync( 'children', viewRoot );
  2120. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2121. renderer.render();
  2122. expect( domRoot.innerHTML ).to.equal(
  2123. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2124. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2125. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2126. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2127. } );
  2128. it( 'should handle attributes change in replaced elements', () => {
  2129. const view = '' +
  2130. '<container:ol>' +
  2131. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2132. '</container:ol>' +
  2133. '<container:p>Paragraph ' +
  2134. '<attribute:a href="123">Link</attribute:a>' +
  2135. '</container:p>' +
  2136. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2137. viewRoot._appendChild( parse( view ) );
  2138. renderer.markToSync( 'children', viewRoot );
  2139. renderer.render();
  2140. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2141. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2142. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2143. const viewOL = viewRoot.getChild( 0 );
  2144. viewOL._removeChildren( 0 );
  2145. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2146. const viewP1 = viewRoot.getChild( 1 );
  2147. viewP1._removeChildren( 1 );
  2148. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2149. viewRoot._removeChildren( 2 );
  2150. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2151. renderer.markToSync( 'children', viewRoot );
  2152. renderer.markToSync( 'children', viewOL );
  2153. renderer.markToSync( 'children', viewP1 );
  2154. renderer.render();
  2155. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2156. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2157. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2158. } );
  2159. it( 'should handle classes change in replaced elements', () => {
  2160. const view = '' +
  2161. '<container:ol>' +
  2162. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2163. '</container:ol>' +
  2164. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2165. viewRoot._appendChild( parse( view ) );
  2166. renderer.markToSync( 'children', viewRoot );
  2167. renderer.render();
  2168. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2169. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2170. const viewOL = viewRoot.getChild( 0 );
  2171. const oldViewLI = viewOL.getChild( 0 );
  2172. viewOL._removeChildren( 0 );
  2173. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2174. const oldViewP = viewRoot.getChild( 1 );
  2175. viewRoot._removeChildren( 1 );
  2176. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2177. renderer.markToSync( 'attributes', oldViewLI );
  2178. renderer.markToSync( 'attributes', oldViewP );
  2179. renderer.markToSync( 'children', viewRoot );
  2180. renderer.markToSync( 'children', viewOL );
  2181. renderer.render();
  2182. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2183. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2184. } );
  2185. it( 'should handle styles change in replaced elements', () => {
  2186. const view = '' +
  2187. '<container:ol>' +
  2188. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2189. '<container:li>Bar ' +
  2190. '<attribute:i>' +
  2191. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2192. ' Bax</attribute:i>' +
  2193. '</container:li>' +
  2194. '</container:ol>';
  2195. viewRoot._appendChild( parse( view ) );
  2196. renderer.markToSync( 'children', viewRoot );
  2197. renderer.render();
  2198. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2199. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2200. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2201. const viewOL = viewRoot.getChild( 0 );
  2202. const viewLI1 = viewOL.getChild( 0 );
  2203. const viewLI2 = viewOL.getChild( 1 );
  2204. viewLI1._removeStyle( 'font-weight' );
  2205. viewLI1._setStyle( { color: '#FFF' } );
  2206. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2207. viewLI2._removeChildren( 0, viewLI2.childCount );
  2208. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2209. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2210. renderer.markToSync( 'attributes', viewLI1 );
  2211. renderer.markToSync( 'attributes', viewLI2 );
  2212. renderer.markToSync( 'children', viewRoot );
  2213. renderer.markToSync( 'children', viewLI2 );
  2214. renderer.render();
  2215. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2216. '<ol><li style="color:#FFF;">Foo</li>' +
  2217. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2218. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2219. } );
  2220. it( 'should handle uiElement rendering', () => {
  2221. function createUIElement( id, text ) {
  2222. const element = new UIElement( 'span' );
  2223. element.render = function( domDocument ) {
  2224. const domElement = this.toDomElement( domDocument );
  2225. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2226. return domElement;
  2227. };
  2228. return element;
  2229. }
  2230. const ui1 = createUIElement( 'id1', 'UI1' );
  2231. const ui2 = createUIElement( 'id2', 'UI2' );
  2232. const viewP = new ViewContainerElement( 'p', null, [ new ViewText( 'Foo ' ), ui1, new ViewText( 'Bar' ) ] );
  2233. viewRoot._appendChild( viewP );
  2234. renderer.markToSync( 'children', viewRoot );
  2235. renderer.render();
  2236. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2237. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2238. viewP._removeChildren( 0, viewP.childCount );
  2239. viewP._insertChild( 0, [ new ViewText( 'Foo' ), ui2, new ViewText( ' Bar' ) ] );
  2240. renderer.markToSync( 'children', viewRoot );
  2241. renderer.markToSync( 'children', viewP );
  2242. renderer.render();
  2243. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2244. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2245. } );
  2246. it( 'should handle linking entire content', () => {
  2247. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2248. renderer.markToSync( 'children', viewRoot );
  2249. renderer.render();
  2250. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2251. const viewP = viewRoot.getChild( 0 );
  2252. // While linking, the existing DOM children are moved to a new `a` element during binding
  2253. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2254. // where view elements were moved to a newly created link view element.
  2255. const viewA = new ViewAttributeElement( 'a', { href: '#href' }, [ new ViewText( 'Foo' ), viewP.getChild( 1 ) ] );
  2256. viewP._removeChildren( 0, viewP.childCount );
  2257. viewP._insertChild( 0, viewA );
  2258. renderer.markToSync( 'children', viewRoot );
  2259. renderer.markToSync( 'children', viewP );
  2260. renderer.render();
  2261. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2262. } );
  2263. } );
  2264. // #1560
  2265. describe( 'direct attributes manipulation', () => {
  2266. it( 'should rerender element if its attribute was removed before rendering', () => {
  2267. const writer = new DowncastWriter();
  2268. // 1. Setup.
  2269. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2270. const viewP = viewRoot.getChild( 0 );
  2271. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2272. renderer.markToSync( 'children', viewRoot );
  2273. renderer.render();
  2274. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2275. // 2. Transform.
  2276. writer.removeAttribute( 'data-placeholder', viewP );
  2277. viewRoot._removeChildren( 0, viewRoot.childCount );
  2278. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2279. renderer.markToSync( 'children', viewRoot );
  2280. renderer.render();
  2281. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2282. } );
  2283. } );
  2284. } );
  2285. describe( '#922', () => {
  2286. let view, viewDoc, viewRoot, domRoot, converter;
  2287. beforeEach( () => {
  2288. view = new View();
  2289. viewDoc = view.document;
  2290. domRoot = document.createElement( 'div' );
  2291. document.body.appendChild( domRoot );
  2292. viewRoot = createViewRoot( viewDoc );
  2293. view.attachDomRoot( domRoot );
  2294. converter = view.domConverter;
  2295. } );
  2296. it( 'should properly render unwrapped attributes #1', () => {
  2297. setViewData( view,
  2298. '<container:p>' +
  2299. '[<attribute:italic>' +
  2300. '<attribute:strong>f</attribute:strong>' +
  2301. '</attribute:italic>]' +
  2302. '<attribute:strong>oo</attribute:strong>' +
  2303. '</container:p>'
  2304. );
  2305. // Render it to DOM to create initial DOM <-> view mappings.
  2306. view.render();
  2307. // Unwrap italic attribute element.
  2308. view.change( writer => {
  2309. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2310. } );
  2311. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2312. // Re-render changes in view to DOM.
  2313. view.render();
  2314. // Check if DOM is rendered correctly.
  2315. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2316. expect( checkMappings() ).to.be.true;
  2317. } );
  2318. it( 'should properly render unwrapped attributes #2', () => {
  2319. setViewData( view,
  2320. '<container:p>' +
  2321. '[<attribute:italic>' +
  2322. '<attribute:strong>foo</attribute:strong>' +
  2323. '</attribute:italic>]' +
  2324. '</container:p>' );
  2325. // Render it to DOM to create initial DOM <-> view mappings.
  2326. view.render();
  2327. // Unwrap italic attribute element and change text inside.
  2328. view.change( writer => {
  2329. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2330. } );
  2331. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2332. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2333. // Re-render changes in view to DOM.
  2334. view.render();
  2335. // Check if DOM is rendered correctly.
  2336. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2337. expect( checkMappings() ).to.be.true;
  2338. } );
  2339. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2340. setViewData( view,
  2341. '<container:p>foo</container:p>'
  2342. );
  2343. // Render it to DOM to create initial DOM <-> view mappings.
  2344. view.render();
  2345. // Change text and insert new element into paragraph.
  2346. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2347. textNode._data = 'foobar';
  2348. view.change( writer => {
  2349. writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  2350. } );
  2351. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2352. // Re-render changes in view to DOM.
  2353. view.render();
  2354. // Check if DOM is rendered correctly.
  2355. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2356. expect( checkMappings() ).to.be.true;
  2357. } );
  2358. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2359. setViewData( view,
  2360. '<container:p>foo</container:p>'
  2361. );
  2362. // Render it to DOM to create initial DOM <-> view mappings.
  2363. view.render();
  2364. // Change text and insert new element into paragraph.
  2365. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2366. textNode._data = 'foobar';
  2367. view.change( writer => {
  2368. writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  2369. } );
  2370. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2371. // Re-render changes in view to DOM.
  2372. view.render();
  2373. // Check if DOM is rendered correctly.
  2374. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2375. expect( checkMappings() ).to.be.true;
  2376. } );
  2377. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2378. setViewData( view,
  2379. '<container:p>' +
  2380. '<attribute:b></attribute:b>' +
  2381. '<attribute:i></attribute:i>' +
  2382. '<attribute:span></attribute:span>' +
  2383. '</container:p>'
  2384. );
  2385. // Render it to DOM to create initial DOM <-> view mappings.
  2386. view.render();
  2387. // Remove first element and reinsert it at the end.
  2388. const container = viewRoot.getChild( 0 );
  2389. const firstElement = container.getChild( 0 );
  2390. view.change( writer => {
  2391. writer.remove( ViewRange.createOn( firstElement ) );
  2392. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2393. } );
  2394. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2395. // Re-render changes in view to DOM.
  2396. view.render();
  2397. // Check if DOM is rendered correctly.
  2398. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2399. expect( checkMappings() ).to.be.true;
  2400. } );
  2401. // Checks if every node in DOM tree is mapped to the view.
  2402. function checkMappings() {
  2403. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2404. while ( domWalker.nextNode() ) {
  2405. const node = domWalker.currentNode;
  2406. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2407. return false;
  2408. }
  2409. }
  2410. return true;
  2411. }
  2412. } );
  2413. describe( '_markDescendantTextToSync', () => {
  2414. let viewRoot;
  2415. beforeEach( () => {
  2416. viewRoot = new ViewElement( 'div' );
  2417. renderer.markedTexts.clear();
  2418. renderer.markedAttributes.clear();
  2419. renderer.markedChildren.clear();
  2420. } );
  2421. it( 'should handle null values', () => {
  2422. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2423. renderer._markDescendantTextToSync( null );
  2424. expect( renderer.markedChildren.size ).to.equal( 0 );
  2425. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2426. expect( renderer.markedTexts.size ).to.equal( 0 );
  2427. } );
  2428. it( 'should handle element nodes', () => {
  2429. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2430. viewRoot._appendChild( viewP );
  2431. renderer._markDescendantTextToSync( viewP );
  2432. expect( renderer.markedChildren.size ).to.equal( 0 );
  2433. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2434. expect( renderer.markedTexts.size ).to.equal( 3 );
  2435. } );
  2436. it( 'should handle text nodes', () => {
  2437. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2438. viewRoot._appendChild( viewP );
  2439. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2440. expect( renderer.markedChildren.size ).to.equal( 0 );
  2441. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2442. expect( renderer.markedTexts.size ).to.equal( 1 );
  2443. } );
  2444. it( 'should handle document fragment', () => {
  2445. const fragment = new DocumentFragment();
  2446. renderer._markDescendantTextToSync( fragment );
  2447. expect( renderer.markedChildren.size ).to.equal( 0 );
  2448. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2449. expect( renderer.markedTexts.size ).to.equal( 0 );
  2450. } );
  2451. it( 'should handle empty element nodes', () => {
  2452. const viewP = parse( '<container:p></container:p>' );
  2453. viewRoot._appendChild( viewP );
  2454. renderer._markDescendantTextToSync( viewP );
  2455. expect( renderer.markedChildren.size ).to.equal( 0 );
  2456. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2457. expect( renderer.markedTexts.size ).to.equal( 0 );
  2458. } );
  2459. } );
  2460. describe( '_updateText', () => {
  2461. let viewRoot, domRoot;
  2462. beforeEach( () => {
  2463. viewRoot = new ViewElement( 'div' );
  2464. domRoot = document.createElement( 'div' );
  2465. document.body.appendChild( domRoot );
  2466. domConverter.bindElements( domRoot, viewRoot );
  2467. renderer.markedTexts.clear();
  2468. renderer.markedAttributes.clear();
  2469. renderer.markedChildren.clear();
  2470. renderer.isFocused = true;
  2471. } );
  2472. afterEach( () => {
  2473. domRoot.remove();
  2474. } );
  2475. it( 'should update text - change on end', () => {
  2476. const viewText = new ViewText( 'foo' );
  2477. viewRoot._appendChild( viewText );
  2478. renderer.markToSync( 'children', viewRoot );
  2479. renderer.render();
  2480. expect( domRoot.childNodes.length ).to.equal( 1 );
  2481. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2482. viewText._data = 'fobar';
  2483. renderer._updateText( viewText, {} );
  2484. expect( domRoot.childNodes.length ).to.equal( 1 );
  2485. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2486. } );
  2487. it( 'should update text - change on start', () => {
  2488. const viewText = new ViewText( 'foo' );
  2489. viewRoot._appendChild( viewText );
  2490. renderer.markToSync( 'children', viewRoot );
  2491. renderer.render();
  2492. expect( domRoot.childNodes.length ).to.equal( 1 );
  2493. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2494. viewText._data = 'baro';
  2495. renderer._updateText( viewText, {} );
  2496. expect( domRoot.childNodes.length ).to.equal( 1 );
  2497. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  2498. } );
  2499. it( 'should update text - change in the middle', () => {
  2500. const viewText = new ViewText( 'foobar' );
  2501. viewRoot._appendChild( viewText );
  2502. renderer.markToSync( 'children', viewRoot );
  2503. renderer.render();
  2504. expect( domRoot.childNodes.length ).to.equal( 1 );
  2505. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  2506. viewText._data = 'fobazr';
  2507. renderer._updateText( viewText, {} );
  2508. expect( domRoot.childNodes.length ).to.equal( 1 );
  2509. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  2510. } );
  2511. it( 'should update text - empty expected', () => {
  2512. const viewText = new ViewText( 'foo' );
  2513. viewRoot._appendChild( viewText );
  2514. renderer.markToSync( 'children', viewRoot );
  2515. renderer.render();
  2516. expect( domRoot.childNodes.length ).to.equal( 1 );
  2517. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2518. viewText._data = '';
  2519. renderer._updateText( viewText, {} );
  2520. expect( domRoot.childNodes.length ).to.equal( 1 );
  2521. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2522. } );
  2523. it( 'should update text - empty actual', () => {
  2524. const viewText = new ViewText( '' );
  2525. viewRoot._appendChild( viewText );
  2526. renderer.markToSync( 'children', viewRoot );
  2527. renderer.render();
  2528. expect( domRoot.childNodes.length ).to.equal( 1 );
  2529. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2530. viewText._data = 'fobar';
  2531. renderer._updateText( viewText, {} );
  2532. expect( domRoot.childNodes.length ).to.equal( 1 );
  2533. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2534. } );
  2535. it( 'should handle filler during text modifications', () => {
  2536. const viewText = new ViewText( 'foo' );
  2537. viewRoot._appendChild( viewText );
  2538. renderer.markToSync( 'children', viewRoot );
  2539. renderer.render();
  2540. expect( domRoot.childNodes.length ).to.equal( 1 );
  2541. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2542. // 1. Insert filler.
  2543. renderer._updateText( viewText, {
  2544. inlineFillerPosition: {
  2545. parent: viewText.parent,
  2546. offset: 0
  2547. }
  2548. } );
  2549. expect( domRoot.childNodes.length ).to.equal( 1 );
  2550. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2551. // 2. Edit text - filler should be preserved.
  2552. viewText._data = 'barfoo';
  2553. renderer._updateText( viewText, {
  2554. inlineFillerPosition: {
  2555. parent: viewText.parent,
  2556. offset: 0
  2557. }
  2558. } );
  2559. expect( domRoot.childNodes.length ).to.equal( 1 );
  2560. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  2561. // 3. Remove filler.
  2562. renderer._updateText( viewText, {} );
  2563. expect( domRoot.childNodes.length ).to.equal( 1 );
  2564. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  2565. } );
  2566. it( 'should handle filler during text modifications - empty text', () => {
  2567. const viewText = new ViewText( '' );
  2568. viewRoot._appendChild( viewText );
  2569. renderer.markToSync( 'children', viewRoot );
  2570. renderer.render();
  2571. expect( domRoot.childNodes.length ).to.equal( 1 );
  2572. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2573. // 1. Insert filler.
  2574. renderer._updateText( viewText, {
  2575. inlineFillerPosition: {
  2576. parent: viewText.parent,
  2577. offset: 0
  2578. }
  2579. } );
  2580. expect( domRoot.childNodes.length ).to.equal( 1 );
  2581. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  2582. // 2. Edit text - filler should be preserved.
  2583. viewText._data = 'foo';
  2584. renderer._updateText( viewText, {
  2585. inlineFillerPosition: {
  2586. parent: viewText.parent,
  2587. offset: 0
  2588. }
  2589. } );
  2590. expect( domRoot.childNodes.length ).to.equal( 1 );
  2591. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2592. // 3. Remove filler.
  2593. viewText._data = '';
  2594. renderer._updateText( viewText, {} );
  2595. expect( domRoot.childNodes.length ).to.equal( 1 );
  2596. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2597. } );
  2598. it( 'should handle filler during text modifications inside inline element', () => {
  2599. const viewB = new ViewElement( 'b' );
  2600. const viewText = new ViewText( 'foo' );
  2601. viewB._appendChild( viewText );
  2602. viewRoot._appendChild( viewB );
  2603. renderer.markToSync( 'children', viewRoot );
  2604. renderer.render();
  2605. expect( domRoot.childNodes.length ).to.equal( 1 );
  2606. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2607. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2608. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  2609. // 1. Insert filler.
  2610. renderer._updateText( viewText, {
  2611. inlineFillerPosition: {
  2612. parent: viewText.parent,
  2613. offset: 0
  2614. }
  2615. } );
  2616. expect( domRoot.childNodes.length ).to.equal( 1 );
  2617. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2618. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2619. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2620. // 2. Edit text - filler should be preserved.
  2621. viewText._data = 'bar';
  2622. renderer._updateText( viewText, {
  2623. inlineFillerPosition: {
  2624. parent: viewText.parent,
  2625. offset: 0
  2626. }
  2627. } );
  2628. expect( domRoot.childNodes.length ).to.equal( 1 );
  2629. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2630. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2631. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  2632. // 3. Remove filler.
  2633. viewText._data = 'bar';
  2634. renderer._updateText( viewText, {} );
  2635. expect( domRoot.childNodes.length ).to.equal( 1 );
  2636. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  2637. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  2638. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  2639. } );
  2640. } );
  2641. } );
  2642. function renderAndExpectNoChanges( renderer, domRoot ) {
  2643. const config = {
  2644. childList: true,
  2645. characterData: true,
  2646. characterDataOldValue: true,
  2647. subtree: true
  2648. };
  2649. const mutationObserver = new window.MutationObserver( () => {
  2650. throw 'There should be not mutations';
  2651. } );
  2652. mutationObserver.observe( domRoot, config );
  2653. renderer.render();
  2654. const records = mutationObserver.takeRecords();
  2655. mutationObserver.disconnect();
  2656. expect( records.length ).to.equal( 0 );
  2657. }