8
0

renderer.js 145 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148
  1. /**
  2. * @license Copyright (c) 2003-2019, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  4. */
  5. /* globals document, window, NodeFilter, MutationObserver */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewEditableElement from '../../src/view/editableelement';
  9. import ViewContainerElement from '../../src/view/containerelement';
  10. import ViewAttributeElement from '../../src/view/attributeelement';
  11. import ViewText from '../../src/view/text';
  12. import ViewRange from '../../src/view/range';
  13. import ViewPosition from '../../src/view/position';
  14. import UIElement from '../../src/view/uielement';
  15. import DocumentSelection from '../../src/view/documentselection';
  16. import DomConverter from '../../src/view/domconverter';
  17. import Renderer from '../../src/view/renderer';
  18. import DocumentFragment from '../../src/view/documentfragment';
  19. import DowncastWriter from '../../src/view/downcastwriter';
  20. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  21. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  22. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  23. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  24. import createViewRoot from './_utils/createroot';
  25. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  26. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  27. import env from '@ckeditor/ckeditor5-utils/src/env';
  28. describe( 'Renderer', () => {
  29. let selection, domConverter, renderer;
  30. testUtils.createSinonSandbox();
  31. beforeEach( () => {
  32. selection = new DocumentSelection();
  33. domConverter = new DomConverter();
  34. renderer = new Renderer( domConverter, selection );
  35. renderer.domDocuments.add( document );
  36. } );
  37. describe( 'markToSync', () => {
  38. let viewRoot;
  39. beforeEach( () => {
  40. viewRoot = new ViewElement( 'p' );
  41. const domRoot = document.createElement( 'p' );
  42. domConverter.bindElements( domRoot, viewRoot );
  43. viewRoot._appendChild( new ViewText( 'foo' ) );
  44. renderer.markedTexts.clear();
  45. renderer.markedAttributes.clear();
  46. renderer.markedChildren.clear();
  47. } );
  48. it( 'should mark attributes which need update', () => {
  49. viewRoot._setAttribute( 'class', 'foo' );
  50. renderer.markToSync( 'attributes', viewRoot );
  51. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  52. } );
  53. it( 'should mark children which need update', () => {
  54. viewRoot._appendChild( new ViewText( 'foo' ) );
  55. renderer.markToSync( 'children', viewRoot );
  56. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  57. } );
  58. it( 'should not mark children if element has no corresponding node', () => {
  59. // Overwrite viewRoot with node without coresponding DOM node.
  60. viewRoot = new ViewElement( 'p' );
  61. viewRoot._appendChild( new ViewText( 'foo' ) );
  62. renderer.markToSync( 'children', viewRoot );
  63. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  64. } );
  65. it( 'should mark text which need update', () => {
  66. const viewText = new ViewText( 'foo' );
  67. viewRoot._appendChild( viewText );
  68. viewText._data = 'bar';
  69. renderer.markToSync( 'text', viewText );
  70. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  71. } );
  72. it( 'should not mark text if parent has no corresponding node', () => {
  73. const viewText = new ViewText( 'foo' );
  74. // Overwrite viewRoot with node without coresponding DOM node.
  75. viewRoot = new ViewElement( 'p' );
  76. viewRoot._appendChild( viewText );
  77. viewText._data = 'bar';
  78. renderer.markToSync( 'text', viewText );
  79. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  80. } );
  81. it( 'should throw if the type is unknown', () => {
  82. expect( () => {
  83. renderer.markToSync( 'UNKNOWN', viewRoot );
  84. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  85. } );
  86. } );
  87. describe( 'render', () => {
  88. let viewRoot, domRoot;
  89. beforeEach( () => {
  90. viewRoot = new ViewEditableElement( 'div' );
  91. viewRoot.getFillerOffset = () => null;
  92. domRoot = document.createElement( 'div' );
  93. document.body.appendChild( domRoot );
  94. domConverter.bindElements( domRoot, viewRoot );
  95. renderer.markedTexts.clear();
  96. renderer.markedAttributes.clear();
  97. renderer.markedChildren.clear();
  98. selection._setTo( null );
  99. renderer.isFocused = true;
  100. } );
  101. afterEach( () => {
  102. domRoot.remove();
  103. } );
  104. it( 'should update attributes', () => {
  105. viewRoot._setAttribute( 'class', 'foo' );
  106. renderer.markToSync( 'attributes', viewRoot );
  107. renderer.render();
  108. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  109. expect( renderer.markedAttributes.size ).to.equal( 0 );
  110. } );
  111. it( 'should remove attributes', () => {
  112. viewRoot._setAttribute( 'class', 'foo' );
  113. domRoot.setAttribute( 'id', 'bar' );
  114. domRoot.setAttribute( 'class', 'bar' );
  115. renderer.markToSync( 'attributes', viewRoot );
  116. renderer.render();
  117. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  118. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  119. expect( renderer.markedAttributes.size ).to.equal( 0 );
  120. } );
  121. it( 'should add children', () => {
  122. viewRoot._appendChild( new ViewText( 'foo' ) );
  123. renderer.markToSync( 'children', viewRoot );
  124. renderer.render();
  125. expect( domRoot.childNodes.length ).to.equal( 1 );
  126. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  127. expect( renderer.markedChildren.size ).to.equal( 0 );
  128. } );
  129. it( 'should remove children', () => {
  130. viewRoot._appendChild( new ViewText( 'foo' ) );
  131. renderer.markToSync( 'children', viewRoot );
  132. renderer.render();
  133. expect( domRoot.childNodes.length ).to.equal( 1 );
  134. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  135. viewRoot._removeChildren( 0, 1 );
  136. renderer.markToSync( 'children', viewRoot );
  137. renderer.render();
  138. expect( domRoot.childNodes.length ).to.equal( 0 );
  139. expect( renderer.markedChildren.size ).to.equal( 0 );
  140. } );
  141. it( 'should update text', () => {
  142. const viewText = new ViewText( 'foo' );
  143. viewRoot._appendChild( viewText );
  144. renderer.markToSync( 'children', viewRoot );
  145. renderer.render();
  146. expect( domRoot.childNodes.length ).to.equal( 1 );
  147. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  148. viewText._data = 'bar';
  149. renderer.markToSync( 'text', viewText );
  150. renderer.render();
  151. expect( domRoot.childNodes.length ).to.equal( 1 );
  152. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  153. expect( renderer.markedTexts.size ).to.equal( 0 );
  154. } );
  155. it( 'should not update same text', () => {
  156. const viewText = new ViewText( 'foo' );
  157. viewRoot._appendChild( viewText );
  158. renderer.markToSync( 'children', viewRoot );
  159. renderer.render();
  160. expect( domRoot.childNodes.length ).to.equal( 1 );
  161. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  162. viewText._data = 'foo';
  163. renderer.markToSync( 'text', viewText );
  164. renderAndExpectNoChanges( renderer, domRoot );
  165. expect( domRoot.childNodes.length ).to.equal( 1 );
  166. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  167. expect( renderer.markedTexts.size ).to.equal( 0 );
  168. } );
  169. it( 'should not update text parent child list changed', () => {
  170. const viewImg = new ViewElement( 'img' );
  171. const viewText = new ViewText( 'foo' );
  172. viewRoot._appendChild( [ viewImg, viewText ] );
  173. renderer.markToSync( 'children', viewRoot );
  174. renderer.markToSync( 'text', viewText );
  175. renderer.render();
  176. expect( domRoot.childNodes.length ).to.equal( 2 );
  177. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  178. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  179. } );
  180. it( 'should not change text if it is the same during text rendering', () => {
  181. const viewText = new ViewText( 'foo' );
  182. viewRoot._appendChild( viewText );
  183. renderer.markToSync( 'children', viewRoot );
  184. renderer.render();
  185. // This should not be changed during the render.
  186. const domText = domRoot.childNodes[ 0 ];
  187. renderer.markToSync( 'text', viewText );
  188. renderer.render();
  189. expect( domRoot.childNodes.length ).to.equal( 1 );
  190. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  191. } );
  192. it( 'should not change text if it is the same during children rendering', () => {
  193. const viewText = new ViewText( 'foo' );
  194. viewRoot._appendChild( viewText );
  195. renderer.markToSync( 'children', viewRoot );
  196. renderer.render();
  197. // This should not be changed during the render.
  198. const domText = domRoot.childNodes[ 0 ];
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. expect( domRoot.childNodes.length ).to.equal( 1 );
  202. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  203. } );
  204. it( 'should not change element if it is the same', () => {
  205. const viewImg = new ViewElement( 'img' );
  206. viewRoot._appendChild( viewImg );
  207. // This should not be changed during the render.
  208. const domImg = document.createElement( 'img' );
  209. domRoot.appendChild( domImg );
  210. domConverter.bindElements( domImg, viewImg );
  211. renderer.markToSync( 'children', viewRoot );
  212. renderer.render();
  213. expect( domRoot.childNodes.length ).to.equal( 1 );
  214. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  215. } );
  216. it( 'should change element if it is different', () => {
  217. const viewImg = new ViewElement( 'img' );
  218. viewRoot._appendChild( viewImg );
  219. renderer.markToSync( 'children', viewRoot );
  220. renderer.render();
  221. const viewP = new ViewElement( 'p' );
  222. viewRoot._removeChildren( 0, 1 );
  223. viewRoot._appendChild( viewP );
  224. renderer.markToSync( 'children', viewRoot );
  225. renderer.render();
  226. expect( domRoot.childNodes.length ).to.equal( 1 );
  227. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  228. } );
  229. it( 'should update removed item when it is reinserted', () => {
  230. const viewFoo = new ViewText( 'foo' );
  231. const viewP = new ViewElement( 'p', null, viewFoo );
  232. const viewDiv = new ViewElement( 'div', null, viewP );
  233. viewRoot._appendChild( viewDiv );
  234. renderer.markToSync( 'children', viewRoot );
  235. renderer.render();
  236. viewDiv._removeChildren( 0, 1 );
  237. renderer.markToSync( 'children', viewDiv );
  238. renderer.render();
  239. viewP._removeChildren( 0, 1 );
  240. viewDiv._appendChild( viewP );
  241. renderer.markToSync( 'children', viewDiv );
  242. renderer.render();
  243. expect( domRoot.childNodes.length ).to.equal( 1 );
  244. const domDiv = domRoot.childNodes[ 0 ];
  245. expect( domDiv.tagName ).to.equal( 'DIV' );
  246. expect( domDiv.childNodes.length ).to.equal( 1 );
  247. const domP = domDiv.childNodes[ 0 ];
  248. expect( domP.tagName ).to.equal( 'P' );
  249. expect( domP.childNodes.length ).to.equal( 0 );
  250. } );
  251. it( 'should update removed item when it is reinserted #2', () => {
  252. // Prepare view: root -> div "outer" -> div "inner" -> p.
  253. const viewP = new ViewElement( 'p' );
  254. const viewDivInner = new ViewElement( 'div', null, viewP );
  255. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  256. viewRoot._appendChild( viewDivOuter );
  257. // Render view tree to DOM.
  258. renderer.markToSync( 'children', viewRoot );
  259. renderer.render();
  260. // Remove div "outer" from root and render it.
  261. viewDivOuter._remove();
  262. renderer.markToSync( 'children', viewRoot );
  263. renderer.render();
  264. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  265. viewP._remove();
  266. // Add div "outer" back to root.
  267. viewRoot._appendChild( viewDivOuter );
  268. renderer.markToSync( 'children', viewRoot );
  269. // Render changes, view is: root -> div "outer" -> div "inner".
  270. renderer.render();
  271. // Same is expected in DOM.
  272. expect( domRoot.childNodes.length ).to.equal( 1 );
  273. const domDivOuter = domRoot.childNodes[ 0 ];
  274. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  275. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  276. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  277. const domDivInner = domDivOuter.childNodes[ 0 ];
  278. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  279. expect( domDivInner.tagName ).to.equal( 'DIV' );
  280. expect( domDivInner.childNodes.length ).to.equal( 0 );
  281. } );
  282. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  283. const viewFoo = new ViewText( 'foo' );
  284. const viewP = new ViewElement( 'p', null, viewFoo );
  285. const viewDiv = new ViewElement( 'div', null, viewP );
  286. viewRoot._appendChild( viewDiv );
  287. renderer.markToSync( 'children', viewRoot );
  288. renderer.render();
  289. viewRoot._removeChildren( 0, 1 );
  290. renderer.markToSync( 'children', viewRoot );
  291. viewDiv._removeChildren( 0, 1 );
  292. renderer.markToSync( 'children', viewDiv );
  293. viewP._removeChildren( 0, 1 );
  294. renderer.markToSync( 'children', viewP );
  295. renderer.render();
  296. expect( domRoot.childNodes.length ).to.equal( 0 );
  297. } );
  298. it( 'should not care about filler if there is no DOM', () => {
  299. const { view: viewP, selection: newSelection } = parse(
  300. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  301. const viewRoot = new ViewElement( 'p' );
  302. viewRoot._appendChild( viewP );
  303. selection._setTo( newSelection );
  304. renderer.markToSync( 'children', viewRoot );
  305. renderer.render();
  306. // Expect no error on render.
  307. expect( viewRoot ).to.be.ok;
  308. } );
  309. it( 'should not add filler when inside contenteditable=false parent', () => {
  310. const { view: viewP, selection: newSelection } = parse(
  311. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  312. viewRoot._appendChild( viewP );
  313. selection._setTo( newSelection );
  314. renderer.markToSync( 'children', viewRoot );
  315. renderer.render();
  316. expect( domRoot.childNodes.length ).to.equal( 1 );
  317. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  318. const domP = domRoot.childNodes[ 0 ];
  319. expect( domP.childNodes.length ).to.equal( 3 );
  320. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  321. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  322. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  323. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  324. } );
  325. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  326. const { view: viewP, selection: newSelection } = parse(
  327. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  328. viewRoot._appendChild( viewP );
  329. selection._setTo( newSelection );
  330. renderer.markToSync( 'children', viewRoot );
  331. renderer.render();
  332. expect( domRoot.childNodes.length ).to.equal( 1 );
  333. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  334. const domP = domRoot.childNodes[ 0 ];
  335. expect( domP.childNodes.length ).to.equal( 3 );
  336. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  337. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  338. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  339. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  340. } );
  341. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  342. const domSelection = document.getSelection();
  343. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  344. const { view: viewP, selection: newSelection } = parse(
  345. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  346. viewRoot._appendChild( viewP );
  347. selection._setTo( newSelection );
  348. renderer.markToSync( 'children', viewRoot );
  349. renderer.render();
  350. expect( domRoot.childNodes.length ).to.equal( 1 );
  351. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  352. const domP = domRoot.childNodes[ 0 ];
  353. expect( domP.childNodes.length ).to.equal( 3 );
  354. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  355. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  356. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  357. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  358. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  359. expect( domSelection.rangeCount ).to.equal( 1 );
  360. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  361. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  362. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  363. // Step 2: No mutation on second render
  364. renderer.markToSync( 'children', viewRoot );
  365. renderer.markToSync( 'children', viewP );
  366. renderAndExpectNoChanges( renderer, domRoot );
  367. // Step 3: <p>foo{}<b></b></p>
  368. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  369. renderer.render();
  370. expect( domP.childNodes.length ).to.equal( 3 );
  371. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  372. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  373. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  374. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  375. expect( domSelection.rangeCount ).to.equal( 1 );
  376. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  377. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  378. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  379. // Step 4: No mutation on second render
  380. renderer.markToSync( 'children', viewRoot );
  381. renderer.markToSync( 'children', viewP );
  382. renderAndExpectNoChanges( renderer, domRoot );
  383. } );
  384. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  385. const domSelection = document.getSelection();
  386. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  387. const { view: viewP, selection: newSelection } = parse(
  388. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  389. viewRoot._appendChild( viewP );
  390. selection._setTo( newSelection );
  391. renderer.markToSync( 'children', viewRoot );
  392. renderer.render();
  393. const domP = domRoot.childNodes[ 0 ];
  394. expect( domP.childNodes.length ).to.equal( 2 );
  395. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  396. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  397. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  398. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  399. expect( domSelection.rangeCount ).to.equal( 1 );
  400. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  401. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  402. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  403. // Step 2: No mutation on second render
  404. renderer.markToSync( 'children', viewP );
  405. renderAndExpectNoChanges( renderer, domRoot );
  406. // Step 3: <p><b>{}foo</b></p>
  407. selection._setTo( ViewRange._createFromParentsAndOffsets(
  408. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  409. renderer.render();
  410. expect( domP.childNodes.length ).to.equal( 1 );
  411. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  412. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  413. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  414. expect( domSelection.rangeCount ).to.equal( 1 );
  415. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  416. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  417. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  418. // Step 4: No mutation on second render
  419. renderer.markToSync( 'children', viewP );
  420. renderAndExpectNoChanges( renderer, domRoot );
  421. } );
  422. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  423. const domSelection = document.getSelection();
  424. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  425. const { view: viewP, selection: newSelection } = parse(
  426. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  427. viewRoot._appendChild( viewP );
  428. selection._setTo( newSelection );
  429. renderer.markToSync( 'children', viewRoot );
  430. renderer.render();
  431. const domP = domRoot.childNodes[ 0 ];
  432. expect( domP.childNodes.length ).to.equal( 2 );
  433. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  434. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  435. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  436. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  437. expect( domSelection.rangeCount ).to.equal( 1 );
  438. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  439. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  440. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  441. // Step 2: No mutation on second render
  442. renderer.markToSync( 'children', viewP );
  443. renderAndExpectNoChanges( renderer, domRoot );
  444. // Step 3: <p><b>foo{}</b></p>
  445. selection._setTo( ViewRange._createFromParentsAndOffsets(
  446. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  447. renderer.render();
  448. expect( domP.childNodes.length ).to.equal( 1 );
  449. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  450. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  451. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  452. expect( domSelection.rangeCount ).to.equal( 1 );
  453. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  454. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  455. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  456. // Step 4: No mutation on second render
  457. renderer.markToSync( 'children', viewP );
  458. renderAndExpectNoChanges( renderer, domRoot );
  459. } );
  460. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  461. const domSelection = document.getSelection();
  462. const { view: viewP, selection: newSelection } = parse(
  463. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  464. viewRoot._appendChild( viewP );
  465. selection._setTo( newSelection );
  466. renderer.markToSync( 'children', viewRoot );
  467. renderer.render();
  468. const domP = domRoot.childNodes[ 0 ];
  469. expect( domP.childNodes.length ).to.equal( 3 );
  470. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  471. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  472. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  473. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  474. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  475. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  476. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  477. expect( domSelection.rangeCount ).to.equal( 1 );
  478. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  479. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  480. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  481. } );
  482. it( 'should move filler when selection is moved', () => {
  483. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  484. const { view: viewP, selection: newSelection } = parse(
  485. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  486. viewRoot._appendChild( viewP );
  487. selection._setTo( newSelection );
  488. renderer.markToSync( 'children', viewRoot );
  489. renderer.render();
  490. const domP = domRoot.childNodes[ 0 ];
  491. expect( domP.childNodes.length ).to.equal( 3 );
  492. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  493. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  494. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  495. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  496. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  497. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  498. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  499. const viewI = viewP.getChild( 2 );
  500. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  501. renderer.render();
  502. expect( domP.childNodes.length ).to.equal( 3 );
  503. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  504. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  505. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  506. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  507. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  508. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  509. } );
  510. it( 'should remove filler when text is added and selection removed', () => {
  511. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  512. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  513. const viewB = viewP.getChild( 1 );
  514. viewRoot._appendChild( viewP );
  515. selection._setTo( newSelection );
  516. renderer.markToSync( 'children', viewRoot );
  517. renderer.render();
  518. const domP = domRoot.childNodes[ 0 ];
  519. expect( domP.childNodes.length ).to.equal( 2 );
  520. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  521. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  522. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  523. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  524. // Step 2: Add text node.
  525. const viewText = new ViewText( 'x' );
  526. viewB._appendChild( viewText );
  527. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  528. renderer.markToSync( 'children', viewB );
  529. renderer.render();
  530. // Step 3: Remove selection from the view.
  531. selection._setTo( null );
  532. renderer.render();
  533. expect( domP.childNodes.length ).to.equal( 2 );
  534. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  535. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  536. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  537. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  538. } );
  539. // #659
  540. // The element before the filler is removed so the position of the filler
  541. // cannot be remembered as parent+offset.
  542. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  543. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  544. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  545. viewRoot._appendChild( viewP );
  546. selection._setTo( newSelection );
  547. renderer.markToSync( 'children', viewRoot );
  548. renderer.render();
  549. const domP = domRoot.childNodes[ 0 ];
  550. expect( domP.childNodes.length ).to.equal( 3 );
  551. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  552. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  553. viewP._removeChildren( 1 );
  554. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  555. renderer.markToSync( 'children', viewP );
  556. renderer.render();
  557. // Step 3: Check whether there's no filler in the DOM.
  558. expect( domP.childNodes.length ).to.equal( 1 );
  559. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  560. } );
  561. // #659
  562. it( 'should remove filler from a modified DOM when children moved', () => {
  563. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  564. const { view: viewFragment, selection: newSelection } = parse(
  565. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  566. );
  567. viewRoot._appendChild( viewFragment );
  568. selection._setTo( newSelection );
  569. renderer.markToSync( 'children', viewRoot );
  570. renderer.render();
  571. expect( domRoot.childNodes.length ).to.equal( 2 );
  572. const domP = domRoot.childNodes[ 0 ];
  573. const domP2 = domRoot.childNodes[ 1 ];
  574. expect( domP.childNodes.length ).to.equal( 3 );
  575. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  576. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  577. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  578. const viewP = viewRoot.getChild( 0 );
  579. const viewP2 = viewRoot.getChild( 1 );
  580. const removedChildren = viewP._removeChildren( 0, 2 );
  581. viewP2._appendChild( removedChildren );
  582. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  583. renderer.markToSync( 'children', viewP );
  584. renderer.markToSync( 'children', viewP2 );
  585. renderer.render();
  586. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  587. // in the second one there are two <b> tags.
  588. expect( domP.childNodes.length ).to.equal( 1 );
  589. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  590. expect( domP2.childNodes.length ).to.equal( 2 );
  591. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  592. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  593. } );
  594. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  595. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  596. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  597. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  598. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  599. viewRoot._appendChild( viewP );
  600. selection._setTo( newSelection );
  601. renderer.markToSync( 'children', viewRoot );
  602. renderer.render();
  603. const domP = domRoot.childNodes[ 0 ];
  604. expect( domP.childNodes.length ).to.equal( 2 );
  605. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  606. // Step 2: Move selection to a new attribute element and remove the previous one
  607. viewP._removeChildren( 1 ); // Remove <b>.
  608. const viewI = parse( '<attribute:i></attribute:i>' );
  609. viewP._appendChild( viewI );
  610. selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  611. renderer.markToSync( 'children', viewP );
  612. renderer.render();
  613. // Step 3: Check whether new filler was created in the <i> element.
  614. expect( domP.childNodes.length ).to.equal( 2 );
  615. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  616. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  617. } );
  618. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  619. // that has not been yet rendered/bound to DOM.
  620. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  621. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  622. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  623. viewRoot._appendChild( viewP );
  624. selection._setTo( newSelection );
  625. renderer.markToSync( 'children', viewRoot );
  626. renderer.render();
  627. const domP = domRoot.childNodes[ 0 ];
  628. expect( domP.childNodes.length ).to.equal( 3 );
  629. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  630. // Step 2: Move selection to a new attribute element.
  631. const viewAbc = parse( 'abc' );
  632. viewP._appendChild( viewAbc );
  633. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  634. renderer.markToSync( 'children', viewP );
  635. renderer.render();
  636. // Step 3: Check whether old filler was removed.
  637. expect( domP.childNodes.length ).to.equal( 3 );
  638. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  639. } );
  640. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  641. const domSelection = document.getSelection();
  642. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  643. viewRoot._appendChild( viewP );
  644. selection._setTo( newSelection );
  645. renderer.markToSync( 'children', viewRoot );
  646. renderer.render();
  647. const domP = domRoot.childNodes[ 0 ];
  648. expect( domP.childNodes.length ).to.equal( 1 );
  649. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  650. expect( domSelection.rangeCount ).to.equal( 1 );
  651. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  652. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  653. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  654. // Remove filler and add text node to both DOM and View <p>x{}</p>
  655. domP.removeChild( domP.childNodes[ 0 ] );
  656. domP.appendChild( document.createTextNode( 'x' ) );
  657. domSelection.removeAllRanges();
  658. const domRange = document.createRange();
  659. domRange.setStart( domP.childNodes[ 0 ], 1 );
  660. domRange.collapse( true );
  661. domSelection.addRange( domRange );
  662. const viewText = new ViewText( 'x' );
  663. viewP._appendChild( viewText );
  664. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  665. renderer.markToSync( 'children', viewP );
  666. renderAndExpectNoChanges( renderer, domRoot );
  667. } );
  668. it( 'should handle typing in empty block, render if needed', () => {
  669. const domSelection = document.getSelection();
  670. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  671. viewRoot._appendChild( viewP );
  672. selection._setTo( newSelection );
  673. renderer.markToSync( 'children', viewRoot );
  674. renderer.render();
  675. const domP = domRoot.childNodes[ 0 ];
  676. expect( domP.childNodes.length ).to.equal( 1 );
  677. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  678. expect( domSelection.rangeCount ).to.equal( 1 );
  679. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  680. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  681. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  682. // Add text node only in View <p>x{}</p>
  683. const viewText = new ViewText( 'x' );
  684. viewP._appendChild( viewText );
  685. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  686. renderer.markToSync( 'children', viewP );
  687. renderer.render();
  688. expect( domP.childNodes.length ).to.equal( 1 );
  689. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  690. expect( domSelection.rangeCount ).to.equal( 1 );
  691. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  692. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  693. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  694. } );
  695. it( 'should handle removing last character', () => {
  696. const domSelection = document.getSelection();
  697. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  698. viewRoot._appendChild( viewP );
  699. selection._setTo( newSelection );
  700. renderer.markToSync( 'children', viewRoot );
  701. renderer.render();
  702. const domP = domRoot.childNodes[ 0 ];
  703. expect( domP.childNodes.length ).to.equal( 1 );
  704. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  705. expect( domSelection.rangeCount ).to.equal( 1 );
  706. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  707. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  708. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  709. // Remove text and add filler to both DOM and View <p>{}</p>
  710. domP.removeChild( domP.childNodes[ 0 ] );
  711. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  712. domSelection.removeAllRanges();
  713. const domRange = document.createRange();
  714. domRange.setStart( domP.childNodes[ 0 ], 0 );
  715. domRange.collapse( true );
  716. domSelection.addRange( domRange );
  717. viewP._removeChildren( 0 );
  718. selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  719. renderer.markToSync( 'children', viewP );
  720. renderAndExpectNoChanges( renderer, domRoot );
  721. } );
  722. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  723. const domSelection = document.getSelection();
  724. // 1. Render <p><b>FILLER{}</b>foo</p>.
  725. const { view: viewP, selection: newSelection } = parse(
  726. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  727. viewRoot._appendChild( viewP );
  728. selection._setTo( newSelection );
  729. renderer.markToSync( 'children', viewRoot );
  730. renderer.render();
  731. // 2. Check the DOM.
  732. const domP = domRoot.childNodes[ 0 ];
  733. expect( domP.childNodes.length ).to.equal( 2 );
  734. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  735. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  736. const domB = domP.childNodes[ 0 ];
  737. const viewB = viewP.getChild( 0 );
  738. expect( domB.childNodes.length ).to.equal( 1 );
  739. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  740. expect( domSelection.rangeCount ).to.equal( 1 );
  741. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  742. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  743. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  744. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  745. domB.childNodes[ 0 ].data += 'x';
  746. domSelection.removeAllRanges();
  747. const domRange = document.createRange();
  748. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  749. domRange.collapse( true );
  750. domSelection.addRange( domRange );
  751. const viewText = new ViewText( 'x' );
  752. viewB._appendChild( viewText );
  753. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  754. renderer.markToSync( 'children', viewP );
  755. renderAndExpectNoChanges( renderer, domRoot );
  756. } );
  757. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  758. const domSelection = document.getSelection();
  759. // 1. Render <p><b>FILLER{}</b>foo</p>.
  760. const { view: viewP, selection: newSelection } = parse(
  761. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  762. viewRoot._appendChild( viewP );
  763. selection._setTo( newSelection );
  764. renderer.markToSync( 'children', viewRoot );
  765. renderer.render();
  766. // 2. Check the DOM.
  767. const domP = domRoot.childNodes[ 0 ];
  768. expect( domP.childNodes.length ).to.equal( 2 );
  769. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  770. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  771. const domB = domP.childNodes[ 0 ];
  772. const viewB = viewP.getChild( 0 );
  773. expect( domB.childNodes.length ).to.equal( 1 );
  774. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  775. expect( domSelection.rangeCount ).to.equal( 1 );
  776. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  777. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  778. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  779. domSelection.removeAllRanges();
  780. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  781. const viewText = new ViewText( 'x' );
  782. viewB._appendChild( viewText );
  783. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  784. renderer.markToSync( 'children', viewB );
  785. renderer.render();
  786. expect( domB.childNodes.length ).to.equal( 1 );
  787. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  788. expect( domSelection.rangeCount ).to.equal( 1 );
  789. // Depending on the browser selection may end up at the end of the text node or after the text node.
  790. const firstRange = domSelection.getRangeAt( 0 );
  791. const assertSelectionAtEndOfTextNode = () => {
  792. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  793. };
  794. const assertSelectionInsideTextNode = () => {
  795. expect( firstRange.startContainer ).to.equal( domB );
  796. expect( firstRange.startOffset ).to.equal( 1 );
  797. };
  798. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  799. expect( firstRange.collapsed ).to.be.true;
  800. } );
  801. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  802. const domSelection = document.getSelection();
  803. // 1. Render <p><b>FILLER{}</b>foo</p>.
  804. const { view: viewP, selection: newSelection } = parse(
  805. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  806. viewRoot._appendChild( viewP );
  807. selection._setTo( newSelection );
  808. renderer.markToSync( 'children', viewRoot );
  809. renderer.render();
  810. // 2. Check the DOM.
  811. const domP = domRoot.childNodes[ 0 ];
  812. expect( domP.childNodes.length ).to.equal( 2 );
  813. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  814. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  815. const domB = domP.childNodes[ 0 ];
  816. const viewB = viewP.getChild( 0 );
  817. expect( domB.childNodes.length ).to.equal( 1 );
  818. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  819. expect( domSelection.rangeCount ).to.equal( 1 );
  820. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  821. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  822. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  823. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  824. const viewText = new ViewText( 'x' );
  825. viewB._appendChild( viewText );
  826. selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  827. renderer.markToSync( 'text', viewText );
  828. renderer.render();
  829. // 4. Check the DOM.
  830. expect( domB.childNodes.length ).to.equal( 1 );
  831. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  832. expect( domSelection.rangeCount ).to.equal( 1 );
  833. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  834. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  835. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  836. } );
  837. it( 'should handle not collapsed range', () => {
  838. const domSelection = document.getSelection();
  839. const { view: viewP, selection: newSelection } = parse(
  840. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  841. viewRoot._appendChild( viewP );
  842. selection._setTo( newSelection );
  843. renderer.markToSync( 'children', viewRoot );
  844. renderer.render();
  845. const domP = domRoot.childNodes[ 0 ];
  846. expect( domP.childNodes.length ).to.equal( 2 );
  847. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  848. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  849. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  850. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  851. expect( domSelection.rangeCount ).to.equal( 1 );
  852. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  853. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  854. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  855. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  856. renderer.markToSync( 'children', viewP );
  857. renderAndExpectNoChanges( renderer, domRoot );
  858. } );
  859. it( 'should not change selection if there is no editable with selection', () => {
  860. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  861. document.body.appendChild( domDiv );
  862. domDiv.focus();
  863. const domSelection = document.getSelection();
  864. domSelection.removeAllRanges();
  865. domSelection.collapse( domDiv, 0 );
  866. const viewDiv = new ViewElement( 'div' );
  867. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  868. viewDiv._appendChild( viewP );
  869. selection._setTo( newSelection );
  870. renderer.render();
  871. expect( domSelection.rangeCount ).to.equal( 1 );
  872. // Depending on the browser selection may end up before the text node or at the beginning of it.
  873. const domRange = domSelection.getRangeAt( 0 );
  874. const assertSelectionAtEndOfTextNode = () => {
  875. expect( domRange.startContainer ).to.equal( domDiv );
  876. };
  877. const assertSelectionInsideTextNode = () => {
  878. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  879. };
  880. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  881. expect( domRange.startOffset ).to.equal( 0 );
  882. expect( domRange.collapsed ).to.be.true;
  883. domDiv.remove();
  884. } );
  885. it( 'should not change selection if there is no focus', () => {
  886. const domDiv = createElement( document, 'div', null, 'not editable' );
  887. document.body.appendChild( domDiv );
  888. const domSelection = document.getSelection();
  889. domSelection.removeAllRanges();
  890. const domRange = document.createRange();
  891. domRange.setStart( domDiv, 0 );
  892. domRange.collapse( true );
  893. domSelection.addRange( domRange );
  894. renderer.isFocused = false;
  895. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  896. viewRoot._appendChild( viewP );
  897. selection._setTo( newSelection );
  898. renderer.render();
  899. expect( domSelection.rangeCount ).to.equal( 1 );
  900. // Depending on the browser selection may end up before the text node or at the beginning of it.
  901. const domSelectionRange = domSelection.getRangeAt( 0 );
  902. const assertSelectionAtEndOfTextNode = () => {
  903. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  904. };
  905. const assertSelectionInsideTextNode = () => {
  906. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  907. };
  908. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  909. expect( domSelectionRange.startOffset ).to.equal( 0 );
  910. expect( domSelectionRange.collapsed ).to.be.true;
  911. domDiv.remove();
  912. } );
  913. it( 'should not add inline filler after text node', () => {
  914. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  915. viewRoot._appendChild( viewP );
  916. selection._setTo( newSelection );
  917. renderer.markToSync( 'children', viewRoot );
  918. renderer.render();
  919. const domP = domRoot.childNodes[ 0 ];
  920. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  921. } );
  922. it( 'should throw if there is no filler in expected position', () => {
  923. const { view: viewP, selection: newSelection } = parse(
  924. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  925. viewRoot._appendChild( viewP );
  926. selection._setTo( newSelection );
  927. renderer.markToSync( 'children', viewRoot );
  928. renderer.render();
  929. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  930. const viewB = viewP.getChild( 1 );
  931. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  932. // Remove filler.
  933. domB.childNodes[ 0 ].data = '';
  934. selection._setTo( null );
  935. renderer.markToSync( 'children', viewB );
  936. expect( () => {
  937. renderer.render();
  938. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  939. } );
  940. // #1014.
  941. it( 'should create inline filler in newly created dom nodes', () => {
  942. // 1. Create the view structure which needs inline filler.
  943. const inputView =
  944. '<container:ul>' +
  945. '<container:li>Foobar.</container:li>' +
  946. '<container:li>[]<container:div></container:div></container:li>' +
  947. '</container:ul>';
  948. const { view: view, selection: newSelection } = parse( inputView );
  949. viewRoot._appendChild( view );
  950. selection._setTo( newSelection );
  951. renderer.markToSync( 'children', viewRoot );
  952. renderer.render();
  953. // 2. Check if filler element has been (correctly) created.
  954. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  955. // 3. Move the inline filler parent to a newly created element.
  956. const viewLi = view.getChild( 0 );
  957. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  958. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  959. viewLi._appendChild( viewUl );
  960. // 4. Mark changed items and render the view.
  961. renderer.markToSync( 'children', view );
  962. renderer.markToSync( 'children', viewLi );
  963. renderer.render();
  964. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  965. const domSelection = document.getSelection();
  966. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  967. } );
  968. it( 'should handle focusing element', () => {
  969. selection._setTo( viewRoot, 0 );
  970. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  971. renderer.render();
  972. expect( domFocusSpy.called ).to.be.true;
  973. } );
  974. it( 'should not focus editable if isFocues is set to false', () => {
  975. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  976. renderer.isFocused = false;
  977. renderer.render();
  978. expect( domFocusSpy.calledOnce ).to.be.false;
  979. } );
  980. it( 'should not focus already focused DOM element', () => {
  981. domRoot.setAttribute( 'contentEditable', true );
  982. domRoot.focus();
  983. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  984. renderer.render();
  985. expect( domFocusSpy.called ).to.be.false;
  986. } );
  987. it( 'should render NBSP as first space in inline element after another space', () => {
  988. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  989. viewRoot._appendChild( viewP );
  990. renderer.markToSync( 'children', viewRoot );
  991. renderer.render();
  992. const domP = domRoot.childNodes[ 0 ];
  993. const domB = domP.childNodes[ 1 ];
  994. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  995. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  996. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  997. // Insert space resulting in '<p>x <b> y</b></p>'.
  998. const viewB = viewP.getChild( 1 );
  999. viewB._removeChildren( 0 );
  1000. viewB._appendChild( new ViewText( ' y' ) );
  1001. renderer.markToSync( 'children', viewP );
  1002. renderer.render();
  1003. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1004. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1005. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1006. } );
  1007. it( 'should update sibling after, when node before is removed', () => {
  1008. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1009. viewRoot._appendChild( viewP );
  1010. renderer.markToSync( 'children', viewRoot );
  1011. renderer.render();
  1012. const domP = domRoot.childNodes[ 0 ];
  1013. const domB = domP.childNodes[ 1 ];
  1014. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1015. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1016. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1017. // Remove 'x' resulting in '<p><b> y</b></p>'.
  1018. viewP._removeChildren( 0 );
  1019. renderer.markToSync( 'children', viewP );
  1020. renderer.render();
  1021. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1022. expect( domP.innerHTML ).to.equal( '<b>&nbsp;y</b>' );
  1023. } );
  1024. it( 'should update sibling before, when node after is removed', () => {
  1025. const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
  1026. viewRoot._appendChild( viewP );
  1027. renderer.markToSync( 'children', viewRoot );
  1028. renderer.render();
  1029. const domP = domRoot.childNodes[ 0 ];
  1030. const domB = domP.childNodes[ 1 ];
  1031. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1032. expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
  1033. expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
  1034. // Remove '<b>y</b>' resulting in '<p>x </p>'.
  1035. viewP._removeChildren( 1 );
  1036. renderer.markToSync( 'children', viewP );
  1037. renderer.render();
  1038. expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
  1039. expect( domP.innerHTML ).to.equal( 'x&nbsp;' );
  1040. } );
  1041. // #1093
  1042. it( 'should update siblings after space is inserted in element before - text-element', () => {
  1043. const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
  1044. viewRoot._appendChild( viewP );
  1045. renderer.markToSync( 'children', viewRoot );
  1046. renderer.render();
  1047. const domP = domRoot.childNodes[ 0 ];
  1048. const domB = domP.childNodes[ 1 ];
  1049. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  1050. expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
  1051. expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
  1052. // Insert space resulting in '<p>x <b> y</b></p>'.
  1053. viewP._removeChildren( 0 );
  1054. viewP._insertChild( 0, new ViewText( 'x ' ) );
  1055. renderer.markToSync( 'children', viewP );
  1056. renderer.render();
  1057. expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
  1058. expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1059. expect( domP.innerHTML ).to.equal( 'x <b>&nbsp;y</b>' );
  1060. } );
  1061. // #1093
  1062. it( 'should update siblings after space is inserted in element before - element-text', () => {
  1063. const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
  1064. viewRoot._appendChild( viewP );
  1065. renderer.markToSync( 'children', viewRoot );
  1066. renderer.render();
  1067. const domP = domRoot.childNodes[ 0 ];
  1068. const domB = domP.childNodes[ 0 ];
  1069. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1070. expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
  1071. expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
  1072. // Insert space resulting in '<p><b>x </b> y</p>'.
  1073. const viewB = viewP.getChild( 0 );
  1074. viewB._removeChildren( 0 );
  1075. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1076. renderer.markToSync( 'children', viewP );
  1077. renderer.render();
  1078. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1079. expect( domP.childNodes[ 1 ].data ).to.equal( '\u00A0y' );
  1080. expect( domP.innerHTML ).to.equal( '<b>x </b>&nbsp;y' );
  1081. } );
  1082. // #1093
  1083. it( 'should update siblings after space is inserted in element before - element-element', () => {
  1084. const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
  1085. viewRoot._appendChild( viewP );
  1086. renderer.markToSync( 'children', viewRoot );
  1087. renderer.render();
  1088. const domP = domRoot.childNodes[ 0 ];
  1089. const domB = domP.childNodes[ 0 ];
  1090. const domI = domP.childNodes[ 1 ];
  1091. expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
  1092. expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
  1093. expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
  1094. // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
  1095. const viewB = viewP.getChild( 0 );
  1096. viewB._removeChildren( 0 );
  1097. viewB._insertChild( 0, new ViewText( 'x ' ) );
  1098. renderer.markToSync( 'children', viewP );
  1099. renderer.render();
  1100. expect( domB.childNodes[ 0 ].data ).to.equal( 'x ' );
  1101. expect( domI.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
  1102. expect( domP.innerHTML ).to.equal( '<b>x </b><i>&nbsp;y</i>' );
  1103. } );
  1104. // #1125
  1105. it( 'should properly rerender many changes done in one batch', () => {
  1106. // This test transforms:
  1107. //
  1108. // <h2>He<strong>ding 1</strong></h2>
  1109. // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
  1110. // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
  1111. //
  1112. // into:
  1113. //
  1114. // <h2>Heading 2</h2>
  1115. // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
  1116. // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
  1117. //
  1118. // during one rerender to check if complex structure changes are rerendered correctly.
  1119. const viewContent = parse( '' +
  1120. '<container:h2>He' +
  1121. '<attribute:i>ading 1</attribute:i>' +
  1122. '</container:h2>' +
  1123. '<container:p>Ph ' +
  1124. '<attribute:strong>Bold</attribute:strong> ' +
  1125. '<attribute:i>It' +
  1126. '<attribute:strong>alic</attribute:strong>' +
  1127. '</attribute:i> ' +
  1128. '<attribute:a href="https://ckeditor.com">' +
  1129. '<attribute:strong>Lin</attribute:strong>' +
  1130. 'k</attribute:a>' +
  1131. '</container:p>' +
  1132. '<container:blockquote>' +
  1133. '<container:ul>' +
  1134. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1135. '</container:ul>' +
  1136. '</container:blockquote>' );
  1137. viewRoot._appendChild( viewContent );
  1138. renderer.markToSync( 'children', viewRoot );
  1139. renderer.render();
  1140. // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
  1141. const viewHeading = viewRoot.getChild( 0 );
  1142. viewHeading._removeChildren( 0, viewHeading.childCount );
  1143. viewHeading._insertChild( 0, new ViewText( 'Heading 2' ) );
  1144. // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
  1145. renderer.markToSync( 'children', viewRoot );
  1146. renderer.markToSync( 'children', viewHeading );
  1147. renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
  1148. // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
  1149. // ->
  1150. // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
  1151. const viewP = viewRoot.getChild( 1 );
  1152. viewP._removeChildren( 0, viewP.childCount );
  1153. viewP._insertChild(
  1154. 0,
  1155. parse(
  1156. 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
  1157. '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
  1158. )
  1159. );
  1160. renderer.markToSync( 'children', viewRoot );
  1161. renderer.markToSync( 'children', viewP );
  1162. renderer.markToSync( 'children', viewP.getChild( 1 ) );
  1163. renderer.markToSync( 'children', viewP.getChild( 3 ) );
  1164. renderer.markToSync( 'text', viewP.getChild( 0 ) );
  1165. renderer.markToSync( 'text', viewP.getChild( 2 ) );
  1166. // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
  1167. // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1168. const viewBq = viewRoot.getChild( 2 );
  1169. viewBq._removeChildren( 0, viewBq.childCount );
  1170. viewBq._insertChild(
  1171. 0,
  1172. parse(
  1173. '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
  1174. '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
  1175. )
  1176. );
  1177. renderer.markToSync( 'children', viewRoot );
  1178. renderer.markToSync( 'children', viewBq );
  1179. renderer.markToSync( 'children', viewBq.getChild( 0 ) );
  1180. renderer.markToSync( 'children', viewBq.getChild( 1 ) );
  1181. renderer.render();
  1182. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1183. '<h2>Heading 2</h2>' +
  1184. '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
  1185. '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
  1186. );
  1187. } );
  1188. // #1125
  1189. it( 'should properly rerender changes when whole content replaced at once', () => {
  1190. // This test replaces:
  1191. //
  1192. // <h1>Header</h1>
  1193. // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
  1194. //
  1195. // with:
  1196. //
  1197. // <h2>Header</h2>
  1198. // <p>Not Quoted <strong>item 1</strong> and item 2</p>
  1199. //
  1200. // during one rerender to check if complex structure changes are rerendered correctly.
  1201. const viewContent = parse(
  1202. '<container:h1>Header</container:h1>' +
  1203. '<container:blockquote>' +
  1204. '<container:ul>' +
  1205. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1206. '<container:li>Item 2</container:li>' +
  1207. '</container:ul>' +
  1208. '</container:blockquote>'
  1209. );
  1210. viewRoot._appendChild( viewContent );
  1211. renderer.markToSync( 'children', viewRoot );
  1212. renderer.render();
  1213. const newViewContent = parse(
  1214. '<container:h2>Header</container:h2>' +
  1215. '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
  1216. );
  1217. viewRoot._removeChildren( 0, viewRoot.childCount );
  1218. viewRoot._appendChild( newViewContent );
  1219. renderer.markToSync( 'children', viewRoot );
  1220. renderer.render();
  1221. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
  1222. '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
  1223. );
  1224. } );
  1225. // #1451
  1226. it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
  1227. const inputView =
  1228. '<container:ul>' +
  1229. '<container:li>Foo</container:li>' +
  1230. '<container:li><attribute:b>Bar</attribute:b></container:li>' +
  1231. '</container:ul>';
  1232. const view = parse( inputView );
  1233. viewRoot._appendChild( view );
  1234. renderer.markToSync( 'children', viewRoot );
  1235. renderer.render();
  1236. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
  1237. const viewLi = view.getChild( 0 );
  1238. const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
  1239. viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
  1240. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  1241. viewLi._appendChild( viewUl );
  1242. renderer.markToSync( 'children', view );
  1243. renderer.markToSync( 'children', viewLi );
  1244. renderer.render();
  1245. expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
  1246. } );
  1247. // #1439
  1248. it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
  1249. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1250. testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
  1251. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1252. // <p>foo<br/>[]</p>
  1253. const { view: viewP, selection: newSelection } = parse(
  1254. '<container:p>' +
  1255. 'foo[]' +
  1256. '<empty:br></empty:br>[]' +
  1257. '</container:p>' );
  1258. viewRoot._appendChild( viewP );
  1259. selection._setTo( newSelection );
  1260. renderer.markToSync( 'children', viewRoot );
  1261. renderer.render();
  1262. sinon.assert.notCalled( spy );
  1263. } );
  1264. // #1439
  1265. it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
  1266. const domSelection = domRoot.ownerDocument.defaultView.getSelection();
  1267. testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
  1268. const spy = testUtils.sinon.stub( domSelection, 'addRange' );
  1269. // <p>foo[]<b>bar</b></p>
  1270. let { view: viewP, selection: newSelection } = parse(
  1271. '<container:p>' +
  1272. 'foo[]' +
  1273. '<attribute:b>bar</attribute:b>' +
  1274. '</container:p>' );
  1275. viewRoot._appendChild( viewP );
  1276. selection._setTo( newSelection );
  1277. renderer.markToSync( 'children', viewRoot );
  1278. renderer.render();
  1279. sinon.assert.notCalled( spy );
  1280. // <p>foo<b>bar</b></p><p>foo[]<br/></p>
  1281. ( { view: viewP, selection: newSelection } = parse(
  1282. '<container:p>' +
  1283. 'foo[]' +
  1284. '<empty:br></empty:br>' +
  1285. '</container:p>' ) );
  1286. viewRoot._appendChild( viewP );
  1287. selection._setTo( newSelection );
  1288. renderer.markToSync( 'children', viewRoot );
  1289. renderer.render();
  1290. sinon.assert.notCalled( spy );
  1291. // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
  1292. selection._setTo( [
  1293. new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
  1294. ] );
  1295. renderer.markToSync( 'children', viewRoot );
  1296. renderer.render();
  1297. sinon.assert.calledOnce( spy );
  1298. } );
  1299. describe( 'fake selection', () => {
  1300. beforeEach( () => {
  1301. const { view: viewP, selection: newSelection } = parse(
  1302. '<container:p>[foo bar]</container:p>'
  1303. );
  1304. viewRoot._appendChild( viewP );
  1305. selection._setTo( newSelection );
  1306. renderer.markToSync( 'children', viewRoot );
  1307. renderer.render();
  1308. } );
  1309. it( 'should render fake selection', () => {
  1310. const label = 'fake selection label';
  1311. selection._setTo( selection.getRanges(), { fake: true, label } );
  1312. renderer.render();
  1313. expect( domRoot.childNodes.length ).to.equal( 2 );
  1314. const container = domRoot.childNodes[ 1 ];
  1315. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1316. expect( container.childNodes.length ).to.equal( 1 );
  1317. const textNode = container.childNodes[ 0 ];
  1318. expect( textNode.textContent ).to.equal( label );
  1319. const domSelection = domRoot.ownerDocument.getSelection();
  1320. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1321. } );
  1322. it( 'should render &nbsp; if no selection label is provided', () => {
  1323. selection._setTo( selection.getRanges(), { fake: true } );
  1324. renderer.render();
  1325. expect( domRoot.childNodes.length ).to.equal( 2 );
  1326. const container = domRoot.childNodes[ 1 ];
  1327. expect( container.childNodes.length ).to.equal( 1 );
  1328. const textNode = container.childNodes[ 0 ];
  1329. expect( textNode.textContent ).to.equal( '\u00A0' );
  1330. const domSelection = domRoot.ownerDocument.getSelection();
  1331. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1332. } );
  1333. it( 'should remove fake selection container when selection is no longer fake', () => {
  1334. selection._setTo( selection.getRanges(), { fake: true } );
  1335. renderer.render();
  1336. selection._setTo( selection.getRanges(), { fake: false } );
  1337. renderer.render();
  1338. expect( domRoot.childNodes.length ).to.equal( 1 );
  1339. const domParagraph = domRoot.childNodes[ 0 ];
  1340. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1341. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1342. const domSelection = domRoot.ownerDocument.getSelection();
  1343. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1344. } );
  1345. it( 'should reuse fake selection container #1', () => {
  1346. const label = 'fake selection label';
  1347. selection._setTo( selection.getRanges(), { fake: true, label } );
  1348. renderer.render();
  1349. expect( domRoot.childNodes.length ).to.equal( 2 );
  1350. const container = domRoot.childNodes[ 1 ];
  1351. selection._setTo( selection.getRanges(), { fake: true, label } );
  1352. renderer.render();
  1353. expect( domRoot.childNodes.length ).to.equal( 2 );
  1354. const newContainer = domRoot.childNodes[ 1 ];
  1355. expect( newContainer ).equals( container );
  1356. expect( newContainer.childNodes.length ).to.equal( 1 );
  1357. const textNode = newContainer.childNodes[ 0 ];
  1358. expect( textNode.textContent ).to.equal( label );
  1359. } );
  1360. it( 'should reuse fake selection container #2', () => {
  1361. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1362. renderer.render();
  1363. expect( domRoot.childNodes.length ).to.equal( 2 );
  1364. const container = domRoot.childNodes[ 1 ];
  1365. selection._setTo( selection.getRanges(), { fake: false } );
  1366. renderer.render();
  1367. expect( domRoot.childNodes.length ).to.equal( 1 );
  1368. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1369. renderer.render();
  1370. expect( domRoot.childNodes.length ).to.equal( 2 );
  1371. const newContainer = domRoot.childNodes[ 1 ];
  1372. expect( newContainer ).equals( container );
  1373. expect( newContainer.childNodes.length ).to.equal( 1 );
  1374. const textNode = newContainer.childNodes[ 0 ];
  1375. expect( textNode.textContent ).to.equal( 'label 2' );
  1376. } );
  1377. it( 'should reuse fake selection container #3', () => {
  1378. selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
  1379. renderer.render();
  1380. expect( domRoot.childNodes.length ).to.equal( 2 );
  1381. const container = domRoot.childNodes[ 1 ];
  1382. selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
  1383. renderer.render();
  1384. expect( domRoot.childNodes.length ).to.equal( 2 );
  1385. const newContainer = domRoot.childNodes[ 1 ];
  1386. expect( newContainer ).equals( container );
  1387. expect( newContainer.childNodes.length ).to.equal( 1 );
  1388. const textNode = newContainer.childNodes[ 0 ];
  1389. expect( textNode.textContent ).to.equal( 'label 2' );
  1390. } );
  1391. it( 'should style fake selection container properly', () => {
  1392. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1393. renderer.render();
  1394. expect( domRoot.childNodes.length ).to.equal( 2 );
  1395. const container = domRoot.childNodes[ 1 ];
  1396. expect( container.style.position ).to.equal( 'fixed' );
  1397. expect( container.style.top ).to.equal( '0px' );
  1398. expect( container.style.left ).to.equal( '-9999px' );
  1399. } );
  1400. it( 'should move fake selection container between editables', () => {
  1401. const viewEditable = new ViewEditableElement( 'div' );
  1402. viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
  1403. const domEditable = document.createElement( 'div' );
  1404. document.body.appendChild( domEditable );
  1405. domConverter.bindElements( domEditable, viewEditable );
  1406. renderer.markToSync( 'children', viewEditable );
  1407. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1408. renderer.render();
  1409. let container = document.getSelection().anchorNode;
  1410. expect( domRoot.contains( container ) ).to.be.true;
  1411. selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
  1412. renderer.render();
  1413. container = document.getSelection().anchorNode;
  1414. expect( domEditable.contains( container ) ).to.be.true;
  1415. } );
  1416. it( 'should bind fake selection container to view selection', () => {
  1417. selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
  1418. renderer.render();
  1419. expect( domRoot.childNodes.length ).to.equal( 2 );
  1420. const container = domRoot.childNodes[ 1 ];
  1421. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1422. expect( bindSelection ).to.not.be.undefined;
  1423. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1424. } );
  1425. // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
  1426. it( 'should handle situation when label got removed from the fake selection container', () => {
  1427. const label = 'fake selection label';
  1428. selection._setTo( selection.getRanges(), { fake: true, label } );
  1429. renderer.render();
  1430. expect( domRoot.childNodes.length ).to.equal( 2 );
  1431. const container = domRoot.childNodes[ 1 ];
  1432. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  1433. expect( container.childNodes.length ).to.equal( 1 );
  1434. const textNode = container.childNodes[ 0 ];
  1435. expect( textNode.textContent ).to.equal( label );
  1436. // Remove a text node (label) from the fake selection container.
  1437. // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
  1438. textNode.remove();
  1439. renderer.render();
  1440. const domSelection = domRoot.ownerDocument.getSelection();
  1441. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  1442. } );
  1443. // Use a forgiving way of checking what the selection contains
  1444. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1445. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1446. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1447. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1448. expect( domSelection.toString() ).to.match( expectedText );
  1449. expect(
  1450. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1451. ).to.be.true;
  1452. }
  1453. } );
  1454. // #887
  1455. describe( 'similar selection', () => {
  1456. // Use spies to check selection updates. Some selection positions are not achievable in some
  1457. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1458. let selectionCollapseSpy, selectionExtendSpy;
  1459. afterEach( () => {
  1460. if ( selectionCollapseSpy ) {
  1461. selectionCollapseSpy.restore();
  1462. selectionCollapseSpy = null;
  1463. }
  1464. if ( selectionExtendSpy ) {
  1465. selectionExtendSpy.restore();
  1466. selectionExtendSpy = null;
  1467. }
  1468. } );
  1469. it( 'should always render collapsed selection even if it is similar', () => {
  1470. const domSelection = document.getSelection();
  1471. const { view: viewP, selection: newSelection } = parse(
  1472. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1473. viewRoot._appendChild( viewP );
  1474. selection._setTo( newSelection );
  1475. renderer.markToSync( 'children', viewRoot );
  1476. renderer.render();
  1477. const domP = domRoot.childNodes[ 0 ];
  1478. const domB = domP.childNodes[ 1 ];
  1479. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1480. expect( domSelection.isCollapsed ).to.true;
  1481. expect( domSelection.rangeCount ).to.equal( 1 );
  1482. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1483. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1484. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1485. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1486. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1487. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1488. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1489. selection._setTo( [
  1490. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1491. ] );
  1492. renderer.markToSync( 'children', viewP );
  1493. renderer.render();
  1494. expect( selectionCollapseSpy.calledOnce ).to.true;
  1495. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1496. expect( selectionExtendSpy.calledOnce ).to.true;
  1497. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1498. } );
  1499. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1500. const domSelection = document.getSelection();
  1501. const { view: viewP, selection: newSelection } = parse(
  1502. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1503. viewRoot._appendChild( viewP );
  1504. selection._setTo( newSelection );
  1505. renderer.markToSync( 'children', viewRoot );
  1506. renderer.render();
  1507. const domP = domRoot.childNodes[ 0 ];
  1508. const domB = domP.childNodes[ 1 ];
  1509. expect( domSelection.isCollapsed ).to.true;
  1510. expect( domSelection.rangeCount ).to.equal( 1 );
  1511. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1512. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1513. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1514. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1515. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1516. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1517. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1518. selection._setTo( [
  1519. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1520. ] );
  1521. renderer.markToSync( 'children', viewP );
  1522. renderer.render();
  1523. expect( selectionCollapseSpy.calledOnce ).to.true;
  1524. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1525. expect( selectionExtendSpy.calledOnce ).to.true;
  1526. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1527. } );
  1528. it( 'should always render non-collapsed selection if it not is similar', () => {
  1529. const domSelection = document.getSelection();
  1530. const { view: viewP, selection: newSelection } = parse(
  1531. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1532. viewRoot._appendChild( viewP );
  1533. selection._setTo( newSelection );
  1534. renderer.markToSync( 'children', viewRoot );
  1535. renderer.render();
  1536. const domP = domRoot.childNodes[ 0 ];
  1537. const domB = domP.childNodes[ 1 ];
  1538. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1539. expect( domSelection.isCollapsed ).to.false;
  1540. expect( domSelection.rangeCount ).to.equal( 1 );
  1541. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1542. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1543. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1544. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1545. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1546. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1547. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1548. selection._setTo( [
  1549. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1550. ] );
  1551. renderer.markToSync( 'children', viewP );
  1552. renderer.render();
  1553. expect( selectionCollapseSpy.calledOnce ).to.true;
  1554. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1555. expect( selectionExtendSpy.calledOnce ).to.true;
  1556. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1557. } );
  1558. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1559. const domSelection = document.getSelection();
  1560. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1561. viewRoot._appendChild( viewP );
  1562. selection._setTo( newSelection );
  1563. renderer.markToSync( 'children', viewRoot );
  1564. renderer.render();
  1565. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1566. // Do not change view selection.
  1567. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1568. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1569. // because DOM selection is in incorrect place.
  1570. const domP = domRoot.childNodes[ 0 ];
  1571. const domSpan = domP.childNodes[ 1 ];
  1572. domSelection.collapse( domSpan, 0 );
  1573. renderer.render();
  1574. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1575. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1576. const assertSelectionAtEndOfTextNode = () => {
  1577. expect( domSelection.anchorNode ).to.equal( domP );
  1578. expect( domSelection.anchorOffset ).to.equal( 1 );
  1579. };
  1580. const assertSelectionInsideTextNode = () => {
  1581. const textNode = domP.childNodes[ 0 ];
  1582. expect( domSelection.anchorNode ).to.equal( textNode );
  1583. expect( domSelection.anchorOffset ).to.equal( 3 );
  1584. };
  1585. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1586. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1587. } );
  1588. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1589. const domSelection = document.getSelection();
  1590. const { view: viewP, selection: newSelection } = parse(
  1591. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1592. viewRoot._appendChild( viewP );
  1593. selection._setTo( newSelection );
  1594. renderer.markToSync( 'children', viewRoot );
  1595. renderer.render();
  1596. const domP = domRoot.childNodes[ 0 ];
  1597. const domB = domP.childNodes[ 1 ];
  1598. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1599. expect( domSelection.isCollapsed ).to.false;
  1600. expect( domSelection.rangeCount ).to.equal( 1 );
  1601. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1602. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1603. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1604. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1605. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1606. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1607. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1608. selection._setTo( [
  1609. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1610. ] );
  1611. renderer.markToSync( 'children', viewP );
  1612. renderer.render();
  1613. expect( selectionCollapseSpy.notCalled ).to.true;
  1614. expect( selectionExtendSpy.notCalled ).to.true;
  1615. } );
  1616. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1617. const domSelection = document.getSelection();
  1618. const { view: viewP, selection: newSelection } = parse(
  1619. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1620. viewRoot._appendChild( viewP );
  1621. selection._setTo( newSelection );
  1622. renderer.markToSync( 'children', viewRoot );
  1623. renderer.render();
  1624. const domP = domRoot.childNodes[ 0 ];
  1625. const domB = domP.childNodes[ 1 ];
  1626. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1627. expect( domSelection.isCollapsed ).to.false;
  1628. expect( domSelection.rangeCount ).to.equal( 1 );
  1629. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1630. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1631. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1632. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1633. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1634. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1635. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1636. selection._setTo( [
  1637. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1638. ] );
  1639. renderer.markToSync( 'children', viewP );
  1640. renderer.render();
  1641. expect( selectionCollapseSpy.notCalled ).to.true;
  1642. expect( selectionExtendSpy.notCalled ).to.true;
  1643. } );
  1644. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1645. const domSelection = document.getSelection();
  1646. const { view: viewP, selection: newSelection } = parse(
  1647. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1648. viewRoot._appendChild( viewP );
  1649. selection._setTo( newSelection );
  1650. renderer.markToSync( 'children', viewRoot );
  1651. renderer.render();
  1652. const domP = domRoot.childNodes[ 0 ];
  1653. const domB = domP.childNodes[ 1 ];
  1654. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1655. expect( domSelection.isCollapsed ).to.false;
  1656. expect( domSelection.rangeCount ).to.equal( 1 );
  1657. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1658. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1659. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1660. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1661. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1662. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1663. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1664. selection._setTo( [
  1665. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1666. ] );
  1667. renderer.markToSync( 'children', viewP );
  1668. renderer.render();
  1669. expect( selectionCollapseSpy.notCalled ).to.true;
  1670. expect( selectionExtendSpy.notCalled ).to.true;
  1671. } );
  1672. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1673. const domSelection = document.getSelection();
  1674. const { view: viewP, selection: newSelection } = parse(
  1675. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1676. viewRoot._appendChild( viewP );
  1677. selection._setTo( newSelection );
  1678. renderer.markToSync( 'children', viewRoot );
  1679. renderer.render();
  1680. const domP = domRoot.childNodes[ 0 ];
  1681. const domB = domP.childNodes[ 1 ];
  1682. expect( domSelection.isCollapsed ).to.false;
  1683. expect( domSelection.rangeCount ).to.equal( 1 );
  1684. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1685. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1686. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1687. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1688. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1689. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1690. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1691. selection._setTo( [
  1692. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1693. ] );
  1694. renderer.markToSync( 'children', viewP );
  1695. renderer.render();
  1696. expect( selectionCollapseSpy.notCalled ).to.true;
  1697. expect( selectionExtendSpy.notCalled ).to.true;
  1698. } );
  1699. } );
  1700. // #1417
  1701. describe( 'optimal rendering – reusing existing nodes', () => {
  1702. it( 'should render inline element replacement (before text)', () => {
  1703. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1704. renderer.markToSync( 'children', viewRoot );
  1705. renderer.render();
  1706. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1707. const viewP = viewRoot.getChild( 0 );
  1708. viewP._removeChildren( 0, 2 );
  1709. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1710. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1711. renderer.markToSync( 'children', viewRoot );
  1712. renderer.markToSync( 'children', viewP );
  1713. renderer.render();
  1714. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1715. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1716. } );
  1717. it( 'should render inline element replacement (after text)', () => {
  1718. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1719. renderer.markToSync( 'children', viewRoot );
  1720. renderer.render();
  1721. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1722. const viewP = viewRoot.getChild( 0 );
  1723. viewP._removeChildren( 0, 2 );
  1724. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1725. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1726. renderer.markToSync( 'children', viewRoot );
  1727. renderer.markToSync( 'children', viewP );
  1728. renderer.render();
  1729. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1730. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1731. } );
  1732. it( 'should render inline element replacement (before text swapped order)', () => {
  1733. viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
  1734. renderer.markToSync( 'children', viewRoot );
  1735. renderer.render();
  1736. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
  1737. const viewP = viewRoot.getChild( 0 );
  1738. viewP._removeChildren( 0, 2 );
  1739. viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
  1740. const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
  1741. renderer.markToSync( 'children', viewRoot );
  1742. renderer.markToSync( 'children', viewP );
  1743. renderer.render();
  1744. expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
  1745. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
  1746. } );
  1747. it( 'should render inline element replacement (after text swapped order)', () => {
  1748. viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
  1749. renderer.markToSync( 'children', viewRoot );
  1750. renderer.render();
  1751. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
  1752. const viewP = viewRoot.getChild( 0 );
  1753. viewP._removeChildren( 0, 2 );
  1754. viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
  1755. const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  1756. renderer.markToSync( 'children', viewRoot );
  1757. renderer.markToSync( 'children', viewP );
  1758. renderer.render();
  1759. expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
  1760. expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
  1761. } );
  1762. it( 'should render single replacement in p group', () => {
  1763. const content = '' +
  1764. '<container:p>1</container:p>' +
  1765. '<container:p>2</container:p>' +
  1766. '<container:p>3</container:p>';
  1767. viewRoot._appendChild( parse( content ) );
  1768. renderer.markToSync( 'children', viewRoot );
  1769. renderer.render();
  1770. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
  1771. viewRoot._removeChildren( 1 );
  1772. viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
  1773. const domP = domRoot.childNodes[ 1 ];
  1774. renderer.markToSync( 'children', viewRoot );
  1775. renderer.render();
  1776. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
  1777. expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
  1778. } );
  1779. it( 'should render replacement and insertion in p group', () => {
  1780. const content = '' +
  1781. '<container:p>1<attribute:i>A</attribute:i></container:p>' +
  1782. '<container:p>2<attribute:i>B</attribute:i></container:p>' +
  1783. '<container:p>3<attribute:i>C</attribute:i></container:p>';
  1784. const replacement = '' +
  1785. '<container:p><attribute:i>D</attribute:i></container:p>' +
  1786. '<container:p>5<attribute:i>E</attribute:i></container:p>';
  1787. viewRoot._appendChild( parse( content ) );
  1788. renderer.markToSync( 'children', viewRoot );
  1789. renderer.render();
  1790. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
  1791. viewRoot._removeChildren( 1 );
  1792. viewRoot._insertChild( 1, parse( replacement ) );
  1793. const domP2 = domRoot.childNodes[ 1 ];
  1794. const domP3 = domRoot.childNodes[ 2 ];
  1795. renderer.markToSync( 'children', viewRoot );
  1796. renderer.render();
  1797. expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
  1798. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1799. expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
  1800. } );
  1801. it( 'should render replacement and deletion in p group', () => {
  1802. const content = '' +
  1803. '<container:p><attribute:i>A</attribute:i>1</container:p>' +
  1804. '<container:p><attribute:i>B</attribute:i>2</container:p>' +
  1805. '<container:p><attribute:i>C</attribute:i>3</container:p>';
  1806. viewRoot._appendChild( parse( content ) );
  1807. renderer.markToSync( 'children', viewRoot );
  1808. renderer.render();
  1809. expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
  1810. viewRoot._removeChildren( 0, 2 );
  1811. viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
  1812. const domP0 = domRoot.childNodes[ 0 ];
  1813. const domP2 = domRoot.childNodes[ 2 ];
  1814. renderer.markToSync( 'children', viewRoot );
  1815. renderer.render();
  1816. expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
  1817. expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
  1818. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1819. } );
  1820. it( 'should render multiple continuous replacement in p group', () => {
  1821. const content = '' +
  1822. '<container:p>1</container:p>' +
  1823. '<container:p>2</container:p>' +
  1824. '<container:p>3</container:p>' +
  1825. '<container:p>4</container:p>' +
  1826. '<container:p>5</container:p>';
  1827. viewRoot._appendChild( parse( content ) );
  1828. renderer.markToSync( 'children', viewRoot );
  1829. renderer.render();
  1830. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1831. viewRoot._removeChildren( 0, 3 );
  1832. viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
  1833. const domP1 = domRoot.childNodes[ 0 ];
  1834. const domP2 = domRoot.childNodes[ 1 ];
  1835. const domP4 = domRoot.childNodes[ 3 ];
  1836. const domP5 = domRoot.childNodes[ 4 ];
  1837. renderer.markToSync( 'children', viewRoot );
  1838. renderer.render();
  1839. expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
  1840. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1841. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1842. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1843. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1844. } );
  1845. it( 'should render multiple replacement in p group', () => {
  1846. const content = '' +
  1847. '<container:p>1</container:p>' +
  1848. '<container:p>2</container:p>' +
  1849. '<container:p>3</container:p>' +
  1850. '<container:p>4</container:p>' +
  1851. '<container:p>5</container:p>';
  1852. viewRoot._appendChild( parse( content ) );
  1853. renderer.markToSync( 'children', viewRoot );
  1854. renderer.render();
  1855. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
  1856. viewRoot._removeChildren( 4 );
  1857. viewRoot._removeChildren( 1, 2 );
  1858. viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
  1859. viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
  1860. const domP1 = domRoot.childNodes[ 0 ];
  1861. const domP2 = domRoot.childNodes[ 1 ];
  1862. const domP4 = domRoot.childNodes[ 3 ];
  1863. const domP5 = domRoot.childNodes[ 4 ];
  1864. renderer.markToSync( 'children', viewRoot );
  1865. renderer.render();
  1866. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
  1867. expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
  1868. expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
  1869. expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
  1870. expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
  1871. } );
  1872. it( 'should not rerender DOM when view replaced with the same structure', () => {
  1873. const content = '' +
  1874. '<container:h2>He' +
  1875. '<attribute:i>ading 1</attribute:i>' +
  1876. '</container:h2>' +
  1877. '<container:p>Ph ' +
  1878. '<attribute:strong>Bold</attribute:strong>' +
  1879. '<attribute:a href="https://ckeditor.com">' +
  1880. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1881. '</attribute:a>' +
  1882. '</container:p>' +
  1883. '<container:blockquote>' +
  1884. '<container:ul>' +
  1885. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1886. '</container:ul>' +
  1887. '</container:blockquote>';
  1888. viewRoot._appendChild( parse( content ) );
  1889. renderer.markToSync( 'children', viewRoot );
  1890. renderer.render();
  1891. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1892. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1893. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1894. viewRoot._removeChildren( 0, viewRoot.childCount );
  1895. viewRoot._appendChild( parse( content ) );
  1896. const viewH = viewRoot.getChild( 0 );
  1897. const viewP = viewRoot.getChild( 1 );
  1898. const viewQ = viewRoot.getChild( 2 );
  1899. const domH = domRoot.childNodes[ 0 ];
  1900. const domHI = domH.childNodes[ 1 ];
  1901. const domP = domRoot.childNodes[ 1 ];
  1902. const domPT = domP.childNodes[ 0 ];
  1903. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1904. const domQ = domRoot.childNodes[ 2 ];
  1905. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1906. renderer.markToSync( 'children', viewRoot );
  1907. renderer.render();
  1908. // Assert content.
  1909. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1910. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1911. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1912. // Assert if DOM elements did not change.
  1913. expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
  1914. expect( domH.childNodes[ 1 ] ).to.equal( domHI );
  1915. expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
  1916. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1917. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1918. expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
  1919. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1920. // Assert mappings.
  1921. const mappings = renderer.domConverter._domToViewMapping;
  1922. expect( mappings.get( domH ) ).to.equal( viewH );
  1923. expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
  1924. expect( mappings.get( domP ) ).to.equal( viewP );
  1925. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1926. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1927. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1928. } );
  1929. it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
  1930. const content = '' +
  1931. '<container:h2>He' +
  1932. '<attribute:i>ading 1</attribute:i>' +
  1933. '</container:h2>' +
  1934. '<container:p>Ph ' +
  1935. '<attribute:strong>Bold</attribute:strong>' +
  1936. '<attribute:a href="https://ckeditor.com">' +
  1937. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1938. '</attribute:a>' +
  1939. '</container:p>' +
  1940. '<container:blockquote>' +
  1941. '<container:ul>' +
  1942. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1943. '</container:ul>' +
  1944. '</container:blockquote>';
  1945. const content2 = '' +
  1946. '<container:p>Ph ' +
  1947. '<attribute:strong>Bold</attribute:strong>' +
  1948. '<attribute:a href="https://ckeditor.com">' +
  1949. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  1950. '</attribute:a>' +
  1951. '</container:p>' +
  1952. '<container:blockquote>' +
  1953. '<container:ul>' +
  1954. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  1955. '</container:ul>' +
  1956. '</container:blockquote>';
  1957. viewRoot._appendChild( parse( content ) );
  1958. renderer.markToSync( 'children', viewRoot );
  1959. renderer.render();
  1960. expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
  1961. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1962. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1963. viewRoot._removeChildren( 0, viewRoot.childCount );
  1964. viewRoot._appendChild( parse( content2 ) );
  1965. const viewP = viewRoot.getChild( 0 );
  1966. const viewQ = viewRoot.getChild( 1 );
  1967. const domP = domRoot.childNodes[ 1 ];
  1968. const domPT = domP.childNodes[ 0 ];
  1969. const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
  1970. const domQ = domRoot.childNodes[ 2 ];
  1971. const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
  1972. renderer.markToSync( 'children', viewRoot );
  1973. renderer.render();
  1974. // Assert content.
  1975. expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
  1976. '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
  1977. 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
  1978. // Assert if DOM elements did not change.
  1979. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  1980. expect( domP.childNodes[ 0 ] ).to.equal( domPT );
  1981. expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
  1982. expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
  1983. expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
  1984. // Assert mappings.
  1985. const mappings = renderer.domConverter._domToViewMapping;
  1986. expect( mappings.get( domP ) ).to.equal( viewP );
  1987. expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
  1988. expect( mappings.get( domQ ) ).to.equal( viewQ );
  1989. expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  1990. } );
  1991. it( 'should not rerender DOM when typing inside empty inline element', () => {
  1992. const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
  1993. viewRoot._appendChild( view );
  1994. renderer.markToSync( 'children', viewRoot );
  1995. renderer.render();
  1996. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
  1997. const viewP = viewRoot.getChild( 0 );
  1998. viewP._removeChildren( 1 );
  1999. viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
  2000. const domP = domRoot.childNodes[ 0 ];
  2001. const domText = domP.childNodes[ 0 ];
  2002. const domB = domP.childNodes[ 1 ];
  2003. domB.innerHTML = 'a';
  2004. renderer.markToSync( 'children', viewRoot );
  2005. renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
  2006. renderer.render();
  2007. // Assert content.
  2008. expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
  2009. // Assert if DOM elements did not change.
  2010. expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
  2011. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
  2012. expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
  2013. // Assert mappings.
  2014. const mappings = renderer.domConverter._domToViewMapping;
  2015. expect( mappings.get( domP ) ).to.equal( viewP );
  2016. expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
  2017. } );
  2018. it( 'should handle complex view duplication', () => {
  2019. const content = '' +
  2020. '<container:blockquote>' +
  2021. '<container:ul>' +
  2022. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2023. '<container:li>Item 2</container:li>' +
  2024. '<container:li>' +
  2025. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2026. '</container:li>' +
  2027. '</container:ul>' +
  2028. '</container:blockquote>';
  2029. const expected = '' +
  2030. '<blockquote>' +
  2031. '<ul>' +
  2032. '<li>Quoted <strong>item 1</strong></li>' +
  2033. '<li>Item 2</li>' +
  2034. '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2035. '</ul>' +
  2036. '</blockquote>';
  2037. viewRoot._appendChild( parse( content ) );
  2038. renderer.markToSync( 'children', viewRoot );
  2039. renderer.render();
  2040. expect( domRoot.innerHTML ).to.equal( expected );
  2041. viewRoot._removeChildren( 0, viewRoot.childCount );
  2042. viewRoot._appendChild( parse( content + content ) );
  2043. const domBQ = domRoot.childNodes[ 0 ];
  2044. const domUL = domBQ.childNodes[ 0 ];
  2045. const domLI1 = domUL.childNodes[ 0 ];
  2046. const domLI2 = domUL.childNodes[ 1 ];
  2047. const domLI3 = domUL.childNodes[ 2 ];
  2048. renderer.markToSync( 'children', viewRoot );
  2049. renderer.render();
  2050. // Assert content.
  2051. expect( domRoot.innerHTML ).to.equal( expected + expected );
  2052. // Assert if DOM elements did not change.
  2053. expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
  2054. expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
  2055. expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
  2056. expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
  2057. expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
  2058. // Assert mappings.
  2059. const domMappings = renderer.domConverter._domToViewMapping;
  2060. expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
  2061. expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
  2062. expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
  2063. expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
  2064. expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
  2065. // Assert if new view elements are bind to new DOM elements.
  2066. const viewMappings = renderer.domConverter._domToViewMapping;
  2067. expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
  2068. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
  2069. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
  2070. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
  2071. expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
  2072. } );
  2073. it( 'should handle complex view replace', () => {
  2074. const content = '' +
  2075. '<container:h2>He' +
  2076. '<attribute:i>ading 1</attribute:i>' +
  2077. '</container:h2>' +
  2078. '<container:p>Ph ' +
  2079. '<attribute:strong>Bold</attribute:strong>' +
  2080. '<attribute:a href="https://ckeditor.com">' +
  2081. '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
  2082. '</attribute:a>' +
  2083. '</container:p>' +
  2084. '<container:blockquote>' +
  2085. '<container:ul>' +
  2086. '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
  2087. '<container:li>Item 2</container:li>' +
  2088. '<container:li>' +
  2089. '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
  2090. '</container:li>' +
  2091. '</container:ul>' +
  2092. '</container:blockquote>';
  2093. const replacement = '' +
  2094. '<container:p>' +
  2095. '1' +
  2096. '<attribute:i>A</attribute:i>' +
  2097. '</container:p>' +
  2098. '<container:p>' +
  2099. '<attribute:a href="https://cksource.com">' +
  2100. 'Li' +
  2101. '<attribute:strong>nk</attribute:strong>' +
  2102. '</attribute:a>' +
  2103. '</container:p>' +
  2104. '<container:h1>' +
  2105. 'Heading ' +
  2106. '<attribute:strong>1</attribute:strong>' +
  2107. '</container:h1>' +
  2108. '<container:h2>' +
  2109. '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
  2110. '</container:h2>' +
  2111. '<container:h3>' +
  2112. 'Heading' +
  2113. '<attribute:i> 3</attribute:i>' +
  2114. '</container:h3>' +
  2115. '<container:blockquote>' +
  2116. 'Foo Bar Baz' +
  2117. '</container:blockquote>' +
  2118. '<container:ul>' +
  2119. '<container:li>' +
  2120. 'Item ' +
  2121. '<attribute:strong>1</attribute:strong>' +
  2122. '</container:li>' +
  2123. '<container:li>' +
  2124. '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
  2125. ' 2' +
  2126. '</container:li>' +
  2127. '</container:ul>';
  2128. viewRoot._appendChild( parse( content ) );
  2129. renderer.markToSync( 'children', viewRoot );
  2130. renderer.render();
  2131. expect( domRoot.innerHTML ).to.equal( '' +
  2132. '<h2>He<i>ading 1</i></h2>' +
  2133. '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
  2134. '<blockquote><ul>' +
  2135. '<li>Quoted <strong>item 1</strong></li>' +
  2136. '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
  2137. '</ul></blockquote>' );
  2138. viewRoot._removeChildren( 0, viewRoot.childCount );
  2139. viewRoot._appendChild( parse( replacement ) );
  2140. renderer.markToSync( 'children', viewRoot );
  2141. renderer.render();
  2142. // Here we just check if new DOM structure was properly rendered.
  2143. expect( domRoot.innerHTML ).to.equal( '' +
  2144. '<p>1<i>A</i></p>' +
  2145. '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
  2146. '<h1>Heading <strong>1</strong></h1>' +
  2147. '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
  2148. '<h3>Heading<i> 3</i></h3>' +
  2149. '<blockquote>Foo Bar Baz</blockquote>' +
  2150. '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
  2151. } );
  2152. it( 'should handle br elements while refreshing bindings', () => {
  2153. const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
  2154. viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
  2155. renderer.markToSync( 'children', viewRoot );
  2156. renderer.render();
  2157. expect( domRoot.innerHTML ).to.equal( expected );
  2158. // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
  2159. // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
  2160. // refreshing mappings in a renderer. Simulate such behaviour (#1354).
  2161. domRoot.childNodes[ 1 ].innerHTML = '<br>';
  2162. viewRoot._removeChildren( 1 );
  2163. viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
  2164. renderer.markToSync( 'children', viewRoot );
  2165. renderer.render();
  2166. expect( domRoot.innerHTML ).to.equal( expected );
  2167. } );
  2168. it( 'should handle list to paragraph conversion', () => {
  2169. const view = '' +
  2170. '<container:ol>' +
  2171. '<container:li>Item 1' +
  2172. '<container:ol>' +
  2173. '<container:li>Item 2</container:li>' +
  2174. '</container:ol>' +
  2175. '</container:li>' +
  2176. '</container:ol>' +
  2177. '<container:p>Paragraph</container:p>' +
  2178. '<container:ol>' +
  2179. '<container:li>Item 3' +
  2180. '<container:ol>' +
  2181. '<container:li>Item 4</container:li>' +
  2182. '</container:ol>' +
  2183. '</container:li>' +
  2184. '</container:ol>';
  2185. viewRoot._appendChild( parse( view ) );
  2186. renderer.markToSync( 'children', viewRoot );
  2187. renderer.render();
  2188. expect( domRoot.innerHTML ).to.equal(
  2189. '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
  2190. const viewOL1 = viewRoot.getChild( 0 );
  2191. viewOL1.getChild( 0 )._removeChildren( 1 );
  2192. viewRoot._removeChildren( 2 );
  2193. viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
  2194. viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
  2195. viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
  2196. const domOL1 = domRoot.childNodes[ 0 ];
  2197. const domOL2 = domRoot.childNodes[ 2 ];
  2198. const domP = domRoot.childNodes[ 1 ];
  2199. renderer.markToSync( 'children', viewRoot );
  2200. renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
  2201. renderer.render();
  2202. expect( domRoot.innerHTML ).to.equal(
  2203. '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
  2204. expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
  2205. expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
  2206. expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
  2207. } );
  2208. it( 'should handle attributes change in replaced elements', () => {
  2209. const view = '' +
  2210. '<container:ol>' +
  2211. '<container:li data-index="1" align="left">Item 1</container:li>' +
  2212. '</container:ol>' +
  2213. '<container:p>Paragraph ' +
  2214. '<attribute:a href="123">Link</attribute:a>' +
  2215. '</container:p>' +
  2216. '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
  2217. viewRoot._appendChild( parse( view ) );
  2218. renderer.markToSync( 'children', viewRoot );
  2219. renderer.render();
  2220. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2221. '<ol><li data-index="1" align="left">Item 1</li></ol>' +
  2222. '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
  2223. const viewOL = viewRoot.getChild( 0 );
  2224. viewOL._removeChildren( 0 );
  2225. viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
  2226. const viewP1 = viewRoot.getChild( 1 );
  2227. viewP1._removeChildren( 1 );
  2228. viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
  2229. viewRoot._removeChildren( 2 );
  2230. viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
  2231. renderer.markToSync( 'children', viewRoot );
  2232. renderer.markToSync( 'children', viewOL );
  2233. renderer.markToSync( 'children', viewP1 );
  2234. renderer.render();
  2235. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2236. '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
  2237. '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
  2238. } );
  2239. it( 'should handle classes change in replaced elements', () => {
  2240. const view = '' +
  2241. '<container:ol>' +
  2242. '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
  2243. '</container:ol>' +
  2244. '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
  2245. viewRoot._appendChild( parse( view ) );
  2246. renderer.markToSync( 'children', viewRoot );
  2247. renderer.render();
  2248. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2249. '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
  2250. const viewOL = viewRoot.getChild( 0 );
  2251. const oldViewLI = viewOL.getChild( 0 );
  2252. viewOL._removeChildren( 0 );
  2253. viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
  2254. const oldViewP = viewRoot.getChild( 1 );
  2255. viewRoot._removeChildren( 1 );
  2256. viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
  2257. renderer.markToSync( 'attributes', oldViewLI );
  2258. renderer.markToSync( 'attributes', oldViewP );
  2259. renderer.markToSync( 'children', viewRoot );
  2260. renderer.markToSync( 'children', viewOL );
  2261. renderer.render();
  2262. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2263. '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
  2264. } );
  2265. it( 'should handle styles change in replaced elements', () => {
  2266. const view = '' +
  2267. '<container:ol>' +
  2268. '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
  2269. '<container:li>Bar ' +
  2270. '<attribute:i>' +
  2271. '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
  2272. ' Bax</attribute:i>' +
  2273. '</container:li>' +
  2274. '</container:ol>';
  2275. viewRoot._appendChild( parse( view ) );
  2276. renderer.markToSync( 'children', viewRoot );
  2277. renderer.render();
  2278. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2279. '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
  2280. '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
  2281. const viewOL = viewRoot.getChild( 0 );
  2282. const viewLI1 = viewOL.getChild( 0 );
  2283. const viewLI2 = viewOL.getChild( 1 );
  2284. viewLI1._removeStyle( 'font-weight' );
  2285. viewLI1._setStyle( { color: '#FFF' } );
  2286. viewLI2._setStyle( { 'font-weight': 'bold' } );
  2287. viewLI2._removeChildren( 0, viewLI2.childCount );
  2288. viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
  2289. '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
  2290. renderer.markToSync( 'attributes', viewLI1 );
  2291. renderer.markToSync( 'attributes', viewLI2 );
  2292. renderer.markToSync( 'children', viewRoot );
  2293. renderer.markToSync( 'children', viewLI2 );
  2294. renderer.render();
  2295. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2296. '<ol><li style="color:#FFF;">Foo</li>' +
  2297. '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
  2298. '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
  2299. } );
  2300. it( 'should handle uiElement rendering', () => {
  2301. function createUIElement( id, text ) {
  2302. const element = new UIElement( 'span' );
  2303. element.render = function( domDocument ) {
  2304. const domElement = this.toDomElement( domDocument );
  2305. domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
  2306. return domElement;
  2307. };
  2308. return element;
  2309. }
  2310. const ui1 = createUIElement( 'id1', 'UI1' );
  2311. const ui2 = createUIElement( 'id2', 'UI2' );
  2312. const viewP = new ViewContainerElement( 'p', null, [ new ViewText( 'Foo ' ), ui1, new ViewText( 'Bar' ) ] );
  2313. viewRoot._appendChild( viewP );
  2314. renderer.markToSync( 'children', viewRoot );
  2315. renderer.render();
  2316. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2317. '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
  2318. viewP._removeChildren( 0, viewP.childCount );
  2319. viewP._insertChild( 0, [ new ViewText( 'Foo' ), ui2, new ViewText( ' Bar' ) ] );
  2320. renderer.markToSync( 'children', viewRoot );
  2321. renderer.markToSync( 'children', viewP );
  2322. renderer.render();
  2323. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
  2324. '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
  2325. } );
  2326. it( 'should handle linking entire content', () => {
  2327. viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
  2328. renderer.markToSync( 'children', viewRoot );
  2329. renderer.render();
  2330. expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
  2331. const viewP = viewRoot.getChild( 0 );
  2332. // While linking, the existing DOM children are moved to a new `a` element during binding
  2333. // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
  2334. // where view elements were moved to a newly created link view element.
  2335. const viewA = new ViewAttributeElement( 'a', { href: '#href' }, [ new ViewText( 'Foo' ), viewP.getChild( 1 ) ] );
  2336. viewP._removeChildren( 0, viewP.childCount );
  2337. viewP._insertChild( 0, viewA );
  2338. renderer.markToSync( 'children', viewRoot );
  2339. renderer.markToSync( 'children', viewP );
  2340. renderer.render();
  2341. expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
  2342. } );
  2343. } );
  2344. describe( 'optimal (minimal) rendering – minimal children changes', () => {
  2345. let observer;
  2346. beforeEach( () => {
  2347. observer = new MutationObserver( () => {} );
  2348. observer.observe( domRoot, {
  2349. childList: true,
  2350. attributes: false,
  2351. subtree: false
  2352. } );
  2353. } );
  2354. afterEach( () => {
  2355. observer.disconnect();
  2356. } );
  2357. it( 'should add only one child (at the beginning)', () => {
  2358. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2359. renderer.markToSync( 'children', viewRoot );
  2360. renderer.render();
  2361. cleanObserver( observer );
  2362. viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
  2363. renderer.markToSync( 'children', viewRoot );
  2364. renderer.render();
  2365. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2366. 'added: 1, removed: 0'
  2367. ] );
  2368. } );
  2369. it( 'should add only one child (at the end)', () => {
  2370. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2371. renderer.markToSync( 'children', viewRoot );
  2372. renderer.render();
  2373. cleanObserver( observer );
  2374. viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
  2375. renderer.markToSync( 'children', viewRoot );
  2376. renderer.render();
  2377. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2378. 'added: 1, removed: 0'
  2379. ] );
  2380. } );
  2381. it( 'should add only one child (in the middle)', () => {
  2382. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2383. renderer.markToSync( 'children', viewRoot );
  2384. renderer.render();
  2385. cleanObserver( observer );
  2386. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2387. renderer.markToSync( 'children', viewRoot );
  2388. renderer.render();
  2389. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2390. 'added: 1, removed: 0'
  2391. ] );
  2392. } );
  2393. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2394. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2395. renderer.markToSync( 'children', viewRoot );
  2396. renderer.render();
  2397. cleanObserver( observer );
  2398. viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
  2399. viewRoot._removeChildren( 0, 1 );
  2400. renderer.markToSync( 'children', viewRoot );
  2401. renderer.render();
  2402. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2403. } );
  2404. it( 'should add and remove one', () => {
  2405. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2406. renderer.markToSync( 'children', viewRoot );
  2407. renderer.render();
  2408. cleanObserver( observer );
  2409. viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
  2410. viewRoot._removeChildren( 0, 1 );
  2411. renderer.markToSync( 'children', viewRoot );
  2412. renderer.render();
  2413. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2414. 'added: 1, removed: 0',
  2415. 'added: 0, removed: 1'
  2416. ] );
  2417. } );
  2418. it( 'should not touch the FSC when rendering children', () => {
  2419. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2420. // Set fake selection on the second paragraph.
  2421. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2422. renderer.markToSync( 'children', viewRoot );
  2423. renderer.render();
  2424. cleanObserver( observer );
  2425. // Remove the second paragraph.
  2426. viewRoot._removeChildren( 1, 1 );
  2427. // And set the fake selection on the first one.
  2428. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2429. renderer.markToSync( 'children', viewRoot );
  2430. renderer.render();
  2431. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2432. 'added: 0, removed: 1'
  2433. ] );
  2434. } );
  2435. it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
  2436. // This test's purpose is mostly reaching 100% CC.
  2437. observer = new MutationObserver( () => {} );
  2438. viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
  2439. const viewDiv = viewRoot.getChild( 0 );
  2440. // Set fake selection on the second paragraph.
  2441. selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
  2442. renderer.markToSync( 'children', viewDiv );
  2443. renderer.markToSync( 'children', viewRoot );
  2444. renderer.render();
  2445. observer.observe( domRoot.childNodes[ 0 ], {
  2446. childList: true,
  2447. attributes: false,
  2448. subtree: false
  2449. } );
  2450. // Remove the second paragraph.
  2451. viewDiv._removeChildren( 1, 1 );
  2452. // And set the fake selection on the first one.
  2453. selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
  2454. renderer.markToSync( 'children', viewDiv );
  2455. renderer.markToSync( 'children', viewRoot );
  2456. renderer.render();
  2457. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2458. 'added: 0, removed: 1'
  2459. ] );
  2460. observer.disconnect();
  2461. } );
  2462. describe( 'using fastDiff() - significant number of nodes in the editor', () => {
  2463. it( 'should add only one child (at the beginning)', () => {
  2464. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2465. renderer.markToSync( 'children', viewRoot );
  2466. renderer.render();
  2467. cleanObserver( observer );
  2468. viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
  2469. renderer.markToSync( 'children', viewRoot );
  2470. renderer.render();
  2471. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2472. 'added: 1, removed: 0'
  2473. ] );
  2474. } );
  2475. it( 'should add only one child (at the end)', () => {
  2476. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2477. renderer.markToSync( 'children', viewRoot );
  2478. renderer.render();
  2479. cleanObserver( observer );
  2480. viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
  2481. renderer.markToSync( 'children', viewRoot );
  2482. renderer.render();
  2483. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2484. 'added: 1, removed: 0'
  2485. ] );
  2486. } );
  2487. it( 'should add only one child (in the middle)', () => {
  2488. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2489. renderer.markToSync( 'children', viewRoot );
  2490. renderer.render();
  2491. cleanObserver( observer );
  2492. viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
  2493. renderer.markToSync( 'children', viewRoot );
  2494. renderer.render();
  2495. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2496. 'added: 1, removed: 0'
  2497. ] );
  2498. } );
  2499. it( 'should not touch elements at all (rendering texts is enough)', () => {
  2500. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2501. renderer.markToSync( 'children', viewRoot );
  2502. renderer.render();
  2503. cleanObserver( observer );
  2504. viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
  2505. viewRoot._removeChildren( 0, 1 );
  2506. renderer.markToSync( 'children', viewRoot );
  2507. renderer.render();
  2508. expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
  2509. } );
  2510. it( 'should add and remove one', () => {
  2511. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2512. renderer.markToSync( 'children', viewRoot );
  2513. renderer.render();
  2514. cleanObserver( observer );
  2515. viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
  2516. viewRoot._removeChildren( 0, 1 );
  2517. renderer.markToSync( 'children', viewRoot );
  2518. renderer.render();
  2519. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2520. 'added: 1, removed: 0',
  2521. 'added: 0, removed: 1'
  2522. ] );
  2523. } );
  2524. it( 'should not touch the FSC when rendering children', () => {
  2525. viewRoot._appendChild( parse( makeContainers( 151 ) ) );
  2526. // Set fake selection on the second paragraph.
  2527. selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
  2528. renderer.markToSync( 'children', viewRoot );
  2529. renderer.render();
  2530. cleanObserver( observer );
  2531. // Remove the second paragraph.
  2532. viewRoot._removeChildren( 1, 1 );
  2533. // And set the fake selection on the first one.
  2534. selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
  2535. renderer.markToSync( 'children', viewRoot );
  2536. renderer.render();
  2537. expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
  2538. 'added: 0, removed: 1'
  2539. ] );
  2540. } );
  2541. } );
  2542. function getMutationStats( mutationList ) {
  2543. return mutationList.map( mutation => {
  2544. return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
  2545. } );
  2546. }
  2547. function cleanObserver( observer ) {
  2548. observer.takeRecords();
  2549. }
  2550. function makeContainers( howMany ) {
  2551. const containers = [];
  2552. for ( let i = 1; i <= howMany; i++ ) {
  2553. containers.push( `<container:p>${ i }</container:p>` );
  2554. }
  2555. return containers.join( '' );
  2556. }
  2557. } );
  2558. // #1560
  2559. describe( 'attributes manipulation on replaced element', () => {
  2560. it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
  2561. const writer = new DowncastWriter();
  2562. // 1. Setup initial view/DOM.
  2563. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2564. const viewP = viewRoot.getChild( 0 );
  2565. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2566. renderer.markToSync( 'children', viewRoot );
  2567. renderer.render();
  2568. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2569. // 2. Modify view.
  2570. writer.removeAttribute( 'data-placeholder', viewP );
  2571. viewRoot._removeChildren( 0, viewRoot.childCount );
  2572. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2573. renderer.markToSync( 'attributes', viewP );
  2574. renderer.markToSync( 'children', viewRoot );
  2575. renderer.render();
  2576. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2577. } );
  2578. it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
  2579. const writer = new DowncastWriter();
  2580. // 1. Setup initial view/DOM.
  2581. viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
  2582. const viewP = viewRoot.getChild( 1 );
  2583. writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
  2584. renderer.markToSync( 'children', viewRoot );
  2585. renderer.render();
  2586. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
  2587. // 2. Modify view.
  2588. writer.removeClass( 'cke-test2', viewP );
  2589. viewRoot._removeChildren( 0, viewRoot.childCount );
  2590. viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
  2591. '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
  2592. renderer.markToSync( 'attributes', viewP );
  2593. renderer.markToSync( 'children', viewRoot );
  2594. renderer.render();
  2595. expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
  2596. } );
  2597. it( 'should rerender element if it was removed and have its attributes removed after', () => {
  2598. const writer = new DowncastWriter();
  2599. // 1. Setup initial view/DOM.
  2600. viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
  2601. const viewP = viewRoot.getChild( 0 );
  2602. writer.setAttribute( 'data-placeholder', 'Body', viewP );
  2603. renderer.markToSync( 'children', viewRoot );
  2604. renderer.render();
  2605. expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
  2606. // 2. Modify view.
  2607. viewRoot._removeChildren( 0, viewRoot.childCount );
  2608. writer.removeAttribute( 'data-placeholder', viewP );
  2609. viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
  2610. renderer.markToSync( 'children', viewRoot );
  2611. renderer.render();
  2612. expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
  2613. } );
  2614. } );
  2615. // ckeditor/ckeditor5-utils#269
  2616. // The expected times has a significant margin above the usual execution time (which is around 40-50%
  2617. // of the expected time) because it depends on the browser and environment in which tests are run.
  2618. // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
  2619. // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
  2620. describe( 'rendering performance', () => {
  2621. before( function() {
  2622. // Ignore on Edge browser where performance is quite poor.
  2623. if ( env.isEdge ) {
  2624. this.skip();
  2625. }
  2626. } );
  2627. it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
  2628. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
  2629. expect( renderingTime ).to.be.within( 0, 350 );
  2630. } );
  2631. it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
  2632. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
  2633. expect( renderingTime ).to.be.within( 0, 350 );
  2634. } );
  2635. it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
  2636. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
  2637. expect( renderingTime ).to.be.within( 0, 350 );
  2638. } );
  2639. it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
  2640. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
  2641. expect( renderingTime ).to.be.within( 0, 350 );
  2642. } );
  2643. it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
  2644. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
  2645. expect( renderingTime ).to.be.within( 0, 350 );
  2646. } );
  2647. it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
  2648. const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
  2649. expect( renderingTime ).to.be.within( 0, 350 );
  2650. } );
  2651. function measureRenderingTime( viewRoot, initialData, newData ) {
  2652. // Set initial data.
  2653. const initialView = parse( initialData );
  2654. viewRoot._appendChild( initialView );
  2655. renderer.markToSync( 'children', viewRoot );
  2656. renderer.render();
  2657. // Set new data.
  2658. const newView = parse( newData );
  2659. viewRoot._removeChildren( 0, viewRoot.childCount );
  2660. viewRoot._appendChild( newView );
  2661. renderer.markToSync( 'children', viewRoot );
  2662. // Measure render time.
  2663. const start = Date.now();
  2664. renderer.render();
  2665. return Date.now() - start;
  2666. }
  2667. function generateViewData1( repeat = 1 ) {
  2668. const viewData = '' +
  2669. '<container:h1>' +
  2670. 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
  2671. '</container:h1>' +
  2672. '<container:p>' +
  2673. 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
  2674. '</container:p>' +
  2675. '<container:ul>' +
  2676. '<container:li>Item 1</container:li>' +
  2677. '</container:ul>' +
  2678. '<container:ul>' +
  2679. '<container:li>Item 2</container:li>' +
  2680. '</container:ul>' +
  2681. '<container:ul>' +
  2682. '<container:li>Item 3</container:li>' +
  2683. '</container:ul>';
  2684. return viewData.repeat( repeat );
  2685. }
  2686. function generateViewData2( repeat = 1 ) {
  2687. const viewData = '' +
  2688. '<container:ol>' +
  2689. '<container:li>' +
  2690. '<attribute:strong>Foo</attribute:strong>' +
  2691. '</container:li>' +
  2692. '</container:ol>' +
  2693. '<container:ol>' +
  2694. '<container:li>Item 1</container:li>' +
  2695. '</container:ol>' +
  2696. '<container:h1>Heading 1</container:h1>' +
  2697. '<container:h2>' +
  2698. '<attribute:strong>Heading</attribute:strong> 2' +
  2699. '</container:h2>' +
  2700. '<container:h3>Heading 4</container:h3>';
  2701. return viewData.repeat( repeat );
  2702. }
  2703. } );
  2704. } );
  2705. describe( '#922', () => {
  2706. let view, viewDoc, viewRoot, domRoot, converter;
  2707. beforeEach( () => {
  2708. view = new View();
  2709. viewDoc = view.document;
  2710. domRoot = document.createElement( 'div' );
  2711. document.body.appendChild( domRoot );
  2712. viewRoot = createViewRoot( viewDoc );
  2713. view.attachDomRoot( domRoot );
  2714. converter = view.domConverter;
  2715. } );
  2716. it( 'should properly render unwrapped attributes #1', () => {
  2717. setViewData( view,
  2718. '<container:p>' +
  2719. '[<attribute:italic>' +
  2720. '<attribute:strong>f</attribute:strong>' +
  2721. '</attribute:italic>]' +
  2722. '<attribute:strong>oo</attribute:strong>' +
  2723. '</container:p>'
  2724. );
  2725. // Render it to DOM to create initial DOM <-> view mappings.
  2726. view.forceRender();
  2727. // Unwrap italic attribute element.
  2728. view.change( writer => {
  2729. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2730. } );
  2731. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  2732. // Re-render changes in view to DOM.
  2733. view.forceRender();
  2734. // Check if DOM is rendered correctly.
  2735. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  2736. expect( checkMappings() ).to.be.true;
  2737. } );
  2738. it( 'should properly render unwrapped attributes #2', () => {
  2739. setViewData( view,
  2740. '<container:p>' +
  2741. '[<attribute:italic>' +
  2742. '<attribute:strong>foo</attribute:strong>' +
  2743. '</attribute:italic>]' +
  2744. '</container:p>' );
  2745. // Render it to DOM to create initial DOM <-> view mappings.
  2746. view.forceRender();
  2747. // Unwrap italic attribute element and change text inside.
  2748. view.change( writer => {
  2749. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  2750. } );
  2751. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
  2752. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  2753. // Re-render changes in view to DOM.
  2754. view.forceRender();
  2755. // Check if DOM is rendered correctly.
  2756. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  2757. expect( checkMappings() ).to.be.true;
  2758. } );
  2759. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  2760. setViewData( view,
  2761. '<container:p>foo</container:p>'
  2762. );
  2763. // Render it to DOM to create initial DOM <-> view mappings.
  2764. view.forceRender();
  2765. // Change text and insert new element into paragraph.
  2766. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2767. textNode._data = 'foobar';
  2768. view.change( writer => {
  2769. writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  2770. } );
  2771. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  2772. // Re-render changes in view to DOM.
  2773. view.forceRender();
  2774. // Check if DOM is rendered correctly.
  2775. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  2776. expect( checkMappings() ).to.be.true;
  2777. } );
  2778. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  2779. setViewData( view,
  2780. '<container:p>foo</container:p>'
  2781. );
  2782. // Render it to DOM to create initial DOM <-> view mappings.
  2783. view.forceRender();
  2784. // Change text and insert new element into paragraph.
  2785. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  2786. textNode._data = 'foobar';
  2787. view.change( writer => {
  2788. writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  2789. } );
  2790. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  2791. // Re-render changes in view to DOM.
  2792. view.forceRender();
  2793. // Check if DOM is rendered correctly.
  2794. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  2795. expect( checkMappings() ).to.be.true;
  2796. } );
  2797. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  2798. setViewData( view,
  2799. '<container:p>' +
  2800. '<attribute:b></attribute:b>' +
  2801. '<attribute:i></attribute:i>' +
  2802. '<attribute:span></attribute:span>' +
  2803. '</container:p>'
  2804. );
  2805. // Render it to DOM to create initial DOM <-> view mappings.
  2806. view.forceRender();
  2807. // Remove first element and reinsert it at the end.
  2808. const container = viewRoot.getChild( 0 );
  2809. const firstElement = container.getChild( 0 );
  2810. view.change( writer => {
  2811. writer.remove( ViewRange._createOn( firstElement ) );
  2812. writer.insert( new ViewPosition( container, 2 ), firstElement );
  2813. } );
  2814. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2815. // Re-render changes in view to DOM.
  2816. view.forceRender();
  2817. // Check if DOM is rendered correctly.
  2818. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  2819. expect( checkMappings() ).to.be.true;
  2820. } );
  2821. // Checks if every node in DOM tree is mapped to the view.
  2822. function checkMappings() {
  2823. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  2824. while ( domWalker.nextNode() ) {
  2825. const node = domWalker.currentNode;
  2826. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  2827. return false;
  2828. }
  2829. }
  2830. return true;
  2831. }
  2832. } );
  2833. describe( '_markDescendantTextToSync', () => {
  2834. let viewRoot;
  2835. beforeEach( () => {
  2836. viewRoot = new ViewElement( 'div' );
  2837. renderer.markedTexts.clear();
  2838. renderer.markedAttributes.clear();
  2839. renderer.markedChildren.clear();
  2840. } );
  2841. it( 'should handle null values', () => {
  2842. // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
  2843. renderer._markDescendantTextToSync( null );
  2844. expect( renderer.markedChildren.size ).to.equal( 0 );
  2845. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2846. expect( renderer.markedTexts.size ).to.equal( 0 );
  2847. } );
  2848. it( 'should handle element nodes', () => {
  2849. const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2850. viewRoot._appendChild( viewP );
  2851. renderer._markDescendantTextToSync( viewP );
  2852. expect( renderer.markedChildren.size ).to.equal( 0 );
  2853. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2854. expect( renderer.markedTexts.size ).to.equal( 3 );
  2855. } );
  2856. it( 'should handle text nodes', () => {
  2857. const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
  2858. viewRoot._appendChild( viewP );
  2859. renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
  2860. expect( renderer.markedChildren.size ).to.equal( 0 );
  2861. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2862. expect( renderer.markedTexts.size ).to.equal( 1 );
  2863. } );
  2864. it( 'should handle document fragment', () => {
  2865. const fragment = new DocumentFragment();
  2866. renderer._markDescendantTextToSync( fragment );
  2867. expect( renderer.markedChildren.size ).to.equal( 0 );
  2868. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2869. expect( renderer.markedTexts.size ).to.equal( 0 );
  2870. } );
  2871. it( 'should handle empty element nodes', () => {
  2872. const viewP = parse( '<container:p></container:p>' );
  2873. viewRoot._appendChild( viewP );
  2874. renderer._markDescendantTextToSync( viewP );
  2875. expect( renderer.markedChildren.size ).to.equal( 0 );
  2876. expect( renderer.markedAttributes.size ).to.equal( 0 );
  2877. expect( renderer.markedTexts.size ).to.equal( 0 );
  2878. } );
  2879. } );
  2880. describe( '_updateText', () => {
  2881. let viewRoot, domRoot;
  2882. beforeEach( () => {
  2883. viewRoot = new ViewElement( 'div' );
  2884. domRoot = document.createElement( 'div' );
  2885. document.body.appendChild( domRoot );
  2886. domConverter.bindElements( domRoot, viewRoot );
  2887. renderer.markedTexts.clear();
  2888. renderer.markedAttributes.clear();
  2889. renderer.markedChildren.clear();
  2890. renderer.isFocused = true;
  2891. } );
  2892. afterEach( () => {
  2893. domRoot.remove();
  2894. } );
  2895. it( 'should update text - change on end', () => {
  2896. const viewText = new ViewText( 'foo' );
  2897. viewRoot._appendChild( viewText );
  2898. renderer.markToSync( 'children', viewRoot );
  2899. renderer.render();
  2900. expect( domRoot.childNodes.length ).to.equal( 1 );
  2901. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2902. viewText._data = 'fobar';
  2903. renderer._updateText( viewText, {} );
  2904. expect( domRoot.childNodes.length ).to.equal( 1 );
  2905. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2906. } );
  2907. it( 'should update text - change on start', () => {
  2908. const viewText = new ViewText( 'foo' );
  2909. viewRoot._appendChild( viewText );
  2910. renderer.markToSync( 'children', viewRoot );
  2911. renderer.render();
  2912. expect( domRoot.childNodes.length ).to.equal( 1 );
  2913. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2914. viewText._data = 'baro';
  2915. renderer._updateText( viewText, {} );
  2916. expect( domRoot.childNodes.length ).to.equal( 1 );
  2917. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
  2918. } );
  2919. it( 'should update text - change in the middle', () => {
  2920. const viewText = new ViewText( 'foobar' );
  2921. viewRoot._appendChild( viewText );
  2922. renderer.markToSync( 'children', viewRoot );
  2923. renderer.render();
  2924. expect( domRoot.childNodes.length ).to.equal( 1 );
  2925. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
  2926. viewText._data = 'fobazr';
  2927. renderer._updateText( viewText, {} );
  2928. expect( domRoot.childNodes.length ).to.equal( 1 );
  2929. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
  2930. } );
  2931. it( 'should update text - empty expected', () => {
  2932. const viewText = new ViewText( 'foo' );
  2933. viewRoot._appendChild( viewText );
  2934. renderer.markToSync( 'children', viewRoot );
  2935. renderer.render();
  2936. expect( domRoot.childNodes.length ).to.equal( 1 );
  2937. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2938. viewText._data = '';
  2939. renderer._updateText( viewText, {} );
  2940. expect( domRoot.childNodes.length ).to.equal( 1 );
  2941. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2942. } );
  2943. it( 'should update text - empty actual', () => {
  2944. const viewText = new ViewText( '' );
  2945. viewRoot._appendChild( viewText );
  2946. renderer.markToSync( 'children', viewRoot );
  2947. renderer.render();
  2948. expect( domRoot.childNodes.length ).to.equal( 1 );
  2949. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2950. viewText._data = 'fobar';
  2951. renderer._updateText( viewText, {} );
  2952. expect( domRoot.childNodes.length ).to.equal( 1 );
  2953. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
  2954. } );
  2955. it( 'should handle filler during text modifications', () => {
  2956. const viewText = new ViewText( 'foo' );
  2957. viewRoot._appendChild( viewText );
  2958. renderer.markToSync( 'children', viewRoot );
  2959. renderer.render();
  2960. expect( domRoot.childNodes.length ).to.equal( 1 );
  2961. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  2962. // 1. Insert filler.
  2963. renderer._updateText( viewText, {
  2964. inlineFillerPosition: {
  2965. parent: viewText.parent,
  2966. offset: 0
  2967. }
  2968. } );
  2969. expect( domRoot.childNodes.length ).to.equal( 1 );
  2970. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  2971. // 2. Edit text - filler should be preserved.
  2972. viewText._data = 'barfoo';
  2973. renderer._updateText( viewText, {
  2974. inlineFillerPosition: {
  2975. parent: viewText.parent,
  2976. offset: 0
  2977. }
  2978. } );
  2979. expect( domRoot.childNodes.length ).to.equal( 1 );
  2980. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
  2981. // 3. Remove filler.
  2982. renderer._updateText( viewText, {} );
  2983. expect( domRoot.childNodes.length ).to.equal( 1 );
  2984. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
  2985. } );
  2986. it( 'should handle filler during text modifications - empty text', () => {
  2987. const viewText = new ViewText( '' );
  2988. viewRoot._appendChild( viewText );
  2989. renderer.markToSync( 'children', viewRoot );
  2990. renderer.render();
  2991. expect( domRoot.childNodes.length ).to.equal( 1 );
  2992. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  2993. // 1. Insert filler.
  2994. renderer._updateText( viewText, {
  2995. inlineFillerPosition: {
  2996. parent: viewText.parent,
  2997. offset: 0
  2998. }
  2999. } );
  3000. expect( domRoot.childNodes.length ).to.equal( 1 );
  3001. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  3002. // 2. Edit text - filler should be preserved.
  3003. viewText._data = 'foo';
  3004. renderer._updateText( viewText, {
  3005. inlineFillerPosition: {
  3006. parent: viewText.parent,
  3007. offset: 0
  3008. }
  3009. } );
  3010. expect( domRoot.childNodes.length ).to.equal( 1 );
  3011. expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3012. // 3. Remove filler.
  3013. viewText._data = '';
  3014. renderer._updateText( viewText, {} );
  3015. expect( domRoot.childNodes.length ).to.equal( 1 );
  3016. expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
  3017. } );
  3018. it( 'should handle filler during text modifications inside inline element', () => {
  3019. const viewB = new ViewElement( 'b' );
  3020. const viewText = new ViewText( 'foo' );
  3021. viewB._appendChild( viewText );
  3022. viewRoot._appendChild( viewB );
  3023. renderer.markToSync( 'children', viewRoot );
  3024. renderer.render();
  3025. expect( domRoot.childNodes.length ).to.equal( 1 );
  3026. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3027. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3028. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  3029. // 1. Insert filler.
  3030. renderer._updateText( viewText, {
  3031. inlineFillerPosition: {
  3032. parent: viewText.parent,
  3033. offset: 0
  3034. }
  3035. } );
  3036. expect( domRoot.childNodes.length ).to.equal( 1 );
  3037. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3038. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3039. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
  3040. // 2. Edit text - filler should be preserved.
  3041. viewText._data = 'bar';
  3042. renderer._updateText( viewText, {
  3043. inlineFillerPosition: {
  3044. parent: viewText.parent,
  3045. offset: 0
  3046. }
  3047. } );
  3048. expect( domRoot.childNodes.length ).to.equal( 1 );
  3049. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3050. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3051. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
  3052. // 3. Remove filler.
  3053. viewText._data = 'bar';
  3054. renderer._updateText( viewText, {} );
  3055. expect( domRoot.childNodes.length ).to.equal( 1 );
  3056. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
  3057. expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  3058. expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  3059. } );
  3060. } );
  3061. } );
  3062. function renderAndExpectNoChanges( renderer, domRoot ) {
  3063. const config = {
  3064. childList: true,
  3065. characterData: true,
  3066. characterDataOldValue: true,
  3067. subtree: true
  3068. };
  3069. const mutationObserver = new window.MutationObserver( () => {
  3070. throw 'There should be not mutations';
  3071. } );
  3072. mutationObserver.observe( domRoot, config );
  3073. renderer.render();
  3074. const records = mutationObserver.takeRecords();
  3075. mutationObserver.disconnect();
  3076. expect( records.length ).to.equal( 0 );
  3077. }