deletecontent.js 38 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176
  1. /**
  2. * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  4. */
  5. import Model from '../../../src/model/model';
  6. import Position from '../../../src/model/position';
  7. import Range from '../../../src/model/range';
  8. import Selection from '../../../src/model/selection';
  9. import Element from '../../../src/model/element';
  10. import deleteContent from '../../../src/model/utils/deletecontent';
  11. import { setData, getData } from '../../../src/dev-utils/model';
  12. import { stringify } from '../../../src/dev-utils/view';
  13. describe( 'DataController utils', () => {
  14. let model, doc;
  15. describe( 'deleteContent', () => {
  16. it( 'should use parent batch', () => {
  17. model = new Model();
  18. doc = model.document;
  19. doc.createRoot();
  20. model.schema.extend( '$text', { allowIn: '$root' } );
  21. setData( model, 'x[abc]x' );
  22. model.change( writer => {
  23. deleteContent( model, doc.selection );
  24. expect( writer.batch.operations ).to.length( 1 );
  25. } );
  26. } );
  27. it( 'should not do anything if the selection is already in graveyard', () => {
  28. model = new Model();
  29. doc = model.document;
  30. const gy = model.document.graveyard;
  31. gy._appendChild( new Element( 'paragraph' ) );
  32. const baseVersion = model.document.baseVersion;
  33. model.change( writer => {
  34. sinon.spy( writer, 'remove' );
  35. const selection = writer.createSelection( writer.createRangeIn( gy ) );
  36. deleteContent( model, selection );
  37. expect( writer.remove.called ).to.be.false;
  38. } );
  39. expect( model.document.baseVersion ).to.equal( baseVersion );
  40. } );
  41. describe( 'in simple scenarios', () => {
  42. beforeEach( () => {
  43. model = new Model();
  44. doc = model.document;
  45. doc.createRoot();
  46. const schema = model.schema;
  47. schema.register( 'image', { allowWhere: '$text' } );
  48. schema.extend( '$text', { allowIn: '$root' } );
  49. } );
  50. it( 'should be able to delete content at custom selection', () => {
  51. setData( model, 'a[]bcd' );
  52. const range = new Range(
  53. new Position( doc.getRoot(), [ 2 ] ),
  54. new Position( doc.getRoot(), [ 3 ] )
  55. );
  56. const selection = new Selection( [ range ] );
  57. model.change( () => {
  58. deleteContent( model, selection );
  59. expect( getData( model ) ).to.equal( 'a[]bd' );
  60. } );
  61. } );
  62. test(
  63. 'does nothing on collapsed selection',
  64. 'f[]oo',
  65. 'f[]oo'
  66. );
  67. test(
  68. 'deletes single character',
  69. 'f[o]o',
  70. 'f[]o'
  71. );
  72. it( 'deletes single character (backward selection)', () => {
  73. setData( model, 'f[o]o', { lastRangeBackward: true } );
  74. deleteContent( model, doc.selection );
  75. expect( getData( model ) ).to.equal( 'f[]o' );
  76. } );
  77. test(
  78. 'deletes whole text',
  79. '[foo]',
  80. '[]'
  81. );
  82. test(
  83. 'deletes whole text between nodes',
  84. '<image></image>[foo]<image></image>',
  85. '<image></image>[]<image></image>'
  86. );
  87. test(
  88. 'deletes an element',
  89. 'x[<image></image>]y',
  90. 'x[]y'
  91. );
  92. test(
  93. 'deletes a bunch of nodes',
  94. 'w[x<image></image>y]z',
  95. 'w[]z'
  96. );
  97. test(
  98. 'does not break things when option.merge passed',
  99. 'w[x<image></image>y]z',
  100. 'w[]z'
  101. );
  102. } );
  103. describe( 'with text attributes', () => {
  104. beforeEach( () => {
  105. model = new Model();
  106. doc = model.document;
  107. doc.createRoot();
  108. const schema = model.schema;
  109. schema.register( 'image', { allowWhere: '$text' } );
  110. schema.register( 'paragraph', { inheritAllFrom: '$block' } );
  111. schema.extend( '$text', {
  112. allowIn: '$root',
  113. allowAttributes: [ 'bold', 'italic' ]
  114. } );
  115. } );
  116. it( 'deletes characters (first half has attrs)', () => {
  117. setData( model, '<$text bold="true">fo[o</$text>b]ar' );
  118. deleteContent( model, doc.selection );
  119. expect( getData( model ) ).to.equal( '<$text bold="true">fo[]</$text>ar' );
  120. expect( doc.selection.getAttribute( 'bold' ) ).to.equal( true );
  121. } );
  122. it( 'deletes characters (2nd half has attrs)', () => {
  123. setData( model, 'fo[o<$text bold="true">b]ar</$text>' );
  124. deleteContent( model, doc.selection );
  125. expect( getData( model ) ).to.equal( 'fo[]<$text bold="true">ar</$text>' );
  126. expect( doc.selection.getAttribute( 'bold' ) ).to.undefined;
  127. } );
  128. it( 'clears selection attrs when emptied content', () => {
  129. setData( model, '<paragraph>x</paragraph><paragraph>[<$text bold="true">foo</$text>]</paragraph><paragraph>y</paragraph>' );
  130. deleteContent( model, doc.selection );
  131. expect( getData( model ) ).to.equal( '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>y</paragraph>' );
  132. expect( doc.selection.getAttribute( 'bold' ) ).to.undefined;
  133. } );
  134. it( 'leaves selection attributes when text contains them', () => {
  135. setData(
  136. model,
  137. '<paragraph>x<$text bold="true">a[foo]b</$text>y</paragraph>',
  138. {
  139. selectionAttributes: {
  140. bold: true
  141. }
  142. }
  143. );
  144. deleteContent( model, doc.selection );
  145. expect( getData( model ) ).to.equal( '<paragraph>x<$text bold="true">a[]b</$text>y</paragraph>' );
  146. expect( doc.selection.getAttribute( 'bold' ) ).to.equal( true );
  147. } );
  148. } );
  149. // Note: The algorithm does not care what kind of it's merging as it knows nothing useful about these elements.
  150. // In most cases it handles all elements like you'd expect to handle block elements in HTML. However,
  151. // in some scenarios where the tree depth is bigger results may be hard to justify. In fact, such cases
  152. // should not happen unless we're talking about lists or tables, but these features will need to cover
  153. // their scenarios themselves. In all generic scenarios elements are never nested.
  154. //
  155. // You may also be thinking – but I don't want my elements to be merged. It means that there are some special rules,
  156. // like – multiple editing hosts (cE=true/false in use) or block limit elements like <td>.
  157. // Those case should, again, be handled by their specific implementations.
  158. describe( 'in multi-element scenarios', () => {
  159. beforeEach( () => {
  160. model = new Model();
  161. doc = model.document;
  162. doc.createRoot();
  163. const schema = model.schema;
  164. schema.register( 'paragraph', {
  165. inheritAllFrom: '$block',
  166. allowIn: 'pparent',
  167. allowAttributes: 'align'
  168. } );
  169. schema.register( 'heading1', { inheritAllFrom: '$block', allowIn: 'pparent' } );
  170. schema.register( 'image', { inheritAllFrom: '$text' } );
  171. schema.register( 'pchild', { allowIn: 'paragraph' } );
  172. schema.register( 'pparent', { allowIn: '$root' } );
  173. schema.register( 'hchild', { allowIn: 'heading1' } );
  174. schema.register( 'widget', { isObject: true, allowWhere: '$text', isInline: true } );
  175. schema.extend( '$text', { allowIn: [ 'pchild', 'pparent', 'hchild' ] } );
  176. } );
  177. test(
  178. 'do not merge when no need to',
  179. '<paragraph>x</paragraph><paragraph>[foo]</paragraph><paragraph>y</paragraph>',
  180. '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>y</paragraph>'
  181. );
  182. test(
  183. 'merges second element into the first one (same name)',
  184. '<paragraph>x</paragraph><paragraph>fo[o</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  185. '<paragraph>x</paragraph><paragraph>fo[]ar</paragraph><paragraph>y</paragraph>'
  186. );
  187. test(
  188. 'merges first element into the second element (it would become empty but second element would not) (same name)',
  189. '<paragraph>x</paragraph><paragraph>[foo</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  190. '<paragraph>x</paragraph><paragraph>[]ar</paragraph><paragraph>y</paragraph>'
  191. );
  192. test(
  193. 'do not remove end block if selection ends at start position of it',
  194. '<paragraph>x</paragraph><paragraph>[foo</paragraph><paragraph>]bar</paragraph><paragraph>y</paragraph>',
  195. '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>bar</paragraph><paragraph>y</paragraph>'
  196. );
  197. test(
  198. 'removes empty element (merges it into second element)',
  199. '<paragraph>x</paragraph><paragraph>[</paragraph><paragraph>]bar</paragraph><paragraph>y</paragraph>',
  200. '<paragraph>x</paragraph><paragraph>[]bar</paragraph><paragraph>y</paragraph>'
  201. );
  202. test(
  203. 'treats inline widget elements as content so parent element is not considered as empty after merging (same name)',
  204. '<paragraph>x</paragraph><paragraph><widget></widget>[foo</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  205. '<paragraph>x</paragraph><paragraph><widget></widget>[]ar</paragraph><paragraph>y</paragraph>'
  206. );
  207. test(
  208. 'does not merge second element into the first one (same name, !option.merge)',
  209. '<paragraph>x</paragraph><paragraph>fo[o</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  210. '<paragraph>x</paragraph><paragraph>fo[]</paragraph><paragraph>ar</paragraph><paragraph>y</paragraph>',
  211. { leaveUnmerged: true }
  212. );
  213. test(
  214. 'does not remove first empty element when it\'s empty but second element is not empty (same name, !option.merge)',
  215. '<paragraph>x</paragraph><paragraph>[foo</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  216. '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>ar</paragraph><paragraph>y</paragraph>',
  217. { leaveUnmerged: true }
  218. );
  219. test(
  220. 'merges second element into the first one (different name)',
  221. '<paragraph>x</paragraph><heading1>fo[o</heading1><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  222. '<paragraph>x</paragraph><heading1>fo[]ar</heading1><paragraph>y</paragraph>'
  223. );
  224. test(
  225. 'removes first element when it\'s empty but second element is not empty (different name)',
  226. '<paragraph>x</paragraph><heading1>[foo</heading1><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  227. '<paragraph>x</paragraph><paragraph>[]ar</paragraph><paragraph>y</paragraph>'
  228. );
  229. // Note: in all these cases we ignore the direction of merge.
  230. // If https://github.com/ckeditor/ckeditor5-engine/issues/470 was fixed we could differently treat
  231. // forward and backward delete.
  232. it( 'merges second element into the first one (different name, backward selection)', () => {
  233. setData(
  234. model,
  235. '<paragraph>x</paragraph><heading1>fo[o</heading1><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  236. { lastRangeBackward: true }
  237. );
  238. deleteContent( model, doc.selection );
  239. expect( getData( model ) ).to.equal( '<paragraph>x</paragraph><heading1>fo[]ar</heading1><paragraph>y</paragraph>' );
  240. } );
  241. test(
  242. 'merges second element into the first one (different attrs)',
  243. '<paragraph>x</paragraph><paragraph align="l">fo[o</paragraph><paragraph>b]ar</paragraph><paragraph>y</paragraph>',
  244. '<paragraph>x</paragraph><paragraph align="l">fo[]ar</paragraph><paragraph>y</paragraph>'
  245. );
  246. test(
  247. 'removes empty first element',
  248. '<paragraph>x</paragraph><heading1>[</heading1><paragraph>fo]o</paragraph><paragraph>y</paragraph>',
  249. '<paragraph>x</paragraph><paragraph>[]o</paragraph><paragraph>y</paragraph>'
  250. );
  251. test(
  252. 'merges empty element into the first element',
  253. '<heading1>f[oo</heading1><paragraph>bar]</paragraph><paragraph>x</paragraph>',
  254. '<heading1>f[]</heading1><paragraph>x</paragraph>'
  255. );
  256. test(
  257. 'leaves just one element when all selected',
  258. '<paragraph>[x</paragraph><paragraph>foo</paragraph><paragraph>y]bar</paragraph>',
  259. '<paragraph>[]bar</paragraph>'
  260. );
  261. test(
  262. 'leaves just one (last) element when all selected (first block would become empty) (different name)',
  263. '<heading1>[x</heading1><paragraph>foo</paragraph><paragraph>y]bar</paragraph>',
  264. '<paragraph>[]bar</paragraph>'
  265. );
  266. test(
  267. 'leaves just one (first) element when all selected (first block would not become empty) (different name)',
  268. '<heading1>foo[x</heading1><paragraph>bar</paragraph><paragraph>y]</paragraph>',
  269. '<heading1>foo[]</heading1>'
  270. );
  271. it( 'uses merge operation even if merged element is empty', () => {
  272. let mergeSpy;
  273. setData( model, '<paragraph>ab[cd</paragraph><paragraph>efgh]</paragraph>' );
  274. model.change( writer => {
  275. mergeSpy = sinon.spy( writer, 'merge' );
  276. deleteContent( model, doc.selection );
  277. } );
  278. expect( getData( model ) ).to.equal( '<paragraph>ab[]</paragraph>' );
  279. expect( mergeSpy.called ).to.be.true;
  280. } );
  281. it( 'uses merge operation even if merged element is empty #2', () => {
  282. let mergeSpy;
  283. setData( model, '<paragraph>ab[</paragraph><paragraph>]</paragraph>' );
  284. model.change( writer => {
  285. mergeSpy = sinon.spy( writer, 'merge' );
  286. deleteContent( model, doc.selection );
  287. } );
  288. expect( getData( model ) ).to.equal( '<paragraph>ab[]</paragraph>' );
  289. expect( mergeSpy.called ).to.be.true;
  290. } );
  291. it( 'uses "merge" operation (from OT) if first element is empty (because of content delete) and last is not', () => {
  292. let mergeSpy;
  293. setData( model, '<paragraph>[abcd</paragraph><paragraph>ef]gh</paragraph>' );
  294. model.change( writer => {
  295. mergeSpy = sinon.spy( writer, 'merge' );
  296. deleteContent( model, doc.selection );
  297. } );
  298. expect( getData( model ) ).to.equal( '<paragraph>[]gh</paragraph>' );
  299. expect( mergeSpy.called ).to.be.true;
  300. } );
  301. it( 'uses merge operation if first element is empty and last is not', () => {
  302. let mergeSpy;
  303. setData( model, '<paragraph>[</paragraph><paragraph>ef]gh</paragraph>' );
  304. model.change( writer => {
  305. mergeSpy = sinon.spy( writer, 'merge' );
  306. deleteContent( model, doc.selection );
  307. } );
  308. expect( getData( model ) ).to.equal( '<paragraph>[]gh</paragraph>' );
  309. expect( mergeSpy.called ).to.be.true;
  310. } );
  311. it( 'does not try to move the second block if not needed', () => {
  312. let mergeSpy, moveSpy;
  313. setData( model, '<paragraph>ab[cd</paragraph><paragraph>ef]gh</paragraph>' );
  314. model.change( writer => {
  315. mergeSpy = sinon.spy( writer, 'merge' );
  316. moveSpy = sinon.spy( writer, 'move' );
  317. deleteContent( model, doc.selection );
  318. } );
  319. expect( getData( model ) ).to.equal( '<paragraph>ab[]gh</paragraph>' );
  320. expect( moveSpy.called ).to.be.false;
  321. expect( mergeSpy.called ).to.be.true;
  322. } );
  323. // Note: in all these cases we ignore the direction of merge.
  324. // If https://github.com/ckeditor/ckeditor5-engine/issues/470 was fixed we could differently treat
  325. // forward and backward delete.
  326. describe( 'with nested elements', () => {
  327. test(
  328. 'merges elements when deep nested',
  329. '<paragraph>x<pchild>fo[o</pchild></paragraph><paragraph><pchild>b]ar</pchild>y</paragraph>',
  330. '<paragraph>x<pchild>fo[]ar</pchild>y</paragraph>'
  331. );
  332. test(
  333. 'merges block element to the right (with nested element)',
  334. '<paragraph><pchild>[foo</pchild></paragraph><paragraph><pchild>b]ar</pchild></paragraph>',
  335. '<paragraph><pchild>[]ar</pchild></paragraph>'
  336. );
  337. test(
  338. 'does not remove block element with nested element and object',
  339. '<paragraph><pchild><widget></widget>[foo</pchild></paragraph><paragraph><pchild>b]ar</pchild></paragraph>',
  340. '<paragraph><pchild><widget></widget>[]ar</pchild></paragraph>'
  341. );
  342. test(
  343. 'merges nested elements',
  344. '<heading1><hchild>x[foo</hchild></heading1><paragraph><pchild>b]ar</pchild></paragraph>',
  345. '<heading1><hchild>x[]ar</hchild></heading1>'
  346. );
  347. test(
  348. 'merges nested elements on multiple levels',
  349. '<heading1><hchild>x[foo</hchild></heading1><paragraph><pchild>b]ar</pchild>abc</paragraph>',
  350. '<heading1><hchild>x[]ar</hchild>abc</heading1>'
  351. );
  352. test(
  353. 'merges nested elements to the right if left side element would become empty',
  354. '<heading1><hchild>[foo</hchild></heading1><paragraph><pchild>b]ar</pchild></paragraph>',
  355. '<paragraph><pchild>[]ar</pchild></paragraph>'
  356. );
  357. test(
  358. 'merges to the left if first element contains object (considers it as a content of that element)',
  359. '<heading1><hchild><widget></widget>[foo</hchild></heading1><paragraph><pchild>b]ar</pchild></paragraph>',
  360. '<heading1><hchild><widget></widget>[]ar</hchild></heading1>'
  361. );
  362. test(
  363. 'merges elements when left end deep nested',
  364. '<paragraph>x<pchild>fo[o</pchild></paragraph><paragraph>b]ary</paragraph><paragraph>x</paragraph>',
  365. '<paragraph>x<pchild>fo[]ary</pchild></paragraph><paragraph>x</paragraph>'
  366. );
  367. test(
  368. 'merges nested elements to the right (on multiple levels) if left side element would become empty',
  369. '<heading1><hchild>[foo</hchild></heading1><paragraph><pchild>b]ar</pchild>abc</paragraph>',
  370. '<paragraph><pchild>[]ar</pchild>abc</paragraph>'
  371. );
  372. test(
  373. 'merges to the right element when left end deep nested and will be empty',
  374. '<paragraph><pchild>[foo</pchild></paragraph><paragraph>b]ar</paragraph><paragraph>x</paragraph>',
  375. '<paragraph>[]ar</paragraph><paragraph>x</paragraph>'
  376. );
  377. test(
  378. 'merges elements when right end deep nested',
  379. '<paragraph>x</paragraph><paragraph>fo[o</paragraph><paragraph><pchild>b]ar</pchild>x</paragraph>',
  380. '<paragraph>x</paragraph><paragraph>fo[]ar</paragraph><paragraph>x</paragraph>'
  381. );
  382. test(
  383. 'removes element when right end deep nested but left end would be empty',
  384. '<paragraph>x</paragraph><paragraph>[foo</paragraph><paragraph><pchild>b]ar</pchild></paragraph>',
  385. '<paragraph>x</paragraph><paragraph><pchild>[]ar</pchild></paragraph>'
  386. );
  387. test(
  388. 'merges elements when right end deep nested (in an empty container)',
  389. '<paragraph>fo[o</paragraph><paragraph><pchild>bar]</pchild></paragraph>',
  390. '<paragraph>fo[]</paragraph>'
  391. );
  392. test(
  393. 'removes elements when left end deep nested (in an empty container)',
  394. '<paragraph><pchild>[foo</pchild></paragraph><paragraph>b]ar</paragraph><paragraph>x</paragraph>',
  395. '<paragraph>[]ar</paragraph><paragraph>x</paragraph>'
  396. );
  397. describe( 'with 3rd level of nesting', () => {
  398. test(
  399. 'merges elements when deep nested (same name)',
  400. '<pparent>x<paragraph>x<pchild>fo[o</pchild></paragraph></pparent>' +
  401. '<pparent><paragraph><pchild>b]ar</pchild>y</paragraph>y</pparent>',
  402. '<pparent>x<paragraph>x<pchild>fo[]ar</pchild>y</paragraph>y</pparent>'
  403. );
  404. test(
  405. 'removes elements when deep nested (same name)',
  406. '<pparent><paragraph><pchild>[foo</pchild></paragraph></pparent>' +
  407. '<pparent><paragraph><pchild>b]ar</pchild>y</paragraph>y</pparent>',
  408. '<pparent><paragraph><pchild>[]ar</pchild>y</paragraph>y</pparent>'
  409. );
  410. test(
  411. 'removes elements up to common ancestor when deep nested (same name)',
  412. '<pparent>' +
  413. '<paragraph><pchild>[foo</pchild></paragraph>' +
  414. '<paragraph><pchild>b]ar</pchild>y</paragraph>y' +
  415. '</pparent>',
  416. '<pparent><paragraph><pchild>[]ar</pchild>y</paragraph>y</pparent>'
  417. );
  418. test(
  419. 'merges elements when deep nested (different name)',
  420. '<pparent>x<heading1>x<hchild>fo[o</hchild></heading1></pparent>' +
  421. '<pparent><paragraph><pchild>b]ar</pchild>y</paragraph>y</pparent>',
  422. '<pparent>x<heading1>x<hchild>fo[]ar</hchild>y</heading1>y</pparent>'
  423. );
  424. test(
  425. 'removes elements when deep nested (different name)',
  426. '<pparent><heading1><hchild>[foo</hchild></heading1></pparent>' +
  427. '<pparent><paragraph><pchild>b]ar</pchild>y</paragraph>y</pparent>',
  428. '<pparent><paragraph><pchild>[]ar</pchild>y</paragraph>y</pparent>'
  429. );
  430. test(
  431. 'merges elements up to common ancestor when deep nested (different names)',
  432. '<pparent>' +
  433. '<heading1><hchild>fo[o</hchild></heading1>' +
  434. '<paragraph><pchild>b]ar</pchild></paragraph>' +
  435. '</pparent>',
  436. '<pparent><heading1><hchild>fo[]ar</hchild></heading1></pparent>'
  437. );
  438. test(
  439. 'removes elements up to common ancestor when deep nested (different names)',
  440. '<pparent>' +
  441. '<heading1><hchild>[foo</hchild></heading1>' +
  442. '<paragraph><pchild>b]ar</pchild>y</paragraph>y' +
  443. '</pparent>',
  444. '<pparent><paragraph><pchild>[]ar</pchild>y</paragraph>y</pparent>'
  445. );
  446. } );
  447. describe( 'with 3rd level of nesting o the left end', () => {
  448. test(
  449. 'merges elements',
  450. '<pparent>x<paragraph>foo<pchild>ba[r</pchild></paragraph></pparent>' +
  451. '<paragraph>b]om</paragraph>',
  452. '<pparent>x<paragraph>foo<pchild>ba[]om</pchild></paragraph></pparent>'
  453. );
  454. test(
  455. 'merges elements (different names)',
  456. '<pparent>x<heading1>foo<hchild>ba[r</hchild></heading1></pparent>' +
  457. '<paragraph>b]om</paragraph>',
  458. '<pparent>x<heading1>foo<hchild>ba[]om</hchild></heading1></pparent>'
  459. );
  460. test(
  461. 'removes elements',
  462. '<pparent><paragraph><pchild>[bar</pchild></paragraph></pparent>' +
  463. '<paragraph>b]om</paragraph>',
  464. '<paragraph>[]om</paragraph>'
  465. );
  466. test(
  467. 'removes elements up to common ancestor (different names)',
  468. '<pparent>' +
  469. '<heading1><hchild>[foo</hchild></heading1>' +
  470. '<paragraph>b]ar</paragraph>y' +
  471. '</pparent>',
  472. '<pparent><paragraph>[]ar</paragraph>y</pparent>'
  473. );
  474. } );
  475. describe( 'with 3rd level of nesting o the right end', () => {
  476. test(
  477. 'merges elements',
  478. '<paragraph>b[om</paragraph>' +
  479. '<pparent><paragraph><pchild>ba]r</pchild></paragraph></pparent>',
  480. '<paragraph>b[]r</paragraph>'
  481. );
  482. test(
  483. 'merges elements (different names)',
  484. '<paragraph>bo[m</paragraph>' +
  485. '<pparent><heading1><hchild>b]ar</hchild></heading1></pparent>',
  486. '<paragraph>bo[]ar</paragraph>'
  487. );
  488. test(
  489. 'merges elements (different names, reversed)',
  490. '<heading1>bo[m</heading1>' +
  491. '<pparent><paragraph><pchild>b]ar</pchild></paragraph></pparent>',
  492. '<heading1>bo[]ar</heading1>'
  493. );
  494. test(
  495. 'removes elements',
  496. '<paragraph>[bom</paragraph>' +
  497. '<pparent><paragraph><pchild>b]ar</pchild></paragraph></pparent>',
  498. '<pparent><paragraph><pchild>[]ar</pchild></paragraph></pparent>'
  499. );
  500. test(
  501. 'removes elements up to common ancestor (different names)',
  502. '<pparent>' +
  503. '<heading1>[bar</heading1>y' +
  504. '<paragraph><pchild>f]oo</pchild></paragraph>' +
  505. '</pparent>',
  506. '<pparent><paragraph><pchild>[]oo</pchild></paragraph></pparent>'
  507. );
  508. } );
  509. } );
  510. describe( 'with object elements', () => {
  511. beforeEach( () => {
  512. const schema = model.schema;
  513. schema.register( 'blockWidget', {
  514. isObject: true
  515. } );
  516. schema.register( 'nestedEditable', {
  517. isLimit: true
  518. } );
  519. schema.extend( 'blockWidget', { allowIn: '$root' } );
  520. schema.extend( 'nestedEditable', { allowIn: 'blockWidget' } );
  521. schema.extend( '$text', { allowIn: 'nestedEditable' } );
  522. } );
  523. test(
  524. 'does not merge an object element (if it is first)',
  525. '<blockWidget><nestedEditable>fo[o</nestedEditable></blockWidget><paragraph>b]ar</paragraph>',
  526. '<blockWidget><nestedEditable>fo[]</nestedEditable></blockWidget><paragraph>ar</paragraph>'
  527. );
  528. test(
  529. 'does not merge an object element (if it is second)',
  530. '<paragraph>ba[r</paragraph><blockWidget><nestedEditable>f]oo</nestedEditable></blockWidget>',
  531. '<paragraph>ba[]</paragraph><blockWidget><nestedEditable>oo</nestedEditable></blockWidget>'
  532. );
  533. } );
  534. describe( 'filtering out', () => {
  535. beforeEach( () => {
  536. const schema = model.schema;
  537. schema.addAttributeCheck( ( ctx, attributeName ) => {
  538. // Disallow 'c' on pchild>pchild>$text.
  539. if ( ctx.endsWith( 'pchild pchild $text' ) && attributeName == 'c' ) {
  540. return false;
  541. }
  542. // Allow 'a' and 'b' on paragraph>$text.
  543. if ( ctx.endsWith( 'paragraph $text' ) && [ 'a', 'b' ].includes( attributeName ) ) {
  544. return true;
  545. }
  546. // Allow 'b' and 'c' in pchild>$text.
  547. if ( ctx.endsWith( 'pchild $text' ) && [ 'b', 'c' ].includes( attributeName ) ) {
  548. return true;
  549. }
  550. } );
  551. schema.extend( 'pchild', { allowIn: 'pchild' } );
  552. } );
  553. test(
  554. 'filters out disallowed attributes after left merge',
  555. '<paragraph>x<pchild>fo[o</pchild></paragraph><paragraph>y]<$text a="1" b="1">z</$text></paragraph>',
  556. '<paragraph>x<pchild>fo[]<$text b="1">z</$text></pchild></paragraph>'
  557. );
  558. test(
  559. 'filters out disallowed attributes from nested nodes after left merge',
  560. '<paragraph>' +
  561. 'x' +
  562. '<pchild>fo[o</pchild>' +
  563. '</paragraph>' +
  564. '<paragraph>' +
  565. 'b]a<$text a="1" b="1">r</$text>' +
  566. '<pchild>b<$text b="1" c="1">i</$text>z</pchild>' +
  567. 'y' +
  568. '</paragraph>',
  569. '<paragraph>' +
  570. 'x' +
  571. '<pchild>' +
  572. 'fo[]a<$text b="1">r</$text>' +
  573. '<pchild>b<$text b="1">i</$text>z</pchild>' +
  574. 'y' +
  575. '</pchild>' +
  576. '</paragraph>'
  577. );
  578. test(
  579. 'filters out disallowed attributes after right merge',
  580. '<paragraph>fo[o</paragraph><paragraph><pchild>x<$text b="1" c="1">y]z</$text></pchild></paragraph>',
  581. '<paragraph>fo[]<$text b="1">z</$text></paragraph>'
  582. );
  583. } );
  584. } );
  585. describe( 'in element selections scenarios', () => {
  586. beforeEach( () => {
  587. model = new Model();
  588. doc = model.document;
  589. // <p> like root.
  590. doc.createRoot( 'paragraph', 'paragraphRoot' );
  591. // <body> like root.
  592. doc.createRoot( '$root', 'bodyRoot' );
  593. // Special root which allows only blockWidgets inside itself.
  594. doc.createRoot( 'restrictedRoot', 'restrictedRoot' );
  595. const schema = model.schema;
  596. schema.register( 'image', { allowWhere: '$text' } );
  597. schema.register( 'paragraph', { inheritAllFrom: '$block' } );
  598. schema.register( 'heading1', { inheritAllFrom: '$block' } );
  599. schema.register( 'blockWidget', { isLimit: true } );
  600. schema.register( 'restrictedRoot', {
  601. isLimit: true
  602. } );
  603. schema.extend( '$block', { allowIn: '$root' } );
  604. schema.extend( 'blockWidget', { allowIn: '$root' } );
  605. schema.extend( 'blockWidget', { allowIn: 'restrictedRoot' } );
  606. } );
  607. // See also "in simple scenarios => deletes an element".
  608. it( 'deletes two inline elements', () => {
  609. model.schema.extend( 'paragraph', {
  610. isLimit: true
  611. } );
  612. setData(
  613. model,
  614. 'x[<image></image><image></image>]z',
  615. { rootName: 'paragraphRoot' }
  616. );
  617. deleteContent( model, doc.selection );
  618. expect( getData( model, { rootName: 'paragraphRoot' } ) )
  619. .to.equal( 'x[]z' );
  620. } );
  621. it( 'moves the (custom) selection to the nearest paragraph', () => {
  622. setData(
  623. model,
  624. '<paragraph>[x]</paragraph><paragraph>yyy</paragraph><paragraph>z</paragraph>',
  625. { rootName: 'bodyRoot' }
  626. );
  627. const root = doc.getRoot( 'bodyRoot' );
  628. // [<paragraph>yyy</paragraph>]
  629. const selection = new Selection( [
  630. new Range( new Position( root, [ 1 ] ), new Position( root, [ 2 ] ) )
  631. ] );
  632. deleteContent( model, selection );
  633. expect( getData( model, { rootName: 'bodyRoot' } ) )
  634. .to.equal( '<paragraph>[x]</paragraph><paragraph></paragraph><paragraph>z</paragraph>' );
  635. expect( stringify( root, selection ) )
  636. .to.equal( '<$root><paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>z</paragraph></$root>' );
  637. } );
  638. it( 'creates a paragraph when text is not allowed (block widget selected)', () => {
  639. setData(
  640. model,
  641. '<paragraph>x</paragraph>[<blockWidget></blockWidget>]<paragraph>z</paragraph>',
  642. { rootName: 'bodyRoot' }
  643. );
  644. deleteContent( model, doc.selection );
  645. expect( getData( model, { rootName: 'bodyRoot' } ) )
  646. .to.equal( '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>z</paragraph>' );
  647. } );
  648. it( 'creates paragraph when text is not allowed (heading selected)', () => {
  649. setData(
  650. model,
  651. '<paragraph>x</paragraph><heading1>yyy</heading1><paragraph>z</paragraph>',
  652. { rootName: 'bodyRoot' }
  653. );
  654. // [<heading1>yyy</heading1>]
  655. const range = new Range(
  656. new Position( doc.getRoot( 'bodyRoot' ), [ 1 ] ),
  657. new Position( doc.getRoot( 'bodyRoot' ), [ 2 ] )
  658. );
  659. deleteContent( model, new Selection( range ) );
  660. expect( getData( model, { rootName: 'bodyRoot', withoutSelection: true } ) )
  661. .to.equal( '<paragraph>x</paragraph><paragraph></paragraph><paragraph>z</paragraph>' );
  662. } );
  663. it( 'creates paragraph when text is not allowed (two blocks selected)', () => {
  664. setData(
  665. model,
  666. '<paragraph>x</paragraph><heading1>yyy</heading1><paragraph>yyy</paragraph><paragraph>z</paragraph>',
  667. { rootName: 'bodyRoot' }
  668. );
  669. // [<heading1>yyy</heading1><paragraph>yyy</paragraph>]
  670. const range = new Range(
  671. new Position( doc.getRoot( 'bodyRoot' ), [ 1 ] ),
  672. new Position( doc.getRoot( 'bodyRoot' ), [ 3 ] )
  673. );
  674. deleteContent( model, new Selection( range ) );
  675. expect( getData( model, { rootName: 'bodyRoot', withoutSelection: true } ) )
  676. .to.equal( '<paragraph>x</paragraph><paragraph></paragraph><paragraph>z</paragraph>' );
  677. } );
  678. it( 'creates paragraph when text is not allowed (all content selected)', () => {
  679. setData(
  680. model,
  681. '[<heading1>x</heading1><paragraph>z</paragraph>]',
  682. { rootName: 'bodyRoot' }
  683. );
  684. deleteContent( model, doc.selection );
  685. expect( getData( model, { rootName: 'bodyRoot' } ) )
  686. .to.equal( '<paragraph>[]</paragraph>' );
  687. } );
  688. it( 'does not create a paragraph when it is not allowed', () => {
  689. setData(
  690. model,
  691. '<blockWidget></blockWidget>[<blockWidget></blockWidget>]<blockWidget></blockWidget>',
  692. { rootName: 'restrictedRoot' }
  693. );
  694. deleteContent( model, doc.selection );
  695. expect( getData( model, { rootName: 'restrictedRoot' } ) )
  696. .to.equal( '<blockWidget></blockWidget>[]<blockWidget></blockWidget>' );
  697. } );
  698. it( 'does not create a paragraph when doNotAutoparagraph option is set to true', () => {
  699. setData(
  700. model,
  701. '<paragraph>x</paragraph>[<blockWidget></blockWidget>]<paragraph>z</paragraph>',
  702. { rootName: 'bodyRoot' }
  703. );
  704. deleteContent( model, doc.selection, { doNotAutoparagraph: true } );
  705. expect( getData( model, { rootName: 'bodyRoot' } ) )
  706. .to.equal( '<paragraph>x[]</paragraph><paragraph>z</paragraph>' );
  707. } );
  708. it( 'does not create a paragraph when after deletion there is no valid selection range (empty root)', () => {
  709. setData(
  710. model,
  711. '[<blockWidget></blockWidget>]',
  712. { rootName: 'bodyRoot' }
  713. );
  714. deleteContent( model, doc.selection, { doNotAutoparagraph: true } );
  715. expect( getData( model, { rootName: 'bodyRoot' } ) )
  716. .to.equal( '[]' );
  717. } );
  718. } );
  719. describe( 'integration with inline limit elements', () => {
  720. beforeEach( () => {
  721. model = new Model();
  722. doc = model.document;
  723. doc.createRoot();
  724. const schema = model.schema;
  725. schema.register( 'inlineLimit', {
  726. isLimit: true,
  727. allowIn: '$root'
  728. } );
  729. schema.extend( '$text', {
  730. allowIn: [ 'inlineLimit', '$root', 'x' ]
  731. } );
  732. schema.register( 'x', { allowIn: '$root' } );
  733. } );
  734. test(
  735. 'should delete inside inline limit element',
  736. '<inlineLimit>foo [bar] baz</inlineLimit>',
  737. '<inlineLimit>foo [] baz</inlineLimit>'
  738. );
  739. test(
  740. 'should delete whole inline limit element',
  741. 'x[<inlineLimit>foo bar</inlineLimit>]x',
  742. 'x[]x'
  743. );
  744. test(
  745. 'should delete from two inline limit elements',
  746. '<inlineLimit>foo [bar</inlineLimit><inlineLimit>baz] qux</inlineLimit>',
  747. '<inlineLimit>foo []</inlineLimit><inlineLimit> qux</inlineLimit>'
  748. );
  749. test(
  750. 'merge option should be ignored if both elements are limits',
  751. '<inlineLimit>foo [bar</inlineLimit><inlineLimit>baz] qux</inlineLimit>',
  752. '<inlineLimit>foo []</inlineLimit><inlineLimit> qux</inlineLimit>'
  753. );
  754. test(
  755. 'merge option should be ignored if the first element is a limit',
  756. '<inlineLimit>foo [bar</inlineLimit><x>baz] qux</x>',
  757. '<inlineLimit>foo []</inlineLimit><x> qux</x>'
  758. );
  759. test(
  760. 'merge option should be ignored if the second element is a limit',
  761. '<x>baz [qux</x><inlineLimit>foo] bar</inlineLimit>',
  762. '<x>baz []</x><inlineLimit> bar</inlineLimit>'
  763. );
  764. } );
  765. describe( 'integration with block limit elements', () => {
  766. beforeEach( () => {
  767. model = new Model();
  768. doc = model.document;
  769. doc.createRoot();
  770. const schema = model.schema;
  771. schema.register( 'blockLimit', {
  772. isLimit: true
  773. } );
  774. schema.extend( 'blockLimit', { allowIn: '$root' } );
  775. schema.extend( '$block', { allowIn: 'blockLimit' } );
  776. schema.register( 'paragraph', { inheritAllFrom: '$block' } );
  777. schema.register( 'blockQuote', {
  778. allowWhere: '$block',
  779. allowContentOf: '$root'
  780. } );
  781. } );
  782. test(
  783. 'should delete inside block limit element',
  784. '<blockLimit><paragraph>fo[o</paragraph><paragraph>b]ar</paragraph></blockLimit>',
  785. '<blockLimit><paragraph>fo[]</paragraph><paragraph>ar</paragraph></blockLimit>',
  786. { leaveUnmerged: true }
  787. );
  788. test(
  789. 'should delete inside block limit element (with merge)',
  790. '<blockLimit><paragraph>fo[o</paragraph><paragraph>b]ar</paragraph></blockLimit>',
  791. '<blockLimit><paragraph>fo[]ar</paragraph></blockLimit>'
  792. );
  793. test(
  794. 'should delete whole block limit element',
  795. '<paragraph>x</paragraph>[<blockLimit><paragraph>foo</paragraph></blockLimit>]<paragraph>x</paragraph>',
  796. '<paragraph>x</paragraph><paragraph>[]</paragraph><paragraph>x</paragraph>'
  797. );
  798. test(
  799. 'should delete from two block limit elements',
  800. '<blockLimit><paragraph>foo [bar</paragraph></blockLimit><blockLimit><paragraph>baz] qux</paragraph></blockLimit>',
  801. '<blockLimit><paragraph>foo []</paragraph></blockLimit><blockLimit><paragraph> qux</paragraph></blockLimit>'
  802. );
  803. test(
  804. 'merge option should be ignored if any of the elements is a limit',
  805. '<blockLimit><paragraph>foo [bar</paragraph></blockLimit><blockLimit><paragraph>baz] qux</paragraph></blockLimit>',
  806. '<blockLimit><paragraph>foo []</paragraph></blockLimit><blockLimit><paragraph> qux</paragraph></blockLimit>'
  807. );
  808. // See: https://github.com/ckeditor/ckeditor5/issues/1265.
  809. it( 'should proper merge two elements which are inside limit element', () => {
  810. setData( model,
  811. '<blockLimit>' +
  812. '<blockQuote>' +
  813. '<paragraph>Foo</paragraph>' +
  814. '</blockQuote>' +
  815. '<paragraph>[]Bar</paragraph>' +
  816. '</blockLimit>'
  817. );
  818. model.modifySelection( doc.selection, { direction: 'backward' } );
  819. deleteContent( model, doc.selection );
  820. expect( getData( model ) ).to.equal(
  821. '<blockLimit>' +
  822. '<blockQuote>' +
  823. '<paragraph>Foo[]Bar</paragraph>' +
  824. '</blockQuote>' +
  825. '</blockLimit>' );
  826. } );
  827. it( 'should proper merge elements which are inside limit element (nested elements)', () => {
  828. setData( model,
  829. '<blockQuote>' +
  830. '<blockLimit>' +
  831. '<blockQuote>' +
  832. '<paragraph>Foo.</paragraph>' +
  833. '<blockQuote>' +
  834. '<paragraph>Foo</paragraph>' +
  835. '</blockQuote>' +
  836. '</blockQuote>' +
  837. '<paragraph>[]Bar</paragraph>' +
  838. '</blockLimit>' +
  839. '</blockQuote>'
  840. );
  841. model.modifySelection( doc.selection, { direction: 'backward' } );
  842. deleteContent( model, doc.selection );
  843. expect( getData( model ) ).to.equal(
  844. '<blockQuote>' +
  845. '<blockLimit>' +
  846. '<blockQuote>' +
  847. '<paragraph>Foo.</paragraph>' +
  848. '<blockQuote>' +
  849. '<paragraph>Foo[]Bar</paragraph>' +
  850. '</blockQuote>' +
  851. '</blockQuote>' +
  852. '</blockLimit>' +
  853. '</blockQuote>'
  854. );
  855. } );
  856. } );
  857. describe( 'should leave a paragraph if the entire content was selected', () => {
  858. beforeEach( () => {
  859. model = new Model();
  860. doc = model.document;
  861. doc.createRoot();
  862. const schema = model.schema;
  863. schema.register( 'div', {
  864. inheritAllFrom: '$block',
  865. isLimit: true
  866. } );
  867. schema.register( 'article', {
  868. inheritAllFrom: '$block',
  869. isLimit: true
  870. } );
  871. schema.register( 'image', {
  872. allowWhere: '$text',
  873. isObject: true
  874. } );
  875. schema.register( 'paragraph', { inheritAllFrom: '$block' } );
  876. schema.register( 'heading1', { inheritAllFrom: '$block' } );
  877. schema.register( 'heading2', { inheritAllFrom: '$block' } );
  878. schema.extend( '$text', { allowIn: '$root' } );
  879. schema.extend( 'image', { allowIn: '$root' } );
  880. schema.extend( 'image', { allowIn: 'heading1' } );
  881. schema.extend( 'heading1', { allowIn: 'div' } );
  882. schema.extend( 'paragraph', { allowIn: 'div' } );
  883. schema.extend( 'heading1', { allowIn: 'article' } );
  884. schema.extend( 'heading2', { allowIn: 'article' } );
  885. } );
  886. test(
  887. 'but not if only one block was selected',
  888. '<heading1>[xx]</heading1>',
  889. '<heading1>[]</heading1>'
  890. );
  891. test(
  892. 'when the entire heading and paragraph were selected',
  893. '<heading1>[xx</heading1><paragraph>yy]</paragraph>',
  894. '<paragraph>[]</paragraph>'
  895. );
  896. test(
  897. 'when the entire content was selected',
  898. '<heading1>[x</heading1><paragraph>foo</paragraph><paragraph>y]</paragraph>',
  899. '<paragraph>[]</paragraph>'
  900. );
  901. test(
  902. 'inside the limit element when the entire heading and paragraph were inside',
  903. '<div><heading1>[xx</heading1><paragraph>yy]</paragraph></div>',
  904. '<div><paragraph>[]</paragraph></div>'
  905. );
  906. test(
  907. 'but not if schema does not accept paragraph in limit element',
  908. '<article><heading1>[xx</heading1><heading2>yy]</heading2></article>',
  909. '<article><heading1>[]</heading1></article>'
  910. );
  911. test(
  912. 'but not if selection is not containing the whole content',
  913. '<image></image><heading1>[xx</heading1><paragraph>yy]</paragraph>',
  914. '<image></image><heading1>[]</heading1>'
  915. );
  916. test(
  917. 'but not if only single element is selected',
  918. '<heading1>[<image></image>xx]</heading1>',
  919. '<heading1>[]</heading1>'
  920. );
  921. it( 'when root element was not added as Schema limits work fine as well', () => {
  922. doc.createRoot( 'paragraph', 'paragraphRoot' );
  923. setData(
  924. model,
  925. 'x[<image></image><image></image>]z',
  926. { rootName: 'paragraphRoot' }
  927. );
  928. deleteContent( model, doc.selection );
  929. expect( getData( model, { rootName: 'paragraphRoot' } ) )
  930. .to.equal( 'x[]z' );
  931. } );
  932. test(
  933. 'but not if the flag "doNotResetEntireContent" is set to true',
  934. '<heading1>[</heading1><paragraph>]</paragraph>',
  935. '<heading1>[]</heading1>',
  936. {
  937. doNotResetEntireContent: true
  938. }
  939. );
  940. } );
  941. function test( title, input, output, options ) {
  942. it( title, () => {
  943. model.enqueueChange( 'transparent', () => {
  944. setData( model, input );
  945. deleteContent( model, doc.selection, options );
  946. } );
  947. expect( getData( model ) ).to.equal( output );
  948. } );
  949. }
  950. } );
  951. } );