| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046 |
- /**
- * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
- * For licensing, see LICENSE.md.
- */
- /* globals document, window, NodeFilter */
- import View from '../../src/view/view';
- import ViewElement from '../../src/view/element';
- import ViewContainerElement from '../../src/view/containerelement';
- import ViewAttributeElement from '../../src/view/attributeelement';
- import ViewText from '../../src/view/text';
- import ViewRange from '../../src/view/range';
- import ViewPosition from '../../src/view/position';
- import DocumentSelection from '../../src/view/documentselection';
- import DomConverter from '../../src/view/domconverter';
- import Renderer from '../../src/view/renderer';
- import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
- import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
- import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
- import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
- import createViewRoot from './_utils/createroot';
- import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
- import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
- testUtils.createSinonSandbox();
- describe( 'Renderer', () => {
- let selection, domConverter, renderer;
- beforeEach( () => {
- selection = new DocumentSelection();
- domConverter = new DomConverter();
- renderer = new Renderer( domConverter, selection );
- renderer.domDocuments.add( document );
- } );
- describe( 'markToSync', () => {
- let viewRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( 'p' );
- const domRoot = document.createElement( 'p' );
- domConverter.bindElements( domRoot, viewRoot );
- viewRoot._appendChildren( new ViewText( 'foo' ) );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- } );
- it( 'should mark attributes which need update', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
- } );
- it( 'should mark children which need update', () => {
- viewRoot._appendChildren( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
- } );
- it( 'should not mark children if element has no corresponding node', () => {
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( 'p' );
- viewRoot._appendChildren( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
- } );
- it( 'should mark text which need update', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChildren( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.true;
- } );
- it( 'should not mark text if parent has no corresponding node', () => {
- const viewText = new ViewText( 'foo' );
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( 'p' );
- viewRoot._appendChildren( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.false;
- } );
- it( 'should throw if the type is unknown', () => {
- expect( () => {
- renderer.markToSync( 'UNKNOWN', viewRoot );
- } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
- } );
- } );
- describe( 'render', () => {
- let viewRoot, domRoot, selectionEditable;
- beforeEach( () => {
- viewRoot = new ViewElement( 'div' );
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- domConverter.bindElements( domRoot, viewRoot );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- selection._setTo( null );
- selectionEditable = viewRoot;
- renderer.isFocused = true;
- // Fake selection editable - it is needed to render selection properly.
- Object.defineProperty( selection, 'editableElement', {
- get() {
- return selectionEditable;
- }
- } );
- } );
- afterEach( () => {
- domRoot.remove();
- } );
- it( 'should update attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should remove attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- domRoot.setAttribute( 'id', 'bar' );
- domRoot.setAttribute( 'class', 'bar' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should add children', () => {
- viewRoot._appendChildren( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should remove children', () => {
- viewRoot._appendChildren( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should update text', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChildren( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should not update text parent child list changed', () => {
- const viewImg = new ViewElement( 'img' );
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChildren( [ viewImg, viewText ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
- expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
- } );
- it( 'should not change text if it is the same during text rendering', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChildren( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change text if it is the same during children rendering', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChildren( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change element if it is the same', () => {
- const viewImg = new ViewElement( 'img' );
- viewRoot._appendChildren( viewImg );
- // This should not be changed during the render.
- const domImg = document.createElement( 'img' );
- domRoot.appendChild( domImg );
- domConverter.bindElements( domImg, viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
- } );
- it( 'should change element if it is different', () => {
- const viewImg = new ViewElement( 'img' );
- viewRoot._appendChildren( viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const viewP = new ViewElement( 'p' );
- viewRoot._removeChildren( 0, 1 );
- viewRoot._appendChildren( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
- } );
- it( 'should update removed item when it is reinserted', () => {
- const viewFoo = new ViewText( 'foo' );
- const viewP = new ViewElement( 'p', null, viewFoo );
- const viewDiv = new ViewElement( 'div', null, viewP );
- viewRoot._appendChildren( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- viewP._removeChildren( 0, 1 );
- viewDiv._appendChildren( viewP );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDiv = domRoot.childNodes[ 0 ];
- expect( domDiv.tagName ).to.equal( 'DIV' );
- expect( domDiv.childNodes.length ).to.equal( 1 );
- const domP = domDiv.childNodes[ 0 ];
- expect( domP.tagName ).to.equal( 'P' );
- expect( domP.childNodes.length ).to.equal( 0 );
- } );
- it( 'should update removed item when it is reinserted #2', () => {
- // Prepare view: root -> div "outer" -> div "inner" -> p.
- const viewP = new ViewElement( 'p' );
- const viewDivInner = new ViewElement( 'div', null, viewP );
- const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
- viewRoot._appendChildren( viewDivOuter );
- // Render view tree to DOM.
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove div "outer" from root and render it.
- viewDivOuter._remove();
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
- viewP._remove();
- // Add div "outer" back to root.
- viewRoot._appendChildren( viewDivOuter );
- renderer.markToSync( 'children', viewRoot );
- // Render changes, view is: root -> div "outer" -> div "inner".
- renderer.render();
- // Same is expected in DOM.
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDivOuter = domRoot.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
- expect( domDivOuter.tagName ).to.equal( 'DIV' );
- expect( domDivOuter.childNodes.length ).to.equal( 1 );
- const domDivInner = domDivOuter.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
- expect( domDivInner.tagName ).to.equal( 'DIV' );
- expect( domDivInner.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
- const viewFoo = new ViewText( 'foo' );
- const viewP = new ViewElement( 'p', null, viewFoo );
- const viewDiv = new ViewElement( 'div', null, viewP );
- viewRoot._appendChildren( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- viewP._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not care about filler if there is no DOM', () => {
- selectionEditable = null;
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- const viewRoot = new ViewElement( 'p' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Expect no error on render.
- expect( viewRoot ).to.be.ok;
- } );
- it( 'should not add filler when inside contenteditable=false parent', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should not add filler when inside contenteditable=false ancestor', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p>foo{}<b></b></p>
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>{}foo</b></p>
- selection._setTo( ViewRange.createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>foo{}</b></p>
- selection._setTo( ViewRange.createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should move filler when selection is moved', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
- // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
- const viewI = viewP.getChild( 2 );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- it( 'should remove filler when text is added and selection removed', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- const viewB = viewP.getChild( 1 );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Add text node.
- const viewText = new ViewText( 'x' );
- viewB._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- // Step 3: Remove selection from the view.
- selection._setTo( null );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
- } );
- // #659
- // The element before the filler is removed so the position of the filler
- // cannot be remembered as parent+offset.
- it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
- // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
- viewP._removeChildren( 1 );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether there's no filler in the DOM.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
- } );
- // #659
- it( 'should remove filler from a modified DOM when children moved', () => {
- // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
- const { view: viewFragment, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
- );
- viewRoot._appendChildren( viewFragment );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const domP = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
- // <p>[]</p><p><b>foo</b><b>bar</b></p>
- const viewP = viewRoot.getChild( 0 );
- const viewP2 = viewRoot.getChild( 1 );
- const removedChildren = viewP._removeChildren( 0, 2 );
- viewP2._appendChildren( removedChildren );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.markToSync( 'children', viewP2 );
- renderer.render();
- // Step 3: Check whether in the first paragraph there's a <br> filler and that
- // in the second one there are two <b> tags.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
- expect( domP2.childNodes.length ).to.equal( 2 );
- expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
- // in one of ckeditor/ckeditor5-typing#59 automated tests.
- it( 'should not break when selection is moved to a new element, when filler exists', () => {
- // Step 1: <p>bar<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element and remove the previous one
- viewP._removeChildren( 1 ); // Remove <b>.
- const viewI = parse( '<attribute:i></attribute:i>' );
- viewP._appendChildren( viewI );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether new filler was created in the <i> element.
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
- // that has not been yet rendered/bound to DOM.
- it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
- // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element.
- const viewAbc = parse( 'abc' );
- viewP._appendChildren( viewAbc );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether old filler was removed.
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove filler and add text node to both DOM and View <p>x{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( document.createTextNode( 'x' ) );
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( 'x' );
- viewP._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty block, render if needed', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Add text node only in View <p>x{}</p>
- const viewText = new ViewText( 'x' );
- viewP._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle removing last character', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove text and add filler to both DOM and View <p>{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- viewP._removeChildren( 0 );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
- domB.childNodes[ 0 ].data += 'x';
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( 'x' );
- viewB._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute as a children change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- domSelection.removeAllRanges();
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( 'x' );
- viewB._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const firstRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- };
- const assertSelectionInsideTextNode = () => {
- expect( firstRange.startContainer ).to.equal( domB );
- expect( firstRange.startOffset ).to.equal( 1 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( firstRange.collapsed ).to.be.true;
- } );
- it( 'should handle typing in empty attribute as a text change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( 'x' );
- viewB._appendChildren( viewText );
- selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- // 4. Check the DOM.
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle not collapsed range', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should not change selection if there is no editable with selection', () => {
- const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
- document.body.appendChild( domDiv );
- domDiv.focus();
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- domSelection.collapse( domDiv, 0 );
- selectionEditable = null;
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domRange.startOffset ).to.equal( 0 );
- expect( domRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not change selection if there is no focus', () => {
- const domDiv = createElement( document, 'div', null, 'not editable' );
- document.body.appendChild( domDiv );
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domDiv, 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- renderer.isFocused = false;
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domSelectionRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelectionRange.startOffset ).to.equal( 0 );
- expect( domSelectionRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not add inline filler after text node', () => {
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should throw if there is no filler in expected position', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- const viewB = viewP.getChild( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Remove filler.
- domB.childNodes[ 0 ].data = '';
- selection._setTo( null );
- renderer.markToSync( 'children', viewB );
- expect( () => {
- renderer.render();
- } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
- } );
- // #1014.
- it( 'should create inline filler in newly created dom nodes', () => {
- // 1. Create the view structure which needs inline filler.
- const inputView =
- '<container:ul>' +
- '<container:li>Foobar.</container:li>' +
- '<container:li>[]<container:div></container:div></container:li>' +
- '</container:ul>';
- const { view: view, selection: newSelection } = parse( inputView );
- viewRoot._appendChildren( view );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check if filler element has been (correctly) created.
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- // 3. Move the inline filler parent to a newly created element.
- const viewLi = view.getChild( 0 );
- const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
- const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
- viewLi._appendChildren( viewUl );
- // 4. Mark changed items and render the view.
- renderer.markToSync( 'children', view );
- renderer.markToSync( 'children', viewLi );
- renderer.render();
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- const domSelection = document.getSelection();
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
- } );
- it( 'should handle focusing element', () => {
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- const editable = selection.editableElement;
- renderer.render();
- expect( editable ).to.equal( viewRoot );
- expect( domFocusSpy.calledOnce ).to.be.true;
- } );
- it( 'should not focus editable if isFocues is set to false', () => {
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.isFocused = false;
- renderer.render();
- expect( domFocusSpy.calledOnce ).to.be.false;
- } );
- it( 'should not focus already focused DOM element', () => {
- domRoot.setAttribute( 'contentEditable', true );
- domRoot.focus();
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.render();
- expect( domFocusSpy.called ).to.be.false;
- } );
- describe( 'fake selection', () => {
- beforeEach( () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[foo bar]</container:p>'
- );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- } );
- it( 'should render fake selection', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( domConverter.mapDomToView( container ) ).to.be.undefined;
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
- } );
- it( 'should render if no selection label is provided', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( '\u00A0' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
- } );
- it( 'should remove fake selection container when selection is no longer fake', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domParagraph = domRoot.childNodes[ 0 ];
- expect( domParagraph.childNodes.length ).to.equal( 1 );
- expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
- } );
- it( 'should reuse fake selection container #1', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- } );
- it( 'should reuse fake selection container #2', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should reuse fake selection container #3', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should style fake selection container properly', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.style.position ).to.equal( 'fixed' );
- expect( container.style.top ).to.equal( '0px' );
- expect( container.style.left ).to.equal( '-9999px' );
- } );
- it( 'should bind fake selection container to view selection', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- const bindSelection = renderer.domConverter.fakeSelectionToView( container );
- expect( bindSelection ).to.not.be.undefined;
- expect( bindSelection.isEqual( selection ) ).to.be.true;
- } );
- // Use a forgiving way of checking what the selection contains
- // because Safari normalizes the selection ranges so precise checking is troublesome.
- // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
- function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
- const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
- expect( domSelection.toString() ).to.match( expectedText );
- expect(
- domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
- ).to.be.true;
- }
- } );
- // #887
- describe( 'similar selection', () => {
- // Use spies to check selection updates. Some selection positions are not achievable in some
- // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
- let selectionCollapseSpy, selectionExtendSpy;
- afterEach( () => {
- if ( selectionCollapseSpy ) {
- selectionCollapseSpy.restore();
- selectionCollapseSpy = null;
- }
- if ( selectionExtendSpy ) {
- selectionExtendSpy.restore();
- selectionExtendSpy = null;
- }
- } );
- it( 'should always render collapsed selection even if it is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- } );
- it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{}<attribute:b></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- } );
- it( 'should always render non-collapsed selection if it not is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
- } );
- it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
- // Do not change view selection.
- // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
- // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
- // because DOM selection is in incorrect place.
- const domP = domRoot.childNodes[ 0 ];
- const domSpan = domP.childNodes[ 1 ];
- domSelection.collapse( domSpan, 0 );
- renderer.render();
- // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelection.anchorNode ).to.equal( domP );
- expect( domSelection.anchorOffset ).to.equal( 1 );
- };
- const assertSelectionInsideTextNode = () => {
- const textNode = domP.childNodes[ 0 ];
- expect( domSelection.anchorNode ).to.equal( textNode );
- expect( domSelection.anchorOffset ).to.equal( 3 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
- viewRoot._appendChildren( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- } );
- } );
- describe( '#922', () => {
- let view, viewDoc, viewRoot, domRoot, converter;
- beforeEach( () => {
- view = new View();
- viewDoc = view.document;
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- viewRoot = createViewRoot( viewDoc );
- view.attachDomRoot( domRoot );
- converter = view.domConverter;
- } );
- it( 'should properly render unwrapped attributes #1', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>f</attribute:strong>' +
- '</attribute:italic>]' +
- '<attribute:strong>oo</attribute:strong>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.render();
- // Unwrap italic attribute element.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.render();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render unwrapped attributes #2', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>foo</attribute:strong>' +
- '</attribute:italic>]' +
- '</container:p>' );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.render();
- // Unwrap italic attribute element and change text inside.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
- } );
- viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
- expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.render();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #1', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.render();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
- // Re-render changes in view to DOM.
- view.render();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #2', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.render();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
- // Re-render changes in view to DOM.
- view.render();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should not unbind elements that are removed and reinserted to DOM', () => {
- setViewData( view,
- '<container:p>' +
- '<attribute:b></attribute:b>' +
- '<attribute:i></attribute:i>' +
- '<attribute:span></attribute:span>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.render();
- // Remove first element and reinsert it at the end.
- const container = viewRoot.getChild( 0 );
- const firstElement = container.getChild( 0 );
- view.change( writer => {
- writer.remove( ViewRange.createOn( firstElement ) );
- writer.insert( new ViewPosition( container, 2 ), firstElement );
- } );
- expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- // Re-render changes in view to DOM.
- view.render();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- // Checks if every node in DOM tree is mapped to the view.
- function checkMappings() {
- const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
- while ( domWalker.nextNode() ) {
- const node = domWalker.currentNode;
- if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
- return false;
- }
- }
- return true;
- }
- } );
- } );
- function renderAndExpectNoChanges( renderer, domRoot ) {
- const config = {
- childList: true,
- characterData: true,
- characterDataOldValue: true,
- subtree: true
- };
- const mutationObserver = new window.MutationObserver( () => {
- throw 'There should be not mutations';
- } );
- mutationObserver.observe( domRoot, config );
- renderer.render();
- const records = mutationObserver.takeRecords();
- mutationObserver.disconnect();
- expect( records.length ).to.equal( 0 );
- }
|