| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191 |
- /**
- * @license Copyright (c) 2003-2019, CKSource - Frederico Knabben. All rights reserved.
- * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
- */
- /* globals document, window, NodeFilter, MutationObserver */
- import View from '../../src/view/view';
- import ViewElement from '../../src/view/element';
- import ViewEditableElement from '../../src/view/editableelement';
- import ViewContainerElement from '../../src/view/containerelement';
- import ViewAttributeElement from '../../src/view/attributeelement';
- import ViewText from '../../src/view/text';
- import ViewRange from '../../src/view/range';
- import ViewPosition from '../../src/view/position';
- import UIElement from '../../src/view/uielement';
- import DocumentSelection from '../../src/view/documentselection';
- import DomConverter from '../../src/view/domconverter';
- import Renderer from '../../src/view/renderer';
- import DocumentFragment from '../../src/view/documentfragment';
- import DowncastWriter from '../../src/view/downcastwriter';
- import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
- import { BR_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../../src/view/filler';
- import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
- import createViewRoot from './_utils/createroot';
- import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
- import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
- import env from '@ckeditor/ckeditor5-utils/src/env';
- import { expectToThrowCKEditorError } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
- describe( 'Renderer', () => {
- let selection, domConverter, renderer;
- testUtils.createSinonSandbox();
- beforeEach( () => {
- selection = new DocumentSelection();
- domConverter = new DomConverter();
- renderer = new Renderer( domConverter, selection );
- renderer.domDocuments.add( document );
- } );
- describe( 'markToSync', () => {
- let viewRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( 'p' );
- const domRoot = document.createElement( 'p' );
- domConverter.bindElements( domRoot, viewRoot );
- viewRoot._appendChild( new ViewText( 'foo' ) );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- } );
- it( 'should mark attributes which need update', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
- } );
- it( 'should mark children which need update', () => {
- viewRoot._appendChild( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
- } );
- it( 'should not mark children if element has no corresponding node', () => {
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( 'p' );
- viewRoot._appendChild( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
- } );
- it( 'should mark text which need update', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.true;
- } );
- it( 'should not mark text if parent has no corresponding node', () => {
- const viewText = new ViewText( 'foo' );
- // Overwrite viewRoot with node without coresponding DOM node.
- viewRoot = new ViewElement( 'p' );
- viewRoot._appendChild( viewText );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- expect( renderer.markedTexts.has( viewText ) ).to.be.false;
- } );
- it( 'should throw if the type is unknown', () => {
- expectToThrowCKEditorError( () => {
- renderer.markToSync( 'UNKNOWN', viewRoot );
- }, /^view-renderer-unknown-type/, selection );
- } );
- } );
- describe( 'render', () => {
- let viewRoot, domRoot;
- beforeEach( () => {
- viewRoot = new ViewEditableElement( 'div' );
- viewRoot.getFillerOffset = () => null;
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- domConverter.bindElements( domRoot, viewRoot );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- selection._setTo( null );
- renderer.isFocused = true;
- } );
- afterEach( () => {
- domRoot.remove();
- } );
- it( 'should update attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should remove attributes', () => {
- viewRoot._setAttribute( 'class', 'foo' );
- domRoot.setAttribute( 'id', 'bar' );
- domRoot.setAttribute( 'class', 'bar' );
- renderer.markToSync( 'attributes', viewRoot );
- renderer.render();
- expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
- expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- } );
- it( 'should add children', () => {
- viewRoot._appendChild( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should remove children', () => {
- viewRoot._appendChild( new ViewText( 'foo' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- } );
- it( 'should update text', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'bar';
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should not update same text', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'foo';
- renderer.markToSync( 'text', viewText );
- renderAndExpectNoChanges( renderer, domRoot );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should not update text parent child list changed', () => {
- const viewImg = new ViewElement( 'img' );
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( [ viewImg, viewText ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
- expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
- } );
- it( 'should not change text if it is the same during text rendering', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'text', viewText );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change text if it is the same during children rendering', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // This should not be changed during the render.
- const domText = domRoot.childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
- } );
- it( 'should not change element if it is the same', () => {
- const viewImg = new ViewElement( 'img' );
- viewRoot._appendChild( viewImg );
- // This should not be changed during the render.
- const domImg = document.createElement( 'img' );
- domRoot.appendChild( domImg );
- domConverter.bindElements( domImg, viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
- } );
- it( 'should change element if it is different', () => {
- const viewImg = new ViewElement( 'img' );
- viewRoot._appendChild( viewImg );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const viewP = new ViewElement( 'p' );
- viewRoot._removeChildren( 0, 1 );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
- } );
- it( 'should update removed item when it is reinserted', () => {
- const viewFoo = new ViewText( 'foo' );
- const viewP = new ViewElement( 'p', null, viewFoo );
- const viewDiv = new ViewElement( 'div', null, viewP );
- viewRoot._appendChild( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- viewP._removeChildren( 0, 1 );
- viewDiv._appendChild( viewP );
- renderer.markToSync( 'children', viewDiv );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDiv = domRoot.childNodes[ 0 ];
- expect( domDiv.tagName ).to.equal( 'DIV' );
- expect( domDiv.childNodes.length ).to.equal( 1 );
- const domP = domDiv.childNodes[ 0 ];
- expect( domP.tagName ).to.equal( 'P' );
- expect( domP.childNodes.length ).to.equal( 0 );
- } );
- it( 'should update removed item when it is reinserted #2', () => {
- // Prepare view: root -> div "outer" -> div "inner" -> p.
- const viewP = new ViewElement( 'p' );
- const viewDivInner = new ViewElement( 'div', null, viewP );
- const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
- viewRoot._appendChild( viewDivOuter );
- // Render view tree to DOM.
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove div "outer" from root and render it.
- viewDivOuter._remove();
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
- viewP._remove();
- // Add div "outer" back to root.
- viewRoot._appendChild( viewDivOuter );
- renderer.markToSync( 'children', viewRoot );
- // Render changes, view is: root -> div "outer" -> div "inner".
- renderer.render();
- // Same is expected in DOM.
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domDivOuter = domRoot.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
- expect( domDivOuter.tagName ).to.equal( 'DIV' );
- expect( domDivOuter.childNodes.length ).to.equal( 1 );
- const domDivInner = domDivOuter.childNodes[ 0 ];
- expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
- expect( domDivInner.tagName ).to.equal( 'DIV' );
- expect( domDivInner.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
- const viewFoo = new ViewText( 'foo' );
- const viewP = new ViewElement( 'p', null, viewFoo );
- const viewDiv = new ViewElement( 'div', null, viewP );
- viewRoot._appendChild( viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- viewDiv._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewDiv );
- viewP._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 0 );
- } );
- it( 'should not care about filler if there is no DOM', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- const viewRoot = new ViewElement( 'p' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Expect no error on render.
- expect( viewRoot ).to.be.ok;
- } );
- it( 'should not add filler when inside contenteditable=false parent', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should not add filler when inside contenteditable=false ancestor', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- } );
- it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p>foo{}<b></b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>{}foo</b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
- const domSelection = document.getSelection();
- // Step 1: <p>"FILLER{}"<b>foo</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 2: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- // Step 3: <p><b>foo{}</b></p>
- selection._setTo( ViewRange._createFromParentsAndOffsets(
- viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Step 4: No mutation on second render
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should move filler when selection is moved', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
- // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
- const viewI = viewP.getChild( 2 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
- expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- it( 'should remove filler when text is added and selection removed', () => {
- // Step 1: <p>foo<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- const viewB = viewP.getChild( 1 );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Add text node.
- const viewText = new ViewText( 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- // Step 3: Remove selection from the view.
- selection._setTo( null );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
- } );
- // #659
- // The element before the filler is removed so the position of the filler
- // cannot be remembered as parent+offset.
- it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
- // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
- viewP._removeChildren( 1 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether there's no filler in the DOM.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
- } );
- // #659
- it( 'should remove filler from a modified DOM when children moved', () => {
- // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
- const { view: viewFragment, selection: newSelection } = parse(
- '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
- );
- viewRoot._appendChild( viewFragment );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const domP = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
- // <p>[]</p><p><b>foo</b><b>bar</b></p>
- const viewP = viewRoot.getChild( 0 );
- const viewP2 = viewRoot.getChild( 1 );
- const removedChildren = viewP._removeChildren( 0, 2 );
- viewP2._appendChild( removedChildren );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.markToSync( 'children', viewP2 );
- renderer.render();
- // Step 3: Check whether in the first paragraph there's a <br> filler and that
- // in the second one there are two <b> tags.
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domP2.childNodes.length ).to.equal( 2 );
- expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
- // in one of ckeditor/ckeditor5-typing#59 automated tests.
- it( 'should not break when selection is moved to a new element, when filler exists', () => {
- // Step 1: <p>bar<b>"FILLER{}"</b></p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element and remove the previous one
- viewP._removeChildren( 1 ); // Remove <b>.
- const viewI = parse( '<attribute:i></attribute:i>' );
- viewP._appendChild( viewI );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether new filler was created in the <i> element.
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- } );
- // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
- // that has not been yet rendered/bound to DOM.
- it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
- // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
- const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
- // Step 2: Move selection to a new attribute element.
- const viewAbc = parse( 'abc' );
- viewP._appendChild( viewAbc );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- // Step 3: Check whether old filler was removed.
- expect( domP.childNodes.length ).to.equal( 3 );
- expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove filler and add text node to both DOM and View <p>x{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( document.createTextNode( 'x' ) );
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( 'x' );
- viewP._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty block, render if needed', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domConverter.isBlockFiller( domP.childNodes[ 0 ] ) ).to.be.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Add text node only in View <p>x{}</p>
- const viewText = new ViewText( 'x' );
- viewP._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle removing last character', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // Remove text and add filler to both DOM and View <p>{}</p>
- domP.removeChild( domP.childNodes[ 0 ] );
- domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domP.childNodes[ 0 ], 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- viewP._removeChildren( 0 );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
- domB.childNodes[ 0 ].data += 'x';
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- const viewText = new ViewText( 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should handle typing in empty attribute as a children change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- domSelection.removeAllRanges();
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'children', viewB );
- renderer.render();
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const firstRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- };
- const assertSelectionInsideTextNode = () => {
- expect( firstRange.startContainer ).to.equal( domB );
- expect( firstRange.startOffset ).to.equal( 1 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( firstRange.collapsed ).to.be.true;
- } );
- it( 'should handle typing in empty attribute as a text change, render if needed', () => {
- const domSelection = document.getSelection();
- // 1. Render <p><b>FILLER{}</b>foo</p>.
- const { view: viewP, selection: newSelection } = parse(
- '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check the DOM.
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
- const domB = domP.childNodes[ 0 ];
- const viewB = viewP.getChild( 0 );
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
- const viewText = new ViewText( 'x' );
- viewB._appendChild( viewText );
- selection._setTo( ViewRange._createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
- renderer.markToSync( 'text', viewText );
- renderer.render();
- // 4. Check the DOM.
- expect( domB.childNodes.length ).to.equal( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should handle not collapsed range', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.childNodes.length ).to.equal( 2 );
- expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
- expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
- expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
- expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
- renderer.markToSync( 'children', viewP );
- renderAndExpectNoChanges( renderer, domRoot );
- } );
- it( 'should not change selection if there is no editable with selection', () => {
- const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
- document.body.appendChild( domDiv );
- domDiv.focus();
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- domSelection.collapse( domDiv, 0 );
- const viewDiv = new ViewElement( 'div' );
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewDiv._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domRange.startOffset ).to.equal( 0 );
- expect( domRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not change selection if there is no focus', () => {
- const domDiv = createElement( document, 'div', null, 'not editable' );
- document.body.appendChild( domDiv );
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- const domRange = document.createRange();
- domRange.setStart( domDiv, 0 );
- domRange.collapse( true );
- domSelection.addRange( domRange );
- renderer.isFocused = false;
- const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.render();
- expect( domSelection.rangeCount ).to.equal( 1 );
- // Depending on the browser selection may end up before the text node or at the beginning of it.
- const domSelectionRange = domSelection.getRangeAt( 0 );
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv );
- };
- const assertSelectionInsideTextNode = () => {
- expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelectionRange.startOffset ).to.equal( 0 );
- expect( domSelectionRange.collapsed ).to.be.true;
- domDiv.remove();
- } );
- it( 'should not add inline filler after text node', () => {
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
- } );
- it( 'should throw if there is no filler in expected position', () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- const viewB = viewP.getChild( 1 );
- expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // Remove filler.
- domB.childNodes[ 0 ].data = '';
- selection._setTo( null );
- renderer.markToSync( 'children', viewB );
- expectToThrowCKEditorError( () => {
- renderer.render();
- }, /^view-renderer-filler-was-lost/, selection );
- } );
- // #1014.
- it( 'should create inline filler in newly created dom nodes', () => {
- // 1. Create the view structure which needs inline filler.
- const inputView =
- '<container:ul>' +
- '<container:li>Foobar.</container:li>' +
- '<container:li>[]<container:div></container:div></container:li>' +
- '</container:ul>';
- const { view: view, selection: newSelection } = parse( inputView );
- viewRoot._appendChild( view );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // 2. Check if filler element has been (correctly) created.
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- // 3. Move the inline filler parent to a newly created element.
- const viewLi = view.getChild( 0 );
- const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
- const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
- viewLi._appendChild( viewUl );
- // 4. Mark changed items and render the view.
- renderer.markToSync( 'children', view );
- renderer.markToSync( 'children', viewLi );
- renderer.render();
- expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
- const domSelection = document.getSelection();
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
- } );
- it( 'should handle focusing element', () => {
- selection._setTo( viewRoot, 0 );
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.render();
- expect( domFocusSpy.called ).to.be.true;
- } );
- it( 'should not focus editable if isFocues is set to false', () => {
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.isFocused = false;
- renderer.render();
- expect( domFocusSpy.calledOnce ).to.be.false;
- } );
- it( 'should not focus already focused DOM element', () => {
- domRoot.setAttribute( 'contentEditable', true );
- domRoot.focus();
- const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
- renderer.render();
- expect( domFocusSpy.called ).to.be.false;
- } );
- it( 'should render NBSP as last space in the previous inline element', () => {
- const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
- expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
- expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
- // Insert space resulting in '<p>x <b> y</b></p>'.
- const viewB = viewP.getChild( 1 );
- viewB._removeChildren( 0 );
- viewB._appendChild( new ViewText( ' y' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x <b> y</b>' );
- } );
- it( 'should update sibling after, when node before is removed', () => {
- const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
- // Remove 'x' resulting in '<p><b> y</b></p>'.
- viewP._removeChildren( 0 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( '\u00A0y' );
- expect( domP.innerHTML ).to.equal( '<b> y</b>' );
- } );
- it( 'should update sibling before, when node after is removed', () => {
- const viewP = parse( '<container:p>x <attribute:b>y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x ' );
- expect( domB.childNodes[ 0 ].data ).to.equal( 'y' );
- expect( domP.innerHTML ).to.equal( 'x <b>y</b>' );
- // Remove '<b>y</b>' resulting in '<p>x </p>'.
- viewP._removeChildren( 1 );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domP.innerHTML ).to.equal( 'x ' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - text-element', () => {
- const viewP = parse( '<container:p>x<attribute:b> y</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x<b> y</b>' );
- // Insert space resulting in '<p>x <b> y</b></p>'.
- viewP._removeChildren( 0 );
- viewP._insertChild( 0, new ViewText( 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domP.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domB.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( 'x <b> y</b>' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - element-text', () => {
- const viewP = parse( '<container:p><attribute:b>x</attribute:b> y</container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 0 ];
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x</b> y' );
- // Insert space resulting in '<p><b>x </b> y</p>'.
- const viewB = viewP.getChild( 0 );
- viewB._removeChildren( 0 );
- viewB._insertChild( 0, new ViewText( 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domP.childNodes[ 1 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x </b> y' );
- } );
- // #1093
- it( 'should update siblings after space is inserted in element before - element-element', () => {
- const viewP = parse( '<container:p><attribute:b>x</attribute:b><attribute:i> y</attribute:i></container:p>' );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 0 ];
- const domI = domP.childNodes[ 1 ];
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x' );
- expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x</b><i> y</i>' );
- // Insert space resulting in '<p><b>x </b><i> y</i></p>'.
- const viewB = viewP.getChild( 0 );
- viewB._removeChildren( 0 );
- viewB._insertChild( 0, new ViewText( 'x ' ) );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domB.childNodes[ 0 ].data ).to.equal( 'x\u00A0' );
- expect( domI.childNodes[ 0 ].data ).to.equal( ' y' );
- expect( domP.innerHTML ).to.equal( '<b>x </b><i> y</i>' );
- } );
- // #1125
- it( 'should properly rerender many changes done in one batch', () => {
- // This test transforms:
- //
- // <h2>He<strong>ding 1</strong></h2>
- // <p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>
- // <blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>
- //
- // into:
- //
- // <h2>Heading 2</h2>
- // <p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>
- // <blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>
- //
- // during one rerender to check if complex structure changes are rerendered correctly.
- const viewContent = parse( '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong> ' +
- '<attribute:i>It' +
- '<attribute:strong>alic</attribute:strong>' +
- '</attribute:i> ' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin</attribute:strong>' +
- 'k</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>' );
- viewRoot._appendChild( viewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // '<h2>He<i>ading 1</i></h2>' -> '<h2>Heading 2</h2>'
- const viewHeading = viewRoot.getChild( 0 );
- viewHeading._removeChildren( 0, viewHeading.childCount );
- viewHeading._insertChild( 0, new ViewText( 'Heading 2' ) );
- // Usually whole subtree is marked to sync so we mark root, changed element and all its direct children.
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewHeading );
- renderer.markToSync( 'text', viewHeading.getChild( 0 ) );
- // '<p>Ph <strong>Bold</strong> <i>It<strong>alic</strong></i> <a><strong>Lin</strong>k</a></p>'
- // ->
- // '<p>Ph <i><strong>Italic</strong></i> <a><strong>L</strong>ink 1</a></p>'
- const viewP = viewRoot.getChild( 1 );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild(
- 0,
- parse(
- 'Ph <attribute:i><attribute:strong>Italic</attribute:strong></attribute:i> ' +
- '<attribute:a href="https://ckeditor.com"><attribute:strong>L</attribute:strong>ink 1</attribute:a>'
- )
- );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.markToSync( 'children', viewP.getChild( 1 ) );
- renderer.markToSync( 'children', viewP.getChild( 3 ) );
- renderer.markToSync( 'text', viewP.getChild( 0 ) );
- renderer.markToSync( 'text', viewP.getChild( 2 ) );
- // '<blockquote><ul><li>Quoted <strong>item 1</strong></li></ul></blockquote>'
- // -> '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
- const viewBq = viewRoot.getChild( 2 );
- viewBq._removeChildren( 0, viewBq.childCount );
- viewBq._insertChild(
- 0,
- parse(
- '<container:p>Qu<attribute:strong>ote</attribute:strong></container:p>' +
- '<container:ul><container:li><attribute:strong>Quoted item 1</attribute:strong></container:li></container:ul>'
- )
- );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewBq );
- renderer.markToSync( 'children', viewBq.getChild( 0 ) );
- renderer.markToSync( 'children', viewBq.getChild( 1 ) );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
- '<h2>Heading 2</h2>' +
- '<p>Ph <i><strong>Italic</strong></i> <a href="https://ckeditor.com"><strong>L</strong>ink 1</a></p>' +
- '<blockquote><p>Qu<strong>ote</strong></p><ul><li><strong>Quoted item 1</strong></li></ul></blockquote>'
- );
- } );
- // #1125
- it( 'should properly rerender changes when whole content replaced at once', () => {
- // This test replaces:
- //
- // <h1>Header</h1>
- // <blockquote><ul><li>Quoted <strong>item 1</strong></li><li>Item 2</li></ul></blockquote>
- //
- // with:
- //
- // <h2>Header</h2>
- // <p>Not Quoted <strong>item 1</strong> and item 2</p>
- //
- // during one rerender to check if complex structure changes are rerendered correctly.
- const viewContent = parse(
- '<container:h1>Header</container:h1>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '</container:ul>' +
- '</container:blockquote>'
- );
- viewRoot._appendChild( viewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const newViewContent = parse(
- '<container:h2>Header</container:h2>' +
- '<container:p>Not Quoted <attribute:strong>item 1</attribute:strong> and item 2</container:p>'
- );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( newViewContent );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal(
- '<h2>Header</h2><p>Not Quoted <strong>item 1</strong> and item 2</p>'
- );
- } );
- // #1451
- it( 'should correctly render changed children even if direct parent is not marked to sync', () => {
- const inputView =
- '<container:ul>' +
- '<container:li>Foo</container:li>' +
- '<container:li><attribute:b>Bar</attribute:b></container:li>' +
- '</container:ul>';
- const view = parse( inputView );
- viewRoot._appendChild( view );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo</li><li><b>Bar</b></li></ul>' );
- const viewLi = view.getChild( 0 );
- const viewLiIndented = view._removeChildren( 1, 1 ); // Array with one element.
- viewLiIndented[ 0 ]._appendChild( parse( '<attribute:i>Baz</attribute:i>' ) );
- const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
- viewLi._appendChild( viewUl );
- renderer.markToSync( 'children', view );
- renderer.markToSync( 'children', viewLi );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<ul><li>Foo<ul><li><b>Bar</b><i>Baz</i></li></ul></li></ul>' );
- } );
- // #1439
- it( 'should not force–refresh the selection in non–Gecko browsers after a soft break', () => {
- const domSelection = domRoot.ownerDocument.defaultView.getSelection();
- testUtils.sinon.stub( env, 'isGecko' ).get( () => false );
- const spy = testUtils.sinon.stub( domSelection, 'addRange' );
- // <p>foo<br/>[]</p>
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<empty:br></empty:br>[]' +
- '</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- } );
- // #1439
- it( 'should force–refresh the selection in Gecko browsers after a soft break to nudge the caret', () => {
- const domSelection = domRoot.ownerDocument.defaultView.getSelection();
- testUtils.sinon.stub( env, 'isGecko' ).get( () => true );
- const spy = testUtils.sinon.stub( domSelection, 'addRange' );
- // <p>foo[]<b>bar</b></p>
- let { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<attribute:b>bar</attribute:b>' +
- '</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- // <p>foo<b>bar</b></p><p>foo[]<br/></p>
- ( { view: viewP, selection: newSelection } = parse(
- '<container:p>' +
- 'foo[]' +
- '<empty:br></empty:br>' +
- '</container:p>' ) );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.notCalled( spy );
- // <p>foo<b>bar</b></p><p>foo<br/>[]</p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP, 2 ), new ViewPosition( viewP, 2 ) )
- ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- sinon.assert.calledOnce( spy );
- } );
- describe( 'fake selection', () => {
- beforeEach( () => {
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>[foo bar]</container:p>'
- );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- } );
- it( 'should render fake selection', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( domConverter.mapDomToView( container ) ).to.be.undefined;
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
- } );
- it( 'should render if no selection label is provided', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( '\u00A0' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
- } );
- it( 'should remove fake selection container when selection is no longer fake', () => {
- selection._setTo( selection.getRanges(), { fake: true } );
- renderer.render();
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- const domParagraph = domRoot.childNodes[ 0 ];
- expect( domParagraph.childNodes.length ).to.equal( 1 );
- expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
- } );
- it( 'should reuse fake selection container #1', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- } );
- it( 'should reuse fake selection container #2', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: false } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should reuse fake selection container #3', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 1' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- selection._setTo( selection.getRanges(), { fake: true, label: 'label 2' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const newContainer = domRoot.childNodes[ 1 ];
- expect( newContainer ).equals( container );
- expect( newContainer.childNodes.length ).to.equal( 1 );
- const textNode = newContainer.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( 'label 2' );
- } );
- it( 'should style fake selection container properly', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( container.style.position ).to.equal( 'fixed' );
- expect( container.style.top ).to.equal( '0px' );
- expect( container.style.left ).to.equal( '-9999px' );
- } );
- it( 'should move fake selection container between editables', () => {
- const viewEditable = new ViewEditableElement( 'div' );
- viewEditable._appendChild( parse( '<container:p>abc xyz</container:p>' ) );
- const domEditable = document.createElement( 'div' );
- document.body.appendChild( domEditable );
- domConverter.bindElements( domEditable, viewEditable );
- renderer.markToSync( 'children', viewEditable );
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- let container = document.getSelection().anchorNode;
- expect( domRoot.contains( container ) ).to.be.true;
- selection._setTo( viewEditable, 'in', { fake: true, label: 'fake selection' } );
- renderer.render();
- container = document.getSelection().anchorNode;
- expect( domEditable.contains( container ) ).to.be.true;
- } );
- it( 'should bind fake selection container to view selection', () => {
- selection._setTo( selection.getRanges(), { fake: true, label: 'fake selection' } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- const bindSelection = renderer.domConverter.fakeSelectionToView( container );
- expect( bindSelection ).to.not.be.undefined;
- expect( bindSelection.isEqual( selection ) ).to.be.true;
- } );
- // https://github.com/ckeditor/ckeditor5-engine/issues/1714.
- it( 'should handle situation when label got removed from the fake selection container', () => {
- const label = 'fake selection label';
- selection._setTo( selection.getRanges(), { fake: true, label } );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 2 );
- const container = domRoot.childNodes[ 1 ];
- expect( domConverter.mapDomToView( container ) ).to.be.undefined;
- expect( container.childNodes.length ).to.equal( 1 );
- const textNode = container.childNodes[ 0 ];
- expect( textNode.textContent ).to.equal( label );
- // Remove a text node (label) from the fake selection container.
- // It can be done by pressing backspace while the delete command is disabled and selection is on the widget.
- textNode.remove();
- renderer.render();
- const domSelection = domRoot.ownerDocument.getSelection();
- assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
- } );
- // Use a forgiving way of checking what the selection contains
- // because Safari normalizes the selection ranges so precise checking is troublesome.
- // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
- function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
- const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
- expect( domSelection.toString() ).to.match( expectedText );
- expect(
- domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
- ).to.be.true;
- }
- } );
- // #887
- describe( 'similar selection', () => {
- // Use spies to check selection updates. Some selection positions are not achievable in some
- // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
- let selectionCollapseSpy, selectionExtendSpy;
- afterEach( () => {
- if ( selectionCollapseSpy ) {
- selectionCollapseSpy.restore();
- selectionCollapseSpy = null;
- }
- if ( selectionExtendSpy ) {
- selectionExtendSpy.restore();
- selectionExtendSpy = null;
- }
- } );
- it( 'should always render collapsed selection even if it is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
- } );
- it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.true;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{}<attribute:b></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
- } );
- it( 'should always render non-collapsed selection if it not is similar', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.calledOnce ).to.true;
- expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
- expect( selectionExtendSpy.calledOnce ).to.true;
- expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
- } );
- it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
- // Do not change view selection.
- // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
- // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
- // because DOM selection is in incorrect place.
- const domP = domRoot.childNodes[ 0 ];
- const domSpan = domP.childNodes[ 1 ];
- domSelection.collapse( domSpan, 0 );
- renderer.render();
- // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
- // Depending on the browser selection may end up at the end of the text node or after the text node.
- const assertSelectionAtEndOfTextNode = () => {
- expect( domSelection.anchorNode ).to.equal( domP );
- expect( domSelection.anchorOffset ).to.equal( 1 );
- };
- const assertSelectionInsideTextNode = () => {
- const textNode = domP.childNodes[ 0 ];
- expect( domSelection.anchorNode ).to.equal( textNode );
- expect( domSelection.anchorOffset ).to.equal( 3 );
- };
- testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
- expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewB = viewRoot.getChild( 0 ).getChild( 1 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
- const domSelection = document.getSelection();
- const { view: viewP, selection: newSelection } = parse(
- '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- const domP = domRoot.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- expect( domSelection.isCollapsed ).to.false;
- expect( domSelection.rangeCount ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
- expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
- expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
- selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
- selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
- // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( selectionCollapseSpy.notCalled ).to.true;
- expect( selectionExtendSpy.notCalled ).to.true;
- } );
- } );
- // #1417
- describe( 'optimal rendering – reusing existing nodes', () => {
- it( 'should render inline element replacement (before text)', () => {
- viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
- } );
- it( 'should render inline element replacement (after text)', () => {
- viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
- } );
- it( 'should render inline element replacement (before text swapped order)', () => {
- viewRoot._appendChild( parse( '<container:p><attribute:i>A</attribute:i>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '2<attribute:i>B</attribute:i>' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 0 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>2<i>B</i></p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 1 ] );
- } );
- it( 'should render inline element replacement (after text swapped order)', () => {
- viewRoot._appendChild( parse( '<container:p>1<attribute:i>A</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 0, 2 );
- viewP._insertChild( 0, parse( '<attribute:i>B</attribute:i>2' ) );
- const domI = domRoot.childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>B</i>2</p>' );
- expect( domI ).to.equal( domRoot.childNodes[ 0 ].childNodes[ 0 ] );
- } );
- it( 'should render single replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p>' );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p>4</container:p>' ) );
- const domP = domRoot.childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>4</p><p>3</p>' );
- expect( domP ).to.equal( domRoot.childNodes[ 1 ] );
- } );
- it( 'should render replacement and insertion in p group', () => {
- const content = '' +
- '<container:p>1<attribute:i>A</attribute:i></container:p>' +
- '<container:p>2<attribute:i>B</attribute:i></container:p>' +
- '<container:p>3<attribute:i>C</attribute:i></container:p>';
- const replacement = '' +
- '<container:p><attribute:i>D</attribute:i></container:p>' +
- '<container:p>5<attribute:i>E</attribute:i></container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p>2<i>B</i></p><p>3<i>C</i></p>' );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( replacement ) );
- const domP2 = domRoot.childNodes[ 1 ];
- const domP3 = domRoot.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1<i>A</i></p><p><i>D</i></p><p>5<i>E</i></p><p>3<i>C</i></p>' );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP3 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should render replacement and deletion in p group', () => {
- const content = '' +
- '<container:p><attribute:i>A</attribute:i>1</container:p>' +
- '<container:p><attribute:i>B</attribute:i>2</container:p>' +
- '<container:p><attribute:i>C</attribute:i>3</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><i>A</i>1</p><p><i>B</i>2</p><p><i>C</i>3</p>' );
- viewRoot._removeChildren( 0, 2 );
- viewRoot._insertChild( 0, parse( '<container:p>4</container:p>' ) );
- const domP0 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>4</p><p><i>C</i>3</p>' );
- expect( domP0 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- } );
- it( 'should render multiple continuous replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>' +
- '<container:p>4</container:p>' +
- '<container:p>5</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
- viewRoot._removeChildren( 0, 3 );
- viewRoot._insertChild( 0, parse( '<container:p>6<attribute:i>A</attribute:i></container:p><container:p>7</container:p>' ) );
- const domP1 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- const domP4 = domRoot.childNodes[ 3 ];
- const domP5 = domRoot.childNodes[ 4 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>6<i>A</i></p><p>7</p><p>4</p><p>5</p>' );
- expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
- expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should render multiple replacement in p group', () => {
- const content = '' +
- '<container:p>1</container:p>' +
- '<container:p>2</container:p>' +
- '<container:p>3</container:p>' +
- '<container:p>4</container:p>' +
- '<container:p>5</container:p>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p><p>3</p><p>4</p><p>5</p>' );
- viewRoot._removeChildren( 4 );
- viewRoot._removeChildren( 1, 2 );
- viewRoot._insertChild( 2, parse( '<container:p>6</container:p>' ) );
- viewRoot._insertChild( 1, parse( '<container:p><attribute:i>A</attribute:i>7</container:p>' ) );
- const domP1 = domRoot.childNodes[ 0 ];
- const domP2 = domRoot.childNodes[ 1 ];
- const domP4 = domRoot.childNodes[ 3 ];
- const domP5 = domRoot.childNodes[ 4 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p><i>A</i>7</p><p>4</p><p>6</p>' );
- expect( domP1 ).to.equal( domRoot.childNodes[ 0 ] );
- expect( domP2 ).to.equal( domRoot.childNodes[ 1 ] );
- expect( domP4 ).to.equal( domRoot.childNodes[ 2 ] );
- expect( domP5 ).to.equal( domRoot.childNodes[ 3 ] );
- } );
- it( 'should not rerender DOM when view replaced with the same structure', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content ) );
- const viewH = viewRoot.getChild( 0 );
- const viewP = viewRoot.getChild( 1 );
- const viewQ = viewRoot.getChild( 2 );
- const domH = domRoot.childNodes[ 0 ];
- const domHI = domH.childNodes[ 1 ];
- const domP = domRoot.childNodes[ 1 ];
- const domPT = domP.childNodes[ 0 ];
- const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
- const domQ = domRoot.childNodes[ 2 ];
- const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domH );
- expect( domH.childNodes[ 1 ] ).to.equal( domHI );
- expect( domRoot.childNodes[ 1 ] ).to.equal( domP );
- expect( domP.childNodes[ 0 ] ).to.equal( domPT );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
- expect( domRoot.childNodes[ 2 ] ).to.equal( domQ );
- expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domH ) ).to.equal( viewH );
- expect( mappings.get( domHI ) ).to.equal( viewH.getChild( 1 ) );
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
- expect( mappings.get( domQ ) ).to.equal( viewQ );
- expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- } );
- it( 'should not rerender DOM when view replaced with the same structure without first node', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const content2 = '' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h2>He<i>ading 1</i></h2><p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content2 ) );
- const viewP = viewRoot.getChild( 0 );
- const viewQ = viewRoot.getChild( 1 );
- const domP = domRoot.childNodes[ 1 ];
- const domPT = domP.childNodes[ 0 ];
- const domPABI = domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ];
- const domQ = domRoot.childNodes[ 2 ];
- const domQULB = domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<p>Ph <strong>Bold</strong>' +
- '<a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p><blockquote><ul><li>' +
- 'Quoted <strong>item 1</strong></li></ul></blockquote>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
- expect( domP.childNodes[ 0 ] ).to.equal( domPT );
- expect( domP.childNodes[ 2 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domPABI );
- expect( domRoot.childNodes[ 1 ] ).to.equal( domQ );
- expect( domQ.childNodes[ 0 ].childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domQULB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domPABI ) ).to.equal( viewP.getChild( 2 ).getChild( 0 ).getChild( 1 ) );
- expect( mappings.get( domQ ) ).to.equal( viewQ );
- expect( mappings.get( domQULB ) ).to.equal( viewQ.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- } );
- it( 'should not rerender DOM when typing inside empty inline element', () => {
- const view = parse( '<container:p>Foo Bar<attribute:strong></attribute:strong></container:p>' );
- viewRoot._appendChild( view );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong></strong></p>' );
- const viewP = viewRoot.getChild( 0 );
- viewP._removeChildren( 1 );
- viewP._insertChild( 1, parse( '<attribute:strong>a</attribute:strong>' ) );
- const domP = domRoot.childNodes[ 0 ];
- const domText = domP.childNodes[ 0 ];
- const domB = domP.childNodes[ 1 ];
- domB.innerHTML = 'a';
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewRoot.getChild( 0 ) );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( '<p>Foo Bar<strong>a</strong></p>' );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domP );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ] ).to.equal( domText );
- expect( domRoot.childNodes[ 0 ].childNodes[ 1 ] ).to.equal( domB );
- // Assert mappings.
- const mappings = renderer.domConverter._domToViewMapping;
- expect( mappings.get( domP ) ).to.equal( viewP );
- expect( mappings.get( domB ) ).to.equal( viewP.getChild( 1 ) );
- } );
- it( 'should handle complex view duplication', () => {
- const content = '' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
- '</container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const expected = '' +
- '<blockquote>' +
- '<ul>' +
- '<li>Quoted <strong>item 1</strong></li>' +
- '<li>Item 2</li>' +
- '<li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
- '</ul>' +
- '</blockquote>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( content + content ) );
- const domBQ = domRoot.childNodes[ 0 ];
- const domUL = domBQ.childNodes[ 0 ];
- const domLI1 = domUL.childNodes[ 0 ];
- const domLI2 = domUL.childNodes[ 1 ];
- const domLI3 = domUL.childNodes[ 2 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Assert content.
- expect( domRoot.innerHTML ).to.equal( expected + expected );
- // Assert if DOM elements did not change.
- expect( domRoot.childNodes[ 0 ] ).to.equal( domBQ );
- expect( domBQ.childNodes[ 0 ] ).to.equal( domUL );
- expect( domUL.childNodes[ 0 ] ).to.equal( domLI1 );
- expect( domUL.childNodes[ 1 ] ).to.equal( domLI2 );
- expect( domUL.childNodes[ 2 ] ).to.equal( domLI3 );
- // Assert mappings.
- const domMappings = renderer.domConverter._domToViewMapping;
- expect( domMappings.get( domBQ ) ).to.equal( viewRoot.getChild( 0 ) );
- expect( domMappings.get( domUL ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ) );
- expect( domMappings.get( domLI1 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ) );
- expect( domMappings.get( domLI2 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 1 ) );
- expect( domMappings.get( domLI3 ) ).to.equal( viewRoot.getChild( 0 ).getChild( 0 ).getChild( 2 ) );
- // Assert if new view elements are bind to new DOM elements.
- const viewMappings = renderer.domConverter._domToViewMapping;
- expect( viewMappings.get( viewRoot.getChild( 1 ) ) ).not.equal( domBQ );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ) ) ).not.equal( domUL );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 0 ) ) ).not.equal( domLI1 );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 1 ) ) ).not.equal( domLI2 );
- expect( viewMappings.get( viewRoot.getChild( 1 ).getChild( 0 ).getChild( 2 ) ) ).not.equal( domLI3 );
- } );
- it( 'should handle complex view replace', () => {
- const content = '' +
- '<container:h2>He' +
- '<attribute:i>ading 1</attribute:i>' +
- '</container:h2>' +
- '<container:p>Ph ' +
- '<attribute:strong>Bold</attribute:strong>' +
- '<attribute:a href="https://ckeditor.com">' +
- '<attribute:strong>Lin<attribute:i>k</attribute:i></attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:blockquote>' +
- '<container:ul>' +
- '<container:li>Quoted <attribute:strong>item 1</attribute:strong></container:li>' +
- '<container:li>Item 2</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://cksource.com">Li<attribute:strong>nk</attribute:strong></attribute:a>' +
- '</container:li>' +
- '</container:ul>' +
- '</container:blockquote>';
- const replacement = '' +
- '<container:p>' +
- '1' +
- '<attribute:i>A</attribute:i>' +
- '</container:p>' +
- '<container:p>' +
- '<attribute:a href="https://cksource.com">' +
- 'Li' +
- '<attribute:strong>nk</attribute:strong>' +
- '</attribute:a>' +
- '</container:p>' +
- '<container:h1>' +
- 'Heading ' +
- '<attribute:strong>1</attribute:strong>' +
- '</container:h1>' +
- '<container:h2>' +
- '<attribute:a href="https://ckeditor.com">Heading 2</attribute:a>' +
- '</container:h2>' +
- '<container:h3>' +
- 'Heading' +
- '<attribute:i> 3</attribute:i>' +
- '</container:h3>' +
- '<container:blockquote>' +
- 'Foo Bar Baz' +
- '</container:blockquote>' +
- '<container:ul>' +
- '<container:li>' +
- 'Item ' +
- '<attribute:strong>1</attribute:strong>' +
- '</container:li>' +
- '<container:li>' +
- '<attribute:a href="https://ckeditor.com">Item</attribute:a>' +
- ' 2' +
- '</container:li>' +
- '</container:ul>';
- viewRoot._appendChild( parse( content ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '' +
- '<h2>He<i>ading 1</i></h2>' +
- '<p>Ph <strong>Bold</strong><a href="https://ckeditor.com"><strong>Lin<i>k</i></strong></a></p>' +
- '<blockquote><ul>' +
- '<li>Quoted <strong>item 1</strong></li>' +
- '<li>Item 2</li><li><a href="https://cksource.com">Li<strong>nk</strong></a></li>' +
- '</ul></blockquote>' );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( replacement ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Here we just check if new DOM structure was properly rendered.
- expect( domRoot.innerHTML ).to.equal( '' +
- '<p>1<i>A</i></p>' +
- '<p><a href="https://cksource.com">Li<strong>nk</strong></a></p>' +
- '<h1>Heading <strong>1</strong></h1>' +
- '<h2><a href="https://ckeditor.com">Heading 2</a></h2>' +
- '<h3>Heading<i> 3</i></h3>' +
- '<blockquote>Foo Bar Baz</blockquote>' +
- '<ul><li>Item <strong>1</strong></li><li><a href="https://ckeditor.com">Item</a> 2</li></ul>' );
- } );
- it( 'should handle br elements while refreshing bindings', () => {
- const expected = `<p>Foo Bar</p><p>${ BR_FILLER( document ).outerHTML }</p>`; // eslint-disable-line new-cap
- viewRoot._appendChild( parse( '<container:p>Foo Bar</container:p><container:p></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- // There is a case in Safari that during accent panel navigation on macOS our 'BR_FILLER' is replaced with
- // just '<br>' element which breaks accent composition in an empty paragraph. It also throws an error while
- // refreshing mappings in a renderer. Simulate such behaviour (#1354).
- domRoot.childNodes[ 1 ].innerHTML = '<br>';
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( expected );
- } );
- it( 'should handle list to paragraph conversion', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li>Item 1' +
- '<container:ol>' +
- '<container:li>Item 2</container:li>' +
- '</container:ol>' +
- '</container:li>' +
- '</container:ol>' +
- '<container:p>Paragraph</container:p>' +
- '<container:ol>' +
- '<container:li>Item 3' +
- '<container:ol>' +
- '<container:li>Item 4</container:li>' +
- '</container:ol>' +
- '</container:li>' +
- '</container:ol>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal(
- '<ol><li>Item 1<ol><li>Item 2</li></ol></li></ol><p>Paragraph</p><ol><li>Item 3<ol><li>Item 4</li></ol></li></ol>' );
- const viewOL1 = viewRoot.getChild( 0 );
- viewOL1.getChild( 0 )._removeChildren( 1 );
- viewRoot._removeChildren( 2 );
- viewRoot._insertChild( 1, parse( '<container:p>Item 2</container:p>' ) );
- viewRoot._insertChild( 3, parse( '<container:p>Item 3</container:p>' ) );
- viewRoot._insertChild( 4, parse( '<container:ol><container:li>Item 4</container:li></container:ol>' ) );
- const domOL1 = domRoot.childNodes[ 0 ];
- const domOL2 = domRoot.childNodes[ 2 ];
- const domP = domRoot.childNodes[ 1 ];
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL1.getChild( 0 ) );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal(
- '<ol><li>Item 1</li></ol><p>Item 2</p><p>Paragraph</p><p>Item 3</p><ol><li>Item 4</li></ol>' );
- expect( domRoot.childNodes[ 0 ] ).to.equal( domOL1 );
- expect( domRoot.childNodes[ 2 ] ).to.equal( domP );
- expect( domRoot.childNodes[ 4 ] ).to.equal( domOL2 );
- } );
- it( 'should handle attributes change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li data-index="1" align="left">Item 1</container:li>' +
- '</container:ol>' +
- '<container:p>Paragraph ' +
- '<attribute:a href="123">Link</attribute:a>' +
- '</container:p>' +
- '<container:p id="p1"><attribute:i>Bar</attribute:i>Baz</container:p>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li data-index="1" align="left">Item 1</li></ol>' +
- '<p>Paragraph <a href="123">Link</a></p><p id="p1"><i>Bar</i>Baz</p>' ) );
- const viewOL = viewRoot.getChild( 0 );
- viewOL._removeChildren( 0 );
- viewOL._insertChild( 0, parse( '<container:li data-index="2" data-attr="foo">Item 1</container:li>' ) );
- const viewP1 = viewRoot.getChild( 1 );
- viewP1._removeChildren( 1 );
- viewP1._insertChild( 1, parse( '<attribute:a href="456" class="cke">Foo</attribute:a>' ) );
- viewRoot._removeChildren( 2 );
- viewRoot._insertChild( 2, parse( '<container:p>Bar</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL );
- renderer.markToSync( 'children', viewP1 );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li data-index="2" data-attr="foo">Item 1</li></ol>' +
- '<p>Paragraph <a href="456" class="cke">Foo</a></p><p>Bar</p>' ) );
- } );
- it( 'should handle classes change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li class="foo1 bar2 baz3">Item 1</container:li>' +
- '</container:ol>' +
- '<container:p><attribute:i class="i1 i2">Bar</attribute:i>Baz</container:p>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li class="foo1 bar2 baz3">Item 1</li></ol><p><i class="i1 i2">Bar</i>Baz</p>' ) );
- const viewOL = viewRoot.getChild( 0 );
- const oldViewLI = viewOL.getChild( 0 );
- viewOL._removeChildren( 0 );
- viewOL._insertChild( 0, parse( '<container:li class="bar2 baz4 bax5">Item 1</container:li>' ) );
- const oldViewP = viewRoot.getChild( 1 );
- viewRoot._removeChildren( 1 );
- viewRoot._insertChild( 1, parse( '<container:p class="p1 p2"><attribute:i>Foo</attribute:i></container:p>' ) );
- renderer.markToSync( 'attributes', oldViewLI );
- renderer.markToSync( 'attributes', oldViewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewOL );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li class="bar2 baz4 bax5">Item 1</li></ol><p class="p1 p2"><i>Foo</i></p>' ) );
- } );
- it( 'should handle styles change in replaced elements', () => {
- const view = '' +
- '<container:ol>' +
- '<container:li style="color:#000;font-weight:bold;">Foo</container:li>' +
- '<container:li>Bar ' +
- '<attribute:i>' +
- '<attribute:b style="color:#00F;background-color:#000;font-size:12px;">Baz</attribute:b>' +
- ' Bax</attribute:i>' +
- '</container:li>' +
- '</container:ol>';
- viewRoot._appendChild( parse( view ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li style="color:#000;font-weight:bold;">Foo</li>' +
- '<li>Bar <i><b style="color:#00F;background-color:#000;font-size:12px;">Baz</b> Bax</i></li></ol>' ) );
- const viewOL = viewRoot.getChild( 0 );
- const viewLI1 = viewOL.getChild( 0 );
- const viewLI2 = viewOL.getChild( 1 );
- viewLI1._removeStyle( 'font-weight' );
- viewLI1._setStyle( { color: '#FFF' } );
- viewLI2._setStyle( { 'font-weight': 'bold' } );
- viewLI2._removeChildren( 0, viewLI2.childCount );
- viewLI2._insertChild( 0, parse( 'Ba1 <attribute:i style="color:#000;border-width:1px;">Ba3 ' +
- '<attribute:b style="font-size:15px;">Ba2</attribute:b></attribute:i>' ) );
- renderer.markToSync( 'attributes', viewLI1 );
- renderer.markToSync( 'attributes', viewLI2 );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewLI2 );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<ol><li style="color:#FFF;">Foo</li>' +
- '<li style="font-weight:bold;">Ba1 <i style="color:#000;border-width:1px;">Ba3 ' +
- '<b style="font-size:15px;">Ba2</b></i></li></ol>' ) );
- } );
- it( 'should handle uiElement rendering', () => {
- function createUIElement( id, text ) {
- const element = new UIElement( 'span' );
- element.render = function( domDocument ) {
- const domElement = this.toDomElement( domDocument );
- domElement.innerText = `<span id="${ id }"><b>${ text }</b></span>`;
- return domElement;
- };
- return element;
- }
- const ui1 = createUIElement( 'id1', 'UI1' );
- const ui2 = createUIElement( 'id2', 'UI2' );
- const viewP = new ViewContainerElement( 'p', null, [ new ViewText( 'Foo ' ), ui1, new ViewText( 'Bar' ) ] );
- viewRoot._appendChild( viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo <span><span id="id1"><b>UI1</b></span></span>Bar</p>' ) );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild( 0, [ new ViewText( 'Foo' ), ui2, new ViewText( ' Bar' ) ] );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( normalizeHtml(
- '<p>Foo<span><span id="id2"><b>UI2</b></span></span> Bar</p>' ) );
- } );
- it( 'should handle linking entire content', () => {
- viewRoot._appendChild( parse( '<container:p>Foo<attribute:i>Bar</attribute:i></container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>Foo<i>Bar</i></p>' );
- const viewP = viewRoot.getChild( 0 );
- // While linking, the existing DOM children are moved to a new `a` element during binding
- // inside the `domConverter.viewToDom()` method. It happens because of a modified view structure
- // where view elements were moved to a newly created link view element.
- const viewA = new ViewAttributeElement( 'a', { href: '#href' }, [ new ViewText( 'Foo' ), viewP.getChild( 1 ) ] );
- viewP._removeChildren( 0, viewP.childCount );
- viewP._insertChild( 0, viewA );
- renderer.markToSync( 'children', viewRoot );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p><a href="#href">Foo<i>Bar</i></a></p>' );
- } );
- } );
- describe( 'optimal (minimal) rendering – minimal children changes', () => {
- let observer;
- beforeEach( () => {
- observer = new MutationObserver( () => {} );
- observer.observe( domRoot, {
- childList: true,
- attributes: false,
- subtree: false
- } );
- } );
- afterEach( () => {
- observer.disconnect();
- } );
- it( 'should add only one child (at the beginning)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 0, parse( '<container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (at the end)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._appendChild( parse( '<container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (in the middle)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch elements at all (rendering texts is enough)', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>3</container:p>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
- } );
- it( 'should add and remove one', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:h1>3</container:h1>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0',
- 'added: 0, removed: 1'
- ] );
- } );
- it( 'should not touch the FSC when rendering children', () => {
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- // Set fake selection on the second paragraph.
- selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- // Remove the second paragraph.
- viewRoot._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- } );
- it( 'should not incorrectly remove element which is not a FSC when rendering children', () => {
- // This test's purpose is mostly reaching 100% CC.
- observer = new MutationObserver( () => {} );
- viewRoot._appendChild( parse( '<container:div><container:p>1</container:p><container:p>2</container:p></container:div>' ) );
- const viewDiv = viewRoot.getChild( 0 );
- // Set fake selection on the second paragraph.
- selection._setTo( viewDiv.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- observer.observe( domRoot.childNodes[ 0 ], {
- childList: true,
- attributes: false,
- subtree: false
- } );
- // Remove the second paragraph.
- viewDiv._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewDiv.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewDiv );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- observer.disconnect();
- } );
- describe( 'using fastDiff() - significant number of nodes in the editor', () => {
- it( 'should add only one child (at the beginning)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 0, parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (at the end)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._appendChild( parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should add only one child (in the middle)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 75, parse( '<container:p>x</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0'
- ] );
- } );
- it( 'should not touch elements at all (rendering texts is enough)', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:p>x</container:p>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.be.empty;
- } );
- it( 'should add and remove one', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- viewRoot._insertChild( 1, parse( '<container:h1>x</container:h1>' ) );
- viewRoot._removeChildren( 0, 1 );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 1, removed: 0',
- 'added: 0, removed: 1'
- ] );
- } );
- it( 'should not touch the FSC when rendering children', () => {
- viewRoot._appendChild( parse( makeContainers( 151 ) ) );
- // Set fake selection on the second paragraph.
- selection._setTo( viewRoot.getChild( 1 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- cleanObserver( observer );
- // Remove the second paragraph.
- viewRoot._removeChildren( 1, 1 );
- // And set the fake selection on the first one.
- selection._setTo( viewRoot.getChild( 0 ), 'on', { fake: true } );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( getMutationStats( observer.takeRecords() ) ).to.deep.equal( [
- 'added: 0, removed: 1'
- ] );
- } );
- } );
- function getMutationStats( mutationList ) {
- return mutationList.map( mutation => {
- return `added: ${ mutation.addedNodes.length }, removed: ${ mutation.removedNodes.length }`;
- } );
- }
- function cleanObserver( observer ) {
- observer.takeRecords();
- }
- function makeContainers( howMany ) {
- const containers = [];
- for ( let i = 1; i <= howMany; i++ ) {
- containers.push( `<container:p>${ i }</container:p>` );
- }
- return containers.join( '' );
- }
- } );
- // #1560
- describe( 'attributes manipulation on replaced element', () => {
- it( 'should rerender element if it was removed after having its attributes removed (attribute)', () => {
- const writer = new DowncastWriter();
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- const viewP = viewRoot.getChild( 0 );
- writer.setAttribute( 'data-placeholder', 'Body', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
- // 2. Modify view.
- writer.removeAttribute( 'data-placeholder', viewP );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'attributes', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
- } );
- it( 'should rerender element if it was removed after having its attributes removed (classes)', () => {
- const writer = new DowncastWriter();
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:h1>h1</container:h1><container:p>p</container:p>' ) );
- const viewP = viewRoot.getChild( 1 );
- writer.addClass( [ 'cke-test1', 'cke-test2' ], viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1 cke-test2">p</p>' );
- // 2. Modify view.
- writer.removeClass( 'cke-test2', viewP );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( parse( '<container:h1>h1</container:h1>' +
- '<container:p class="cke-test1">p</container:p><container:p>p2</container:p>' ) );
- renderer.markToSync( 'attributes', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<h1>h1</h1><p class="cke-test1">p</p><p>p2</p>' );
- } );
- it( 'should rerender element if it was removed and have its attributes removed after', () => {
- const writer = new DowncastWriter();
- // 1. Setup initial view/DOM.
- viewRoot._appendChild( parse( '<container:p>1</container:p>' ) );
- const viewP = viewRoot.getChild( 0 );
- writer.setAttribute( 'data-placeholder', 'Body', viewP );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p data-placeholder="Body">1</p>' );
- // 2. Modify view.
- viewRoot._removeChildren( 0, viewRoot.childCount );
- writer.removeAttribute( 'data-placeholder', viewP );
- viewRoot._appendChild( parse( '<container:p>1</container:p><container:p>2</container:p>' ) );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.innerHTML ).to.equal( '<p>1</p><p>2</p>' );
- } );
- } );
- // ckeditor/ckeditor5-utils#269
- // The expected times has a significant margin above the usual execution time (which is around 40-50%
- // of the expected time) because it depends on the browser and environment in which tests are run.
- // However, for larger data sets the difference between using `diff()` and `fastDiff()` (see above issue for context)
- // is more than 10x in execution time so it is clearly visible in these tests when something goes wrong.
- describe( 'rendering performance', () => {
- before( function() {
- // Ignore on Edge browser where performance is quite poor.
- if ( env.isEdge ) {
- this.skip();
- }
- } );
- it( 'should not take more than 350ms to render around 300 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 65 ), generateViewData1( 55 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 300 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 55 ), generateViewData2( 65 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 500 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 105 ), generateViewData1( 95 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 500 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 95 ), generateViewData2( 105 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 1000 element nodes (same html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 195 ), generateViewData1( 205 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- it( 'should not take more than 350ms to render around 1000 element nodes (different html)', () => {
- const renderingTime = measureRenderingTime( viewRoot, generateViewData1( 205 ), generateViewData2( 195 ) );
- expect( renderingTime ).to.be.within( 0, 350 );
- } );
- function measureRenderingTime( viewRoot, initialData, newData ) {
- // Set initial data.
- const initialView = parse( initialData );
- viewRoot._appendChild( initialView );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Set new data.
- const newView = parse( newData );
- viewRoot._removeChildren( 0, viewRoot.childCount );
- viewRoot._appendChild( newView );
- renderer.markToSync( 'children', viewRoot );
- // Measure render time.
- const start = Date.now();
- renderer.render();
- return Date.now() - start;
- }
- function generateViewData1( repeat = 1 ) {
- const viewData = '' +
- '<container:h1>' +
- 'CKEditor 5 <attribute:strong>h1</attribute:strong> heading!' +
- '</container:h1>' +
- '<container:p>' +
- 'Foo <attribute:strong>Bar</attribute:strong> Baz and some text' +
- '</container:p>' +
- '<container:ul>' +
- '<container:li>Item 1</container:li>' +
- '</container:ul>' +
- '<container:ul>' +
- '<container:li>Item 2</container:li>' +
- '</container:ul>' +
- '<container:ul>' +
- '<container:li>Item 3</container:li>' +
- '</container:ul>';
- return viewData.repeat( repeat );
- }
- function generateViewData2( repeat = 1 ) {
- const viewData = '' +
- '<container:ol>' +
- '<container:li>' +
- '<attribute:strong>Foo</attribute:strong>' +
- '</container:li>' +
- '</container:ol>' +
- '<container:ol>' +
- '<container:li>Item 1</container:li>' +
- '</container:ol>' +
- '<container:h1>Heading 1</container:h1>' +
- '<container:h2>' +
- '<attribute:strong>Heading</attribute:strong> 2' +
- '</container:h2>' +
- '<container:h3>Heading 4</container:h3>';
- return viewData.repeat( repeat );
- }
- } );
- // #1782
- it( 'should leave dom selection untouched while composing', () => {
- const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
- viewRoot._appendChild( viewP );
- selection._setTo( newSelection );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- // Mock IME typing in Safari: <p>[c]</p>.
- renderer.isComposing = true;
- const domText = document.createTextNode( 'c' );
- domRoot.firstChild.appendChild( domText );
- const range = document.createRange();
- range.setStart( domText, 0 );
- range.setEnd( domText, 1 );
- const domSelection = document.getSelection();
- domSelection.removeAllRanges();
- domSelection.addRange( range );
- // <container:p>c[]</container:p>
- viewP._appendChild( new ViewText( 'c' ) );
- selection._setTo( [
- new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 0 ), 1 ) )
- ] );
- renderer.markToSync( 'children', viewP );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.firstChild.childNodes.length ).to.equal( 1 );
- expect( domRoot.firstChild.firstChild.data ).to.equal( 'c' );
- const currentRange = domSelection.getRangeAt( 0 );
- expect( currentRange.collapsed ).to.equal( false );
- expect( currentRange.startContainer ).to.equal( domRoot.firstChild.firstChild );
- expect( currentRange.startOffset ).to.equal( 0 );
- expect( currentRange.endContainer ).to.equal( domRoot.firstChild.firstChild );
- expect( currentRange.endOffset ).to.equal( 1 );
- } );
- } );
- describe( '#922', () => {
- let view, viewDoc, viewRoot, domRoot, converter;
- beforeEach( () => {
- view = new View();
- viewDoc = view.document;
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- viewRoot = createViewRoot( viewDoc );
- view.attachDomRoot( domRoot );
- converter = view.domConverter;
- } );
- it( 'should properly render unwrapped attributes #1', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>f</attribute:strong>' +
- '</attribute:italic>]' +
- '<attribute:strong>oo</attribute:strong>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Unwrap italic attribute element.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render unwrapped attributes #2', () => {
- setViewData( view,
- '<container:p>' +
- '[<attribute:italic>' +
- '<attribute:strong>foo</attribute:strong>' +
- '</attribute:italic>]' +
- '</container:p>' );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Unwrap italic attribute element and change text inside.
- view.change( writer => {
- writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
- } );
- viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 )._data = 'bar';
- expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #1', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition._createAfter( textNode ), new ViewAttributeElement( 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should properly render if text is changed and element is inserted into same node #2', () => {
- setViewData( view,
- '<container:p>foo</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Change text and insert new element into paragraph.
- const textNode = viewRoot.getChild( 0 ).getChild( 0 );
- textNode._data = 'foobar';
- view.change( writer => {
- writer.insert( ViewPosition._createBefore( textNode ), new ViewAttributeElement( 'img' ) );
- } );
- expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
- expect( checkMappings() ).to.be.true;
- } );
- it( 'should not unbind elements that are removed and reinserted to DOM', () => {
- setViewData( view,
- '<container:p>' +
- '<attribute:b></attribute:b>' +
- '<attribute:i></attribute:i>' +
- '<attribute:span></attribute:span>' +
- '</container:p>'
- );
- // Render it to DOM to create initial DOM <-> view mappings.
- view.forceRender();
- // Remove first element and reinsert it at the end.
- const container = viewRoot.getChild( 0 );
- const firstElement = container.getChild( 0 );
- view.change( writer => {
- writer.remove( ViewRange._createOn( firstElement ) );
- writer.insert( new ViewPosition( container, 2 ), firstElement );
- } );
- expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- // Re-render changes in view to DOM.
- view.forceRender();
- // Check if DOM is rendered correctly.
- expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
- expect( checkMappings() ).to.be.true;
- } );
- // Checks if every node in DOM tree is mapped to the view.
- function checkMappings() {
- const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
- while ( domWalker.nextNode() ) {
- const node = domWalker.currentNode;
- if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
- return false;
- }
- }
- return true;
- }
- } );
- describe( '_markDescendantTextToSync', () => {
- let viewRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( 'div' );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- } );
- it( 'should handle null values', () => {
- // Such situation occurs when renderer encounters inline filler in 'renderer._updateChildren'.
- renderer._markDescendantTextToSync( null );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should handle element nodes', () => {
- const viewP = parse( '<container:p>foo<attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 3 );
- } );
- it( 'should handle text nodes', () => {
- const viewP = parse( '<container:p><attribute:b>bar<attribute:i>baz</attribute:i></attribute:b></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP.getChild( 0 ).getChild( 0 ) );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 1 );
- } );
- it( 'should handle document fragment', () => {
- const fragment = new DocumentFragment();
- renderer._markDescendantTextToSync( fragment );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- it( 'should handle empty element nodes', () => {
- const viewP = parse( '<container:p></container:p>' );
- viewRoot._appendChild( viewP );
- renderer._markDescendantTextToSync( viewP );
- expect( renderer.markedChildren.size ).to.equal( 0 );
- expect( renderer.markedAttributes.size ).to.equal( 0 );
- expect( renderer.markedTexts.size ).to.equal( 0 );
- } );
- } );
- describe( '_updateText', () => {
- let viewRoot, domRoot;
- beforeEach( () => {
- viewRoot = new ViewElement( 'div' );
- domRoot = document.createElement( 'div' );
- document.body.appendChild( domRoot );
- domConverter.bindElements( domRoot, viewRoot );
- renderer.markedTexts.clear();
- renderer.markedAttributes.clear();
- renderer.markedChildren.clear();
- renderer.isFocused = true;
- } );
- afterEach( () => {
- domRoot.remove();
- } );
- it( 'should update text - change on end', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'fobar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
- } );
- it( 'should update text - change on start', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = 'baro';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'baro' );
- } );
- it( 'should update text - change in the middle', () => {
- const viewText = new ViewText( 'foobar' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foobar' );
- viewText._data = 'fobazr';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobazr' );
- } );
- it( 'should update text - empty expected', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- viewText._data = '';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- } );
- it( 'should update text - empty actual', () => {
- const viewText = new ViewText( '' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- viewText._data = 'fobar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'fobar' );
- } );
- it( 'should handle filler during text modifications', () => {
- const viewText = new ViewText( 'foo' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'barfoo';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'barfoo' );
- // 3. Remove filler.
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( 'barfoo' );
- } );
- it( 'should handle filler during text modifications - empty text', () => {
- const viewText = new ViewText( '' );
- viewRoot._appendChild( viewText );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'foo';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 3. Remove filler.
- viewText._data = '';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].data ).to.equal( '' );
- } );
- it( 'should handle filler during text modifications inside inline element', () => {
- const viewB = new ViewElement( 'b' );
- const viewText = new ViewText( 'foo' );
- viewB._appendChild( viewText );
- viewRoot._appendChild( viewB );
- renderer.markToSync( 'children', viewRoot );
- renderer.render();
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
- // 1. Insert filler.
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'foo' );
- // 2. Edit text - filler should be preserved.
- viewText._data = 'bar';
- renderer._updateText( viewText, {
- inlineFillerPosition: {
- parent: viewText.parent,
- offset: 0
- }
- } );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'bar' );
- // 3. Remove filler.
- viewText._data = 'bar';
- renderer._updateText( viewText, {} );
- expect( domRoot.childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'B' );
- expect( domRoot.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
- expect( domRoot.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'bar' );
- } );
- } );
- } );
- function renderAndExpectNoChanges( renderer, domRoot ) {
- const config = {
- childList: true,
- characterData: true,
- characterDataOldValue: true,
- subtree: true
- };
- const mutationObserver = new window.MutationObserver( () => {
- throw 'There should be not mutations';
- } );
- mutationObserver.observe( domRoot, config );
- renderer.render();
- const records = mutationObserver.takeRecords();
- mutationObserver.disconnect();
- expect( records.length ).to.equal( 0 );
- }
|