8
0

imageuploadcommand.js 6.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. import VirtualTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/virtualtesteditor';
  6. import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
  7. import ImageUploadCommand from '../../src/imageupload/imageuploadcommand';
  8. import FileRepository from '@ckeditor/ckeditor5-upload/src/filerepository';
  9. import { createNativeFileMock, UploadAdapterMock } from '@ckeditor/ckeditor5-upload/tests/_utils/mocks';
  10. import { setData as setModelData, getData as getModelData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
  11. import Image from '../../src/image/imageediting';
  12. import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
  13. import log from '@ckeditor/ckeditor5-utils/src/log';
  14. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  15. describe( 'ImageUploadCommand', () => {
  16. let editor, command, model, fileRepository;
  17. testUtils.createSinonSandbox();
  18. class UploadAdapterPluginMock extends Plugin {
  19. init() {
  20. fileRepository = this.editor.plugins.get( FileRepository );
  21. fileRepository.createUploadAdapter = loader => {
  22. return new UploadAdapterMock( loader );
  23. };
  24. }
  25. }
  26. beforeEach( () => {
  27. return VirtualTestEditor
  28. .create( {
  29. plugins: [ FileRepository, Image, Paragraph, UploadAdapterPluginMock ]
  30. } )
  31. .then( newEditor => {
  32. editor = newEditor;
  33. model = editor.model;
  34. command = new ImageUploadCommand( editor );
  35. const schema = model.schema;
  36. schema.extend( 'image', { allowAttributes: 'uploadId' } );
  37. } );
  38. } );
  39. afterEach( () => {
  40. return editor.destroy();
  41. } );
  42. describe( 'isEnabled', () => {
  43. it( 'should be true when the selection directly in the root', () => {
  44. model.enqueueChange( 'transparent', () => {
  45. setModelData( model, '[]' );
  46. command.refresh();
  47. expect( command.isEnabled ).to.be.true;
  48. } );
  49. } );
  50. it( 'should be true when the selection is in empty block', () => {
  51. setModelData( model, '<paragraph>[]</paragraph>' );
  52. expect( command.isEnabled ).to.be.true;
  53. } );
  54. it( 'should be true when the selection directly in a paragraph', () => {
  55. setModelData( model, '<paragraph>foo[]</paragraph>' );
  56. expect( command.isEnabled ).to.be.true;
  57. } );
  58. it( 'should be true when the selection directly in a block', () => {
  59. model.schema.register( 'block', { inheritAllFrom: '$block' } );
  60. model.schema.extend( '$text', { allowIn: 'block' } );
  61. editor.conversion.for( 'downcast' ).elementToElement( { model: 'block', view: 'block' } );
  62. setModelData( model, '<block>foo[]</block>' );
  63. expect( command.isEnabled ).to.be.true;
  64. } );
  65. it( 'should be false when the selection is on other image', () => {
  66. setModelData( model, '[<image></image>]' );
  67. expect( command.isEnabled ).to.be.false;
  68. } );
  69. it( 'should be false when the selection is inside other image', () => {
  70. model.schema.register( 'caption', {
  71. allowIn: 'image',
  72. allowContentOf: '$block',
  73. isLimit: true
  74. } );
  75. editor.conversion.for( 'downcast' ).elementToElement( { model: 'caption', view: 'figcaption' } );
  76. setModelData( model, '<image><caption>[]</caption></image>' );
  77. expect( command.isEnabled ).to.be.false;
  78. } );
  79. it( 'should be false when the selection is on other object', () => {
  80. model.schema.register( 'object', { isObject: true, allowIn: '$root' } );
  81. editor.conversion.for( 'downcast' ).elementToElement( { model: 'object', view: 'object' } );
  82. setModelData( model, '[<object></object>]' );
  83. expect( command.isEnabled ).to.be.false;
  84. } );
  85. it( 'should be false when the selection is inside other object', () => {
  86. model.schema.register( 'object', { isObject: true, allowIn: '$root' } );
  87. model.schema.extend( '$text', { allowIn: 'object' } );
  88. editor.conversion.for( 'downcast' ).elementToElement( { model: 'object', view: 'object' } );
  89. setModelData( model, '<object>[]</object>' );
  90. expect( command.isEnabled ).to.be.false;
  91. } );
  92. it( 'should be false when schema disallows image', () => {
  93. model.schema.register( 'block', { inheritAllFrom: '$block' } );
  94. model.schema.extend( 'paragraph', { allowIn: 'block' } );
  95. // Block image in block.
  96. model.schema.addChildCheck( ( context, childDefinition ) => {
  97. if ( childDefinition.name === 'image' && context.last.name === 'block' ) {
  98. return false;
  99. }
  100. } );
  101. editor.conversion.for( 'downcast' ).elementToElement( { model: 'block', view: 'block' } );
  102. setModelData( model, '<block><paragraph>[]</paragraph></block>' );
  103. expect( command.isEnabled ).to.be.false;
  104. } );
  105. } );
  106. describe( 'execute()', () => {
  107. it( 'should insert image at selection position as other widgets', () => {
  108. const file = createNativeFileMock();
  109. setModelData( model, '<paragraph>f[o]o</paragraph>' );
  110. command.execute( { file } );
  111. const id = fileRepository.getLoader( file ).id;
  112. expect( getModelData( model ) )
  113. .to.equal( `[<image uploadId="${ id }"></image>]<paragraph>foo</paragraph>` );
  114. } );
  115. it( 'should use parent batch', () => {
  116. const file = createNativeFileMock();
  117. setModelData( model, '<paragraph>[]foo</paragraph>' );
  118. model.change( writer => {
  119. expect( writer.batch.operations ).to.length( 0 );
  120. command.execute( { file } );
  121. expect( writer.batch.operations ).to.length.above( 0 );
  122. } );
  123. } );
  124. it( 'should not insert image nor crash when image could not be inserted', () => {
  125. const file = createNativeFileMock();
  126. model.schema.register( 'other', {
  127. allowIn: '$root',
  128. isLimit: true
  129. } );
  130. model.schema.extend( '$text', { allowIn: 'other' } );
  131. editor.conversion.for( 'downcast' ).elementToElement( { model: 'other', view: 'p' } );
  132. setModelData( model, '<other>[]</other>' );
  133. command.execute( { file } );
  134. expect( getModelData( model ) ).to.equal( '<other>[]</other>' );
  135. } );
  136. it( 'should not throw when upload adapter is not set (FileRepository will log an error anyway)', () => {
  137. const file = createNativeFileMock();
  138. fileRepository.createUploadAdapter = undefined;
  139. const logStub = testUtils.sinon.stub( log, 'error' );
  140. setModelData( model, '<paragraph>fo[]o</paragraph>' );
  141. expect( () => {
  142. command.execute( { file } );
  143. } ).to.not.throw();
  144. expect( getModelData( model ) ).to.equal( '<paragraph>fo[]o</paragraph>' );
  145. expect( logStub.calledOnce ).to.be.true;
  146. } );
  147. } );
  148. } );