8
0

renderer.js 45 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287
  1. /**
  2. * @license Copyright (c) 2003-2015, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals Range, document, window */
  6. /* bender-tags: view, browser-only */
  7. import ViewElement from '/ckeditor5/engine/view/element.js';
  8. import ViewText from '/ckeditor5/engine/view/text.js';
  9. import ViewRange from '/ckeditor5/engine/view/range.js';
  10. import Selection from '/ckeditor5/engine/view/selection.js';
  11. import DomConverter from '/ckeditor5/engine/view/domconverter.js';
  12. import Renderer from '/ckeditor5/engine/view/renderer.js';
  13. import CKEditorError from '/ckeditor5/utils/ckeditorerror.js';
  14. import { parse } from '/ckeditor5/engine/dev-utils/view.js';
  15. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '/ckeditor5/engine/view/filler.js';
  16. import testUtils from '/tests/core/_utils/utils.js';
  17. import createElement from '/ckeditor5/utils/dom/createelement.js';
  18. testUtils.createSinonSandbox();
  19. describe( 'Renderer', () => {
  20. let selection, domConverter, renderer;
  21. beforeEach( () => {
  22. selection = new Selection();
  23. domConverter = new DomConverter();
  24. renderer = new Renderer( domConverter, selection );
  25. renderer.domDocuments.add( document );
  26. } );
  27. describe( 'markToSync', () => {
  28. let viewRoot;
  29. beforeEach( () => {
  30. viewRoot = new ViewElement( 'p' );
  31. const domRoot = document.createElement( 'p' );
  32. domConverter.bindElements( domRoot, viewRoot );
  33. viewRoot.appendChildren( new ViewText( 'foo' ) );
  34. renderer.markedTexts.clear();
  35. renderer.markedAttributes.clear();
  36. renderer.markedChildren.clear();
  37. } );
  38. it( 'should mark attributes which need update', () => {
  39. viewRoot.setAttribute( 'class', 'foo' );
  40. renderer.markToSync( 'attributes', viewRoot );
  41. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  42. } );
  43. it( 'should mark children which need update', () => {
  44. viewRoot.appendChildren( new ViewText( 'foo' ) );
  45. renderer.markToSync( 'children', viewRoot );
  46. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  47. } );
  48. it( 'should not mark children if element has no corresponding node', () => {
  49. // Overwrite viewRoot with node without coresponding DOM node.
  50. viewRoot = new ViewElement( 'p' );
  51. viewRoot.appendChildren( new ViewText( 'foo' ) );
  52. renderer.markToSync( 'children', viewRoot );
  53. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  54. } );
  55. it( 'should mark text which need update', () => {
  56. const viewText = new ViewText( 'foo' );
  57. viewRoot.appendChildren( viewText );
  58. viewText.data = 'bar';
  59. renderer.markToSync( 'text', viewText );
  60. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  61. } );
  62. it( 'should not mark text if parent has no corresponding node', () => {
  63. const viewText = new ViewText( 'foo' );
  64. // Overwrite viewRoot with node without coresponding DOM node.
  65. viewRoot = new ViewElement( 'p' );
  66. viewRoot.appendChildren( viewText );
  67. viewText.data = 'bar';
  68. renderer.markToSync( 'text', viewText );
  69. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  70. } );
  71. it( 'should throw if the type is unknown', () => {
  72. expect( () => {
  73. renderer.markToSync( 'UNKNOWN', viewRoot );
  74. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  75. } );
  76. } );
  77. describe( 'render', () => {
  78. let viewRoot, domRoot, selectionEditable;
  79. beforeEach( () => {
  80. viewRoot = new ViewElement( 'div' );
  81. domRoot = document.createElement( 'div' );
  82. document.body.appendChild( domRoot );
  83. domConverter.bindElements( domRoot, viewRoot );
  84. renderer.markedTexts.clear();
  85. renderer.markedAttributes.clear();
  86. renderer.markedChildren.clear();
  87. selection.removeAllRanges();
  88. selection.setFake( false );
  89. selectionEditable = viewRoot;
  90. renderer.isFocused = true;
  91. // Fake selection editable - it is needed to render selection properly.
  92. Object.defineProperty( selection, 'editableElement', {
  93. get: function() {
  94. return selectionEditable;
  95. }
  96. } );
  97. } );
  98. it( 'should update attributes', () => {
  99. viewRoot.setAttribute( 'class', 'foo' );
  100. renderer.markToSync( 'attributes', viewRoot );
  101. renderer.render();
  102. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  103. expect( renderer.markedAttributes.size ).to.equal( 0 );
  104. } );
  105. it( 'should remove attributes', () => {
  106. viewRoot.setAttribute( 'class', 'foo' );
  107. domRoot.setAttribute( 'id', 'bar' );
  108. domRoot.setAttribute( 'class', 'bar' );
  109. renderer.markToSync( 'attributes', viewRoot );
  110. renderer.render();
  111. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  112. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  113. expect( renderer.markedAttributes.size ).to.equal( 0 );
  114. } );
  115. it( 'should add children', () => {
  116. viewRoot.appendChildren( new ViewText( 'foo' ) );
  117. renderer.markToSync( 'children', viewRoot );
  118. renderer.render();
  119. expect( domRoot.childNodes.length ).to.equal( 1 );
  120. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  121. expect( renderer.markedChildren.size ).to.equal( 0 );
  122. } );
  123. it( 'should remove children', () => {
  124. viewRoot.appendChildren( new ViewText( 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. viewRoot.removeChildren( 0, 1 );
  130. renderer.markToSync( 'children', viewRoot );
  131. renderer.render();
  132. expect( domRoot.childNodes.length ).to.equal( 0 );
  133. expect( renderer.markedChildren.size ).to.equal( 0 );
  134. } );
  135. it( 'should update text', () => {
  136. const viewText = new ViewText( 'foo' );
  137. viewRoot.appendChildren( viewText );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 1 );
  141. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  142. viewText.data = 'bar';
  143. renderer.markToSync( 'text', viewText );
  144. renderer.render();
  145. expect( domRoot.childNodes.length ).to.equal( 1 );
  146. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  147. expect( renderer.markedTexts.size ).to.equal( 0 );
  148. } );
  149. it( 'should not update text parent child list changed', () => {
  150. const viewImg = new ViewElement( 'img' );
  151. const viewText = new ViewText( 'foo' );
  152. viewRoot.appendChildren( [ viewImg, viewText ] );
  153. renderer.markToSync( 'children', viewRoot );
  154. renderer.markToSync( 'text', viewText );
  155. renderer.render();
  156. expect( domRoot.childNodes.length ).to.equal( 2 );
  157. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  158. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  159. } );
  160. it( 'should not change text if it is the same during text rendering', () => {
  161. const viewText = new ViewText( 'foo' );
  162. viewRoot.appendChildren( viewText );
  163. renderer.markToSync( 'children', viewRoot );
  164. renderer.render();
  165. // This should not be changed during the render.
  166. const domText = domRoot.childNodes[ 0 ];
  167. renderer.markToSync( 'text', viewText );
  168. renderer.render();
  169. expect( domRoot.childNodes.length ).to.equal( 1 );
  170. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  171. } );
  172. it( 'should not change text if it is the same during children rendering', () => {
  173. const viewText = new ViewText( 'foo' );
  174. viewRoot.appendChildren( viewText );
  175. renderer.markToSync( 'children', viewRoot );
  176. renderer.render();
  177. // This should not be changed during the render.
  178. const domText = domRoot.childNodes[ 0 ];
  179. renderer.markToSync( 'children', viewRoot );
  180. renderer.render();
  181. expect( domRoot.childNodes.length ).to.equal( 1 );
  182. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  183. } );
  184. it( 'should not change element if it is the same', () => {
  185. const viewImg = new ViewElement( 'img' );
  186. viewRoot.appendChildren( viewImg );
  187. // This should not be changed during the render.
  188. const domImg = document.createElement( 'img' );
  189. domRoot.appendChild( domImg );
  190. domConverter.bindElements( domImg, viewImg );
  191. renderer.markToSync( 'children', viewRoot );
  192. renderer.render();
  193. expect( domRoot.childNodes.length ).to.equal( 1 );
  194. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  195. } );
  196. it( 'should change element if it is different', () => {
  197. const viewImg = new ViewElement( 'img' );
  198. viewRoot.appendChildren( viewImg );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. const viewP = new ViewElement( 'p' );
  202. viewRoot.removeChildren( 0, 1 );
  203. viewRoot.appendChildren( viewP );
  204. renderer.markToSync( 'children', viewRoot );
  205. renderer.render();
  206. expect( domRoot.childNodes.length ).to.equal( 1 );
  207. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  208. } );
  209. it( 'should not care about filler if there is no DOM', () => {
  210. selectionEditable = null;
  211. const { view: viewP, selection: newSelection } = parse(
  212. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  213. const viewRoot = new ViewElement( 'p' );
  214. viewRoot.appendChildren( viewP );
  215. selection.setTo( newSelection );
  216. renderer.markToSync( 'children', viewRoot );
  217. renderer.render();
  218. // Expect no error on render.
  219. expect( viewRoot ).to.be.ok;
  220. } );
  221. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  222. const domSelection = document.getSelection();
  223. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  224. const { view: viewP, selection: newSelection } = parse(
  225. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  226. viewRoot.appendChildren( viewP );
  227. selection.setTo( newSelection );
  228. renderer.markToSync( 'children', viewRoot );
  229. renderer.render();
  230. expect( domRoot.childNodes.length ).to.equal( 1 );
  231. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  232. const domP = domRoot.childNodes[ 0 ];
  233. expect( domP.childNodes.length ).to.equal( 3 );
  234. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  235. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  236. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  237. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  238. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  239. expect( domSelection.rangeCount ).to.equal( 1 );
  240. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  241. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  242. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  243. // Step 2: No mutation on second render
  244. renderer.markToSync( 'children', viewRoot );
  245. renderer.markToSync( 'children', viewP );
  246. renderAndExpectNoChanges( renderer, domRoot );
  247. // Step 3: <p>foo{}<b></b></p>
  248. selection.removeAllRanges();
  249. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  250. renderer.render();
  251. expect( domP.childNodes.length ).to.equal( 3 );
  252. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  253. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  254. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  255. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  256. expect( domSelection.rangeCount ).to.equal( 1 );
  257. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  258. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  259. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  260. // Step 4: No mutation on second render
  261. renderer.markToSync( 'children', viewRoot );
  262. renderer.markToSync( 'children', viewP );
  263. renderAndExpectNoChanges( renderer, domRoot );
  264. } );
  265. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  266. const domSelection = document.getSelection();
  267. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  268. const { view: viewP, selection: newSelection } = parse(
  269. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  270. viewRoot.appendChildren( viewP );
  271. selection.setTo( newSelection );
  272. renderer.markToSync( 'children', viewRoot );
  273. renderer.render();
  274. const domP = domRoot.childNodes[ 0 ];
  275. expect( domP.childNodes.length ).to.equal( 2 );
  276. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  277. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  278. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  279. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  280. expect( domSelection.rangeCount ).to.equal( 1 );
  281. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  282. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  283. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  284. // Step 2: No mutation on second render
  285. renderer.markToSync( 'children', viewP );
  286. renderAndExpectNoChanges( renderer, domRoot );
  287. // Step 3: <p><b>{}foo</b></p>
  288. selection.removeAllRanges();
  289. selection.addRange( ViewRange.createFromParentsAndOffsets(
  290. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  291. renderer.render();
  292. expect( domP.childNodes.length ).to.equal( 1 );
  293. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  294. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  295. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  296. expect( domSelection.rangeCount ).to.equal( 1 );
  297. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] .childNodes[ 0 ] );
  298. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  299. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  300. // Step 4: No mutation on second render
  301. renderer.markToSync( 'children', viewP );
  302. renderAndExpectNoChanges( renderer, domRoot );
  303. } );
  304. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  305. const domSelection = document.getSelection();
  306. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  307. const { view: viewP, selection: newSelection } = parse(
  308. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  309. viewRoot.appendChildren( viewP );
  310. selection.setTo( newSelection );
  311. renderer.markToSync( 'children', viewRoot );
  312. renderer.render();
  313. const domP = domRoot.childNodes[ 0 ];
  314. expect( domP.childNodes.length ).to.equal( 2 );
  315. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  316. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  317. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  318. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  319. expect( domSelection.rangeCount ).to.equal( 1 );
  320. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  321. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  322. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  323. // Step 2: No mutation on second render
  324. renderer.markToSync( 'children', viewP );
  325. renderAndExpectNoChanges( renderer, domRoot );
  326. // Step 3: <p><b>foo{}</b></p>
  327. selection.removeAllRanges();
  328. selection.addRange( ViewRange.createFromParentsAndOffsets(
  329. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  330. renderer.render();
  331. expect( domP.childNodes.length ).to.equal( 1 );
  332. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  333. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  334. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  335. expect( domSelection.rangeCount ).to.equal( 1 );
  336. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] .childNodes[ 0 ] );
  337. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  338. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  339. // Step 4: No mutation on second render
  340. renderer.markToSync( 'children', viewP );
  341. renderAndExpectNoChanges( renderer, domRoot );
  342. } );
  343. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  344. const domSelection = document.getSelection();
  345. const { view: viewP, selection: newSelection } = parse(
  346. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  347. viewRoot.appendChildren( viewP );
  348. selection.setTo( newSelection );
  349. renderer.markToSync( 'children', viewRoot );
  350. renderer.render();
  351. const domP = domRoot.childNodes[ 0 ];
  352. expect( domP.childNodes.length ).to.equal( 3 );
  353. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  354. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  355. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  356. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  357. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  358. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  359. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  360. expect( domSelection.rangeCount ).to.equal( 1 );
  361. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  362. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  363. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  364. } );
  365. it( 'should move filler when selection is moved', () => {
  366. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  367. const { view: viewP, selection: newSelection } = parse(
  368. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  369. viewRoot.appendChildren( viewP );
  370. selection.setTo( newSelection );
  371. renderer.markToSync( 'children', viewRoot );
  372. renderer.render();
  373. const domP = domRoot.childNodes[ 0 ];
  374. expect( domP.childNodes.length ).to.equal( 3 );
  375. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  376. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  377. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  378. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  379. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  380. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  381. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  382. selection.removeAllRanges();
  383. const viewI = viewP.getChild( 2 );
  384. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  385. renderer.render();
  386. expect( domP.childNodes.length ).to.equal( 3 );
  387. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  389. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  390. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  391. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  392. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  393. } );
  394. it( 'should remove filler when text is added and selection removed', () => {
  395. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  396. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  397. const viewB = viewP.getChild( 1 );
  398. viewRoot.appendChildren( viewP );
  399. selection.setTo( newSelection );
  400. renderer.markToSync( 'children', viewRoot );
  401. renderer.render();
  402. const domP = domRoot.childNodes[ 0 ];
  403. expect( domP.childNodes.length ).to.equal( 2 );
  404. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  405. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  406. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  407. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  408. // Step 2: Add text node.
  409. const viewText = new ViewText( 'x' );
  410. viewB.appendChildren( viewText );
  411. selection.removeAllRanges();
  412. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  413. renderer.markToSync( 'children', viewB );
  414. renderer.render();
  415. // Step 3: Remove selection from the view.
  416. selection.removeAllRanges();
  417. renderer.render();
  418. expect( domP.childNodes.length ).to.equal( 2 );
  419. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  420. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  421. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  422. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  423. } );
  424. // #659
  425. // The element before the filler is removed so the position of the filler
  426. // cannot be remembered as parent+offset.
  427. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  428. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  429. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  430. viewRoot.appendChildren( viewP );
  431. selection.setTo( newSelection );
  432. renderer.markToSync( 'children', viewRoot );
  433. renderer.render();
  434. const domP = domRoot.childNodes[ 0 ];
  435. expect( domP.childNodes.length ).to.equal( 3 );
  436. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  437. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  438. viewP.removeChildren( 1 );
  439. selection.removeAllRanges();
  440. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  441. renderer.markToSync( 'children', viewP );
  442. renderer.render();
  443. // Step 3: Check whether there's no filler in the DOM.
  444. expect( domP.childNodes.length ).to.equal( 1 );
  445. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  446. } );
  447. // #659
  448. it( 'should remove filler from a modified DOM when children moved', () => {
  449. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  450. const { view: viewFragment, selection: newSelection }
  451. = parse( '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>' );
  452. viewRoot.appendChildren( viewFragment );
  453. selection.setTo( newSelection );
  454. renderer.markToSync( 'children', viewRoot );
  455. renderer.render();
  456. expect( domRoot.childNodes.length ).to.equal( 2 );
  457. const domP = domRoot.childNodes[ 0 ];
  458. const domP2 = domRoot.childNodes[ 1 ];
  459. expect( domP.childNodes.length ).to.equal( 3 );
  460. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  461. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  462. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  463. const viewP = viewRoot.getChild( 0 );
  464. const viewP2 = viewRoot.getChild( 1 );
  465. const removedChildren = viewP.removeChildren( 0, 2 );
  466. viewP2.appendChildren( removedChildren );
  467. selection.removeAllRanges();
  468. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  469. renderer.markToSync( 'children', viewP );
  470. renderer.markToSync( 'children', viewP2 );
  471. renderer.render();
  472. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  473. // in the second one there are two <b> tags.
  474. expect( domP.childNodes.length ).to.equal( 1 );
  475. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  476. expect( domP2.childNodes.length ).to.equal( 2 );
  477. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  478. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  479. } );
  480. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  481. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  482. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  483. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  484. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  485. viewRoot.appendChildren( viewP );
  486. selection.setTo( newSelection );
  487. renderer.markToSync( 'children', viewRoot );
  488. renderer.render();
  489. const domP = domRoot.childNodes[ 0 ];
  490. expect( domP.childNodes.length ).to.equal( 2 );
  491. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  492. // Step 2: Move selection to a new attribute element and remove the previous one
  493. viewP.removeChildren( 1 ); // Remove <b>.
  494. const viewI = parse( '<attribute:i></attribute:i>' );
  495. viewP.appendChildren( viewI );
  496. selection.removeAllRanges();
  497. selection.addRange( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  498. renderer.markToSync( 'children', viewP );
  499. renderer.render();
  500. // Step 3: Check whether new filler was created in the <i> element.
  501. expect( domP.childNodes.length ).to.equal( 2 );
  502. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  503. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  504. } );
  505. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  506. const domSelection = document.getSelection();
  507. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  508. viewRoot.appendChildren( viewP );
  509. selection.setTo( newSelection );
  510. renderer.markToSync( 'children', viewRoot );
  511. renderer.render();
  512. const domP = domRoot.childNodes[ 0 ];
  513. expect( domP.childNodes.length ).to.equal( 1 );
  514. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  515. expect( domSelection.rangeCount ).to.equal( 1 );
  516. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  517. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  518. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  519. // Remove filler and add text node to both DOM and View <p>x{}</p>
  520. domP.removeChild( domP.childNodes[ 0 ] );
  521. domP.appendChild( document.createTextNode( 'x' ) );
  522. domSelection.removeAllRanges();
  523. const domRange = new Range();
  524. domRange.setStart( domP.childNodes[ 0 ], 1 );
  525. domRange.collapse( true );
  526. domSelection.addRange( domRange );
  527. const viewText = new ViewText( 'x' );
  528. viewP.appendChildren( viewText );
  529. selection.removeAllRanges();
  530. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  531. renderer.markToSync( 'children', viewP );
  532. renderAndExpectNoChanges( renderer, domRoot );
  533. } );
  534. it( 'should handle typing in empty block, render if needed', () => {
  535. const domSelection = document.getSelection();
  536. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  537. viewRoot.appendChildren( viewP );
  538. selection.setTo( newSelection );
  539. renderer.markToSync( 'children', viewRoot );
  540. renderer.render();
  541. const domP = domRoot.childNodes[ 0 ];
  542. expect( domP.childNodes.length ).to.equal( 1 );
  543. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  544. expect( domSelection.rangeCount ).to.equal( 1 );
  545. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  546. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  547. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  548. // Add text node only in View <p>x{}</p>
  549. const viewText = new ViewText( 'x' );
  550. viewP.appendChildren( viewText );
  551. selection.removeAllRanges();
  552. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  553. renderer.markToSync( 'children', viewP );
  554. renderer.render();
  555. expect( domP.childNodes.length ).to.equal( 1 );
  556. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  557. expect( domSelection.rangeCount ).to.equal( 1 );
  558. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  559. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  560. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  561. } );
  562. it( 'should handle removing last character', () => {
  563. const domSelection = document.getSelection();
  564. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  565. viewRoot.appendChildren( viewP );
  566. selection.setTo( newSelection );
  567. renderer.markToSync( 'children', viewRoot );
  568. renderer.render();
  569. const domP = domRoot.childNodes[ 0 ];
  570. expect( domP.childNodes.length ).to.equal( 1 );
  571. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  572. expect( domSelection.rangeCount ).to.equal( 1 );
  573. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  574. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  575. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  576. // Remove text and add filler to both DOM and View <p>{}</p>
  577. domP.removeChild( domP.childNodes[ 0 ] );
  578. domP.appendChild( BR_FILLER( document ) );
  579. domSelection.removeAllRanges();
  580. const domRange = new Range();
  581. domRange.setStart( domP.childNodes[ 0 ], 0 );
  582. domRange.collapse( true );
  583. domSelection.addRange( domRange );
  584. viewP.removeChildren( 0 );
  585. selection.removeAllRanges();
  586. selection.addRange( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  587. renderer.markToSync( 'children', viewP );
  588. renderAndExpectNoChanges( renderer, domRoot );
  589. } );
  590. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  591. const domSelection = document.getSelection();
  592. // 1. Render <p><b>FILLER{}</b>foo</p>.
  593. const { view: viewP, selection: newSelection } = parse(
  594. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  595. viewRoot.appendChildren( viewP );
  596. selection.setTo( newSelection );
  597. renderer.markToSync( 'children', viewRoot );
  598. renderer.render();
  599. // 2. Check the DOM.
  600. const domP = domRoot.childNodes[ 0 ];
  601. expect( domP.childNodes.length ).to.equal( 2 );
  602. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  603. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  604. const domB = domP.childNodes[ 0 ];
  605. const viewB = viewP.getChild( 0 );
  606. expect( domB.childNodes.length ).to.equal( 1 );
  607. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  608. expect( domSelection.rangeCount ).to.equal( 1 );
  609. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  610. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  611. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  612. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  613. domB.childNodes[ 0 ].data += 'x';
  614. domSelection.removeAllRanges();
  615. const domRange = new Range();
  616. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  617. domRange.collapse( true );
  618. domSelection.addRange( domRange );
  619. const viewText = new ViewText( 'x' );
  620. viewB.appendChildren( viewText );
  621. selection.removeAllRanges();
  622. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  623. renderer.markToSync( 'children', viewP );
  624. renderAndExpectNoChanges( renderer, domRoot );
  625. } );
  626. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  627. const domSelection = document.getSelection();
  628. // 1. Render <p><b>FILLER{}</b>foo</p>.
  629. const { view: viewP, selection: newSelection } = parse(
  630. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  631. viewRoot.appendChildren( viewP );
  632. selection.setTo( newSelection );
  633. renderer.markToSync( 'children', viewRoot );
  634. renderer.render();
  635. // 2. Check the DOM.
  636. const domP = domRoot.childNodes[ 0 ];
  637. expect( domP.childNodes.length ).to.equal( 2 );
  638. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  639. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  640. const domB = domP.childNodes[ 0 ];
  641. const viewB = viewP.getChild( 0 );
  642. expect( domB.childNodes.length ).to.equal( 1 );
  643. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  644. expect( domSelection.rangeCount ).to.equal( 1 );
  645. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  646. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  647. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  648. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  649. const viewText = new ViewText( 'x' );
  650. viewB.appendChildren( viewText );
  651. selection.removeAllRanges();
  652. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  653. renderer.markToSync( 'children', viewB );
  654. renderer.render();
  655. expect( domB.childNodes.length ).to.equal( 1 );
  656. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  657. expect( domSelection.rangeCount ).to.equal( 1 );
  658. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  659. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  660. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  661. } );
  662. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  663. const domSelection = document.getSelection();
  664. // 1. Render <p><b>FILLER{}</b>foo</p>.
  665. const { view: viewP, selection: newSelection } = parse(
  666. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  667. viewRoot.appendChildren( viewP );
  668. selection.setTo( newSelection );
  669. renderer.markToSync( 'children', viewRoot );
  670. renderer.render();
  671. // 2. Check the DOM.
  672. const domP = domRoot.childNodes[ 0 ];
  673. expect( domP.childNodes.length ).to.equal( 2 );
  674. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  675. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  676. const domB = domP.childNodes[ 0 ];
  677. const viewB = viewP.getChild( 0 );
  678. expect( domB.childNodes.length ).to.equal( 1 );
  679. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  680. expect( domSelection.rangeCount ).to.equal( 1 );
  681. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  682. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  683. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  684. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  685. const viewText = new ViewText( 'x' );
  686. viewB.appendChildren( viewText );
  687. selection.removeAllRanges();
  688. selection.addRange( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  689. renderer.markToSync( 'text', viewText );
  690. renderer.render();
  691. // 4. Check the DOM.
  692. expect( domB.childNodes.length ).to.equal( 1 );
  693. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  694. expect( domSelection.rangeCount ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  696. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  697. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  698. } );
  699. it( 'should handle not collapsed range', () => {
  700. const domSelection = document.getSelection();
  701. const { view: viewP, selection: newSelection } = parse(
  702. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  703. viewRoot.appendChildren( viewP );
  704. selection.setTo( newSelection );
  705. renderer.markToSync( 'children', viewRoot );
  706. renderer.render();
  707. const domP = domRoot.childNodes[ 0 ];
  708. expect( domP.childNodes.length ).to.equal( 2 );
  709. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  710. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  711. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  712. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  713. expect( domSelection.rangeCount ).to.equal( 1 );
  714. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  715. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  716. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  717. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  718. renderer.markToSync( 'children', viewP );
  719. renderAndExpectNoChanges( renderer, domRoot );
  720. } );
  721. it( 'should not change selection if there is no editable with selection', () => {
  722. const domDiv = createElement( document, 'div', null, 'not editable' );
  723. document.body.appendChild( domDiv );
  724. const domSelection = document.getSelection();
  725. domSelection.removeAllRanges();
  726. const domRange = new Range();
  727. domRange.setStart( domDiv, 0 );
  728. domRange.collapse( true );
  729. domSelection.addRange( domRange );
  730. selectionEditable = null;
  731. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  732. viewRoot.appendChildren( viewP );
  733. selection.setTo( newSelection );
  734. renderer.render();
  735. expect( domSelection.rangeCount ).to.equal( 1 );
  736. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  737. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  738. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  739. } );
  740. it( 'should not change selection if there is no focus', () => {
  741. const domDiv = createElement( document, 'div', null, 'not editable' );
  742. document.body.appendChild( domDiv );
  743. const domSelection = document.getSelection();
  744. domSelection.removeAllRanges();
  745. const domRange = new Range();
  746. domRange.setStart( domDiv, 0 );
  747. domRange.collapse( true );
  748. domSelection.addRange( domRange );
  749. renderer.isFocused = false;
  750. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  751. viewRoot.appendChildren( viewP );
  752. selection.setTo( newSelection );
  753. renderer.render();
  754. expect( domSelection.rangeCount ).to.equal( 1 );
  755. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domDiv );
  756. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  757. expect( domSelection.getRangeAt( 0 ).collapsed ).to.equal( true );
  758. } );
  759. it( 'should not add inline filler after text node', () => {
  760. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  761. viewRoot.appendChildren( viewP );
  762. selection.setTo( newSelection );
  763. renderer.markToSync( 'children', viewRoot );
  764. renderer.render();
  765. const domP = domRoot.childNodes[ 0 ];
  766. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  767. } );
  768. it( 'should throw if there is no filler in expected position', () => {
  769. const { view: viewP, selection: newSelection } = parse(
  770. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  771. viewRoot.appendChildren( viewP );
  772. selection.setTo( newSelection );
  773. renderer.markToSync( 'children', viewRoot );
  774. renderer.render();
  775. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  776. const viewB = viewP.getChild( 1 );
  777. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  778. // Remove filler.
  779. domB.childNodes[ 0 ].data = '';
  780. selection.removeAllRanges();
  781. renderer.markToSync( 'children', viewB );
  782. expect( () => {
  783. renderer.render();
  784. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  785. } );
  786. it( 'should handle focusing element', () => {
  787. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  788. const editable = selection.editableElement;
  789. renderer.render();
  790. expect( editable ).to.equal( viewRoot );
  791. expect( domFocusSpy.calledOnce ).to.be.true;
  792. } );
  793. it( 'should not focus editable if isFocues is set to false', () => {
  794. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  795. renderer.isFocused = false;
  796. renderer.render();
  797. expect( domFocusSpy.calledOnce ).to.be.false;
  798. } );
  799. it( 'should not focus already focused DOM element', () => {
  800. domRoot.setAttribute( 'contentEditable', true );
  801. domRoot.focus();
  802. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  803. renderer.render();
  804. expect( domFocusSpy.called ).to.be.false;
  805. } );
  806. describe( 'fake selection', () => {
  807. beforeEach( () => {
  808. const { view: viewP, selection: newSelection } = parse(
  809. '<container:p>[foo bar]</container:p>'
  810. );
  811. viewRoot.appendChildren( viewP );
  812. selection.setTo( newSelection );
  813. renderer.markToSync( 'children', viewRoot );
  814. renderer.render();
  815. } );
  816. it( 'should render fake selection', () => {
  817. const label = 'fake selection label';
  818. selection.setFake( true, { label } );
  819. renderer.render();
  820. expect( domRoot.childNodes.length ).to.equal( 2 );
  821. const container = domRoot.childNodes[ 1 ];
  822. expect( domConverter.getCorrespondingViewElement( container ) ).to.be.undefined;
  823. expect( container.childNodes.length ).to.equal( 1 );
  824. const textNode = container.childNodes[ 0 ];
  825. expect( textNode.textContent ).to.equal( label );
  826. const domSelection = domRoot.ownerDocument.getSelection();
  827. expect( domSelection.anchorNode ).to.equal( textNode );
  828. expect( domSelection.anchorOffset ).to.equal( 0 );
  829. expect( domSelection.focusNode ).to.equal( textNode );
  830. expect( domSelection.focusOffset ).to.equal( label.length );
  831. } );
  832. it( 'should render &nbsp; if no selection label is provided', () => {
  833. selection.setFake( true );
  834. renderer.render();
  835. expect( domRoot.childNodes.length ).to.equal( 2 );
  836. const container = domRoot.childNodes[ 1 ];
  837. expect( container.childNodes.length ).to.equal( 1 );
  838. const textNode = container.childNodes[ 0 ];
  839. expect( textNode.textContent ).to.equal( '\u00A0' );
  840. const domSelection = domRoot.ownerDocument.getSelection();
  841. expect( domSelection.anchorNode ).to.equal( textNode );
  842. expect( domSelection.anchorOffset ).to.equal( 0 );
  843. expect( domSelection.focusNode ).to.equal( textNode );
  844. expect( domSelection.focusOffset ).to.equal( 1 );
  845. } );
  846. it( 'should remove fake selection container when selection is no longer fake', () => {
  847. selection.setFake( true );
  848. renderer.render();
  849. selection.setFake( false );
  850. renderer.render();
  851. expect( domRoot.childNodes.length ).to.equal( 1 );
  852. const domParagraph = domRoot.childNodes[ 0 ];
  853. expect( domParagraph.childNodes.length ).to.equal( 1 );
  854. const textNode = domParagraph.childNodes[ 0 ];
  855. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  856. const domSelection = domRoot.ownerDocument.getSelection();
  857. expect( domSelection.anchorNode ).to.equal( textNode );
  858. expect( domSelection.anchorOffset ).to.equal( 0 );
  859. expect( domSelection.focusNode ).to.equal( textNode );
  860. expect( domSelection.focusOffset ).to.equal( 7 );
  861. } );
  862. it( 'should reuse fake selection container #1', () => {
  863. const label = 'fake selection label';
  864. selection.setFake( true, { label } );
  865. renderer.render();
  866. expect( domRoot.childNodes.length ).to.equal( 2 );
  867. const container = domRoot.childNodes[ 1 ];
  868. selection.setFake( true, { label } );
  869. renderer.render();
  870. expect( domRoot.childNodes.length ).to.equal( 2 );
  871. const newContainer = domRoot.childNodes[ 1 ];
  872. expect( newContainer ).equals( container );
  873. expect( newContainer.childNodes.length ).to.equal( 1 );
  874. const textNode = newContainer.childNodes[ 0 ];
  875. expect( textNode.textContent ).to.equal( label );
  876. } );
  877. it( 'should reuse fake selection container #2', () => {
  878. selection.setFake( true, { label: 'label 1' } );
  879. renderer.render();
  880. expect( domRoot.childNodes.length ).to.equal( 2 );
  881. const container = domRoot.childNodes[ 1 ];
  882. selection.setFake( false );
  883. renderer.render();
  884. expect( domRoot.childNodes.length ).to.equal( 1 );
  885. selection.setFake( true, { label: 'label 2' } );
  886. renderer.render();
  887. expect( domRoot.childNodes.length ).to.equal( 2 );
  888. const newContainer = domRoot.childNodes[ 1 ];
  889. expect( newContainer ).equals( container );
  890. expect( newContainer.childNodes.length ).to.equal( 1 );
  891. const textNode = newContainer.childNodes[ 0 ];
  892. expect( textNode.textContent ).to.equal( 'label 2' );
  893. } );
  894. it( 'should reuse fake selection container #3', () => {
  895. selection.setFake( true, { label: 'label 1' } );
  896. renderer.render();
  897. expect( domRoot.childNodes.length ).to.equal( 2 );
  898. const container = domRoot.childNodes[ 1 ];
  899. selection.setFake( true, { label: 'label 2' } );
  900. renderer.render();
  901. expect( domRoot.childNodes.length ).to.equal( 2 );
  902. const newContainer = domRoot.childNodes[ 1 ];
  903. expect( newContainer ).equals( container );
  904. expect( newContainer.childNodes.length ).to.equal( 1 );
  905. const textNode = newContainer.childNodes[ 0 ];
  906. expect( textNode.textContent ).to.equal( 'label 2' );
  907. } );
  908. it( 'should style fake selection container properly', () => {
  909. selection.setFake( true, { label: 'fake selection' } );
  910. renderer.render();
  911. expect( domRoot.childNodes.length ).to.equal( 2 );
  912. const container = domRoot.childNodes[ 1 ];
  913. expect( container.style.position ).to.equal( 'fixed' );
  914. expect( container.style.top ).to.equal( '0px' );
  915. expect( container.style.left ).to.equal( '-9999px' );
  916. } );
  917. it( 'should bind fake selection container to view selection', () => {
  918. selection.setFake( true, { label: 'fake selection' } );
  919. renderer.render();
  920. expect( domRoot.childNodes.length ).to.equal( 2 );
  921. const container = domRoot.childNodes[ 1 ];
  922. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  923. expect( bindSelection ).to.be.defined;
  924. expect( bindSelection.isEqual( selection ) ).to.be.true;
  925. } );
  926. } );
  927. } );
  928. } );
  929. function renderAndExpectNoChanges( renderer, domRoot ) {
  930. const config = {
  931. childList: true,
  932. characterData: true,
  933. characterDataOldValue: true,
  934. subtree: true
  935. };
  936. const mutationObserver = new window.MutationObserver( () => {
  937. throw 'There should be not mutations';
  938. } );
  939. mutationObserver.observe( domRoot, config );
  940. renderer.render();
  941. const records = mutationObserver.takeRecords();
  942. mutationObserver.disconnect();
  943. expect( records.length ).to.equal( 0 );
  944. }