undoengine-integration.js 27 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844
  1. /**
  2. * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. import VirtualTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/virtualtesteditor';
  6. import Range from '@ckeditor/ckeditor5-engine/src/model/range';
  7. import Position from '@ckeditor/ckeditor5-engine/src/model/position';
  8. import UndoEngine from '../src/undoengine';
  9. import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
  10. import HeadingEngine from '@ckeditor/ckeditor5-heading/src/headingengine';
  11. import Typing from '@ckeditor/ckeditor5-typing/src/typing';
  12. import Enter from '@ckeditor/ckeditor5-enter/src/enter';
  13. import Clipboard from '@ckeditor/ckeditor5-clipboard/src/clipboard';
  14. import BoldEngine from '@ckeditor/ckeditor5-basic-styles/src/boldengine';
  15. import buildModelConverter from '@ckeditor/ckeditor5-engine/src/conversion/buildmodelconverter';
  16. import buildViewConverter from '@ckeditor/ckeditor5-engine/src/conversion/buildviewconverter';
  17. import { setData, getData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
  18. describe( 'UndoEngine integration', () => {
  19. let editor, doc, root;
  20. beforeEach( () => {
  21. return VirtualTestEditor.create( { plugins: [ Paragraph, HeadingEngine, Typing, Enter, Clipboard, BoldEngine, UndoEngine ] } )
  22. .then( newEditor => {
  23. editor = newEditor;
  24. doc = editor.document;
  25. // Add "div feature".
  26. doc.schema.registerItem( 'div', '$block' );
  27. buildModelConverter().for( editor.data.modelToView, editor.editing.modelToView ).fromElement( 'div' ).toElement( 'div' );
  28. buildViewConverter().for( editor.data.viewToModel ).fromElement( 'div' ).toElement( 'div' );
  29. root = doc.getRoot();
  30. } );
  31. } );
  32. function setSelection( pathA, pathB ) {
  33. doc.selection.setRanges( [ new Range( new Position( root, pathA ), new Position( root, pathB ) ) ] );
  34. }
  35. function input( input ) {
  36. setData( doc, input );
  37. }
  38. function output( output ) {
  39. expect( getData( doc ) ).to.equal( output );
  40. }
  41. function undoDisabled() {
  42. expect( editor.commands.get( 'undo' ).isEnabled ).to.be.false;
  43. }
  44. function redoDisabled() {
  45. expect( editor.commands.get( 'redo' ).isEnabled ).to.be.false;
  46. }
  47. describe( 'adding and removing content', () => {
  48. it( 'add and undo', () => {
  49. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  50. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  51. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  52. editor.execute( 'undo' );
  53. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  54. undoDisabled();
  55. } );
  56. it( 'multiple adding and undo', () => {
  57. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  58. doc.batch()
  59. .insert( doc.selection.getFirstPosition(), 'zzz' )
  60. .insert( new Position( root, [ 1, 0 ] ), 'xxx' );
  61. output( '<paragraph>fozzz[]o</paragraph><paragraph>xxxbar</paragraph>' );
  62. setSelection( [ 1, 0 ], [ 1, 0 ] );
  63. doc.batch().insert( doc.selection.getFirstPosition(), 'yyy' );
  64. output( '<paragraph>fozzzo</paragraph><paragraph>yyy[]xxxbar</paragraph>' );
  65. editor.execute( 'undo' );
  66. output( '<paragraph>fozzzo</paragraph><paragraph>[]xxxbar</paragraph>' );
  67. editor.execute( 'undo' );
  68. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  69. undoDisabled();
  70. } );
  71. it( 'multiple adding mixed with undo', () => {
  72. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  73. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  74. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  75. setSelection( [ 1, 0 ], [ 1, 0 ] );
  76. doc.batch().insert( doc.selection.getFirstPosition(), 'yyy' );
  77. output( '<paragraph>fozzzo</paragraph><paragraph>yyy[]bar</paragraph>' );
  78. editor.execute( 'undo' );
  79. output( '<paragraph>fozzzo</paragraph><paragraph>[]bar</paragraph>' );
  80. setSelection( [ 0, 0 ], [ 0, 0 ] );
  81. doc.batch().insert( doc.selection.getFirstPosition(), 'xxx' );
  82. output( '<paragraph>xxx[]fozzzo</paragraph><paragraph>bar</paragraph>' );
  83. editor.execute( 'undo' );
  84. output( '<paragraph>[]fozzzo</paragraph><paragraph>bar</paragraph>' );
  85. editor.execute( 'undo' );
  86. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  87. undoDisabled();
  88. } );
  89. it( 'multiple remove and undo', () => {
  90. input( '<paragraph>[]foo</paragraph><paragraph>bar</paragraph>' );
  91. doc.batch().remove( Range.createFromPositionAndShift( doc.selection.getFirstPosition(), 2 ) );
  92. output( '<paragraph>[]o</paragraph><paragraph>bar</paragraph>' );
  93. setSelection( [ 1, 1 ], [ 1, 1 ] );
  94. doc.batch().remove( Range.createFromPositionAndShift( doc.selection.getFirstPosition(), 2 ) );
  95. output( '<paragraph>o</paragraph><paragraph>b[]</paragraph>' );
  96. editor.execute( 'undo' );
  97. // Here is an edge case that selection could be before or after `ar`.
  98. output( '<paragraph>o</paragraph><paragraph>bar[]</paragraph>' );
  99. editor.execute( 'undo' );
  100. // As above.
  101. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  102. undoDisabled();
  103. } );
  104. it( 'add and remove different parts and undo', () => {
  105. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  106. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  107. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  108. setSelection( [ 1, 2 ], [ 1, 2 ] );
  109. doc.batch().remove( Range.createFromPositionAndShift( new Position( root, [ 1, 1 ] ), 1 ) );
  110. output( '<paragraph>fozzzo</paragraph><paragraph>b[]r</paragraph>' );
  111. editor.execute( 'undo' );
  112. output( '<paragraph>fozzzo</paragraph><paragraph>ba[]r</paragraph>' );
  113. editor.execute( 'undo' );
  114. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  115. undoDisabled();
  116. } );
  117. it( 'add and remove same part and undo', () => {
  118. input( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  119. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  120. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  121. doc.batch().remove( Range.createFromPositionAndShift( new Position( root, [ 0, 2 ] ), 3 ) );
  122. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  123. editor.execute( 'undo' );
  124. output( '<paragraph>fozzz[]o</paragraph><paragraph>bar</paragraph>' );
  125. editor.execute( 'undo' );
  126. output( '<paragraph>fo[]o</paragraph><paragraph>bar</paragraph>' );
  127. undoDisabled();
  128. } );
  129. } );
  130. describe( 'moving', () => {
  131. it( 'move same content twice then undo', () => {
  132. input( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  133. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 1, 0 ] ) );
  134. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  135. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0, 2 ] ) );
  136. output( '<paragraph>fz[o]</paragraph><paragraph>bar</paragraph>' );
  137. editor.execute( 'undo' );
  138. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  139. editor.execute( 'undo' );
  140. output( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  141. undoDisabled();
  142. } );
  143. it( 'move content and new parent then undo', () => {
  144. input( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  145. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 1, 0 ] ) );
  146. output( '<paragraph>fz</paragraph><paragraph>[o]bar</paragraph>' );
  147. setSelection( [ 1 ], [ 2 ] );
  148. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0 ] ) );
  149. output( '[<paragraph>obar</paragraph>]<paragraph>fz</paragraph>' );
  150. editor.execute( 'undo' );
  151. output( '<paragraph>fz</paragraph>[<paragraph>obar</paragraph>]' );
  152. editor.execute( 'undo' );
  153. output( '<paragraph>f[o]z</paragraph><paragraph>bar</paragraph>' );
  154. undoDisabled();
  155. } );
  156. } );
  157. describe( 'attributes with other', () => {
  158. it( 'attributes then insert inside then undo', () => {
  159. input( '<paragraph>fo[ob]ar</paragraph>' );
  160. doc.batch().setAttribute( doc.selection.getFirstRange(), 'bold', true );
  161. output( '<paragraph>fo[<$text bold="true">ob</$text>]ar</paragraph>' );
  162. setSelection( [ 0, 3 ], [ 0, 3 ] );
  163. doc.batch().insert( doc.selection.getFirstPosition(), 'zzz' );
  164. output( '<paragraph>fo<$text bold="true">o</$text>zzz<$text bold="true">[]b</$text>ar</paragraph>' );
  165. expect( doc.selection.getAttribute( 'bold' ) ).to.true;
  166. editor.execute( 'undo' );
  167. output( '<paragraph>fo<$text bold="true">o[]b</$text>ar</paragraph>' );
  168. expect( doc.selection.getAttribute( 'bold' ) ).to.true;
  169. editor.execute( 'undo' );
  170. output( '<paragraph>fo[ob]ar</paragraph>' );
  171. undoDisabled();
  172. } );
  173. } );
  174. describe( 'wrapping, unwrapping, merging, splitting', () => {
  175. it( 'wrap and undo', () => {
  176. doc.schema.allow( { name: '$text', inside: '$root' } );
  177. input( 'fo[zb]ar' );
  178. doc.batch().wrap( doc.selection.getFirstRange(), 'paragraph' );
  179. output( 'fo<paragraph>[zb]</paragraph>ar' );
  180. editor.execute( 'undo' );
  181. output( 'fo[zb]ar' );
  182. undoDisabled();
  183. } );
  184. it( 'wrap, move and undo', () => {
  185. doc.schema.allow( { name: '$text', inside: '$root' } );
  186. input( 'fo[zb]ar' );
  187. doc.batch().wrap( doc.selection.getFirstRange(), 'paragraph' );
  188. // Would be better if selection was inside P.
  189. output( 'fo<paragraph>[zb]</paragraph>ar' );
  190. setSelection( [ 2, 0 ], [ 2, 1 ] );
  191. doc.batch().move( doc.selection.getFirstRange(), new Position( root, [ 0 ] ) );
  192. output( '[z]fo<paragraph>b</paragraph>ar' );
  193. editor.execute( 'undo' );
  194. output( 'fo<paragraph>[z]b</paragraph>ar' );
  195. editor.execute( 'undo' );
  196. output( 'fo[zb]ar' );
  197. undoDisabled();
  198. } );
  199. it( 'unwrap and undo', () => {
  200. input( '<paragraph>foo[]bar</paragraph>' );
  201. doc.batch().unwrap( doc.selection.getFirstPosition().parent );
  202. output( 'foo[]bar' );
  203. editor.execute( 'undo' );
  204. output( '<paragraph>foo[]bar</paragraph>' );
  205. undoDisabled();
  206. } );
  207. it( 'merge and undo', () => {
  208. input( '<paragraph>foo</paragraph><paragraph>[]bar</paragraph>' );
  209. doc.batch().merge( new Position( root, [ 1 ] ) );
  210. // Because selection is stuck with <paragraph> it ends up in graveyard. We have to manually move it to correct node.
  211. setSelection( [ 0, 3 ], [ 0, 3 ] );
  212. output( '<paragraph>foo[]bar</paragraph>' );
  213. editor.execute( 'undo' );
  214. output( '<paragraph>foo</paragraph><paragraph>bar[]</paragraph>' );
  215. undoDisabled();
  216. } );
  217. it( 'split and undo', () => {
  218. input( '<paragraph>foo[]bar</paragraph>' );
  219. doc.batch().split( doc.selection.getFirstPosition() );
  220. // Because selection is stuck with <paragraph> it ends up in wrong node. We have to manually move it to correct node.
  221. setSelection( [ 1, 0 ], [ 1, 0 ] );
  222. output( '<paragraph>foo</paragraph><paragraph>[]bar</paragraph>' );
  223. editor.execute( 'undo' );
  224. output( '<paragraph>foobar[]</paragraph>' );
  225. undoDisabled();
  226. } );
  227. } );
  228. // Restoring selection in those examples may be completely off.
  229. describe( 'multiple enters, deletes and typing', () => {
  230. function split( path ) {
  231. setSelection( path.slice(), path.slice() );
  232. editor.execute( 'enter' );
  233. }
  234. function merge( path ) {
  235. const selPath = path.slice();
  236. selPath.push( 0 );
  237. setSelection( selPath, selPath.slice() );
  238. editor.execute( 'delete' );
  239. }
  240. function type( path, text ) {
  241. setSelection( path.slice(), path.slice() );
  242. editor.execute( 'input', { text } );
  243. }
  244. function remove( path ) {
  245. setSelection( path.slice(), path.slice() );
  246. editor.execute( 'delete' );
  247. }
  248. it( 'split, split, split', () => {
  249. input( '<paragraph>12345678</paragraph>' );
  250. split( [ 0, 3 ] );
  251. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  252. split( [ 1, 4 ] );
  253. output( '<paragraph>123</paragraph><paragraph>4567</paragraph><paragraph>[]8</paragraph>' );
  254. split( [ 1, 2 ] );
  255. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67</paragraph><paragraph>8</paragraph>' );
  256. editor.execute( 'undo' );
  257. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  258. editor.execute( 'undo' );
  259. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  260. editor.execute( 'undo' );
  261. output( '<paragraph>12345678[]</paragraph>' );
  262. undoDisabled();
  263. editor.execute( 'redo' );
  264. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  265. editor.execute( 'redo' );
  266. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  267. editor.execute( 'redo' );
  268. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  269. redoDisabled();
  270. } );
  271. it( 'merge, merge, merge', () => {
  272. input( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  273. merge( [ 1 ] );
  274. output( '<paragraph>123[]45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  275. merge( [ 2 ] );
  276. output( '<paragraph>12345</paragraph><paragraph>67[]8</paragraph>' );
  277. merge( [ 1 ] );
  278. output( '<paragraph>12345[]678</paragraph>' );
  279. editor.execute( 'undo' );
  280. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  281. editor.execute( 'undo' );
  282. output( '<paragraph>12345</paragraph><paragraph>67</paragraph><paragraph>8[]</paragraph>' );
  283. editor.execute( 'undo' );
  284. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  285. undoDisabled();
  286. editor.execute( 'redo' );
  287. output( '<paragraph>12345[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  288. editor.execute( 'redo' );
  289. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  290. editor.execute( 'redo' );
  291. output( '<paragraph>12345678[]</paragraph>' );
  292. redoDisabled();
  293. } );
  294. it( 'split, merge, split, merge (same position)', () => {
  295. input( '<paragraph>12345678</paragraph>' );
  296. split( [ 0, 3 ] );
  297. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  298. merge( [ 1 ] );
  299. output( '<paragraph>123[]45678</paragraph>' );
  300. split( [ 0, 3 ] );
  301. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  302. merge( [ 1 ] );
  303. output( '<paragraph>123[]45678</paragraph>' );
  304. editor.execute( 'undo' );
  305. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  306. editor.execute( 'undo' );
  307. output( '<paragraph>12345678[]</paragraph>' );
  308. editor.execute( 'undo' );
  309. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  310. editor.execute( 'undo' );
  311. output( '<paragraph>12345678[]</paragraph>' );
  312. undoDisabled();
  313. editor.execute( 'redo' );
  314. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  315. editor.execute( 'redo' );
  316. output( '<paragraph>12345678[]</paragraph>' );
  317. editor.execute( 'redo' );
  318. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  319. editor.execute( 'redo' );
  320. output( '<paragraph>12345678[]</paragraph>' );
  321. redoDisabled();
  322. } );
  323. it( 'split, split, split, merge, merge, merge', () => {
  324. input( '<paragraph>12345678</paragraph>' );
  325. split( [ 0, 3 ] );
  326. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  327. split( [ 1, 4 ] );
  328. output( '<paragraph>123</paragraph><paragraph>4567</paragraph><paragraph>[]8</paragraph>' );
  329. split( [ 1, 2 ] );
  330. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67</paragraph><paragraph>8</paragraph>' );
  331. merge( [ 1 ] );
  332. output( '<paragraph>123[]45</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  333. merge( [ 2 ] );
  334. output( '<paragraph>12345</paragraph><paragraph>67[]8</paragraph>' );
  335. merge( [ 1 ] );
  336. output( '<paragraph>12345[]678</paragraph>' );
  337. editor.execute( 'undo' );
  338. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  339. editor.execute( 'undo' );
  340. output( '<paragraph>12345</paragraph><paragraph>67</paragraph><paragraph>8[]</paragraph>' );
  341. editor.execute( 'undo' );
  342. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  343. editor.execute( 'undo' );
  344. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  345. editor.execute( 'undo' );
  346. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  347. editor.execute( 'undo' );
  348. output( '<paragraph>12345678[]</paragraph>' );
  349. undoDisabled();
  350. editor.execute( 'redo' );
  351. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  352. editor.execute( 'redo' );
  353. output( '<paragraph>123</paragraph><paragraph>4567[]</paragraph><paragraph>8</paragraph>' );
  354. editor.execute( 'redo' );
  355. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  356. editor.execute( 'redo' );
  357. output( '<paragraph>12345[]</paragraph><paragraph>67</paragraph><paragraph>8</paragraph>' );
  358. editor.execute( 'redo' );
  359. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  360. editor.execute( 'redo' );
  361. output( '<paragraph>12345678[]</paragraph>' );
  362. redoDisabled();
  363. } );
  364. it( 'split, split, merge, split, merge (different order)', () => {
  365. input( '<paragraph>12345678</paragraph>' );
  366. split( [ 0, 3 ] );
  367. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  368. split( [ 1, 2 ] );
  369. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]678</paragraph>' );
  370. merge( [ 1 ] );
  371. output( '<paragraph>123[]45</paragraph><paragraph>678</paragraph>' );
  372. split( [ 1, 1 ] );
  373. output( '<paragraph>12345</paragraph><paragraph>6</paragraph><paragraph>[]78</paragraph>' );
  374. merge( [ 1 ] );
  375. output( '<paragraph>12345[]6</paragraph><paragraph>78</paragraph>' );
  376. editor.execute( 'undo' );
  377. output( '<paragraph>12345</paragraph><paragraph>6[]</paragraph><paragraph>78</paragraph>' );
  378. editor.execute( 'undo' );
  379. output( '<paragraph>12345</paragraph><paragraph>678[]</paragraph>' );
  380. editor.execute( 'undo' );
  381. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>678</paragraph>' );
  382. editor.execute( 'undo' );
  383. output( '<paragraph>123</paragraph><paragraph>45678[]</paragraph>' );
  384. editor.execute( 'undo' );
  385. output( '<paragraph>12345678[]</paragraph>' );
  386. undoDisabled();
  387. editor.execute( 'redo' );
  388. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  389. editor.execute( 'redo' );
  390. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>678</paragraph>' );
  391. editor.execute( 'redo' );
  392. output( '<paragraph>12345[]</paragraph><paragraph>678</paragraph>' );
  393. editor.execute( 'redo' );
  394. output( '<paragraph>12345</paragraph><paragraph>6[]</paragraph><paragraph>78</paragraph>' );
  395. editor.execute( 'redo' );
  396. output( '<paragraph>123456[]</paragraph><paragraph>78</paragraph>' );
  397. redoDisabled();
  398. } );
  399. it( 'split, remove, split, merge, merge', () => {
  400. input( '<paragraph>12345678</paragraph>' );
  401. split( [ 0, 3 ] );
  402. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  403. remove( [ 1, 4 ] );
  404. remove( [ 1, 3 ] );
  405. output( '<paragraph>123</paragraph><paragraph>45[]8</paragraph>' );
  406. split( [ 1, 1 ] );
  407. output( '<paragraph>123</paragraph><paragraph>4</paragraph><paragraph>[]58</paragraph>' );
  408. merge( [ 1 ] );
  409. output( '<paragraph>123[]4</paragraph><paragraph>58</paragraph>' );
  410. merge( [ 1 ] );
  411. output( '<paragraph>1234[]58</paragraph>' );
  412. editor.execute( 'undo' );
  413. output( '<paragraph>1234</paragraph><paragraph>58[]</paragraph>' );
  414. editor.execute( 'undo' );
  415. output( '<paragraph>123</paragraph><paragraph>4[]</paragraph><paragraph>58</paragraph>' );
  416. editor.execute( 'undo' );
  417. output( '<paragraph>123</paragraph><paragraph>458[]</paragraph>' );
  418. editor.execute( 'undo' );
  419. output( '<paragraph>123</paragraph><paragraph>4567[]8</paragraph>' );
  420. editor.execute( 'undo' );
  421. output( '<paragraph>12345678[]</paragraph>' );
  422. undoDisabled();
  423. editor.execute( 'redo' );
  424. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  425. editor.execute( 'redo' );
  426. output( '<paragraph>123</paragraph><paragraph>458[]</paragraph>' );
  427. editor.execute( 'redo' );
  428. output( '<paragraph>123</paragraph><paragraph>4[]</paragraph><paragraph>58</paragraph>' );
  429. editor.execute( 'redo' );
  430. output( '<paragraph>1234[]</paragraph><paragraph>58</paragraph>' );
  431. editor.execute( 'redo' );
  432. output( '<paragraph>123458[]</paragraph>' );
  433. redoDisabled();
  434. } );
  435. it( 'split, typing, split, merge, merge', () => {
  436. input( '<paragraph>12345678</paragraph>' );
  437. split( [ 0, 3 ] );
  438. output( '<paragraph>123</paragraph><paragraph>[]45678</paragraph>' );
  439. type( [ 1, 4 ], 'x' );
  440. type( [ 1, 5 ], 'y' );
  441. output( '<paragraph>123</paragraph><paragraph>4567xy[]8</paragraph>' );
  442. split( [ 1, 2 ] );
  443. output( '<paragraph>123</paragraph><paragraph>45</paragraph><paragraph>[]67xy8</paragraph>' );
  444. merge( [ 1 ] );
  445. output( '<paragraph>123[]45</paragraph><paragraph>67xy8</paragraph>' );
  446. merge( [ 1 ] );
  447. output( '<paragraph>12345[]67xy8</paragraph>' );
  448. editor.execute( 'undo' );
  449. output( '<paragraph>12345</paragraph><paragraph>67xy8[]</paragraph>' );
  450. editor.execute( 'undo' );
  451. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67xy8</paragraph>' );
  452. editor.execute( 'undo' );
  453. output( '<paragraph>123</paragraph><paragraph>4567xy8[]</paragraph>' );
  454. editor.execute( 'undo' );
  455. output( '<paragraph>123</paragraph><paragraph>4567[]8</paragraph>' );
  456. editor.execute( 'undo' );
  457. output( '<paragraph>12345678[]</paragraph>' );
  458. undoDisabled();
  459. editor.execute( 'redo' );
  460. output( '<paragraph>123[]</paragraph><paragraph>45678</paragraph>' );
  461. editor.execute( 'redo' );
  462. output( '<paragraph>123</paragraph><paragraph>4567xy8[]</paragraph>' );
  463. editor.execute( 'redo' );
  464. output( '<paragraph>123</paragraph><paragraph>45[]</paragraph><paragraph>67xy8</paragraph>' );
  465. editor.execute( 'redo' );
  466. output( '<paragraph>12345[]</paragraph><paragraph>67xy8</paragraph>' );
  467. editor.execute( 'redo' );
  468. output( '<paragraph>1234567xy8[]</paragraph>' );
  469. redoDisabled();
  470. } );
  471. } );
  472. describe( 'other reported cases', () => {
  473. // ckeditor5-engine#t/1051
  474. it( 'rename leaks to other elements on undo #1', () => {
  475. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  476. doc.batch().rename( root.getChild( 0 ), 'paragraph' );
  477. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  478. doc.batch().split( Position.createAt( root.getChild( 0 ), 1 ) );
  479. output( '<paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph>' );
  480. doc.batch().merge( Position.createAt( root, 2 ) );
  481. output( '<paragraph>[]F</paragraph><paragraph>ooBar</paragraph>' );
  482. editor.execute( 'undo' );
  483. output( '<paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph>' );
  484. editor.execute( 'undo' );
  485. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  486. editor.execute( 'undo' );
  487. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  488. } );
  489. // Similar issue that bases on the same error as above, however here we first merge (above we first split).
  490. it( 'rename leaks to other elements on undo #2', () => {
  491. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  492. doc.batch().rename( root.getChild( 0 ), 'heading2' );
  493. output( '<heading2>[]Foo</heading2><paragraph>Bar</paragraph>' );
  494. doc.batch().merge( Position.createAt( root, 1 ) );
  495. output( '<heading2>[]FooBar</heading2>' );
  496. editor.execute( 'undo' );
  497. output( '<heading2>[]Foo</heading2><paragraph>Bar</paragraph>' );
  498. editor.execute( 'undo' );
  499. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  500. } );
  501. // Reverse issue, this time first operation is merge and then rename.
  502. it( 'merge, rename, undo, undo is correct', () => {
  503. input( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  504. doc.batch().merge( Position.createAt( root, 1 ) );
  505. output( '<heading1>[]FooBar</heading1>' );
  506. doc.batch().rename( root.getChild( 0 ), 'heading2' );
  507. output( '<heading2>[]FooBar</heading2>' );
  508. editor.execute( 'undo' );
  509. output( '<heading1>[]FooBar</heading1>' );
  510. editor.execute( 'undo' );
  511. output( '<heading1>[]Foo</heading1><paragraph>Bar</paragraph>' );
  512. } );
  513. // ckeditor5-engine#t/1053
  514. it( 'wrap, split, undo, undo is correct', () => {
  515. input( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  516. doc.batch().wrap( Range.createIn( root ), 'div' );
  517. output( '<div><paragraph>[]Foo</paragraph><paragraph>Bar</paragraph></div>' );
  518. doc.batch().split( new Position( root, [ 0, 0, 1 ] ) );
  519. output( '<div><paragraph>[]F</paragraph><paragraph>oo</paragraph><paragraph>Bar</paragraph></div>' );
  520. editor.execute( 'undo' );
  521. output( '<div><paragraph>[]Foo</paragraph><paragraph>Bar</paragraph></div>' );
  522. editor.execute( 'undo' );
  523. output( '<paragraph>[]Foo</paragraph><paragraph>Bar</paragraph>' );
  524. } );
  525. // ckeditor5-engine#t/1055
  526. it( 'selection attribute setting: split, bold, merge, undo, undo, undo', () => {
  527. input( '<p>Foo[]</p><p>Bar</p>' );
  528. editor.execute( 'enter' );
  529. output( '<p>Foo</p><p>[]</p><p>Bar</p>' );
  530. editor.execute( 'bold' );
  531. output( '<p>Foo</p><p selection:bold="true"><$text bold="true">[]</$text></p><p>Bar</p>' );
  532. editor.execute( 'forwardDelete' );
  533. output( '<p>Foo</p><p>[]Bar</p>' );
  534. editor.execute( 'undo' );
  535. output( '<p>Foo</p><p selection:bold="true"><$text bold="true">[]</$text></p><p>Bar</p>' );
  536. editor.execute( 'undo' );
  537. output( '<p>Foo</p><p>[]</p><p>Bar</p>' );
  538. editor.execute( 'undo' );
  539. output( '<p>Foo[]</p><p>Bar</p>' );
  540. } );
  541. } );
  542. describe( 'pasting', () => {
  543. function pasteHtml( editor, html ) {
  544. editor.editing.view.fire( 'paste', {
  545. dataTransfer: createDataTransfer( { 'text/html': html } ),
  546. preventDefault() {}
  547. } );
  548. }
  549. function createDataTransfer( data ) {
  550. return {
  551. getData( type ) {
  552. return data[ type ];
  553. }
  554. };
  555. }
  556. // ckeditor5-engine#t/1065
  557. it( 'undo paste into non empty element should not throw and be correct', () => {
  558. input( '<paragraph>Foo[]</paragraph>' );
  559. pasteHtml( editor, '<p>a</p><p>b</p>' );
  560. output( '<paragraph>Fooa</paragraph><paragraph>b[]</paragraph>' );
  561. pasteHtml( editor, '<p>c</p><p>d</p>' );
  562. output( '<paragraph>Fooa</paragraph><paragraph>bc</paragraph><paragraph>d[]</paragraph>' );
  563. editor.execute( 'undo' );
  564. output( '<paragraph>Fooa</paragraph><paragraph>b[]</paragraph>' );
  565. editor.execute( 'undo' );
  566. output( '<paragraph>Foo[]</paragraph>' );
  567. } );
  568. } );
  569. describe( 'other edge cases', () => {
  570. it( 'deleteContent between two nodes', () => {
  571. input( '<paragraph>fo[o</paragraph><paragraph>b]ar</paragraph>' );
  572. editor.data.deleteContent( doc.selection, doc.batch() );
  573. output( '<paragraph>fo[]ar</paragraph>' );
  574. editor.execute( 'undo' );
  575. output( '<paragraph>fo[o</paragraph><paragraph>b]ar</paragraph>' );
  576. } );
  577. // Related to ckeditor5-engine#891 and ckeditor5-list#51.
  578. it( 'change attribute of removed node then undo and redo', () => {
  579. input( '<paragraph></paragraph>' );
  580. const gy = doc.graveyard;
  581. const p = doc.getRoot().getChild( 0 );
  582. doc.enqueueChanges( () => {
  583. doc.batch().remove( p );
  584. doc.batch().setAttribute( p, 'bold', true );
  585. } );
  586. editor.execute( 'undo' );
  587. editor.execute( 'redo' );
  588. expect( p.root ).to.equal( gy );
  589. expect( p.getAttribute( 'bold' ) ).to.be.true;
  590. } );
  591. } );
  592. } );