renderer.js 72 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047
  1. /**
  2. * @license Copyright (c) 2003-2018, CKSource - Frederico Knabben. All rights reserved.
  3. * For licensing, see LICENSE.md.
  4. */
  5. /* globals document, window, NodeFilter */
  6. import View from '../../src/view/view';
  7. import ViewElement from '../../src/view/element';
  8. import ViewContainerElement from '../../src/view/containerelement';
  9. import ViewAttributeElement from '../../src/view/attributeelement';
  10. import ViewText from '../../src/view/text';
  11. import ViewRange from '../../src/view/range';
  12. import ViewPosition from '../../src/view/position';
  13. import Selection from '../../src/view/selection';
  14. import DomConverter from '../../src/view/domconverter';
  15. import Renderer from '../../src/view/renderer';
  16. import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
  17. import { parse, setData as setViewData, getData as getViewData } from '../../src/dev-utils/view';
  18. import { INLINE_FILLER, INLINE_FILLER_LENGTH, isBlockFiller, BR_FILLER } from '../../src/view/filler';
  19. import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
  20. import createViewRoot from './_utils/createroot';
  21. import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
  22. import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
  23. testUtils.createSinonSandbox();
  24. describe( 'Renderer', () => {
  25. let selection, domConverter, renderer;
  26. beforeEach( () => {
  27. selection = new Selection();
  28. domConverter = new DomConverter();
  29. renderer = new Renderer( domConverter, selection );
  30. renderer.domDocuments.add( document );
  31. } );
  32. describe( 'markToSync', () => {
  33. let viewRoot;
  34. beforeEach( () => {
  35. viewRoot = new ViewElement( 'p' );
  36. const domRoot = document.createElement( 'p' );
  37. domConverter.bindElements( domRoot, viewRoot );
  38. viewRoot.appendChildren( new ViewText( 'foo' ) );
  39. renderer.markedTexts.clear();
  40. renderer.markedAttributes.clear();
  41. renderer.markedChildren.clear();
  42. } );
  43. it( 'should mark attributes which need update', () => {
  44. viewRoot._setAttribute( 'class', 'foo' );
  45. renderer.markToSync( 'attributes', viewRoot );
  46. expect( renderer.markedAttributes.has( viewRoot ) ).to.be.true;
  47. } );
  48. it( 'should mark children which need update', () => {
  49. viewRoot.appendChildren( new ViewText( 'foo' ) );
  50. renderer.markToSync( 'children', viewRoot );
  51. expect( renderer.markedChildren.has( viewRoot ) ).to.be.true;
  52. } );
  53. it( 'should not mark children if element has no corresponding node', () => {
  54. // Overwrite viewRoot with node without coresponding DOM node.
  55. viewRoot = new ViewElement( 'p' );
  56. viewRoot.appendChildren( new ViewText( 'foo' ) );
  57. renderer.markToSync( 'children', viewRoot );
  58. expect( renderer.markedTexts.has( viewRoot ) ).to.be.false;
  59. } );
  60. it( 'should mark text which need update', () => {
  61. const viewText = new ViewText( 'foo' );
  62. viewRoot.appendChildren( viewText );
  63. viewText.data = 'bar';
  64. renderer.markToSync( 'text', viewText );
  65. expect( renderer.markedTexts.has( viewText ) ).to.be.true;
  66. } );
  67. it( 'should not mark text if parent has no corresponding node', () => {
  68. const viewText = new ViewText( 'foo' );
  69. // Overwrite viewRoot with node without coresponding DOM node.
  70. viewRoot = new ViewElement( 'p' );
  71. viewRoot.appendChildren( viewText );
  72. viewText.data = 'bar';
  73. renderer.markToSync( 'text', viewText );
  74. expect( renderer.markedTexts.has( viewText ) ).to.be.false;
  75. } );
  76. it( 'should throw if the type is unknown', () => {
  77. expect( () => {
  78. renderer.markToSync( 'UNKNOWN', viewRoot );
  79. } ).to.throw( CKEditorError, /^view-renderer-unknown-type/ );
  80. } );
  81. } );
  82. describe( 'render', () => {
  83. let viewRoot, domRoot, selectionEditable;
  84. beforeEach( () => {
  85. viewRoot = new ViewElement( 'div' );
  86. domRoot = document.createElement( 'div' );
  87. document.body.appendChild( domRoot );
  88. domConverter.bindElements( domRoot, viewRoot );
  89. renderer.markedTexts.clear();
  90. renderer.markedAttributes.clear();
  91. renderer.markedChildren.clear();
  92. selection._setTo( null );
  93. selection._setFake( false );
  94. selectionEditable = viewRoot;
  95. renderer.isFocused = true;
  96. // Fake selection editable - it is needed to render selection properly.
  97. Object.defineProperty( selection, 'editableElement', {
  98. get() {
  99. return selectionEditable;
  100. }
  101. } );
  102. } );
  103. afterEach( () => {
  104. domRoot.remove();
  105. } );
  106. it( 'should update attributes', () => {
  107. viewRoot._setAttribute( 'class', 'foo' );
  108. renderer.markToSync( 'attributes', viewRoot );
  109. renderer.render();
  110. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  111. expect( renderer.markedAttributes.size ).to.equal( 0 );
  112. } );
  113. it( 'should remove attributes', () => {
  114. viewRoot._setAttribute( 'class', 'foo' );
  115. domRoot.setAttribute( 'id', 'bar' );
  116. domRoot.setAttribute( 'class', 'bar' );
  117. renderer.markToSync( 'attributes', viewRoot );
  118. renderer.render();
  119. expect( domRoot.getAttribute( 'class' ) ).to.equal( 'foo' );
  120. expect( domRoot.getAttribute( 'id' ) ).to.be.not.ok;
  121. expect( renderer.markedAttributes.size ).to.equal( 0 );
  122. } );
  123. it( 'should add children', () => {
  124. viewRoot.appendChildren( new ViewText( 'foo' ) );
  125. renderer.markToSync( 'children', viewRoot );
  126. renderer.render();
  127. expect( domRoot.childNodes.length ).to.equal( 1 );
  128. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  129. expect( renderer.markedChildren.size ).to.equal( 0 );
  130. } );
  131. it( 'should remove children', () => {
  132. viewRoot.appendChildren( new ViewText( 'foo' ) );
  133. renderer.markToSync( 'children', viewRoot );
  134. renderer.render();
  135. expect( domRoot.childNodes.length ).to.equal( 1 );
  136. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  137. viewRoot.removeChildren( 0, 1 );
  138. renderer.markToSync( 'children', viewRoot );
  139. renderer.render();
  140. expect( domRoot.childNodes.length ).to.equal( 0 );
  141. expect( renderer.markedChildren.size ).to.equal( 0 );
  142. } );
  143. it( 'should update text', () => {
  144. const viewText = new ViewText( 'foo' );
  145. viewRoot.appendChildren( viewText );
  146. renderer.markToSync( 'children', viewRoot );
  147. renderer.render();
  148. expect( domRoot.childNodes.length ).to.equal( 1 );
  149. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'foo' );
  150. viewText.data = 'bar';
  151. renderer.markToSync( 'text', viewText );
  152. renderer.render();
  153. expect( domRoot.childNodes.length ).to.equal( 1 );
  154. expect( domRoot.childNodes[ 0 ].data ).to.equal( 'bar' );
  155. expect( renderer.markedTexts.size ).to.equal( 0 );
  156. } );
  157. it( 'should not update text parent child list changed', () => {
  158. const viewImg = new ViewElement( 'img' );
  159. const viewText = new ViewText( 'foo' );
  160. viewRoot.appendChildren( [ viewImg, viewText ] );
  161. renderer.markToSync( 'children', viewRoot );
  162. renderer.markToSync( 'text', viewText );
  163. renderer.render();
  164. expect( domRoot.childNodes.length ).to.equal( 2 );
  165. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'IMG' );
  166. expect( domRoot.childNodes[ 1 ].data ).to.equal( 'foo' );
  167. } );
  168. it( 'should not change text if it is the same during text rendering', () => {
  169. const viewText = new ViewText( 'foo' );
  170. viewRoot.appendChildren( viewText );
  171. renderer.markToSync( 'children', viewRoot );
  172. renderer.render();
  173. // This should not be changed during the render.
  174. const domText = domRoot.childNodes[ 0 ];
  175. renderer.markToSync( 'text', viewText );
  176. renderer.render();
  177. expect( domRoot.childNodes.length ).to.equal( 1 );
  178. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  179. } );
  180. it( 'should not change text if it is the same during children rendering', () => {
  181. const viewText = new ViewText( 'foo' );
  182. viewRoot.appendChildren( viewText );
  183. renderer.markToSync( 'children', viewRoot );
  184. renderer.render();
  185. // This should not be changed during the render.
  186. const domText = domRoot.childNodes[ 0 ];
  187. renderer.markToSync( 'children', viewRoot );
  188. renderer.render();
  189. expect( domRoot.childNodes.length ).to.equal( 1 );
  190. expect( domRoot.childNodes[ 0 ] ).to.equal( domText );
  191. } );
  192. it( 'should not change element if it is the same', () => {
  193. const viewImg = new ViewElement( 'img' );
  194. viewRoot.appendChildren( viewImg );
  195. // This should not be changed during the render.
  196. const domImg = document.createElement( 'img' );
  197. domRoot.appendChild( domImg );
  198. domConverter.bindElements( domImg, viewImg );
  199. renderer.markToSync( 'children', viewRoot );
  200. renderer.render();
  201. expect( domRoot.childNodes.length ).to.equal( 1 );
  202. expect( domRoot.childNodes[ 0 ] ).to.equal( domImg );
  203. } );
  204. it( 'should change element if it is different', () => {
  205. const viewImg = new ViewElement( 'img' );
  206. viewRoot.appendChildren( viewImg );
  207. renderer.markToSync( 'children', viewRoot );
  208. renderer.render();
  209. const viewP = new ViewElement( 'p' );
  210. viewRoot.removeChildren( 0, 1 );
  211. viewRoot.appendChildren( viewP );
  212. renderer.markToSync( 'children', viewRoot );
  213. renderer.render();
  214. expect( domRoot.childNodes.length ).to.equal( 1 );
  215. expect( domRoot.childNodes[ 0 ].tagName ).to.equal( 'P' );
  216. } );
  217. it( 'should update removed item when it is reinserted', () => {
  218. const viewFoo = new ViewText( 'foo' );
  219. const viewP = new ViewElement( 'p', null, viewFoo );
  220. const viewDiv = new ViewElement( 'div', null, viewP );
  221. viewRoot.appendChildren( viewDiv );
  222. renderer.markToSync( 'children', viewRoot );
  223. renderer.render();
  224. viewDiv.removeChildren( 0, 1 );
  225. renderer.markToSync( 'children', viewDiv );
  226. renderer.render();
  227. viewP.removeChildren( 0, 1 );
  228. viewDiv.appendChildren( viewP );
  229. renderer.markToSync( 'children', viewDiv );
  230. renderer.render();
  231. expect( domRoot.childNodes.length ).to.equal( 1 );
  232. const domDiv = domRoot.childNodes[ 0 ];
  233. expect( domDiv.tagName ).to.equal( 'DIV' );
  234. expect( domDiv.childNodes.length ).to.equal( 1 );
  235. const domP = domDiv.childNodes[ 0 ];
  236. expect( domP.tagName ).to.equal( 'P' );
  237. expect( domP.childNodes.length ).to.equal( 0 );
  238. } );
  239. it( 'should update removed item when it is reinserted #2', () => {
  240. // Prepare view: root -> div "outer" -> div "inner" -> p.
  241. const viewP = new ViewElement( 'p' );
  242. const viewDivInner = new ViewElement( 'div', null, viewP );
  243. const viewDivOuter = new ViewElement( 'div', null, viewDivInner );
  244. viewRoot.appendChildren( viewDivOuter );
  245. // Render view tree to DOM.
  246. renderer.markToSync( 'children', viewRoot );
  247. renderer.render();
  248. // Remove div "outer" from root and render it.
  249. viewDivOuter.remove();
  250. renderer.markToSync( 'children', viewRoot );
  251. renderer.render();
  252. // Remove p from div "child" -- div "inner" won't be marked because it is in document fragment not view root.
  253. viewP.remove();
  254. // Add div "outer" back to root.
  255. viewRoot.appendChildren( viewDivOuter );
  256. renderer.markToSync( 'children', viewRoot );
  257. // Render changes, view is: root -> div "outer" -> div "inner".
  258. renderer.render();
  259. // Same is expected in DOM.
  260. expect( domRoot.childNodes.length ).to.equal( 1 );
  261. const domDivOuter = domRoot.childNodes[ 0 ];
  262. expect( renderer.domConverter.viewToDom( viewDivOuter, domRoot.document ) ).to.equal( domDivOuter );
  263. expect( domDivOuter.tagName ).to.equal( 'DIV' );
  264. expect( domDivOuter.childNodes.length ).to.equal( 1 );
  265. const domDivInner = domDivOuter.childNodes[ 0 ];
  266. expect( renderer.domConverter.viewToDom( viewDivInner, domRoot.document ) ).to.equal( domDivInner );
  267. expect( domDivInner.tagName ).to.equal( 'DIV' );
  268. expect( domDivInner.childNodes.length ).to.equal( 0 );
  269. } );
  270. it( 'should not throw when trying to update children of view element that got removed and lost its binding', () => {
  271. const viewFoo = new ViewText( 'foo' );
  272. const viewP = new ViewElement( 'p', null, viewFoo );
  273. const viewDiv = new ViewElement( 'div', null, viewP );
  274. viewRoot.appendChildren( viewDiv );
  275. renderer.markToSync( 'children', viewRoot );
  276. renderer.render();
  277. viewRoot.removeChildren( 0, 1 );
  278. renderer.markToSync( 'children', viewRoot );
  279. viewDiv.removeChildren( 0, 1 );
  280. renderer.markToSync( 'children', viewDiv );
  281. viewP.removeChildren( 0, 1 );
  282. renderer.markToSync( 'children', viewP );
  283. renderer.render();
  284. expect( domRoot.childNodes.length ).to.equal( 0 );
  285. } );
  286. it( 'should not care about filler if there is no DOM', () => {
  287. selectionEditable = null;
  288. const { view: viewP, selection: newSelection } = parse(
  289. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  290. const viewRoot = new ViewElement( 'p' );
  291. viewRoot.appendChildren( viewP );
  292. selection._setTo( newSelection );
  293. renderer.markToSync( 'children', viewRoot );
  294. renderer.render();
  295. // Expect no error on render.
  296. expect( viewRoot ).to.be.ok;
  297. } );
  298. it( 'should not add filler when inside contenteditable=false parent', () => {
  299. const { view: viewP, selection: newSelection } = parse(
  300. '<container:p>foo<attribute:b contenteditable="false">[]</attribute:b>bar</container:p>' );
  301. viewRoot.appendChildren( viewP );
  302. selection._setTo( newSelection );
  303. renderer.markToSync( 'children', viewRoot );
  304. renderer.render();
  305. expect( domRoot.childNodes.length ).to.equal( 1 );
  306. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  307. const domP = domRoot.childNodes[ 0 ];
  308. expect( domP.childNodes.length ).to.equal( 3 );
  309. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  310. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  311. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  312. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  313. } );
  314. it( 'should not add filler when inside contenteditable=false ancestor', () => {
  315. const { view: viewP, selection: newSelection } = parse(
  316. '<container:p contenteditable="false">foo<attribute:b>[]</attribute:b>bar</container:p>' );
  317. viewRoot.appendChildren( viewP );
  318. selection._setTo( newSelection );
  319. renderer.markToSync( 'children', viewRoot );
  320. renderer.render();
  321. expect( domRoot.childNodes.length ).to.equal( 1 );
  322. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  323. const domP = domRoot.childNodes[ 0 ];
  324. expect( domP.childNodes.length ).to.equal( 3 );
  325. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  326. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  327. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  328. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  329. } );
  330. it( 'should add and remove inline filler in case <p>foo<b>[]</b>bar</p>', () => {
  331. const domSelection = document.getSelection();
  332. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  333. const { view: viewP, selection: newSelection } = parse(
  334. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  335. viewRoot.appendChildren( viewP );
  336. selection._setTo( newSelection );
  337. renderer.markToSync( 'children', viewRoot );
  338. renderer.render();
  339. expect( domRoot.childNodes.length ).to.equal( 1 );
  340. expect( domRoot.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'p' );
  341. const domP = domRoot.childNodes[ 0 ];
  342. expect( domP.childNodes.length ).to.equal( 3 );
  343. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  344. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  345. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  346. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  347. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  348. expect( domSelection.rangeCount ).to.equal( 1 );
  349. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  350. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  351. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  352. // Step 2: No mutation on second render
  353. renderer.markToSync( 'children', viewRoot );
  354. renderer.markToSync( 'children', viewP );
  355. renderAndExpectNoChanges( renderer, domRoot );
  356. // Step 3: <p>foo{}<b></b></p>
  357. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP.getChild( 0 ), 3, viewP.getChild( 0 ), 3 ) );
  358. renderer.render();
  359. expect( domP.childNodes.length ).to.equal( 3 );
  360. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  361. expect( domP.childNodes[ 2 ].data ).to.equal( 'bar' );
  362. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  363. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  364. expect( domSelection.rangeCount ).to.equal( 1 );
  365. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  366. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  367. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  368. // Step 4: No mutation on second render
  369. renderer.markToSync( 'children', viewRoot );
  370. renderer.markToSync( 'children', viewP );
  371. renderAndExpectNoChanges( renderer, domRoot );
  372. } );
  373. it( 'should add and remove inline filler in case <p>[]<b>foo</b></p>', () => {
  374. const domSelection = document.getSelection();
  375. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  376. const { view: viewP, selection: newSelection } = parse(
  377. '<container:p>[]<attribute:b>foo</attribute:b></container:p>' );
  378. viewRoot.appendChildren( viewP );
  379. selection._setTo( newSelection );
  380. renderer.markToSync( 'children', viewRoot );
  381. renderer.render();
  382. const domP = domRoot.childNodes[ 0 ];
  383. expect( domP.childNodes.length ).to.equal( 2 );
  384. expect( domP.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  385. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  386. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  387. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  388. expect( domSelection.rangeCount ).to.equal( 1 );
  389. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  390. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  391. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  392. // Step 2: No mutation on second render
  393. renderer.markToSync( 'children', viewP );
  394. renderAndExpectNoChanges( renderer, domRoot );
  395. // Step 3: <p><b>{}foo</b></p>
  396. selection._setTo( ViewRange.createFromParentsAndOffsets(
  397. viewP.getChild( 0 ).getChild( 0 ), 0, viewP.getChild( 0 ).getChild( 0 ), 0 ) );
  398. renderer.render();
  399. expect( domP.childNodes.length ).to.equal( 1 );
  400. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  401. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  402. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  403. expect( domSelection.rangeCount ).to.equal( 1 );
  404. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  405. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  406. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  407. // Step 4: No mutation on second render
  408. renderer.markToSync( 'children', viewP );
  409. renderAndExpectNoChanges( renderer, domRoot );
  410. } );
  411. it( 'should add and remove inline filler in case <p><b>foo</b>[]</p>', () => {
  412. const domSelection = document.getSelection();
  413. // Step 1: <p>"FILLER{}"<b>foo</b></p>
  414. const { view: viewP, selection: newSelection } = parse(
  415. '<container:p><attribute:b>foo</attribute:b>[]</container:p>' );
  416. viewRoot.appendChildren( viewP );
  417. selection._setTo( newSelection );
  418. renderer.markToSync( 'children', viewRoot );
  419. renderer.render();
  420. const domP = domRoot.childNodes[ 0 ];
  421. expect( domP.childNodes.length ).to.equal( 2 );
  422. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  423. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  424. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  425. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  426. expect( domSelection.rangeCount ).to.equal( 1 );
  427. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  428. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  429. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  430. // Step 2: No mutation on second render
  431. renderer.markToSync( 'children', viewP );
  432. renderAndExpectNoChanges( renderer, domRoot );
  433. // Step 3: <p><b>foo{}</b></p>
  434. selection._setTo( ViewRange.createFromParentsAndOffsets(
  435. viewP.getChild( 0 ).getChild( 0 ), 3, viewP.getChild( 0 ).getChild( 0 ), 3 ) );
  436. renderer.render();
  437. expect( domP.childNodes.length ).to.equal( 1 );
  438. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  439. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  440. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  441. expect( domSelection.rangeCount ).to.equal( 1 );
  442. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ].childNodes[ 0 ] );
  443. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  444. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  445. // Step 4: No mutation on second render
  446. renderer.markToSync( 'children', viewP );
  447. renderAndExpectNoChanges( renderer, domRoot );
  448. } );
  449. it( 'should add and remove inline filler in case <p><b>foo</b>[]<b>bar</b></p>', () => {
  450. const domSelection = document.getSelection();
  451. const { view: viewP, selection: newSelection } = parse(
  452. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p>' );
  453. viewRoot.appendChildren( viewP );
  454. selection._setTo( newSelection );
  455. renderer.markToSync( 'children', viewRoot );
  456. renderer.render();
  457. const domP = domRoot.childNodes[ 0 ];
  458. expect( domP.childNodes.length ).to.equal( 3 );
  459. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  460. expect( domP.childNodes[ 0 ].childNodes.length ).to.equal( 1 );
  461. expect( domP.childNodes[ 0 ].childNodes[ 0 ].data ).to.equal( 'foo' );
  462. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  463. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'b' );
  464. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  465. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  466. expect( domSelection.rangeCount ).to.equal( 1 );
  467. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 1 ] );
  468. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  469. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  470. } );
  471. it( 'should move filler when selection is moved', () => {
  472. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  473. const { view: viewP, selection: newSelection } = parse(
  474. '<container:p>foo<attribute:b>[]</attribute:b><attribute:i></attribute:i></container:p>' );
  475. viewRoot.appendChildren( viewP );
  476. selection._setTo( newSelection );
  477. renderer.markToSync( 'children', viewRoot );
  478. renderer.render();
  479. const domP = domRoot.childNodes[ 0 ];
  480. expect( domP.childNodes.length ).to.equal( 3 );
  481. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  482. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  483. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  484. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  485. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  486. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 0 );
  487. // Step 2: <p>foo<b></b><i>"FILLER{}"</i></p>
  488. const viewI = viewP.getChild( 2 );
  489. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  490. renderer.render();
  491. expect( domP.childNodes.length ).to.equal( 3 );
  492. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  493. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  494. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 0 );
  495. expect( domP.childNodes[ 2 ].tagName.toLowerCase() ).to.equal( 'i' );
  496. expect( domP.childNodes[ 2 ].childNodes.length ).to.equal( 1 );
  497. expect( domP.childNodes[ 2 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  498. } );
  499. it( 'should remove filler when text is added and selection removed', () => {
  500. // Step 1: <p>foo<b>"FILLER{}"</b></p>
  501. const { view: viewP, selection: newSelection } = parse( '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  502. const viewB = viewP.getChild( 1 );
  503. viewRoot.appendChildren( viewP );
  504. selection._setTo( newSelection );
  505. renderer.markToSync( 'children', viewRoot );
  506. renderer.render();
  507. const domP = domRoot.childNodes[ 0 ];
  508. expect( domP.childNodes.length ).to.equal( 2 );
  509. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  510. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  511. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  512. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  513. // Step 2: Add text node.
  514. const viewText = new ViewText( 'x' );
  515. viewB.appendChildren( viewText );
  516. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  517. renderer.markToSync( 'children', viewB );
  518. renderer.render();
  519. // Step 3: Remove selection from the view.
  520. selection._setTo( null );
  521. renderer.render();
  522. expect( domP.childNodes.length ).to.equal( 2 );
  523. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  524. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  525. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  526. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'x' );
  527. } );
  528. // #659
  529. // The element before the filler is removed so the position of the filler
  530. // cannot be remembered as parent+offset.
  531. it( 'should remove filler from a modified DOM in case <p>bar<b>foo</b>[]</p>', () => {
  532. // Step 1: <p>bar<b>foo</b>"FILLER{}"</p>
  533. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>foo</attribute:b>[]</container:p>' );
  534. viewRoot.appendChildren( viewP );
  535. selection._setTo( newSelection );
  536. renderer.markToSync( 'children', viewRoot );
  537. renderer.render();
  538. const domP = domRoot.childNodes[ 0 ];
  539. expect( domP.childNodes.length ).to.equal( 3 );
  540. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  541. // Step 2: Remove the <b> and update the selection (<p>bar[]</p>).
  542. viewP.removeChildren( 1 );
  543. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 1, viewP, 1 ) );
  544. renderer.markToSync( 'children', viewP );
  545. renderer.render();
  546. // Step 3: Check whether there's no filler in the DOM.
  547. expect( domP.childNodes.length ).to.equal( 1 );
  548. expect( domP.childNodes[ 0 ].data ).to.equal( 'bar' );
  549. } );
  550. // #659
  551. it( 'should remove filler from a modified DOM when children moved', () => {
  552. // Step 1: <p><b>foo</b>"FILLER{}"<b>bar</b></p><p></p>
  553. const { view: viewFragment, selection: newSelection } = parse(
  554. '<container:p><attribute:b>foo</attribute:b>[]<attribute:b>bar</attribute:b></container:p><container:p></container:p>'
  555. );
  556. viewRoot.appendChildren( viewFragment );
  557. selection._setTo( newSelection );
  558. renderer.markToSync( 'children', viewRoot );
  559. renderer.render();
  560. expect( domRoot.childNodes.length ).to.equal( 2 );
  561. const domP = domRoot.childNodes[ 0 ];
  562. const domP2 = domRoot.childNodes[ 1 ];
  563. expect( domP.childNodes.length ).to.equal( 3 );
  564. expect( domP.childNodes[ 1 ].data ).to.equal( INLINE_FILLER );
  565. // Step 2: Move <b>foo</b><b>bar</b> to the second paragraph and leave collapsed selection in the first one.
  566. // <p>[]</p><p><b>foo</b><b>bar</b></p>
  567. const viewP = viewRoot.getChild( 0 );
  568. const viewP2 = viewRoot.getChild( 1 );
  569. const removedChildren = viewP.removeChildren( 0, 2 );
  570. viewP2.appendChildren( removedChildren );
  571. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  572. renderer.markToSync( 'children', viewP );
  573. renderer.markToSync( 'children', viewP2 );
  574. renderer.render();
  575. // Step 3: Check whether in the first paragraph there's a <br> filler and that
  576. // in the second one there are two <b> tags.
  577. expect( domP.childNodes.length ).to.equal( 1 );
  578. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  579. expect( domP2.childNodes.length ).to.equal( 2 );
  580. expect( domP2.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  581. expect( domP2.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  582. } );
  583. // Test for an edge case in the _isSelectionInInlineFiller which can be triggered like
  584. // in one of ckeditor/ckeditor5-typing#59 automated tests.
  585. it( 'should not break when selection is moved to a new element, when filler exists', () => {
  586. // Step 1: <p>bar<b>"FILLER{}"</b></p>
  587. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>[]</attribute:b></container:p>' );
  588. viewRoot.appendChildren( viewP );
  589. selection._setTo( newSelection );
  590. renderer.markToSync( 'children', viewRoot );
  591. renderer.render();
  592. const domP = domRoot.childNodes[ 0 ];
  593. expect( domP.childNodes.length ).to.equal( 2 );
  594. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  595. // Step 2: Move selection to a new attribute element and remove the previous one
  596. viewP.removeChildren( 1 ); // Remove <b>.
  597. const viewI = parse( '<attribute:i></attribute:i>' );
  598. viewP.appendChildren( viewI );
  599. selection._setTo( ViewRange.createFromParentsAndOffsets( viewI, 0, viewI, 0 ) );
  600. renderer.markToSync( 'children', viewP );
  601. renderer.render();
  602. // Step 3: Check whether new filler was created in the <i> element.
  603. expect( domP.childNodes.length ).to.equal( 2 );
  604. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'i' );
  605. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  606. } );
  607. // Test for an edge case in the _isSelectionInInlineFiller, when selection is before a view element
  608. // that has not been yet rendered/bound to DOM.
  609. it( 'should remove inline filler if selection is before a view element not bound to dom', () => {
  610. // Step 1: <p>bar<b>abc</b>"FILLER"{}</p>
  611. const { view: viewP, selection: newSelection } = parse( '<container:p>bar<attribute:b>abc</attribute:b>[]</container:p>' );
  612. viewRoot.appendChildren( viewP );
  613. selection._setTo( newSelection );
  614. renderer.markToSync( 'children', viewRoot );
  615. renderer.render();
  616. const domP = domRoot.childNodes[ 0 ];
  617. expect( domP.childNodes.length ).to.equal( 3 );
  618. expect( domP.childNodes[ 2 ].data ).to.equal( INLINE_FILLER );
  619. // Step 2: Move selection to a new attribute element.
  620. const viewAbc = parse( 'abc' );
  621. viewP.appendChildren( viewAbc );
  622. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 3, viewP, 3 ) );
  623. renderer.markToSync( 'children', viewP );
  624. renderer.render();
  625. // Step 3: Check whether old filler was removed.
  626. expect( domP.childNodes.length ).to.equal( 3 );
  627. expect( domP.textContent.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  628. } );
  629. it( 'should handle typing in empty block, do nothing if changes are already applied', () => {
  630. const domSelection = document.getSelection();
  631. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  632. viewRoot.appendChildren( viewP );
  633. selection._setTo( newSelection );
  634. renderer.markToSync( 'children', viewRoot );
  635. renderer.render();
  636. const domP = domRoot.childNodes[ 0 ];
  637. expect( domP.childNodes.length ).to.equal( 1 );
  638. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  639. expect( domSelection.rangeCount ).to.equal( 1 );
  640. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  641. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  642. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  643. // Remove filler and add text node to both DOM and View <p>x{}</p>
  644. domP.removeChild( domP.childNodes[ 0 ] );
  645. domP.appendChild( document.createTextNode( 'x' ) );
  646. domSelection.removeAllRanges();
  647. const domRange = document.createRange();
  648. domRange.setStart( domP.childNodes[ 0 ], 1 );
  649. domRange.collapse( true );
  650. domSelection.addRange( domRange );
  651. const viewText = new ViewText( 'x' );
  652. viewP.appendChildren( viewText );
  653. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  654. renderer.markToSync( 'children', viewP );
  655. renderAndExpectNoChanges( renderer, domRoot );
  656. } );
  657. it( 'should handle typing in empty block, render if needed', () => {
  658. const domSelection = document.getSelection();
  659. const { view: viewP, selection: newSelection } = parse( '<container:p>[]</container:p>' );
  660. viewRoot.appendChildren( viewP );
  661. selection._setTo( newSelection );
  662. renderer.markToSync( 'children', viewRoot );
  663. renderer.render();
  664. const domP = domRoot.childNodes[ 0 ];
  665. expect( domP.childNodes.length ).to.equal( 1 );
  666. expect( isBlockFiller( domP.childNodes[ 0 ], BR_FILLER ) ).to.be.true;
  667. expect( domSelection.rangeCount ).to.equal( 1 );
  668. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP );
  669. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  670. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  671. // Add text node only in View <p>x{}</p>
  672. const viewText = new ViewText( 'x' );
  673. viewP.appendChildren( viewText );
  674. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  675. renderer.markToSync( 'children', viewP );
  676. renderer.render();
  677. expect( domP.childNodes.length ).to.equal( 1 );
  678. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  679. expect( domSelection.rangeCount ).to.equal( 1 );
  680. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  681. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  682. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  683. } );
  684. it( 'should handle removing last character', () => {
  685. const domSelection = document.getSelection();
  686. const { view: viewP, selection: newSelection } = parse( '<container:p>x{}</container:p>' );
  687. viewRoot.appendChildren( viewP );
  688. selection._setTo( newSelection );
  689. renderer.markToSync( 'children', viewRoot );
  690. renderer.render();
  691. const domP = domRoot.childNodes[ 0 ];
  692. expect( domP.childNodes.length ).to.equal( 1 );
  693. expect( domP.childNodes[ 0 ].data ).to.equal( 'x' );
  694. expect( domSelection.rangeCount ).to.equal( 1 );
  695. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  696. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  697. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  698. // Remove text and add filler to both DOM and View <p>{}</p>
  699. domP.removeChild( domP.childNodes[ 0 ] );
  700. domP.appendChild( BR_FILLER( document ) ); // eslint-disable-line new-cap
  701. domSelection.removeAllRanges();
  702. const domRange = document.createRange();
  703. domRange.setStart( domP.childNodes[ 0 ], 0 );
  704. domRange.collapse( true );
  705. domSelection.addRange( domRange );
  706. viewP.removeChildren( 0 );
  707. selection._setTo( ViewRange.createFromParentsAndOffsets( viewP, 0, viewP, 0 ) );
  708. renderer.markToSync( 'children', viewP );
  709. renderAndExpectNoChanges( renderer, domRoot );
  710. } );
  711. it( 'should handle typing in empty attribute, do nothing if changes are already applied', () => {
  712. const domSelection = document.getSelection();
  713. // 1. Render <p><b>FILLER{}</b>foo</p>.
  714. const { view: viewP, selection: newSelection } = parse(
  715. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  716. viewRoot.appendChildren( viewP );
  717. selection._setTo( newSelection );
  718. renderer.markToSync( 'children', viewRoot );
  719. renderer.render();
  720. // 2. Check the DOM.
  721. const domP = domRoot.childNodes[ 0 ];
  722. expect( domP.childNodes.length ).to.equal( 2 );
  723. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  724. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  725. const domB = domP.childNodes[ 0 ];
  726. const viewB = viewP.getChild( 0 );
  727. expect( domB.childNodes.length ).to.equal( 1 );
  728. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  729. expect( domSelection.rangeCount ).to.equal( 1 );
  730. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  731. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  732. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  733. // 3. Add text node to both the DOM and the view: <p><b>FILLERx</b>foo</p>.
  734. domB.childNodes[ 0 ].data += 'x';
  735. domSelection.removeAllRanges();
  736. const domRange = document.createRange();
  737. domRange.setStart( domB.childNodes[ 0 ], INLINE_FILLER_LENGTH + 1 );
  738. domRange.collapse( true );
  739. domSelection.addRange( domRange );
  740. const viewText = new ViewText( 'x' );
  741. viewB.appendChildren( viewText );
  742. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  743. renderer.markToSync( 'children', viewP );
  744. renderAndExpectNoChanges( renderer, domRoot );
  745. } );
  746. it( 'should handle typing in empty attribute as a children change, render if needed', () => {
  747. const domSelection = document.getSelection();
  748. // 1. Render <p><b>FILLER{}</b>foo</p>.
  749. const { view: viewP, selection: newSelection } = parse(
  750. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  751. viewRoot.appendChildren( viewP );
  752. selection._setTo( newSelection );
  753. renderer.markToSync( 'children', viewRoot );
  754. renderer.render();
  755. // 2. Check the DOM.
  756. const domP = domRoot.childNodes[ 0 ];
  757. expect( domP.childNodes.length ).to.equal( 2 );
  758. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  759. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  760. const domB = domP.childNodes[ 0 ];
  761. const viewB = viewP.getChild( 0 );
  762. expect( domB.childNodes.length ).to.equal( 1 );
  763. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  764. expect( domSelection.rangeCount ).to.equal( 1 );
  765. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  766. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  767. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  768. domSelection.removeAllRanges();
  769. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  770. const viewText = new ViewText( 'x' );
  771. viewB.appendChildren( viewText );
  772. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  773. renderer.markToSync( 'children', viewB );
  774. renderer.render();
  775. expect( domB.childNodes.length ).to.equal( 1 );
  776. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  777. expect( domSelection.rangeCount ).to.equal( 1 );
  778. // Depending on the browser selection may end up at the end of the text node or after the text node.
  779. const firstRange = domSelection.getRangeAt( 0 );
  780. const assertSelectionAtEndOfTextNode = () => {
  781. expect( firstRange.startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  782. };
  783. const assertSelectionInsideTextNode = () => {
  784. expect( firstRange.startContainer ).to.equal( domB );
  785. expect( firstRange.startOffset ).to.equal( 1 );
  786. };
  787. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  788. expect( firstRange.collapsed ).to.be.true;
  789. } );
  790. it( 'should handle typing in empty attribute as a text change, render if needed', () => {
  791. const domSelection = document.getSelection();
  792. // 1. Render <p><b>FILLER{}</b>foo</p>.
  793. const { view: viewP, selection: newSelection } = parse(
  794. '<container:p><attribute:b>[]</attribute:b>foo</container:p>' );
  795. viewRoot.appendChildren( viewP );
  796. selection._setTo( newSelection );
  797. renderer.markToSync( 'children', viewRoot );
  798. renderer.render();
  799. // 2. Check the DOM.
  800. const domP = domRoot.childNodes[ 0 ];
  801. expect( domP.childNodes.length ).to.equal( 2 );
  802. expect( domP.childNodes[ 0 ].tagName.toLowerCase() ).to.equal( 'b' );
  803. expect( domP.childNodes[ 1 ].data ).to.equal( 'foo' );
  804. const domB = domP.childNodes[ 0 ];
  805. const viewB = viewP.getChild( 0 );
  806. expect( domB.childNodes.length ).to.equal( 1 );
  807. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  808. expect( domSelection.rangeCount ).to.equal( 1 );
  809. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  810. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  811. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  812. // 3. Add text node only to the view: <p><b>x{}</b>foo</p>.
  813. const viewText = new ViewText( 'x' );
  814. viewB.appendChildren( viewText );
  815. selection._setTo( ViewRange.createFromParentsAndOffsets( viewText, 1, viewText, 1 ) );
  816. renderer.markToSync( 'text', viewText );
  817. renderer.render();
  818. // 4. Check the DOM.
  819. expect( domB.childNodes.length ).to.equal( 1 );
  820. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER + 'x' );
  821. expect( domSelection.rangeCount ).to.equal( 1 );
  822. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  823. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH + 1 );
  824. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  825. } );
  826. it( 'should handle not collapsed range', () => {
  827. const domSelection = document.getSelection();
  828. const { view: viewP, selection: newSelection } = parse(
  829. '<container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>' );
  830. viewRoot.appendChildren( viewP );
  831. selection._setTo( newSelection );
  832. renderer.markToSync( 'children', viewRoot );
  833. renderer.render();
  834. const domP = domRoot.childNodes[ 0 ];
  835. expect( domP.childNodes.length ).to.equal( 2 );
  836. expect( domP.childNodes[ 0 ].data ).to.equal( 'foo' );
  837. expect( domP.childNodes[ 1 ].tagName.toLowerCase() ).to.equal( 'b' );
  838. expect( domP.childNodes[ 1 ].childNodes.length ).to.equal( 1 );
  839. expect( domP.childNodes[ 1 ].childNodes[ 0 ].data ).to.equal( 'bar' );
  840. expect( domSelection.rangeCount ).to.equal( 1 );
  841. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  842. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  843. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 1 ].childNodes[ 0 ] );
  844. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 1 );
  845. renderer.markToSync( 'children', viewP );
  846. renderAndExpectNoChanges( renderer, domRoot );
  847. } );
  848. it( 'should not change selection if there is no editable with selection', () => {
  849. const domDiv = createElement( document, 'div', { contenteditable: true }, 'not editable' );
  850. document.body.appendChild( domDiv );
  851. domDiv.focus();
  852. const domSelection = document.getSelection();
  853. domSelection.removeAllRanges();
  854. domSelection.collapse( domDiv, 0 );
  855. selectionEditable = null;
  856. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  857. viewRoot.appendChildren( viewP );
  858. selection._setTo( newSelection );
  859. renderer.render();
  860. expect( domSelection.rangeCount ).to.equal( 1 );
  861. // Depending on the browser selection may end up before the text node or at the beginning of it.
  862. const domRange = domSelection.getRangeAt( 0 );
  863. const assertSelectionAtEndOfTextNode = () => {
  864. expect( domRange.startContainer ).to.equal( domDiv );
  865. };
  866. const assertSelectionInsideTextNode = () => {
  867. expect( domRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  868. };
  869. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  870. expect( domRange.startOffset ).to.equal( 0 );
  871. expect( domRange.collapsed ).to.be.true;
  872. domDiv.remove();
  873. } );
  874. it( 'should not change selection if there is no focus', () => {
  875. const domDiv = createElement( document, 'div', null, 'not editable' );
  876. document.body.appendChild( domDiv );
  877. const domSelection = document.getSelection();
  878. domSelection.removeAllRanges();
  879. const domRange = document.createRange();
  880. domRange.setStart( domDiv, 0 );
  881. domRange.collapse( true );
  882. domSelection.addRange( domRange );
  883. renderer.isFocused = false;
  884. const { view: viewP, selection: newSelection } = parse( '<container:p>fo{o}</container:p>' );
  885. viewRoot.appendChildren( viewP );
  886. selection._setTo( newSelection );
  887. renderer.render();
  888. expect( domSelection.rangeCount ).to.equal( 1 );
  889. // Depending on the browser selection may end up before the text node or at the beginning of it.
  890. const domSelectionRange = domSelection.getRangeAt( 0 );
  891. const assertSelectionAtEndOfTextNode = () => {
  892. expect( domSelectionRange.startContainer ).to.equal( domDiv );
  893. };
  894. const assertSelectionInsideTextNode = () => {
  895. expect( domSelectionRange.startContainer ).to.equal( domDiv.childNodes[ 0 ] );
  896. };
  897. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  898. expect( domSelectionRange.startOffset ).to.equal( 0 );
  899. expect( domSelectionRange.collapsed ).to.be.true;
  900. domDiv.remove();
  901. } );
  902. it( 'should not add inline filler after text node', () => {
  903. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]</container:p>' );
  904. viewRoot.appendChildren( viewP );
  905. selection._setTo( newSelection );
  906. renderer.markToSync( 'children', viewRoot );
  907. renderer.render();
  908. const domP = domRoot.childNodes[ 0 ];
  909. expect( domP.innerHTML.indexOf( INLINE_FILLER ) ).to.equal( -1 );
  910. } );
  911. it( 'should throw if there is no filler in expected position', () => {
  912. const { view: viewP, selection: newSelection } = parse(
  913. '<container:p>foo<attribute:b>[]</attribute:b>bar</container:p>' );
  914. viewRoot.appendChildren( viewP );
  915. selection._setTo( newSelection );
  916. renderer.markToSync( 'children', viewRoot );
  917. renderer.render();
  918. const domB = domRoot.childNodes[ 0 ].childNodes[ 1 ];
  919. const viewB = viewP.getChild( 1 );
  920. expect( domB.childNodes[ 0 ].data ).to.equal( INLINE_FILLER );
  921. // Remove filler.
  922. domB.childNodes[ 0 ].data = '';
  923. selection._setTo( null );
  924. renderer.markToSync( 'children', viewB );
  925. expect( () => {
  926. renderer.render();
  927. } ).to.throw( CKEditorError, /^view-renderer-filler-was-lost/ );
  928. } );
  929. // #1014.
  930. it( 'should create inline filler in newly created dom nodes', () => {
  931. // 1. Create the view structure which needs inline filler.
  932. const inputView =
  933. '<container:ul>' +
  934. '<container:li>Foobar.</container:li>' +
  935. '<container:li>[]<container:div></container:div></container:li>' +
  936. '</container:ul>';
  937. const { view: view, selection: newSelection } = parse( inputView );
  938. viewRoot.appendChildren( view );
  939. selection._setTo( newSelection );
  940. renderer.markToSync( 'children', viewRoot );
  941. renderer.render();
  942. // 2. Check if filler element has been (correctly) created.
  943. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  944. // 3. Move the inline filler parent to a newly created element.
  945. const viewLi = view.getChild( 0 );
  946. const viewLiIndented = view.removeChildren( 1, 1 ); // Array with one element.
  947. const viewUl = new ViewContainerElement( 'ul', null, viewLiIndented );
  948. viewLi.appendChildren( viewUl );
  949. // 4. Mark changed items and render the view.
  950. renderer.markToSync( 'children', view );
  951. renderer.markToSync( 'children', viewLi );
  952. renderer.render();
  953. expect( domRoot.innerHTML.indexOf( INLINE_FILLER ) ).not.to.equal( -1 );
  954. const domSelection = document.getSelection();
  955. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 7 ); // After inline filler.
  956. } );
  957. it( 'should handle focusing element', () => {
  958. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  959. const editable = selection.editableElement;
  960. renderer.render();
  961. expect( editable ).to.equal( viewRoot );
  962. expect( domFocusSpy.calledOnce ).to.be.true;
  963. } );
  964. it( 'should not focus editable if isFocues is set to false', () => {
  965. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  966. renderer.isFocused = false;
  967. renderer.render();
  968. expect( domFocusSpy.calledOnce ).to.be.false;
  969. } );
  970. it( 'should not focus already focused DOM element', () => {
  971. domRoot.setAttribute( 'contentEditable', true );
  972. domRoot.focus();
  973. const domFocusSpy = testUtils.sinon.spy( domRoot, 'focus' );
  974. renderer.render();
  975. expect( domFocusSpy.called ).to.be.false;
  976. } );
  977. describe( 'fake selection', () => {
  978. beforeEach( () => {
  979. const { view: viewP, selection: newSelection } = parse(
  980. '<container:p>[foo bar]</container:p>'
  981. );
  982. viewRoot.appendChildren( viewP );
  983. selection._setTo( newSelection );
  984. renderer.markToSync( 'children', viewRoot );
  985. renderer.render();
  986. } );
  987. it( 'should render fake selection', () => {
  988. const label = 'fake selection label';
  989. selection._setFake( true, { label } );
  990. renderer.render();
  991. expect( domRoot.childNodes.length ).to.equal( 2 );
  992. const container = domRoot.childNodes[ 1 ];
  993. expect( domConverter.mapDomToView( container ) ).to.be.undefined;
  994. expect( container.childNodes.length ).to.equal( 1 );
  995. const textNode = container.childNodes[ 0 ];
  996. expect( textNode.textContent ).to.equal( label );
  997. const domSelection = domRoot.ownerDocument.getSelection();
  998. assertDomSelectionContents( domSelection, container, /^fake selection label$/ );
  999. } );
  1000. it( 'should render &nbsp; if no selection label is provided', () => {
  1001. selection._setFake( true );
  1002. renderer.render();
  1003. expect( domRoot.childNodes.length ).to.equal( 2 );
  1004. const container = domRoot.childNodes[ 1 ];
  1005. expect( container.childNodes.length ).to.equal( 1 );
  1006. const textNode = container.childNodes[ 0 ];
  1007. expect( textNode.textContent ).to.equal( '\u00A0' );
  1008. const domSelection = domRoot.ownerDocument.getSelection();
  1009. assertDomSelectionContents( domSelection, container, /^[ \u00A0]$/ );
  1010. } );
  1011. it( 'should remove fake selection container when selection is no longer fake', () => {
  1012. selection._setFake( true );
  1013. renderer.render();
  1014. selection._setFake( false );
  1015. renderer.render();
  1016. expect( domRoot.childNodes.length ).to.equal( 1 );
  1017. const domParagraph = domRoot.childNodes[ 0 ];
  1018. expect( domParagraph.childNodes.length ).to.equal( 1 );
  1019. expect( domParagraph.tagName.toLowerCase() ).to.equal( 'p' );
  1020. const domSelection = domRoot.ownerDocument.getSelection();
  1021. assertDomSelectionContents( domSelection, domParagraph, /^foo bar$/ );
  1022. } );
  1023. it( 'should reuse fake selection container #1', () => {
  1024. const label = 'fake selection label';
  1025. selection._setFake( true, { label } );
  1026. renderer.render();
  1027. expect( domRoot.childNodes.length ).to.equal( 2 );
  1028. const container = domRoot.childNodes[ 1 ];
  1029. selection._setFake( true, { label } );
  1030. renderer.render();
  1031. expect( domRoot.childNodes.length ).to.equal( 2 );
  1032. const newContainer = domRoot.childNodes[ 1 ];
  1033. expect( newContainer ).equals( container );
  1034. expect( newContainer.childNodes.length ).to.equal( 1 );
  1035. const textNode = newContainer.childNodes[ 0 ];
  1036. expect( textNode.textContent ).to.equal( label );
  1037. } );
  1038. it( 'should reuse fake selection container #2', () => {
  1039. selection._setFake( true, { label: 'label 1' } );
  1040. renderer.render();
  1041. expect( domRoot.childNodes.length ).to.equal( 2 );
  1042. const container = domRoot.childNodes[ 1 ];
  1043. selection._setFake( false );
  1044. renderer.render();
  1045. expect( domRoot.childNodes.length ).to.equal( 1 );
  1046. selection._setFake( true, { label: 'label 2' } );
  1047. renderer.render();
  1048. expect( domRoot.childNodes.length ).to.equal( 2 );
  1049. const newContainer = domRoot.childNodes[ 1 ];
  1050. expect( newContainer ).equals( container );
  1051. expect( newContainer.childNodes.length ).to.equal( 1 );
  1052. const textNode = newContainer.childNodes[ 0 ];
  1053. expect( textNode.textContent ).to.equal( 'label 2' );
  1054. } );
  1055. it( 'should reuse fake selection container #3', () => {
  1056. selection._setFake( true, { label: 'label 1' } );
  1057. renderer.render();
  1058. expect( domRoot.childNodes.length ).to.equal( 2 );
  1059. const container = domRoot.childNodes[ 1 ];
  1060. selection._setFake( true, { label: 'label 2' } );
  1061. renderer.render();
  1062. expect( domRoot.childNodes.length ).to.equal( 2 );
  1063. const newContainer = domRoot.childNodes[ 1 ];
  1064. expect( newContainer ).equals( container );
  1065. expect( newContainer.childNodes.length ).to.equal( 1 );
  1066. const textNode = newContainer.childNodes[ 0 ];
  1067. expect( textNode.textContent ).to.equal( 'label 2' );
  1068. } );
  1069. it( 'should style fake selection container properly', () => {
  1070. selection._setFake( true, { label: 'fake selection' } );
  1071. renderer.render();
  1072. expect( domRoot.childNodes.length ).to.equal( 2 );
  1073. const container = domRoot.childNodes[ 1 ];
  1074. expect( container.style.position ).to.equal( 'fixed' );
  1075. expect( container.style.top ).to.equal( '0px' );
  1076. expect( container.style.left ).to.equal( '-9999px' );
  1077. } );
  1078. it( 'should bind fake selection container to view selection', () => {
  1079. selection._setFake( true, { label: 'fake selection' } );
  1080. renderer.render();
  1081. expect( domRoot.childNodes.length ).to.equal( 2 );
  1082. const container = domRoot.childNodes[ 1 ];
  1083. const bindSelection = renderer.domConverter.fakeSelectionToView( container );
  1084. expect( bindSelection ).to.not.be.undefined;
  1085. expect( bindSelection.isEqual( selection ) ).to.be.true;
  1086. } );
  1087. // Use a forgiving way of checking what the selection contains
  1088. // because Safari normalizes the selection ranges so precise checking is troublesome.
  1089. // Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
  1090. function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
  1091. const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;
  1092. expect( domSelection.toString() ).to.match( expectedText );
  1093. expect(
  1094. domSelectionContainer == expectedContainer.firstChild || domSelectionContainer == expectedContainer
  1095. ).to.be.true;
  1096. }
  1097. } );
  1098. // #887
  1099. describe( 'similar selection', () => {
  1100. // Use spies to check selection updates. Some selection positions are not achievable in some
  1101. // browsers (e.g. <p>Foo<b>{}Bar</b></p> in Chrome) so asserting dom selection after rendering would fail.
  1102. let selectionCollapseSpy, selectionExtendSpy;
  1103. afterEach( () => {
  1104. if ( selectionCollapseSpy ) {
  1105. selectionCollapseSpy.restore();
  1106. selectionCollapseSpy = null;
  1107. }
  1108. if ( selectionExtendSpy ) {
  1109. selectionExtendSpy.restore();
  1110. selectionExtendSpy = null;
  1111. }
  1112. } );
  1113. it( 'should always render collapsed selection even if it is similar', () => {
  1114. const domSelection = document.getSelection();
  1115. const { view: viewP, selection: newSelection } = parse(
  1116. '<container:p>foo{}<attribute:b>bar</attribute:b></container:p>' );
  1117. viewRoot.appendChildren( viewP );
  1118. selection._setTo( newSelection );
  1119. renderer.markToSync( 'children', viewRoot );
  1120. renderer.render();
  1121. const domP = domRoot.childNodes[ 0 ];
  1122. const domB = domP.childNodes[ 1 ];
  1123. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1124. expect( domSelection.isCollapsed ).to.true;
  1125. expect( domSelection.rangeCount ).to.equal( 1 );
  1126. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1127. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 3 );
  1128. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1129. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1130. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1131. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1132. // <container:p>foo<attribute:b>{}bar</attribute:b></container:p>
  1133. selection._setTo( [
  1134. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 0 ), new ViewPosition( viewB.getChild( 0 ), 0 ) )
  1135. ] );
  1136. renderer.markToSync( 'children', viewP );
  1137. renderer.render();
  1138. expect( selectionCollapseSpy.calledOnce ).to.true;
  1139. expect( selectionCollapseSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1140. expect( selectionExtendSpy.calledOnce ).to.true;
  1141. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 0 ) ).to.true;
  1142. } );
  1143. it( 'should always render collapsed selection even if it is similar (with empty element)', () => {
  1144. const domSelection = document.getSelection();
  1145. const { view: viewP, selection: newSelection } = parse(
  1146. '<container:p>foo<attribute:b>[]</attribute:b></container:p>' );
  1147. viewRoot.appendChildren( viewP );
  1148. selection._setTo( newSelection );
  1149. renderer.markToSync( 'children', viewRoot );
  1150. renderer.render();
  1151. const domP = domRoot.childNodes[ 0 ];
  1152. const domB = domP.childNodes[ 1 ];
  1153. expect( domSelection.isCollapsed ).to.true;
  1154. expect( domSelection.rangeCount ).to.equal( 1 );
  1155. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1156. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( INLINE_FILLER_LENGTH );
  1157. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1158. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( INLINE_FILLER_LENGTH );
  1159. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1160. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1161. // <container:p>foo{}<attribute:b></attribute:b></container:p>
  1162. selection._setTo( [
  1163. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewP.getChild( 0 ), 3 ) )
  1164. ] );
  1165. renderer.markToSync( 'children', viewP );
  1166. renderer.render();
  1167. expect( selectionCollapseSpy.calledOnce ).to.true;
  1168. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1169. expect( selectionExtendSpy.calledOnce ).to.true;
  1170. expect( selectionExtendSpy.calledWith( domP.childNodes[ 0 ], 3 ) ).to.true;
  1171. } );
  1172. it( 'should always render non-collapsed selection if it not is similar', () => {
  1173. const domSelection = document.getSelection();
  1174. const { view: viewP, selection: newSelection } = parse(
  1175. '<container:p>fo{o}<attribute:b>bar</attribute:b></container:p>' );
  1176. viewRoot.appendChildren( viewP );
  1177. selection._setTo( newSelection );
  1178. renderer.markToSync( 'children', viewRoot );
  1179. renderer.render();
  1180. const domP = domRoot.childNodes[ 0 ];
  1181. const domB = domP.childNodes[ 1 ];
  1182. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1183. expect( domSelection.isCollapsed ).to.false;
  1184. expect( domSelection.rangeCount ).to.equal( 1 );
  1185. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1186. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 2 );
  1187. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domP.childNodes[ 0 ] );
  1188. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1189. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1190. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1191. // <container:p>fo{o<attribute:b>b}ar</attribute:b></container:p>
  1192. selection._setTo( [
  1193. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 2 ), new ViewPosition( viewB.getChild( 0 ), 1 ) )
  1194. ] );
  1195. renderer.markToSync( 'children', viewP );
  1196. renderer.render();
  1197. expect( selectionCollapseSpy.calledOnce ).to.true;
  1198. expect( selectionCollapseSpy.calledWith( domP.childNodes[ 0 ], 2 ) ).to.true;
  1199. expect( selectionExtendSpy.calledOnce ).to.true;
  1200. expect( selectionExtendSpy.calledWith( domB.childNodes[ 0 ], 1 ) ).to.true;
  1201. } );
  1202. it( 'should always render selection (even if it is same in view) if current dom selection is in incorrect place', () => {
  1203. const domSelection = document.getSelection();
  1204. const { view: viewP, selection: newSelection } = parse( '<container:p>foo[]<ui:span></ui:span></container:p>' );
  1205. viewRoot.appendChildren( viewP );
  1206. selection._setTo( newSelection );
  1207. renderer.markToSync( 'children', viewRoot );
  1208. renderer.render();
  1209. // In DOM, set position to: <p>foo<span>[]</span></p>. This is incorrect DOM selection (it is in view ui element).
  1210. // Do not change view selection.
  1211. // When renderer will check if the DOM selection changed, it will convert DOM selection to a view selection.
  1212. // Selections (current view selection and view-from-dom selection) will be equal but we will still expect re-render
  1213. // because DOM selection is in incorrect place.
  1214. const domP = domRoot.childNodes[ 0 ];
  1215. const domSpan = domP.childNodes[ 1 ];
  1216. domSelection.collapse( domSpan, 0 );
  1217. renderer.render();
  1218. // Expect that after calling `renderer.render()` the DOM selection was re-rendered (and set at correct position).
  1219. // Depending on the browser selection may end up at the end of the text node or after the text node.
  1220. const assertSelectionAtEndOfTextNode = () => {
  1221. expect( domSelection.anchorNode ).to.equal( domP );
  1222. expect( domSelection.anchorOffset ).to.equal( 1 );
  1223. };
  1224. const assertSelectionInsideTextNode = () => {
  1225. const textNode = domP.childNodes[ 0 ];
  1226. expect( domSelection.anchorNode ).to.equal( textNode );
  1227. expect( domSelection.anchorOffset ).to.equal( 3 );
  1228. };
  1229. testUtils.checkAssertions( assertSelectionAtEndOfTextNode, assertSelectionInsideTextNode );
  1230. expect( domSelection.getRangeAt( 0 ).collapsed ).to.be.true;
  1231. } );
  1232. it( 'should not render non-collapsed selection it is similar (element start)', () => {
  1233. const domSelection = document.getSelection();
  1234. const { view: viewP, selection: newSelection } = parse(
  1235. '<container:p>foo<attribute:b>{ba}r</attribute:b></container:p>' );
  1236. viewRoot.appendChildren( viewP );
  1237. selection._setTo( newSelection );
  1238. renderer.markToSync( 'children', viewRoot );
  1239. renderer.render();
  1240. const domP = domRoot.childNodes[ 0 ];
  1241. const domB = domP.childNodes[ 1 ];
  1242. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1243. expect( domSelection.isCollapsed ).to.false;
  1244. expect( domSelection.rangeCount ).to.equal( 1 );
  1245. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1246. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1247. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1248. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1249. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1250. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1251. // <container:p>foo{<attribute:b>ba}r</attribute:b></container:p>
  1252. selection._setTo( [
  1253. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewB.getChild( 0 ), 2 ) )
  1254. ] );
  1255. renderer.markToSync( 'children', viewP );
  1256. renderer.render();
  1257. expect( selectionCollapseSpy.notCalled ).to.true;
  1258. expect( selectionExtendSpy.notCalled ).to.true;
  1259. } );
  1260. it( 'should not render non-collapsed selection it is similar (element end)', () => {
  1261. const domSelection = document.getSelection();
  1262. const { view: viewP, selection: newSelection } = parse(
  1263. '<container:p>foo<attribute:b>b{ar}</attribute:b>baz</container:p>' );
  1264. viewRoot.appendChildren( viewP );
  1265. selection._setTo( newSelection );
  1266. renderer.markToSync( 'children', viewRoot );
  1267. renderer.render();
  1268. const domP = domRoot.childNodes[ 0 ];
  1269. const domB = domP.childNodes[ 1 ];
  1270. const viewB = viewRoot.getChild( 0 ).getChild( 1 );
  1271. expect( domSelection.isCollapsed ).to.false;
  1272. expect( domSelection.rangeCount ).to.equal( 1 );
  1273. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ] );
  1274. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1275. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ] );
  1276. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1277. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1278. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1279. // <container:p>foo<attribute:b>b{ar</attribute:b>}baz</container:p>
  1280. selection._setTo( [
  1281. new ViewRange( new ViewPosition( viewB.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1282. ] );
  1283. renderer.markToSync( 'children', viewP );
  1284. renderer.render();
  1285. expect( selectionCollapseSpy.notCalled ).to.true;
  1286. expect( selectionExtendSpy.notCalled ).to.true;
  1287. } );
  1288. it( 'should not render non-collapsed selection it is similar (element start - nested)', () => {
  1289. const domSelection = document.getSelection();
  1290. const { view: viewP, selection: newSelection } = parse(
  1291. '<container:p>foo<attribute:b><attribute:i>{ba}r</attribute:i></attribute:b></container:p>' );
  1292. viewRoot.appendChildren( viewP );
  1293. selection._setTo( newSelection );
  1294. renderer.markToSync( 'children', viewRoot );
  1295. renderer.render();
  1296. const domP = domRoot.childNodes[ 0 ];
  1297. const domB = domP.childNodes[ 1 ];
  1298. const viewI = viewRoot.getChild( 0 ).getChild( 1 ).getChild( 0 );
  1299. expect( domSelection.isCollapsed ).to.false;
  1300. expect( domSelection.rangeCount ).to.equal( 1 );
  1301. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1302. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 0 );
  1303. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1304. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 2 );
  1305. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1306. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1307. // <container:p>foo{<attribute:b><attribute:i>ba}r</attribute:i></attribute:b></container:p>
  1308. selection._setTo( [
  1309. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 3 ), new ViewPosition( viewI.getChild( 0 ), 2 ) )
  1310. ] );
  1311. renderer.markToSync( 'children', viewP );
  1312. renderer.render();
  1313. expect( selectionCollapseSpy.notCalled ).to.true;
  1314. expect( selectionExtendSpy.notCalled ).to.true;
  1315. } );
  1316. it( 'should not render non-collapsed selection it is similar (element end - nested)', () => {
  1317. const domSelection = document.getSelection();
  1318. const { view: viewP, selection: newSelection } = parse(
  1319. '<container:p>f{oo<attribute:b><attribute:i>bar}</attribute:i></attribute:b>baz</container:p>' );
  1320. viewRoot.appendChildren( viewP );
  1321. selection._setTo( newSelection );
  1322. renderer.markToSync( 'children', viewRoot );
  1323. renderer.render();
  1324. const domP = domRoot.childNodes[ 0 ];
  1325. const domB = domP.childNodes[ 1 ];
  1326. expect( domSelection.isCollapsed ).to.false;
  1327. expect( domSelection.rangeCount ).to.equal( 1 );
  1328. expect( domSelection.getRangeAt( 0 ).startContainer ).to.equal( domP.childNodes[ 0 ] );
  1329. expect( domSelection.getRangeAt( 0 ).startOffset ).to.equal( 1 );
  1330. expect( domSelection.getRangeAt( 0 ).endContainer ).to.equal( domB.childNodes[ 0 ].childNodes[ 0 ] );
  1331. expect( domSelection.getRangeAt( 0 ).endOffset ).to.equal( 3 );
  1332. selectionCollapseSpy = sinon.spy( window.Selection.prototype, 'collapse' );
  1333. selectionExtendSpy = sinon.spy( window.Selection.prototype, 'extend' );
  1334. // <container:p>f{oo<attribute:b><attribute:i>bar</attribute:i></attribute:b>}baz</container:p>
  1335. selection._setTo( [
  1336. new ViewRange( new ViewPosition( viewP.getChild( 0 ), 1 ), new ViewPosition( viewP.getChild( 2 ), 0 ) )
  1337. ] );
  1338. renderer.markToSync( 'children', viewP );
  1339. renderer.render();
  1340. expect( selectionCollapseSpy.notCalled ).to.true;
  1341. expect( selectionExtendSpy.notCalled ).to.true;
  1342. } );
  1343. } );
  1344. } );
  1345. describe( '#922', () => {
  1346. let view, viewDoc, viewRoot, domRoot, converter;
  1347. beforeEach( () => {
  1348. view = new View();
  1349. viewDoc = view.document;
  1350. domRoot = document.createElement( 'div' );
  1351. document.body.appendChild( domRoot );
  1352. viewRoot = createViewRoot( viewDoc );
  1353. view.attachDomRoot( domRoot );
  1354. converter = view.domConverter;
  1355. } );
  1356. it( 'should properly render unwrapped attributes #1', () => {
  1357. setViewData( view,
  1358. '<container:p>' +
  1359. '[<attribute:italic>' +
  1360. '<attribute:strong>f</attribute:strong>' +
  1361. '</attribute:italic>]' +
  1362. '<attribute:strong>oo</attribute:strong>' +
  1363. '</container:p>'
  1364. );
  1365. // Render it to DOM to create initial DOM <-> view mappings.
  1366. view.render();
  1367. // Unwrap italic attribute element.
  1368. view.change( writer => {
  1369. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1370. } );
  1371. expect( getViewData( view ) ).to.equal( '<p>[<strong>foo</strong>]</p>' );
  1372. // Re-render changes in view to DOM.
  1373. view.render();
  1374. // Check if DOM is rendered correctly.
  1375. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>foo</strong></p>' );
  1376. expect( checkMappings() ).to.be.true;
  1377. } );
  1378. it( 'should properly render unwrapped attributes #2', () => {
  1379. setViewData( view,
  1380. '<container:p>' +
  1381. '[<attribute:italic>' +
  1382. '<attribute:strong>foo</attribute:strong>' +
  1383. '</attribute:italic>]' +
  1384. '</container:p>' );
  1385. // Render it to DOM to create initial DOM <-> view mappings.
  1386. view.render();
  1387. // Unwrap italic attribute element and change text inside.
  1388. view.change( writer => {
  1389. writer.unwrap( viewDoc.selection.getFirstRange(), new ViewAttributeElement( 'italic' ) );
  1390. } );
  1391. viewRoot.getChild( 0 ).getChild( 0 ).getChild( 0 ).data = 'bar';
  1392. expect( getViewData( view ) ).to.equal( '<p>[<strong>bar</strong>]</p>' );
  1393. // Re-render changes in view to DOM.
  1394. view.render();
  1395. // Check if DOM is rendered correctly.
  1396. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><strong>bar</strong></p>' );
  1397. expect( checkMappings() ).to.be.true;
  1398. } );
  1399. it( 'should properly render if text is changed and element is inserted into same node #1', () => {
  1400. setViewData( view,
  1401. '<container:p>foo</container:p>'
  1402. );
  1403. // Render it to DOM to create initial DOM <-> view mappings.
  1404. view.render();
  1405. // Change text and insert new element into paragraph.
  1406. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1407. textNode.data = 'foobar';
  1408. view.change( writer => {
  1409. writer.insert( ViewPosition.createAfter( textNode ), new ViewAttributeElement( 'img' ) );
  1410. } );
  1411. expect( getViewData( view ) ).to.equal( '<p>foobar<img></img></p>' );
  1412. // Re-render changes in view to DOM.
  1413. view.render();
  1414. // Check if DOM is rendered correctly.
  1415. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p>foobar<img></img></p>' );
  1416. expect( checkMappings() ).to.be.true;
  1417. } );
  1418. it( 'should properly render if text is changed and element is inserted into same node #2', () => {
  1419. setViewData( view,
  1420. '<container:p>foo</container:p>'
  1421. );
  1422. // Render it to DOM to create initial DOM <-> view mappings.
  1423. view.render();
  1424. // Change text and insert new element into paragraph.
  1425. const textNode = viewRoot.getChild( 0 ).getChild( 0 );
  1426. textNode.data = 'foobar';
  1427. view.change( writer => {
  1428. writer.insert( ViewPosition.createBefore( textNode ), new ViewAttributeElement( 'img' ) );
  1429. } );
  1430. expect( getViewData( view ) ).to.equal( '<p><img></img>foobar</p>' );
  1431. // Re-render changes in view to DOM.
  1432. view.render();
  1433. // Check if DOM is rendered correctly.
  1434. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><img></img>foobar</p>' );
  1435. expect( checkMappings() ).to.be.true;
  1436. } );
  1437. it( 'should not unbind elements that are removed and reinserted to DOM', () => {
  1438. setViewData( view,
  1439. '<container:p>' +
  1440. '<attribute:b></attribute:b>' +
  1441. '<attribute:i></attribute:i>' +
  1442. '<attribute:span></attribute:span>' +
  1443. '</container:p>'
  1444. );
  1445. // Render it to DOM to create initial DOM <-> view mappings.
  1446. view.render();
  1447. // Remove first element and reinsert it at the end.
  1448. const container = viewRoot.getChild( 0 );
  1449. const firstElement = container.getChild( 0 );
  1450. view.change( writer => {
  1451. writer.remove( ViewRange.createOn( firstElement ) );
  1452. writer.insert( new ViewPosition( container, 2 ), firstElement );
  1453. } );
  1454. expect( getViewData( view ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1455. // Re-render changes in view to DOM.
  1456. view.render();
  1457. // Check if DOM is rendered correctly.
  1458. expect( normalizeHtml( domRoot.innerHTML ) ).to.equal( '<p><i></i><span></span><b></b></p>' );
  1459. expect( checkMappings() ).to.be.true;
  1460. } );
  1461. // Checks if every node in DOM tree is mapped to the view.
  1462. function checkMappings() {
  1463. const domWalker = document.createTreeWalker( domRoot, NodeFilter.SHOW_ELEMENT | NodeFilter.SHOW_TEXT );
  1464. while ( domWalker.nextNode() ) {
  1465. const node = domWalker.currentNode;
  1466. if ( !converter.mapDomToView( node ) && !converter.findCorrespondingViewText( node ) ) {
  1467. return false;
  1468. }
  1469. }
  1470. return true;
  1471. }
  1472. } );
  1473. } );
  1474. function renderAndExpectNoChanges( renderer, domRoot ) {
  1475. const config = {
  1476. childList: true,
  1477. characterData: true,
  1478. characterDataOldValue: true,
  1479. subtree: true
  1480. };
  1481. const mutationObserver = new window.MutationObserver( () => {
  1482. throw 'There should be not mutations';
  1483. } );
  1484. mutationObserver.observe( domRoot, config );
  1485. renderer.render();
  1486. const records = mutationObserver.takeRecords();
  1487. mutationObserver.disconnect();
  1488. expect( records.length ).to.equal( 0 );
  1489. }