浏览代码

Reduced max number of visible fake panels to 2.

Oskar Wróbel 6 年之前
父节点
当前提交
ffa0574021

+ 1 - 1
packages/ckeditor5-ui/src/panel/balloon/contextualballoon.js

@@ -415,7 +415,7 @@ export default class ContextualBalloon extends Plugin {
 		const view = new FakePanelsView( this.editor.locale, this.view );
 
 		view.bind( 'numberOfPanels' ).to( this, '_numberOfStacks', number => {
-			return number < 2 ? 0 : Math.min( number - 1, 3 );
+			return number < 2 ? 0 : Math.min( number - 1, 2 );
 		} );
 
 		view.listenTo( this.view, 'change:top', () => view.updatePosition() );

+ 2 - 16
packages/ckeditor5-ui/tests/panel/balloon/contextualballoon.js

@@ -858,10 +858,9 @@ describe( 'ContextualBalloon', () => {
 			expect( fakePanelsView.element.childElementCount ).to.equal( 0 );
 		} );
 
-		it( 'should show fake panels when more than one stack is added to the balloon (max to 3 panels)', () => {
+		it( 'should show fake panels when more than one stack is added to the balloon (max to 2 panels)', () => {
 			const fakePanelsView = editor.ui.view.body.last;
 			const viewD = new View();
-			const viewE = new View();
 
 			balloon.add( {
 				view: viewB,
@@ -885,20 +884,7 @@ describe( 'ContextualBalloon', () => {
 			} );
 
 			expect( fakePanelsView.element.classList.contains( 'ck-hidden' ) ).to.equal( false );
-			expect( fakePanelsView.element.childElementCount ).to.equal( 3 );
-
-			balloon.add( {
-				view: viewE,
-				stackId: 'fifth'
-			} );
-
-			expect( fakePanelsView.element.classList.contains( 'ck-hidden' ) ).to.equal( false );
-			expect( fakePanelsView.element.childElementCount ).to.equal( 3 );
-
-			balloon.remove( viewE );
-
-			expect( fakePanelsView.element.classList.contains( 'ck-hidden' ) ).to.equal( false );
-			expect( fakePanelsView.element.childElementCount ).to.equal( 3 );
+			expect( fakePanelsView.element.childElementCount ).to.equal( 2 );
 
 			balloon.remove( viewD );