Forráskód Böngészése

Tests: updated Selection tests.

Szymon Cofalik 10 éve
szülő
commit
fbb3857e20
1 módosított fájl, 70 hozzáadás és 54 törlés
  1. 70 54
      packages/ckeditor5-engine/tests/treemodel/selection.js

+ 70 - 54
packages/ckeditor5-engine/tests/treemodel/selection.js

@@ -9,6 +9,7 @@
 
 const modules = bender.amd.require(
 	'treemodel/document',
+	'treemodel/element',
 	'treemodel/range',
 	'treemodel/position',
 	'treemodel/liverange',
@@ -18,10 +19,11 @@ const modules = bender.amd.require(
 );
 
 describe( 'Selection', () => {
-	let Document, Range, Position, LiveRange, Selection, InsertOperation, MoveOperation;
+	let Document, Element, Range, Position, LiveRange, Selection, InsertOperation, MoveOperation;
 
 	before( () => {
 		Document = modules[ 'treemodel/document' ];
+		Element = modules[ 'treemodel/element' ];
 		Range = modules[ 'treemodel/range' ];
 		Position = modules[ 'treemodel/position' ];
 		LiveRange = modules[ 'treemodel/liverange' ];
@@ -30,25 +32,25 @@ describe( 'Selection', () => {
 		MoveOperation = modules[ 'treemodel/operation/moveoperation' ];
 	} );
 
-	let doc, root, selection, range1, range2;
+	let doc, root, selection, liveRange, range;
 
 	beforeEach( () => {
 		doc = new Document();
 		root = doc.createRoot( 'root' );
 		selection = new Selection();
 
-		range1 = new LiveRange( new Position( root, [ 0 ] ), new Position( root, [ 1 ] ) );
-		range2 = new LiveRange( new Position( root, [ 2 ] ), new Position( root, [ 2, 2 ] ) );
+		liveRange = new LiveRange( new Position( root, [ 0 ] ), new Position( root, [ 1 ] ) );
+		range = new Range( new Position( root, [ 2 ] ), new Position( root, [ 2, 2 ] ) );
 	} );
 
 	afterEach( () => {
 		selection.detach();
-		range1.detach();
-		range2.detach();
+		liveRange.detach();
 	} );
 
 	it( 'should not have any range, anchor or focus position when just created', () => {
 		let ranges = selection.getRanges();
+
 		expect( ranges.length ).to.equal( 0 );
 		expect( selection.anchor ).to.be.null;
 		expect( selection.focus ).to.be.null;
@@ -63,7 +65,7 @@ describe( 'Selection', () => {
 	} );
 
 	it( 'should not be collapsed when it has a range that is not collapsed', () => {
-		selection.addRange( range1 );
+		selection.addRange( liveRange );
 
 		expect( selection.isCollapsed ).to.be.false;
 
@@ -72,63 +74,74 @@ describe( 'Selection', () => {
 		expect( selection.isCollapsed ).to.be.false;
 	} );
 
-	it( 'should store multiple ranges', () => {
-		selection.addRange( range1 );
-		selection.addRange( range2 );
+	it( 'should copy added ranges and store multiple ranges', () => {
+		selection.addRange( liveRange );
+		selection.addRange( range );
 
 		let ranges = selection.getRanges();
 
 		expect( ranges.length ).to.equal( 2 );
-		expect( ranges[ 0 ] ).to.equal( range1 );
-		expect( ranges[ 1 ] ).to.equal( range2 );
+		expect( ranges[ 0 ].isEqual( liveRange ) ).to.be.true;
+		expect( ranges[ 1 ].isEqual( range ) ).to.be.true;
+		expect( ranges[ 0 ] ).not.to.be.equal( liveRange );
+		expect( ranges[ 1 ] ).not.to.be.equal( range );
 	} );
 
 	it( 'should set anchor and focus to the start and end of the most recently added range', () => {
-		selection.addRange( range1 );
+		selection.addRange( liveRange );
 
 		expect( selection.anchor.path ).to.deep.equal( [ 0 ] );
 		expect( selection.focus.path ).to.deep.equal( [ 1 ] );
 
-		selection.addRange( range2 );
+		selection.addRange( range );
 
 		expect( selection.anchor.path ).to.deep.equal( [ 2 ] );
 		expect( selection.focus.path ).to.deep.equal( [ 2, 2 ] );
 	} );
 
 	it( 'should set anchor and focus to the end and start of the most recently added range if backward flag was used', () => {
-		selection.addRange( range1, true );
+		selection.addRange( liveRange, true );
 
 		expect( selection.anchor.path ).to.deep.equal( [ 1 ] );
 		expect( selection.focus.path ).to.deep.equal( [ 0 ] );
 
-		selection.addRange( range2, true );
+		selection.addRange( range, true );
 
 		expect( selection.anchor.path ).to.deep.equal( [ 2, 2 ] );
 		expect( selection.focus.path ).to.deep.equal( [ 2 ] );
 	} );
 
+	it( 'should return a copy of (not a reference to) array of stored ranges', () => {
+		selection.addRange( liveRange );
+
+		let ranges = selection.getRanges();
+
+		selection.addRange( range );
+
+		expect( ranges.length ).to.equal( 1 );
+		expect( ranges[ 0 ].isEqual( liveRange ) ).to.be.true;
+	} );
+
 	it( 'should convert added Range to LiveRange', () => {
-		let range = new Range( new Position( root, [ 0 ] ), new Position( root, [ 1 ] ) );
 		selection.addRange( range );
 
 		let ranges = selection.getRanges();
 
 		expect( ranges[ 0 ] ).to.be.instanceof( LiveRange );
-		expect( ranges[ 0 ].isEqual( range ) ).to.be.true;
 	} );
 
 	it( 'should fire update event when adding a range', () => {
 		let spy = sinon.spy();
 		selection.on( 'update', spy );
 
-		selection.addRange( range1 );
+		selection.addRange( range );
 
 		expect( spy.called ).to.be.true;
 	} );
 
 	it( 'should unbind all events when detached', () => {
-		selection.addRange( range1 );
-		selection.addRange( new Range( new Position( root, [ 3 ] ), new Position( root, [ 4 ] ) ) );
+		selection.addRange( liveRange );
+		selection.addRange( range );
 
 		let ranges = selection.getRanges();
 
@@ -145,30 +158,30 @@ describe( 'Selection', () => {
 	} );
 
 	describe( 'removeAllRanges', () => {
-		let spy;
+		let spy, ranges;
 
 		beforeEach( () => {
-			selection.addRange( range1 );
-			selection.addRange( range2 );
+			selection.addRange( liveRange );
+			selection.addRange( range );
 
 			spy = sinon.spy();
 			selection.on( 'update', spy );
 
-			sinon.spy( range1, 'detach' );
-			sinon.spy( range2, 'detach' );
+			ranges = selection.getRanges();
+
+			sinon.spy( ranges[ 0 ], 'detach' );
+			sinon.spy( ranges[ 1 ], 'detach' );
 
 			selection.removeAllRanges();
 		} );
 
 		afterEach( () => {
-			range1.detach.restore();
-			range2.detach.restore();
+			ranges[ 0 ].detach.restore();
+			ranges[ 1 ].detach.restore();
 		} );
 
 		it( 'should remove all stored ranges', () => {
-			let ranges = selection.getRanges();
-
-			expect( ranges.length ).to.equal( 0 );
+			expect( selection.getRanges().length ).to.equal( 0 );
 			expect( selection.anchor ).to.be.null;
 			expect( selection.focus ).to.be.null;
 			expect( selection.isCollapsed ).to.be.true;
@@ -178,68 +191,71 @@ describe( 'Selection', () => {
 			expect( spy.calledOnce ).to.be.true;
 		} );
 
-		it( 'should detach removed LiveRanges', () => {
-			expect( range1.detach.called ).to.be.true;
-			expect( range2.detach.called ).to.be.true;
+		it( 'should detach removed ranges', () => {
+			expect( ranges[ 0 ].detach.called ).to.be.true;
+			expect( ranges[ 1 ].detach.called ).to.be.true;
 		} );
 	} );
 
 	describe( 'setRanges', () => {
-		let newRanges, spy;
+		let newRanges, spy, oldRanges;
 
 		before( () => {
 			newRanges = [
-				new LiveRange( new Position( root, [ 4 ] ), new Position( root, [ 5 ] ) ),
-				new LiveRange( new Position( root, [ 5, 0 ] ), new Position( root, [ 6, 0 ] ) )
+				new Range( new Position( root, [ 4 ] ), new Position( root, [ 5 ] ) ),
+				new Range( new Position( root, [ 5, 0 ] ), new Position( root, [ 6, 0 ] ) )
 			];
 		} );
 
 		beforeEach( () => {
-			selection.addRange( range1 );
-			selection.addRange( range2 );
+			selection.addRange( liveRange );
+			selection.addRange( range );
 
 			spy = sinon.spy();
 			selection.on( 'update', spy );
 
-			sinon.spy( range1, 'detach' );
-			sinon.spy( range2, 'detach' );
+			oldRanges = selection.getRanges();
+
+			sinon.spy( oldRanges[ 0 ], 'detach' );
+			sinon.spy( oldRanges[ 1 ], 'detach' );
 		} );
 
 		afterEach( () => {
-			range1.detach.restore();
-			range2.detach.restore();
+			oldRanges[ 0 ].detach.restore();
+			oldRanges[ 1 ].detach.restore();
 		} );
 
 		it( 'should remove all ranges and add given ranges', () => {
 			selection.setRanges( newRanges );
+
 			let ranges = selection.getRanges();
 
 			expect( ranges.length ).to.equal( 2 );
-			expect( ranges[ 0 ] ).to.equal( newRanges[ 0 ] );
-			expect( ranges[ 1 ] ).to.equal( newRanges[ 1 ] );
+			expect( ranges[ 0 ].isEqual( newRanges[ 0 ] ) ).to.be.true;
+			expect( ranges[ 1 ].isEqual( newRanges[ 1 ] ) ).to.be.true;
 		} );
 
 		it( 'should use last range from given array to get anchor and focus position', () => {
 			selection.setRanges( newRanges );
-
 			expect( selection.anchor.path ).to.deep.equal( [ 5, 0 ] );
 			expect( selection.focus.path ).to.deep.equal( [ 6, 0 ] );
 		} );
 
 		it( 'should acknowledge backward flag when setting anchor and focus', () => {
 			selection.setRanges( newRanges, true );
-
 			expect( selection.anchor.path ).to.deep.equal( [ 6, 0 ] );
 			expect( selection.focus.path ).to.deep.equal( [ 5, 0 ] );
 		} );
 
 		it( 'should fire exactly one update event', () => {
+			selection.setRanges( newRanges );
 			expect( spy.calledOnce ).to.be.true;
 		} );
 
 		it( 'should detach removed LiveRanges', () => {
-			expect( range1.detach.called ).to.be.true;
-			expect( range2.detach.called ).to.be.true;
+			selection.setRanges( newRanges );
+			expect( oldRanges[ 0 ].detach.called ).to.be.true;
+			expect( oldRanges[ 1 ].detach.called ).to.be.true;
 		} );
 	} );
 
@@ -251,7 +267,7 @@ describe( 'Selection', () => {
 		beforeEach( () => {
 			root.insertChildren( 0, [ new Element( 'ul', [], 'abcdef' ), new Element( 'p', [], 'foobar' ), 'xyz' ] );
 
-			selection.addRange( new LiveRange( new Position( root, [ 0, 2 ] ), new Position( root, [ 1, 4 ] ) ) );
+			selection.addRange( new Range( new Position( root, [ 0, 2 ] ), new Position( root, [ 1, 4 ] ) ) );
 
 			spy = sinon.spy();
 			selection.on( 'update', spy );
@@ -338,7 +354,7 @@ describe( 'Selection', () => {
 
 				let range = selection.getRanges()[ 0 ];
 
-				expect( range.start.path ).to.deep.equal( [ 0, 4 ] );
+				expect( range.start.path ).to.deep.equal( [ 0, 2 ] );
 				expect( range.end.path ).to.deep.equal( [ 1, 2 ] );
 				expect( spy.called ).to.be.false;
 			} );
@@ -355,7 +371,7 @@ describe( 'Selection', () => {
 
 				let range = selection.getRanges()[ 0 ];
 
-				expect( range.start.path ).to.deep.equal( [ 0, 4 ] );
+				expect( range.start.path ).to.deep.equal( [ 0, 2 ] );
 				expect( range.end.path ).to.deep.equal( [ 1, 3 ] );
 				expect( spy.called ).to.be.false;
 			} );
@@ -380,8 +396,8 @@ describe( 'Selection', () => {
 
 				let range = selection.getRanges()[ 0 ];
 
-				expect( range.start.path ).to.deep.equal( [ 0, 4 ] );
-				expect( range.end.path ).to.deep.equal( [ 1, 2 ] );
+				expect( range.start.path ).to.deep.equal( [ 0, 2 ] );
+				expect( range.end.path ).to.deep.equal( [ 2, 2 ] );
 				expect( spy.called ).to.be.false;
 			} );
 		} );