Forráskód Böngészése

Docs (image): Added some extra documentation on what the code is doing.

Marek Lewandowski 5 éve
szülő
commit
f835a333d6

+ 4 - 1
packages/ckeditor5-image/src/imageresize/imageresizehandles.js

@@ -91,12 +91,15 @@ export default class ImageResizeHandles extends Plugin {
 	}
 
 	/**
+	 * Function to add listeners that will hide the resizer frame until the image is loaded,
+	 * to avoid [resize frame flashing when the image is not yet loaded](https://github.com/ckeditor/ckeditor5/issues/8088).
+	 *
 	 * @private
 	 * @param {module:widget/widgetresize/resizer~Resizer} resizer
 	 * @param {module:engine/view/containerelement~ContainerElement} widget
 	 */
 	_hideResizerUntilImageIsLoaded( resizer, widget ) {
-		// Mitigation logic for #8088 (which is caused by a more complex problem #7548).
+		// Given that #7548 is fixed, this logic might no longer be needed.
 		const editingView = this.editor.editing.view;
 
 		editingView.change( writer => {

+ 1 - 0
packages/ckeditor5-image/theme/imageresize.css

@@ -25,6 +25,7 @@
 }
 
 .ck-focused .ck-widget_with-resizer.ck-widget_selected.image.image_resizer_loading > .ck-widget__resizer {
+	/* Style to avoid resizer border flicker when the image is not yet uploaded (#8088). */
 	display: none;
 }