Selaa lähdekoodia

Minor fixes in image alternate text.

Szymon Kupś 9 vuotta sitten
vanhempi
commit
f4340b141c

+ 3 - 3
packages/ckeditor5-image/src/imagealternatetext/imagealternatetext.js

@@ -13,7 +13,7 @@ import ImageAlternateTextEngine from './imagealternatetextengine';
 import escPressHandler from '@ckeditor/ckeditor5-ui/src/bindings/escpresshandler';
 import ImageToolbar from '../imagetoolbar';
 import AlternateTextFormView from './ui/alternatetextformview';
-import ImageBalloonPanel from '../ui/imageballoonpanel';
+import ImageBalloonPanel from '../ui/imageballoonpanelview';
 
 import alternateTextIcon from '@ckeditor/ckeditor5-core/theme/icons/input.svg';
 import '../../theme/imagealternatetext/theme.scss';
@@ -41,7 +41,7 @@ export default class ImageAlternateText extends Plugin {
 			/**
 			 * Balloon panel containing alternate text change form.
 			 *
-			 * @member {module:image/ui/imageballoonpanel~ImageBalloonPanel} #baloonPanel
+			 * @member {module:image/ui/imageballoonpanel~ImageBalloonPanelView} #baloonPanel
 			 */
 			this.balloonPanel = panel;
 
@@ -86,7 +86,7 @@ export default class ImageAlternateText extends Plugin {
 	 * Creates balloon panel.
 	 *
 	 * @private
-	 * @return {Promise.<module:image/ui/imageballoonpanel~ImageBalloonPanel>}
+	 * @return {Promise.<module:image/ui/imageballoonpanel~ImageBalloonPanelView>}
 	 */
 	_createBalloonPanel() {
 		const editor = this.editor;

+ 6 - 5
packages/ckeditor5-image/src/imagealternatetext/ui/alternatetextformview.js

@@ -26,6 +26,8 @@ export default class AlternateTextFormView extends View {
 	constructor( locale ) {
 		super( locale );
 
+		const t = this.locale.t;
+
 		/**
 		 * Text area with label.
 		 *
@@ -38,7 +40,7 @@ export default class AlternateTextFormView extends View {
 		 *
 		 * @member {module:ui/button/buttonview~ButtonView} #saveButtonView
 		 */
-		this.saveButtonView = this._createButton( 'Ok' );
+		this.saveButtonView = this._createButton( t( 'Save' ) );
 		this.saveButtonView.type = 'submit';
 
 		/**
@@ -46,7 +48,7 @@ export default class AlternateTextFormView extends View {
 		 *
 		 * @member {module:ui/button/buttonview~ButtonView} #cancelButtonView
 		 */
-		this.cancelButtonView = this._createButton( 'Cancel', 'cancel' );
+		this.cancelButtonView = this._createButton( t( 'Cancel' ), 'cancel' );
 
 		// Register child views.
 		this.addChildren( [ this.saveButtonView ] );
@@ -93,7 +95,7 @@ export default class AlternateTextFormView extends View {
 	}
 
 	/**
-	 * Creates button View.
+	 * Creates button view.
 	 *
 	 * @private
 	 * @param {String} label Button label
@@ -101,10 +103,9 @@ export default class AlternateTextFormView extends View {
 	 * @returns {module:ui/button/buttonview~ButtonView} Button view instance.
 	 */
 	_createButton( label, eventName ) {
-		const t = this.locale.t;
 		const button = new ButtonView( this.locale );
 
-		button.label = t( label );
+		button.label = label;
 		button.withText = true;
 
 		if ( eventName ) {

+ 1 - 1
packages/ckeditor5-image/src/imagetoolbar.js

@@ -11,7 +11,7 @@ import Template from '@ckeditor/ckeditor5-ui/src/template';
 import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
 import ToolbarView from '@ckeditor/ckeditor5-ui/src/toolbar/toolbarview';
 import { isImageWidget } from './utils';
-import ImageBalloonPanel from './ui/imageballoonpanel';
+import ImageBalloonPanel from './ui/imageballoonpanelview';
 
 /**
  * Image toolbar class. Creates image toolbar placed inside balloon panel that is showed when image widget is selected.

+ 1 - 1
packages/ckeditor5-image/src/ui/imageballoonpanel.js

@@ -44,7 +44,7 @@ const positions = {
  *
  * @extends module:ui/balloonpanel/balloonpanelview~BalloonPanelView
  */
-export default class ImageBalloonPanel extends BalloonPanelView {
+export default class ImageBalloonPanelView extends BalloonPanelView {
 	/**
 	 * @inheritDoc
 	 */

+ 1 - 1
packages/ckeditor5-image/tests/imagetoolbar.js

@@ -7,7 +7,7 @@ import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classic';
 import ImageToolbar from '../src/imagetoolbar';
 import Image from '../src/image';
 import global from '@ckeditor/ckeditor5-utils/src/dom/global';
-import ImageBalloonPanel from '../src/ui/imageballoonpanel';
+import ImageBalloonPanel from '../src/ui/imageballoonpanelview';
 import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
 import ButtonView from '@ckeditor/ckeditor5-ui/src/button/buttonview';
 import { setData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';

+ 1 - 1
packages/ckeditor5-image/tests/ui/imageballoonpanel.js

@@ -7,7 +7,7 @@
 
 import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classic';
 import global from '@ckeditor/ckeditor5-utils/src/dom/global';
-import ImageBalloonPanel from '../../src/ui/imageballoonpanel';
+import ImageBalloonPanel from '../../src/ui/imageballoonpanelview';
 import BalloonPanelView from '@ckeditor/ckeditor5-ui/src/balloonpanel/balloonpanelview';
 import ImageEngine from '../../src/imageengine';
 import { setData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';