Browse Source

Refactoring, code style fixes.

Szymon Kupś 9 years ago
parent
commit
f08d1eda29

+ 2 - 2
packages/ckeditor5-image/src/image.js

@@ -32,7 +32,7 @@ export default class Image extends Feature {
 
 		// If mouse down is pressed create selection over whole view element.
 		viewDocument.addObserver( MouseDownObserver );
-		this.listenTo( viewDocument, 'mousedown', this._onMouseDown, { context: this } );
+		this.listenTo( viewDocument, 'mousedown', ( ...args ) => this._onMousedown( ...args ) );
 	}
 
 	/**
@@ -43,7 +43,7 @@ export default class Image extends Feature {
 	 * @param {utils.EventInfo} eventInfo
 	 * @param {envine.view.observer.DomEventData} domEventData
 	 */
-	_onMouseDown( eventInfo, domEventData ) {
+	_onMousedown( eventInfo, domEventData ) {
 		const target = domEventData.target;
 		const viewDocument = this.editor.editing.view;
 

+ 1 - 1
packages/ckeditor5-image/src/mousedownobserver.js

@@ -35,6 +35,6 @@ export default class MouseDownObserver extends DomEventObserver {
  * to {@link engine.view.Document} by a {@link engine.view.Document#addObserver} method.
  *
  * @see image.MouseDownObserver
- * @event engine.view.Document#click
+ * @event engine.view.Document#mousedown
  * @param {engine.view.observer.DomEventData} data Event data.
  */

+ 6 - 6
packages/ckeditor5-image/tests/image.js

@@ -22,12 +22,12 @@ describe( 'Image', () => {
 		return ClassicTestEditor.create( editorElement, {
 			features: [ Image, Paragraph ]
 		} )
-			.then( newEditor => {
-				editor = newEditor;
-				document = editor.document;
-				viewDocument = editor.editing.view;
-				imageFeature = editor.plugins.get( Image );
-			} );
+		.then( newEditor => {
+			editor = newEditor;
+			document = editor.document;
+			viewDocument = editor.editing.view;
+			imageFeature = editor.plugins.get( Image );
+		} );
 	} );
 
 	it( 'should be loaded', () => {

+ 3 - 3
packages/ckeditor5-image/tests/manual/image.md

@@ -3,6 +3,6 @@
 
 ## Image feature
 
- - Two images with CKEditor logo should be loaded.
- - Hovering over image should apply yellow outline.
- - Clicking on image should apply blue outline which should not change when hovering over.
+* Two images with CKEditor logo should be loaded.
+* Hovering over image should apply yellow outline.
+* Clicking on image should apply blue outline which should not change when hovering over.

+ 18 - 14
packages/ckeditor5-image/theme/theme.scss

@@ -1,17 +1,21 @@
-figure {
-	&.ck-widget.image {
-		text-align: center;
+//figure {
+//	&.ck-widget.image {
+//		text-align: center;
+//
+//		img {
+//			pointer-events: none;
+//		}
+//
+//		&.ck-widget_selected img, &.ck-widget_selected:hover img{
+//			outline: 2px solid #ace;
+//		}
+//
+//		&:hover img {
+//			outline: 2px solid yellow;
+//		}
+//	}
+//}
 
-		img {
-			pointer-events: none;
-		}
+.ck-widget {
 
-		&.ck-widget_selected img, &.ck-widget_selected:hover img{
-			outline: 2px solid #ace;
-		}
-
-		&:hover img {
-			outline: 2px solid yellow;
-		}
-	}
 }