Bläddra i källkod

Do not remove basic options from DataController#get config.

Oskar Wróbel 5 år sedan
förälder
incheckning
ef301bb2cf

+ 0 - 3
packages/ckeditor5-engine/src/controller/datacontroller.js

@@ -157,9 +157,6 @@ export default class DataController {
 	get( options = {} ) {
 		const { rootName = 'main', trim = 'empty' } = options;
 
-		delete options.rootName;
-		delete options.trim;
-
 		if ( !this._checkIfRootsExists( [ rootName ] ) ) {
 			/**
 			 * Cannot get data from a non-existing root. This error is thrown when {@link #get DataController#get() method}

+ 0 - 17
packages/ckeditor5-engine/tests/controller/datacontroller.js

@@ -530,23 +530,6 @@ describe( 'DataController', () => {
 			expect( data.get( { skipMarker: false } ) ).to.equal( '<p>f<marker>o</marker>o</p>' );
 			expect( data.get( { skipMarker: true } ) ).to.equal( '<p>foo</p>' );
 		} );
-
-		it( 'should provide additional options for retrieving data without basic rootName and trim properties', () => {
-			downcastHelpers.elementToElement( { model: 'paragraph', view: 'p' } );
-			schema.register( 'paragraph', { inheritAllFrom: '$block' } );
-
-			const spy = sinon.spy();
-
-			data.downcastDispatcher.on( 'insert:paragraph', ( evt, data, conversionApi ) => {
-				spy( conversionApi.options );
-			}, { priority: 'high' } );
-
-			setData( model, '<paragraph>foo</paragraph>' );
-
-			data.get( { rootName: 'main', trim: 'empty', foo: 'bar' } );
-
-			expect( spy.lastCall.args[ 0 ] ).to.deep.equal( { foo: 'bar' } );
-		} );
 	} );
 
 	describe( 'stringify()', () => {