8
0
Просмотр исходного кода

Make `externalElement` protected property instead of public one.

Krzysztof Krztoń 7 лет назад
Родитель
Сommit
eef5791778

+ 7 - 6
packages/ckeditor5-ui/src/editableui/editableuiview.js

@@ -67,9 +67,10 @@ export default class EditableUIView extends View {
 		 * An external {@link #editableElement} passed into the constructor, which also means
 		 * An external {@link #editableElement} passed into the constructor, which also means
 		 * the view will not render its {@link #template}.
 		 * the view will not render its {@link #template}.
 		 *
 		 *
-		 * @member {HTMLElement} #externalElement
+		 * @protected
+		 * @member {HTMLElement} #_externalElement
 		 */
 		 */
-		this.externalElement = editableElement;
+		this._externalElement = editableElement;
 
 
 		/**
 		/**
 		 * The element which is the main editable element (usually the one with `contentEditable="true"`).
 		 * The element which is the main editable element (usually the one with `contentEditable="true"`).
@@ -86,8 +87,8 @@ export default class EditableUIView extends View {
 	render() {
 	render() {
 		super.render();
 		super.render();
 
 
-		if ( this.externalElement ) {
-			this.template.apply( this.element = this.externalElement );
+		if ( this._externalElement ) {
+			this.template.apply( this.element = this._externalElement );
 		} else {
 		} else {
 			this.editableElement = this.element;
 			this.editableElement = this.element;
 		}
 		}
@@ -97,8 +98,8 @@ export default class EditableUIView extends View {
 	 * @inheritDoc
 	 * @inheritDoc
 	 */
 	 */
 	destroy() {
 	destroy() {
-		if ( this.externalElement ) {
-			this.template.revert( this.externalElement );
+		if ( this._externalElement ) {
+			this.template.revert( this._externalElement );
 		}
 		}
 
 
 		super.destroy();
 		super.destroy();

+ 3 - 3
packages/ckeditor5-ui/tests/editableui/editableuiview.js

@@ -27,7 +27,7 @@ describe( 'EditableUIView', () => {
 		it( 'sets initial values of attributes', () => {
 		it( 'sets initial values of attributes', () => {
 			expect( view.isReadOnly ).to.be.false;
 			expect( view.isReadOnly ).to.be.false;
 			expect( view.isFocused ).to.be.false;
 			expect( view.isFocused ).to.be.false;
-			expect( view.externalElement ).to.be.undefined;
+			expect( view._externalElement ).to.be.undefined;
 		} );
 		} );
 
 
 		it( 'renders element from template when no editableElement', () => {
 		it( 'renders element from template when no editableElement', () => {
@@ -39,7 +39,7 @@ describe( 'EditableUIView', () => {
 			expect( view.element.classList.contains( 'ck-editor__editable' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-editor__editable' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-content' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-content' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-rounded-corners' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-rounded-corners' ) ).to.be.true;
-			expect( view.externalElement ).to.be.undefined;
+			expect( view._externalElement ).to.be.undefined;
 			expect( view.isRendered ).to.be.true;
 			expect( view.isRendered ).to.be.true;
 		} );
 		} );
 
 
@@ -52,7 +52,7 @@ describe( 'EditableUIView', () => {
 			expect( view.element.classList.contains( 'ck' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-editor__editable' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-editor__editable' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-rounded-corners' ) ).to.be.true;
 			expect( view.element.classList.contains( 'ck-rounded-corners' ) ).to.be.true;
-			expect( view.externalElement ).to.equal( editableElement );
+			expect( view._externalElement ).to.equal( editableElement );
 			expect( view.isRendered ).to.be.true;
 			expect( view.isRendered ).to.be.true;
 		} );
 		} );
 	} );
 	} );