Przeglądaj źródła

Rename DowncastDispatcher#mapReconversionTriggerEvent to _mapReconversionTriggerEvent() as it is a protected method.

Maciej Gołaszewski 5 lat temu
rodzic
commit
e8921b6e46

+ 19 - 19
packages/ckeditor5-engine/src/conversion/downcastdispatcher.js

@@ -176,25 +176,6 @@ export default class DowncastDispatcher {
 	}
 
 	/**
-	 * Maps model element "insert" reconversion for given event names. The event names must be fully specified:
-	 *
-	 * * For "attribute" change event it should include main element name, ie: `'attribute:attributeName:elementName'`.
-	 * * For child nodes change events, those should use child event name as well, ie:
-	 *     * For adding a node: `'insert:childElementName'`.
-	 *     * For removing a node: `'remove:childElementName'`.
-	 *
-	 * **Note**: This method should not be used directly. A reconversion is defined by `triggerBy` attribute of the `elementToElement()`
-	 * conversion helper.
-	 *
-	 * @protected
-	 * @param {String} modelName Main model element name for which events will trigger reconversion.
-	 * @param {String} eventName Name of an event that would trigger conversion for given model element.
-	 */
-	mapReconversionTriggerEvent( modelName, eventName ) {
-		this._reconversionTriggerEventToElementNameMapping.set( eventName, modelName );
-	}
-
-	/**
 	 * Starts a conversion of a range insertion.
 	 *
 	 * For each node in the range, {@link #event:insert `insert` event is fired}. For each attribute on each node,
@@ -471,6 +452,25 @@ export default class DowncastDispatcher {
 	}
 
 	/**
+	 * Maps model element "insert" reconversion for given event names. The event names must be fully specified:
+	 *
+	 * * For "attribute" change event it should include main element name, ie: `'attribute:attributeName:elementName'`.
+	 * * For child nodes change events, those should use child event name as well, ie:
+	 *     * For adding a node: `'insert:childElementName'`.
+	 *     * For removing a node: `'remove:childElementName'`.
+	 *
+	 * **Note**: This method should not be used directly. A reconversion is defined by `triggerBy` configuration of the `elementToElement()`
+	 * conversion helper.
+	 *
+	 * @protected
+	 * @param {String} modelName Main model element name for which events will trigger reconversion.
+	 * @param {String} eventName Name of an event that would trigger conversion for given model element.
+	 */
+	_mapReconversionTriggerEvent( modelName, eventName ) {
+		this._reconversionTriggerEventToElementNameMapping.set( eventName, modelName );
+	}
+
+	/**
 	 * Creates {@link module:engine/conversion/modelconsumable~ModelConsumable} with values to consume from given range,
 	 * assuming that the range has just been inserted to the model.
 	 *

+ 3 - 3
packages/ckeditor5-engine/src/conversion/downcasthelpers.js

@@ -1370,14 +1370,14 @@ function downcastElementToElement( config ) {
 		if ( config.triggerBy ) {
 			if ( Array.isArray( config.triggerBy.attributes ) ) {
 				for ( const attributeKey of config.triggerBy.attributes ) {
-					dispatcher.mapReconversionTriggerEvent( config.model, `attribute:${ attributeKey }:${ config.model }` );
+					dispatcher._mapReconversionTriggerEvent( config.model, `attribute:${ attributeKey }:${ config.model }` );
 				}
 			}
 
 			if ( Array.isArray( config.triggerBy.children ) ) {
 				for ( const childName of config.triggerBy.children ) {
-					dispatcher.mapReconversionTriggerEvent( config.model, `insert:${ childName }` );
-					dispatcher.mapReconversionTriggerEvent( config.model, `remove:${ childName }` );
+					dispatcher._mapReconversionTriggerEvent( config.model, `insert:${ childName }` );
+					dispatcher._mapReconversionTriggerEvent( config.model, `remove:${ childName }` );
 				}
 			}
 		}