Sfoglia il codice sorgente

Added manual test for the media embed toolbar.

Maciej Bukowski 7 anni fa
parent
commit
e6c28c793e

+ 1 - 1
packages/ckeditor5-media-embed/src/mediaembedtoolbar.js

@@ -41,7 +41,7 @@ export default class MediaEmbedToolbar extends Plugin {
 		const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
 		const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
 
 
 		widgetToolbarRepository.register( 'mediaEmbed', {
 		widgetToolbarRepository.register( 'mediaEmbed', {
-			items: editor.config.get( 'media.toolbar' ) || [],
+			items: editor.config.get( 'mediaEmbed.toolbar' ) || [],
 			visibleWhen: isMediaWidgetSelected,
 			visibleWhen: isMediaWidgetSelected,
 		} );
 		} );
 	}
 	}

+ 4 - 2
packages/ckeditor5-media-embed/tests/manual/mediaembed.js

@@ -8,15 +8,17 @@
 import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
 import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
 import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset';
 import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset';
 import MediaEmbed from '../../src/mediaembed';
 import MediaEmbed from '../../src/mediaembed';
+import MediaEmbedToolbar from '../../src/mediaembedtoolbar';
 
 
 ClassicEditor
 ClassicEditor
 	.create( document.querySelector( '#editor' ), {
 	.create( document.querySelector( '#editor' ), {
-		plugins: [ ArticlePluginSet, MediaEmbed ],
+		plugins: [ ArticlePluginSet, MediaEmbed, MediaEmbedToolbar ],
 		toolbar: [
 		toolbar: [
 			'heading', '|', 'mediaEmbed', '|', 'bold', 'italic', 'bulletedList', 'numberedList', 'blockQuote', 'link', 'undo', 'redo'
 			'heading', '|', 'mediaEmbed', '|', 'bold', 'italic', 'bulletedList', 'numberedList', 'blockQuote', 'link', 'undo', 'redo'
 		],
 		],
 		mediaEmbed: {
 		mediaEmbed: {
-			mediaPreviewsInData: true
+			mediaPreviewsInData: true,
+			toolbar: [ 'blockQuote' ]
 		}
 		}
 	} )
 	} )
 	.then( editor => {
 	.then( editor => {

+ 7 - 0
packages/ckeditor5-media-embed/tests/manual/mediaembed.md

@@ -45,3 +45,10 @@
 1. Hover the URL in the content (the tooltip should show up),
 1. Hover the URL in the content (the tooltip should show up),
 1. Click the URL,
 1. Click the URL,
 1. A new browser tab should open with the media URL.
 1. A new browser tab should open with the media URL.
+
+### Media embed toolbar
+
+1. Click the media,
+1. The block quote button should be visible,
+1. Click the block quote button,
+1. The block quote should be applied to the media.

+ 1 - 1
packages/ckeditor5-media-embed/tests/mediaembedtoolbar.js

@@ -28,7 +28,7 @@ describe( 'MediaEmbedToolbar', () => {
 
 
 		return ClassicTestEditor.create( element, {
 		return ClassicTestEditor.create( element, {
 			plugins: [ Paragraph, MediaEmbed, MediaEmbedToolbar, FakeButton ],
 			plugins: [ Paragraph, MediaEmbed, MediaEmbedToolbar, FakeButton ],
-			media: {
+			mediaEmbed: {
 				toolbar: [ 'fake_button' ]
 				toolbar: [ 'fake_button' ]
 			}
 			}
 		} ).then( _editor => {
 		} ).then( _editor => {