Selaa lähdekoodia

Fixed test, so it passes with webpack@4.

Maciej Bukowski 7 vuotta sitten
vanhempi
commit
dc34cb8969

+ 9 - 1
packages/ckeditor5-ui/src/panel/balloon/balloonpanelview.js

@@ -234,7 +234,7 @@ export default class BalloonPanelView extends View {
 			fitInViewport: true
 		}, options );
 
-		const { top, left, name: position } = getOptimalPosition( positionOptions );
+		const { top, left, name: position } = BalloonPanelView._getOptimalPosition( positionOptions );
 
 		Object.assign( this, { top, left, position } );
 	}
@@ -416,6 +416,14 @@ BalloonPanelView.arrowHorizontalOffset = 25;
 BalloonPanelView.arrowVerticalOffset = 10;
 
 /**
+ * Function used to calculate the optimal position for the balloon.
+ *
+ * @protected
+ * @member {Function} module:ui/panel/balloon/balloonpanelview~BalloonPanelView._getOptimalPosition
+ */
+BalloonPanelView._getOptimalPosition = getOptimalPosition;
+
+/**
  * A default set of positioning functions used by the balloon panel view
  * when attaching using {@link module:ui/panel/balloon/balloonpanelview~BalloonPanelView#attachTo} method.
  *

+ 1 - 2
packages/ckeditor5-ui/tests/panel/balloon/balloonpanelview.js

@@ -9,7 +9,6 @@ import ViewCollection from '../../../src/viewcollection';
 import BalloonPanelView from '../../../src/panel/balloon/balloonpanelview';
 import ButtonView from '../../../src/button/buttonview';
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
-import * as positionUtils from '@ckeditor/ckeditor5-utils/src/dom/position';
 
 testUtils.createSinonSandbox();
 
@@ -173,7 +172,7 @@ describe( 'BalloonPanelView', () => {
 		} );
 
 		it( 'should use default options', () => {
-			const spy = testUtils.sinon.spy( positionUtils, 'getOptimalPosition' );
+			const spy = testUtils.sinon.spy( BalloonPanelView, '_getOptimalPosition' );
 
 			view.attachTo( { target } );