8
0
Просмотр исходного кода

Renamed Template#_rendered -> Template#_isRendered.

Aleksander Nowodzinski 8 лет назад
Родитель
Сommit
dbd99d2498
2 измененных файлов с 8 добавлено и 8 удалено
  1. 3 3
      packages/ckeditor5-ui/src/template.js
  2. 5 5
      packages/ckeditor5-ui/tests/template.js

+ 3 - 3
packages/ckeditor5-ui/src/template.js

@@ -64,7 +64,7 @@ export default class Template {
 		 * @protected
 		 * @member {Boolean}
 		 */
-		this._rendered = false;
+		this._isRendered = false;
 
 		/**
 		 * Tag of this template, i.e. `div`, indicating that the instance will render
@@ -114,7 +114,7 @@ export default class Template {
 	render() {
 		const node = this._renderNode( undefined, true );
 
-		this._rendered = true;
+		this._isRendered = true;
 
 		return node;
 	}
@@ -247,7 +247,7 @@ export default class Template {
 	 * @param {module:ui/template~TemplateDefinition} def An extension to existing an template instance.
 	 */
 	static extend( template, def ) {
-		if ( template._rendered ) {
+		if ( template._isRendered ) {
 			/**
 			 * Extending a template after rendering may not work as expected. To make sure
 			 * the {@link #extend extending} works for the rendered element, perform it

+ 5 - 5
packages/ckeditor5-ui/tests/template.js

@@ -24,8 +24,8 @@ let el, text;
 
 describe( 'Template', () => {
 	describe( 'constructor()', () => {
-		it( 'sets #_rendered property', () => {
-			expect( new Template( { tag: 'p' } )._rendered ).to.be.false;
+		it( 'sets #_isRendered property', () => {
+			expect( new Template( { tag: 'p' } )._isRendered ).to.be.false;
 		} );
 
 		it( 'accepts and normalizes the definition', () => {
@@ -138,14 +138,14 @@ describe( 'Template', () => {
 			} ).to.throw( CKEditorError, /ui-template-wrong-syntax/ );
 		} );
 
-		it( 'sets #_rendered true', () => {
+		it( 'sets #_isRendered true', () => {
 			const tpl = new Template( { tag: 'p' } );
 
-			expect( tpl._rendered ).to.be.false;
+			expect( tpl._isRendered ).to.be.false;
 
 			tpl.render();
 
-			expect( tpl._rendered ).to.be.true;
+			expect( tpl._isRendered ).to.be.true;
 		} );
 
 		describe( 'DOM Node', () => {