Browse Source

Apply suggestions from code review

Add the language fixes.

Co-Authored-By: Aleksander Nowodzinski <a.nowodzinski@cksource.com>

Maciej 5 years ago
parent
commit
d9e243e48f

+ 2 - 2
packages/ckeditor5-table/src/commands/utils.js

@@ -87,9 +87,9 @@ export function getSingleValue( objectOrString ) {
 }
 
 /**
- * Add a unit to a value if the value is a number or string with a number.
+ * Adds a unit to a value if the value is a number or a string representing a number.
  *
- * Does nothing to a non-numeric values.
+ * **Note**: It does nothing to non-numeric values.
  *
  *		getSingleValue( 25, 'px' );		// '25px'
  *		getSingleValue( 25, 'em' );		// '25em'

+ 2 - 2
packages/ckeditor5-table/src/tablecellproperties/commands/tablecellborderwidthcommand.js

@@ -22,13 +22,13 @@ import TableCellPropertyCommand from './tablecellpropertycommand';
  *			value: '5px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableCellBorderWidth', {
  *			value: '5'
  *		} );
  *
- * Will set `borderWidth` attribute to `'5px'` in the model.
+ * will set the `borderWidth` attribute to `'5px'` in the model.
  *
  * @extends module:core/command~Command
  */

+ 2 - 2
packages/ckeditor5-table/src/tablecellproperties/commands/tablecellheightcommand.js

@@ -22,13 +22,13 @@ import TableCellPropertyCommand from './tablecellpropertycommand';
  *			value: '50px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableCellHeight', {
  *			value: '50'
  *		} );
  *
- * Will set `height` attribute to `'50px'` in the model.
+ * will set the `height` attribute to `'50px'` in the model.
  *
  * @extends module:table/tablecellproperties/commands/tablecellpropertycommand
  */

+ 2 - 2
packages/ckeditor5-table/src/tablecellproperties/commands/tablecellpaddingcommand.js

@@ -22,13 +22,13 @@ import TableCellPropertyCommand from './tablecellpropertycommand';
  *			value: '5px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableCellPadding', {
  *			value: '5'
  *		} );
  *
- * Will set `padding` attribute to `'5px'` in the model.
+ * will set the `padding` attribute to `'5px'` in the model.
  * @extends module:table/tablecellproperties/commands/tablecellpropertycommand
  */
 export default class TableCellPaddingCommand extends TableCellPropertyCommand {

+ 1 - 1
packages/ckeditor5-table/src/tablecellproperties/commands/tablecellpropertycommand.js

@@ -89,7 +89,7 @@ export default class TableCellPropertyCommand extends Command {
 	}
 
 	/**
-	 * Returns proper model value. Can be used to add default unit to numeric values.
+	 * Returns the proper model value. Can be used to add a default unit to numeric values.
 	 *
 	 * @private
 	 * @param {*} value

+ 2 - 2
packages/ckeditor5-table/src/tableproperties/commands/tableborderwidthcommand.js

@@ -22,13 +22,13 @@ import TablePropertyCommand from './tablepropertycommand';
  *			value: '5px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableBorderWidth', {
  *			value: '5'
  *		} );
  *
- * Will set `borderWidth` attribute to `'5px'` in the model.
+ * Will set the `borderWidth` attribute to `'5px'` in the model.
  *
  * @extends module:table/tableproperties/commands/tablepropertycommand
  */

+ 2 - 2
packages/ckeditor5-table/src/tableproperties/commands/tableheightcommand.js

@@ -22,13 +22,13 @@ import { addDefaultUnitToNumericValue } from '../../commands/utils';
  *			value: '500px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableHeight', {
  *			value: '50'
  *		} );
  *
- * Will set `height` attribute to `'50px'` in the model.
+ * Will set the `height` attribute to `'50px'` in the model.
  *
  * @extends module:core/command~Command
  */

+ 1 - 1
packages/ckeditor5-table/src/tableproperties/commands/tablepropertycommand.js

@@ -88,7 +88,7 @@ export default class TablePropertyCommand extends Command {
 	}
 
 	/**
-	 * Returns proper model value. Can be used to add default unit to numeric values.
+	 * Returns the proper model value. Can be used to add a default unit to numeric values.
 	 *
 	 * @private
 	 * @param {*} value

+ 2 - 2
packages/ckeditor5-table/src/tableproperties/commands/tablewidthcommand.js

@@ -22,13 +22,13 @@ import TablePropertyCommand from './tablepropertycommand';
  *			value: '400px'
  *		} );
  *
- * **Note**: This command adds a default `'px'` unit to a numeric values. Executing:
+ * **Note**: This command adds the default `'px'` unit to numeric values. Executing:
  *
  *		editor.execute( 'tableWidth', {
  *			value: '50'
  *		} );
  *
- * Will set `width` attribute to `'50px'` in the model.
+ * Will set the `width` attribute to `'50px'` in the model.
  *
  * @extends module:table/tableproperties/commands/tablepropertycommand
  */