Explorar el Código

Renamed selectionDescriptorToAttribute to selectionDescriptorToAttributeElement.

Szymon Kupś hace 8 años
padre
commit
d9d222a52f

+ 2 - 2
packages/ckeditor5-engine/src/conversion/model-selection-to-view-converters.js

@@ -6,7 +6,7 @@
 import ViewElement from '../view/element';
 import ViewRange from '../view/range';
 import viewWriter from '../view/writer';
-import { virtualSelectionDescriptorToAttribute } from './model-to-view-converters';
+import { virtualSelectionDescriptorToAttributeElement } from './model-to-view-converters';
 
 /**
  * Contains {@link module:engine/model/selection~Selection model selection} to
@@ -176,7 +176,7 @@ export function convertSelectionMarker( selectionDescriptor ) {
 			return;
 		}
 
-		const viewElement = virtualSelectionDescriptorToAttribute( descriptor );
+		const viewElement = virtualSelectionDescriptorToAttributeElement( descriptor );
 		const consumableName = 'selectionMarker:' + data.name;
 
 		wrapCollapsedSelectionPosition( data.selection, conversionApi.viewSelection, viewElement, consumable, consumableName );

+ 2 - 2
packages/ckeditor5-engine/src/conversion/model-to-view-converters.js

@@ -412,7 +412,7 @@ export function markerToVirtualSelection( selectionDescriptor ) {
 		}
 
 		if ( modelItem.is( 'textProxy' ) ) {
-			const viewElement = virtualSelectionDescriptorToAttribute( descriptor );
+			const viewElement = virtualSelectionDescriptorToAttributeElement( descriptor );
 			const converter = addMarker ?
 				wrapItem( viewElement, eventName => eventName ) :
 				unwrapItem( viewElement, eventName => eventName );
@@ -524,7 +524,7 @@ export function eventNameToConsumableType( evtName ) {
  * @param {module:engine/conversion/buildmodelconverter~VirtualSelectionDescriptor }descriptor
  * @return {module:engine/view/attributeelement~AttributeElement}
  */
-export function virtualSelectionDescriptorToAttribute( descriptor ) {
+export function virtualSelectionDescriptorToAttributeElement( descriptor ) {
 	const attributeElement = new ViewAttributeElement( 'span', descriptor.attributes );
 
 	if ( descriptor.class ) {

+ 6 - 6
packages/ckeditor5-engine/tests/conversion/model-to-view-converters.js

@@ -29,7 +29,7 @@ import {
 	remove,
 	removeUIElement,
 	markerToVirtualSelection,
-	virtualSelectionDescriptorToAttribute
+	virtualSelectionDescriptorToAttributeElement
 } from '../../src/conversion/model-to-view-converters';
 
 import { createRangeOnElementOnly } from '../../tests/model/_utils/utils';
@@ -1037,14 +1037,14 @@ describe( 'model-to-view-converters', () => {
 		} );
 	} );
 
-	describe( 'virtualSelectionDescriptorToAttribute()', () => {
+	describe( 'virtualSelectionDescriptorToAttributeElement()', () => {
 		it( 'should return attribute element from descriptor object', () => {
 			const descriptor = {
 				class: 'foo-class',
 				attributes: { one: 1, two: 2 },
 				priority: 7,
 			};
-			const element = virtualSelectionDescriptorToAttribute( descriptor );
+			const element = virtualSelectionDescriptorToAttributeElement( descriptor );
 
 			expect( element.is( 'attributeElement' ) ).to.be.true;
 			expect( element.name ).to.equal( 'span' );
@@ -1061,7 +1061,7 @@ describe( 'model-to-view-converters', () => {
 				attributes: { one: 1, two: 2 },
 				priority: 7,
 			};
-			const element = virtualSelectionDescriptorToAttribute( descriptor );
+			const element = virtualSelectionDescriptorToAttributeElement( descriptor );
 
 			expect( element.is( 'attributeElement' ) ).to.be.true;
 			expect( element.name ).to.equal( 'span' );
@@ -1077,7 +1077,7 @@ describe( 'model-to-view-converters', () => {
 				class: 'foo-class',
 				attributes: { one: 1, two: 2 },
 			};
-			const element = virtualSelectionDescriptorToAttribute( descriptor );
+			const element = virtualSelectionDescriptorToAttributeElement( descriptor );
 
 			expect( element.is( 'attributeElement' ) ).to.be.true;
 			expect( element.name ).to.equal( 'span' );
@@ -1094,7 +1094,7 @@ describe( 'model-to-view-converters', () => {
 				class: 'foo-class',
 				priority: 7
 			};
-			const element = virtualSelectionDescriptorToAttribute( descriptor );
+			const element = virtualSelectionDescriptorToAttributeElement( descriptor );
 
 			expect( element.is( 'attributeElement' ) ).to.be.true;
 			expect( element.name ).to.equal( 'span' );