浏览代码

Renamed imageLoad event to imageLoaded.

Oskar Wróbel 7 年之前
父节点
当前提交
d6aa2e7f21

+ 3 - 3
packages/ckeditor5-image/src/image/imageloadobserver.js

@@ -12,7 +12,7 @@ import DOMEmitterMixin from '@ckeditor/ckeditor5-utils/src/dom/emittermixin';
 
 /**
  * Observes all images added to the {@link module:engine/view/document~Document},
- * fires {@link module:engine/view/document~Document#event:imageLoad}` event and
+ * fires {@link module:engine/view/document~Document#event:imageLoaded}` event and
  * {@link module:engine/view/view~View#render renders} the View every time when new image
  * has been loaded.
  *
@@ -78,7 +78,7 @@ export default class ImageLoadObserver extends DomEventObserver {
 	 */
 	onDomEvent( domEvent ) {
 		this.view.render();
-		this.fire( 'imageLoad', domEvent );
+		this.fire( 'imageLoaded', domEvent );
 	}
 
 	/**
@@ -96,6 +96,6 @@ export default class ImageLoadObserver extends DomEventObserver {
  * Introduced by {@link module:image/image/imageloadobserver~ImageLoadObserver}.
  *
  * @see image/image/imageloadobserver~ImageLoadObserver
- * @event module:engine/view/document~Document#event:imageLoad
+ * @event module:engine/view/document~Document#event:imageLoaded
  * @param {module:engine/view/observer/domeventdata~DomEventData} data Event data.
  */

+ 6 - 6
packages/ckeditor5-image/tests/image/imageloadobserver.js

@@ -32,7 +32,7 @@ describe( 'ClickObserver', () => {
 	it( 'should fire `loadImage` event for images in the document that are loaded with a delay', () => {
 		const spy = sinon.spy();
 
-		viewDocument.on( 'imageLoad', spy );
+		viewDocument.on( 'imageLoaded', spy );
 
 		setData( view, '<img src="foo.png" />' );
 
@@ -46,7 +46,7 @@ describe( 'ClickObserver', () => {
 	it( 'should not fire `loadImage` event for images removed from document', () => {
 		const spy = sinon.spy();
 
-		viewDocument.on( 'imageLoad', spy );
+		viewDocument.on( 'imageLoaded', spy );
 
 		setData( view, '<img src="foo.png" />' );
 
@@ -81,16 +81,16 @@ describe( 'ClickObserver', () => {
 		sinon.assert.neverCalledWith( mapSpy, viewDiv );
 	} );
 
-	it( 'should call `view#render` along with `imageLoad` event', () => {
+	it( 'should call `view#render` along with `imageLoaded` event', () => {
 		const renderSpy = sinon.spy();
-		const imageLoadSpy = sinon.spy();
+		const imageLoadedSpy = sinon.spy();
 
 		view.on( 'render', renderSpy );
-		view.document.on( 'imageLoad', imageLoadSpy );
+		view.document.on( 'imageLoaded', imageLoadedSpy );
 
 		observer.onDomEvent( {} );
 
 		sinon.assert.calledOnce( renderSpy );
-		sinon.assert.calledOnce( imageLoadSpy );
+		sinon.assert.calledOnce( imageLoadedSpy );
 	} );
 } );