|
|
@@ -59,7 +59,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should create a widget toolbar and add it to the collection', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false,
|
|
|
+ whenVisible: () => false,
|
|
|
} );
|
|
|
|
|
|
expect( widgetToolbarRepository._toolbars.size ).to.equal( 1 );
|
|
|
@@ -69,13 +69,13 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should throw when adding two times widget with the same id', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
|
|
|
expect( () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
} ).to.throw( /widget-toolbar-duplicated/ );
|
|
|
} );
|
|
|
@@ -85,7 +85,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should remove given widget toolbar', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
|
|
|
widgetToolbarRepository.deregister( 'fake' );
|
|
|
@@ -96,7 +96,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should throw an error if a toolbar does not exist', () => {
|
|
|
widgetToolbarRepository.register( 'foo', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
|
|
|
expect( () => {
|
|
|
@@ -109,7 +109,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should return `true` when a toolbar with given id was added', () => {
|
|
|
widgetToolbarRepository.register( 'foo', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
|
|
|
expect( widgetToolbarRepository.isRegistered( 'foo' ) ).to.be.true;
|
|
|
@@ -118,7 +118,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'should return `false` when a toolbar with given id was not added', () => {
|
|
|
widgetToolbarRepository.register( 'foo', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: () => false
|
|
|
+ whenVisible: () => false
|
|
|
} );
|
|
|
|
|
|
expect( widgetToolbarRepository.isRegistered( 'bar' ) ).to.be.false;
|
|
|
@@ -130,10 +130,10 @@ describe( 'WidgetToolbar', () => {
|
|
|
editor.ui.focusTracker.isFocused = true;
|
|
|
} );
|
|
|
|
|
|
- it( 'toolbar should be visible when the `isVisible` callback returns true', () => {
|
|
|
+ it( 'toolbar should be visible when the `whenVisible` callback returns true', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '<paragraph>foo</paragraph>[<fake-widget></fake-widget>]' );
|
|
|
@@ -143,10 +143,10 @@ describe( 'WidgetToolbar', () => {
|
|
|
expect( balloon.visibleView ).to.equal( fakeWidgetToolbarView );
|
|
|
} );
|
|
|
|
|
|
- it( 'toolbar should be hidden when the `isVisible` callback returns false', () => {
|
|
|
+ it( 'toolbar should be hidden when the `whenVisible` callback returns false', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '[<paragraph>foo</paragraph>]<fake-widget></fake-widget>' );
|
|
|
@@ -154,10 +154,10 @@ describe( 'WidgetToolbar', () => {
|
|
|
expect( balloon.visibleView ).to.equal( null );
|
|
|
} );
|
|
|
|
|
|
- it( 'toolbar should be hidden when the `isVisible` callback returns false #2', () => {
|
|
|
+ it( 'toolbar should be hidden when the `whenVisible` callback returns false #2', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '<paragraph>foo</paragraph>[<fake-widget></fake-widget>]' );
|
|
|
@@ -173,7 +173,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'toolbar should update its position when other widget is selected', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '[<fake-widget></fake-widget>]<fake-widget></fake-widget>' );
|
|
|
@@ -191,7 +191,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'it should be possible to create a widget toolbar for content inside the widget', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetContentSelected
|
|
|
+ whenVisible: isFakeWidgetContentSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '<fake-widget>[foo]</fake-widget>' );
|
|
|
@@ -204,7 +204,7 @@ describe( 'WidgetToolbar', () => {
|
|
|
it( 'toolbar should not engage when is in the balloon yet invisible', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
const fakeWidgetToolbarView = widgetToolbarRepository._toolbars.get( 'fake' ).view;
|
|
|
@@ -270,7 +270,7 @@ describe( 'WidgetToolbarRepository - integration with the BalloonToolbar', () =>
|
|
|
it( 'balloon toolbar should be hidden when the widget is selected', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected,
|
|
|
+ whenVisible: isFakeWidgetSelected,
|
|
|
} );
|
|
|
|
|
|
const fakeWidgetToolbarView = widgetToolbarRepository._toolbars.get( 'fake' ).view;
|
|
|
@@ -285,7 +285,7 @@ describe( 'WidgetToolbarRepository - integration with the BalloonToolbar', () =>
|
|
|
it( 'balloon toolbar should be visible when the widget is not selected', () => {
|
|
|
widgetToolbarRepository.register( 'fake', {
|
|
|
toolbarItems: editor.config.get( 'fake.toolbar' ),
|
|
|
- isVisible: isFakeWidgetSelected
|
|
|
+ whenVisible: isFakeWidgetSelected
|
|
|
} );
|
|
|
|
|
|
setData( model, '<fake-widget></fake-widget><paragraph>[foo]</paragraph>' );
|