Browse Source

Fixed mistakes spotted on review.

Piotrek Koszuliński 6 years ago
parent
commit
ce13b6cecf

+ 7 - 1
packages/ckeditor5-engine/tests/tickets/5564.js

@@ -35,9 +35,15 @@ describe( 'Bug ckeditor5#5564', () => {
 	it( 'preserves a soft break in an empty paragraph', () => {
 		setModelData( editor.model, '<paragraph>x</paragraph><paragraph><softBreak /></paragraph><paragraph>x</paragraph>' );
 
-		expect( editor.getData() ).to.equal( '<p>x</p><p><br>&nbsp;</p><p>x</p>' );
+		const expectedData = '<p>x</p><p><br>&nbsp;</p><p>x</p>';
+		const actualData = editor.getData();
+
+		expect( actualData ).to.equal( expectedData );
 
 		// Loading this data into the editor will actually create an excessive space as &nbsp; here isn't recognized as a filler.
 		// It's a known issue.
+		editor.setData( actualData );
+
+		expect( editor.getData() ).to.equal( expectedData );
 	} );
 } );

+ 2 - 2
packages/ckeditor5-engine/tests/view/domconverter/domconverter.js

@@ -349,7 +349,7 @@ describe( 'DomConverter', () => {
 				const context = document.createElement( 'div' );
 				context.innerHTML = 'x<br>x';
 
-				expect( converter.isBlockFiller( context.firstChild ) ).to.be.false;
+				expect( converter.isBlockFiller( context.childNodes[ 1 ] ) ).to.be.false;
 			} );
 
 			// SPECIAL CASE (see ckeditor5#5564).
@@ -369,7 +369,7 @@ describe( 'DomConverter', () => {
 
 			it( 'should return false for a <br> element which is followed by an nbsp', () => {
 				const context = document.createElement( 'span' );
-				context.innerHTML = '&nbsp;';
+				context.innerHTML = '<br>&nbsp;';
 
 				expect( converter.isBlockFiller( context.firstChild ) ).to.be.false;
 			} );