8
0
Просмотр исходного кода

Changed: Delta#saveHistory became protected, changed how parameters are passed to it.

Szymon Cofalik 8 лет назад
Родитель
Сommit
ca3af894de

+ 16 - 14
packages/ckeditor5-engine/src/dev-utils/enableenginedebug.js

@@ -320,22 +320,18 @@ function enableLoggingTools() {
 		}
 	};
 
-	Delta.prototype.saveHistory = function( before, transformedBy, wasImportant, resultIndex, resultsTotal ) {
-		const history = before.history ? before.history : [];
+	Delta.prototype._saveHistory = function( itemToSave ) {
+		const history = itemToSave.before.history ? itemToSave.before.history : [];
 
-		const beforeClone = clone( before );
-		delete beforeClone.history;
+		itemToSave.before = clone( itemToSave.before );
+		delete itemToSave.before.history;
+		itemToSave.before = JSON.stringify( itemToSave.before );
 
-		const transformedByClone = clone( transformedBy );
-		delete transformedByClone.history;
+		itemToSave.transformedBy = clone( itemToSave.transformedBy );
+		delete itemToSave.transformedBy.history;
+		itemToSave.transformedBy = JSON.stringify( itemToSave.transformedBy );
 
-		this.history = history.concat( {
-			before: JSON.stringify( beforeClone ),
-			transformedBy: JSON.stringify( transformedByClone ),
-			wasImportant: wasImportant,
-			resultIndex: resultIndex,
-			resultsTotal: resultsTotal
-		} );
+		this.history = history.concat( itemToSave );
 	};
 
 	const _deltaTransformTransform = deltaTransform.transform;
@@ -344,7 +340,13 @@ function enableLoggingTools() {
 		const results = _deltaTransformTransform( a, b, isAMoreImportantThanB );
 
 		for ( let i = 0; i < results.length; i++ ) {
-			results[ i ].saveHistory( a, b, isAMoreImportantThanB, i, results.length );
+			results[ i ]._saveHistory( {
+				before: a,
+				transformedBy: b,
+				wasImportant: isAMoreImportantThanB,
+				resultIndex: i,
+				resultsTotal: results.length
+			} );
 		}
 
 		return results;

+ 15 - 3
packages/ckeditor5-engine/tests/dev-utils/enableenginedebug.js

@@ -775,7 +775,7 @@ describe( 'debug tools', () => {
 			otherRoot = document.createRoot( 'other', 'other' );
 		} );
 
-		it( 'Delta#saveHistory()', () => {
+		it( 'Delta#_saveHistory()', () => {
 			const insertDeltaA = new InsertDelta();
 			const insertOpA = new InsertOperation( ModelPosition.createAt( root, 0 ), new ModelText( 'a' ), 0 );
 			insertDeltaA.addOperation( insertOpA );
@@ -788,7 +788,13 @@ describe( 'debug tools', () => {
 			const insertOpFinalA = new InsertOperation( ModelPosition.createAt( root, 0 ), new ModelText( 'a' ), 1 );
 			insertDeltaFinalA.addOperation( insertOpFinalA );
 			const insertDeltaFinalAJsonWithoutHistory = JSON.stringify( insertDeltaFinalA );
-			insertDeltaFinalA.saveHistory( insertDeltaA, insertDeltaB, true, 0, 1 );
+			insertDeltaFinalA._saveHistory( {
+				before: insertDeltaA,
+				transformedBy: insertDeltaB,
+				wasImportant: true,
+				resultIndex: 0,
+				resultsTotal: 1
+			} );
 
 			const insertDeltaC = new InsertDelta();
 			const insertOpC = new InsertOperation( ModelPosition.createAt( root, 0 ), new ModelText( 'a' ), 1 );
@@ -797,7 +803,13 @@ describe( 'debug tools', () => {
 			const insertDeltaFinalB = new InsertDelta();
 			const insertOpFinalB = new InsertOperation( ModelPosition.createAt( root, 0 ), new ModelText( 'a' ), 2 );
 			insertDeltaFinalB.addOperation( insertOpFinalB );
-			insertDeltaFinalB.saveHistory( insertDeltaFinalA, insertDeltaC, false, 1, 3 );
+			insertDeltaFinalB._saveHistory( {
+				before: insertDeltaFinalA,
+				transformedBy: insertDeltaC,
+				wasImportant: false,
+				resultIndex: 1,
+				resultsTotal: 3
+			} );
 
 			expect( insertDeltaA.history ).to.be.undefined;
 			expect( insertDeltaB.history ).to.be.undefined;