Răsfoiți Sursa

Changed: Unify table converter methods invocation.

Maciej Gołaszewski 8 ani în urmă
părinte
comite
c92c019ec1

+ 2 - 2
packages/ckeditor5-table/src/converters.js

@@ -14,8 +14,8 @@ export function upcastTable() {
 	return upcastElementToElement( { model: _createModelTable, view: 'table' } );
 }
 
-export function downcastTableCell( dispatcher ) {
-	dispatcher.on( 'insert:tableCell', ( evt, data, conversionApi ) => {
+export function downcastTableCell() {
+	return dispatcher => dispatcher.on( 'insert:tableCell', ( evt, data, conversionApi ) => {
 		if ( !conversionApi.consumable.consume( data.item, 'insert' ) ) {
 			return;
 		}

+ 1 - 1
packages/ckeditor5-table/src/tableediting.js

@@ -53,7 +53,7 @@ export default class TablesEditing extends Plugin {
 		// Table cell conversion.
 		conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'td' } ) );
 		conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'th' } ) );
-		conversion.for( 'downcast' ).add( downcastTableCell );
+		conversion.for( 'downcast' ).add( downcastTableCell() );
 
 		conversion.attributeToAttribute( { model: 'colspan', view: 'colspan' } );
 		conversion.attributeToAttribute( { model: 'rowspan', view: 'rowspan' } );

+ 2 - 2
packages/ckeditor5-table/tests/converters.js

@@ -55,11 +55,11 @@ describe( 'Table converters', () => {
 				// Table cell conversion.
 				conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'td' } ) );
 				conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'th' } ) );
-				conversion.for( 'downcast' ).add( downcastTableCell );
+				conversion.for( 'downcast' ).add( downcastTableCell() );
 			} );
 	} );
 
-	describe( 'createTable()', () => {
+	describe( 'upcastTable()', () => {
 		function expectModel( data ) {
 			expect( getModelData( model, { withoutSelection: true } ) ).to.equal( data );
 		}