8
0
Просмотр исходного кода

Using setData in manual tests.

Szymon Kupś 8 лет назад
Родитель
Сommit
c1e3a68071

+ 8 - 14
packages/ckeditor5-engine/tests/view/manual/immutable.js

@@ -6,26 +6,20 @@
 /* globals document */
 
 import View from '../../../src/view/view';
-import Position from '../../../src/view/position';
-import { parse } from '../../../src/dev-utils/view';
+import { setData } from '../../../src/dev-utils/view';
 import createViewRoot from '../_utils/createroot';
 
 const view = new View();
 const viewDocument = view.document;
-const viewRoot = createViewRoot( viewDocument, 'div' );
+createViewRoot( viewDocument, 'div' );
 view.attachDomRoot( document.getElementById( 'editor' ) );
 
-view.change( writer => {
-	const { selection, view: data } = parse(
-		'<container:p><attribute:strong>foo</attribute:strong>[]<attribute:strong>bar</attribute:strong></container:p>' +
-		'<container:p></container:p>' +
-		'<container:p><attribute:strong></attribute:strong></container:p>' +
-		'<container:p>bom</container:p>'
-	);
-
-	writer.insert( Position.createAt( viewRoot ), data );
-	writer.setSelection( selection );
-} );
+setData( view,
+	'<container:p><attribute:strong>foo</attribute:strong>[]<attribute:strong>bar</attribute:strong></container:p>' +
+	'<container:p></container:p>' +
+	'<container:p><attribute:strong></attribute:strong></container:p>' +
+	'<container:p>bom</container:p>'
+);
 
 viewDocument.on( 'selectionChange', () => {
 	// Re-render view selection each time selection is changed.

+ 8 - 11
packages/ckeditor5-engine/tests/view/manual/inline-filler.js

@@ -6,28 +6,25 @@
 /* globals document */
 
 import View from '../../../src/view/view';
-import Position from '../../../src/view/position';
 import createViewRoot from '../_utils/createroot';
-import { parse } from '../../../src/dev-utils/view';
+import { setData } from '../../../src/dev-utils/view';
 
 const view = new View();
 const viewDocument = view.document;
-const viewRoot = createViewRoot( viewDocument );
+createViewRoot( viewDocument );
 view.attachDomRoot( document.getElementById( 'editor' ) );
 
-view.change( writer => {
-	const { selection, view: data } = parse(
-		'<container:p><attribute:strong>foo</attribute:strong>[]<attribute:strong>bar</attribute:strong></container:p>'
-	);
-
-	writer.insert( Position.createAt( viewRoot ), data );
-	writer.setSelection( selection );
-} );
+setData(
+	view,
+	'<container:p><attribute:strong>foo</attribute:strong>[]<attribute:strong>bar</attribute:strong></container:p>'
+);
 
 view.focus();
 
 viewDocument.on( 'selectionChange', ( evt, data ) => {
 	view.change( writer => {
+		// Re-render view selection each time selection is changed.
+		// See https://github.com/ckeditor/ckeditor5-engine/issues/796.
 		writer.setSelection( data.newSelection );
 	} );
 } );

+ 6 - 11
packages/ckeditor5-engine/tests/view/manual/mutationobserver.js

@@ -6,13 +6,12 @@
 /* globals console, document */
 
 import View from '../../../src/view/view';
-import Position from '../../../src/view/position';
 import createViewRoot from '../_utils/createroot';
-import { parse } from '../../../src/dev-utils/view';
+import { setData } from '../../../src/dev-utils/view';
 
 const view = new View();
 const viewDocument = view.document;
-const viewRoot = createViewRoot( viewDocument );
+createViewRoot( viewDocument );
 view.attachDomRoot( document.getElementById( 'editor' ) );
 
 viewDocument.on( 'mutations', ( evt, mutations ) => console.log( mutations ) );
@@ -20,11 +19,7 @@ viewDocument.on( 'selectionChange', ( evt, data ) => {
 	view.change( writer => writer.setSelection( data.newSelection ) );
 } );
 
-view.change( writer => {
-	const data = parse(
-		'<container:p>foo</container:p>' +
-		'<container:p>bar</container:p>'
-	);
-
-	writer.insert( Position.createAt( viewRoot ), data );
-} );
+setData( view,
+	'<container:p>foo</container:p>' +
+	'<container:p>bar</container:p>'
+);