Tests: Properly use sinon sandbox in tests t/ckeditor5/1144.
@@ -49,9 +49,9 @@ import ViewElement from '../../src/view/element';
import createViewRoot from '../view/_utils/createroot';
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
-testUtils.createSinonSandbox();
-
describe( 'enableEngineDebug', () => {
+ testUtils.createSinonSandbox();
+
afterEach( () => {
disableEngineDebug();
} );
@@ -72,6 +72,8 @@ describe( 'enableEngineDebug', () => {
describe( 'disableEngineDebug', () => {
it( 'restores modified stubs', () => {
expect( ModelPosition.prototype.log ).to.equal( undefined, 'Initial value (model/position)' );
expect( ModelElement.prototype.printTree ).to.equal( undefined, 'Initial value (model/element)' );
@@ -103,6 +105,8 @@ describe( 'disableEngineDebug', () => {
describe( 'debug tools', () => {
let DebugPlugin, log, error;
before( () => {
log = sinon.spy();
error = sinon.spy();
@@ -22,11 +22,11 @@ import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import { wrapInDelta } from '../../tests/model/_utils/utils';
import { setData, getData } from '../../src/dev-utils/model';
describe( 'DocumentSelection', () => {
let model, doc, root, selection, liveRange, range;
const fooStoreAttrKey = DocumentSelection._getStoreAttributeKey( 'foo' );
const abcStoreAttrKey = DocumentSelection._getStoreAttributeKey( 'abc' );
@@ -13,11 +13,11 @@ import CKEditorError from '@ckeditor/ckeditor5-utils/src/ckeditorerror';
import { jsonParseStringify } from '../../tests/model/_utils/utils';
describe( 'Position', () => {
let doc, root, otherRoot, p, ul, li1, li2, f, o, z, b, a, r, foz, bar;
// root
// |- p Before: [ 0 ] After: [ 1 ]
// |- ul Before: [ 1 ] After: [ 2 ]
@@ -16,11 +16,11 @@ import count from '@ckeditor/ckeditor5-utils/src/count';
import { parse, setData } from '../../src/dev-utils/model';
import Schema from '../../src/model/schema';
describe( 'Selection', () => {
let model, doc, root, selection, liveRange, range, range1, range2, range3;
beforeEach( () => {
model = new Model();
doc = model.document;
@@ -11,11 +11,11 @@ import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import count from '@ckeditor/ckeditor5-utils/src/count';
import createViewRoot from './_utils/createroot';
describe( 'Document', () => {
let domRoot, viewDocument;
domRoot = createElement( document, 'div', {
id: 'editor',
@@ -14,11 +14,11 @@ import { BR_FILLER, NBSP_FILLER, INLINE_FILLER, INLINE_FILLER_LENGTH } from '../
import global from '@ckeditor/ckeditor5-utils/src/dom/global';
describe( 'DomConverter', () => {
let converter;
converter = new DomConverter();
@@ -16,11 +16,11 @@ import log from '@ckeditor/ckeditor5-utils/src/log';
import createViewRoot from '../_utils/createroot';
import { parse } from '../../../src/dev-utils/view';
describe( 'SelectionObserver', () => {
let view, viewDocument, viewRoot, selectionObserver, domRoot, domMain, domDocument;
beforeEach( done => {
domDocument = document;
domRoot = domDocument.createElement( 'div' );
@@ -25,11 +25,11 @@ import createViewRoot from './_utils/createroot';
import createElement from '@ckeditor/ckeditor5-utils/src/dom/createelement';
import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
describe( 'Renderer', () => {
let selection, domConverter, renderer;
selection = new DocumentSelection();
domConverter = new DomConverter();