浏览代码

Changed: Make tab movement in table select whole cell.

Maciej Gołaszewski 7 年之前
父节点
当前提交
bae0ab0253
共有 2 个文件被更改,包括 7 次插入7 次删除
  1. 2 2
      packages/ckeditor5-table/src/tableediting.js
  2. 5 5
      packages/ckeditor5-table/tests/tableediting.js

+ 2 - 2
packages/ckeditor5-table/src/tableediting.js

@@ -10,7 +10,7 @@
 import Plugin from '@ckeditor/ckeditor5-core/src/plugin';
 import { upcastElementToElement } from '@ckeditor/ckeditor5-engine/src/conversion/upcast-converters';
 import { keyCodes } from '@ckeditor/ckeditor5-utils/src/keyboard';
-import Position from '@ckeditor/ckeditor5-engine/src/model/position';
+import Range from '@ckeditor/ckeditor5-engine/src/model/range';
 
 import upcastTable from './converters/upcasttable';
 import { downcastInsertCell, downcastInsertRow, downcastInsertTable, downcastRemoveRow } from './converters/downcast';
@@ -135,7 +135,7 @@ export default class TablesEditing extends Plugin {
 			}
 
 			editor.model.change( writer => {
-				writer.setSelection( Position.createAt( moveToCell ) );
+				writer.setSelection( Range.createIn( moveToCell ) );
 			} );
 		} );
 	}

+ 5 - 5
packages/ckeditor5-table/tests/tableediting.js

@@ -153,13 +153,13 @@ describe( 'TableEditing', () => {
 				sinon.assert.calledOnce( domEvtDataStub.preventDefault );
 				sinon.assert.calledOnce( domEvtDataStub.stopPropagation );
 				expect( formatModelTable( getModelData( model ) ) ).to.equal( formattedModelTable( [
-					[ '11', '[]12' ]
+					[ '11', '[12]' ]
 				] ) );
 			} );
 
 			it( 'should create another row and move to first cell in new row', () => {
 				setModelData( model, modelTable( [
-					[ '11', '12[]' ]
+					[ '11', '[12]' ]
 				] ) );
 
 				editor.editing.view.document.fire( 'keydown', domEvtDataStub );
@@ -180,7 +180,7 @@ describe( 'TableEditing', () => {
 
 				expect( formatModelTable( getModelData( model ) ) ).to.equal( formattedModelTable( [
 					[ '11', '12' ],
-					[ '[]21', '22' ]
+					[ '[21]', '22' ]
 				] ) );
 			} );
 		} );
@@ -217,7 +217,7 @@ describe( 'TableEditing', () => {
 				sinon.assert.calledOnce( domEvtDataStub.preventDefault );
 				sinon.assert.calledOnce( domEvtDataStub.stopPropagation );
 				expect( formatModelTable( getModelData( model ) ) ).to.equal( formattedModelTable( [
-					[ '[]11', '12' ]
+					[ '[11]', '12' ]
 				] ) );
 			} );
 
@@ -242,7 +242,7 @@ describe( 'TableEditing', () => {
 				editor.editing.view.document.fire( 'keydown', domEvtDataStub );
 
 				expect( formatModelTable( getModelData( model ) ) ).to.equal( formattedModelTable( [
-					[ '11', '[]12' ],
+					[ '11', '[12]' ],
 					[ '21', '22' ]
 				] ) );
 			} );