Explorar el Código

Refactoring: prepended protected methods with underscores.

Piotrek Koszuliński hace 9 años
padre
commit
b9b87c6aa8

+ 3 - 3
packages/ckeditor5-engine/src/model/document.js

@@ -306,7 +306,7 @@ export default class Document {
 	 * @protected
 	 * @returns {engine.model.RootElement} The default root for this document.
 	 */
-	getDefaultRoot() {
+	_getDefaultRoot() {
 		for ( let root of this._roots.values() ) {
 			if ( root !== this.graveyard ) {
 				return root;
@@ -323,8 +323,8 @@ export default class Document {
 	 * @protected
 	 * @returns {engine.model.Range}
 	 */
-	getDefaultRange() {
-		const defaultRoot = this.getDefaultRoot();
+	_getDefaultRange() {
+		const defaultRoot = this._getDefaultRoot();
 
 		// Find the first position where the selection can be put.
 		for ( let position of Range.createIn( defaultRoot ).getPositions() ) {

+ 5 - 5
packages/ckeditor5-engine/src/model/liveselection.js

@@ -96,14 +96,14 @@ export default class LiveSelection extends Selection {
 	 * @inheritDoc
 	 */
 	get anchor() {
-		return super.anchor || this._document.getDefaultRange().start;
+		return super.anchor || this._document._getDefaultRange().start;
 	}
 
 	/**
 	 * @inheritDoc
 	 */
 	get focus() {
-		return super.focus || this._document.getDefaultRange().start;
+		return super.focus || this._document._getDefaultRange().start;
 	}
 
 	/**
@@ -131,7 +131,7 @@ export default class LiveSelection extends Selection {
 		if ( this._ranges.length ) {
 			yield *super.getRanges();
 		} else {
-			yield this._document.getDefaultRange();
+			yield this._document._getDefaultRange();
 		}
 	}
 
@@ -139,14 +139,14 @@ export default class LiveSelection extends Selection {
 	 * @inheritDoc
 	 */
 	getFirstRange() {
-		return super.getFirstRange() || this._document.getDefaultRange();
+		return super.getFirstRange() || this._document._getDefaultRange();
 	}
 
 	/**
 	 * @inheritDoc
 	 */
 	getLastRange() {
-		return super.getLastRange() || this._document.getDefaultRange();
+		return super.getLastRange() || this._document._getDefaultRange();
 	}
 
 	/**

+ 3 - 3
packages/ckeditor5-engine/tests/model/document/document.js

@@ -284,9 +284,9 @@ describe( 'Document', () => {
 		} );
 	} );
 
-	describe( 'getDefaultRoot', () => {
+	describe( '_getDefaultRoot', () => {
 		it( 'should return graveyard root if there are no other roots in the document', () => {
-			expect( doc.getDefaultRoot() ).to.equal( doc.graveyard );
+			expect( doc._getDefaultRoot() ).to.equal( doc.graveyard );
 		} );
 
 		it( 'should return the first root added to the document', () => {
@@ -294,7 +294,7 @@ describe( 'Document', () => {
 			doc.createRoot( '$root', 'rootB' );
 			doc.createRoot( '$root', 'rootC' );
 
-			expect( doc.getDefaultRoot() ).to.equal( rootA );
+			expect( doc._getDefaultRoot() ).to.equal( rootA );
 		} );
 	} );