Browse Source

Changed: Remove toolbar class binding from dropdown.

Maciej Gołaszewski 7 years ago
parent
commit
b959eba869

+ 0 - 10
packages/ckeditor5-ui/src/dropdown/button/buttondropdownmodel.jsdoc

@@ -43,13 +43,3 @@
  * @observable
  * @observable
  * @member {String} #icon
  * @member {String} #icon
  */
  */
-
-/**
- * (Optional) A CSS class set to
- * {@link module:ui/dropdown/button/buttondropdownview~ButtonDropdownView#toolbarView}.
- *
- * Also see {@link module:ui/toolbar/toolbarview~ToolbarView#className `ToolbarView#className`}.
- *
- * @observable
- * @member {String} #toolbarClassName
- */

+ 1 - 1
packages/ckeditor5-ui/src/dropdown/utils.js

@@ -236,7 +236,7 @@ export function addToolbarToDropdown( dropdownView, model ) {
 	const toolbarView = dropdownView.toolbarView = new ToolbarView();
 	const toolbarView = dropdownView.toolbarView = new ToolbarView();
 
 
 	// TODO verify className binding
 	// TODO verify className binding
-	toolbarView.bind( 'isVertical', 'className' ).to( model, 'isVertical', 'toolbarClassName' );
+	toolbarView.bind( 'isVertical' ).to( model, 'isVertical' );
 
 
 	// TODO: verify class names
 	// TODO: verify class names
 	dropdownView.extendTemplate( {
 	dropdownView.extendTemplate( {

+ 0 - 8
packages/ckeditor5-ui/tests/dropdown/utils.js

@@ -462,14 +462,6 @@ describe( 'utils', () => {
 				model.isVertical = true;
 				model.isVertical = true;
 				expect( dropdownView.toolbarView.isVertical ).to.be.true;
 				expect( dropdownView.toolbarView.isVertical ).to.be.true;
 			} );
 			} );
-
-			// TODO: remove?
-			it( 'reacts on model#toolbarClassName', () => {
-				expect( dropdownView.toolbarView.className ).to.be.undefined;
-
-				model.set( 'toolbarClassName', 'foo' );
-				expect( dropdownView.toolbarView.className ).to.equal( 'foo' );
-			} );
 		} );
 		} );
 
 
 		describe( 'buttons', () => {
 		describe( 'buttons', () => {