Bladeren bron

Fixed: Stop using `move` converter.

Szymon Cofalik 8 jaren geleden
bovenliggende
commit
b7ac11fd05
2 gewijzigde bestanden met toevoegingen van 0 en 18 verwijderingen
  1. 0 6
      packages/ckeditor5-list/src/listengine.js
  2. 0 12
      packages/ckeditor5-list/tests/listengine.js

+ 0 - 6
packages/ckeditor5-list/src/listengine.js

@@ -17,7 +17,6 @@ import {
 	modelViewChangeType,
 	modelViewMergeAfter,
 	modelViewRemove,
-	modelViewMove,
 	modelViewSplitOnInsert,
 	modelViewChangeIndent,
 	viewModelConverter,
@@ -71,11 +70,6 @@ export default class ListEngine extends Plugin {
 		data.modelToView.on( 'remove:listItem', modelViewRemove );
 		data.modelToView.on( 'remove', modelViewMergeAfter, { priority: 'low' } );
 
-		editing.modelToView.on( 'move:listItem', modelViewMove );
-		editing.modelToView.on( 'move', modelViewMergeAfter, { priority: 'low' } );
-		data.modelToView.on( 'move:listItem', modelViewMove );
-		data.modelToView.on( 'move', modelViewMergeAfter, { priority: 'low' } );
-
 		editing.modelToView.on( 'changeAttribute:indent:listItem', modelViewChangeIndent );
 		data.modelToView.on( 'changeAttribute:indent:listItem', modelViewChangeIndent );
 

+ 0 - 12
packages/ckeditor5-list/tests/listengine.js

@@ -462,18 +462,6 @@ describe( 'ListEngine', () => {
 			expect( getViewData( editor.editing.view, { withoutSelection: true } ) ).to.equal( '<ul><li></li></ul>' );
 		} );
 
-		it( 'model move converter should not fire if change was already consumed', () => {
-			editor.editing.modelToView.on( 'move', ( evt, data, consumable ) => {
-				consumable.consume( data.item, 'move' );
-			}, { priority: 'highest' } );
-
-			setModelData( doc, '<listItem indent="0" type="bulleted"></listItem><paragraph>foo</paragraph>' );
-
-			doc.batch().move( root.getChild( 0 ), ModelPosition.createAt( root, 2 ) );
-
-			expect( getViewData( editor.editing.view, { withoutSelection: true } ) ).to.equal( '<ul><li></li></ul><p>foo</p>' );
-		} );
-
 		it( 'model change type converter should not fire if change was already consumed', () => {
 			editor.editing.modelToView.on( 'changeAttribute:type', ( evt, data, consumable ) => {
 				consumable.consume( data.item, 'changeAttribute:type' );