|
|
@@ -3,9 +3,15 @@
|
|
|
* For licensing, see LICENSE.md.
|
|
|
*/
|
|
|
|
|
|
+/* global document */
|
|
|
+
|
|
|
import VirtualTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/virtualtesteditor';
|
|
|
+import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor';
|
|
|
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
|
|
|
import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
|
|
|
+import Bold from '@ckeditor/ckeditor5-basic-styles/src/boldengine';
|
|
|
+import Italic from '@ckeditor/ckeditor5-basic-styles/src/italicengine';
|
|
|
+import LinkEngine from '@ckeditor/ckeditor5-link/src/linkengine';
|
|
|
import Input from '../src/input';
|
|
|
|
|
|
import Batch from '@ckeditor/ckeditor5-engine/src/model/batch';
|
|
|
@@ -15,7 +21,9 @@ import buildViewConverter from '@ckeditor/ckeditor5-engine/src/conversion/buildv
|
|
|
|
|
|
import ViewText from '@ckeditor/ckeditor5-engine/src/view/text';
|
|
|
import ViewElement from '@ckeditor/ckeditor5-engine/src/view/element';
|
|
|
+import ViewContainerElement from '@ckeditor/ckeditor5-engine/src/view/containerelement';
|
|
|
import ViewSelection from '@ckeditor/ckeditor5-engine/src/view/selection';
|
|
|
+import MutationObserver from '@ckeditor/ckeditor5-engine/src/view/observer/mutationobserver';
|
|
|
|
|
|
import EmitterMixin from '@ckeditor/ckeditor5-utils/src/emittermixin';
|
|
|
import { getCode } from '@ckeditor/ckeditor5-utils/src/keyboard';
|
|
|
@@ -541,5 +549,401 @@ describe( 'Input feature', () => {
|
|
|
expect( getModelData( model ) ).to.equal( '<paragraph>fo[ob]ar</paragraph>' );
|
|
|
} );
|
|
|
} );
|
|
|
+
|
|
|
+ // NOTE: In all these tests we need to simulate the mutations. However, it's really tricky to tell what
|
|
|
+ // should be in "newChildren" because we don't have yet access to these nodes. We pass new instances,
|
|
|
+ // but this means that DomConverter which is used somewhere internally may return a different instance
|
|
|
+ // (which wouldn't happen in practice because it'd cache it). Besides, it's really hard to tell if the
|
|
|
+ // browser will keep the instances of the old elements when modifying the tree when the user is typing
|
|
|
+ // or if it will create new instances itself too.
|
|
|
+ // However, the code handling these mutations doesn't really care what's inside new/old children. It
|
|
|
+ // just needs the mutations common ancestor to understand how big fragment of the tree has changed.
|
|
|
+ describe( '#100', () => {
|
|
|
+ let domElement, domRoot;
|
|
|
+
|
|
|
+ beforeEach( () => {
|
|
|
+ domElement = document.createElement( 'div' );
|
|
|
+ document.body.appendChild( domElement );
|
|
|
+
|
|
|
+ return ClassicTestEditor.create( domElement, { plugins: [ Input, Paragraph, Bold, Italic, LinkEngine ] } )
|
|
|
+ .then( newEditor => {
|
|
|
+ editor = newEditor;
|
|
|
+ model = editor.document;
|
|
|
+ modelRoot = model.getRoot();
|
|
|
+ view = editor.editing.view;
|
|
|
+ viewRoot = view.getRoot();
|
|
|
+ domRoot = view.getDomRoot();
|
|
|
+
|
|
|
+ // Mock image feature.
|
|
|
+ newEditor.document.schema.registerItem( 'image', '$inline' );
|
|
|
+
|
|
|
+ buildModelConverter().for( newEditor.data.modelToView, newEditor.editing.modelToView )
|
|
|
+ .fromElement( 'image' )
|
|
|
+ .toElement( 'img' );
|
|
|
+
|
|
|
+ buildViewConverter().for( newEditor.data.viewToModel )
|
|
|
+ .fromElement( 'img' )
|
|
|
+ .toElement( 'image' );
|
|
|
+
|
|
|
+ // Disable MO completely and in a way it won't be reenabled on some Document#render() call.
|
|
|
+ const mutationObserver = view.getObserver( MutationObserver );
|
|
|
+
|
|
|
+ mutationObserver.disable();
|
|
|
+ mutationObserver.enable = () => {};
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+
|
|
|
+ afterEach( () => {
|
|
|
+ domElement.remove();
|
|
|
+
|
|
|
+ return editor.destroy();
|
|
|
+ } );
|
|
|
+
|
|
|
+ // This happens when browser automatically switches parent and child nodes.
|
|
|
+ it( 'should handle mutations switching inner and outer node when adding new text node after', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text italic="true" linkHref="foo">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><a href="foo"><i>text{}</i></a></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const link = paragraph.getChild( 0 );
|
|
|
+ const italic = link.getChild( 0 );
|
|
|
+ const text = italic.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<i><a href="foo">text</a>x</i>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ // First mutation - remove all children from link element.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: link,
|
|
|
+ oldChildren: [ italic ],
|
|
|
+ newChildren: []
|
|
|
+ },
|
|
|
+
|
|
|
+ // Second mutation - remove link from paragraph and put italic there.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ link ],
|
|
|
+ newChildren: [ new ViewElement( 'i' ) ]
|
|
|
+ },
|
|
|
+
|
|
|
+ // Third mutation - italic's new children.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: italic,
|
|
|
+ oldChildren: [ text ],
|
|
|
+ newChildren: [ new ViewElement( 'a', null, text ), new ViewText( 'x' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><a href="foo"><i>textx{}</i></a></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should handle mutations switching inner and outer node when adding new text node before', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text italic="true" linkHref="foo">' +
|
|
|
+ '[]text' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><a href="foo"><i>{}text</i></a></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const link = paragraph.getChild( 0 );
|
|
|
+ const italic = link.getChild( 0 );
|
|
|
+ const text = italic.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<i>x<a href="foo">text</a></i>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ // First mutation - remove all children from link element.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: link,
|
|
|
+ oldChildren: [ italic ],
|
|
|
+ newChildren: []
|
|
|
+ },
|
|
|
+
|
|
|
+ // Second mutation - remove link from paragraph and put italic there.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ link ],
|
|
|
+ newChildren: [ new ViewElement( 'i' ) ]
|
|
|
+ },
|
|
|
+
|
|
|
+ // Third mutation - italic's new children.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: italic,
|
|
|
+ oldChildren: [ text ],
|
|
|
+ newChildren: [ new ViewText( 'x' ), new ViewElement( 'a', null, 'text' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><a href="foo"><i>x{}text</i></a></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should handle mutations switching inner and outer node - with text before', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ 'xxx<$text italic="true" linkHref="foo">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p>xxx<a href="foo"><i>text{}</i></a></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const textBefore = paragraph.getChild( 0 );
|
|
|
+ const link = paragraph.getChild( 1 );
|
|
|
+ const italic = link.getChild( 0 );
|
|
|
+ const text = italic.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = 'xxx<i><a href="foo">text</a>x</i>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ // First mutation - remove all children from link element.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: link,
|
|
|
+ oldChildren: [ italic ],
|
|
|
+ newChildren: []
|
|
|
+ },
|
|
|
+
|
|
|
+ // Second mutation - remove link from paragraph and put italic there.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ textBefore, link ],
|
|
|
+ newChildren: [ new ViewText( 'xxx' ), new ViewElement( 'i' ) ]
|
|
|
+ },
|
|
|
+
|
|
|
+ // Third mutation - italic's new children.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: italic,
|
|
|
+ oldChildren: [ text ],
|
|
|
+ newChildren: [ new ViewElement( 'a', null, 'text' ), new ViewText( 'x' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p>xxx<a href="foo"><i>textx{}</i></a></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ // This happens when spell checker is applied on <strong> element and changes it to <b>.
|
|
|
+ it( 'should handle mutations replacing node', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<b>fixed text</b>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ // Replace `<strong>` with `<b>`.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ strong ],
|
|
|
+ newChildren: [ new ViewElement( 'b', null, 'fixed text' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view, { withoutSelection: true } ) ).to.equal( '<p><strong>fixed text</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ // Spell checker splits text inside attributes to two text nodes.
|
|
|
+ it( 'should handle mutations inside attribute element', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'this is foo text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>this is foo text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+ const text = strong.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].childNodes[ 0 ].innerHTML = 'this is bar text';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: strong,
|
|
|
+ oldChildren: [ text ],
|
|
|
+ newChildren: [ new ViewText( 'this is bar' ), new ViewText( ' text' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view, { withoutSelection: true } ) ).to.equal( '<p><strong>this is bar text</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should do nothing if elements mutated', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<strong>text</strong><img />';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ strong ],
|
|
|
+ newChildren: [
|
|
|
+ new ViewElement( 'strong', null, new ViewText( 'text' ) ),
|
|
|
+ new ViewElement( 'img' )
|
|
|
+ ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should do nothing if text is not changed', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<strong>text</strong>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ strong ],
|
|
|
+ newChildren: [ new ViewElement( 'strong', null, new ViewText( 'text' ) ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should do nothing on empty mutations', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<strong>text</strong>';
|
|
|
+ view.fire( 'mutations', [] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should do nothing if mutations does not have common ancestor', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<strong>text</strong>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ strong ],
|
|
|
+ newChildren: [ strong ]
|
|
|
+ },
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: new ViewContainerElement( 'div' ),
|
|
|
+ oldChildren: [],
|
|
|
+ newChildren: [ new ViewText( 'foo' ), new ViewText( 'bar' ) ]
|
|
|
+ }
|
|
|
+ ] );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should handle view selection if one is returned from mutations', () => {
|
|
|
+ setModelData( model,
|
|
|
+ '<paragraph>' +
|
|
|
+ '<$text bold="true">' +
|
|
|
+ 'text[]' +
|
|
|
+ '</$text>' +
|
|
|
+ '</paragraph>'
|
|
|
+ );
|
|
|
+
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>text{}</strong></p>' );
|
|
|
+
|
|
|
+ const paragraph = viewRoot.getChild( 0 );
|
|
|
+ const strong = paragraph.getChild( 0 );
|
|
|
+ const viewSelection = new ViewSelection();
|
|
|
+ viewSelection.collapse( paragraph, 0 );
|
|
|
+
|
|
|
+ // Simulate mutations and DOM change.
|
|
|
+ domRoot.childNodes[ 0 ].innerHTML = '<b>textx</b>';
|
|
|
+ view.fire( 'mutations', [
|
|
|
+ // Replace `<strong>` with `<b>`.
|
|
|
+ {
|
|
|
+ type: 'children',
|
|
|
+ node: paragraph,
|
|
|
+ oldChildren: [ strong ],
|
|
|
+ newChildren: [ new ViewElement( 'b', null, new ViewText( 'textx' ) ) ]
|
|
|
+ }
|
|
|
+ ], viewSelection );
|
|
|
+
|
|
|
+ expect( getModelData( model ) ).to.equal( '<paragraph><$text bold="true">[]textx</$text></paragraph>' );
|
|
|
+ expect( getViewData( view ) ).to.equal( '<p><strong>{}textx</strong></p>' );
|
|
|
+ } );
|
|
|
+ } );
|
|
|
} );
|
|
|
|