8
0
Просмотр исходного кода

Tests: Add proper tests for Edge browser.

Maciej Gołaszewski 7 лет назад
Родитель
Сommit
afeb2d296f
1 измененных файлов с 51 добавлено и 0 удалено
  1. 51 0
      packages/ckeditor5-widget/tests/utils.js

+ 51 - 0
packages/ckeditor5-widget/tests/utils.js

@@ -19,11 +19,17 @@ import {
 	WIDGET_CLASS_NAME
 	WIDGET_CLASS_NAME
 } from '../src/utils';
 } from '../src/utils';
 import UIElement from '@ckeditor/ckeditor5-engine/src/view/uielement';
 import UIElement from '@ckeditor/ckeditor5-engine/src/view/uielement';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 
 describe( 'widget utils', () => {
 describe( 'widget utils', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let element, writer, viewDocument;
 	let element, writer, viewDocument;
 
 
 	beforeEach( () => {
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		viewDocument = new ViewDocument();
 		viewDocument = new ViewDocument();
 		writer = new Writer( viewDocument );
 		writer = new Writer( viewDocument );
 
 
@@ -31,6 +37,10 @@ describe( 'widget utils', () => {
 		toWidget( element, writer );
 		toWidget( element, writer );
 	} );
 	} );
 
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	describe( 'toWidget()', () => {
 	describe( 'toWidget()', () => {
 		it( 'should set contenteditable to "false"', () => {
 		it( 'should set contenteditable to "false"', () => {
 			expect( element.getAttribute( 'contenteditable' ) ).to.equal( 'false' );
 			expect( element.getAttribute( 'contenteditable' ) ).to.equal( 'false' );
@@ -110,6 +120,19 @@ describe( 'widget utils', () => {
 			expect( icon.classList.contains( 'ck' ) ).to.be.true;
 			expect( icon.classList.contains( 'ck' ) ).to.be.true;
 			expect( icon.classList.contains( 'ck-icon' ) ).to.be.true;
 			expect( icon.classList.contains( 'ck-icon' ) ).to.be.true;
 		} );
 		} );
+
+		describe( 'on Edge', () => {
+			beforeEach( () => {
+				env.isEdge = true;
+
+				element = writer.createContainerElement( 'div' );
+				toWidget( element, writer );
+			} );
+
+			it( 'should not set contenteditable onEdge', () => {
+				expect( element.getAttribute( 'contenteditable' ) ).to.be.undefined;
+			} );
+		} );
 	} );
 	} );
 
 
 	describe( 'isWidget()', () => {
 	describe( 'isWidget()', () => {
@@ -189,6 +212,34 @@ describe( 'widget utils', () => {
 			element.isFocused = false;
 			element.isFocused = false;
 			expect( element.hasClass( 'ck-editor__nested-editable_focused' ) ).to.be.false;
 			expect( element.hasClass( 'ck-editor__nested-editable_focused' ) ).to.be.false;
 		} );
 		} );
+
+		describe( 'on Edge', () => {
+			beforeEach( () => {
+				env.isEdge = true;
+
+				viewDocument = new ViewDocument();
+				element = new ViewEditableElement( 'div' );
+				element._document = viewDocument;
+				toWidgetEditable( element, writer );
+			} );
+
+			it( 'should add contenteditable attribute when element is read-only - initialization', () => {
+				const element = new ViewEditableElement( 'div' );
+				element._document = viewDocument;
+				element.isReadOnly = true;
+				toWidgetEditable( element, writer );
+
+				expect( element.getAttribute( 'contenteditable' ) ).to.be.undefined;
+			} );
+
+			it( 'should add contenteditable attribute when element is read-only - when changing', () => {
+				element.isReadOnly = true;
+				expect( element.getAttribute( 'contenteditable' ) ).to.be.undefined;
+
+				element.isReadOnly = false;
+				expect( element.getAttribute( 'contenteditable' ) ).to.be.undefined;
+			} );
+		} );
 	} );
 	} );
 
 
 	describe( 'addHighlightHandling()', () => {
 	describe( 'addHighlightHandling()', () => {