浏览代码

Removed options to set custom virutal selection handling functions in toWidget utility.

Szymon Kupś 8 年之前
父节点
当前提交
aeba2f724a
共有 2 个文件被更改,包括 1 次插入34 次删除
  1. 1 11
      packages/ckeditor5-widget/src/utils.js
  2. 0 23
      packages/ckeditor5-widget/tests/utils.js

+ 1 - 11
packages/ckeditor5-widget/src/utils.js

@@ -49,12 +49,6 @@ export function isWidget( element ) {
  * @param {Object} [options={}]
  * @param {String|Function} [options.label] Element's label provided to {@link ~setLabel} function. It can be passed as
  * a plain string or a function returning a string.
- * @param {Function} [setVirtualSelection] Function that will apply virtual selection on widget's element. When not
- * provided, default behaviour will be used: adding CSS class from
- * {@link module:engine/conversion/buildmodelconverter~VirtualSelectionDescriptor}.
- * @param {Function} [removeVirtualSelection] Function that will remove virtual selection on widget's element. When not
- * provided, default behaviour will be used: removing CSS class from
- * {@link module:engine/conversion/buildmodelconverter~VirtualSelectionDescriptor}.
  * @returns {module:engine/view/element~Element} Returns same element.
  */
 export function toWidget( element, options = {} ) {
@@ -67,11 +61,7 @@ export function toWidget( element, options = {} ) {
 		setLabel( element, options.label );
 	}
 
-	setVirtualSelectionHandling(
-		element,
-		options.setVirtualSelection || setVirtualSelection,
-		options.removeVirtualSelection || removeVirtualSelection
-	);
+	setVirtualSelectionHandling( element, setVirtualSelection, removeVirtualSelection );
 
 	return element;
 }

+ 0 - 23
packages/ckeditor5-widget/tests/utils.js

@@ -65,29 +65,6 @@ describe( 'widget utils', () => {
 			remove( element, { priority: 1, class: 'virtual-selection' } );
 			expect( element.hasClass( 'virtual-selection' ) ).to.be.false;
 		} );
-
-		it( 'should use provided virtual selection methods', () => {
-			const setSpy = sinon.spy();
-			const removeSpy = sinon.spy();
-			const descriptor = { priority: 1, class: 'virtual-selection' };
-			toWidget( element, { setVirtualSelection: setSpy, removeVirtualSelection: removeSpy } );
-
-			const set = element.getCustomProperty( 'setVirtualSelection' );
-			const remove = element.getCustomProperty( 'removeVirtualSelection' );
-
-			expect( typeof set ).to.equal( 'function' );
-			expect( typeof remove ).to.equal( 'function' );
-
-			set( element, descriptor );
-
-			sinon.assert.calledOnce( setSpy );
-			sinon.assert.calledWithExactly( setSpy, element, descriptor );
-
-			remove( element, descriptor );
-
-			sinon.assert.calledOnce( removeSpy );
-			sinon.assert.calledWithExactly( removeSpy, element, descriptor );
-		} );
 	} );
 
 	describe( 'isWidget()', () => {