Browse Source

Fix: Wrong toolbar position when config.toolbar.viewportTopOffset is not specified.

Aleksander Nowodzinski 8 years ago
parent
commit
acb96c00a7

+ 1 - 1
packages/ckeditor5-editor-inline/src/inlineeditorui.js

@@ -56,7 +56,7 @@ export default class InlineEditorUI {
 		// Set–up the view#panel.
 		view.panel.bind( 'isVisible' ).to( this.focusTracker, 'isFocused' );
 
-		if ( this._toolbarConfig ) {
+		if ( this._toolbarConfig && this._toolbarConfig.viewportTopOffset ) {
 			view.viewportTopOffset = this._toolbarConfig.viewportTopOffset;
 		}
 

+ 5 - 1
packages/ckeditor5-editor-inline/tests/inlineeditorui.js

@@ -73,7 +73,11 @@ describe( 'InlineEditorUI', () => {
 				expect( view.panel.isVisible ).to.be.true;
 			} );
 
-			it( 'sets view#viewportTopOffset', () => {
+			it( 'doesn\'t set the view#viewportTopOffset, if not specified in the config', () => {
+				expect( view.viewportTopOffset ).to.equal( 0 );
+			} );
+
+			it( 'sets view#viewportTopOffset, if specified', () => {
 				editorElement = document.createElement( 'div' );
 				document.body.appendChild( editorElement );
 

+ 4 - 0
packages/ckeditor5-editor-inline/tests/inlineeditoruiview.js

@@ -31,6 +31,10 @@ describe( 'InlineEditorUIView', () => {
 				expect( view.toolbar.element.classList.contains( 'ck-editor-toolbar' ) ).to.be.true;
 				expect( view.toolbar.element.classList.contains( 'ck-toolbar_floating' ) ).to.be.true;
 			} );
+
+			it( 'sets the default value of the #viewportTopOffset attribute', () => {
+				expect( view.viewportTopOffset ).to.equal( 0 );
+			} );
 		} );
 
 		describe( '#panel', () => {