소스 검색

Ensure some better cleanup so we can test memory leaks.

Piotrek Koszuliński 9 년 전
부모
커밋
ac301069a2

+ 3 - 1
packages/ckeditor5-engine/tests/creator/manual/_utils/creator/classiccreator.js

@@ -13,7 +13,7 @@ import FramedEditableView from '/tests/core/_utils/ui/editable/framed/framededit
 import Model from '/ckeditor5/core/ui/model.js';
 import Toolbar from '/ckeditor5/ui/toolbar/toolbar.js';
 import ToolbarView from '/ckeditor5/ui/toolbar/toolbarview.js';
-import imitateFeatures from '../imitatefeatures.js';
+import { imitateFeatures, imitateDestroyFeatures } from '../imitatefeatures.js';
 
 export default class ClassicCreator extends Creator {
 	constructor( editor ) {
@@ -34,6 +34,8 @@ export default class ClassicCreator extends Creator {
 	}
 
 	destroy() {
+		imitateDestroyFeatures();
+
 		this.updateEditorElement();
 
 		return super.destroy();

+ 3 - 1
packages/ckeditor5-engine/tests/creator/manual/_utils/creator/inlinecreator.js

@@ -13,7 +13,7 @@ import InlineEditableView from '/tests/core/_utils/ui/editable/inline/inlineedit
 import Model from '/ckeditor5/core/ui/model.js';
 import FloatingToolbar from '/tests/core/_utils/ui/floatingtoolbar/floatingtoolbar.js';
 import FloatingToolbarView from '/tests/core/_utils/ui/floatingtoolbar/floatingtoolbarview.js';
-import imitateFeatures from '../imitatefeatures.js';
+import { imitateFeatures, imitateDestroyFeatures } from '../imitatefeatures.js';
 
 export default class InlineCreator extends Creator {
 	constructor( editor ) {
@@ -33,6 +33,8 @@ export default class InlineCreator extends Creator {
 	}
 
 	destroy() {
+		imitateDestroyFeatures();
+
 		this.updateEditorElement();
 
 		return super.destroy();

+ 6 - 1
packages/ckeditor5-engine/tests/creator/manual/_utils/imitatefeatures.js

@@ -14,7 +14,7 @@ import ButtonView from '/ckeditor5/ui/button/buttonview.js';
  *
  * @param {core.Editor} editor
  */
-export default function imitateFeatures( editor ) {
+export function imitateFeatures( editor ) {
 	const boldModel = new Model( {
 		isEnabled: true,
 		isOn: false,
@@ -48,3 +48,8 @@ export default function imitateFeatures( editor ) {
 	window.boldModel = boldModel;
 	window.italicModel = italicModel;
 }
+
+export function imitateDestroyFeatures() {
+	delete window.boldModel;
+	delete window.italicModel;
+}