Jelajahi Sumber

Removed `batch` event. Changed `History#updateDelta` to `History#getTransformedDelta`.

Szymon Cofalik 9 tahun lalu
induk
melakukan
a4e137310d

+ 0 - 5
packages/ckeditor5-engine/src/treemodel/batch.js

@@ -58,7 +58,6 @@ export default class Batch {
 	 * Adds delta to the Batch instance. All modification methods (insert, remove, split, etc.) use this method
 	 * to add created deltas.
 	 *
-	 * @fires {@link core.treeModel.Document#batch}
 	 * @param {core.treeModel.delta.Delta} delta Delta to add.
 	 * @return {core.treeModel.delta.Delta} Added delta.
 	 */
@@ -66,10 +65,6 @@ export default class Batch {
 		delta.batch = this;
 		this.deltas.push( delta );
 
-		if ( this.deltas.length == 1 ) {
-			this.doc.fire( 'batch', this );
-		}
-
 		return delta;
 	}
 }

+ 0 - 6
packages/ckeditor5-engine/src/treemodel/document.js

@@ -319,12 +319,6 @@ export default class Document {
 	 *
 	 * @event core.treeModel.Document#changesDone
 	 */
-
-	/**
-	 * Fired when a first delta is added to a batch. Can be treated as "new batch created" event.
-	 *
-	 * @event core.treeModel.Document#batch
-	 */
 }
 
 utils.mix( Document, EmitterMixin );

+ 1 - 1
packages/ckeditor5-engine/src/treemodel/history.js

@@ -84,7 +84,7 @@ export default class History {
 	 * @param {core.treeModel.delta.Delta} delta Delta to update.
 	 * @returns {Array.<core.treeModel.delta.Delta>} Result of transformation which is an array containing one or more deltas.
 	 */
-	updateDelta( delta ) {
+	getTransformedDelta( delta ) {
 		if ( delta.baseVersion === this._nextHistoryPoint ) {
 			return [ delta ];
 		}

+ 0 - 16
packages/ckeditor5-engine/tests/treemodel/batch.js

@@ -68,21 +68,5 @@ describe( 'Batch', () => {
 			expect( batch.deltas[ 0 ] ).to.equal( deltaA );
 			expect( batch.deltas[ 1 ] ).to.equal( deltaB );
 		} );
-
-		it( 'should fire batch event on it\'s document when first delta is added to the batch', () => {
-			const doc = new Document();
-			const batch = new Batch( doc );
-			const spy = sinon.spy();
-
-			doc.on( 'batch', spy );
-
-			batch.addDelta( new Delta() );
-
-			expect( spy.calledOnce ).to.be.true;
-
-			batch.addDelta( new Delta() );
-
-			expect( spy.calledOnce ).to.be.true;
-		} );
 	} );
 } );

+ 4 - 4
packages/ckeditor5-engine/tests/treemodel/history.js

@@ -78,7 +78,7 @@ describe( 'History', () => {
 		} );
 	} );
 
-	describe( 'updateDelta', () => {
+	describe( 'getTransformedDelta', () => {
 		it( 'should transform given delta by deltas from history which were applied since the baseVersion of given delta', () => {
 			sinon.spy( History, '_transform' );
 
@@ -104,7 +104,7 @@ describe( 'History', () => {
 
 			// `deltaX` bases on the same history point as `deltaB` -- so it already acknowledges `deltaA` existence.
 			// It should be transformed by `deltaB` and all following deltas (`deltaC` and `deltaD`).
-			history.updateDelta( deltaX );
+			history.getTransformedDelta( deltaX );
 
 			// `deltaX` was not transformed by `deltaA`.
 			expect( History._transform.calledWithExactly( deltaX, deltaA ) ).to.be.false;
@@ -126,7 +126,7 @@ describe( 'History', () => {
 
 			history.addOperation( deltaA.operations[ 0 ] );
 
-			let result = history.updateDelta( deltaB );
+			let result = history.getTransformedDelta( deltaB );
 
 			expect( result.length ).to.equal( 1 );
 			expect( result[ 0 ] ).to.equal( deltaB );
@@ -147,7 +147,7 @@ describe( 'History', () => {
 			deltaB.addOperation( new NoOperation( 1 ) );
 
 			expect( () => {
-				history.updateDelta( deltaB );
+				history.getTransformedDelta( deltaB );
 			} ).to.throw( CKEditorError, /history-wrong-version/ );
 		} );
 	} );