浏览代码

Tests: Using `model.Writer` instead of constructor in tests and docs of conversion utils.

Szymon Cofalik 7 年之前
父节点
当前提交
a2e1ae5f61

+ 3 - 9
packages/ckeditor5-engine/src/conversion/upcast-converters.js

@@ -37,19 +37,13 @@ import cloneDeep from '@ckeditor/ckeditor5-utils/src/lib/lodash/cloneDeep';
  *		} );
  *
  *		upcastElementToElement( {
- *			view: {
- *				name: 'p',
- *				class: 'fancy'
- *			},
- *			model: new ModelElement( 'p', { fancy: true } )
- *		} );
- *
- *		upcastElementToElement( {
  * 			view: {
  *				name: 'p',
  *				class: 'heading'
  * 			},
- * 			model: viewElement => new ModelElement( 'heading', { level: viewElement.getAttribute( 'data-level' ) } )
+ * 			model: ( viewElement, modelWriter ) => {
+ * 				return modelWriter.createElement( 'heading', { level: viewElement.getAttribute( 'data-level' ) } );
+ * 			}
  * 		} );
  *
  * See {@link module:engine/conversion/conversion~Conversion#for} to learn how to add converter to conversion process.

+ 3 - 19
packages/ckeditor5-engine/tests/conversion/upcast-converters.js

@@ -101,24 +101,6 @@ describe( 'upcast-helpers', () => {
 			expectResult( new ViewContainerElement( 'p', { class: 'fancy' } ), '<fancyParagraph></fancyParagraph>' );
 		} );
 
-		it( 'config.model is element instance', () => {
-			schema.extend( 'paragraph', {
-				allowAttributes: [ 'fancy' ]
-			} );
-
-			const helper = upcastElementToElement( {
-				view: {
-					name: 'p',
-					class: 'fancy'
-				},
-				model: new ModelElement( 'paragraph', { fancy: true } )
-			} );
-
-			conversion.for( 'upcast' ).add( helper );
-
-			expectResult( new ViewContainerElement( 'p', { class: 'fancy' } ), '<paragraph fancy="true"></paragraph>' );
-		} );
-
 		it( 'config.model is a function', () => {
 			schema.register( 'heading', {
 				inheritAllFrom: '$block',
@@ -130,7 +112,9 @@ describe( 'upcast-helpers', () => {
 					name: 'p',
 					class: 'heading'
 				},
-				model: viewElement => new ModelElement( 'heading', { level: viewElement.getAttribute( 'data-level' ) } )
+				model: ( viewElement, modelWriter ) => {
+					return modelWriter.createElement( 'heading', { level: viewElement.getAttribute( 'data-level' ) } );
+				}
 			} );
 
 			conversion.for( 'upcast' ).add( helper );