|
|
@@ -3,7 +3,7 @@
|
|
|
* For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
|
|
|
*/
|
|
|
|
|
|
-/* globals document */
|
|
|
+/* globals window, document */
|
|
|
|
|
|
import DeleteObserver from '../src/deleteobserver';
|
|
|
import View from '@ckeditor/ckeditor5-engine/src/view/view';
|
|
|
@@ -260,3 +260,149 @@ describe( 'DeleteObserver', () => {
|
|
|
};
|
|
|
}
|
|
|
} );
|
|
|
+
|
|
|
+describe( 'DeleteObserver - Android', () => {
|
|
|
+ let view, viewDocument, oldEnvIsAndroid, domElement, viewRoot, domText;
|
|
|
+
|
|
|
+ testUtils.createSinonSandbox();
|
|
|
+
|
|
|
+ before( () => {
|
|
|
+ oldEnvIsAndroid = env.isAndroid;
|
|
|
+ env.isAndroid = true;
|
|
|
+ } );
|
|
|
+
|
|
|
+ beforeEach( () => {
|
|
|
+ domElement = document.createElement( 'div' );
|
|
|
+ domElement.contenteditable = true;
|
|
|
+
|
|
|
+ document.body.appendChild( domElement );
|
|
|
+
|
|
|
+ view = new View();
|
|
|
+ viewDocument = view.document;
|
|
|
+ view.addObserver( DeleteObserver );
|
|
|
+
|
|
|
+ viewRoot = createViewRoot( viewDocument );
|
|
|
+ view.attachDomRoot( domElement );
|
|
|
+
|
|
|
+ view.change( writer => {
|
|
|
+ const p = writer.createContainerElement( 'p' );
|
|
|
+
|
|
|
+ writer.insert( writer.createPositionAt( viewRoot, 0 ), p );
|
|
|
+
|
|
|
+ const text = writer.createText( 'foo' );
|
|
|
+
|
|
|
+ writer.insert( writer.createPositionAt( p, 0 ), text );
|
|
|
+ } );
|
|
|
+
|
|
|
+ domText = domElement.childNodes[ 0 ].childNodes[ 0 ];
|
|
|
+ } );
|
|
|
+
|
|
|
+ afterEach( () => {
|
|
|
+ view.destroy();
|
|
|
+ domElement.remove();
|
|
|
+ } );
|
|
|
+
|
|
|
+ after( () => {
|
|
|
+ env.isAndroid = oldEnvIsAndroid;
|
|
|
+ } );
|
|
|
+
|
|
|
+ describe( 'delete event', () => {
|
|
|
+ it( 'is fired on beforeinput', () => {
|
|
|
+ const spy = sinon.spy();
|
|
|
+
|
|
|
+ viewDocument.on( 'delete', spy );
|
|
|
+
|
|
|
+ setDomSelection( domText, 1, domText, 2 );
|
|
|
+
|
|
|
+ viewDocument.fire( 'beforeinput', new DomEventData( viewDocument, getDomEvent( 'deleteContentBackward' ), {
|
|
|
+ domTarget: domElement
|
|
|
+ } ) );
|
|
|
+
|
|
|
+ expect( spy.calledOnce ).to.be.true;
|
|
|
+
|
|
|
+ const data = spy.args[ 0 ][ 1 ];
|
|
|
+ expect( data ).to.have.property( 'direction', 'backward' );
|
|
|
+ expect( data ).to.have.property( 'unit', 'codepoint' );
|
|
|
+ expect( data ).to.have.property( 'sequence', 1 );
|
|
|
+ expect( data ).not.to.have.property( 'selectionToRemove' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should set selectionToRemove if DOM selection size is different than 1', () => {
|
|
|
+ // In real scenarios, before `beforeinput` is fired, browser changes DOM selection to a selection that contains
|
|
|
+ // all content that should be deleted. If the selection is big (> 1 character) we need to pass special parameter
|
|
|
+ // so that `DeleteCommand` will know what to delete. This test checks that case.
|
|
|
+ const spy = sinon.spy();
|
|
|
+
|
|
|
+ viewDocument.on( 'delete', spy );
|
|
|
+
|
|
|
+ setDomSelection( domText, 0, domText, 3 );
|
|
|
+
|
|
|
+ viewDocument.fire( 'beforeinput', new DomEventData( viewDocument, getDomEvent( 'deleteContentBackward' ), {
|
|
|
+ domTarget: domElement
|
|
|
+ } ) );
|
|
|
+
|
|
|
+ expect( spy.calledOnce ).to.be.true;
|
|
|
+
|
|
|
+ const data = spy.args[ 0 ][ 1 ];
|
|
|
+ expect( data ).to.have.property( 'selectionToRemove' );
|
|
|
+
|
|
|
+ const viewText = viewRoot.getChild( 0 ).getChild( 0 );
|
|
|
+ const range = data.selectionToRemove.getFirstRange();
|
|
|
+
|
|
|
+ expect( range.start.offset ).to.equal( 0 );
|
|
|
+ expect( range.start.parent ).to.equal( viewText );
|
|
|
+ expect( range.end.offset ).to.equal( 3 );
|
|
|
+ expect( range.end.parent ).to.equal( viewText );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'is not fired on beforeinput when event type is other than deleteContentBackward', () => {
|
|
|
+ const spy = sinon.spy();
|
|
|
+
|
|
|
+ viewDocument.on( 'delete', spy );
|
|
|
+
|
|
|
+ viewDocument.fire( 'keydown', new DomEventData( viewDocument, getDomEvent( 'insertText' ), {
|
|
|
+ domTarget: domElement
|
|
|
+ } ) );
|
|
|
+
|
|
|
+ expect( spy.calledOnce ).to.be.false;
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should stop beforeinput event when delete event is stopped', () => {
|
|
|
+ const keydownSpy = sinon.spy();
|
|
|
+ viewDocument.on( 'beforeinput', keydownSpy );
|
|
|
+ viewDocument.on( 'delete', evt => evt.stop() );
|
|
|
+
|
|
|
+ viewDocument.fire( 'beforeinput', new DomEventData( viewDocument, getDomEvent( 'deleteContentBackward' ), {
|
|
|
+ domTarget: domElement
|
|
|
+ } ) );
|
|
|
+
|
|
|
+ sinon.assert.notCalled( keydownSpy );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should not stop keydown event when delete event is not stopped', () => {
|
|
|
+ const keydownSpy = sinon.spy();
|
|
|
+ viewDocument.on( 'beforeinput', keydownSpy );
|
|
|
+ viewDocument.on( 'delete', evt => evt.stop() );
|
|
|
+
|
|
|
+ viewDocument.fire( 'beforeinput', new DomEventData( viewDocument, getDomEvent( 'insertText' ), {
|
|
|
+ domTarget: domElement
|
|
|
+ } ) );
|
|
|
+
|
|
|
+ sinon.assert.calledOnce( keydownSpy );
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+
|
|
|
+ function getDomEvent( inputType ) {
|
|
|
+ return {
|
|
|
+ inputType,
|
|
|
+ preventDefault: sinon.spy()
|
|
|
+ };
|
|
|
+ }
|
|
|
+
|
|
|
+ function setDomSelection( anchorNode, anchorOffset, focusNode, focusOffset ) {
|
|
|
+ const selection = window.getSelection();
|
|
|
+
|
|
|
+ selection.collapse( anchorNode, anchorOffset );
|
|
|
+ selection.extend( focusNode, focusOffset );
|
|
|
+ }
|
|
|
+} );
|