Bladeren bron

Remove unit test for classes without 'is()' method.

Mateusz Samsel 6 jaren geleden
bovenliggende
commit
98ce9a952d

+ 0 - 15
packages/ckeditor5-engine/tests/view/document.js

@@ -37,21 +37,6 @@ describe( 'Document', () => {
 		} );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for "document"', () => {
-			expect( viewDocument.is( 'document' ) ).to.be.true;
-			expect( viewDocument.is( 'view:document' ) ).to.be.true;
-		} );
-
-		it( 'should return false for incorrect values', () => {
-			expect( viewDocument.is( 'model' ) ).to.be.false;
-			expect( viewDocument.is( 'model:document' ) ).to.be.false;
-			expect( viewDocument.is( 'node' ) ).to.be.false;
-			expect( viewDocument.is( 'view:node' ) ).to.be.false;
-			expect( viewDocument.is( 'element', 'text' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'getRoot()', () => {
 		it( 'should return "main" root', () => {
 			createViewRoot( viewDocument, 'div', 'main' );

+ 0 - 15
packages/ckeditor5-engine/tests/view/domconverter/domconverter.js

@@ -34,21 +34,6 @@ describe( 'DomConverter', () => {
 		} );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for "domConverter"', () => {
-			expect( converter.is( 'domConverter' ) ).to.be.true;
-			expect( converter.is( 'view:domConverter' ) ).to.be.true;
-		} );
-
-		it( 'should return false for incorrect values', () => {
-			expect( converter.is( 'view' ) ).to.be.false;
-			expect( converter.is( 'model:domConverter' ) ).to.be.false;
-			expect( converter.is( 'node' ) ).to.be.false;
-			expect( converter.is( 'view:node' ) ).to.be.false;
-			expect( converter.is( 'element', 'text' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'focus()', () => {
 		let viewEditable, domEditable, domEditableParent, viewDocument;
 

+ 0 - 23
packages/ckeditor5-engine/tests/view/downcastwriter/is.js

@@ -1,23 +0,0 @@
-import DowncastWriter from '../../../src/view/downcastwriter';
-import Document from '../../../src/view/document';
-
-describe( 'is()', () => {
-	let writer;
-
-	before( () => {
-		writer = new DowncastWriter( new Document() );
-	} );
-
-	it( 'should return true for "downcastWriter"', () => {
-		expect( writer.is( 'downcastWriter' ) ).to.be.true;
-		expect( writer.is( 'view:downcastWriter' ) ).to.be.true;
-	} );
-
-	it( 'should return false for incorrect values', () => {
-		expect( writer.is( 'view' ) ).to.be.false;
-		expect( writer.is( 'model:downcastWriter' ) ).to.be.false;
-		expect( writer.is( 'node' ) ).to.be.false;
-		expect( writer.is( 'view:node' ) ).to.be.false;
-		expect( writer.is( 'element', 'text' ) ).to.be.false;
-	} );
-} );

+ 0 - 26
packages/ckeditor5-engine/tests/view/matcher.js

@@ -442,30 +442,4 @@ describe( 'Matcher', () => {
 			expect( matcher.getElementName() ).to.be.null;
 		} );
 	} );
-
-	describe( 'is', () => {
-		let matcher;
-
-		before( () => {
-			matcher = new Matcher( 'div' );
-		} );
-
-		it( 'should return true for "matcher"', () => {
-			expect( matcher.is( 'matcher' ) ).to.be.true;
-			expect( matcher.is( 'view:matcher' ) ).to.be.true;
-		} );
-
-		it( 'should return false for other accept values', () => {
-			expect( matcher.is( 'rootElement' ) ).to.be.false;
-			expect( matcher.is( 'containerElement' ) ).to.be.false;
-			expect( matcher.is( 'element' ) ).to.be.false;
-			expect( matcher.is( 'p' ) ).to.be.false;
-			expect( matcher.is( 'text' ) ).to.be.false;
-			expect( matcher.is( 'textProxy' ) ).to.be.false;
-			expect( matcher.is( 'attributeElement' ) ).to.be.false;
-			expect( matcher.is( 'uiElement' ) ).to.be.false;
-			expect( matcher.is( 'emptyElement' ) ).to.be.false;
-			expect( matcher.is( 'documentFragment' ) ).to.be.false;
-		} );
-	} );
 } );

+ 0 - 21
packages/ckeditor5-engine/tests/view/renderer.js

@@ -41,27 +41,6 @@ describe( 'Renderer', () => {
 		renderer.domDocuments.add( document );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for "renderer"', () => {
-			expect( renderer.is( 'renderer' ) ).to.be.true;
-			expect( renderer.is( 'view:renderer' ) ).to.be.true;
-		} );
-
-		it( 'should return false for other accept values', () => {
-			expect( renderer.is( 'rootElement' ) ).to.be.false;
-			expect( renderer.is( 'containerElement' ) ).to.be.false;
-			expect( renderer.is( 'element' ) ).to.be.false;
-			expect( renderer.is( 'p' ) ).to.be.false;
-			expect( renderer.is( 'text' ) ).to.be.false;
-			expect( renderer.is( 'textProxy' ) ).to.be.false;
-			expect( renderer.is( 'attributeElement' ) ).to.be.false;
-			expect( renderer.is( 'uiElement' ) ).to.be.false;
-			expect( renderer.is( 'emptyElement' ) ).to.be.false;
-			expect( renderer.is( 'documentFragment' ) ).to.be.false;
-			expect( renderer.is( 'model:renderer' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'markToSync', () => {
 		let viewRoot;
 

+ 0 - 27
packages/ckeditor5-engine/tests/view/treewalker.js

@@ -70,33 +70,6 @@ describe( 'TreeWalker', () => {
 		} );
 	} );
 
-	describe( 'is()', () => {
-		let treeWalker;
-
-		beforeEach( () => {
-			treeWalker = new TreeWalker( { startPosition: rootBeginning } );
-		} );
-
-		it( 'should return true for "treeWalker"', () => {
-			expect( treeWalker.is( 'treeWalker' ) ).to.be.true;
-			expect( treeWalker.is( 'view:treeWalker' ) ).to.be.true;
-		} );
-
-		it( 'should return false for other accept values', () => {
-			expect( treeWalker.is( 'rootElement' ) ).to.be.false;
-			expect( treeWalker.is( 'containerElement' ) ).to.be.false;
-			expect( treeWalker.is( 'element' ) ).to.be.false;
-			expect( treeWalker.is( 'p' ) ).to.be.false;
-			expect( treeWalker.is( 'text' ) ).to.be.false;
-			expect( treeWalker.is( 'textProxy' ) ).to.be.false;
-			expect( treeWalker.is( 'attributeElement' ) ).to.be.false;
-			expect( treeWalker.is( 'uiElement' ) ).to.be.false;
-			expect( treeWalker.is( 'emptyElement' ) ).to.be.false;
-			expect( treeWalker.is( 'documentFragment' ) ).to.be.false;
-			expect( treeWalker.is( 'model:treeWalker' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'iterate from start position `startPosition`', () => {
 		let expected;
 

+ 0 - 21
packages/ckeditor5-engine/tests/view/upcastwriter.js

@@ -34,27 +34,6 @@ describe( 'UpcastWriter', () => {
 		view = dataprocessor.toView( html );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for "upcastWriter"', () => {
-			expect( writer.is( 'upcastWriter' ) ).to.be.true;
-			expect( writer.is( 'view:upcastWriter' ) ).to.be.true;
-		} );
-
-		it( 'should return false for other accept values', () => {
-			expect( writer.is( 'rootElement' ) ).to.be.false;
-			expect( writer.is( 'containerElement' ) ).to.be.false;
-			expect( writer.is( 'element' ) ).to.be.false;
-			expect( writer.is( 'p' ) ).to.be.false;
-			expect( writer.is( 'text' ) ).to.be.false;
-			expect( writer.is( 'textProxy' ) ).to.be.false;
-			expect( writer.is( 'attributeElement' ) ).to.be.false;
-			expect( writer.is( 'uiElement' ) ).to.be.false;
-			expect( writer.is( 'emptyElement' ) ).to.be.false;
-			expect( writer.is( 'documentFragment' ) ).to.be.false;
-			expect( writer.is( 'model:renderer' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'createDocumentFragment', () => {
 		it( 'should create empty document fragment', () => {
 			const df = writer.createDocumentFragment();

+ 0 - 14
packages/ckeditor5-engine/tests/view/view/view.js

@@ -488,20 +488,6 @@ describe( 'view', () => {
 		} );
 	} );
 
-	describe( 'is()', () => {
-		it( 'should return true for "view"', () => {
-			expect( view.is( 'view' ) ).to.be.true;
-		} );
-
-		it( 'should return false for incorrect values', () => {
-			expect( view.is( 'model' ) ).to.be.false;
-			expect( view.is( 'model:document' ) ).to.be.false;
-			expect( view.is( 'node' ) ).to.be.false;
-			expect( view.is( 'view:node' ) ).to.be.false;
-			expect( view.is( 'element', 'text' ) ).to.be.false;
-		} );
-	} );
-
 	describe( 'isFocused', () => {
 		it( 'should change renderer.isFocused too', () => {
 			expect( viewDocument.isFocused ).to.equal( false );